2006-07-31 [wwp] 2.4.0cvs3
[claws.git] / src / prefs_filtering.c
index aae42aa86580c9932fd790e5b4c965b8684f2072..177ce09146d82e1671b496f90a26563bff456862 100644 (file)
@@ -1,6 +1,6 @@
 /*
  * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2003 Hiroyuki Yamamoto and the Sylpheed-Claws team
+ * Copyright (C) 1999-2006 Hiroyuki Yamamoto and the Sylpheed-Claws team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -14,7 +14,7 @@
  *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  */
 
 #ifdef HAVE_CONFIG_H
@@ -24,6 +24,7 @@
 #include "defs.h"
 
 #include <glib.h>
+#include <glib/gi18n.h>
 #include <gtk/gtk.h>
 #include <gtk/gtkoptionmenu.h>
 #include <gdk/gdkkeysyms.h>
@@ -32,7 +33,6 @@
 #include <string.h>
 #include <errno.h>
 
-#include "intl.h"
 #include "main.h"
 #include "prefs_gtk.h"
 #include "prefs_matcher.h"
 #include "filtering.h"
 #include "addr_compl.h"
 #include "colorlabel.h"
+#include "manual.h"
+#include "combobox.h"
 
 #include "matcher_parser.h"
 #include "matcher.h"
 #include "prefs_filtering_action.h"
 
 enum {
+       PREFS_FILTERING_ENABLED,
+       PREFS_FILTERING_NAME,
+       PREFS_FILTERING_ACCOUNT,
        PREFS_FILTERING_RULE,
        PREFS_FILTERING_PROP,
        N_PREFS_FILTERING_COLUMNS
 };
 
-static struct Filtering {
+struct _Filtering {
        GtkWidget *window;
 
+       GtkWidget *help_btn;
        GtkWidget *ok_btn;
+       GtkWidget *name_entry;
+       GtkWidget *account_label;
+       GtkWidget *account_combobox;
+       GtkListStore *account_combobox_list;
        GtkWidget *cond_entry;
        GtkWidget *action_entry;
 
        GtkWidget *cond_list_view;
-} filtering;
+};
+
+typedef struct _Filtering Filtering;
+
+static Filtering  filtering;
 
 static GSList ** p_processing_list = NULL;
 
@@ -110,10 +124,18 @@ static void delete_path(GSList ** p_filters, const gchar * path);
 static GtkListStore* prefs_filtering_create_data_store (void);
 static gint prefs_filtering_list_view_insert_rule      (GtkListStore *list_store,
                                                         gint row,
+                                                        gboolean enabled,
+                                                        const gchar *name, 
+                                                        gint account_id,
                                                         const gchar *rule, 
                                                         gboolean prop);
 static gchar *prefs_filtering_list_view_get_rule       (GtkWidget *list, 
                                                         gint row);
+static void prefs_filtering_list_view_get_rule_name    (GtkWidget *list, 
+                                                        gint row,
+                                                        gboolean *enabled,
+                                                        gchar **name,
+                                                        gint *account_id);
 
 static GtkWidget *prefs_filtering_list_view_create     (void);
 static void prefs_filtering_create_list_view_columns   (GtkWidget *list_view);
@@ -126,10 +148,16 @@ static gboolean prefs_filtering_selected          (GtkTreeSelection *selector,
                                                         gboolean currently_selected,
                                                         gpointer data);
 
+static void prefs_filtering_account_option_menu_populate(void);
+
+static gulong signal_id = 0; /* filtering.help_btn clicked signal */
+
 void prefs_filtering_open(GSList ** p_processing,
-                         const gchar * title,
+                         const gchar *title,
+                         const gchar *help_url_anchor,
                          const gchar *header,
-                         const gchar *key)
+                         const gchar *key,
+                         gboolean per_account_filtering)
 {
        if (prefs_rc_is_readonly(FILTERING_RC))
                return;
@@ -138,6 +166,9 @@ void prefs_filtering_open(GSList ** p_processing,
 
        if (!filtering.window) {
                prefs_filtering_create();
+       } else {
+               gtk_list_store_clear(filtering.account_combobox_list);
+               prefs_filtering_account_option_menu_populate();
        }
 
        manage_window_set_transient(GTK_WINDOW(filtering.window));
@@ -148,14 +179,47 @@ void prefs_filtering_open(GSList ** p_processing,
        else
                gtk_window_set_title (GTK_WINDOW(filtering.window),
                                      _("Filtering/Processing configuration"));
-       
+
+       if (help_url_anchor != NULL) {
+               if (signal_id != 0) {
+                       g_signal_handler_disconnect(
+                                       G_OBJECT(filtering.help_btn),
+                                       signal_id);
+               }
+
+               signal_id = g_signal_connect(G_OBJECT(filtering.help_btn),
+                               "clicked",
+                               G_CALLBACK(manual_open_with_anchor_cb),
+                               (gchar*)help_url_anchor);
+       }
+       else {
+               gtk_widget_set_sensitive(filtering.help_btn, FALSE);
+       }
+
         p_processing_list = p_processing;
         
        prefs_filtering_set_dialog(header, key);
+       if (per_account_filtering) {
+               gtk_widget_show(filtering.account_label);
+               gtk_widget_show(filtering.account_combobox);
+       } else {
+               gtk_widget_hide(filtering.account_label);
+               gtk_widget_hide(filtering.account_combobox);
+               combobox_select_by_data(GTK_COMBO_BOX(filtering.account_combobox), 0);
+       }
 
        gtk_widget_show(filtering.window);
 
-       start_address_completion();
+       start_address_completion(NULL);
+}
+
+static void prefs_filtering_size_allocate_cb(GtkWidget *widget,
+                                        GtkAllocation *allocation)
+{
+       g_return_if_fail(allocation != NULL);
+
+       prefs_common.filteringwin_width = allocation->width;
+       prefs_common.filteringwin_height = allocation->height;
 }
 
 /* prefs_filtering_close() - just to have one common exit point */
@@ -167,20 +231,59 @@ static void prefs_filtering_close(void)
        inc_unlock();
 }
 
+static void prefs_filtering_account_option_menu_populate(void)
+{
+       GList *accounts = NULL;
+       GtkTreeIter iter;
+
+       accounts = account_get_list();
+
+       g_return_val_if_fail(accounts != NULL, NULL);
+
+       COMBOBOX_ADD(filtering.account_combobox_list, _("All"), 0);
+       for (; accounts != NULL; accounts = accounts->next) {
+               PrefsAccount *ac = (PrefsAccount *)accounts->data;
+
+               COMBOBOX_ADD(filtering.account_combobox_list, ac->account_name, ac->account_id);
+       }
+}
+
+static GtkWidget *prefs_filtering_account_option_menu(Filtering *filtering)
+{
+       GtkWidget *optmenu = NULL;
+       GtkWidget *optmenubox = NULL;
+       GtkListStore *menu = NULL;
+       
+       optmenubox = gtk_event_box_new();
+       optmenu = gtkut_sc_combobox_create(optmenubox, FALSE);
+       menu = GTK_LIST_STORE(gtk_combo_box_get_model(GTK_COMBO_BOX(optmenu)));
+
+       filtering->account_combobox = optmenu;
+       filtering->account_combobox_list = menu;
+
+       prefs_filtering_account_option_menu_populate();
+
+       return optmenubox;
+}
+
 static void prefs_filtering_create(void)
 {
        GtkWidget *window;
        GtkWidget *vbox;
-       GtkWidget *ok_btn;
+       GtkWidget *help_btn;
        GtkWidget *cancel_btn;
+       GtkWidget *ok_btn;
        GtkWidget *confirm_area;
 
        GtkWidget *vbox1;
-       GtkWidget *hbox1;
        GtkWidget *reg_hbox;
        GtkWidget *arrow;
        GtkWidget *btn_hbox;
 
+       GtkWidget *name_label;
+       GtkWidget *name_entry;
+       GtkWidget *account_label;
+       GtkWidget *account_opt_menu;
        GtkWidget *cond_label;
        GtkWidget *cond_entry;
        GtkWidget *cond_btn;
@@ -202,8 +305,8 @@ static void prefs_filtering_create(void)
        GtkWidget *up_btn;
        GtkWidget *down_btn;
        GtkWidget *bottom_btn;
-
-       gchar *title[1];
+       GtkWidget *table;
+       static GdkGeometry geometry;
 
        debug_print("Creating filtering configuration window...\n");
 
@@ -217,8 +320,10 @@ static void prefs_filtering_create(void)
        gtk_widget_show (vbox);
        gtk_container_add (GTK_CONTAINER (window), vbox);
 
-       gtkut_button_set_create_stock(&confirm_area, &ok_btn, GTK_STOCK_OK,
-                                     &cancel_btn, GTK_STOCK_CANCEL, NULL, NULL);
+       gtkut_stock_button_set_create_with_help(&confirm_area, &help_btn,
+                       &cancel_btn, GTK_STOCK_CANCEL,
+                       &ok_btn, GTK_STOCK_OK,
+                       NULL, NULL);
        gtk_widget_show (confirm_area);
        gtk_box_pack_end (GTK_BOX(vbox), confirm_area, FALSE, FALSE, 0);
        gtk_widget_grab_default (ok_btn);
@@ -228,6 +333,8 @@ static void prefs_filtering_create(void)
 
        g_signal_connect(G_OBJECT(window), "delete_event",
                         G_CALLBACK(prefs_filtering_deleted), NULL);
+       g_signal_connect(G_OBJECT(window), "size_allocate",
+                        G_CALLBACK(prefs_filtering_size_allocate_cb), NULL);
        g_signal_connect(G_OBJECT(window), "key_press_event",
                         G_CALLBACK(prefs_filtering_key_pressed), NULL);
        MANAGE_WINDOW_SIGNALS_CONNECT (window);
@@ -238,53 +345,86 @@ static void prefs_filtering_create(void)
 
        vbox1 = gtk_vbox_new (FALSE, VSPACING);
        gtk_widget_show (vbox1);
-       gtk_box_pack_start (GTK_BOX (vbox), vbox1, TRUE, TRUE, 0);
+       gtk_box_pack_start (GTK_BOX (vbox), vbox1, FALSE, TRUE, 0);
        gtk_container_set_border_width (GTK_CONTAINER (vbox1), 2);
 
-       cond_label = gtk_label_new (_("Condition"));
-       gtk_widget_show (cond_label);
-       gtk_misc_set_alignment (GTK_MISC (cond_label), 0, 0.5);
-       gtk_box_pack_start (GTK_BOX (vbox1), cond_label, FALSE, FALSE, 0);
+       table = gtk_table_new(3, 4, FALSE);
+       gtk_widget_show(table);
+       gtk_box_pack_start (GTK_BOX (vbox1), table, TRUE, TRUE, 0);
+       
 
-       hbox1 = gtk_hbox_new (FALSE, VSPACING);
-       gtk_widget_show (hbox1);
-       gtk_box_pack_start (GTK_BOX (vbox1), hbox1, FALSE, FALSE, 0);
-       gtk_container_set_border_width (GTK_CONTAINER (vbox1), 2);
+       name_label = gtk_label_new (_("Name: "));
+       gtk_widget_show (name_label);
+       gtk_misc_set_alignment (GTK_MISC (name_label), 1, 0.5);
+       gtk_table_attach (GTK_TABLE (table), name_label, 0, 1, 0, 1,
+                         (GtkAttachOptions) (GTK_FILL),
+                         (GtkAttachOptions) (0), 0, 0);
+
+       name_entry = gtk_entry_new ();
+       gtk_widget_show (name_entry);
+       gtk_table_attach (GTK_TABLE (table), name_entry, 1, 2, 0, 1,
+                         (GtkAttachOptions) (GTK_FILL|GTK_EXPAND),
+                         (GtkAttachOptions) (0), 0, 0);
+
+       account_label = gtk_label_new (_("Account:"));
+       gtk_widget_show (account_label);
+       gtk_misc_set_alignment (GTK_MISC (account_label), 1, 0.5);
+       gtk_table_attach (GTK_TABLE (table), account_label, 0, 1, 1, 2,
+                         (GtkAttachOptions) (GTK_FILL),
+                         (GtkAttachOptions) (0), 0, 0);
+
+       account_opt_menu = prefs_filtering_account_option_menu(&filtering);
+       gtk_widget_show (account_opt_menu);
+       gtk_table_attach (GTK_TABLE (table), account_opt_menu, 1, 2, 1, 2,
+                         (GtkAttachOptions) (GTK_FILL|GTK_EXPAND),
+                         (GtkAttachOptions) (0), 0, 0);
+       combobox_select_by_data(GTK_COMBO_BOX(filtering.account_combobox), 0);
+
+       cond_label = gtk_label_new (_("Condition: "));
+       gtk_widget_show (cond_label);
+       gtk_misc_set_alignment (GTK_MISC (cond_label), 1, 0.5);
+       gtk_table_attach (GTK_TABLE (table), cond_label, 0, 1, 2, 3,
+                         (GtkAttachOptions) (GTK_FILL),
+                         (GtkAttachOptions) (0), 0, 0);
 
        cond_entry = gtk_entry_new ();
        gtk_widget_show (cond_entry);
-       gtk_box_pack_start (GTK_BOX (hbox1), cond_entry, TRUE, TRUE, 0);
+       gtk_table_attach (GTK_TABLE (table), cond_entry, 1, 2, 2, 3,
+                         (GtkAttachOptions) (GTK_FILL|GTK_EXPAND),
+                         (GtkAttachOptions) (0), 0, 0);
 
-       cond_btn = gtk_button_new_with_label (_("Define ..."));
+       cond_btn = gtk_button_new_with_label (_(" Define... "));
        gtk_widget_show (cond_btn);
-       gtk_box_pack_start (GTK_BOX (hbox1), cond_btn, FALSE, FALSE, 0);
+       gtk_table_attach (GTK_TABLE (table), cond_btn, 2, 3, 2, 3,
+                         (GtkAttachOptions) (GTK_FILL),
+                         (GtkAttachOptions) (0), 2, 2);
        g_signal_connect(G_OBJECT (cond_btn), "clicked",
                         G_CALLBACK(prefs_filtering_condition_define),
                         NULL);
 
-       action_label = gtk_label_new (_("Action"));
+       action_label = gtk_label_new (_("Action"));
        gtk_widget_show (action_label);
-       gtk_misc_set_alignment (GTK_MISC (action_label), 0, 0.5);
-       gtk_box_pack_start (GTK_BOX (vbox1), action_label, FALSE, FALSE, 0);
-
-       hbox1 = gtk_hbox_new (FALSE, VSPACING);
-       gtk_widget_show (hbox1);
-       gtk_box_pack_start (GTK_BOX (vbox1), hbox1, FALSE, FALSE, 0);
-       gtk_container_set_border_width (GTK_CONTAINER (vbox1), 2);
+       gtk_misc_set_alignment (GTK_MISC (action_label), 1, 0.5);
+       gtk_table_attach (GTK_TABLE (table), action_label, 0, 1, 3, 4,
+                         (GtkAttachOptions) (GTK_FILL),
+                         (GtkAttachOptions) (0), 0, 0);
 
        action_entry = gtk_entry_new ();
        gtk_widget_show (action_entry);
-       gtk_box_pack_start (GTK_BOX (hbox1), action_entry, TRUE, TRUE, 0);
+       gtk_table_attach (GTK_TABLE (table), action_entry, 1, 2, 3, 4,
+                         (GtkAttachOptions) (GTK_FILL|GTK_EXPAND),
+                         (GtkAttachOptions) (0), 0, 0);
 
-       action_btn = gtk_button_new_with_label (_("Define ..."));
+       action_btn = gtk_button_new_with_label (_(" Define... "));
        gtk_widget_show (action_btn);
-       gtk_box_pack_start (GTK_BOX (hbox1), action_btn, FALSE, FALSE, 0);
+       gtk_table_attach (GTK_TABLE (table), action_btn, 2, 3, 3, 4,
+                         (GtkAttachOptions) (GTK_FILL),
+                         (GtkAttachOptions) (0), 2, 2);
        g_signal_connect(G_OBJECT (action_btn), "clicked",
                         G_CALLBACK(prefs_filtering_action_define),
                         NULL);
-
+                        
        /* register / substitute / delete */
-
        reg_hbox = gtk_hbox_new (FALSE, 4);
        gtk_widget_show (reg_hbox);
        gtk_box_pack_start (GTK_BOX (vbox1), reg_hbox, FALSE, FALSE, 0);
@@ -292,7 +432,7 @@ static void prefs_filtering_create(void)
        arrow = gtk_arrow_new (GTK_ARROW_DOWN, GTK_SHADOW_OUT);
        gtk_widget_show (arrow);
        gtk_box_pack_start (GTK_BOX (reg_hbox), arrow, FALSE, FALSE, 0);
-       gtk_widget_set_usize (arrow, -1, 16);
+       gtk_widget_set_size_request (arrow, -1, 16);
 
        btn_hbox = gtk_hbox_new (TRUE, 4);
        gtk_widget_show (btn_hbox);
@@ -304,14 +444,14 @@ static void prefs_filtering_create(void)
        g_signal_connect(G_OBJECT (reg_btn), "clicked",
                         G_CALLBACK(prefs_filtering_register_cb), NULL);
 
-       subst_btn = gtk_button_new_with_label (_("  Replace  "));
+       subst_btn = gtkut_get_replace_btn (_("Replace"));
        gtk_widget_show (subst_btn);
        gtk_box_pack_start (GTK_BOX (btn_hbox), subst_btn, FALSE, TRUE, 0);
        g_signal_connect(G_OBJECT (subst_btn), "clicked",
                         G_CALLBACK(prefs_filtering_substitute_cb),
                         NULL);
 
-       del_btn = gtk_button_new_from_stock (GTK_STOCK_REMOVE);
+       del_btn = gtk_button_new_from_stock (GTK_STOCK_DELETE);
        gtk_widget_show (del_btn);
        gtk_box_pack_start (GTK_BOX (btn_hbox), del_btn, FALSE, TRUE, 0);
        g_signal_connect(G_OBJECT (del_btn), "clicked",
@@ -319,11 +459,11 @@ static void prefs_filtering_create(void)
 
        cond_hbox = gtk_hbox_new (FALSE, 8);
        gtk_widget_show (cond_hbox);
-       gtk_box_pack_start (GTK_BOX (vbox1), cond_hbox, TRUE, TRUE, 0);
+       gtk_box_pack_start (GTK_BOX (vbox), cond_hbox, TRUE, TRUE, 0);
 
        cond_scrolledwin = gtk_scrolled_window_new (NULL, NULL);
        gtk_widget_show (cond_scrolledwin);
-       gtk_widget_set_usize (cond_scrolledwin, -1, 150);
+       gtk_widget_set_size_request (cond_scrolledwin, -1, 150);
        gtk_box_pack_start (GTK_BOX (cond_hbox), cond_scrolledwin,
                            TRUE, TRUE, 0);
        gtk_scrolled_window_set_policy (GTK_SCROLLED_WINDOW (cond_scrolledwin),
@@ -366,16 +506,27 @@ static void prefs_filtering_create(void)
        g_signal_connect(G_OBJECT (bottom_btn), "clicked",
                         G_CALLBACK(prefs_filtering_bottom), NULL);
 
-       gtk_widget_set_usize(window, 500, -1);
+       if (!geometry.min_height) {
+               geometry.min_width = 500;
+               geometry.min_height = 400;
+       }
+
+       gtk_window_set_geometry_hints(GTK_WINDOW(window), NULL, &geometry,
+                                     GDK_HINT_MIN_SIZE);
+       gtk_widget_set_size_request(window, prefs_common.filteringwin_width,
+                                   prefs_common.filteringwin_height);
 
        gtk_widget_show_all(window);
 
        filtering.window    = window;
+       filtering.help_btn = help_btn;
        filtering.ok_btn = ok_btn;
 
+       filtering.name_entry     = name_entry;
        filtering.cond_entry     = cond_entry;
        filtering.action_entry   = action_entry;
        filtering.cond_list_view = cond_list_view;
+       filtering.account_label  = account_label;
 }
 
 static void rename_path(GSList * filters,
@@ -592,7 +743,6 @@ static void prefs_filtering_set_dialog(const gchar *header, const gchar *key)
        GSList *cur;
        GSList * prefs_filtering;
        gchar *cond_str;
-       gint row;
        GtkListStore *list_store;
        
        list_store = GTK_LIST_STORE(gtk_tree_view_get_model(list_view));
@@ -600,6 +750,9 @@ static void prefs_filtering_set_dialog(const gchar *header, const gchar *key)
 
        /* add the place holder (New) at row 0 */
        prefs_filtering_list_view_insert_rule(list_store, -1, 
+                                             FALSE,
+                                             _("(New)"),
+                                                 0,
                                              _("(New)"),
                                              FALSE);
 
@@ -612,6 +765,9 @@ static void prefs_filtering_set_dialog(const gchar *header, const gchar *key)
                subst_char(cond_str, '\t', ':');
 
                prefs_filtering_list_view_insert_rule(list_store, -1, 
+                                                     prop->enabled,
+                                                     prop->name,
+                                                         prop->account_id,
                                                      cond_str, TRUE);
                
                g_free(cond_str);
@@ -636,6 +792,8 @@ static void prefs_filtering_set_dialog(const gchar *header, const gchar *key)
 
 static void prefs_filtering_reset_dialog(void)
 {
+       gtk_entry_set_text(GTK_ENTRY(filtering.name_entry), "");
+       combobox_select_by_data(GTK_COMBO_BOX(filtering.account_combobox), 0);
        gtk_entry_set_text(GTK_ENTRY(filtering.cond_entry), "");
        gtk_entry_set_text(GTK_ENTRY(filtering.action_entry), "");
 }
@@ -660,11 +818,22 @@ static void prefs_filtering_set_list(void)
                /* FIXME: this strcmp() is bogus: "(New)" should never
                 * be inserted in the storage */
                if (strcmp(filtering_str, _("(New)")) != 0) {
+                       gboolean enabled;
+                       gchar *name;
+                       gint account_id = 0;
+
+                       prefs_filtering_list_view_get_rule_name(
+                                       filtering.cond_list_view, row,
+                                       &enabled, &name, &account_id);
                        prop = matcher_parser_get_filtering(filtering_str);
                        g_free(filtering_str);
-                       if (prop) 
+                       if (prop) {
+                               prop->enabled = enabled;
+                               prop->name = name;
+                               prop->account_id = account_id;
                                prefs_filtering = 
                                        g_slist_append(prefs_filtering, prop);
+                       }
                }
                
                row++;
@@ -678,14 +847,29 @@ static gint prefs_filtering_list_view_set_row(gint row, FilteringProp * prop)
        GtkTreeView *list_view = GTK_TREE_VIEW(filtering.cond_list_view);
        gchar *str;
        GtkListStore *list_store;
+       gchar *name = NULL;
+       gint account_id = 0;
+       gboolean enabled = TRUE;
 
        str = filteringprop_to_string(prop);
        if (str == NULL)
                return -1;
 
+       if (prop) {
+               if (prop->name)
+                       name = prop->name;
+               account_id = prop->account_id;
+               enabled = prop->enabled;
+       }
+
        list_store = GTK_LIST_STORE(gtk_tree_view_get_model(list_view));
 
-       row = prefs_filtering_list_view_insert_rule(list_store, row, str, prop != NULL);
+       row = prefs_filtering_list_view_insert_rule(list_store, row,
+                                                   enabled,
+                                                   name,
+                                                   account_id,
+                                                   str,
+                                                   prop != NULL);
 
        g_free(str);
 
@@ -776,11 +960,18 @@ static void prefs_filtering_action_define(void)
 static FilteringProp * prefs_filtering_dialog_to_filtering(gboolean alert)
 {
        MatcherList * cond;
+       gboolean enabled = TRUE;
+       gchar * name = NULL;
+       gint account_id = 0;
        gchar * cond_str = NULL;
        gchar * action_str = NULL;
        FilteringProp * prop = NULL;
        GSList * action_list;
 
+       name = gtk_editable_get_chars(GTK_EDITABLE(filtering.name_entry), 0, -1);
+       
+       account_id = combobox_get_active_data(GTK_COMBO_BOX(filtering.account_combobox));
+
        cond_str = gtk_editable_get_chars(GTK_EDITABLE(filtering.cond_entry), 0, -1);
        if (*cond_str == '\0') {
                if(alert == TRUE) alertpanel_error(_("Condition string is empty."));
@@ -808,9 +999,10 @@ static FilteringProp * prefs_filtering_dialog_to_filtering(gboolean alert)
                goto fail;
        }
 
-       prop = filteringprop_new(cond, action_list);
+       prop = filteringprop_new(enabled, name, account_id, cond, action_list);
 
 fail:
+       g_free(name);
        g_free(cond_str);
        g_free(action_str);
        return prop;
@@ -826,6 +1018,8 @@ static void prefs_filtering_register_cb(void)
        prefs_filtering_list_view_set_row(-1, prop);
        
        filteringprop_free(prop);
+
+       prefs_filtering_reset_dialog();
 }
 
 static void prefs_filtering_substitute_cb(void)
@@ -843,6 +1037,8 @@ static void prefs_filtering_substitute_cb(void)
        prefs_filtering_list_view_set_row(selected_row, prop);
 
        filteringprop_free(prop);
+
+       prefs_filtering_reset_dialog();
 }
 
 static void prefs_filtering_delete_cb(void)
@@ -858,7 +1054,7 @@ static void prefs_filtering_delete_cb(void)
 
        if (alertpanel(_("Delete rule"),
                       _("Do you really want to delete this rule?"),
-                      _("Yes"), _("No"), NULL) == G_ALERTALTERNATE)
+                      GTK_STOCK_CANCEL, "+"GTK_STOCK_DELETE, NULL) == G_ALERTDEFAULT)
                return;
 
        model = gtk_tree_view_get_model(list_view);     
@@ -961,7 +1157,12 @@ static void prefs_filtering_select_set(FilteringProp *prop)
        if (matcher_str == NULL) {
                return;
        }
+       
+       if (prop->name != NULL)
+               gtk_entry_set_text(GTK_ENTRY(filtering.name_entry), prop->name);
 
+       combobox_select_by_data(GTK_COMBO_BOX(filtering.account_combobox), prop->account_id);
+               
        gtk_entry_set_text(GTK_ENTRY(filtering.cond_entry), matcher_str);
 
         action_str = filteringaction_list_to_string(prop->action_list);
@@ -1015,7 +1216,7 @@ static void prefs_filtering_ok(void)
                if (!filtering_str) {
                        val = alertpanel(_("Entry not saved"),
                                 _("The entry was not saved. Close anyway?"),
-                                _("Yes"), _("No"), NULL);
+                                GTK_STOCK_CLOSE, _("+_Continue editing"), NULL);
                        if (G_ALERTDEFAULT != val) {
                                g_free(filtering_str);
                                g_free(str); /* fixed two leaks: huzzah! */
@@ -1027,6 +1228,27 @@ static void prefs_filtering_ok(void)
                g_free(filtering_str);
                g_free(str);
                filteringprop_free(prop); /* fixed a leak: huzzah! */
+       } else {
+               gchar *name, *condition, *action;
+               name = gtk_editable_get_chars(GTK_EDITABLE(filtering.name_entry), 0, -1);
+               condition = gtk_editable_get_chars(GTK_EDITABLE(filtering.cond_entry), 0, -1);
+               action = gtk_editable_get_chars(GTK_EDITABLE(filtering.action_entry), 0, -1);
+               if (strlen(name) || 
+                   strlen(condition) || 
+                   strlen(action)) {
+                       val = alertpanel(_("Entry not saved"),
+                                _("The entry was not saved. Close anyway?"),
+                                GTK_STOCK_CLOSE, _("+_Continue editing"), NULL);
+                       if (G_ALERTDEFAULT != val) {
+                               g_free(name);
+                               g_free(condition);
+                               g_free(action);
+                               return;
+                       }
+               }
+               g_free(name);
+               g_free(condition);
+               g_free(action);
        }
        prefs_filtering_set_list();
        prefs_matcher_write_config();
@@ -1042,6 +1264,9 @@ static void prefs_filtering_cancel(void)
 static GtkListStore* prefs_filtering_create_data_store(void)
 {
        return gtk_list_store_new(N_PREFS_FILTERING_COLUMNS,
+                                 G_TYPE_BOOLEAN,
+                                 G_TYPE_STRING,
+                                 G_TYPE_INT,
                                  G_TYPE_STRING,
                                  G_TYPE_BOOLEAN,
                                 -1);
@@ -1055,6 +1280,9 @@ static GtkListStore* prefs_filtering_create_data_store(void)
  *\param       list_store Store to operate on
  *\param       row -1 to add a new rule to store, else change an existing
  *             row
+ *\param       enabled TRUE if rule is enabled
+ *\param       name The Name of rule
+ *\param       account_id The account ID
  *\param       rule String representation of rule
  *\param       prop TRUE if valid filtering rule; if FALSE it's the first
  *             entry in the store ("(New)").
@@ -1063,6 +1291,9 @@ static GtkListStore* prefs_filtering_create_data_store(void)
  */
 static gint prefs_filtering_list_view_insert_rule(GtkListStore *list_store,
                                                  gint row,
+                                                 gboolean enabled,
+                                                 const gchar *name,
+                                                 gint account_id,
                                                  const gchar *rule,
                                                  gboolean prop) 
 {
@@ -1079,6 +1310,9 @@ static gint prefs_filtering_list_view_insert_rule(GtkListStore *list_store,
                /* append new */
                gtk_list_store_append(list_store, &iter);
                gtk_list_store_set(list_store, &iter, 
+                                  PREFS_FILTERING_ENABLED, enabled,
+                                  PREFS_FILTERING_NAME, name,
+                                  PREFS_FILTERING_ACCOUNT, account_id,
                                   PREFS_FILTERING_RULE, rule,
                                   PREFS_FILTERING_PROP, prop,
                                   -1);
@@ -1087,6 +1321,9 @@ static gint prefs_filtering_list_view_insert_rule(GtkListStore *list_store,
        } else {
                /* change existing */
                gtk_list_store_set(list_store, &iter, 
+                                  PREFS_FILTERING_ENABLED, enabled,
+                                  PREFS_FILTERING_NAME, name,
+                                  PREFS_FILTERING_ACCOUNT, account_id,
                                   PREFS_FILTERING_RULE, rule,
                                   -1);
                return row;                                
@@ -1113,6 +1350,25 @@ static gchar *prefs_filtering_list_view_get_rule(GtkWidget *list, gint row)
        return result;
 }
 
+static void prefs_filtering_list_view_get_rule_name(GtkWidget *list, gint row,
+                               gboolean *enabled, gchar **name, gint *account_id)
+{      
+       GtkTreeView *list_view = GTK_TREE_VIEW(list);
+       GtkTreeModel *model = gtk_tree_view_get_model(list_view);
+       GtkTreeIter iter;
+
+       *enabled = TRUE;
+       *name = NULL;
+
+       if (gtk_tree_model_iter_nth_child(model, &iter, NULL, row)) {
+               gtk_tree_model_get(model, &iter, 
+                                  PREFS_FILTERING_ENABLED, enabled,
+                                  PREFS_FILTERING_NAME, name,
+                                  PREFS_FILTERING_ACCOUNT, account_id,
+                                  -1);
+       }
+}
+
 /*!
  *\brief       Create list view for filtering
  */
@@ -1124,7 +1380,8 @@ static GtkWidget *prefs_filtering_list_view_create(void)
        list_view = GTK_TREE_VIEW(gtk_tree_view_new_with_model(GTK_TREE_MODEL
                (prefs_filtering_create_data_store())));
        
-       gtk_tree_view_set_rules_hint(list_view, TRUE);
+       gtk_tree_view_set_rules_hint(list_view, prefs_common.enable_rules_hint);
+       gtk_tree_view_set_reorderable(list_view, TRUE);
        
        selector = gtk_tree_view_get_selection(list_view);
        gtk_tree_selection_set_mode(selector, GTK_SELECTION_BROWSE);
@@ -1137,14 +1394,58 @@ static GtkWidget *prefs_filtering_list_view_create(void)
        return GTK_WIDGET(list_view);
 }
 
+static void prefs_filtering_enable_toggled(GtkCellRendererToggle *widget,
+               gchar *path,
+               GtkWidget *list_view)
+{
+       GtkTreeIter iter;
+       GtkTreeModel *model = gtk_tree_view_get_model(GTK_TREE_VIEW(list_view));
+       gboolean enabled = TRUE;
+
+       if (!gtk_tree_model_get_iter_from_string(model, &iter, path))
+               return;
+
+       gtk_tree_model_get(model, &iter,
+                          PREFS_FILTERING_ENABLED, &enabled,
+                          -1);
+
+       gtk_list_store_set(GTK_LIST_STORE(model), &iter,
+                          PREFS_FILTERING_ENABLED, !enabled,
+                          -1);
+}
+
 static void prefs_filtering_create_list_view_columns(GtkWidget *list_view)
 {
        GtkTreeViewColumn *column;
        GtkCellRenderer *renderer;
 
+       renderer = gtk_cell_renderer_toggle_new();
+       g_object_set(renderer,
+                    "radio", FALSE,
+                    "activatable", TRUE,
+                    NULL);
+       column = gtk_tree_view_column_new_with_attributes
+               (_("Enable"), /* FIXME : Enable, Enabled, or 'E' ? */
+                renderer,
+                "active", PREFS_FILTERING_ENABLED,
+                NULL);
+       gtk_tree_view_append_column(GTK_TREE_VIEW(list_view), column);
+       g_signal_connect(G_OBJECT(renderer), "toggled",
+                        G_CALLBACK(prefs_filtering_enable_toggled),
+                        list_view);
+
        renderer = gtk_cell_renderer_text_new();
        column = gtk_tree_view_column_new_with_attributes
-               (_("Current filtering/processing rules"),
+               (_("Name"),
+                renderer,
+                "text", PREFS_FILTERING_NAME,
+                NULL);
+       gtk_tree_view_append_column(GTK_TREE_VIEW(list_view), column);
+       gtk_tree_view_column_set_resizable(column, TRUE);
+               
+       renderer = gtk_cell_renderer_text_new();
+       column = gtk_tree_view_column_new_with_attributes
+               (_("Rule"),
                 renderer,
                 "text", PREFS_FILTERING_RULE,
                 NULL);
@@ -1241,17 +1542,30 @@ static gboolean prefs_filtering_selected(GtkTreeSelection *selector,
                if (has_prop) {
                        FilteringProp *prop;
                        gchar *filtering_str = NULL;
-                       
+                       gchar *name = NULL;
+                       gint account_id = 0;
+
                        gtk_tree_model_get(model, &iter,
                                           PREFS_FILTERING_RULE, &filtering_str,
                                           -1);
+                       gtk_tree_model_get(model, &iter,
+                                          PREFS_FILTERING_NAME, &name,
+                                          -1);
+                       gtk_tree_model_get(model, &iter,
+                                          PREFS_FILTERING_ACCOUNT, &account_id,
+                                          -1);
+                       gtk_tree_model_get(model, &iter,
+                                          PREFS_FILTERING_ACCOUNT, &account_id,
+                                          -1);
 
                        prop = matcher_parser_get_filtering(filtering_str);
                        if (prop) { 
+                               prop->name = g_strdup(name);
+                               prop->account_id = account_id;
                                prefs_filtering_select_set(prop);
                                filteringprop_free(prop);
                        }                               
-                       
+                       g_free(name);
                        g_free(filtering_str);
                } else
                        prefs_filtering_reset_dialog();