fix bug 4239, 'Preferences: Text Options Header Display modal is not modal' (sic)
[claws.git] / src / prefs_customheader.c
index 34a9e0865a383a8a906f63eae5774186a3f84a0c..c60328bfba4f11f1c63efebce36445757316e228 100644 (file)
@@ -1,10 +1,10 @@
 /*
  * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2006 Hiroyuki Yamamoto and the Sylpheed-Claws team
+ * Copyright (C) 1999-2012 Hiroyuki Yamamoto and the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
+ * the Free Software Foundation; either version 3 of the License, or
  * (at your option) any later version.
  *
  * This program is distributed in the hope that it will be useful,
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ * 
  */
 
 #ifdef HAVE_CONFIG_H
 #  include "config.h"
+#include "claws-features.h"
 #endif
 
 #include "defs.h"
@@ -45,8 +46,9 @@
 #include "utils.h"
 #include "gtkutils.h"
 #include "alertpanel.h"
-#include "base64.h"
 #include "filesel.h"
+#include "combobox.h"
+#include "file-utils.h"
 
 enum {
        CUSTHDR_STRING,         /*!< display string managed by list store */
@@ -63,6 +65,7 @@ static struct CustomHdr {
        GtkWidget *hdr_combo;
        GtkWidget *hdr_entry;
        GtkWidget *val_entry;
+       GtkWidget *preview;
        GtkWidget *list_view;
 } customhdr;
 
@@ -123,6 +126,7 @@ void prefs_custom_header_open(PrefsAccount *ac)
        cur_ac = ac;
 
        gtk_widget_show(customhdr.window);
+       gtk_window_set_modal(GTK_WINDOW(customhdr.window), TRUE);
 }
 
 static void prefs_custom_header_create(void)
@@ -149,6 +153,7 @@ static void prefs_custom_header_create(void)
        GtkWidget *arrow;
        GtkWidget *add_btn;
        GtkWidget *del_btn;
+       GtkWidget *preview;
 
        GtkWidget *ch_hbox;
        GtkWidget *ch_scrolledwin;
@@ -160,11 +165,11 @@ static void prefs_custom_header_create(void)
 
        debug_print("Creating custom header setting window...\n");
 
-       window = gtk_window_new (GTK_WINDOW_TOPLEVEL);
+       window = gtkut_window_new(GTK_WINDOW_TOPLEVEL, "prefs_customheader");
        gtk_container_set_border_width (GTK_CONTAINER (window), 8);
        gtk_window_set_position (GTK_WINDOW (window), GTK_WIN_POS_CENTER);
-       gtk_window_set_modal (GTK_WINDOW (window), TRUE);
        gtk_window_set_resizable(GTK_WINDOW (window), TRUE);
+       gtk_window_set_type_hint(GTK_WINDOW(window), GDK_WINDOW_TYPE_HINT_DIALOG);
 
        vbox = gtk_vbox_new (FALSE, 6);
        gtk_widget_show (vbox);
@@ -209,15 +214,11 @@ static void prefs_custom_header_create(void)
                          0, 0, 0);
        gtk_misc_set_alignment (GTK_MISC (hdr_label), 0, 0.5);
        
-       hdr_combo = gtk_combo_new ();
-       gtk_widget_show (hdr_combo);
+       hdr_combo = combobox_text_new(TRUE, "User-Agent", "Face", "X-Face",
+                                     "X-Operating-System", NULL);
        gtk_table_attach (GTK_TABLE (table1), hdr_combo, 0, 1, 1, 2,
                          GTK_EXPAND | GTK_SHRINK | GTK_FILL,
                          0, 0, 0);
-       gtk_widget_set_size_request (hdr_combo, 150, -1);
-       gtkut_combo_set_items (GTK_COMBO (hdr_combo),
-                              "User-Agent", "Face", "X-Face", "X-Operating-System",
-                              NULL);
 
        val_label = gtk_label_new (_("Value"));
        gtk_widget_show (val_label);
@@ -231,9 +232,8 @@ static void prefs_custom_header_create(void)
        gtk_table_attach (GTK_TABLE (table1), val_entry, 1, 2, 1, 2,
                          GTK_EXPAND | GTK_SHRINK | GTK_FILL,
                          0, 0, 0);
-       gtk_widget_set_size_request (val_entry, 200, -1);
 
-       val_btn = gtk_button_new_with_label (_("From file..."));
+       val_btn = gtkut_get_browse_file_btn(_("Bro_wse"));
        gtk_widget_show (val_btn);
        gtk_table_attach (GTK_TABLE (table1), val_btn, 2, 3, 1, 2,
                          GTK_EXPAND | GTK_SHRINK | GTK_FILL,
@@ -251,7 +251,6 @@ static void prefs_custom_header_create(void)
        arrow = gtk_arrow_new (GTK_ARROW_DOWN, GTK_SHADOW_OUT);
        gtk_widget_show (arrow);
        gtk_box_pack_start (GTK_BOX (reg_hbox), arrow, FALSE, FALSE, 0);
-       gtk_widget_set_size_request (arrow, -1, 16);
 
        btn_hbox = gtk_hbox_new (TRUE, 4);
        gtk_widget_show (btn_hbox);
@@ -277,7 +276,6 @@ static void prefs_custom_header_create(void)
        gtk_box_pack_start (GTK_BOX (vbox1), ch_hbox, TRUE, TRUE, 0);
 
        ch_scrolledwin = gtk_scrolled_window_new (NULL, NULL);
-       gtk_widget_set_size_request (ch_scrolledwin, -1, 200);
        gtk_widget_show (ch_scrolledwin);
        gtk_box_pack_start (GTK_BOX (ch_hbox), ch_scrolledwin, TRUE, TRUE, 0);
        gtk_scrolled_window_set_policy (GTK_SCROLLED_WINDOW (ch_scrolledwin),
@@ -304,14 +302,19 @@ static void prefs_custom_header_create(void)
        g_signal_connect (G_OBJECT (down_btn), "clicked",
                          G_CALLBACK (prefs_custom_header_down), NULL);
 
+       preview = gtk_image_new ();
+       gtk_widget_show (preview);
+       gtk_box_pack_start (GTK_BOX (btn_vbox), preview, FALSE, FALSE, 0);
+
        gtk_widget_show_all(window);
 
        customhdr.window     = window;
        customhdr.ok_btn     = ok_btn;
        customhdr.cancel_btn = cancel_btn;
+       customhdr.preview = preview;
 
        customhdr.hdr_combo  = hdr_combo;
-       customhdr.hdr_entry  = GTK_COMBO (hdr_combo)->entry;
+       customhdr.hdr_entry  = gtk_bin_get_child(GTK_BIN((hdr_combo)));
        customhdr.val_entry  = val_entry;
 
        customhdr.list_view   = list_view;
@@ -328,8 +331,8 @@ void prefs_custom_header_read_config(PrefsAccount *ac)
 
        rcpath = g_strconcat(get_rc_dir(), G_DIR_SEPARATOR_S,
                             CUSTOM_HEADER_RC, NULL);
-       if ((fp = g_fopen(rcpath, "rb")) == NULL) {
-               if (ENOENT != errno) FILE_OP_ERROR(rcpath, "fopen");
+       if ((fp = claws_fopen(rcpath, "rb")) == NULL) {
+               if (ENOENT != errno) FILE_OP_ERROR(rcpath, "claws_fopen");
                g_free(rcpath);
                ac->customhdr_list = NULL;
                return;
@@ -343,7 +346,7 @@ void prefs_custom_header_read_config(PrefsAccount *ac)
                custom_header_free(ch);
        }
 
-       while (fgets(buf, sizeof(buf), fp) != NULL) {
+       while (claws_fgets(buf, sizeof(buf), fp) != NULL) {
                ch = custom_header_read_str(buf);
                if (ch) {
                        if (ch->account_id == ac->account_id) {
@@ -354,10 +357,10 @@ void prefs_custom_header_read_config(PrefsAccount *ac)
                }
        }
 
-       fclose(fp);
+       claws_fclose(fp);
 }
 
-void prefs_custom_header_write_config(PrefsAccount *ac)
+static void prefs_custom_header_write_config(PrefsAccount *ac)
 {
        gchar *rcpath;
        PrefFile *pfile;
@@ -373,12 +376,12 @@ void prefs_custom_header_write_config(PrefsAccount *ac)
        rcpath = g_strconcat(get_rc_dir(), G_DIR_SEPARATOR_S,
                             CUSTOM_HEADER_RC, NULL);
 
-       if ((fp = g_fopen(rcpath, "rb")) == NULL) {
-               if (ENOENT != errno) FILE_OP_ERROR(rcpath, "fopen");
+       if ((fp = claws_fopen(rcpath, "rb")) == NULL) {
+               if (ENOENT != errno) FILE_OP_ERROR(rcpath, "claws_fopen");
        } else {
                all_hdrs = NULL;
 
-               while (fgets(buf, sizeof(buf), fp) != NULL) {
+               while (claws_fgets(buf, sizeof(buf), fp) != NULL) {
                        ch = custom_header_read_str(buf);
                        if (ch) {
                                if (ch->account_id != ac->account_id)
@@ -389,11 +392,11 @@ void prefs_custom_header_write_config(PrefsAccount *ac)
                        }
                }
 
-               fclose(fp);
+               claws_fclose(fp);
        }
 
        if ((pfile = prefs_write_open(rcpath)) == NULL) {
-               g_warning("failed to write configuration to file\n");
+               g_warning("failed to write configuration to file");
                g_free(rcpath);
                return;
        }
@@ -403,9 +406,9 @@ void prefs_custom_header_write_config(PrefsAccount *ac)
                gchar *chstr;
 
                chstr = custom_header_get_str(hdr);
-               if (fputs(chstr, pfile->fp) == EOF ||
-                   fputc('\n', pfile->fp) == EOF) {
-                       FILE_OP_ERROR(rcpath, "fputs || fputc");
+               if (claws_fputs(chstr, pfile->fp) == EOF ||
+                   claws_fputc('\n', pfile->fp) == EOF) {
+                       FILE_OP_ERROR(rcpath, "claws_fputs || claws_fputc");
                        prefs_file_close_revert(pfile);
                        g_free(rcpath);
                        g_free(chstr);
@@ -419,9 +422,9 @@ void prefs_custom_header_write_config(PrefsAccount *ac)
                gchar *chstr;
 
                chstr = custom_header_get_str(hdr);
-               if (fputs(chstr, pfile->fp) == EOF ||
-                   fputc('\n', pfile->fp) == EOF) {
-                       FILE_OP_ERROR(rcpath, "fputs || fputc");
+               if (claws_fputs(chstr, pfile->fp) == EOF ||
+                   claws_fputc('\n', pfile->fp) == EOF) {
+                       FILE_OP_ERROR(rcpath, "claws_fputs || claws_fputc");
                        prefs_file_close_revert(pfile);
                        g_free(rcpath);
                        g_free(chstr);
@@ -439,7 +442,7 @@ void prefs_custom_header_write_config(PrefsAccount *ac)
        }
 
        if (prefs_file_close(pfile) < 0) {
-               g_warning("failed to write configuration to file\n");
+               g_warning("failed to write configuration to file");
                return;
        }
 }
@@ -495,10 +498,6 @@ static void prefs_custom_header_list_view_set_row(PrefsAccount *ac)
        CustomHeader *ch;
        const gchar *entry_text;
        gchar *ch_str;
-       GtkListStore *store;
-
-       store = GTK_LIST_STORE(gtk_tree_view_get_model
-                               (GTK_TREE_VIEW(customhdr.list_view)));
 
        entry_text = gtk_entry_get_text(GTK_ENTRY(customhdr.hdr_entry));
        if (entry_text[0] == '\0') {
@@ -554,15 +553,22 @@ static void prefs_custom_header_list_view_set_row(PrefsAccount *ac)
 #define B64_BUFFSIZE           77
 static void prefs_custom_header_val_from_file_cb(void)
 {
-       gchar *filename = filesel_select_file_open(_("Choose file"), NULL);
+       gchar *filename = NULL;
        gchar *contents = NULL;
        const gchar *hdr = gtk_entry_get_text(GTK_ENTRY(customhdr.hdr_entry));
        
+       if (!strcmp(hdr, "Face"))
+               filename = filesel_select_file_open(_("Choose a PNG file"), NULL);
+       else if (!strcmp(hdr, "X-Face"))
+               filename = filesel_select_file_open(_("Choose an XBM file"), NULL);
+       else
+               filename = filesel_select_file_open(_("Choose a text file"), NULL);
+
        if (!strcmp(hdr, "Face") || !strcmp(hdr, "X-Face")) {
                if (filename && is_file_exist(filename)) {
                        FILE *fp = NULL;
                        gint len;
-                       gchar inbuf[B64_LINE_SIZE], outbuf[B64_BUFFSIZE];
+                       gchar inbuf[B64_LINE_SIZE], *outbuf;
                        gchar *tmp = NULL;
                        gint w, h;
                        GdkPixbufFormat *format = gdk_pixbuf_get_file_info(
@@ -586,7 +592,7 @@ static void prefs_custom_header_val_from_file_cb(void)
                                }
                                if (g_ascii_strcasecmp("png", gdk_pixbuf_format_get_name(format))) {
                                        alertpanel_error(_("The image isn't in the correct format (PNG)."));
-                                       printf("%s\n", gdk_pixbuf_format_get_name(format));
+                                       g_print("%s\n", gdk_pixbuf_format_get_name(format));
                                        g_free(filename);
                                        return;
                                }
@@ -595,19 +601,25 @@ static void prefs_custom_header_val_from_file_cb(void)
                                int i = 0;
                                if (g_ascii_strcasecmp("xbm", gdk_pixbuf_format_get_name(format))) {
                                        alertpanel_error(_("The image isn't in the correct format (XBM)."));
-                                       printf("%s\n", gdk_pixbuf_format_get_name(format));
+                                       g_print("%s\n", gdk_pixbuf_format_get_name(format));
                                        g_free(filename);
                                        return;
                                }
                                cmd = g_strdup_printf("compface %s", filename);
                                tmp = get_command_output(cmd);
                                g_free(cmd);
-                               if (tmp == NULL || strlen(tmp) == 0){
+                               if (tmp == NULL || *tmp == '\0') {
                                        alertpanel_error(_("Couldn't call `compface`. Make sure it's in your $PATH."));
                                        g_free(filename);
                                        g_free(tmp);
                                        return;
                                }
+                               if (strstr(tmp, "compface:")) {
+                                       alertpanel_error(_("Compface error: %s"), tmp);
+                                       g_free(filename);
+                                       g_free(tmp);
+                                       return;
+                               }
                                while (tmp[i]) {
                                        gchar *tmp2 = NULL;
                                        if (tmp[i] == ' ') {
@@ -625,30 +637,35 @@ static void prefs_custom_header_val_from_file_cb(void)
                                goto settext;
                        }
 
-                       fp = g_fopen(filename, "rb");
+                       fp = claws_fopen(filename, "rb");
                        if (!fp) {
                                g_free(filename);
                                return; 
                        }
 
-                       while ((len = fread(inbuf, sizeof(gchar),
+                       while ((len = claws_fread(inbuf, sizeof(gchar),
                                            B64_LINE_SIZE, fp))
                               == B64_LINE_SIZE) {
-                               base64_encode(outbuf, inbuf, B64_LINE_SIZE);
+                               outbuf = g_base64_encode(inbuf, B64_LINE_SIZE);
 
                                tmp = contents;
                                contents = g_strconcat(tmp?tmp:"",outbuf, NULL);
+                               g_free(outbuf);
                                g_free(tmp);
                        }
-                       if (len > 0 && feof(fp)) {
+                       if (len > 0 && claws_feof(fp)) {
                                tmp = contents;
-                               base64_encode(outbuf, inbuf, len);
+                               outbuf = g_base64_encode(inbuf, len);
                                contents = g_strconcat(tmp?tmp:"",outbuf, NULL);
+                               g_free(outbuf);
                                g_free(tmp);
                        }
-                       fclose(fp);
+                       claws_fclose(fp);
                }
        } else {
+               if (!filename)
+                       return;
+
                contents = file_read_to_str(filename);
                if (strchr(contents, '\n') || strchr(contents,'\r')) {
                        alertpanel_error(_("This file contains newlines."));
@@ -683,7 +700,7 @@ static void prefs_custom_header_delete_cb(void)
 
        if (alertpanel(_("Delete header"),
                       _("Do you really want to delete this header?"),
-                      GTK_STOCK_CANCEL, GTK_STOCK_DELETE, NULL) != G_ALERTALTERNATE)
+                      GTK_STOCK_CANCEL, GTK_STOCK_DELETE, NULL, ALERTFOCUS_FIRST) != G_ALERTALTERNATE)
                return;
 
        gtk_tree_model_get(model, &sel,
@@ -757,7 +774,7 @@ static gboolean prefs_custom_header_key_pressed(GtkWidget *widget,
                                                GdkEventKey *event,
                                                gpointer data)
 {
-       if (event && event->keyval == GDK_Escape)
+       if (event && event->keyval == GDK_KEY_Escape)
                prefs_custom_header_cancel();
        return FALSE;
 }
@@ -766,12 +783,14 @@ static void prefs_custom_header_ok(void)
 {
        prefs_custom_header_write_config(cur_ac);
        gtk_widget_hide(customhdr.window);
+       gtk_window_set_modal(GTK_WINDOW(customhdr.window), FALSE);
 }
 
 static void prefs_custom_header_cancel(void)
 {
        prefs_custom_header_read_config(cur_ac); 
        gtk_widget_hide(customhdr.window);
+       gtk_window_set_modal(GTK_WINDOW(customhdr.window), FALSE);
 }
 
 static gint prefs_custom_header_deleted(GtkWidget *widget, GdkEventAny *event,
@@ -832,7 +851,8 @@ static GtkWidget *prefs_custom_header_list_view_create(void)
        list_view = GTK_TREE_VIEW(gtk_tree_view_new_with_model(model));
        g_object_unref(model);  
        
-       gtk_tree_view_set_rules_hint(list_view, prefs_common.enable_rules_hint);
+       gtk_tree_view_set_rules_hint(list_view, prefs_common.use_stripes_everywhere);
+       gtk_tree_view_set_reorderable(list_view, TRUE);
        
        selector = gtk_tree_view_get_selection(list_view);
        gtk_tree_selection_set_mode(selector, GTK_SELECTION_BROWSE);
@@ -870,6 +890,8 @@ static gboolean prefs_custom_header_selected(GtkTreeSelection *selector,
 {
        GtkTreeIter iter;
        CustomHeader *ch;
+       GtkImage *preview;
+       GdkPixbuf *pixbuf;
        CustomHeader default_ch = { 0, "", NULL };
 
        if (currently_selected)
@@ -886,7 +908,25 @@ static gboolean prefs_custom_header_selected(GtkTreeSelection *selector,
 
        ENTRY_SET_TEXT(customhdr.hdr_entry, ch->name);
        ENTRY_SET_TEXT(customhdr.val_entry, ch->value);
-                          
+       if (!g_strcmp0("Face",ch->name)) {
+               preview = GTK_IMAGE(face_get_from_header (ch->value));
+               pixbuf = gtk_image_get_pixbuf(preview);
+               gtk_image_set_from_pixbuf (GTK_IMAGE(customhdr.preview), pixbuf);
+               gtk_widget_show(customhdr.preview);
+               g_object_ref_sink (G_OBJECT(preview));
+       } 
+#if HAVE_LIBCOMPFACE
+else if (!g_strcmp0("X-Face", ch->name)) {
+               preview = GTK_IMAGE(xface_get_from_header(ch->value));  
+               pixbuf = gtk_image_get_pixbuf(preview);
+               gtk_image_set_from_pixbuf (GTK_IMAGE(customhdr.preview), pixbuf);
+               gtk_widget_show(customhdr.preview);
+               g_object_ref_sink (G_OBJECT(preview));
+       } 
+#endif
+else {
+               gtk_widget_hide(customhdr.preview);
+       }
        return TRUE;
 }