2012-11-18 [colin] 3.9.0cvs6-stable
[claws.git] / src / prefs_actions.c
index ec928d974ef644e5efde28f1c10b3f8f5204d08e..f32cd4c11ccdd6bc54466f775cee74e02753b511 100644 (file)
@@ -1,6 +1,6 @@
 /*
  * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2007 Hiroyuki Yamamoto & The Claws Mail Team
+ * Copyright (C) 1999-2012 Hiroyuki Yamamoto & The Claws Mail Team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -19,6 +19,7 @@
 
 #ifdef HAVE_CONFIG_H
 #  include "config.h"
+#include "claws-features.h"
 #endif
 
 #include "defs.h"
 #include "gtkutils.h"
 #include "manual.h"
 #include "menu.h"
+#include "filtering.h"
+#include "prefs_filtering_action.h"
+#include "matcher_parser.h"
+#include "prefs_toolbar.h"
 
 enum {
        PREFS_ACTIONS_STRING,   /*!< string pointer managed by list store, 
@@ -63,10 +68,13 @@ static struct Actions
        GtkWidget *window;
 
        GtkWidget *ok_btn;
-
+       GtkWidget *filter_btn;
        GtkWidget *name_entry;
        GtkWidget *cmd_entry;
-
+       GtkWidget *info_btn;
+       GtkWidget *shell_radiobtn;
+       GtkWidget *filter_radiobtn;
+       
        GtkWidget *actions_list_view;
 } actions;
 
@@ -85,13 +93,10 @@ static void prefs_actions_register_cb       (GtkWidget      *w,
                                         gpointer        data);
 static void prefs_actions_substitute_cb        (GtkWidget      *w,
                                         gpointer        data);
-static void prefs_actions_delete_cb    (GtkWidget      *w,
-                                        gpointer        data);
-static void prefs_actions_delete_all_cb        (GtkWidget      *w,
-                                        gpointer        data);
-static void prefs_actions_clear_cb     (void);
-static void prefs_actions_duplicate_cb (GtkWidget      *w,
-                                        gpointer        data);
+static void prefs_actions_delete_cb    (gpointer gtk_action, gpointer data);
+static void prefs_actions_delete_all_cb        (gpointer gtk_action, gpointer data);
+static void prefs_actions_clear_cb     (gpointer gtk_action, gpointer data);
+static void prefs_actions_duplicate_cb (gpointer gtk_action, gpointer data);
 static void prefs_actions_up           (GtkWidget      *w,
                                         gpointer        data);
 static void prefs_actions_down         (GtkWidget      *w,
@@ -102,6 +107,9 @@ static gint prefs_actions_deleted   (GtkWidget      *widget,
 static gboolean prefs_actions_key_pressed(GtkWidget    *widget,
                                          GdkEventKey   *event,
                                          gpointer       data);
+static gboolean prefs_actions_search_func_cb (GtkTreeModel *model, gint column, 
+                                               const gchar *key, GtkTreeIter *iter, 
+                                               gpointer search_data);
 static void prefs_actions_cancel       (GtkWidget      *w,
                                         gpointer        data);
 static void prefs_actions_ok           (GtkWidget      *w,
@@ -117,6 +125,12 @@ static GtkWidget *prefs_actions_list_view_create   (void);
 static void prefs_actions_create_list_view_columns     (GtkWidget *list_view);
 static void prefs_actions_select_row(GtkTreeView *list_view, GtkTreePath *path);
 
+static void prefs_action_filter_radiobtn_cb(GtkWidget *widget, gpointer data);
+static void prefs_action_shell_radiobtn_cb(GtkWidget *widget, gpointer data);
+static void prefs_action_filterbtn_cb(GtkWidget *widget, gpointer data);
+static void prefs_action_define_filter_done(GSList * action_list);
+
+
 void prefs_actions_open(MainWindow *mainwin)
 {
        inc_lock();
@@ -130,6 +144,7 @@ void prefs_actions_open(MainWindow *mainwin)
        prefs_actions_set_dialog();
 
        gtk_widget_show(actions.window);
+       gtk_window_set_modal(GTK_WINDOW(actions.window), TRUE);
 }
 
 /*!
@@ -138,7 +153,7 @@ void prefs_actions_open(MainWindow *mainwin)
 static void prefs_actions_size_allocate_cb(GtkWidget *widget,
                                         GtkAllocation *allocation)
 {
-       g_return_if_fail(allocation != NULL);
+       cm_return_if_fail(allocation != NULL);
 
        prefs_common.actionswin_width = allocation->width;
        prefs_common.actionswin_height = allocation->height;
@@ -148,6 +163,7 @@ static void prefs_actions_create(MainWindow *mainwin)
 {
        GtkWidget *window;
        GtkWidget *vbox;
+       GtkWidget *filter_hbox;
        GtkWidget *help_btn;
        GtkWidget *ok_btn;
        GtkWidget *cancel_btn;
@@ -156,10 +172,14 @@ static void prefs_actions_create(MainWindow *mainwin)
        GtkWidget *vbox1;
        GtkWidget *table;
 
+       GtkWidget *shell_radiobtn;
+       GtkWidget *filter_radiobtn;
+
        GtkWidget *name_label;
        GtkWidget *name_entry;
        GtkWidget *cmd_label;
        GtkWidget *cmd_entry;
+       GtkWidget *filter_btn;
 
        GtkWidget *reg_hbox;
        GtkWidget *btn_hbox;
@@ -186,7 +206,6 @@ static void prefs_actions_create(MainWindow *mainwin)
 
        gtk_container_set_border_width(GTK_CONTAINER (window), 8);
        gtk_window_set_position(GTK_WINDOW(window), GTK_WIN_POS_CENTER);
-       gtk_window_set_modal(GTK_WINDOW(window), TRUE);
        gtk_window_set_resizable(GTK_WINDOW(window), TRUE);
 
        vbox = gtk_vbox_new(FALSE, 6);
@@ -220,9 +239,9 @@ static void prefs_actions_create(MainWindow *mainwin)
        vbox1 = gtk_vbox_new(FALSE, VSPACING);
        gtk_widget_show(vbox1);
        gtk_box_pack_start(GTK_BOX(vbox), vbox1, TRUE, TRUE, 0);
-       gtk_container_set_border_width(GTK_CONTAINER(vbox1), 2);
+       gtk_container_set_border_width(GTK_CONTAINER(vbox1), 2);        
 
-       table = gtk_table_new(2, 2, FALSE);
+       table = gtk_table_new(3, 2, FALSE);
        gtk_table_set_row_spacings (GTK_TABLE (table), VSPACING_NARROW_2);
        gtk_table_set_col_spacings (GTK_TABLE (table), 4);
        gtk_widget_show(table);
@@ -239,21 +258,51 @@ static void prefs_actions_create(MainWindow *mainwin)
        gtk_widget_show (name_entry);
        gtk_table_attach (GTK_TABLE (table), name_entry, 1, 2, 0, 1,
                          (GtkAttachOptions) (GTK_FILL|GTK_EXPAND),
-                         (GtkAttachOptions) (0), 0, 0);
+                         (GtkAttachOptions) (0), 0, 0);
 
-       cmd_label = gtk_label_new (_("Command line"));
+       cmd_label = gtk_label_new (_("Command"));
        gtk_widget_show (cmd_label);
        gtk_misc_set_alignment (GTK_MISC (cmd_label), 1, 0.5);
-       gtk_table_attach (GTK_TABLE (table), cmd_label, 0, 1, 1, 2,
+       gtk_table_attach (GTK_TABLE (table), cmd_label, 0, 1, 2, 3,
                          (GtkAttachOptions) (GTK_FILL),
                          (GtkAttachOptions) (0), 0, 0);
 
        cmd_entry = gtk_entry_new ();
        gtk_widget_show (cmd_entry);
-       gtk_table_attach (GTK_TABLE (table), cmd_entry, 1, 2, 1, 2,
+       gtk_table_attach (GTK_TABLE (table), cmd_entry, 1, 2, 2, 3,
                          (GtkAttachOptions) (GTK_FILL|GTK_EXPAND),
                          (GtkAttachOptions) (0), 0, 0);
 
+       /* radio buttons for filter actions or shell */
+       filter_hbox = gtk_hbox_new(FALSE,4);
+       gtk_table_attach(GTK_TABLE(table), filter_hbox, 1, 2, 3, 4,
+                         (GtkAttachOptions) (GTK_FILL|GTK_EXPAND),
+                         (GtkAttachOptions) (0), 0, 0);
+       gtk_widget_show(filter_hbox);
+
+       shell_radiobtn = gtk_radio_button_new_with_label(NULL, _("Shell command"));
+       gtk_box_pack_start(GTK_BOX(filter_hbox), shell_radiobtn, FALSE, FALSE, 0);
+       gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(shell_radiobtn), TRUE);
+       gtk_widget_show(shell_radiobtn);
+       
+       g_signal_connect(G_OBJECT(shell_radiobtn), "clicked",
+                        G_CALLBACK(prefs_action_shell_radiobtn_cb), NULL);
+
+       filter_radiobtn =
+               gtk_radio_button_new_with_label_from_widget(GTK_RADIO_BUTTON(shell_radiobtn), 
+                                                           _("Filter action"));
+       gtk_box_pack_start(GTK_BOX(filter_hbox), filter_radiobtn, FALSE, FALSE, 0);
+       gtk_widget_show(filter_radiobtn);
+       g_signal_connect(G_OBJECT(filter_radiobtn), "clicked",
+                        G_CALLBACK(prefs_action_filter_radiobtn_cb), NULL);
+
+       filter_btn = gtk_button_new_with_label(_("Edit filter action"));
+       gtk_box_pack_start(GTK_BOX(filter_hbox), filter_btn, FALSE, FALSE, 0);
+       gtk_widget_set_sensitive(filter_btn, FALSE);
+       g_signal_connect(G_OBJECT(filter_btn), "clicked",
+                        G_CALLBACK(prefs_action_filterbtn_cb), NULL);
+       gtk_widget_show(filter_btn);
+
        /* register / substitute / delete */
 
        reg_hbox = gtk_hbox_new(FALSE, 4);
@@ -274,35 +323,40 @@ static void prefs_actions_create(MainWindow *mainwin)
        gtk_box_pack_start(GTK_BOX(btn_hbox), reg_btn, FALSE, TRUE, 0);
        g_signal_connect(G_OBJECT(reg_btn), "clicked",
                         G_CALLBACK(prefs_actions_register_cb), NULL);
+       CLAWS_SET_TIP(reg_btn,
+                       _("Append the new action above to the list"));
 
        subst_btn = gtkut_get_replace_btn(_("Replace"));
        gtk_widget_show(subst_btn);
        gtk_box_pack_start(GTK_BOX(btn_hbox), subst_btn, FALSE, TRUE, 0);
        g_signal_connect(G_OBJECT(subst_btn), "clicked",
-                        G_CALLBACK(prefs_actions_substitute_cb),
-                        NULL);
+                        G_CALLBACK(prefs_actions_substitute_cb), NULL);
+       CLAWS_SET_TIP(subst_btn,
+                       _("Replace the selected action in list with the action above"));
 
        del_btn = gtk_button_new_from_stock(GTK_STOCK_DELETE);
        gtk_widget_show(del_btn);
        gtk_box_pack_start(GTK_BOX(btn_hbox), del_btn, FALSE, TRUE, 0);
        g_signal_connect(G_OBJECT(del_btn), "clicked",
                         G_CALLBACK(prefs_actions_delete_cb), NULL);
+       CLAWS_SET_TIP(del_btn,
+                       _("Delete the selected action from the list"));
 
        clear_btn = gtk_button_new_from_stock (GTK_STOCK_CLEAR);
        gtk_widget_show (clear_btn);
        gtk_box_pack_start (GTK_BOX (btn_hbox), clear_btn, FALSE, TRUE, 0);
        g_signal_connect(G_OBJECT (clear_btn), "clicked",
                        G_CALLBACK(prefs_actions_clear_cb), NULL);
+       CLAWS_SET_TIP(clear_btn,
+                       _("Clear all the input fields in the dialog"));
 
-#if GTK_CHECK_VERSION(2, 8, 0)
        info_btn = gtk_button_new_from_stock(GTK_STOCK_INFO);
-#else
-       info_btn = gtk_button_new_with_label(_("Info..."));
-#endif
        gtk_widget_show(info_btn);
        gtk_box_pack_end(GTK_BOX(reg_hbox), info_btn, FALSE, FALSE, 0);
        g_signal_connect(G_OBJECT(info_btn), "clicked",
                         G_CALLBACK(prefs_actions_info_cb), GTK_WINDOW(window));
+       CLAWS_SET_TIP(info_btn,
+                       _("Show information on configuring actions"));
 
        cond_hbox = gtk_hbox_new(FALSE, 8);
        gtk_widget_show(cond_hbox);
@@ -316,6 +370,8 @@ static void prefs_actions_create(MainWindow *mainwin)
        gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW (cond_scrolledwin),
                                       GTK_POLICY_AUTOMATIC,
                                       GTK_POLICY_AUTOMATIC);
+       gtk_scrolled_window_set_shadow_type(GTK_SCROLLED_WINDOW(cond_scrolledwin),
+                                           GTK_SHADOW_ETCHED_IN);
 
        cond_list_view = prefs_actions_list_view_create();                                     
        gtk_widget_show(cond_list_view);
@@ -330,12 +386,16 @@ static void prefs_actions_create(MainWindow *mainwin)
        gtk_box_pack_start(GTK_BOX(btn_vbox), up_btn, FALSE, FALSE, 0);
        g_signal_connect(G_OBJECT(up_btn), "clicked",
                         G_CALLBACK(prefs_actions_up), NULL);
+       CLAWS_SET_TIP(up_btn,
+                       _("Move the selected action up"));
 
        down_btn = gtk_button_new_from_stock(GTK_STOCK_GO_DOWN);
        gtk_widget_show(down_btn);
        gtk_box_pack_start(GTK_BOX(btn_vbox), down_btn, FALSE, FALSE, 0);
        g_signal_connect(G_OBJECT(down_btn), "clicked",
                         G_CALLBACK(prefs_actions_down), NULL);
+       CLAWS_SET_TIP(down_btn,
+                       _("Move selected action down"));
 
        if (!geometry.min_height) {
                geometry.min_width = 486;
@@ -351,10 +411,14 @@ static void prefs_actions_create(MainWindow *mainwin)
 
        actions.window = window;
        actions.ok_btn = ok_btn;
+       actions.info_btn = info_btn;
 
        actions.name_entry = name_entry;
        actions.cmd_entry  = cmd_entry;
-
+       actions.filter_btn = filter_btn;
+       actions.shell_radiobtn = shell_radiobtn;
+       actions.filter_radiobtn = filter_radiobtn;
+       
        actions.actions_list_view = cond_list_view;
 }
 
@@ -362,6 +426,7 @@ static void prefs_actions_reset_dialog(void)
 {
        gtk_entry_set_text(GTK_ENTRY(actions.name_entry), "");
        gtk_entry_set_text(GTK_ENTRY(actions.cmd_entry), "");
+       gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(actions.shell_radiobtn), TRUE);
 }
 
 void prefs_actions_read_config(void)
@@ -443,6 +508,7 @@ void prefs_actions_write_config(void)
                    fputc('\n', pfile->fp) == EOF) {
                        FILE_OP_ERROR(rcpath, "fputs || fputc");
                        prefs_file_close_revert(pfile);
+                       g_free(act);
                        g_free(rcpath);
                        return;
                }
@@ -469,13 +535,12 @@ static void prefs_actions_set_dialog(void)
 {
        GtkListStore *store;
        GSList *cur;
-       GtkTreeSelection *selection;
-       GtkTreeIter iter;
 
        store = GTK_LIST_STORE(gtk_tree_view_get_model
                                (GTK_TREE_VIEW(actions.actions_list_view)));
 
        prefs_actions_clear_list(store);        
+       prefs_actions_reset_dialog();
 
        for (cur = prefs_common.actions_list; cur != NULL; cur = cur->next) {
                gchar *action = (gchar *) cur->data;
@@ -483,13 +548,6 @@ static void prefs_actions_set_dialog(void)
                prefs_actions_list_view_insert_action(actions.actions_list_view,
                                                      -1, action, TRUE);
        }
-
-       /* select first entry */
-       selection = gtk_tree_view_get_selection
-               (GTK_TREE_VIEW(actions.actions_list_view));
-       if (gtk_tree_model_get_iter_first(GTK_TREE_MODEL(store),
-                                         &iter))
-               gtk_tree_selection_select_iter(selection, &iter);
 }
 
 static void prefs_actions_set_list(void)
@@ -529,13 +587,9 @@ static void prefs_actions_set_list(void)
 static gint prefs_actions_clist_set_row(gint row)
 {
        const gchar *entry_text;
-       gint len;
+       gint len, action_nb;
        gchar action[PREFSBUFSIZE];
        gchar *new_action;
-       GtkListStore *store;
-
-       store = GTK_LIST_STORE(gtk_tree_view_get_model
-                               (GTK_TREE_VIEW(actions.actions_list_view)));
 
        GET_ENTRY(actions.name_entry);
        if (entry_text[0] == '\0') {
@@ -553,6 +607,12 @@ static gint prefs_actions_clist_set_row(gint row)
                return -1;
        }
 
+       action_nb = prefs_actions_find_by_name(entry_text);
+       if ((action_nb != -1) && ((row == -1) || (row != action_nb + 1))) {
+               alertpanel_error(_("There is an action with this name already."));
+               return -1;
+       }
+       
        strncpy(action, entry_text, PREFSBUFSIZE - 1);
 
        while (strstr(action, "//")) {
@@ -577,7 +637,7 @@ static gint prefs_actions_clist_set_row(gint row)
        GET_ENTRY(actions.cmd_entry);
 
        if (entry_text[0] == '\0') {
-               alertpanel_error(_("Command line not set."));
+               alertpanel_error(_("Command-line not set."));
                return -1;
        }
 
@@ -590,7 +650,7 @@ static gint prefs_actions_clist_set_row(gint row)
                gchar *message;
                message = g_markup_printf_escaped(_("The command\n%s\nhas a syntax error."),
                                                entry_text);
-               alertpanel_error(message);
+               alertpanel_error("%s", message);
                g_free(message);
                return -1;
        }
@@ -630,7 +690,7 @@ static void prefs_actions_substitute_cb(GtkWidget *w, gpointer data)
        modified_list = TRUE;
 }
 
-static void prefs_actions_delete_cb(GtkWidget *w, gpointer data)
+static void prefs_actions_delete_cb(gpointer gtk_action, gpointer data)
 {
        GtkTreeIter sel;
        GtkTreeModel *model;
@@ -663,13 +723,13 @@ static void prefs_actions_delete_cb(GtkWidget *w, gpointer data)
        modified_list = TRUE;
 }
 
-static void prefs_actions_delete_all_cb(GtkWidget *w, gpointer data)
+static void prefs_actions_delete_all_cb(gpointer gtk_action, gpointer data)
 {
        GtkListStore *list_store;
 
        if (alertpanel(_("Delete all actions"),
-                         _("Do you really want to delete all actions?"),
-                         GTK_STOCK_CANCEL, "+"GTK_STOCK_DELETE, NULL) == G_ALERTDEFAULT)
+                         _("Do you really want to delete all the actions?"),
+                         GTK_STOCK_CANCEL, GTK_STOCK_DELETE, NULL) != G_ALERTDEFAULT)
           return;
 
        list_store = GTK_LIST_STORE(gtk_tree_view_get_model(GTK_TREE_VIEW(actions.actions_list_view)));
@@ -680,7 +740,7 @@ static void prefs_actions_delete_all_cb(GtkWidget *w, gpointer data)
        modified_list = TRUE;
 }
 
-static void prefs_actions_clear_cb(void)
+static void prefs_actions_clear_cb(gpointer gtk_action, gpointer data)
 {
        gint row;
 
@@ -692,7 +752,7 @@ static void prefs_actions_clear_cb(void)
                modified = TRUE;
 }
 
-static void prefs_actions_duplicate_cb(GtkWidget *w, gpointer data)
+static void prefs_actions_duplicate_cb(gpointer gtk_action, gpointer data)
 {
        gint row;
        
@@ -793,18 +853,40 @@ static gint prefs_actions_deleted(GtkWidget *widget, GdkEventAny *event,
 static gboolean prefs_actions_key_pressed(GtkWidget *widget, GdkEventKey *event,
                                          gpointer data)
 {
-       if (event && event->keyval == GDK_Escape)
+       if (event && event->keyval == GDK_KEY_Escape)
                prefs_actions_cancel(widget, data);
        else {
                GtkWidget *focused = gtkut_get_focused_child(
-                                       GTK_CONTAINER(widget));
-               if (focused && GTK_IS_EDITABLE(focused)) {
+                               GTK_CONTAINER(widget));
+               if (focused && GTK_IS_EDITABLE(focused))
                        modified = TRUE;
-               }
        }
        return FALSE;
 }
 
+static gboolean prefs_actions_search_func_cb (GtkTreeModel *model, gint column, const gchar *key, 
+                                               GtkTreeIter *iter, gpointer search_data) 
+{
+       gchar *store_string;
+       gboolean retval;
+       GtkTreePath *path;
+
+       gtk_tree_model_get (model, iter, column, &store_string, -1);
+
+       if (!store_string || !key)
+               return FALSE;
+
+
+       retval = (strncmp (key, store_string, strlen(key)) != 0);
+
+       g_free(store_string);
+       debug_print("selecting row\n");
+       path = gtk_tree_model_get_path(model, iter);
+       prefs_actions_select_row(GTK_TREE_VIEW(actions.actions_list_view), path);
+       gtk_tree_path_free(path);
+
+       return retval;
+}
 static void prefs_actions_cancel(GtkWidget *w, gpointer data)
 {
        GtkListStore *store;
@@ -827,6 +909,7 @@ static void prefs_actions_cancel(GtkWidget *w, gpointer data)
        gtk_list_store_clear(store);
        prefs_actions_read_config();
        gtk_widget_hide(actions.window);
+       gtk_window_set_modal(GTK_WINDOW(actions.window), FALSE);
        inc_unlock();
 }
 
@@ -870,7 +953,11 @@ static void prefs_actions_ok(GtkWidget *widget, gpointer data)
                compose_update_actions_menu(compose);
        }
 
+       /* Update toolbars */
+       prefs_toolbar_update_action_btns();
+       
        gtk_widget_hide(actions.window);
+       gtk_window_set_modal(GTK_WINDOW(actions.window), FALSE);
        inc_unlock();
 }
 
@@ -883,7 +970,7 @@ static gchar *actions_desc_strings[] = {
        N_("<span weight=\"bold\" underline=\"single\">Menu name:</span>"), NULL,
        N_("Use / in menu name to make submenus."), NULL,
        "", NULL,
-       N_("<span weight=\"bold\" underline=\"single\">Command line:</span>"), NULL,
+       N_("<span weight=\"bold\" underline=\"single\">Command-line:</span>"), NULL,
        N_("<span weight=\"bold\">Begin with:</span>"), NULL,
        "     |",   N_("to send message body or selection to command's standard input"),
        "     &gt;",   N_("to send user provided text to command's standard input"),
@@ -908,6 +995,7 @@ static gchar *actions_desc_strings[] = {
 static DescriptionWindow actions_desc_win = { 
        NULL,
        NULL,
+       TRUE,
        2,
        N_("Actions"),
        N_("The Actions feature is a way for the user to launch "
@@ -989,62 +1077,81 @@ static void prefs_actions_list_view_insert_action(GtkWidget *list_view,
        }
 }
 
-static GtkItemFactory *prefs_actions_popup_factory = NULL;
+static GtkActionGroup *prefs_actions_popup_action = NULL;
 static GtkWidget *prefs_actions_popup_menu = NULL;
 
-static GtkItemFactoryEntry prefs_actions_popup_entries[] =
+static GtkActionEntry prefs_actions_popup_entries[] =
 {
-   {N_("/_Delete"),            NULL, prefs_actions_delete_cb, 0, NULL, NULL},
-   {N_("/Delete _all"),        NULL, prefs_actions_delete_all_cb, 0, NULL, NULL},
-   {N_("/D_uplicate"), NULL, prefs_actions_duplicate_cb, 0, NULL, NULL},
+       {"PrefsActionsPopup",                   NULL, "PrefsActionsPopup" },
+       {"PrefsActionsPopup/Delete",            NULL, N_("_Delete"), NULL, NULL, G_CALLBACK(prefs_actions_delete_cb) },
+       {"PrefsActionsPopup/DeleteAll", NULL, N_("Delete _all"), NULL, NULL, G_CALLBACK(prefs_actions_delete_all_cb) },
+       {"PrefsActionsPopup/Duplicate", NULL, N_("D_uplicate"), NULL, NULL, G_CALLBACK(prefs_actions_duplicate_cb) },
 };
 
+static void prefs_actions_row_selected(GtkTreeSelection *selection, GtkTreeView *list_view)
+{
+       GtkTreePath *path;
+       GtkTreeIter iter;
+       GtkTreeModel *model;
+       
+       if (!gtk_tree_selection_get_selected(selection, &model, &iter))
+               return;
+       
+       path = gtk_tree_model_get_path(model, &iter);
+       prefs_actions_select_row(list_view, path);
+       gtk_tree_path_free(path);
+}
+
 static gint prefs_actions_list_btn_pressed(GtkWidget *widget, GdkEventButton *event,
                                   GtkTreeView *list_view)
 {
-   if (event) {
-          /* left- or right-button click */
-          if (event->button == 1 || event->button == 3) {
-                  GtkTreePath *path = NULL;
-                  if (gtk_tree_view_get_path_at_pos( list_view, event->x, event->y,
-                                                          &path, NULL, NULL, NULL)) {
-                          prefs_actions_select_row(list_view, path);
-                  }
-                  if (path)
-                          gtk_tree_path_free(path);
-          }
-
-          /* right-button click */
-          if (event->button == 3) {
-                  GtkTreeModel *model = gtk_tree_view_get_model(list_view);
-                  GtkTreeIter iter;
-                  gboolean non_empty;
-                  gint row;
-
-                  if (!prefs_actions_popup_menu) {
-                          gint n_entries = sizeof(prefs_actions_popup_entries) /
-                                          sizeof(prefs_actions_popup_entries[0]);
-                          prefs_actions_popup_menu = menu_create_items(prefs_actions_popup_entries,
-                                                                n_entries, "<PrefsActionsPopupMenu>",
-                                                                &prefs_actions_popup_factory, list_view);
-                  }
-
-                  /* grey out some popup menu items if there is no selected row */
-                  row = gtkut_list_view_get_selected_row(GTK_WIDGET(list_view));
-                  menu_set_sensitive(prefs_actions_popup_factory, "/Delete", (row > 0));
-                  menu_set_sensitive(prefs_actions_popup_factory, "/Duplicate", (row > 0));
-
-                  /* grey out seom popup menu items if there is no row
-                         (not counting the (New) one at row 0) */
-                  non_empty = gtk_tree_model_get_iter_first(model, &iter);
-                  if (non_empty)
-                          non_empty = gtk_tree_model_iter_next(model, &iter);
-                  menu_set_sensitive(prefs_actions_popup_factory, "/Delete all", non_empty);
-
-                  gtk_menu_popup(GTK_MENU(prefs_actions_popup_menu), 
-                                         NULL, NULL, NULL, NULL, 
-                                         event->button, event->time);
-          }
+       if (event) {
+               /* left- or right-button click */
+               if (event->button == 1 || event->button == 3) {
+                       GtkTreePath *path = NULL;
+                       if (gtk_tree_view_get_path_at_pos( list_view, event->x, event->y,
+                                       &path, NULL, NULL, NULL)) {
+                               prefs_actions_select_row(list_view, path);
+               }
+               if (path)
+                       gtk_tree_path_free(path);
+               }
+
+               /* right-button click */
+               if (event->button == 3) {
+                       GtkTreeModel *model = gtk_tree_view_get_model(list_view);
+                       GtkTreeIter iter;
+                       gboolean non_empty;
+                       gint row;
+
+                       if (!prefs_actions_popup_menu) {
+                               prefs_actions_popup_action = cm_menu_create_action_group("PrefsActionsPopup",
+                                               prefs_actions_popup_entries, G_N_ELEMENTS(prefs_actions_popup_entries),
+                                               (gpointer)list_view);
+                               MENUITEM_ADDUI("/Menus", "PrefsActionsPopup", "PrefsActionsPopup", GTK_UI_MANAGER_MENU)
+                               MENUITEM_ADDUI("/Menus/PrefsActionsPopup", "Delete", "PrefsActionsPopup/Delete", GTK_UI_MANAGER_MENUITEM)
+                               MENUITEM_ADDUI("/Menus/PrefsActionsPopup", "DeleteAll", "PrefsActionsPopup/DeleteAll", GTK_UI_MANAGER_MENUITEM)
+                               MENUITEM_ADDUI("/Menus/PrefsActionsPopup", "Duplicate", "PrefsActionsPopup/Duplicate", GTK_UI_MANAGER_MENUITEM)
+                               prefs_actions_popup_menu = gtk_menu_item_get_submenu(GTK_MENU_ITEM(
+                                               gtk_ui_manager_get_widget(gtkut_ui_manager(), "/Menus/PrefsActionsPopup")) );
+                       }
+
+                       /* grey out some popup menu items if there is no selected row */
+                       row = gtkut_list_view_get_selected_row(GTK_WIDGET(list_view));
+                       cm_menu_set_sensitive("PrefsActionsPopup/Delete", (row > 0));
+                       cm_menu_set_sensitive("PrefsActionsPopup/Duplicate", (row > 0));
+
+                       /* grey out seom popup menu items if there is no row
+                       (not counting the (New) one at row 0) */
+                       non_empty = gtk_tree_model_get_iter_first(model, &iter);
+                       if (non_empty)
+                               non_empty = gtk_tree_model_iter_next(model, &iter);
+                       cm_menu_set_sensitive("PrefsActionsPopup/DeleteAll", non_empty);
+
+                       gtk_menu_popup(GTK_MENU(prefs_actions_popup_menu), 
+                                       NULL, NULL, NULL, NULL, 
+                                       event->button, event->time);
+               }
    }
    return FALSE;
 }
@@ -1089,6 +1196,8 @@ static GtkWidget *prefs_actions_list_view_create(void)
 
        selector = gtk_tree_view_get_selection(list_view);
        gtk_tree_selection_set_mode(selector, GTK_SELECTION_BROWSE);
+       g_signal_connect(G_OBJECT(selector), "changed",
+                        G_CALLBACK(prefs_actions_row_selected), list_view);
 
        /* create the columns */
        prefs_actions_create_list_view_columns(GTK_WIDGET(list_view));
@@ -1108,6 +1217,7 @@ static void prefs_actions_create_list_view_columns(GtkWidget *list_view)
                 "text", PREFS_ACTIONS_STRING,
                 NULL);
        gtk_tree_view_append_column(GTK_TREE_VIEW(list_view), column);          
+       gtk_tree_view_set_search_equal_func(GTK_TREE_VIEW(list_view), prefs_actions_search_func_cb , NULL, NULL);
 }
 
 #define ENTRY_SET_TEXT(entry, str) \
@@ -1149,7 +1259,139 @@ static void prefs_actions_select_row(GtkTreeView *list_view, GtkTreePath *path)
                return;
 
        *cmd = '\0';
-       ENTRY_SET_TEXT(actions.name_entry, buf);
+       gtk_entry_set_text(GTK_ENTRY(actions.name_entry), buf);
+
+       if (g_str_has_prefix(&cmd[2], "%as{") == TRUE)
+               gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(
+                                               actions.filter_radiobtn), TRUE);
+       else
+               gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(
+                                               actions.shell_radiobtn), TRUE);
 
        return;
 }
+
+static void prefs_action_filter_radiobtn_cb(GtkWidget *widget, gpointer data)
+{
+       if (actions.filter_btn)
+               gtk_widget_set_sensitive(actions.filter_btn, TRUE);
+       if (actions.cmd_entry)
+               gtk_widget_set_sensitive(actions.cmd_entry, FALSE);
+       if (actions.info_btn)
+               gtk_widget_set_sensitive(actions.info_btn, FALSE);
+}
+
+static void prefs_action_shell_radiobtn_cb(GtkWidget *widget, gpointer data)
+{
+       if (actions.filter_btn)
+               gtk_widget_set_sensitive(actions.filter_btn, FALSE);
+       if (actions.cmd_entry)
+               gtk_widget_set_sensitive(actions.cmd_entry, TRUE);
+       if (actions.info_btn)
+               gtk_widget_set_sensitive(actions.info_btn, TRUE);
+}
+
+static void prefs_action_filterbtn_cb(GtkWidget *widget, gpointer data)
+{
+       gchar *action_str, **tokens;
+       GSList *action_list = NULL, *cur;
+
+/* I think this warning is useless - it's logical to clear the field when
+   changing its type.
+
+       if(modified && alertpanel(_("Entry was modified"),
+                       _("Opening the filter action dialog will clear current modifications "
+                       "of the command line."),
+                       GTK_STOCK_CANCEL, _("+_Continue editing"), NULL) != G_ALERTDEFAULT)
+               return;
+*/
+       action_str = gtk_editable_get_chars(GTK_EDITABLE(actions.cmd_entry), 0, -1);
+       tokens = g_strsplit_set(action_str, "{}", 5);
+
+       if (tokens[0] && tokens[1] && *tokens[1] != '\0') {
+               action_list = matcher_parser_get_action_list(tokens[1]);
+               if (action_list == NULL)
+                       alertpanel_error(_("Action string is not valid."));
+       }
+               
+       prefs_filtering_action_open(action_list, prefs_action_define_filter_done);
+
+       if (action_list != NULL) {
+               for(cur = action_list ; cur != NULL ; cur = cur->next)
+                        filteringaction_free(cur->data);
+        }
+        
+       g_free(action_str);
+       g_strfreev(tokens);
+}
+
+static void prefs_action_define_filter_done(GSList * action_list)
+{
+       gchar *str;
+
+       if (action_list == NULL)
+               return;
+
+       action_list = filtering_action_list_sort(action_list);
+       str = filteringaction_list_to_string(action_list);
+
+       if (str != NULL) {
+               gchar *cmd;
+               cmd = g_strdup_printf("%%as{%s}",str);
+               g_free(str);
+               gtk_entry_set_text(GTK_ENTRY(actions.cmd_entry), cmd);
+               g_free(cmd);
+               modified = TRUE;
+       }
+}
+
+void prefs_actions_rename_path(const gchar *old_path, const gchar *new_path)
+{
+       gchar **tokens, *action_str;
+       GSList *action, *action_list;
+       
+       for (action = prefs_common.actions_list; action != NULL;
+                       action = action->next) {
+               action_str = (gchar *)action->data;
+               tokens = g_strsplit_set(action_str, "{}", 5);
+               
+               if (tokens[0] && tokens[1] && *tokens[1] != '\0')
+                       action_list = matcher_parser_get_action_list(tokens[1]);
+               else
+                       action_list = NULL;
+
+               if (action_list &&
+                   filtering_action_list_rename_path(action_list,
+                                               old_path, new_path)) {
+                       g_free(action->data);
+                       action->data = g_strconcat(tokens[0], "{",
+                               filteringaction_list_to_string(action_list),
+                               "}", NULL);
+               }
+
+               g_strfreev(tokens);
+       }
+}
+
+gint prefs_actions_find_by_name(const gchar *name)
+{
+       GSList *act = prefs_common.actions_list;
+       gchar *action_name, *action_p;
+       gint action_nb = 0;
+       
+       for (; act != NULL; act = act->next) {
+               action_name = g_strdup((gchar *)act->data);
+               action_p = strstr(action_name, ": ");
+               action_p[0] = 0x00;
+
+               if (g_utf8_collate(name, action_name) == 0) {
+                       g_free(action_name);
+                       return action_nb;
+               }
+
+               g_free(action_name);
+               action_nb++;
+       }
+
+       return -1;
+}