Assume direct TLS if SMTP autoconfig finds port 465.
[claws.git] / src / prefs_account.c
index 5bd2afd55326ea580c6a5a452168c29e5a2b1f85..30c3d0abec6883185ea51d1b97dca4cd0fc24c16 100644 (file)
@@ -331,8 +331,8 @@ struct BasicProtocol {
 };
 
 static char *protocol_names[] = {
-       N_("POP3"),
-       N_("IMAP4"),
+       N_("POP"),
+       N_("IMAP"),
        N_("News (NNTP)"),
        N_("Local mbox file"),
        N_("None (SMTP only)")
@@ -366,6 +366,8 @@ static void prefs_account_nntpauth_toggled(GtkToggleButton *button,
                                           gpointer user_data);
 static void prefs_account_mailcmd_toggled(GtkToggleButton *button,
                                          gpointer user_data);
+static void prefs_account_showpwd_checkbtn_toggled(GtkToggleButton *button,
+                                         gpointer user_data);
 static void prefs_account_filter_on_recv_toggled(GtkToggleButton *button,
                                          gpointer user_data);
 
@@ -1010,6 +1012,7 @@ static void basic_create_widget_func(PrefsPage * _page,
        GtkWidget *auto_configure_btn;
        GtkWidget *auto_configure_cancel_btn;
        GtkWidget *auto_configure_lbl;
+       GtkWidget *showpwd_checkbtn;
        GtkListStore *menu;
        GtkTreeIter iter;
        gchar *buf;
@@ -1153,7 +1156,7 @@ static void basic_create_widget_func(PrefsPage * _page,
        protocol_optmenu->no_imap_warn_icon = no_imap_warn_icon;
        protocol_optmenu->no_imap_warn_label = no_imap_warn_label;
 
-       serv_table = gtk_table_new (6, 4, FALSE);
+       serv_table = gtk_table_new (10, 4, FALSE);
        gtk_widget_show (serv_table);
        gtk_box_pack_start (GTK_BOX (vbox2), serv_table, FALSE, FALSE, 0);
        gtk_table_set_row_spacings (GTK_TABLE (serv_table), VSPACING_NARROW);
@@ -1288,6 +1291,15 @@ static void basic_create_widget_func(PrefsPage * _page,
        gtk_table_attach (GTK_TABLE (serv_table), pass_label, 0, 1, 8, 9,
                          GTK_FILL, 0, 0, 0);
 #endif
+
+       showpwd_checkbtn = gtk_check_button_new_with_label (_("Show password"));
+       gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(showpwd_checkbtn), FALSE);
+       gtk_widget_show(showpwd_checkbtn);
+       gtk_table_attach (GTK_TABLE (serv_table), showpwd_checkbtn, 3, 4, 9, 10,
+                       GTK_FILL, 0, 0, 0);
+       g_signal_connect(G_OBJECT(showpwd_checkbtn), "toggled",
+                       G_CALLBACK(prefs_account_showpwd_checkbtn_toggled), pass_entry);
+
        SET_TOGGLE_SENSITIVITY (nntpauth_checkbtn, uid_label);
        SET_TOGGLE_SENSITIVITY (nntpauth_checkbtn, pass_label);
        SET_TOGGLE_SENSITIVITY (nntpauth_checkbtn, uid_entry);
@@ -1451,7 +1463,7 @@ static void receive_create_widget_func(PrefsPage * _page,
                          G_CALLBACK (prefs_account_select_folder_cb),
                          local_inbox_entry);
 
-       vbox2 = gtkut_get_options_frame(vbox1, &frame1, _("POP3"));
+       vbox2 = gtkut_get_options_frame(vbox1, &frame1, _("POP"));
        PACK_CHECK_BUTTON (vbox2, use_apop_checkbtn,
                           _("Use secure authentication (APOP)"));
 
@@ -1564,7 +1576,7 @@ static void receive_create_widget_func(PrefsPage * _page,
        gtk_spin_button_set_numeric
                (GTK_SPIN_BUTTON (maxarticle_spinbtn), TRUE);
 
-       vbox2 = gtkut_get_options_frame(vbox1, &imap_frame, _("IMAP4"));
+       vbox2 = gtkut_get_options_frame(vbox1, &imap_frame, _("IMAP"));
 
        hbox1 = gtk_hbox_new (FALSE, 8);
        gtk_widget_show (hbox1);
@@ -1703,6 +1715,7 @@ static void send_create_widget_func(PrefsPage * _page,
        GtkWidget *checkbtn_msgid_with_addr;
        GtkWidget *vbox3;
        GtkWidget *smtp_auth_checkbtn;
+       GtkWidget *showpwd_checkbtn;
        GtkWidget *optmenu;
        GtkListStore *menu;
        GtkTreeIter iter;
@@ -1823,8 +1836,15 @@ static void send_create_widget_func(PrefsPage * _page,
        gtk_widget_show (smtp_pass_entry);
        gtk_widget_set_size_request (smtp_pass_entry, DEFAULT_ENTRY_WIDTH, -1);
        gtk_box_pack_start (GTK_BOX (hbox), smtp_pass_entry, TRUE, TRUE, 0);
-
        gtk_entry_set_visibility (GTK_ENTRY (smtp_pass_entry), FALSE);
+
+       showpwd_checkbtn = gtk_check_button_new_with_label (_("Show password"));
+       gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(showpwd_checkbtn), FALSE);
+       gtk_widget_show(showpwd_checkbtn);
+       gtk_box_pack_start(GTK_BOX (hbox), showpwd_checkbtn, FALSE, FALSE, 0);
+       g_signal_connect(G_OBJECT(showpwd_checkbtn), "toggled",
+                       G_CALLBACK(prefs_account_showpwd_checkbtn_toggled), smtp_pass_entry);
+
        PACK_VSPACER(vbox4, vbox_spc, VSPACING_NARROW_2);
 
        hbox = gtk_hbox_new (FALSE, 8);
@@ -1848,7 +1868,7 @@ static void send_create_widget_func(PrefsPage * _page,
        SET_TOGGLE_SENSITIVITY (smtp_auth_checkbtn, vbox4);
 
        PACK_CHECK_BUTTON (vbox3, pop_bfr_smtp_checkbtn,
-               _("Authenticate with POP3 before sending"));
+               _("Authenticate with POP before sending"));
        
        g_signal_connect (G_OBJECT (pop_bfr_smtp_checkbtn), "clicked",
                          G_CALLBACK (pop_bfr_smtp_tm_set_sens),
@@ -2027,7 +2047,7 @@ static void compose_create_widget_func(PrefsPage * _page,
        gtk_table_set_col_spacings (GTK_TABLE (table), 8);
 
        autocc_checkbtn = gtk_check_button_new_with_label (
-                               prefs_common_translated_header_name("Cc"));
+                               prefs_common_translated_header_name("Cc:"));
        gtk_widget_show (autocc_checkbtn);
        gtk_table_attach (GTK_TABLE (table), autocc_checkbtn, 0, 1, 0, 1,
                          GTK_FILL, 0, 0, 0);
@@ -2041,7 +2061,7 @@ static void compose_create_widget_func(PrefsPage * _page,
        SET_TOGGLE_SENSITIVITY (autocc_checkbtn, autocc_entry);
 
        autobcc_checkbtn = gtk_check_button_new_with_label (
-                               prefs_common_translated_header_name("Bcc"));
+                               prefs_common_translated_header_name("Bcc:"));
        gtk_widget_show (autobcc_checkbtn);
        gtk_table_attach (GTK_TABLE (table), autobcc_checkbtn, 0, 1, 1, 2,
                          GTK_FILL, 0, 0, 0);
@@ -2055,7 +2075,7 @@ static void compose_create_widget_func(PrefsPage * _page,
        SET_TOGGLE_SENSITIVITY (autobcc_checkbtn, autobcc_entry);
 
        autoreplyto_checkbtn = gtk_check_button_new_with_label (
-                               prefs_common_translated_header_name("Reply-To"));
+                               prefs_common_translated_header_name("Reply-To:"));
        gtk_widget_show (autoreplyto_checkbtn);
        gtk_table_attach (GTK_TABLE (table), autoreplyto_checkbtn, 0, 1, 2, 3,
                          GTK_FILL, 0, 0, 0);
@@ -2436,6 +2456,7 @@ static void ssl_create_widget_func(PrefsPage * _page,
        GtkWidget *cert_table;
        GtkWidget *entry_in_cert_pass;
        GtkWidget *entry_out_cert_pass;
+       GtkWidget *showpwd_checkbtn;
 
        GtkWidget *vbox7;
        GtkWidget *ssl_certs_auto_accept_checkbtn;
@@ -2449,32 +2470,32 @@ static void ssl_create_widget_func(PrefsPage * _page,
        gtk_widget_show (vbox1);
        gtk_container_set_border_width (GTK_CONTAINER (vbox1), VBOX_BORDER);
 
-       vbox2 = gtkut_get_options_frame(vbox1, &pop_frame, _("POP3"));
+       vbox2 = gtkut_get_options_frame(vbox1, &pop_frame, _("POP"));
 
        CREATE_RADIO_BUTTONS(vbox2,
                             pop_nossl_radiobtn,
-                            _("Don't use SSL"),
+                            _("Don't use SSL/TLS"),
                             SSL_NONE,
                             pop_ssltunnel_radiobtn,
-                            _("Use SSL for POP3 connection"),
+                            _("Use SSL/TLS"),
                             SSL_TUNNEL,
                             pop_starttls_radiobtn,
-                            _("Use STARTTLS command to start SSL session"),
+                            _("Use STARTTLS command to start encrypted session"),
                             SSL_STARTTLS);
        g_signal_connect(G_OBJECT(pop_ssltunnel_radiobtn), "toggled",
                         G_CALLBACK(pop_ssltunnel_toggled), NULL);
        
-       vbox3 = gtkut_get_options_frame(vbox1, &imap_frame, _("IMAP4"));
+       vbox3 = gtkut_get_options_frame(vbox1, &imap_frame, _("IMAP"));
 
        CREATE_RADIO_BUTTONS(vbox3,
                             imap_nossl_radiobtn,
-                            _("Don't use SSL"),
+                            _("Don't use SSL/TLS"),
                             SSL_NONE,
                             imap_ssltunnel_radiobtn,
-                            _("Use SSL for IMAP4 connection"),
+                            _("Use SSL/TLS"),
                             SSL_TUNNEL,
                             imap_starttls_radiobtn,
-                            _("Use STARTTLS command to start SSL session"),
+                            _("Use STARTTLS command to start encrypted session"),
                             SSL_STARTTLS);
        g_signal_connect(G_OBJECT(imap_ssltunnel_radiobtn), "toggled",
                         G_CALLBACK(imap_ssltunnel_toggled), NULL);
@@ -2482,7 +2503,7 @@ static void ssl_create_widget_func(PrefsPage * _page,
        vbox4 = gtkut_get_options_frame(vbox1, &nntp_frame, _("NNTP"));
 
        nntp_nossl_radiobtn =
-               gtk_radio_button_new_with_label (NULL, _("Don't use SSL"));
+               gtk_radio_button_new_with_label (NULL, _("Don't use SSL/TLS"));
        gtk_widget_show (nntp_nossl_radiobtn);
        gtk_box_pack_start (GTK_BOX (vbox4), nntp_nossl_radiobtn,
                            FALSE, FALSE, 0);
@@ -2491,7 +2512,7 @@ static void ssl_create_widget_func(PrefsPage * _page,
                           GINT_TO_POINTER (SSL_NONE));
 
        CREATE_RADIO_BUTTON(vbox4, nntp_ssltunnel_radiobtn, nntp_nossl_radiobtn,
-                           _("Use SSL for NNTP connection"), SSL_TUNNEL);
+                           _("Use SSL/TLS"), SSL_TUNNEL);
        g_signal_connect(G_OBJECT(nntp_ssltunnel_radiobtn), "toggled",
                         G_CALLBACK(nntp_ssltunnel_toggled), NULL);
 
@@ -2499,13 +2520,13 @@ static void ssl_create_widget_func(PrefsPage * _page,
 
        CREATE_RADIO_BUTTONS(vbox5,
                             smtp_nossl_radiobtn,
-                            _("Don't use SSL (but, if necessary, use STARTTLS)"),
+                            _("Don't use SSL/TLS (but, if necessary, use STARTTLS)"),
                             SSL_NONE,
                             smtp_ssltunnel_radiobtn,
-                            _("Use SSL for SMTP connection"),
+                            _("Use SSL/TLS"),
                             SSL_TUNNEL,
                             smtp_starttls_radiobtn,
-                            _("Use STARTTLS command to start SSL session"),
+                            _("Use STARTTLS command to start encrypted session"),
                             SSL_STARTTLS);
        g_signal_connect(G_OBJECT(smtp_ssltunnel_radiobtn), "toggled",
                         G_CALLBACK(smtp_ssltunnel_toggled), NULL);
@@ -2536,9 +2557,15 @@ static void ssl_create_widget_func(PrefsPage * _page,
        gtk_misc_set_alignment(GTK_MISC(label), 1, 0.5);
        entry_in_cert_pass = gtk_entry_new();
        gtk_entry_set_visibility(GTK_ENTRY(entry_in_cert_pass), FALSE);
+       showpwd_checkbtn = gtk_check_button_new_with_label (_("Show password"));
+       gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(showpwd_checkbtn), FALSE);
+       g_signal_connect(G_OBJECT(showpwd_checkbtn), "toggled",
+                       G_CALLBACK(prefs_account_showpwd_checkbtn_toggled), entry_in_cert_pass);
        gtk_table_attach(GTK_TABLE(cert_table), label, 0, 1, 1, 2, GTK_FILL, 0, 0, 0);
        gtk_table_attach(GTK_TABLE(cert_table), entry_in_cert_pass, 1, 2, 1, 2,
                         GTK_FILL, 0, 0, 0);
+       gtk_table_attach(GTK_TABLE(cert_table), showpwd_checkbtn, 2, 3, 1, 2,
+                       GTK_FILL, 0, 0, 0);
 
        label = gtk_label_new(_("Certificate for sending"));
        gtk_misc_set_alignment(GTK_MISC(label), 1, 0.5);
@@ -2558,9 +2585,16 @@ static void ssl_create_widget_func(PrefsPage * _page,
        gtk_misc_set_alignment(GTK_MISC(label), 1, 0.5);
        entry_out_cert_pass = gtk_entry_new();
        gtk_entry_set_visibility(GTK_ENTRY(entry_out_cert_pass), FALSE);
+       showpwd_checkbtn = gtk_check_button_new_with_label (_("Show password"));
+       gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(showpwd_checkbtn), FALSE);
+       g_signal_connect(G_OBJECT(showpwd_checkbtn), "toggled",
+                       G_CALLBACK(prefs_account_showpwd_checkbtn_toggled), entry_out_cert_pass);
        gtk_table_attach(GTK_TABLE(cert_table), label, 0, 1, 3, 4, GTK_FILL, 0, 0, 0);
        gtk_table_attach(GTK_TABLE(cert_table), entry_out_cert_pass, 1, 2, 3, 4,
                         GTK_FILL, 0, 0, 0);
+       gtk_table_attach(GTK_TABLE(cert_table), showpwd_checkbtn, 2, 3, 3, 4,
+                       GTK_FILL, 0, 0, 0);
+
        gtk_widget_show_all(cert_table);
 
        g_signal_connect(G_OBJECT(in_ssl_cert_browse_button), "clicked",
@@ -2573,10 +2607,10 @@ static void ssl_create_widget_func(PrefsPage * _page,
        gtk_box_pack_start (GTK_BOX (vbox1), vbox7, FALSE, FALSE, 0);
 
        PACK_CHECK_BUTTON(vbox7, ssl_certs_auto_accept_checkbtn,
-                         _("Automatically accept valid SSL certificates"));
+                         _("Automatically accept valid SSL/TLS certificates"));
 
        PACK_CHECK_BUTTON(vbox7, use_nonblocking_ssl_checkbtn,
-                         _("Use non-blocking SSL"));
+                         _("Use non-blocking SSL/TLS"));
 
        hbox = gtk_hbox_new (FALSE, 0);
        gtk_widget_show (hbox);
@@ -2588,7 +2622,7 @@ static void ssl_create_widget_func(PrefsPage * _page,
        gtk_widget_set_size_request (hbox_spc, 16, -1);
 
        label = gtk_label_new
-               (_("Turn this off if you have SSL connection problems"));
+               (_("Turn this off if you have SSL/TLS connection problems"));
        gtk_widget_show (label);
        gtk_box_pack_start (GTK_BOX (hbox), label, FALSE, FALSE, 0);
        gtkut_widget_set_small_font_size (label);
@@ -2730,14 +2764,14 @@ static void advanced_create_widget_func(PrefsPage * _page,
        
        PACK_HBOX (hbox_popport);
        PACK_CHECK_BUTTON (hbox_popport, checkbtn_popport,
-                          _("POP3 port"));
+                          _("POP port"));
        PACK_PORT_SPINBTN (hbox_popport, spinbtn_popport);
        SET_TOGGLE_SENSITIVITY (checkbtn_popport, spinbtn_popport);
        gtk_size_group_add_widget(size_group, checkbtn_popport);
 
        PACK_HBOX (hbox_imapport);
        PACK_CHECK_BUTTON (hbox_imapport, checkbtn_imapport,
-                          _("IMAP4 port"));
+                          _("IMAP port"));
        PACK_PORT_SPINBTN (hbox_imapport, spinbtn_imapport);
        SET_TOGGLE_SENSITIVITY (checkbtn_imapport, spinbtn_imapport);
        gtk_size_group_add_widget(size_group, checkbtn_imapport);
@@ -2918,7 +2952,7 @@ static gint prefs_basic_apply(void)
        }
        if (protocol == A_POP3 &&
            *gtk_entry_get_text(GTK_ENTRY(basic_page.recvserv_entry)) == '\0') {
-               alertpanel_error(_("POP3 server is not entered."));
+               alertpanel_error(_("POP server is not entered."));
                return -1;
        }
        if (protocol == A_POP3 || protocol == A_LOCAL) {
@@ -2944,7 +2978,7 @@ static gint prefs_basic_apply(void)
        }
        if (protocol == A_IMAP4 &&
            *gtk_entry_get_text(GTK_ENTRY(basic_page.recvserv_entry)) == '\0') {
-               alertpanel_error(_("IMAP4 server is not entered."));
+               alertpanel_error(_("IMAP server is not entered."));
                return -1;
        }
        if (protocol == A_NNTP &&
@@ -3393,7 +3427,7 @@ static void register_ssl_page(void)
        static gchar *path[3];
 
        path[0] = _("Account");
-       path[1] = _("SSL");
+       path[1] = _("SSL/TLS");
        path[2] = NULL;
         
        ssl_page.page.path = path;
@@ -3882,7 +3916,7 @@ static void prefs_account_select_folder_cb(GtkWidget *widget, gpointer data)
        FolderItem *item;
        gchar *id;
 
-       item = foldersel_folder_sel(NULL, FOLDER_SEL_COPY, NULL, FALSE);
+       item = foldersel_folder_sel(NULL, FOLDER_SEL_COPY, NULL, FALSE, NULL);
        if (item && item->path) {
                id = folder_item_get_identifier(item);
                if (id) {
@@ -3982,7 +4016,7 @@ static void auto_configure_cb (GtkWidget *widget, gpointer data)
        send_data->set_port = GTK_TOGGLE_BUTTON(advanced_page.smtpport_checkbtn);
        send_data->port = GTK_SPIN_BUTTON(advanced_page.smtpport_spinbtn);
        send_data->tls_checkbtn = GTK_TOGGLE_BUTTON(ssl_page.smtp_starttls_radiobtn);
-       send_data->ssl_checkbtn = NULL;
+       send_data->ssl_checkbtn = GTK_TOGGLE_BUTTON(ssl_page.smtp_ssltunnel_radiobtn);
        send_data->default_port = 25;
        send_data->default_ssl_port = -1;
        send_data->uid_entry = NULL;
@@ -4848,6 +4882,15 @@ static void prefs_account_mailcmd_toggled(GtkToggleButton *button,
        gtk_widget_set_sensitive(basic_page.pass_entry, !use_mailcmd);
 }
 
+static void prefs_account_showpwd_checkbtn_toggled(GtkToggleButton *button,
+               gpointer user_data)
+{
+       gboolean active = gtk_toggle_button_get_active(button);
+       GtkWidget *entry = GTK_WIDGET(user_data);
+
+       gtk_entry_set_visibility(GTK_ENTRY(entry), active);
+}
+
 static void prefs_account_filter_on_recv_toggled(GtkToggleButton *button,
                                          gpointer user_data)
 {
@@ -4911,7 +4954,7 @@ gchar *prefs_account_generate_msgid(PrefsAccount *account)
 {
        gchar *addr, *tmbuf, *buf = NULL;
        GDateTime *now;
-       gchar *user_addr = account->msgid_with_addr ? account->address : NULL;
+       gchar *user_addr = account->msgid_with_addr ? g_strdup(account->address) : NULL;
 
        if (account->set_domain && account->domain) {
                buf = g_strdup(account->domain);
@@ -4962,3 +5005,44 @@ void prefs_account_unregister_page(PrefsPage *page)
 {
        prefs_pages = g_slist_remove(prefs_pages, page);
 }
+
+gchar *prefs_account_cache_dir(PrefsAccount *ac_prefs, gboolean for_server)
+{
+       gchar *dir = NULL;
+#ifdef G_OS_WIN32
+       gchar *sanitized_server;
+#endif
+
+       if (ac_prefs->protocol == A_IMAP4) {
+#ifdef G_OS_WIN32
+               sanitized_server = g_strdup(ac_prefs->recv_server);
+               g_strdelimit(sanitized_server, ":", ',');
+#endif
+               if (for_server) {
+                       dir = g_strconcat(get_imap_cache_dir(),
+                                         G_DIR_SEPARATOR_S,
+#ifdef G_OS_WIN32
+                                         sanitized_server,
+#else
+                                         ac_prefs->recv_server,
+#endif
+                                         NULL);
+               } else {
+                       dir = g_strconcat(get_imap_cache_dir(),
+                                         G_DIR_SEPARATOR_S,
+#ifdef G_OS_WIN32
+                                         sanitized_server,
+#else
+                                         ac_prefs->recv_server,
+#endif
+                                         G_DIR_SEPARATOR_S,
+                                         ac_prefs->userid,
+                                         NULL);
+               }
+#ifdef G_OS_WIN32
+               g_free(sanitized_server);
+#endif
+       }
+
+       return dir;
+}