#include "imap.h"
#include "remotefolder.h"
#include "base64.h"
+#include "combobox.h"
static gboolean cancelled;
static gboolean new_account;
static GSList *prefs_pages = NULL;
+struct BasicProtocol {
+ GtkWidget *combobox;
+ GtkWidget *label;
+ GtkWidget *descrlabel;
+};
+
static struct Basic {
GtkWidget *acname_entry;
GtkWidget *default_chkbtn;
GtkWidget *serv_frame;
GtkWidget *serv_table;
- GtkWidget *protocol_optmenu;
+ gpointer *protocol_optmenu;
GtkWidget *recvserv_label;
GtkWidget *smtpserv_label;
GtkWidget *nntpserv_label;
GtkWidget *trash_folder_entry;
} advanced;
-static void prefs_account_fix_size (void);
+static char *protocol_names[] = {
+ N_("POP3"),
+ NULL, /* APOP, deprecated */
+ NULL, /* RPOP, deprecated */
+ N_("IMAP4"),
+ N_("News (NNTP)"),
+ N_("Local mbox file"),
+ N_("None (SMTP only)")
+};
static void prefs_account_protocol_set_data_from_optmenu(PrefParam *pparam);
static void prefs_account_protocol_set_optmenu (PrefParam *pparam);
-static void prefs_account_protocol_activated (GtkMenuItem *menuitem);
+static void prefs_account_protocol_changed (GtkComboBox *combobox,
+ gpointer data);
static void prefs_account_set_string_from_optmenu (PrefParam *pparam);
static void prefs_account_set_optmenu_from_string (PrefParam *pparam);
&basic.org_entry, prefs_set_data_from_entry, prefs_set_entry},
{"protocol", NULL, &tmp_ac_prefs.protocol, P_ENUM,
- &basic.protocol_optmenu,
+ (GtkWidget **)&basic.protocol_optmenu,
prefs_account_protocol_set_data_from_optmenu,
prefs_account_protocol_set_optmenu},
gtk_entry_set_text(GTK_ENTRY(basic.org_entry),
def_ac->organization ? def_ac->organization : "");
}
- menu_set_sensitive_all
- (GTK_MENU_SHELL
- (gtk_option_menu_get_menu
- (GTK_OPTION_MENU
- (basic.protocol_optmenu))),
- TRUE);
} else
prefs_set_dialog(param);
#endif /* USE_OPENSSL */
prefs_account_advanced_create();
SET_NOTEBOOK_LABEL(notebook, _("A_dvanced"), page++);
-
- prefs_account_fix_size();
-}
-
-/**
- * prefs_account_fix_size:
- *
- * Fix the window size after creating widgets by selecting "Local"
- * protocol (currently it has the largest size of parameter widgets).
- * Without this the window gets too large.
- **/
-static void prefs_account_fix_size(void)
-{
- GtkOptionMenu *optmenu = GTK_OPTION_MENU (basic.protocol_optmenu);
- GtkWidget *menu;
- GtkWidget *menuitem;
-
- gtk_option_menu_set_history (optmenu, 4); /* local */
- menu = gtk_option_menu_get_menu (optmenu);
- menuitem = gtk_menu_get_active (GTK_MENU (menu));
- gtk_menu_item_activate (GTK_MENU_ITEM (menuitem));
-}
-
-#define SET_ACTIVATE(menuitem) \
-{ \
- g_signal_connect(G_OBJECT(menuitem), "activate", \
- G_CALLBACK(prefs_account_protocol_activated), \
- NULL); \
}
#define TABLE_YPAD 2
GtkWidget *serv_frame;
GtkWidget *vbox2;
+ GtkWidget *optmenubox;
GtkWidget *optmenu;
- GtkWidget *optmenu_menu;
- GtkWidget *menuitem;
+ GtkWidget *optlabel;
GtkWidget *serv_table;
GtkWidget *recvserv_label;
GtkWidget *smtpserv_label;
GtkWidget *pass_label;
GtkWidget *uid_entry;
GtkWidget *pass_entry;
+ GtkListStore *menu;
+ GtkTreeIter iter;
+
+ struct BasicProtocol *protocol_optmenu;
+ gint i;
vbox1 = gtk_vbox_new (FALSE, VSPACING);
gtk_widget_show (vbox1);
gtk_widget_show (label);
gtk_box_pack_start (GTK_BOX (hbox), label, FALSE, FALSE, 0);
- optmenu = gtk_option_menu_new ();
- gtk_widget_show (optmenu);
- gtk_box_pack_start (GTK_BOX (hbox), optmenu, FALSE, FALSE, 0);
+ /* Create GtkHBox for protocol combobox and label */
+ optmenubox = gtk_hbox_new(FALSE, 20);
+ gtk_widget_show(optmenubox);
+ gtk_box_pack_start (GTK_BOX (hbox), optmenubox, FALSE, FALSE, 0);
- optmenu_menu = gtk_menu_new ();
+ /* Create and populate the combobox */
+ optmenu = gtkut_sc_combobox_create(NULL, FALSE);
+ gtk_box_pack_start(GTK_BOX (optmenubox), optmenu, FALSE, FALSE, 0);
- MENUITEM_ADD (optmenu_menu, menuitem, _("POP3"), A_POP3);
- SET_ACTIVATE (menuitem);
- MENUITEM_ADD (optmenu_menu, menuitem, _("IMAP4"), A_IMAP4);
- SET_ACTIVATE (menuitem);
- MENUITEM_ADD (optmenu_menu, menuitem, _("News (NNTP)"), A_NNTP);
- SET_ACTIVATE (menuitem);
- MENUITEM_ADD (optmenu_menu, menuitem, _("Local mbox file"), A_LOCAL);
- SET_ACTIVATE (menuitem);
- MENUITEM_ADD (optmenu_menu, menuitem, _("None (SMTP only)"), A_NONE);
- SET_ACTIVATE (menuitem);
+ menu = GTK_LIST_STORE(gtk_combo_box_get_model(GTK_COMBO_BOX(optmenu)));
+ for( i = 0; i < NUM_RECV_PROTOCOLS; i++ )
+ if( protocol_names[i] != NULL )
+ COMBOBOX_ADD (menu, protocol_names[i], i);
- gtk_option_menu_set_menu (GTK_OPTION_MENU (optmenu), optmenu_menu);
+ g_signal_connect(G_OBJECT(optmenu), "changed",
+ G_CALLBACK(prefs_account_protocol_changed), NULL);
+
+ /* Create protocol label, empty for now */
+ optlabel = gtk_label_new("");
+ gtk_label_set_use_markup(GTK_LABEL(optlabel), TRUE);
+ gtk_label_set_justify(GTK_LABEL(optlabel), GTK_JUSTIFY_CENTER);
+ gtk_box_pack_start(GTK_BOX (optmenubox), optlabel, FALSE, FALSE, 0);
+
+ /* Set up a struct to store pointers to necessary widgets */
+ protocol_optmenu = g_new(struct BasicProtocol, 1);
+ protocol_optmenu->combobox = optmenu;
+ protocol_optmenu->label = optlabel;
+ protocol_optmenu->descrlabel = label;
serv_table = gtk_table_new (6, 4, FALSE);
gtk_widget_show (serv_table);
basic.serv_frame = serv_frame;
basic.serv_table = serv_table;
- basic.protocol_optmenu = optmenu;
+ basic.protocol_optmenu = (gpointer)protocol_optmenu;
basic.recvserv_label = recvserv_label;
basic.recvserv_entry = recvserv_entry;
basic.smtpserv_label = smtpserv_label;
static gint prefs_account_apply(void)
{
RecvProtocol protocol;
- GtkWidget *menu;
- GtkWidget *menuitem;
gchar *old_id = NULL;
gchar *new_id = NULL;
- menu = gtk_option_menu_get_menu(GTK_OPTION_MENU(basic.protocol_optmenu));
- menuitem = gtk_menu_get_active(GTK_MENU(menu));
- protocol = GPOINTER_TO_INT
- (g_object_get_data(G_OBJECT(menuitem), MENU_VAL_ID));
+ protocol = combobox_get_active_data(GTK_COMBO_BOX(basic.protocol_optmenu));
if (*gtk_entry_get_text(GTK_ENTRY(basic.acname_entry)) == '\0') {
alertpanel_error(_("Account name is not entered."));
static void prefs_account_protocol_set_data_from_optmenu(PrefParam *pparam)
{
- GtkWidget *menu;
- GtkWidget *menuitem;
+ struct BasicProtocol *protocol_optmenu =
+ (struct BasicProtocol *)*pparam->widget;
+ GtkWidget *optmenu = protocol_optmenu->combobox;
- menu = gtk_option_menu_get_menu(GTK_OPTION_MENU(*pparam->widget));
- menuitem = gtk_menu_get_active(GTK_MENU(menu));
- *((RecvProtocol *)pparam->data) = GPOINTER_TO_INT
- (g_object_get_data(G_OBJECT(menuitem), MENU_VAL_ID));
+ *((RecvProtocol *)pparam->data) =
+ combobox_get_active_data(GTK_COMBO_BOX(optmenu));
}
static void prefs_account_protocol_set_optmenu(PrefParam *pparam)
{
RecvProtocol protocol;
- GtkOptionMenu *optmenu = GTK_OPTION_MENU(*pparam->widget);
- GtkWidget *menu;
- GtkWidget *menuitem;
- gint index;
+ struct BasicProtocol *protocol_optmenu =
+ (struct BasicProtocol *)*pparam->widget;
+ GtkWidget *optmenu = protocol_optmenu->combobox;
+ GtkWidget *optlabel = protocol_optmenu->label;
+ GtkWidget *descrlabel = protocol_optmenu->descrlabel;
+ gchar *label = NULL;
protocol = *((RecvProtocol *)pparam->data);
- index = menu_find_option_menu_index
- (optmenu, GINT_TO_POINTER(protocol), NULL);
- if (index < 0) return;
- gtk_option_menu_set_history(optmenu, index);
-
- menu = gtk_option_menu_get_menu(optmenu);
- menu_set_insensitive_all(GTK_MENU_SHELL(menu));
- menuitem = gtk_menu_get_active(GTK_MENU(menu));
- gtk_widget_set_sensitive(menuitem, TRUE);
- gtk_menu_item_activate(GTK_MENU_ITEM(menuitem));
+ /* Set combobox to correct value even if it will be hidden, so
+ * we won't break existing accounts when saving. */
+ combobox_select_by_data(GTK_COMBO_BOX(optmenu), protocol);
+
+ /* Set up widgets accordingly */
+ if( new_account ) {
+ gtk_label_set_text(GTK_LABEL(descrlabel), _("Protocol"));
+ gtk_widget_hide(optlabel);
+ gtk_widget_show(optmenu);
+ } else {
+ gtk_label_set_text(GTK_LABEL(descrlabel), _("Protocol:"));
+ label = g_markup_printf_escaped("<b>%s</b>", protocol_names[protocol]);
+ gtk_label_set_markup(GTK_LABEL(optlabel), label);
+ g_free(label);
+ gtk_widget_hide(optmenu);
+ gtk_widget_show(optlabel);
+ }
}
static void prefs_account_imap_auth_type_set_data_from_optmenu(PrefParam *pparam)
g_list_free(children);
}
-static void prefs_account_protocol_activated(GtkMenuItem *menuitem)
+static void prefs_account_protocol_changed(GtkComboBox *combobox, gpointer data)
{
RecvProtocol protocol;
- protocol = GPOINTER_TO_INT
- (g_object_get_data(G_OBJECT(menuitem), MENU_VAL_ID));
+ protocol = combobox_get_active_data(combobox);
switch(protocol) {
case A_NNTP:
projects / claws.git / blobdiff