RSSyl: Allow use of .netrc by libcurl. Bug/enhancement #3309, by Vincent Pelletier
[claws.git] / src / plugins / spamassassin / spamassassin_gtk.c
index bf6abe2ff32ce588e9d9a0e96084b093efcfeab0..1121ec25b00505f751fb5f4cb9ed95f681d23b60 100644 (file)
@@ -1,6 +1,6 @@
 /*
  * Claws Mail -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2007 the Claws Mail Team
+ * Copyright (C) 1999-2012 the Claws Mail Team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -19,6 +19,7 @@
 
 #ifdef HAVE_CONFIG_H
 #  include "config.h"
+#include "claws-features.h"
 #endif
 
 #include "defs.h"
@@ -26,7 +27,7 @@
 #include <glib.h>
 #include <glib/gi18n.h>
 #include <gtk/gtk.h>
-#include <gtk/gtkutils.h>
+#include "gtk/gtkutils.h"
 
 #include "common/claws.h"
 #include "common/version.h"
@@ -40,6 +41,7 @@
 #include "statusbar.h"
 #include "menu.h"
 #include "addressbook.h"
+#include "combobox.h"
 
 struct SpamAssassinPage
 {
@@ -66,13 +68,6 @@ struct SpamAssassinPage
        SpamAssassinTransport   trans;
 };
 
-/*!
- *\brief       Preset addressbook book/folder items
- */
-static const gchar *whitelist_ab_folder_text [] = {
-       N_("Any")
-};
-
 struct Transport
 {
        gchar                   *name;
@@ -98,17 +93,21 @@ struct Transport transports[] = {
        { N_("Unix Socket"),    SPAMASSASSIN_TRANSPORT_UNIX,            PAGE_UNIX,    0 },
 };
 
+#ifndef USE_NEW_ADDRBOOK
 static void spamassassin_whitelist_ab_select_cb(GtkWidget *widget, gpointer data)
 {
        struct SpamAssassinPage *page = (struct SpamAssassinPage *) data;
-       gchar *folderpath = NULL;
-       gboolean ret = FALSE;
-
-       folderpath = (gchar *) gtk_entry_get_text(GTK_ENTRY(GTK_COMBO(page->whitelist_ab_folder_combo)->entry));
-       ret = addressbook_folder_selection(&folderpath);
-       if ( ret != FALSE && folderpath != NULL)
-               gtk_entry_set_text(GTK_ENTRY(GTK_COMBO(page->whitelist_ab_folder_combo)->entry), folderpath);
+       const gchar *folderpath = NULL;
+       gchar *new_path = NULL;
+
+       folderpath = gtk_entry_get_text(GTK_ENTRY(gtk_bin_get_child(GTK_BIN((page->whitelist_ab_folder_combo)))));
+       new_path = addressbook_folder_selection(folderpath);
+       if (new_path) {
+               gtk_entry_set_text(GTK_ENTRY(gtk_bin_get_child(GTK_BIN((page->whitelist_ab_folder_combo)))), new_path);
+               g_free(new_path);
+       } 
 }
+#endif
 
 static void foldersel_cb(GtkWidget *widget, gpointer data)
 {
@@ -117,7 +116,7 @@ static void foldersel_cb(GtkWidget *widget, gpointer data)
        gchar *item_id;
        gint newpos = 0;
        
-       item = foldersel_folder_sel(NULL, FOLDER_SEL_MOVE, NULL);
+       item = foldersel_folder_sel(NULL, FOLDER_SEL_MOVE, NULL, FALSE);
        if (item && (item_id = folder_item_get_identifier(item)) != NULL) {
                gtk_editable_delete_text(GTK_EDITABLE(page->save_folder), 0, -1);
                gtk_editable_insert_text(GTK_EDITABLE(page->save_folder), item_id, strlen(item_id), &newpos);
@@ -193,8 +192,15 @@ static void transport_sel_cb(GtkMenuItem *menuitem, gpointer data)
 {
        struct SpamAssassinPage *page = (struct SpamAssassinPage *) data;
        struct Transport *transport;
+       GtkTreeModel *model;
+       GtkTreeIter iter;
+       
+       cm_return_if_fail(gtk_combo_box_get_active_iter(
+                       GTK_COMBO_BOX(page->transport_optmenu), &iter));
+       
+       model = gtk_combo_box_get_model(GTK_COMBO_BOX(page->transport_optmenu));                        
+       gtk_tree_model_get(model, &iter, 1, &transport, -1);
 
-       transport = (struct Transport *) g_object_get_data(G_OBJECT(menuitem), MENU_VAL_ID);
        show_transport(page, transport);
 }
 
@@ -214,13 +220,11 @@ static void spamassassin_create_widget_func(PrefsPage * _page,
        GtkWidget *whitelist_ab_checkbtn;
        GtkWidget *whitelist_ab_folder_combo;
        GtkWidget *whitelist_ab_select_btn;
-       GList *combo_items;
 
        GtkWidget *enable_sa_checkbtn;
 
        GtkWidget *transport_label;
        GtkWidget *transport_optmenu;
-       GtkWidget *transport_menu;
 
        GtkWidget *user_label;
        GtkWidget *user_entry;
@@ -228,17 +232,17 @@ static void spamassassin_create_widget_func(PrefsPage * _page,
        GtkWidget *spamd_label;
        GtkWidget *spamd_hostname_entry;
        GtkWidget *spamd_colon_label;
-       GtkObject *spamd_port_spinbtn_adj;
+       GtkAdjustment *spamd_port_spinbtn_adj;
        GtkWidget *spamd_port_spinbtn;
        GtkWidget *spamd_socket_entry;
 
        GtkWidget *max_size_label;
-       GtkObject *max_size_spinbtn_adj;
+       GtkAdjustment *max_size_spinbtn_adj;
        GtkWidget *max_size_spinbtn;
        GtkWidget *max_size_kb_label;
 
        GtkWidget *timeout_label;
-       GtkObject *timeout_spinbtn_adj;
+       GtkAdjustment *timeout_spinbtn_adj;
        GtkWidget *timeout_spinbtn;
        GtkWidget *timeout_seconds_label;
 
@@ -250,9 +254,9 @@ static void spamassassin_create_widget_func(PrefsPage * _page,
 
        GtkWidget *mark_as_read_checkbtn;
 
-       GtkTooltips *tooltips;
-
-       tooltips = gtk_tooltips_new();
+       GtkListStore *store;
+       GtkCellRenderer *renderer;
+       GtkTreeIter iter;
 
        vbox1 = gtk_vbox_new (FALSE, VSPACING);
        gtk_widget_show (vbox1);
@@ -282,13 +286,18 @@ static void spamassassin_create_widget_func(PrefsPage * _page,
        gtk_label_set_justify(GTK_LABEL(transport_label), GTK_JUSTIFY_RIGHT);
        gtk_misc_set_alignment(GTK_MISC(transport_label), 1, 0.5);
 
-       transport_optmenu = gtk_option_menu_new();
+       store = gtk_list_store_new(2, G_TYPE_STRING, G_TYPE_POINTER);
+       transport_optmenu = gtk_combo_box_new_with_model(GTK_TREE_MODEL(store));
+       renderer = gtk_cell_renderer_text_new();
+       gtk_cell_layout_pack_start(GTK_CELL_LAYOUT(transport_optmenu),
+                                  renderer, TRUE);
+       gtk_cell_layout_set_attributes(GTK_CELL_LAYOUT(transport_optmenu),
+                                      renderer, "text", 0, NULL);
        gtk_widget_show(transport_optmenu);
 
        gtk_table_attach (GTK_TABLE (table_transport), transport_optmenu, 1, 2, 0, 1,
                        (GtkAttachOptions) (GTK_EXPAND | GTK_FILL),
                        (GtkAttachOptions) (0), 0, 0);
-       transport_menu = gtk_menu_new();
 
        user_label = gtk_label_new(_("User"));
        gtk_widget_show(user_label);
@@ -303,8 +312,7 @@ static void spamassassin_create_widget_func(PrefsPage * _page,
        gtk_table_attach (GTK_TABLE (table_transport), user_entry, 1, 2, 1, 2,
                        (GtkAttachOptions) (GTK_EXPAND | GTK_FILL),
                        (GtkAttachOptions) (0), 0, 0);
-       gtk_tooltips_set_tip(tooltips, user_entry, _("User to use with spamd server"),
-                       NULL);
+       CLAWS_SET_TIP(user_entry, _("User to use with spamd server"));
 
        spamd_label = gtk_label_new(_("spamd"));
        gtk_widget_show(spamd_label);
@@ -323,26 +331,25 @@ static void spamassassin_create_widget_func(PrefsPage * _page,
        spamd_hostname_entry = gtk_entry_new();
        gtk_widget_show(spamd_hostname_entry);
        gtk_box_pack_start(GTK_BOX(hbox_spamd), spamd_hostname_entry, TRUE, TRUE, 0);
-       gtk_tooltips_set_tip(tooltips, spamd_hostname_entry,
-                       _("Hostname or IP address of spamd server"), NULL);
+       CLAWS_SET_TIP(spamd_hostname_entry,
+                       _("Hostname or IP address of spamd server"));
 
        spamd_colon_label = gtk_label_new(":");
        gtk_widget_show(spamd_colon_label);
        gtk_box_pack_start(GTK_BOX(hbox_spamd), spamd_colon_label, FALSE, FALSE, 0);
 
-       spamd_port_spinbtn_adj = gtk_adjustment_new(783, 1, 65535, 1, 10, 10);
+       spamd_port_spinbtn_adj = GTK_ADJUSTMENT(gtk_adjustment_new(783, 1, 65535, 1, 10, 0));
        spamd_port_spinbtn = gtk_spin_button_new(GTK_ADJUSTMENT(spamd_port_spinbtn_adj), 1, 0);
        gtk_widget_show(spamd_port_spinbtn);
        gtk_box_pack_start(GTK_BOX(hbox_spamd), spamd_port_spinbtn, FALSE, FALSE, 0);
-       gtk_tooltips_set_tip(tooltips, spamd_port_spinbtn,
-                       _("Port of spamd server"), NULL);
+       CLAWS_SET_TIP(spamd_port_spinbtn,
+                       _("Port of spamd server"));
        gtk_spin_button_set_numeric(GTK_SPIN_BUTTON(spamd_port_spinbtn), TRUE);
 
        spamd_socket_entry = gtk_entry_new();
        gtk_widget_show(spamd_socket_entry);
        gtk_box_pack_start(GTK_BOX(hbox_spamd), spamd_socket_entry, TRUE, TRUE, 0);
-       gtk_tooltips_set_tip(tooltips, spamd_socket_entry, _("Path of Unix socket"),
-                       NULL);
+       CLAWS_SET_TIP(spamd_socket_entry, _("Path of Unix socket"));
 
        hbox_max_size = gtk_hbox_new(FALSE, 8);
        gtk_widget_show(hbox_max_size);
@@ -352,15 +359,15 @@ static void spamassassin_create_widget_func(PrefsPage * _page,
        gtk_widget_show(max_size_label);
        gtk_box_pack_start(GTK_BOX(hbox_max_size), max_size_label, FALSE, FALSE, 0);
 
-       max_size_spinbtn_adj = gtk_adjustment_new(250, 0, 10000, 10, 10, 10);
+       max_size_spinbtn_adj = GTK_ADJUSTMENT(gtk_adjustment_new(250, 0, 10000, 10, 10, 0));
        max_size_spinbtn = gtk_spin_button_new(GTK_ADJUSTMENT(max_size_spinbtn_adj), 1, 0);
        gtk_widget_show(max_size_spinbtn);
        gtk_box_pack_start(GTK_BOX(hbox_max_size), max_size_spinbtn, FALSE, FALSE, 0);
-       gtk_tooltips_set_tip(tooltips, max_size_spinbtn,
-                       _("Messages larger than this will not be checked"), NULL);
+       CLAWS_SET_TIP(max_size_spinbtn,
+                       _("Messages larger than this will not be checked"));
        gtk_spin_button_set_numeric(GTK_SPIN_BUTTON(max_size_spinbtn), TRUE);
 
-       max_size_kb_label = gtk_label_new(_("kB"));
+       max_size_kb_label = gtk_label_new(_("KB"));
        gtk_widget_show(max_size_kb_label);
        gtk_box_pack_start(GTK_BOX(hbox_max_size), max_size_kb_label, FALSE, FALSE, 0);
 
@@ -372,14 +379,13 @@ static void spamassassin_create_widget_func(PrefsPage * _page,
        gtk_widget_show(timeout_label);
        gtk_box_pack_start(GTK_BOX(hbox_timeout), timeout_label, FALSE, FALSE, 0);
 
-       timeout_spinbtn_adj = gtk_adjustment_new(60, 0, 10000, 10, 10, 10);
+       timeout_spinbtn_adj = GTK_ADJUSTMENT(gtk_adjustment_new(60, 0, 10000, 10, 10, 0));
        timeout_spinbtn = gtk_spin_button_new(GTK_ADJUSTMENT(timeout_spinbtn_adj), 1, 0);
        gtk_widget_show(timeout_spinbtn);
        gtk_box_pack_start(GTK_BOX(hbox_timeout), timeout_spinbtn, FALSE, FALSE, 0);
-       gtk_tooltips_set_tip(tooltips, timeout_spinbtn,
+       CLAWS_SET_TIP(timeout_spinbtn,
                        _("Maximum time allowed for checking. If the check takes longer "
-                               "it will be aborted."),
-                       NULL);
+                               "it will be aborted."));
        gtk_spin_button_set_numeric(GTK_SPIN_BUTTON(timeout_spinbtn), TRUE);
 
        timeout_seconds_label = gtk_label_new(_("seconds"));
@@ -406,16 +412,14 @@ static void spamassassin_create_widget_func(PrefsPage * _page,
        save_spam_folder_entry = gtk_entry_new();
        gtk_widget_show (save_spam_folder_entry);
        gtk_box_pack_start (GTK_BOX (hbox_save_spam), save_spam_folder_entry, TRUE, TRUE, 0);
-       gtk_tooltips_set_tip(tooltips, save_spam_folder_entry,
-                       _("Folder for storing identified spam. Leave empty to use the trash folder."),
-                       NULL);
+       CLAWS_SET_TIP(save_spam_folder_entry,
+                       _("Folder for storing identified spam. Leave empty to use the trash folder."));
 
        save_spam_folder_select = gtkut_get_browse_directory_btn(_("_Browse"));
        gtk_widget_show (save_spam_folder_select);
        gtk_box_pack_start (GTK_BOX (hbox_save_spam), save_spam_folder_select, FALSE, FALSE, 0);
-       gtk_tooltips_set_tip(tooltips, save_spam_folder_select,
-                       _("Click this button to select a folder for storing spam"),
-                       NULL);
+       CLAWS_SET_TIP(save_spam_folder_select,
+                       _("Click this button to select a folder for storing spam"));
 
        hbox_mark_as_read = gtk_hbox_new(FALSE, 8);
        gtk_widget_show(hbox_mark_as_read);
@@ -433,31 +437,18 @@ static void spamassassin_create_widget_func(PrefsPage * _page,
        whitelist_ab_checkbtn = gtk_check_button_new_with_label(_("Whitelist senders found in address book/folder"));
        gtk_widget_show(whitelist_ab_checkbtn);
        gtk_box_pack_start(GTK_BOX(hbox_whitelist), whitelist_ab_checkbtn, FALSE, FALSE, 0);
-       gtk_tooltips_set_tip(tooltips, whitelist_ab_checkbtn,
-                       _("Messages coming from your address book contacts will be received in the normal folder even if detected as spam"), NULL);
+       CLAWS_SET_TIP(whitelist_ab_checkbtn,
+                       _("Messages coming from your address book contacts will be received in the normal folder even if detected as spam"));
 
-       whitelist_ab_folder_combo = gtk_combo_new();
-       gtk_widget_show(whitelist_ab_folder_combo);
+       whitelist_ab_folder_combo = combobox_text_new(TRUE, _("Any"), NULL);
        gtk_widget_set_size_request(whitelist_ab_folder_combo, 100, -1);
-       gtk_entry_set_editable(GTK_ENTRY(GTK_COMBO(whitelist_ab_folder_combo)->entry),
-                              TRUE);
-
-       combo_items = NULL;
-       for (i = 0; i < (gint) (sizeof(whitelist_ab_folder_text) / sizeof(gchar *)); i++) {
-               combo_items = g_list_append(combo_items,
-                                           (gpointer) _(whitelist_ab_folder_text[i]));
-       }
-       gtk_combo_set_popdown_strings(GTK_COMBO(whitelist_ab_folder_combo), combo_items);
-       g_list_free(combo_items);
-
        gtk_box_pack_start (GTK_BOX (hbox_whitelist), whitelist_ab_folder_combo, TRUE, TRUE, 0);
 
-       whitelist_ab_select_btn = gtk_button_new_with_label(_("Select ..."));
+       whitelist_ab_select_btn = gtk_button_new_with_label(_("Select..."));
        gtk_widget_show (whitelist_ab_select_btn);
        gtk_box_pack_start (GTK_BOX (hbox_whitelist), whitelist_ab_select_btn, FALSE, FALSE, 0);
-       gtk_tooltips_set_tip(tooltips, whitelist_ab_select_btn,
-                       _("Click this button to select a book or folder in the address book"),
-                       NULL);
+       CLAWS_SET_TIP(whitelist_ab_select_btn,
+                       _("Click this button to select a book or folder in the address book"));
 
        SET_TOGGLE_SENSITIVITY(enable_sa_checkbtn, frame_transport);
        SET_TOGGLE_SENSITIVITY(enable_sa_checkbtn, hbox_max_size);
@@ -468,14 +459,19 @@ static void spamassassin_create_widget_func(PrefsPage * _page,
        SET_TOGGLE_SENSITIVITY(enable_sa_checkbtn, hbox_process_emails);
        SET_TOGGLE_SENSITIVITY(save_spam_checkbtn, mark_as_read_checkbtn);
        SET_TOGGLE_SENSITIVITY(whitelist_ab_checkbtn, whitelist_ab_folder_combo);
+#ifndef USE_NEW_ADDRBOOK
        SET_TOGGLE_SENSITIVITY(whitelist_ab_checkbtn, whitelist_ab_select_btn);
-
+#endif
        config = spamassassin_get_config();
 
        g_signal_connect(G_OBJECT(save_spam_folder_select), "clicked",
                        G_CALLBACK(foldersel_cb), page);
+#ifndef USE_NEW_ADDRBOOK
        g_signal_connect(G_OBJECT (whitelist_ab_select_btn), "clicked",
                         G_CALLBACK(spamassassin_whitelist_ab_select_cb), page);
+#else
+       gtk_widget_set_sensitive(GTK_WIDGET(whitelist_ab_select_btn), FALSE);
+#endif
 
        gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(enable_sa_checkbtn), config->enable);
        if (config->username != NULL)
@@ -484,9 +480,20 @@ static void spamassassin_create_widget_func(PrefsPage * _page,
                gtk_entry_set_text(GTK_ENTRY(spamd_hostname_entry), config->hostname);
        if (config->socket != NULL)
                gtk_entry_set_text(GTK_ENTRY(spamd_socket_entry), config->socket);
-       if (config->whitelist_ab_folder != NULL)
-               gtk_entry_set_text(GTK_ENTRY(GTK_COMBO(whitelist_ab_folder_combo)->entry),
-                               config->whitelist_ab_folder);
+       if (config->whitelist_ab_folder != NULL) {
+               /* translate "Any" (stored UNtranslated) */
+               if (strcasecmp(config->whitelist_ab_folder, "Any") == 0)
+                       gtk_entry_set_text(GTK_ENTRY(gtk_bin_get_child(GTK_BIN((whitelist_ab_folder_combo)))),
+                                       config->whitelist_ab_folder);
+               else
+               /* backward compatibility (when translated "Any" was stored) */
+               if (g_utf8_collate(config->whitelist_ab_folder, _("Any")) == 0)
+                       gtk_entry_set_text(GTK_ENTRY(gtk_bin_get_child(GTK_BIN((whitelist_ab_folder_combo)))),
+                                       config->whitelist_ab_folder);
+               else
+                       gtk_entry_set_text(GTK_ENTRY(gtk_bin_get_child(GTK_BIN((whitelist_ab_folder_combo)))),
+                                       config->whitelist_ab_folder);
+       }
        gtk_spin_button_set_value(GTK_SPIN_BUTTON(spamd_port_spinbtn), (float) config->port);
        gtk_spin_button_set_value(GTK_SPIN_BUTTON(max_size_spinbtn), (float) config->max_size);
        gtk_spin_button_set_value(GTK_SPIN_BUTTON(timeout_spinbtn), (float) config->timeout);
@@ -517,14 +524,11 @@ static void spamassassin_create_widget_func(PrefsPage * _page,
 
        active = 0;
        for (i = 0; i < (sizeof(transports) / sizeof(struct Transport)); i++) {
-               GtkWidget *menuitem;
-
-               menuitem = gtk_menu_item_new_with_label(gettext(transports[i].name));
-               g_object_set_data(G_OBJECT(menuitem), MENU_VAL_ID, &transports[i]);
-               g_signal_connect(G_OBJECT(menuitem), "activate",
-                               G_CALLBACK(transport_sel_cb), page);
-               gtk_widget_show(menuitem);
-               gtk_menu_append(GTK_MENU(transport_menu), menuitem);
+               
+               gtk_list_store_append(store, &iter);
+               gtk_list_store_set(store, &iter,
+                                  0, gettext(transports[i].name),
+                                  1, &transports[i], -1);
 
                if (config->transport == transports[i].transport) {
                        show_transport(page, &transports[i]);
@@ -540,8 +544,9 @@ static void spamassassin_create_widget_func(PrefsPage * _page,
                                config->enable);
                }
        }
-       gtk_option_menu_set_menu(GTK_OPTION_MENU(transport_optmenu), transport_menu);
-       gtk_option_menu_set_history(GTK_OPTION_MENU(transport_optmenu), active);
+       gtk_combo_box_set_active(GTK_COMBO_BOX(transport_optmenu), active);
+       g_signal_connect(G_OBJECT(transport_optmenu), "changed",
+                        G_CALLBACK(transport_sel_cb), page);
 
        page->page.widget = vbox1;
 }
@@ -603,7 +608,12 @@ static void spamassassin_save_func(PrefsPage *_page)
        config->whitelist_ab = gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(page->whitelist_ab));
        g_free(config->whitelist_ab_folder);
        config->whitelist_ab_folder = gtk_editable_get_chars(
-                               GTK_EDITABLE(GTK_COMBO(page->whitelist_ab_folder_combo)->entry), 0, -1);
+                               GTK_EDITABLE(gtk_bin_get_child(GTK_BIN((page->whitelist_ab_folder_combo)))), 0, -1);
+       /* store UNtranslated "Any" */
+       if (g_utf8_collate(config->whitelist_ab_folder, _("Any")) == 0) {
+               g_free(config->whitelist_ab_folder);
+               config->whitelist_ab_folder = g_strdup("Any");
+       }
 
        if (config->process_emails) {
                spamassassin_register_hook();