#endif
/* Global includes */
+#include <errno.h>
#include <glib.h>
#include <glib/gi18n.h>
#include <string.h>
static gint rssyl_cb_feed_compare(const FeedItem *a, const FeedItem *b)
{
gboolean date_eq = FALSE, url_eq = FALSE, title_eq = FALSE;
+ gboolean pubdate_eq = FALSE, moddate_eq = FALSE;
gboolean no_url = FALSE, no_date = FALSE, no_title = FALSE;
+ gboolean no_pubdate = FALSE, no_moddate = FALSE;
gchar *atit = NULL, *btit = NULL;
g_return_val_if_fail(a != NULL && b != NULL, 1);
} else
no_url = TRUE;
+ /* Now we prepare some boolean flags to help us express comparing choices
+ * later on. */
+
+ /* Title */
if( (a->title != NULL) && (b->title != NULL) ) {
atit = conv_unmime_header(a->title, CS_UTF_8, FALSE);
btit = conv_unmime_header(b->title, CS_UTF_8, FALSE);
} else
no_title = TRUE;
- /* If there's no 'published' timestamp for the item, we can only judge
- * by item url - 'modified' timestamp can have changed if the item was
- * updated recently. */
- if( b->date_published <= 0 ) {
- if( b->date_modified > 0 ) {
- /* If the item has 'modified' timestamp, we can only rely on url
- * and title at this point. */
- if( (url_eq || no_url) && title_eq
- && (a->date_modified >= b->date_modified) )
- return 0;
- else
- return 1;
- } else {
- /* No timestamp of any kind, we'll just assume if both title and url
- * match, we found the right item. Items in such feeds rarely change,
- * and if they do, there's no way we can really */
- if( (url_eq || no_url) && title_eq )
- return 0;
- else
- return 1;
- }
+ /* Published date */
+ if (b->date_published <= 0) {
+ no_pubdate = TRUE;
+ } else {
+ if (a->date_published == b->date_published)
+ pubdate_eq = TRUE;
}
- /* Check if 'published' or at least 'modified' timestamps match */
- if( ((a->date_published > 0) && (b->date_published > 0) &&
- (a->date_published == b->date_published))
- || ((a->date_modified > 0) && (b->date_modified > 0) &&
- (a->date_modified == b->date_modified))) {
- date_eq = TRUE;
- } else
+ /* Modified date */
+ if (b->date_modified <= 0) {
+ no_moddate = TRUE;
+ } else {
+ if (a->date_modified == b->date_modified)
+ moddate_eq = TRUE;
+ }
+
+ if (no_pubdate && no_moddate)
no_date = TRUE;
- /* If 'published' time and item url match, it is reasonable to assume
+ if (pubdate_eq || (no_pubdate && moddate_eq))
+ date_eq = TRUE;
+
+ /* If timestamp and url match, it is reasonable to assume
* we found our item. */
- if( (no_url || url_eq) && date_eq )
+ if (url_eq && date_eq)
+ return 0;
+
+ /* Likewise if timestamp and title match. */
+ if (title_eq && date_eq)
return 0;
/* There is no timestamp and the url matches (or there is none),
MsgPermFlags oldperm_flags = 0;
MsgInfo *msginfo;
FILE *f;
- gint fd, d, dif, errno = 0;
+ gint fd, d, dif;
time_t tmpd;
gchar *meta_charset = NULL;
gchar *baseurl = NULL;
feed_item_set_title(feed_item, rssyl_format_string(feed_item_get_title(feed_item), TRUE, TRUE));
debug_print("RSSyl: fixing up URL\n");
feed_item_set_url(feed_item, rssyl_format_string(feed_item_get_url(feed_item),
- TRUE, TRUE));
+ FALSE, TRUE));
if( feed_item_get_id(feed_item) != NULL ) {
debug_print("RSSyl: fixing up ID\n");
feed_item_set_id(feed_item, rssyl_format_string(feed_item_get_id(feed_item),
- TRUE, TRUE));
+ FALSE, TRUE));
}
/* If there's a summary, but no text, use summary as text. */
dirname = folder_item_get_path(&ritem->item);
template = g_strconcat(dirname, G_DIR_SEPARATOR_S,
RSSYL_TMP_TEMPLATE, NULL);
- if ((fd = mkstemp(template)) < 0) {
- g_warning("Couldn't mkstemp('%s'), not adding message!\n", template);
+ if ((fd = g_mkstemp(template)) < 0) {
+ g_warning("Couldn't g_mkstemp('%s'), not adding message!\n", template);
g_free(template);
return;
}
/* Unset unread+new if the changed item wasn't set unread and user
* doesn't want to see it unread because of the change. */
- if (!(oldperm_flags & MSG_UNREAD) && (ritem->silent_update == 2
- || (ritem->silent_update == 1 && dif == EXISTS_CHANGED_TEXTONLY)))
- procmsg_msginfo_unset_flags(
- folder_item_get_msginfo((FolderItem *)ritem, d), MSG_NEW | MSG_UNREAD, 0);
+ if (dif != EXISTS_NEW) {
+ if (!(oldperm_flags & MSG_UNREAD) && (ritem->silent_update == 2
+ || (ritem->silent_update == 1 && dif == EXISTS_CHANGED_TEXTONLY)))
+ procmsg_msginfo_unset_flags(
+ folder_item_get_msginfo((FolderItem *)ritem, d), MSG_NEW | MSG_UNREAD, 0);
+ }
debug_print("RSSyl: folder_item_add_msg(): %d\n", d);
}
projects / claws.git / blobdiff