More null pointer dereference fixes
[claws.git] / src / plugins / pgpcore / sgpgme.c
index 52f6d36ba3cbb15d397d24961f6423331322b467..5d0ecacc70ce10e7318beba27978f5f7b9987084 100644 (file)
@@ -1,6 +1,6 @@
 /*
  * Claws Mail -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2012 the Claws Mail team
+ * Copyright (C) 1999-2015 the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  *
  * You should have received a copy of the GNU General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
- * 
+ *
  */
+
 #ifdef HAVE_CONFIG_H
 #  include "config.h"
 #include "claws-features.h"
 #endif
+
 #ifdef USE_GPGME
 
 #include <time.h>
@@ -85,7 +85,6 @@ gpgme_verify_result_t sgpgme_verify_signature(gpgme_ctx_t ctx, gpgme_data_t sig,
 
 SignatureStatus sgpgme_sigstat_gpgme_to_privacy(gpgme_ctx_t ctx, gpgme_verify_result_t status)
 {
-       unsigned long validity = 0;
        gpgme_signature_t sig = NULL;
        
        if (GPOINTER_TO_INT(status) == -GPG_ERR_SYSTEM_ERROR) {
@@ -103,12 +102,11 @@ SignatureStatus sgpgme_sigstat_gpgme_to_privacy(gpgme_ctx_t ctx, gpgme_verify_re
                debug_print("sig == NULL\n");
                return SIGNATURE_UNCHECKED;
        }
-       validity = sig->validity;
 
        debug_print("err code %d\n", gpg_err_code(sig->status));
        switch (gpg_err_code(sig->status)) {
        case GPG_ERR_NO_ERROR:
-               switch (gpg_err_code(sig->validity)) {
+               switch (sig->validity) {
                case GPGME_VALIDITY_NEVER:
                        return SIGNATURE_INVALID;
                case GPGME_VALIDITY_UNKNOWN:
@@ -155,6 +153,22 @@ static const gchar *get_validity_str(unsigned long validity)
        }
 }
 
+static const gchar *get_owner_trust_str(unsigned long owner_trust)
+{
+       switch (gpgme_err_code(owner_trust)) {
+       case GPGME_VALIDITY_NEVER:
+               return _("Untrusted");
+       case GPGME_VALIDITY_MARGINAL:
+               return _("Marginal");
+       case GPGME_VALIDITY_FULL:
+               return _("Full");
+       case GPGME_VALIDITY_ULTIMATE:
+               return _("Ultimate");
+       default:
+               return _("Unknown");
+       }
+}
+
 static gchar *extract_name(const char *uid)
 {
        if (uid == NULL)
@@ -199,7 +213,7 @@ gchar *sgpgme_sigstat_info_short(gpgme_ctx_t ctx, gpgme_verify_result_t status)
                if (!warned)
                        alertpanel_error(_("PGP Core: Can't get key - no gpg-agent running."));
                else
-                       g_warning(_("PGP Core: Can't get key - no gpg-agent running."));
+                       g_warning("PGP Core: Can't get key - no gpg-agent running.");
                warned = TRUE;
        } else if (gpg_err_code(err) != GPG_ERR_NO_ERROR && gpg_err_code(err) != GPG_ERR_EOF) {
                return g_strdup_printf(_("The signature can't be checked - %s"), 
@@ -209,39 +223,47 @@ gchar *sgpgme_sigstat_info_short(gpgme_ctx_t ctx, gpgme_verify_result_t status)
                uname = extract_name(key->uids->uid);
        else
                uname = g_strdup("<?>");
+
        switch (gpg_err_code(sig->status)) {
        case GPG_ERR_NO_ERROR:
-               switch (gpg_err_code(sig->validity)) {
-               case GPGME_VALIDITY_FULL:
+               switch (key->uids?key->uids->validity:GPGME_VALIDITY_UNKNOWN) {
                case GPGME_VALIDITY_ULTIMATE:
-                       result = g_strdup_printf(_("Good signature from %s."), uname);
+                       result = g_strdup_printf(_("Good signature from \"%s\" [ultimate]"), uname);
+                       break;
+               case GPGME_VALIDITY_FULL:
+                       result = g_strdup_printf(_("Good signature from \"%s\" [full]"), uname);
                        break;
                case GPGME_VALIDITY_MARGINAL:
+                       result = g_strdup_printf(_("Good signature from \"%s\" [marginal]"), uname);
+                       break;
                case GPGME_VALIDITY_UNKNOWN:
                case GPGME_VALIDITY_UNDEFINED:
                case GPGME_VALIDITY_NEVER:
                default:
-                       result = g_strdup_printf(_("Good signature (untrusted) from %s."), uname);
+                       result = g_strdup_printf(_("Good signature from \"%s\""), uname);
                        break;
-               }
+               }
                break;
        case GPG_ERR_SIG_EXPIRED:
-               result = g_strdup_printf(_("Expired signature from %s."), uname);
+               result = g_strdup_printf(_("Expired signature from \"%s\""), uname);
                break;
        case GPG_ERR_KEY_EXPIRED:
-               result = g_strdup_printf(_("Expired key from %s."), uname);
+               result = g_strdup_printf(_("Good signature from \"%s\", but the key has expired"), uname);
+               break;
+       case GPG_ERR_CERT_REVOKED:
+               result = g_strdup_printf(_("Good signature from \"%s\", but the key has been revoked"), uname);
                break;
        case GPG_ERR_BAD_SIGNATURE:
-               result = g_strdup_printf(_("Bad signature from %s."), uname);
+               result = g_strdup_printf(_("Bad signature from \"%s\""), uname);
                break;
        case GPG_ERR_NO_PUBKEY: {
                gchar *id = g_strdup(sig->fpr + strlen(sig->fpr)-8);
-               result = g_strdup_printf(_("Key 0x%s not available to verify this signature."), id);
+               result = g_strdup_printf(_("Key 0x%s not available to verify this signature"), id);
                g_free(id);
                break;
                }
        default:
-               result = g_strdup(_("The signature has not been checked."));
+               result = g_strdup(_("The signature has not been checked"));
                break;
        }
        if (result == NULL)
@@ -267,7 +289,8 @@ gchar *sgpgme_sigstat_info_full(gpgme_ctx_t ctx, gpgme_verify_result_t status)
        sig = status->signatures;
        
        while (sig) {
-               gpgme_user_id_t user = NULL;
+               char buf[100];
+               struct tm lt;
                gpgme_key_t key;
                gpgme_error_t err;
                const gchar *keytype, *keyid, *uid;
@@ -282,31 +305,42 @@ gchar *sgpgme_sigstat_info_full(gpgme_ctx_t ctx, gpgme_verify_result_t status)
                        goto bail;
                }
                if (key) {
-                       user = key->uids;
                        keytype = gpgme_pubkey_algo_name(
                                        key->subkeys->pubkey_algo);
                        keyid = key->subkeys->keyid;
-                       uid = user->uid;
+                       uid = key->uids->uid;
                } else {
                        keytype = "?";
                        keyid = "?";
                        uid = "?";
                }
+
+               memset(buf, 0, sizeof(buf));
+               fast_strftime(buf, sizeof(buf)-1, prefs_common_get_prefs()->date_format, localtime_r(&sig->timestamp, &lt));
                g_string_append_printf(siginfo,
-                       _("Signature made using %s key ID %s\n"),
-                       keytype, keyid);
+                       _("Signature made on %s using %s key ID %s\n"),
+                       buf, keytype, keyid);
                
                switch (gpg_err_code(sig->status)) {
                case GPG_ERR_NO_ERROR:
-               case GPG_ERR_KEY_EXPIRED:
                        g_string_append_printf(siginfo,
                                _("Good signature from uid \"%s\" (Validity: %s)\n"),
-                               uid, get_validity_str(user?user->validity:GPGME_VALIDITY_UNKNOWN));
+                               uid, get_validity_str((key && key->uids) ? key->uids->validity:GPGME_VALIDITY_UNKNOWN));
+                       break;
+               case GPG_ERR_KEY_EXPIRED:
+                       g_string_append_printf(siginfo,
+                               _("Expired key uid \"%s\"\n"),
+                               uid);
                        break;
                case GPG_ERR_SIG_EXPIRED:
                        g_string_append_printf(siginfo,
                                _("Expired signature from uid \"%s\" (Validity: %s)\n"),
-                               uid, get_validity_str(user?user->validity:GPGME_VALIDITY_UNKNOWN));
+                               uid, get_validity_str((key && key->uids) ? key->uids->validity:GPGME_VALIDITY_UNKNOWN));
+                       break;
+               case GPG_ERR_CERT_REVOKED:
+                       g_string_append_printf(siginfo,
+                               _("Revoked key uid \"%s\"\n"),
+                               uid);
                        break;
                case GPG_ERR_BAD_SIGNATURE:
                        g_string_append_printf(siginfo,
@@ -318,15 +352,19 @@ gchar *sgpgme_sigstat_info_full(gpgme_ctx_t ctx, gpgme_verify_result_t status)
                }
                if (sig->status != GPG_ERR_BAD_SIGNATURE) {
                        gint j = 1;
-                       user = user ? user->next : NULL;
-                       while (user != NULL) {
-                               g_string_append_printf(siginfo,
-                                       _("                    uid \"%s\" (Validity: %s)\n"),
-                                       user->uid,
-                                       get_validity_str(user->validity));
-                               j++;
-                               user = user->next;
+                       if (key) {
+                               key->uids = key->uids ? key->uids->next : NULL;
+                               while (key->uids != NULL) {
+                                       g_string_append_printf(siginfo,
+                                               _("                    uid \"%s\" (Validity: %s)\n"),
+                                               key->uids->uid,
+                                               key->uids->revoked==TRUE?_("Revoked"):get_validity_str(key->uids->validity));
+                                       j++;
+                                       key->uids = key->uids->next;
+                               }
                        }
+                       g_string_append_printf(siginfo,_("Owner Trust: %s\n"),
+                                              key ? get_owner_trust_str(key->owner_trust) : _("No key!"));
                        g_string_append(siginfo,
                                _("Primary key fingerprint:"));
                        const char* primary_fpr = NULL;
@@ -375,20 +413,12 @@ gpgme_data_t sgpgme_data_from_mimeinfo(MimeInfo *mimeinfo)
        gpgme_data_t data = NULL;
        gpgme_error_t err;
        FILE *fp = g_fopen(mimeinfo->data.filename, "rb");
-       gchar *tmp_file = NULL;
 
        if (!fp) 
                return NULL;
 
-       tmp_file = get_tmp_file();
-       copy_file_part(fp, mimeinfo->offset, mimeinfo->length, tmp_file);
+       err = gpgme_data_new_from_filepart(&data, NULL, fp, mimeinfo->offset, mimeinfo->length);
        fclose(fp);
-       fp = NULL;
-       debug_print("tmp file %s\n", tmp_file);
-       
-       err = gpgme_data_new_from_file(&data, tmp_file, 1);
-       claws_unlink(tmp_file);
-       g_free(tmp_file);
 
        debug_print("data %p (%d %d)\n", (void *)&data, mimeinfo->offset, mimeinfo->length);
        if (err) {
@@ -439,7 +469,7 @@ gpgme_data_t sgpgme_decrypt_verify(gpgme_data_t cipher, gpgme_verify_result_t *s
 
                err = cm_gpgme_data_rewind(plain);
                if (err) {
-                       debug_print("can't seek (%d %d %s)\n", err, errno, strerror(errno));
+                       debug_print("can't seek (%d %d %s)\n", err, errno, g_strerror(errno));
                }
 
                debug_print("decrypted.\n");
@@ -456,7 +486,7 @@ gpgme_data_t sgpgme_decrypt_verify(gpgme_data_t cipher, gpgme_verify_result_t *s
 
                err = cm_gpgme_data_rewind(plain);
                if (err) {
-                       debug_print("can't seek (%d %d %s)\n", err, errno, strerror(errno));
+                       debug_print("can't seek (%d %d %s)\n", err, errno, g_strerror(errno));
                }
 
                debug_print("decrypted.\n");
@@ -518,7 +548,7 @@ gboolean sgpgme_setup_signers(gpgme_ctx_t ctx, PrefsAccount *account,
 
        if (config->sign_key != SIGN_KEY_DEFAULT) {
                const gchar *keyid;
-               gpgme_key_t key, key2;
+               gpgme_key_t key, found_key;
                gpgme_error_t err;
 
                if (config->sign_key == SIGN_KEY_BY_FROM)
@@ -528,78 +558,71 @@ gboolean sgpgme_setup_signers(gpgme_ctx_t ctx, PrefsAccount *account,
                else
                        goto bail;
 
-               err = gpgme_op_keylist_start(ctx, keyid, 1);
-               if (!err) {
-                       do {
-                               err = gpgme_op_keylist_next(ctx, &key);
-                               if (!err && key && key->protocol == gpgme_get_protocol(ctx) &&
-                                   !key->expired && !key->revoked && !key->disabled)
-                                       break;
-                               if (!err && key && key->protocol != gpgme_get_protocol(ctx)) {
-                                       debug_print("skipping a key (wrong protocol %d)\n", key->protocol);
-                                       gpgme_key_release(key);
-                               }
-                               if (!err && key && (key->expired || key->revoked || key->disabled)) {
-                                       
-                                       debug_print("skipping a key");
-                                       if (key->expired) 
-                                               debug_print(" expired");
-                                       if (key->revoked) 
-                                               debug_print(" revoked");
-                                       if (key->disabled) 
-                                               debug_print(" disabled");
-                                       debug_print("\n");
-                                       gpgme_key_release(key);
-                               }
-                       } while (!err);
-               }
-               if (err) {
-                       g_warning("setup_signers start: %s", gpgme_strerror(err));
-                       privacy_set_error(_("Secret key not found (%s)"), gpgme_strerror(err));
-                       goto bail;
-               }
-               
-               do {
-                       err = gpgme_op_keylist_next(ctx, &key2);
-                       if (!err && key2 && key2->protocol == gpgme_get_protocol(ctx) &&
-                           !key2->expired && !key2->revoked && !key2->disabled)
-                               break;
-                       if (!err && key2 && key2->protocol != gpgme_get_protocol(ctx)) {
-                               debug_print("skipping a key (wrong protocol %d)\n", key2->protocol);
-                               gpgme_key_release(key2);
+                found_key = NULL;
+               /* Look for any key, not just private ones, or GPGMe doesn't
+                * correctly set the revoked flag. */
+               err = gpgme_op_keylist_start(ctx, keyid, 0);
+               while ((err = gpgme_op_keylist_next(ctx, &key)) == 0) {
+                       if (key == NULL)
+                               continue;
+
+                       if (!key->can_sign)
+                               continue;
+
+                       if (key->protocol != gpgme_get_protocol(ctx)) {
+                               debug_print("skipping a key (wrong protocol %d)\n", key->protocol);
+                               gpgme_key_release(key);
+                               continue;
                        }
-                       if (!err && key2 && (key2->expired || key2->revoked || key2->disabled)) {
-                                       debug_print("skipping a key");
-                                       if (key2->expired) 
-                                               debug_print(" expired");
-                                       if (key2->revoked) 
-                                               debug_print(" revoked");
-                                       if (key2->disabled) 
-                                               debug_print(" disabled");
-                                       debug_print("\n");
-                               gpgme_key_release(key2);
+
+                       if (key->expired) {
+                               debug_print("skipping a key, expired");
+                               gpgme_key_release(key);
+                               continue;
                        }
-               } while (!err);
-               if (!err) {
-                       gpgme_key_release(key2);
-                       g_warning("ambiguous specification of secret key '%s'\n",
-                               keyid);
-                       privacy_set_error(_("Secret key specification is ambiguous"));
-                       goto bail;
-               }
-               
+                       if (key->revoked) {
+                               debug_print("skipping a key, revoked");
+                               gpgme_key_release(key);
+                               continue;
+                       }
+                       if (key->disabled) {
+                               debug_print("skipping a key, disabled");
+                               gpgme_key_release(key);
+                               continue;
+                       }
+
+                       if (found_key != NULL) {
+                               gpgme_key_release(key);
+                               gpgme_op_keylist_end(ctx);
+                               g_warning("ambiguous specification of secret key '%s'", keyid);
+                               privacy_set_error(_("Secret key specification is ambiguous"));
+                               goto bail;
+                       }
+
+                       found_key = key;
+                }
                gpgme_op_keylist_end(ctx);
-               err = gpgme_signers_add(ctx, key);
-               debug_print("got key (proto %d (pgp %d, smime %d).\n", key->protocol,
-                               GPGME_PROTOCOL_OpenPGP, GPGME_PROTOCOL_CMS);
-               gpgme_key_release(key);
-               
+
+               if (found_key == NULL) {
+                       g_warning("setup_signers start: %s", gpgme_strerror(err));
+                       privacy_set_error(_("Secret key not found (%s)"), gpgme_strerror(err));
+                       goto bail;
+                }
+
+               err = gpgme_signers_add(ctx, found_key);
+               debug_print("got key (proto %d (pgp %d, smime %d).\n",
+                           found_key->protocol, GPGME_PROTOCOL_OpenPGP,
+                           GPGME_PROTOCOL_CMS);
+               gpgme_key_release(found_key);
+
                if (err) {
-                       g_warning("error adding secret key: %s\n", gpgme_strerror(err));
-                       privacy_set_error(_("Error setting secret key: %s"), gpgme_strerror(err));
+                       g_warning("error adding secret key: %s",
+                                 gpgme_strerror(err));
+                       privacy_set_error(_("Error setting secret key: %s"),
+                                         gpgme_strerror(err));
                        goto bail;
                }
-       }
+        }
 
        prefs_gpg_account_free_config(config);
 
@@ -611,17 +634,68 @@ bail:
 
 void sgpgme_init()
 {
+       gchar *ctype_locale = NULL, *messages_locale = NULL;
+       gchar *ctype_utf8_locale = NULL, *messages_utf8_locale = NULL;
+
        gpgme_engine_info_t engineInfo;
+
+       if (strcmp(prefs_gpg_get_config()->gpg_path, "") != 0 &&
+           access(prefs_gpg_get_config()->gpg_path, X_OK) != -1)
+               gpgme_set_engine_info(GPGME_PROTOCOL_OpenPGP,prefs_gpg_get_config()->gpg_path, NULL);
+
        if (gpgme_check_version("1.0.0")) {
 #ifdef LC_CTYPE
-               gpgme_set_locale(NULL, LC_CTYPE, setlocale(LC_CTYPE, NULL));
+               debug_print("setting gpgme CTYPE locale\n");
+#ifdef G_OS_WIN32
+               ctype_locale = g_win32_getlocale();
+#else
+               ctype_locale = g_strdup(setlocale(LC_CTYPE, NULL));
+#endif
+               if (ctype_locale) {
+                       debug_print("setting gpgme CTYPE locale to: %s\n", ctype_locale);
+                       if (strchr(ctype_locale, '.'))
+                               *(strchr(ctype_locale, '.')) = '\0';
+                       else if (strchr(ctype_locale, '@'))
+                               *(strchr(ctype_locale, '@')) = '\0';
+                       ctype_utf8_locale = g_strconcat(ctype_locale, ".UTF-8", NULL);
+
+                       debug_print("setting gpgme locale to UTF8: %s\n", ctype_utf8_locale ? ctype_utf8_locale : "NULL");
+                       gpgme_set_locale(NULL, LC_CTYPE, ctype_utf8_locale);
+
+                       debug_print("done\n");
+                       g_free(ctype_utf8_locale);
+                       g_free(ctype_locale);
+               } else {
+                       debug_print("couldn't set gpgme CTYPE locale\n");
+               }
 #endif
 #ifdef LC_MESSAGES
-               gpgme_set_locale(NULL, LC_MESSAGES, setlocale(LC_MESSAGES, NULL));
+               debug_print("setting gpgme MESSAGES locale\n");
+#ifdef G_OS_WIN32
+               messages_locale = g_win32_getlocale();
+#else
+               messages_locale = g_strdup(setlocale(LC_MESSAGES, NULL));
+#endif
+               if (messages_locale) {
+                       debug_print("setting gpgme MESSAGES locale to: %s\n", messages_locale);
+                       if (strchr(messages_locale, '.'))
+                               *(strchr(messages_locale, '.')) = '\0';
+                       else if (strchr(messages_locale, '@'))
+                               *(strchr(messages_locale, '@')) = '\0';
+                       messages_utf8_locale = g_strconcat(messages_locale, ".UTF-8", NULL);
+                       debug_print("setting gpgme locale to UTF8: %s\n", messages_utf8_locale ? messages_utf8_locale : "NULL");
+
+                       gpgme_set_locale(NULL, LC_MESSAGES, messages_utf8_locale);
+
+                       debug_print("done\n");
+                       g_free(messages_utf8_locale);
+                       g_free(messages_locale);
+               } else {
+                       debug_print("couldn't set gpgme MESSAGES locale\n");
+               }
 #endif
                if (!gpgme_get_engine_info(&engineInfo)) {
                        while (engineInfo) {
-#ifndef G_OS_WIN32
                                debug_print("GpgME Protocol: %s\n"
                                            "Version: %s (req %s)\n"
                                            "Executable: %s\n",
@@ -629,7 +703,6 @@ void sgpgme_init()
                                        engineInfo->version ? engineInfo->version:"???",
                                        engineInfo->req_version ? engineInfo->req_version:"???",
                                        engineInfo->file_name ? engineInfo->file_name:"???");
-#endif
                                if (engineInfo->protocol == GPGME_PROTOCOL_OpenPGP
                                &&  gpgme_engine_check_version(engineInfo->protocol) != 
                                        GPG_ERR_NO_ERROR) {
@@ -747,9 +820,9 @@ again:
        }
        
        key_parms = g_strdup_printf("<GnupgKeyParms format=\"internal\">\n"
-                                       "Key-Type: DSA\n"
-                                       "Key-Length: 1024\n"
-                                       "Subkey-Type: ELG-E\n"
+                                       "Key-Type: RSA\n"
+                                       "Key-Length: 2048\n"
+                                       "Subkey-Type: RSA\n"
                                        "Subkey-Length: 2048\n"
                                        "Name-Real: %s\n"
                                        "Name-Email: %s\n"
@@ -913,7 +986,14 @@ void *sgpgme_data_release_and_get_mem(gpgme_data_t data, size_t *len)
        /* I know it's deprecated, but we don't compile with _LARGEFILE */
        cm_gpgme_data_rewind(data);
        while ((r = gpgme_data_read(data, buf, BUFSIZ)) > 0) {
-               result = realloc(result, r + w);
+               void *rresult = realloc(result, r + w);
+               if (rresult == NULL) {
+                       g_warning("can't allocate memory");
+                       if (result != NULL)
+                               free(result);
+                       return NULL;
+               }
+               result = rresult;
                memcpy(result+w, buf, r);
                w += r;
        }