/* select-keys.c - GTK+ based key selection
- * Copyright (C) 2001-2007 Werner Koch (dd9jn) and the Claws Mail team
+ * Copyright (C) 2001-2016 Werner Koch (dd9jn) and the Claws Mail team
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
- *
*/
#ifdef HAVE_CONFIG_H
COL_ALGO,
COL_KEYID,
COL_NAME,
- COL_EMAIL,
- COL_VALIDITY,
+ COL_ADDRESS,
+ COL_TRUST,
+ COL_PTR,
N_COL_TITLES
};
+#define COL_ALGO_WIDTH 70
+#define COL_KEYID_WIDTH 120
+#define COL_NAME_WIDTH 115
+#define COL_ADDRESS_WIDTH 140
+#define COL_TRUST_WIDTH 20
+
struct select_keys_s {
int okay;
GtkWidget *window;
GtkLabel *toplabel;
- GtkCMCList *clist;
+ GtkWidget *view;
const char *pattern;
unsigned int num_keys;
gpgme_key_t *kset;
};
-static void set_row (GtkCMCList *clist, gpgme_key_t key, gpgme_protocol_t proto);
-static gpgme_key_t fill_clist (struct select_keys_s *sk, const char *pattern,
+static void set_row (GtkListStore *store, gpgme_key_t key, gpgme_protocol_t proto);
+static gpgme_key_t fill_view (struct select_keys_s *sk, const char *pattern,
gpgme_protocol_t proto);
static void create_dialog (struct select_keys_s *sk);
static void open_dialog (struct select_keys_s *sk);
static void cancel_btn_cb (GtkWidget *widget, gpointer data);
static void dont_encrypt_btn_cb (GtkWidget *widget, gpointer data);
static void other_btn_cb (GtkWidget *widget, gpointer data);
-static void sort_keys (struct select_keys_s *sk, enum col_titles column);
-static void sort_keys_name (GtkWidget *widget, gpointer data);
-static void sort_keys_email (GtkWidget *widget, gpointer data);
-static gboolean use_untrusted (gpgme_key_t, gpgme_protocol_t proto);
+static gboolean use_untrusted (gpgme_key_t, gpgme_user_id_t uid, gpgme_protocol_t proto);
static void
update_progress (struct select_keys_s *sk, int running, const char *pattern)
do {
sk.pattern = recp_names? recp_names->data:NULL;
- sk.proto = proto;
- gtk_cmclist_clear (sk.clist);
- key = fill_clist (&sk, sk.pattern, proto);
- update_progress (&sk, 0, sk.pattern);
+ sk.proto = proto;
+ if (sk.view != NULL) {
+ GtkTreeModel *model =
+ gtk_tree_view_get_model(GTK_TREE_VIEW(sk.view));
+ gtk_list_store_clear(GTK_LIST_STORE(model));
+ }
+ key = fill_view (&sk, sk.pattern, proto);
+ update_progress (&sk, 0, sk.pattern ? sk.pattern : "NULL");
if (!key) {
gtk_widget_show_all (sk.window);
gtk_main ();
}
static void
-destroy_key (gpointer data)
-{
- gpgme_key_t key = data;
- gpgme_key_release (key);
-}
-
-static void
-set_row (GtkCMCList *clist, gpgme_key_t key, gpgme_protocol_t proto)
+set_row (GtkListStore *store, gpgme_key_t key, gpgme_protocol_t proto)
{
- const char *s;
- const char *text[N_COL_TITLES];
- char *algo_buf;
- int row;
+ const gchar *s;
+ gchar *algo_buf, *name, *address;
+ GtkTreeIter iter;
gsize by_read = 0, by_written = 0;
gchar *ret_str = NULL;
/* first check whether the key is capable of encryption which is not
* the case for revoked, expired or sign-only keys */
- if (!key->can_encrypt || key->revoked || key->expired)
+ if (!key->can_encrypt || key->revoked || key->expired || key->disabled)
return;
algo_buf = g_strdup_printf ("%du/%s",
key->subkeys->length,
gpgme_pubkey_algo_name(key->subkeys->pubkey_algo) );
- text[COL_ALGO] = algo_buf;
-
- s = key->subkeys->keyid;
- if (strlen (s) == 16)
- s += 8; /* show only the short keyID */
- text[COL_KEYID] = s;
-
s = key->uids->name;
if (!s || !*s)
if (ret_str && by_written) {
s = ret_str;
}
- text[COL_NAME] = s;
+ name = g_strdup(s);
if (proto == GPGME_PROTOCOL_CMS && (!key->uids->email || !*key->uids->email)) {
gpgme_user_id_t uid = key->uids->next;
if (ret_str && by_written) {
s = ret_str;
}
- text[COL_EMAIL] = s;
+ address = g_strdup(s);
switch (key->uids->validity)
{
s = _("Unknown");
break;
}
- text[COL_VALIDITY] = s;
- row = gtk_cmclist_append (clist, (gchar**)text);
+ gtk_list_store_append(store, &iter);
+ gtk_list_store_set(store, &iter,
+ COL_ALGO, algo_buf,
+ COL_KEYID, key->subkeys->keyid,
+ COL_NAME, name,
+ COL_ADDRESS, address,
+ COL_TRUST, s,
+ COL_PTR, key,
+ -1);
+ gpgme_key_ref(key);
+
+ g_free(name);
+ g_free(address);
g_free (algo_buf);
-
- gtk_cmclist_set_row_data_full (clist, row, key, destroy_key);
}
static gpgme_key_t
-fill_clist (struct select_keys_s *sk, const char *pattern, gpgme_protocol_t proto)
+fill_view (struct select_keys_s *sk, const char *pattern, gpgme_protocol_t proto)
{
- GtkCMCList *clist;
+ GtkWidget *view;
+ GtkTreeModel *model;
+ GtkTreeSelection *sel;
+ GtkTreeIter iter;
gpgme_ctx_t ctx;
gpgme_error_t err;
gpgme_key_t key;
int num_results = 0;
gboolean exact_match = FALSE;
gpgme_key_t last_key = NULL;
- g_return_val_if_fail (sk, NULL);
- clist = sk->clist;
- g_return_val_if_fail (clist, NULL);
+ gpgme_user_id_t last_uid = NULL;
- debug_print ("select_keys:fill_clist: pattern '%s' proto %d\n", pattern, proto);
+ cm_return_val_if_fail (sk, NULL);
+
+ view = sk->view;
+ cm_return_val_if_fail (view, NULL);
+ model = gtk_tree_view_get_model(GTK_TREE_VIEW(view));
+
+ debug_print ("select_keys:fill_view: pattern '%s' proto %d\n", pattern != NULL ? pattern : "NULL", proto);
- /*gtk_cmclist_freeze (select_keys.clist);*/
err = gpgme_new (&ctx);
g_assert (!err);
err = gpgme_op_keylist_start (ctx, pattern, 0);
if (err) {
- debug_print ("** gpgme_op_keylist_start(%s) failed: %s",
- pattern, gpgme_strerror (err));
+ debug_print ("** gpgme_op_keylist_start(%s) failed: %s\n",
+ pattern != NULL ? pattern : "NULL", gpgme_strerror (err));
sk->select_ctx = NULL;
gpgme_release(ctx);
return NULL;
update_progress (sk, ++running, pattern);
while ( !(err = gpgme_op_keylist_next ( ctx, &key )) ) {
gpgme_user_id_t uid = key->uids;
- if (!key->can_encrypt || key->revoked || key->expired)
+ if (!key->can_encrypt || key->revoked || key->expired || key->disabled) {
+ gpgme_key_unref(key);
continue;
+ }
debug_print ("%% %s:%d: insert\n", __FILE__ ,__LINE__ );
- set_row (clist, key, proto );
+ set_row (GTK_LIST_STORE(model), key, proto );
for (; uid; uid = uid->next) {
gchar *raw_mail = NULL;
if (!uid->email)
continue;
+ if (uid->revoked || uid->invalid)
+ continue;
raw_mail = g_strdup(uid->email);
extract_address(raw_mail);
- if (!strcasecmp(pattern, raw_mail)) {
+ if (pattern != NULL && !strcasecmp(pattern, raw_mail)) {
exact_match = TRUE;
+ last_uid = uid;
g_free(raw_mail);
break;
}
g_free(raw_mail);
}
+
+ /* Select the first row */
+ sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(view));
+ if (gtk_tree_model_get_iter_first(model, &iter))
+ gtk_tree_selection_select_iter(sel, &iter);
+
num_results++;
+ if (last_key != NULL)
+ gpgme_key_unref(last_key);
last_key = key;
key = NULL;
update_progress (sk, ++running, pattern);
if (exact_match == TRUE && num_results == 1) {
if (last_key->uids->validity < GPGME_VALIDITY_FULL &&
- !use_untrusted(last_key, proto))
+ !use_untrusted(last_key, last_uid, proto))
exact_match = FALSE;
}
debug_print ("%% %s:%d: ready\n", __FILE__ ,__LINE__ );
if (gpgme_err_code(err) != GPG_ERR_EOF) {
- debug_print ("** gpgme_op_keylist_next failed: %s",
+ debug_print ("** gpgme_op_keylist_next failed: %s\n",
gpgme_strerror (err));
gpgme_op_keylist_end(ctx);
}
sk->select_ctx = NULL;
gpgme_release (ctx);
}
- /*gtk_cmclist_thaw (select_keys.clist);*/
- return (exact_match == TRUE && num_results == 1 ? last_key:NULL);
+
+ if (exact_match && num_results == 1)
+ return last_key;
+
+ if (last_key != NULL)
+ gpgme_key_unref(last_key);
+
+ return NULL;
+}
+
+
+static void
+view_row_activated_cb(GtkTreeView *view,
+ GtkTreePath *path,
+ GtkTreeViewColumn *column,
+ gpointer user_data)
+{
+ select_btn_cb(NULL, user_data);
}
GtkWidget *vbox, *vbox2, *hbox;
GtkWidget *bbox;
GtkWidget *scrolledwin;
- GtkWidget *clist;
+ GtkWidget *view;
GtkWidget *label;
GtkWidget *select_btn, *cancel_btn, *dont_encrypt_btn, *other_btn;
- const char *titles[N_COL_TITLES];
+ GtkListStore *store;
+ GtkCellRenderer *rdr;
+ GtkTreeViewColumn *col;
+ GtkTreeSelection *sel;
+ gint i = 0;
g_assert (!sk->window);
window = gtkut_window_new (GTK_WINDOW_TOPLEVEL, "select-keys");
- gtk_widget_set_size_request (window, 520, 280);
+ gtk_widget_set_size_request (window, 560, 280);
gtk_container_set_border_width (GTK_CONTAINER (window), 8);
gtk_window_set_title (GTK_WINDOW (window), _("Select Keys"));
gtk_window_set_modal (GTK_WINDOW (window), TRUE);
+ gtk_window_set_type_hint(GTK_WINDOW(window), GDK_WINDOW_TYPE_HINT_DIALOG);
g_signal_connect (G_OBJECT (window), "delete_event",
G_CALLBACK (delete_event_cb), sk);
g_signal_connect (G_OBJECT (window), "key_press_event",
GTK_POLICY_AUTOMATIC,
GTK_POLICY_AUTOMATIC);
- titles[COL_ALGO] = _("Size");
- titles[COL_KEYID] = _("Key ID");
- titles[COL_NAME] = _("Name");
- titles[COL_EMAIL] = _("Address");
- titles[COL_VALIDITY] = _("Trust");
-
- clist = gtk_cmclist_new_with_titles (N_COL_TITLES, (char**)titles);
- gtk_container_add (GTK_CONTAINER (scrolledwin), clist);
- gtk_cmclist_set_column_width (GTK_CMCLIST(clist), COL_ALGO, 72);
- gtk_cmclist_set_column_width (GTK_CMCLIST(clist), COL_KEYID, 76);
- gtk_cmclist_set_column_width (GTK_CMCLIST(clist), COL_NAME, 130);
- gtk_cmclist_set_column_width (GTK_CMCLIST(clist), COL_EMAIL, 130);
- gtk_cmclist_set_column_width (GTK_CMCLIST(clist), COL_VALIDITY, 20);
- gtk_cmclist_set_selection_mode (GTK_CMCLIST(clist), GTK_SELECTION_BROWSE);
- g_signal_connect (G_OBJECT(GTK_CMCLIST(clist)->column[COL_NAME].button),
- "clicked",
- G_CALLBACK(sort_keys_name), sk);
- g_signal_connect (G_OBJECT(GTK_CMCLIST(clist)->column[COL_EMAIL].button),
- "clicked",
- G_CALLBACK(sort_keys_email), sk);
+ store = gtk_list_store_new(N_COL_TITLES,
+ G_TYPE_STRING,
+ G_TYPE_STRING,
+ G_TYPE_STRING,
+ G_TYPE_STRING,
+ G_TYPE_STRING,
+ G_TYPE_POINTER,
+ -1);
+
+ view = gtk_tree_view_new_with_model(GTK_TREE_MODEL(store));
+ g_object_unref(store);
+ gtk_tree_view_set_headers_visible(GTK_TREE_VIEW(view), TRUE);
+ gtk_tree_view_set_reorderable(GTK_TREE_VIEW(view), FALSE);
+ sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(view));
+ gtk_tree_selection_set_mode(sel, GTK_SELECTION_BROWSE);
+
+ rdr = gtk_cell_renderer_text_new();
+ col = gtk_tree_view_column_new_with_attributes(_("Size"), rdr,
+ "markup", COL_ALGO, NULL);
+ gtk_tree_view_column_set_min_width(col, COL_ALGO_WIDTH);
+ gtk_tree_view_column_set_sort_column_id(col, i++);
+ gtk_tree_view_append_column(GTK_TREE_VIEW(view), col);
+
+ col = gtk_tree_view_column_new_with_attributes(_("Key ID"), rdr,
+ "markup", COL_KEYID, NULL);
+ gtk_tree_view_column_set_min_width(col, COL_KEYID_WIDTH);
+ gtk_tree_view_column_set_sort_column_id(col, i++);
+ gtk_tree_view_append_column(GTK_TREE_VIEW(view), col);
+
+ col = gtk_tree_view_column_new_with_attributes(_("Name"), rdr,
+ "markup", COL_NAME, NULL);
+ gtk_tree_view_column_set_min_width(col, COL_NAME_WIDTH);
+ gtk_tree_view_column_set_sort_column_id(col, i++);
+ gtk_tree_view_append_column(GTK_TREE_VIEW(view), col);
+
+ col = gtk_tree_view_column_new_with_attributes(_("Address"), rdr,
+ "markup", COL_ADDRESS, NULL);
+ gtk_tree_view_column_set_min_width(col, COL_ADDRESS_WIDTH);
+ gtk_tree_view_column_set_sort_column_id(col, i++);
+ gtk_tree_view_append_column(GTK_TREE_VIEW(view), col);
+
+ col = gtk_tree_view_column_new_with_attributes(_("Trust"), rdr,
+ "markup", COL_TRUST, NULL);
+ gtk_tree_view_column_set_min_width(col, COL_TRUST_WIDTH);
+ gtk_tree_view_column_set_sort_column_id(col, i++);
+ gtk_tree_view_append_column(GTK_TREE_VIEW(view), col);
+
+ g_signal_connect(G_OBJECT(view), "row-activated",
+ G_CALLBACK(view_row_activated_cb), sk);
+
+ gtk_container_add (GTK_CONTAINER (scrolledwin), view);
hbox = gtk_hbox_new (FALSE, 8);
gtk_box_pack_end (GTK_BOX (vbox), hbox, FALSE, FALSE, 0);
+ /* TRANSLATORS: check that the accelerators in _Select, _Other and
+ * Do_n't encrypt are different than the one in the stock Cancel
+ * button */
gtkut_stock_button_set_create (&bbox,
- &select_btn, _("Select"),
- &other_btn, _("Other"),
- &dont_encrypt_btn, _("Don't encrypt"));
+ &select_btn, _("_Select"),
+ &other_btn, _("_Other"),
+ &dont_encrypt_btn, _("Do_n't encrypt"));
cancel_btn = gtk_button_new_from_stock(GTK_STOCK_CANCEL);
- GTK_WIDGET_SET_FLAGS(cancel_btn, GTK_CAN_DEFAULT);
+ gtk_widget_set_can_default(cancel_btn, TRUE);
gtk_box_pack_start(GTK_BOX(bbox), cancel_btn, TRUE, TRUE, 0);
gtk_widget_show(cancel_btn);
gtk_box_pack_end (GTK_BOX (hbox), bbox, FALSE, FALSE, 0);
sk->window = window;
sk->toplabel = GTK_LABEL (label);
- sk->clist = GTK_CMCLIST (clist);
+ sk->view = view;
+}
+
+
+/* Function called by gtk_tree_model_foreach() upon dialog close,
+ * which unrefs the gpgme_key_t pointer from each model line */
+static gboolean
+close_dialog_foreach_func(GtkTreeModel *model,
+ GtkTreePath *path,
+ GtkTreeIter *iter,
+ gpointer user_data)
+{
+ gpgme_key_t key;
+
+ gtk_tree_model_get(model, iter, COL_PTR, &key, -1);
+ gpgme_key_unref(key);
+ return FALSE;
}
static void
close_dialog (struct select_keys_s *sk)
{
- g_return_if_fail (sk);
+ GtkTreeModel *model;
+ cm_return_if_fail (sk);
+
+ debug_print("pgpcore select-keys dialog closing\n");
+ if (sk->view != NULL) {
+ model = gtk_tree_view_get_model(GTK_TREE_VIEW(sk->view));
+ gtk_tree_model_foreach(model, close_dialog_foreach_func, NULL);
+ gtk_list_store_clear(GTK_LIST_STORE(model));
+ }
+
gtk_widget_destroy (sk->window);
sk->window = NULL;
}
{
struct select_keys_s *sk = data;
- g_return_val_if_fail (sk, FALSE);
- if (event && event->keyval == GDK_Escape) {
+ cm_return_val_if_fail (sk, FALSE);
+ if (event && event->keyval == GDK_KEY_Escape) {
sk->okay = 0;
gtk_main_quit ();
}
select_btn_cb (GtkWidget *widget, gpointer data)
{
struct select_keys_s *sk = data;
- int row;
gboolean use_key;
gpgme_key_t key;
- g_return_if_fail (sk);
- if (!sk->clist->selection) {
- debug_print ("** nothing selected");
- return;
- }
- row = GPOINTER_TO_INT(sk->clist->selection->data);
- key = gtk_cmclist_get_row_data(sk->clist, row);
+ cm_return_if_fail (sk);
+
+ key = gtkut_tree_view_get_selected_pointer(
+ GTK_TREE_VIEW(sk->view), COL_PTR,
+ NULL, NULL, NULL);
if (key) {
- if ( key->uids->validity < GPGME_VALIDITY_FULL ) {
- use_key = use_untrusted(key, sk->proto);
+ gpgme_user_id_t uid;
+ for (uid = key->uids; uid; uid = uid->next) {
+ gchar *raw_mail = NULL;
+
+ if (!uid->email)
+ continue;
+ raw_mail = g_strdup(uid->email);
+ extract_address(raw_mail);
+ if (sk->pattern && !strcasecmp(sk->pattern, raw_mail)) {
+ g_free(raw_mail);
+ break;
+ }
+ g_free(raw_mail);
+ }
+ if (!uid)
+ uid = key->uids;
+
+ if ( uid->validity < GPGME_VALIDITY_FULL ) {
+ use_key = use_untrusted(key, uid, sk->proto);
if (!use_key) {
- debug_print ("** Key untrusted, will not encrypt");
+ debug_print ("** Key untrusted, will not encrypt\n");
return;
}
}
{
struct select_keys_s *sk = data;
- g_return_if_fail (sk);
+ cm_return_if_fail (sk);
sk->okay = 0;
sk->result = KEY_SELECTION_CANCEL;
if (sk->select_ctx)
{
struct select_keys_s *sk = data;
- g_return_if_fail (sk);
+ cm_return_if_fail (sk);
sk->okay = 0;
sk->result = KEY_SELECTION_DONT;
if (sk->select_ctx)
struct select_keys_s *sk = data;
char *uid;
- g_return_if_fail (sk);
+ cm_return_if_fail (sk);
uid = input_dialog ( _("Add key"),
_("Enter another user or key ID:"),
NULL );
if (!uid)
return;
- if (fill_clist (sk, uid, sk->proto) != NULL) {
+ if (fill_view (sk, uid, sk->proto) != NULL) {
gpgme_release(sk->select_ctx);
sk->select_ctx = NULL;
}
static gboolean
-use_untrusted (gpgme_key_t key, gpgme_protocol_t proto)
+use_untrusted (gpgme_key_t key, gpgme_user_id_t uid, gpgme_protocol_t proto)
{
AlertValue aval;
gchar *buf = NULL;
-
+ gchar *title = NULL;
if (proto != GPGME_PROTOCOL_OpenPGP)
return TRUE;
- buf = g_strdup_printf(_("The key of '%s' is not fully trusted.\n"
- "If you choose to encrypt the message with this key you don't\n"
- "know for sure that it will go to the person you mean it to.\n"
- "Do you trust it enough to use it anyway?"), key->uids->email);
- aval = alertpanel
- (_("Trust key"),
- buf,
- GTK_STOCK_NO, GTK_STOCK_YES, NULL);
+ title = g_strdup_printf(_("Encrypt to %s <%s>"), uid->name, uid->email);
+ buf = g_strdup_printf(_("This encryption key is not fully trusted.\n"
+ "If you choose to encrypt the message with this key, you don't\n"
+ "know for sure that it will go to the person you mean it to.\n\n"
+ "Key details: ID %s, primary identity %s <%s>\n\n"
+ "Do you trust this key enough to use it anyway?"),
+ key->subkeys->keyid, key->uids->name, key->uids->email);
+ aval = alertpanel(title, buf,
+ GTK_STOCK_NO, GTK_STOCK_YES, NULL, ALERTFOCUS_FIRST);
g_free(buf);
+ g_free(title);
if (aval == G_ALERTALTERNATE)
return TRUE;
else
return FALSE;
}
-
-static gint
-cmp_name (GtkCMCList *clist, gconstpointer pa, gconstpointer pb)
-{
- gpgme_key_t a = ((GtkCMCListRow *)pa)->data;
- gpgme_key_t b = ((GtkCMCListRow *)pb)->data;
- const char *sa, *sb;
-
- sa = a? a->uids->name : NULL;
- sb = b? b->uids->name : NULL;
- if (!sa)
- return !!sb;
- if (!sb)
- return -1;
- return g_ascii_strcasecmp(sa, sb);
-}
-
-static gint
-cmp_email (GtkCMCList *clist, gconstpointer pa, gconstpointer pb)
-{
- gpgme_key_t a = ((GtkCMCListRow *)pa)->data;
- gpgme_key_t b = ((GtkCMCListRow *)pb)->data;
- const char *sa, *sb;
-
- sa = a? a->uids->email : NULL;
- sb = b? b->uids->email : NULL;
- if (!sa)
- return !!sb;
- if (!sb)
- return -1;
- return g_ascii_strcasecmp(sa, sb);
-}
-
-static void
-sort_keys ( struct select_keys_s *sk, enum col_titles column)
-{
- GtkCMCList *clist = sk->clist;
-
- switch (column) {
- case COL_NAME:
- gtk_cmclist_set_compare_func (clist, cmp_name);
- break;
- case COL_EMAIL:
- gtk_cmclist_set_compare_func (clist, cmp_email);
- break;
- default:
- return;
- }
-
- /* column clicked again: toggle as-/decending */
- if ( sk->sort_column == column) {
- sk->sort_type = sk->sort_type == GTK_SORT_ASCENDING ?
- GTK_SORT_DESCENDING : GTK_SORT_ASCENDING;
- }
- else
- sk->sort_type = GTK_SORT_ASCENDING;
-
- sk->sort_column = column;
- gtk_cmclist_set_sort_type (clist, sk->sort_type);
- gtk_cmclist_sort (clist);
-}
-
-static void
-sort_keys_name (GtkWidget *widget, gpointer data)
-{
- sort_keys ((struct select_keys_s*)data, COL_NAME);
-}
-
-static void
-sort_keys_email (GtkWidget *widget, gpointer data)
-{
- sort_keys ((struct select_keys_s*)data, COL_EMAIL);
-}
-
#endif /*USE_GPGME*/
projects / claws.git / blobdiff