0.8.11claws50
[claws.git] / src / news.c
index caa76add9831e472e075d738facbc4ab2ca94572..a9b7d544f22d30a718cd1ed8048531847f9cbfef 100644 (file)
@@ -1,6 +1,6 @@
 /*
  * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2002 Hiroyuki Yamamoto
+ * Copyright (C) 1999-2003 Hiroyuki Yamamoto
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
 #include "prefs_common.h"
 #include "prefs_account.h"
 #include "inputdialog.h"
-#include "alertpanel.h"
 #include "log.h"
-#include "mainwindow.h"
-#include "inc.h"
+#include "progressindicator.h"
 #if USE_OPENSSL
 #  include "ssl.h"
 #endif
@@ -89,21 +87,9 @@ static gint news_select_group                 (NNTPSession   *session,
                                          gint          *num,
                                          gint          *first,
                                          gint          *last);
-static GSList *news_get_uncached_articles(NNTPSession  *session,
-                                         FolderItem    *item,
-                                         gint           cache_last,
-                                         gint          *rfirst,
-                                         gint          *rlast);
 static MsgInfo *news_parse_xover        (const gchar   *xover_str);
 static gchar *news_parse_xhdr           (const gchar   *xhdr_str,
                                          MsgInfo       *msginfo);
-static GSList *news_delete_old_articles         (GSList        *alist,
-                                         FolderItem    *item,
-                                         gint           first);
-static void news_delete_all_articles    (FolderItem    *item);
-static void news_delete_expired_caches  (GSList        *alist,
-                                         FolderItem    *item);
-
 static gint news_remove_msg             (Folder        *folder, 
                                          FolderItem    *item, 
                                          gint           num);
@@ -120,11 +106,57 @@ GSList *news_get_msginfos          (Folder        *folder,
 gint news_post_stream                   (Folder        *folder, 
                                          FILE          *fp);
 
+FolderClass news_class =
+{
+       F_NEWS,
+       "news",
+       "News",
+
+       /* Folder functions */
+       news_folder_new,
+       news_folder_destroy,
+       NULL,
+       NULL,
+
+       /* FolderItem functions */
+       NULL,
+       NULL,
+       NULL,
+       NULL,
+       NULL,
+       news_get_num_list,
+       NULL,
+       NULL,
+       NULL,
+       NULL,
+
+       /* Message functions */
+       news_get_msginfo,
+       news_get_msginfos,
+       news_fetch_msg,
+       NULL,
+       NULL,
+       NULL,
+       NULL,
+       NULL,
+       news_remove_msg,
+       NULL,
+       NULL,
+       NULL,
+       NULL,
+};
+
+FolderClass *news_get_class()
+{
+       return &news_class;
+}
+
 Folder *news_folder_new(const gchar *name, const gchar *path)
 {
        Folder *folder;
 
        folder = (Folder *)g_new0(NewsFolder, 1);
+       folder->class = &news_class;
        news_folder_init(folder, name, path);
 
        return folder;
@@ -145,22 +177,7 @@ void news_folder_destroy(Folder *folder)
 static void news_folder_init(Folder *folder, const gchar *name,
                             const gchar *path)
 {
-       folder->type = F_NEWS;
-
        folder_remote_folder_init(folder, name, path);
-
-/*
-       folder->get_msg_list = news_get_article_list;
-*/
-       folder->fetch_msg    = news_fetch_msg;
-/*
-       folder->scan         = news_scan_group;
-*/
-       folder->destroy      = news_folder_destroy;
-       folder->remove_msg   = news_remove_msg;
-       folder->get_num_list = news_get_num_list;
-       folder->get_msginfo  = news_get_msginfo;
-       folder->get_msginfos = news_get_msginfos;
 }
 
 #if USE_OPENSSL
@@ -196,19 +213,17 @@ static Session *news_session_new(const gchar *server, gushort port,
        if (nntp_sock == NULL)
                return NULL;
 
-       session = g_new(NNTPSession, 1);
+       session = g_new0(NNTPSession, 1);
+       session_init(SESSION(session));
        SESSION(session)->type             = SESSION_NEWS;
        SESSION(session)->server           = g_strdup(server);
-       session->nntp_sock                 = nntp_sock;
-       SESSION(session)->sock             = nntp_sock->sock;
-       SESSION(session)->connected        = TRUE;
-       SESSION(session)->phase            = SESSION_READY;
-       SESSION(session)->last_access_time = time(NULL);
+       SESSION(session)->sock             = NULL;
        SESSION(session)->data             = NULL;
 
        SESSION(session)->destroy          = news_session_destroy;
 
-       session->group = NULL;
+       session->nntp_sock                 = nntp_sock;
+       session->group                     = NULL;
 
        return SESSION(session);
 }
@@ -217,7 +232,6 @@ void news_session_destroy(Session *session)
 {
        nntp_close(NNTP_SESSION(session)->nntp_sock);
        NNTP_SESSION(session)->nntp_sock = NULL;
-       session->sock = NULL;
 
        g_free(NNTP_SESSION(session)->group);
 }
@@ -253,7 +267,7 @@ static Session *news_session_new_for_folder(Folder *folder)
        port = ac->set_nntpport ? ac->nntpport : NNTP_PORT;
        session = news_session_new(ac->nntp_server, port, userid, passwd);
 #endif
-       if (ac->use_nntp_auth && ac->use_nntp_auth_onconnect)
+       if ((session != NULL) && ac->use_nntp_auth && ac->use_nntp_auth_onconnect)
                nntp_forceauth(NNTP_SESSION(session)->nntp_sock, buf, userid, passwd);
 
        g_free(passwd);
@@ -266,7 +280,7 @@ NNTPSession *news_session_get(Folder *folder)
        RemoteFolder *rfolder = REMOTE_FOLDER(folder);
 
        g_return_val_if_fail(folder != NULL, NULL);
-       g_return_val_if_fail(folder->type == F_NEWS, NULL);
+       g_return_val_if_fail(FOLDER_CLASS(folder) == &news_class, NULL);
        g_return_val_if_fail(folder->account != NULL, NULL);
 
        if (!rfolder->session) {
@@ -295,57 +309,6 @@ NNTPSession *news_session_get(Folder *folder)
        return NNTP_SESSION(rfolder->session);
 }
 
-GSList *news_get_article_list(Folder *folder, FolderItem *item,
-                             gboolean use_cache)
-{
-       GSList *alist;
-       NNTPSession *session;
-
-       g_return_val_if_fail(folder != NULL, NULL);
-       g_return_val_if_fail(item != NULL, NULL);
-       g_return_val_if_fail(folder->type == F_NEWS, NULL);
-
-       session = news_session_get(folder);
-
-       if (!session) {
-               alist = procmsg_read_cache(item, FALSE);
-               item->last_num = procmsg_get_last_num_in_msg_list(alist);
-       } else if (use_cache) {
-               GSList *newlist;
-               gint cache_last;
-               gint first, last;
-
-               alist = procmsg_read_cache(item, FALSE);
-
-               cache_last = procmsg_get_last_num_in_msg_list(alist);
-               newlist = news_get_uncached_articles
-                       (session, item, cache_last, &first, &last);
-               if (first == 0 && last == 0) {
-                       news_delete_all_articles(item);
-                       procmsg_msg_list_free(alist);
-                       alist = NULL;
-               } else {
-                       alist = news_delete_old_articles(alist, item, first);
-                       news_delete_expired_caches(alist, item);
-               }
-
-               alist = g_slist_concat(alist, newlist);
-
-               item->last_num = last;
-       } else {
-               gint last;
-
-               alist = news_get_uncached_articles
-                       (session, item, 0, NULL, &last);
-               news_delete_all_articles(item);
-               item->last_num = last;
-       }
-
-       procmsg_set_flags(alist, item);
-
-       return alist;
-}
-
 gchar *news_fetch_msg(Folder *folder, FolderItem *item, gint num)
 {
        gchar *path, *filename;
@@ -384,6 +347,8 @@ gchar *news_fetch_msg(Folder *folder, FolderItem *item, gint num)
                              num, filename);
        if (ok < 0) {
                g_warning("can't read article %d\n", num);
+               session_destroy(SESSION(session));
+               REMOTE_FOLDER(folder)->session = NULL;
                g_free(filename);
                return NULL;
        }
@@ -482,7 +447,7 @@ GSList *news_get_group_list(Folder *folder)
        gchar buf[NNTPBUFSIZE];
 
        g_return_val_if_fail(folder != NULL, NULL);
-       g_return_val_if_fail(folder->type == F_NEWS, NULL);
+       g_return_val_if_fail(FOLDER_CLASS(folder) == &news_class, NULL);
 
        path = folder_item_get_path(FOLDER_ITEM(folder->node->data));
        if (!is_dir_exist(path))
@@ -503,7 +468,8 @@ GSList *news_get_group_list(Folder *folder)
                        g_free(filename);
                        return NULL;
                }
-               if (recv_write_to_file(SESSION(session)->sock, filename) < 0) {
+               if (recv_write_to_file
+                       (session->nntp_sock->sock, filename) < 0) {
                        log_warning("can't retrieve newsgroup list\n");
                        session_destroy(SESSION(session));
                        REMOTE_FOLDER(folder)->session = NULL;
@@ -569,7 +535,7 @@ void news_remove_group_list_cache(Folder *folder)
        gchar *path, *filename;
 
        g_return_if_fail(folder != NULL);
-       g_return_if_fail(folder->type == F_NEWS);
+       g_return_if_fail(FOLDER_CLASS(folder) == &news_class);
 
        path = folder_item_get_path(FOLDER_ITEM(folder->node->data));
        filename = g_strconcat(path, G_DIR_SEPARATOR_S, NEWSGROUP_LIST, NULL);
@@ -588,7 +554,7 @@ gint news_post(Folder *folder, const gchar *file)
        gint ok;
 
        g_return_val_if_fail(folder != NULL, -1);
-       g_return_val_if_fail(folder->type == F_NEWS, -1);
+       g_return_val_if_fail(FOLDER_CLASS(folder) == &news_class, -1);
        g_return_val_if_fail(file != NULL, -1);
 
        if ((fp = fopen(file, "rb")) == NULL) {
@@ -609,7 +575,7 @@ gint news_post_stream(Folder *folder, FILE *fp)
        gint ok;
 
        g_return_val_if_fail(folder != NULL, -1);
-       g_return_val_if_fail(folder->type == F_NEWS, -1);
+       g_return_val_if_fail(FOLDER_CLASS(folder) == &news_class, -1);
        g_return_val_if_fail(fp != NULL, -1);
 
        session = news_session_get(folder);
@@ -699,143 +665,6 @@ static gint news_select_group(NNTPSession *session, const gchar *group,
        return ok;
 }
 
-static GSList *news_get_uncached_articles(NNTPSession *session,
-                                         FolderItem *item, gint cache_last,
-                                         gint *rfirst, gint *rlast)
-{
-       gint ok;
-       gint num = 0, first = 0, last = 0, begin = 0, end = 0;
-       gchar buf[NNTPBUFSIZE];
-       GSList *newlist = NULL;
-       GSList *llast = NULL;
-       MsgInfo *msginfo;
-
-       if (rfirst) *rfirst = -1;
-       if (rlast)  *rlast  = -1;
-
-       g_return_val_if_fail(session != NULL, NULL);
-       g_return_val_if_fail(item != NULL, NULL);
-       g_return_val_if_fail(item->folder != NULL, NULL);
-       g_return_val_if_fail(item->folder->type == F_NEWS, NULL);
-
-       ok = news_select_group(session, item->path, &num, &first, &last);
-       if (ok != NN_SUCCESS) {
-               log_warning("can't set group: %s\n", item->path);
-               return NULL;
-       }
-
-       /* calculate getting overview range */
-       if (first > last) {
-               log_warning("invalid article range: %d - %d\n",
-                           first, last);
-               return NULL;
-       }
-
-       if (rfirst) *rfirst = first;
-       if (rlast)  *rlast  = last;
-
-       if (cache_last < first)
-               begin = first;
-       else if (last < cache_last)
-               begin = first;
-       else if (last == cache_last) {
-               debug_print("no new articles.\n");
-               return NULL;
-       } else
-               begin = cache_last + 1;
-       end = last;
-
-       if (prefs_common.max_articles > 0 &&
-           end - begin + 1 > prefs_common.max_articles)
-               begin = end - prefs_common.max_articles + 1;
-
-       log_message(_("getting xover %d - %d in %s...\n"),
-                   begin, end, item->path);
-       if (nntp_xover(session->nntp_sock, begin, end) != NN_SUCCESS) {
-               log_warning("can't get xover\n");
-               return NULL;
-       }
-
-       for (;;) {
-               if (sock_gets(SESSION(session)->sock, buf, sizeof(buf)) < 0) {
-                       log_warning("error occurred while getting xover.\n");
-                       return newlist;
-               }
-
-               if (buf[0] == '.' && buf[1] == '\r') break;
-
-               msginfo = news_parse_xover(buf);
-               if (!msginfo) {
-                       log_warning("invalid xover line: %s\n", buf);
-                       continue;
-               }
-
-               msginfo->folder = item;
-               msginfo->flags.perm_flags = MSG_NEW|MSG_UNREAD;
-               msginfo->flags.tmp_flags = MSG_NEWS;
-               msginfo->newsgroups = g_strdup(item->path);
-
-               if (!newlist)
-                       llast = newlist = g_slist_append(newlist, msginfo);
-               else {
-                       llast = g_slist_append(llast, msginfo);
-                       llast = llast->next;
-               }
-       }
-
-       if (nntp_xhdr(session->nntp_sock, "to", begin, end) != NN_SUCCESS) {
-               log_warning("can't get xhdr\n");
-               return newlist;
-       }
-
-       llast = newlist;
-
-       for (;;) {
-               if (sock_gets(SESSION(session)->sock, buf, sizeof(buf)) < 0) {
-                       log_warning("error occurred while getting xhdr.\n");
-                       return newlist;
-               }
-
-               if (buf[0] == '.' && buf[1] == '\r') break;
-               if (!llast) {
-                       g_warning("llast == NULL\n");
-                       continue;
-               }
-
-               msginfo = (MsgInfo *)llast->data;
-               msginfo->to = news_parse_xhdr(buf, msginfo);
-
-               llast = llast->next;
-       }
-
-       if (nntp_xhdr(session->nntp_sock, "cc", begin, end) != NN_SUCCESS) {
-               log_warning("can't get xhdr\n");
-               return newlist;
-       }
-
-       llast = newlist;
-
-       for (;;) {
-               if (sock_gets(SESSION(session)->sock, buf, sizeof(buf)) < 0) {
-                       log_warning("error occurred while getting xhdr.\n");
-                       return newlist;
-               }
-
-               if (buf[0] == '.' && buf[1] == '\r') break;
-               if (!llast) {
-                       g_warning("llast == NULL\n");
-                       continue;
-               }
-
-               msginfo = (MsgInfo *)llast->data;
-               msginfo->cc = news_parse_xhdr(buf, msginfo);
-
-               llast = llast->next;
-       }
-
-       return newlist;
-}
-
 #define PARSE_ONE_PARAM(p, srcp) \
 { \
        p = strchr(srcp, '\t'); \
@@ -936,70 +765,6 @@ static gchar *news_parse_xhdr(const gchar *xhdr_str, MsgInfo *msginfo)
                return g_strdup(p);
 }
 
-static GSList *news_delete_old_articles(GSList *alist, FolderItem *item,
-                                       gint first)
-{
-       GSList *cur, *next;
-       MsgInfo *msginfo;
-       gchar *dir;
-
-       g_return_val_if_fail(item != NULL, alist);
-       g_return_val_if_fail(item->folder != NULL, alist);
-       g_return_val_if_fail(item->folder->type == F_NEWS, alist);
-
-       if (first < 2) return alist;
-
-       debug_print("Deleting cached articles 1 - %d ...\n", first - 1);
-
-       dir = folder_item_get_path(item);
-       remove_numbered_files(dir, 1, first - 1);
-       g_free(dir);
-
-       for (cur = alist; cur != NULL; ) {
-               next = cur->next;
-
-               msginfo = (MsgInfo *)cur->data;
-               if (msginfo && msginfo->msgnum < first) {
-                       procmsg_msginfo_free(msginfo);
-                       alist = g_slist_remove(alist, msginfo);
-               }
-
-               cur = next;
-       }
-
-       return alist;
-}
-
-static void news_delete_all_articles(FolderItem *item)
-{
-       gchar *dir;
-
-       g_return_if_fail(item != NULL);
-       g_return_if_fail(item->folder != NULL);
-       g_return_if_fail(item->folder->type == F_NEWS);
-
-       debug_print("Deleting all cached articles...\n");
-
-       dir = folder_item_get_path(item);
-       remove_all_numbered_files(dir);
-       g_free(dir);
-}
-
-static void news_delete_expired_caches(GSList *alist, FolderItem *item)
-{
-       gchar *dir;
-
-       g_return_if_fail(item != NULL);
-       g_return_if_fail(item->folder != NULL);
-       g_return_if_fail(item->folder->type == F_NEWS);
-
-       debug_print("Deleting expired cached articles...\n");
-
-       dir = folder_item_get_path(item);
-       remove_expired_files(dir, 24 * 7);
-       g_free(dir);
-}
-
 gint news_cancel_article(Folder * folder, MsgInfo * msginfo)
 {
        gchar * tmp;
@@ -1049,7 +814,7 @@ gint news_get_num_list(Folder *folder, FolderItem *item, GSList **msgnum_list)
 
        g_return_val_if_fail(item != NULL, -1);
        g_return_val_if_fail(item->folder != NULL, -1);
-       g_return_val_if_fail(item->folder->type == F_NEWS, -1);
+       g_return_val_if_fail(FOLDER_CLASS(folder) == &news_class, -1);
 
        session = news_session_get(folder);
        g_return_val_if_fail(session != NULL, -1);
@@ -1081,7 +846,7 @@ gint news_get_num_list(Folder *folder, FolderItem *item, GSList **msgnum_list)
 
 #define READ_TO_LISTEND(hdr) \
        while (!(buf[0] == '.' && buf[1] == '\r')) { \
-               if (sock_gets(SESSION(session)->sock, buf, sizeof(buf)) < 0) { \
+               if (sock_gets(session->nntp_sock->sock, buf, sizeof(buf)) < 0) { \
                        log_warning(_("error occurred while getting %s.\n"), hdr); \
                        return msginfo; \
                } \
@@ -1097,7 +862,7 @@ MsgInfo *news_get_msginfo(Folder *folder, FolderItem *item, gint num)
        g_return_val_if_fail(session != NULL, NULL);
        g_return_val_if_fail(item != NULL, NULL);
        g_return_val_if_fail(item->folder != NULL, NULL);
-       g_return_val_if_fail(item->folder->type == F_NEWS, NULL);
+       g_return_val_if_fail(FOLDER_CLASS(item->folder) == &news_class, NULL);
 
        log_message(_("getting xover %d in %s...\n"),
                    num, item->path);
@@ -1106,7 +871,7 @@ MsgInfo *news_get_msginfo(Folder *folder, FolderItem *item, gint num)
                return NULL;
        }
        
-       if (sock_gets(SESSION(session)->sock, buf, sizeof(buf)) < 0) {
+       if (sock_gets(session->nntp_sock->sock, buf, sizeof(buf)) < 0) {
                log_warning(_("error occurred while getting xover.\n"));
                return NULL;
        }
@@ -1131,7 +896,7 @@ MsgInfo *news_get_msginfo(Folder *folder, FolderItem *item, gint num)
                return msginfo;
        }
 
-       if (sock_gets(SESSION(session)->sock, buf, sizeof(buf)) < 0) {
+       if (sock_gets(session->nntp_sock->sock, buf, sizeof(buf)) < 0) {
                log_warning(_("error occurred while getting xhdr.\n"));
                return msginfo;
        }
@@ -1145,7 +910,7 @@ MsgInfo *news_get_msginfo(Folder *folder, FolderItem *item, gint num)
                return msginfo;
        }
 
-       if (sock_gets(SESSION(session)->sock, buf, sizeof(buf)) < 0) {
+       if (sock_gets(session->nntp_sock->sock, buf, sizeof(buf)) < 0) {
                log_warning(_("error occurred while getting xhdr.\n"));
                return msginfo;
        }
@@ -1157,72 +922,34 @@ MsgInfo *news_get_msginfo(Folder *folder, FolderItem *item, gint num)
        return msginfo;
 }
 
-/*!
- *\brief       Set/reset/update progressbar, max. 10 redraws/second
- *
- *\param       action What to do with the statusbar
- *                     = 0 : Reset to zero
- *                     < 0 : Init maximum to -(action)
- *                     > 0 : Increase by (action)
- */
-void news_doprogress(glong action) {
-       static glong curcount=0;
-       static glong maxval;
-       static MainWindow *mainwin=0;
-       static struct timeval tv_prev, tv_cur;
-       
-       if (!mainwin)
-               mainwin = mainwindow_get_mainwindow();
-       g_return_if_fail(mainwin);
-
-       if (action < 0)
-               maxval = -action;
-       else if (action == 0) {
-               curcount=0;
-               gtk_progress_bar_update(
-                       GTK_PROGRESS_BAR(mainwin->progressbar), 0.0);
-       } else {
-               curcount += action;
-               gettimeofday(&tv_cur, NULL);
-               if (!(tv_cur.tv_sec - tv_prev.tv_sec > 0 ||
-                       tv_cur.tv_usec - tv_prev.tv_usec > 100)
-                   || !maxval)
-                       return;
-
-               gtk_progress_bar_update(
-                       GTK_PROGRESS_BAR(mainwin->progressbar),
-                       (float)curcount/maxval);
-               while (gtk_events_pending()) gtk_main_iteration ();
-               gettimeofday(&tv_prev, NULL);
-       }
-}
-
 static GSList *news_get_msginfos_for_range(NNTPSession *session, FolderItem *item, guint begin, guint end)
 {
        gchar buf[NNTPBUFSIZE];
        GSList *newlist = NULL;
        GSList *llast = NULL;
        MsgInfo *msginfo;
+       guint count = 0, lines = (end - begin + 2) * 3;
 
        g_return_val_if_fail(session != NULL, NULL);
        g_return_val_if_fail(item != NULL, NULL);
 
-       inc_lock();
        log_message(_("getting xover %d - %d in %s...\n"),
                    begin, end, item->path);
        if (nntp_xover(session->nntp_sock, begin, end) != NN_SUCCESS) {
                log_warning(_("can't get xover\n"));
-               goto unlock_leave;
+               return NULL;
        }
 
-       news_doprogress(-3*(end-begin));
-       statusbar_print_all(_("Getting overview (%d articles)..."),end-begin);
        for (;;) {
-               if (sock_gets(SESSION(session)->sock, buf, sizeof(buf)) < 0) {
+               if (sock_gets(session->nntp_sock->sock, buf, sizeof(buf)) < 0) {
                        log_warning(_("error occurred while getting xover.\n"));
-                       goto unlock_leave;
+                       return newlist;
                }
-               news_doprogress(1);
+               count++;
+               progressindicator_set_percentage
+                       (PROGRESS_TYPE_NETWORK,
+                        session->fetch_base_percentage +
+                        (((gfloat) count) / ((gfloat) lines)) * session->fetch_total_percentage);
 
                if (buf[0] == '.' && buf[1] == '\r') break;
 
@@ -1247,19 +974,21 @@ static GSList *news_get_msginfos_for_range(NNTPSession *session, FolderItem *ite
 
        if (nntp_xhdr(session->nntp_sock, "to", begin, end) != NN_SUCCESS) {
                log_warning(_("can't get xhdr\n"));
-                       goto unlock_leave;
+               return newlist;
        }
 
        llast = newlist;
 
-       statusbar_pop_all();
-       statusbar_print_all(_("Getting headers (%d articles)..."),end-begin);
        for (;;) {
-               if (sock_gets(SESSION(session)->sock, buf, sizeof(buf)) < 0) {
+               if (sock_gets(session->nntp_sock->sock, buf, sizeof(buf)) < 0) {
                        log_warning(_("error occurred while getting xhdr.\n"));
-                       goto unlock_leave;
+                       return newlist;
                }
-               news_doprogress(1);
+               count++;
+               progressindicator_set_percentage
+                       (PROGRESS_TYPE_NETWORK,
+                        session->fetch_base_percentage +
+                        (((gfloat) count) / ((gfloat) lines)) * session->fetch_total_percentage);
 
                if (buf[0] == '.' && buf[1] == '\r') break;
                if (!llast) {
@@ -1275,19 +1004,21 @@ static GSList *news_get_msginfos_for_range(NNTPSession *session, FolderItem *ite
 
        if (nntp_xhdr(session->nntp_sock, "cc", begin, end) != NN_SUCCESS) {
                log_warning(_("can't get xhdr\n"));
-               goto unlock_leave;
+               return newlist;
        }
 
        llast = newlist;
 
-       statusbar_pop_all();
-       statusbar_print_all(_("Getting crossposted articles (%d messages)..."),end-begin);
        for (;;) {
-               if (sock_gets(SESSION(session)->sock, buf, sizeof(buf)) < 0) {
+               if (sock_gets(session->nntp_sock->sock, buf, sizeof(buf)) < 0) {
                        log_warning(_("error occurred while getting xhdr.\n"));
-                       goto unlock_leave;
+                       return newlist;
                }
-               news_doprogress(1);
+               count++;
+               progressindicator_set_percentage
+                       (PROGRESS_TYPE_NETWORK,
+                        session->fetch_base_percentage +
+                        (((gfloat) count) / ((gfloat) lines)) * session->fetch_total_percentage);
 
                if (buf[0] == '.' && buf[1] == '\r') break;
                if (!llast) {
@@ -1301,10 +1032,6 @@ static GSList *news_get_msginfos_for_range(NNTPSession *session, FolderItem *ite
                llast = llast->next;
        }
 
-unlock_leave:
-       news_doprogress(0);
-       statusbar_pop_all();
-       inc_unlock();
        return newlist;
 }
 
@@ -1318,9 +1045,10 @@ GSList *news_get_msginfos(Folder *folder, FolderItem *item, GSList *msgnum_list)
        NNTPSession *session;
        GSList *elem, *msginfo_list = NULL, *tmp_msgnum_list, *tmp_msginfo_list;
        guint first, last, next;
+       guint tofetch, fetched;
        
        g_return_val_if_fail(folder != NULL, NULL);
-       g_return_val_if_fail(folder->type == F_NEWS, NULL);
+       g_return_val_if_fail(FOLDER_CLASS(folder) == &news_class, NULL);
        g_return_val_if_fail(msgnum_list != NULL, NULL);
        g_return_val_if_fail(item != NULL, NULL);
        
@@ -1330,21 +1058,32 @@ GSList *news_get_msginfos(Folder *folder, FolderItem *item, GSList *msgnum_list)
        tmp_msgnum_list = g_slist_copy(msgnum_list);
        tmp_msgnum_list = g_slist_sort(tmp_msgnum_list, news_fetch_msgnum_sort);
 
+       progressindicator_start(PROGRESS_TYPE_NETWORK);
+       tofetch = g_slist_length(tmp_msgnum_list);
+       fetched = 0;
+
        first = GPOINTER_TO_INT(tmp_msgnum_list->data);
        last = first;
        for(elem = g_slist_next(tmp_msgnum_list); elem != NULL; elem = g_slist_next(elem)) {
                next = GPOINTER_TO_INT(elem->data);
                if(next != (last + 1)) {
+                       session->fetch_base_percentage = ((gfloat) fetched) / ((gfloat) tofetch);
+                       session->fetch_total_percentage = ((gfloat) (last - first + 1)) / ((gfloat) tofetch);
                        tmp_msginfo_list = news_get_msginfos_for_range(session, item, first, last);
                        msginfo_list = g_slist_concat(msginfo_list, tmp_msginfo_list);
+                       fetched = last - first + 1;
                        first = next;
                }
                last = next;
        }
+       session->fetch_base_percentage = ((gfloat) fetched) / ((gfloat) tofetch);
+       session->fetch_total_percentage = ((gfloat) (last - first + 1)) / ((gfloat) tofetch);
        tmp_msginfo_list = news_get_msginfos_for_range(session, item, first, last);
        msginfo_list = g_slist_concat(msginfo_list, tmp_msginfo_list);
 
        g_slist_free(tmp_msgnum_list);
        
+       progressindicator_stop(PROGRESS_TYPE_NETWORK);
+
        return msginfo_list;
 }