2009-10-03 [colin] 3.7.2cvs42

[claws.git] / src / mimeview.c

diff --git a/src/mimeview.c b/src/mimeview.c
index 37bcd8883aef56fb42523dcb1aa8eb5d75f22fbf..de500fb7ad3ad3445bba11359bc8d5e832e3f21c 100644 (file)
--- a/src/mimeview.c
+++ b/src/mimeview.c
@@ -321,8 +321,6 @@ MimeView *mimeview_create(MainWindow *mainwin)
        mime_toggle = gtk_event_box_new();
        gtk_event_box_set_visible_window(GTK_EVENT_BOX(mime_toggle), FALSE);
 
-       g_signal_connect(G_OBJECT(mime_toggle), "visibility-notify-event",
-                        G_CALLBACK(mimeview_visi_notify), mimeview);
        g_signal_connect(G_OBJECT(mime_toggle), "motion-notify-event",
                         G_CALLBACK(mimeview_visi_notify), mimeview);
        g_signal_connect(G_OBJECT(mime_toggle), "leave-notify-event",
@@ -461,8 +459,8 @@ void mimeview_show_message(MimeView *mimeview, MimeInfo *mimeinfo,
 
        mimeview_clear(mimeview);
 
-       g_return_if_fail(file != NULL);
-       g_return_if_fail(mimeinfo != NULL);
+       cm_return_if_fail(file != NULL);
+       cm_return_if_fail(mimeinfo != NULL);
 
        mimeview->mimeinfo = mimeinfo;
 
@@ -575,7 +573,7 @@ static void mimeview_set_multipart_tree(MimeView *mimeview,
 {
        GtkCMCTreeNode *node;
 
-       g_return_if_fail(mimeinfo != NULL);
+       cm_return_if_fail(mimeinfo != NULL);
 
        while (mimeinfo != NULL) {
                node = mimeview_append_part(mimeview, mimeinfo, parent);
@@ -860,8 +858,8 @@ static void update_signature_noticeview(MimeView *mimeview, MimeInfo *mimeinfo,
        StockPixmap icon = STOCK_PIXMAP_PRIVACY_SIGNED;
        SignatureStatus mycode = SIGNATURE_UNCHECKED;
        
-       g_return_if_fail(mimeview != NULL);
-       g_return_if_fail(mimeinfo != NULL);
+       cm_return_if_fail(mimeview != NULL);
+       cm_return_if_fail(mimeinfo != NULL);
        
        if (special)
                mycode = code;
@@ -1171,8 +1169,8 @@ static void update_signature_info(MimeView *mimeview, MimeInfo *selected)
        MimeInfo *siginfo;
        MimeInfo *first_text;
        
-       g_return_if_fail(mimeview != NULL);
-       g_return_if_fail(selected != NULL);
+       cm_return_if_fail(mimeview != NULL);
+       cm_return_if_fail(selected != NULL);
        
        if (selected->type == MIMETYPE_MESSAGE 
        &&  !g_ascii_strcasecmp(selected->subtype, "rfc822")) {
@@ -1251,7 +1249,7 @@ static void mimeview_start_drag(GtkWidget *widget, gint button,
        GdkDragContext *context;
        MimeInfo *partinfo;
 
-       g_return_if_fail(mimeview != NULL);
+       cm_return_if_fail(mimeview != NULL);
 
        partinfo = mimeview_get_selected_part(mimeview);
        if (partinfo->disposition == DISPOSITIONTYPE_INLINE) return;
@@ -1598,8 +1596,10 @@ static gchar *mimeview_get_filename_for_part(MimeInfo *partinfo,
        gchar *filename;
 
        filename = g_strdup(get_part_name(partinfo));
-       if (!filename || !*filename)
+       if (!filename || !*filename) {
+               g_free(filename);
                filename = g_strdup_printf("noname.%d", number);
+       }
 
        if (!g_utf8_validate(filename, -1, NULL)) {
                gchar *tmp = conv_filename_to_utf8(filename);
@@ -1769,7 +1769,7 @@ static void mimeview_save_as(MimeView *mimeview)
 
        partinfo = mimeview_get_part_to_use(mimeview);
 
-       g_return_if_fail(partinfo != NULL);
+       cm_return_if_fail(partinfo != NULL);
        
        if (get_part_name(partinfo) == NULL) {
                return;
@@ -1825,7 +1825,7 @@ static void mimeview_display_as_text(MimeView *mimeview)
 
        partinfo = mimeview_get_part_to_use(mimeview);
        mimeview_select_mimepart_icon(mimeview, partinfo);
-       g_return_if_fail(partinfo != NULL);
+       cm_return_if_fail(partinfo != NULL);
        mimeview_show_message_part(mimeview, partinfo);
 }
 
@@ -1840,7 +1840,7 @@ static void mimeview_launch(MimeView *mimeview, MimeInfo *partinfo)
        if (!partinfo)
                partinfo = mimeview_get_part_to_use(mimeview);
 
-       g_return_if_fail(partinfo != NULL);
+       cm_return_if_fail(partinfo != NULL);
 
        filename = procmime_get_tmp_file_name(partinfo);
 
@@ -1883,7 +1883,7 @@ static void mimeview_open_part_with(MimeView *mimeview, MimeInfo *partinfo, gboo
        gchar *uri;
        int r = 0;
 #endif
-       g_return_if_fail(partinfo != NULL);
+       cm_return_if_fail(partinfo != NULL);
 
        filename = procmime_get_tmp_file_name(partinfo);
 
@@ -2217,8 +2217,6 @@ static void icon_list_append_icon (MimeView *mimeview, MimeInfo *mimeinfo)
        mimeview->icon_count++;
        button = gtk_event_box_new();
 
-       g_signal_connect(G_OBJECT(button), "visibility-notify-event",
-                        G_CALLBACK(mimeview_visi_notify), mimeview);
        g_signal_connect(G_OBJECT(button), "motion-notify-event",
                         G_CALLBACK(mimeview_visi_notify), mimeview);
        g_signal_connect(G_OBJECT(button), "leave-notify-event",
@@ -2251,7 +2249,9 @@ static void icon_list_append_icon (MimeView *mimeview, MimeInfo *mimeinfo)
                stockp = STOCK_PIXMAP_MIME_MESSAGE;
                break;
        case MIMETYPE_APPLICATION:
-               if (mimeinfo->subtype && !g_ascii_strcasecmp(mimeinfo->subtype, "pgp-signature"))
+               if (mimeinfo->subtype && (!g_ascii_strcasecmp(mimeinfo->subtype, "pgp-signature")
+                   || !g_ascii_strcasecmp(mimeinfo->subtype, "x-pkcs7-signature")
+                   || !g_ascii_strcasecmp(mimeinfo->subtype, "pkcs7-signature")))
                        stockp = STOCK_PIXMAP_MIME_PGP_SIG;
                else if (mimeinfo->subtype && !g_ascii_strcasecmp(mimeinfo->subtype, "pdf"))
                        stockp = STOCK_PIXMAP_MIME_PDF;
@@ -2421,7 +2421,7 @@ static void icon_list_create(MimeView *mimeview, MimeInfo *mimeinfo)
 {
        GtkRequisition size;
 
-       g_return_if_fail(mimeinfo != NULL);
+       cm_return_if_fail(mimeinfo != NULL);
 
        while (mimeinfo != NULL) {
                if (mimeinfo->type != MIMETYPE_MULTIPART)