2010-03-23 [pawel] 3.7.5cvs37
[claws.git] / src / mimeview.c
index dc8afb4969a460fc7b1549d05e9347a6942df5ca..b514356fc0bc17e775151e4843cca403bfa61560 100644 (file)
@@ -1,6 +1,6 @@
 /*
  * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2008 Hiroyuki Yamamoto and the Claws Mail team
+ * Copyright (C) 1999-2009 Hiroyuki Yamamoto and the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -119,10 +119,12 @@ static void mimeview_save_as              (MimeView       *mimeview);
 static void mimeview_save_all          (MimeView       *mimeview);
 static void mimeview_launch            (MimeView       *mimeview,
                                         MimeInfo       *partinfo);
+#ifndef G_OS_WIN32
 static void mimeview_open_with         (MimeView       *mimeview);
 static void mimeview_open_part_with    (MimeView       *mimeview,
                                         MimeInfo       *partinfo,
                                         gboolean        automatic);
+#endif
 static void mimeview_select_next_part  (MimeView       *mimeview);
 static void mimeview_select_prev_part  (MimeView       *mimeview);
 static void mimeview_view_file         (const gchar    *filename,
@@ -161,10 +163,12 @@ static void mimeview_launch_cb(GtkAction *action, gpointer data)
        mimeview_launch(mimeview, mimeview_get_part_to_use(mimeview));
 }
 
+#ifndef G_OS_WIN32
 static void mimeview_open_with_cb(GtkAction *action, gpointer data)
 {
        mimeview_open_with((MimeView *)data);
 }
+#endif
 
 static void mimeview_display_as_text_cb(GtkAction *action, gpointer data)
 {
@@ -189,7 +193,7 @@ static void mimeview_select_next_part_cb(GtkAction *action, gpointer data)
 static GtkActionEntry mimeview_menu_actions[] = {
        { "MimeView", NULL, "MimeView" },
        { "MimeView/Open", NULL, N_("_Open (l)"), NULL, "Open MIME part", G_CALLBACK(mimeview_launch_cb) },
-#ifndef MAEMO
+#if (!defined MAEMO && !defined G_OS_WIN32)
        { "MimeView/OpenWith", NULL, N_("Open _with (o)..."), NULL, "Open MIME part with...", G_CALLBACK(mimeview_open_with_cb) },
 #endif
        { "MimeView/DisplayAsText", NULL, N_("_Display as text (t)"), NULL, "Display as text", G_CALLBACK(mimeview_display_as_text_cb) },
@@ -250,9 +254,9 @@ MimeView *mimeview_create(MainWindow *mainwin)
        GtkWidget *arrow;
        GtkWidget *scrollbutton;
        GtkWidget *hbox;
-       GtkUIManager *gui_manager = gtkut_ui_manager();
-       GtkActionGroup *actions;
        NoticeView *siginfoview;
+       GtkRequisition r;
+
        gchar *titles[N_MIMEVIEW_COLS];
        gint i;
        CLAWS_TIP_DECL();
@@ -274,16 +278,22 @@ MimeView *mimeview_create(MainWindow *mainwin)
                                       GTK_POLICY_AUTOMATIC);
 
        ctree = gtk_sctree_new_with_titles(N_MIMEVIEW_COLS, 0, titles);
-       gtk_widget_show(ctree);
+
+       if (prefs_common.show_col_headers == FALSE)
+               gtk_cmclist_column_titles_hide(GTK_CMCLIST(ctree));
+
        gtk_cmclist_set_selection_mode(GTK_CMCLIST(ctree), GTK_SELECTION_BROWSE);
        gtk_cmctree_set_line_style(GTK_CMCTREE(ctree), GTK_CMCTREE_LINES_NONE);
        gtk_cmclist_set_column_justification(GTK_CMCLIST(ctree), COL_SIZE,
                                           GTK_JUSTIFY_RIGHT);
        gtk_cmclist_set_column_width(GTK_CMCLIST(ctree), COL_MIMETYPE, 240);
        gtk_cmclist_set_column_width(GTK_CMCLIST(ctree), COL_SIZE, 90);
+       gtk_cmclist_set_column_auto_resize(GTK_CMCLIST(ctree), COL_MIMETYPE, TRUE);
+       gtk_cmclist_set_column_auto_resize(GTK_CMCLIST(ctree), COL_NAME, TRUE); 
        for (i = 0; i < N_MIMEVIEW_COLS; i++)
                GTK_WIDGET_UNSET_FLAGS(GTK_CMCLIST(ctree)->column[i].button,
                                       GTK_CAN_FOCUS);
+       gtk_widget_show(ctree);
        gtk_container_add(GTK_CONTAINER(scrolledwin), ctree);
 
        g_signal_connect(G_OBJECT(ctree), "tree_select_row",
@@ -317,8 +327,6 @@ MimeView *mimeview_create(MainWindow *mainwin)
        mime_toggle = gtk_event_box_new();
        gtk_event_box_set_visible_window(GTK_EVENT_BOX(mime_toggle), FALSE);
 
-       g_signal_connect(G_OBJECT(mime_toggle), "visibility-notify-event",
-                        G_CALLBACK(mimeview_visi_notify), mimeview);
        g_signal_connect(G_OBJECT(mime_toggle), "motion-notify-event",
                         G_CALLBACK(mimeview_visi_notify), mimeview);
        g_signal_connect(G_OBJECT(mime_toggle), "leave-notify-event",
@@ -331,6 +339,7 @@ MimeView *mimeview_create(MainWindow *mainwin)
        mimeview->ctree_mode = FALSE;
        arrow = gtk_arrow_new(GTK_ARROW_LEFT, GTK_SHADOW_NONE);
        gtk_widget_show(arrow);
+       gtk_widget_size_request(arrow, &r);
        gtk_container_add(GTK_CONTAINER(mime_toggle), arrow);
        g_signal_connect(G_OBJECT(mime_toggle), "button_release_event", 
                         G_CALLBACK(mime_toggle_button_cb), mimeview);
@@ -347,27 +356,37 @@ MimeView *mimeview_create(MainWindow *mainwin)
        ctree_mainbox = gtk_hbox_new(FALSE, 0); 
        gtk_box_pack_start(GTK_BOX(ctree_mainbox), scrolledwin, TRUE, TRUE, 0);
 
-       actions = cm_menu_create_action_group("MimeView", mimeview_menu_actions,
+       mimeview->ui_manager = gtk_ui_manager_new();
+       mimeview->action_group = cm_menu_create_action_group_full(mimeview->ui_manager,
+                       "MimeView", mimeview_menu_actions,
                        G_N_ELEMENTS(mimeview_menu_actions), (gpointer)mimeview);
 
-       MENUITEM_ADDUI("/Menus/", "MimeView", "MimeView", GTK_UI_MANAGER_MENU);
-       MENUITEM_ADDUI("/Menus/MimeView/", "Open", "MimeView/Open",
+       MENUITEM_ADDUI_MANAGER(mimeview->ui_manager, "/", "Menus", "Menus", GTK_UI_MANAGER_MENUBAR)
+       MENUITEM_ADDUI_MANAGER(mimeview->ui_manager, 
+                       "/Menus/", "MimeView", "MimeView", GTK_UI_MANAGER_MENU);
+       MENUITEM_ADDUI_MANAGER(mimeview->ui_manager, 
+                       "/Menus/MimeView/", "Open", "MimeView/Open",
                        GTK_UI_MANAGER_MENUITEM);
-#ifndef MAEMO
-       MENUITEM_ADDUI("/Menus/MimeView/", "OpenWith", "MimeView/OpenWith",
+#if (!defined MAEMO && !defined G_OS_WIN32)
+       MENUITEM_ADDUI_MANAGER(mimeview->ui_manager, 
+                       "/Menus/MimeView/", "OpenWith", "MimeView/OpenWith",
                        GTK_UI_MANAGER_MENUITEM);
 #endif
-       MENUITEM_ADDUI("/Menus/MimeView/", "DisplayAsText", "MimeView/DisplayAsText",
+       MENUITEM_ADDUI_MANAGER(mimeview->ui_manager, 
+                       "/Menus/MimeView/", "DisplayAsText", "MimeView/DisplayAsText",
                        GTK_UI_MANAGER_MENUITEM);
-       MENUITEM_ADDUI("/Menus/MimeView/", "SaveAs", "MimeView/SaveAs",
+       MENUITEM_ADDUI_MANAGER(mimeview->ui_manager, 
+                       "/Menus/MimeView/", "SaveAs", "MimeView/SaveAs",
                        GTK_UI_MANAGER_MENUITEM);
-       MENUITEM_ADDUI("/Menus/MimeView/", "SaveAll", "MimeView/SaveAll",
+       MENUITEM_ADDUI_MANAGER(mimeview->ui_manager, 
+                       "/Menus/MimeView/", "SaveAll", "MimeView/SaveAll",
                        GTK_UI_MANAGER_MENUITEM);
-       MENUITEM_ADDUI("/Menus/MimeView/", "NextPart", "MimeView/NextPart",
+       MENUITEM_ADDUI_MANAGER(mimeview->ui_manager, 
+                       "/Menus/MimeView/", "NextPart", "MimeView/NextPart",
                        GTK_UI_MANAGER_MENUITEM);
 
        popupmenu = gtk_menu_item_get_submenu(GTK_MENU_ITEM(
-                               gtk_ui_manager_get_widget(gui_manager, "/Menus/MimeView")) );
+                               gtk_ui_manager_get_widget(mimeview->ui_manager, "/Menus/MimeView")) );
 
 
        vbox = gtk_vbox_new(FALSE, 0);
@@ -390,7 +409,7 @@ MimeView *mimeview_create(MainWindow *mainwin)
        gtk_widget_show(hbox);
        gtk_widget_hide(ctree_mainbox);
 #ifdef GENERIC_UMPC
-       gtk_widget_set_size_request(mime_toggle, -1, arrow->requisition.height + 8);
+       gtk_widget_set_size_request(mime_toggle, -1, r.height + 8);
 #endif
        mimeview->hbox          = hbox;
        mimeview->paned         = paned;
@@ -446,8 +465,8 @@ void mimeview_show_message(MimeView *mimeview, MimeInfo *mimeinfo,
 
        mimeview_clear(mimeview);
 
-       g_return_if_fail(file != NULL);
-       g_return_if_fail(mimeinfo != NULL);
+       cm_return_if_fail(file != NULL);
+       cm_return_if_fail(mimeinfo != NULL);
 
        mimeview->mimeinfo = mimeinfo;
 
@@ -560,7 +579,7 @@ static void mimeview_set_multipart_tree(MimeView *mimeview,
 {
        GtkCMCTreeNode *node;
 
-       g_return_if_fail(mimeinfo != NULL);
+       cm_return_if_fail(mimeinfo != NULL);
 
        while (mimeinfo != NULL) {
                node = mimeview_append_part(mimeview, mimeinfo, parent);
@@ -624,7 +643,7 @@ static GtkCMCTreeNode *mimeview_append_part(MimeView *mimeview,
                str[COL_NAME] = (gchar *) get_part_name(partinfo);
 
        node = gtk_sctree_insert_node(ctree, parent, NULL, str, 0,
-                                    NULL, NULL, NULL, NULL,
+                                    NULL, NULL,
                                     FALSE, TRUE);
        gtk_cmctree_node_set_row_data(ctree, node, partinfo);
 
@@ -744,6 +763,11 @@ gboolean mimeview_show_part(MimeView *mimeview, MimeInfo *partinfo)
 {
        MimeViewer *viewer;
        
+       if (mimeview->messageview->partial_display_shown) {
+               noticeview_hide(mimeview->messageview->noticeview);
+               mimeview->messageview->partial_display_shown = FALSE;
+       }
+
        viewer = get_viewer_for_mimeinfo(mimeview, partinfo);
        if (viewer == NULL) {
                if (mimeview->mimeviewer != NULL)
@@ -840,8 +864,8 @@ static void update_signature_noticeview(MimeView *mimeview, MimeInfo *mimeinfo,
        StockPixmap icon = STOCK_PIXMAP_PRIVACY_SIGNED;
        SignatureStatus mycode = SIGNATURE_UNCHECKED;
        
-       g_return_if_fail(mimeview != NULL);
-       g_return_if_fail(mimeinfo != NULL);
+       cm_return_if_fail(mimeview != NULL);
+       cm_return_if_fail(mimeinfo != NULL);
        
        if (special)
                mycode = code;
@@ -1151,8 +1175,8 @@ static void update_signature_info(MimeView *mimeview, MimeInfo *selected)
        MimeInfo *siginfo;
        MimeInfo *first_text;
        
-       g_return_if_fail(mimeview != NULL);
-       g_return_if_fail(selected != NULL);
+       cm_return_if_fail(mimeview != NULL);
+       cm_return_if_fail(selected != NULL);
        
        if (selected->type == MIMETYPE_MESSAGE 
        &&  !g_ascii_strcasecmp(selected->subtype, "rfc822")) {
@@ -1231,7 +1255,7 @@ static void mimeview_start_drag(GtkWidget *widget, gint button,
        GdkDragContext *context;
        MimeInfo *partinfo;
 
-       g_return_if_fail(mimeview != NULL);
+       cm_return_if_fail(mimeview != NULL);
 
        partinfo = mimeview_get_selected_part(mimeview);
        if (partinfo->disposition == DISPOSITIONTYPE_INLINE) return;
@@ -1293,15 +1317,17 @@ static gboolean part_button_pressed(MimeView *mimeview, GdkEventButton *event,
                if (partinfo && (partinfo->type == MIMETYPE_MESSAGE ||
                                 partinfo->type == MIMETYPE_IMAGE ||
                                 partinfo->type == MIMETYPE_MULTIPART))
-                       cm_menu_set_sensitive("MimeView/DisplayAsText", FALSE);
+                       cm_menu_set_sensitive_full(mimeview->ui_manager, "Menus/MimeView/DisplayAsText", FALSE);
                else
-                       cm_menu_set_sensitive("MimeView/DisplayAsText", TRUE);
+                       cm_menu_set_sensitive_full(mimeview->ui_manager, "Menus/MimeView/DisplayAsText", TRUE);
+#ifndef G_OS_WIN32
                if (partinfo &&
                    partinfo->type == MIMETYPE_APPLICATION &&
                    !g_ascii_strcasecmp(partinfo->subtype, "octet-stream"))
-                       cm_menu_set_sensitive("MimeView/Open", FALSE);
+                       cm_menu_set_sensitive_full(mimeview->ui_manager, "Menus/MimeView/Open", FALSE);
                else
-                       cm_menu_set_sensitive("MimeView/Open", TRUE);
+#endif
+                       cm_menu_set_sensitive_full(mimeview->ui_manager, "Menus/MimeView/Open", TRUE);
 
                g_object_set_data(G_OBJECT(mimeview->popupmenu),
                                  "pop_partinfo", partinfo);
@@ -1387,13 +1413,16 @@ static gint mimeview_key_pressed(GtkWidget *widget, GdkEventKey *event,
                return FALSE;
                
        switch (event->keyval) {
+       case GDK_Page_Down:
        case GDK_space:
-               if (mimeview_scroll_page(mimeview, FALSE))
+               if (mimeview_scroll_page(mimeview,
+                                        (event->state & GDK_SHIFT_MASK) != 0))
                        return TRUE;
-
-               mimeview_select_next_part(mimeview);
+                       
+               if (!(event->state & GDK_SHIFT_MASK))
+                       mimeview_select_next_part(mimeview);
                return TRUE;
-
+       case GDK_Page_Up:
        case GDK_BackSpace:
                mimeview_scroll_page(mimeview, TRUE);
                return TRUE;
@@ -1402,6 +1431,10 @@ static gint mimeview_key_pressed(GtkWidget *widget, GdkEventKey *event,
                mimeview_scroll_one_line(mimeview,
                                         (event->state & GDK_MOD1_MASK) != 0);
                return TRUE;
+       case GDK_Up:
+       case GDK_Down:
+               mimeview_scroll_one_line(mimeview, (event->keyval == GDK_Up));
+               return TRUE;
        case GDK_n:
        case GDK_N:
                BREAK_ON_MODIFIER_KEY();
@@ -1432,7 +1465,9 @@ static gint mimeview_key_pressed(GtkWidget *widget, GdkEventKey *event,
        case GDK_o:
                BREAK_ON_MODIFIER_KEY();
                KEY_PRESS_EVENT_STOP();
+#ifndef G_OS_WIN32
                mimeview_open_with(mimeview);
+#endif
                return TRUE;
        case GDK_c:
                BREAK_ON_MODIFIER_KEY();
@@ -1574,8 +1609,10 @@ static gchar *mimeview_get_filename_for_part(MimeInfo *partinfo,
        gchar *filename;
 
        filename = g_strdup(get_part_name(partinfo));
-       if (!filename || !*filename)
+       if (!filename || !*filename) {
+               g_free(filename);
                filename = g_strdup_printf("noname.%d", number);
+       }
 
        if (!g_utf8_validate(filename, -1, NULL)) {
                gchar *tmp = conv_filename_to_utf8(filename);
@@ -1586,7 +1623,7 @@ static gchar *mimeview_get_filename_for_part(MimeInfo *partinfo,
        subst_for_filename(filename);
 
        fullname = g_strconcat
-               (basedir, G_DIR_SEPARATOR_S, (filename[0] == G_DIR_SEPARATOR)
+               (basedir, G_DIR_SEPARATOR_S, (g_path_is_absolute(filename))
                 ? &filename[1] : filename, NULL);
 
        g_free(filename);
@@ -1745,7 +1782,7 @@ static void mimeview_save_as(MimeView *mimeview)
 
        partinfo = mimeview_get_part_to_use(mimeview);
 
-       g_return_if_fail(partinfo != NULL);
+       cm_return_if_fail(partinfo != NULL);
        
        if (get_part_name(partinfo) == NULL) {
                return;
@@ -1767,7 +1804,7 @@ static void mimeview_save_as(MimeView *mimeview)
 
        subst_for_filename(partname);
        
-       if (prefs_common.attach_save_dir)
+       if (prefs_common.attach_save_dir && *prefs_common.attach_save_dir)
                filepath = g_strconcat(prefs_common.attach_save_dir,
                                       G_DIR_SEPARATOR_S, partname, NULL);
        else
@@ -1801,7 +1838,7 @@ static void mimeview_display_as_text(MimeView *mimeview)
 
        partinfo = mimeview_get_part_to_use(mimeview);
        mimeview_select_mimepart_icon(mimeview, partinfo);
-       g_return_if_fail(partinfo != NULL);
+       cm_return_if_fail(partinfo != NULL);
        mimeview_show_message_part(mimeview, partinfo);
 }
 
@@ -1816,7 +1853,7 @@ static void mimeview_launch(MimeView *mimeview, MimeInfo *partinfo)
        if (!partinfo)
                partinfo = mimeview_get_part_to_use(mimeview);
 
-       g_return_if_fail(partinfo != NULL);
+       cm_return_if_fail(partinfo != NULL);
 
        filename = procmime_get_tmp_file_name(partinfo);
 
@@ -1830,6 +1867,7 @@ static void mimeview_launch(MimeView *mimeview, MimeInfo *partinfo)
        g_free(filename);
 }
 
+#ifndef G_OS_WIN32
 static void mimeview_open_with(MimeView *mimeview)
 {
        MimeInfo *partinfo;
@@ -1858,7 +1896,7 @@ static void mimeview_open_part_with(MimeView *mimeview, MimeInfo *partinfo, gboo
        gchar *uri;
        int r = 0;
 #endif
-       g_return_if_fail(partinfo != NULL);
+       cm_return_if_fail(partinfo != NULL);
 
        filename = procmime_get_tmp_file_name(partinfo);
 
@@ -1929,14 +1967,14 @@ static void mimeview_open_part_with(MimeView *mimeview, MimeInfo *partinfo, gboo
                if (content_type != NULL)
                        cmd = input_dialog_combo_remember
                                (_("Open with"),
-                                _("Enter the command line to open file:\n"
+                                _("Enter the command-line to open file:\n"
                                   "('%s' will be replaced with file name)"),
                                 mime_command ? mime_command : prefs_common.mime_open_cmd,
                                 prefs_common.mime_open_cmd_history, &remember);
                else
                        cmd = input_dialog_combo
                                (_("Open with"),
-                                _("Enter the command line to open file:\n"
+                                _("Enter the command-line to open file:\n"
                                   "('%s' will be replaced with file name)"),
                                 mime_command ? mime_command : prefs_common.mime_open_cmd,
                                 prefs_common.mime_open_cmd_history);
@@ -1960,10 +1998,12 @@ out:
        g_free(content_type);
        g_free(filename);
 }
+#endif
 
 static void mimeview_view_file(const gchar *filename, MimeInfo *partinfo,
                               const gchar *cmd, MimeView *mimeview)
 {
+#ifndef G_OS_WIN32
        gchar *p;
        gchar buf[BUFFSIZE];
        if (cmd == NULL)
@@ -1977,7 +2017,7 @@ static void mimeview_view_file(const gchar *filename, MimeInfo *partinfo,
                        else
                                g_chmod(filename, S_IRUSR|S_IWUSR);
                } else {
-                       g_warning("MIME viewer command line is invalid: '%s'", cmd);
+                       g_warning("MIME viewer command-line is invalid: '%s'", cmd);
                        mimeview_open_part_with(mimeview, partinfo, FALSE);
                }
                if (execute_command_line(buf, TRUE) != 0) {
@@ -1986,6 +2026,24 @@ static void mimeview_view_file(const gchar *filename, MimeInfo *partinfo,
                        mimeview_open_part_with(mimeview, partinfo, FALSE);
                }
        }
+#else
+       SHFILEINFO file_info;
+       if ((SHGetFileInfo(filename, 0, &file_info, sizeof(SHFILEINFO), SHGFI_EXETYPE)) != 0) {
+               AlertValue val = alertpanel_full(_("Execute untrusted binary?"), 
+                                     _("This attachment is an executable file. Executing "
+                                       "untrusted binaries is dangerous and could probably "
+                                       "lead to compromission of your computer.\n\n"
+                                       "Do you want to run this file?"), GTK_STOCK_CANCEL, 
+                                       _("Run binary"),
+                                     NULL, FALSE, NULL, ALERT_WARNING, G_ALERTDEFAULT);
+               if (val == G_ALERTALTERNATE) {
+                       debug_print("executing binary\n");
+                       ShellExecute(NULL, "open", filename, NULL, NULL, SW_SHOW);
+               }
+       } else
+               ShellExecute(NULL, "open", filename, NULL, NULL, SW_SHOW);
+       
+#endif
 }
 
 void mimeview_register_viewer_factory(MimeViewerFactory *factory)
@@ -2111,10 +2169,12 @@ static gint icon_key_pressed(GtkWidget *button, GdkEventKey *event,
                BREAK_ON_MODIFIER_KEY();
                mimeview_launch(mimeview, NULL);
                return TRUE;
+#ifndef G_OS_WIN32
        case GDK_o:
                BREAK_ON_MODIFIER_KEY();
                mimeview_open_with(mimeview);
                return TRUE;
+#endif
        case GDK_c:
                BREAK_ON_MODIFIER_KEY();
                mimeview_check_signature(mimeview);
@@ -2159,6 +2219,9 @@ static void icon_list_append_icon (MimeView *mimeview, MimeInfo *mimeinfo)
        MimeInfo *partinfo;
        MimeInfo *siginfo = NULL;
        MimeInfo *encrypted = NULL;
+#ifdef GENERIC_UMPC
+       GtkRequisition r;
+#endif
 #if !(GTK_CHECK_VERSION(2,12,0))
        GtkTooltips *tips = mimeview->tooltips;
 #endif
@@ -2167,8 +2230,6 @@ static void icon_list_append_icon (MimeView *mimeview, MimeInfo *mimeinfo)
        mimeview->icon_count++;
        button = gtk_event_box_new();
 
-       g_signal_connect(G_OBJECT(button), "visibility-notify-event",
-                        G_CALLBACK(mimeview_visi_notify), mimeview);
        g_signal_connect(G_OBJECT(button), "motion-notify-event",
                         G_CALLBACK(mimeview_visi_notify), mimeview);
        g_signal_connect(G_OBJECT(button), "leave-notify-event",
@@ -2201,7 +2262,9 @@ static void icon_list_append_icon (MimeView *mimeview, MimeInfo *mimeinfo)
                stockp = STOCK_PIXMAP_MIME_MESSAGE;
                break;
        case MIMETYPE_APPLICATION:
-               if (mimeinfo->subtype && !g_ascii_strcasecmp(mimeinfo->subtype, "pgp-signature"))
+               if (mimeinfo->subtype && (!g_ascii_strcasecmp(mimeinfo->subtype, "pgp-signature")
+                   || !g_ascii_strcasecmp(mimeinfo->subtype, "x-pkcs7-signature")
+                   || !g_ascii_strcasecmp(mimeinfo->subtype, "pkcs7-signature")))
                        stockp = STOCK_PIXMAP_MIME_PGP_SIG;
                else if (mimeinfo->subtype && !g_ascii_strcasecmp(mimeinfo->subtype, "pdf"))
                        stockp = STOCK_PIXMAP_MIME_PDF;
@@ -2275,8 +2338,15 @@ static void icon_list_append_icon (MimeView *mimeview, MimeInfo *mimeinfo)
        content_type = procmime_get_content_type_str(mimeinfo->type,
                                                     mimeinfo->subtype);
 
-       tip = g_strjoin("\n", content_type,
-                       to_human_readable((goffset)mimeinfo->length), NULL);
+#if GTK_CHECK_VERSION(2,12,0)
+       tip = g_strconcat("<b>", _("Type:"), "  </b>", content_type,
+                         "\n<b>", _("Size:"), " </b>",
+                         to_human_readable((goffset)mimeinfo->length), NULL);
+#else
+       tip = g_strconcat(_("Type:"), " ", content_type,
+                         "\n", _("Size:"), " ",
+                         to_human_readable((goffset)mimeinfo->length), NULL);
+#endif 
        g_free(content_type);
        if (desc && *desc) {
                gchar *tmp = NULL;
@@ -2285,7 +2355,17 @@ static void icon_list_append_icon (MimeView *mimeview, MimeInfo *mimeinfo)
                } else {
                        tmp = g_strdup(desc);
                }
-               tiptmp = g_strjoin("\n", tmp, tip, NULL);
+#if GTK_CHECK_VERSION(2,12,0)
+               tiptmp = g_strconcat(tip, "\n<b>",
+                               prefs_common.attach_desc && mimeinfo->description ?
+                               _("Description:") : _("Filename:"),
+                               " </b>", tmp, NULL);
+#else
+               tiptmp = g_strconcat(tip, "\n",
+                               prefs_common.attach_desc && mimeinfo->description ?
+                               _("Description:") : _("Filename:"),
+                               " ", tmp, NULL);
+#endif
                g_free(tip);
                tip = tiptmp;
                g_free(tmp);
@@ -2297,7 +2377,11 @@ static void icon_list_append_icon (MimeView *mimeview, MimeInfo *mimeinfo)
        }
        g_free(sigshort);
 
+#if GTK_CHECK_VERSION(2,12,0)
+       gtk_widget_set_tooltip_markup(button, tip);
+#else
        CLAWS_SET_TIP(button, tip);
+#endif
        g_free(tip);
        gtk_widget_show_all(button);
        gtk_drag_source_set(button, GDK_BUTTON1_MASK|GDK_BUTTON3_MASK, 
@@ -2319,23 +2403,23 @@ static void icon_list_append_icon (MimeView *mimeview, MimeInfo *mimeinfo)
                         G_CALLBACK(mimeview_drag_data_get), mimeview);
        gtk_box_pack_start(GTK_BOX(vbox), button, FALSE, FALSE, 0);
 #ifdef GENERIC_UMPC
-       gtk_widget_set_size_request(vbox, -1, pixmap->requisition.height + 8);
-       gtk_widget_set_size_request(button, -1, pixmap->requisition.height + 4);
+       gtk_widget_size_request(pixmap, &r);
+       gtk_widget_set_size_request(button, -1, r.height + 4);
 #endif
 
 }
 
 static void icon_list_clear (MimeView *mimeview)
 {
-       GList     *child;
+       GList     *child, *orig;
        GtkAdjustment *adj;
                
-       child = gtk_container_get_children(GTK_CONTAINER(mimeview->icon_vbox));
-       for (; child != NULL; child = g_list_next(child)) {
+       orig = gtk_container_get_children(GTK_CONTAINER(mimeview->icon_vbox));
+       for (child = orig; child != NULL; child = g_list_next(child)) {
                gtkut_container_remove(GTK_CONTAINER(mimeview->icon_vbox), 
                                       GTK_WIDGET(child->data));
        }
-       g_list_free(child);
+       g_list_free(orig);
        mimeview->icon_count = 0;
        adj  = gtk_layout_get_vadjustment(GTK_LAYOUT(mimeview->icon_scroll));
        gtk_adjustment_set_value(adj, adj->lower);
@@ -2354,7 +2438,7 @@ static void icon_scroll_size_allocate_cb(GtkWidget *widget,
        GtkAllocation *vbox_size;
        GtkAllocation *layout_size;
        GtkAdjustment *adj;
-       
+
        adj = gtk_layout_get_vadjustment(GTK_LAYOUT(mimeview->icon_scroll));
 
        mainbox_size = &mimeview->icon_mainbox->allocation;
@@ -2371,7 +2455,7 @@ static void icon_list_create(MimeView *mimeview, MimeInfo *mimeinfo)
 {
        GtkRequisition size;
 
-       g_return_if_fail(mimeinfo != NULL);
+       cm_return_if_fail(mimeinfo != NULL);
 
        while (mimeinfo != NULL) {
                if (mimeinfo->type != MIMETYPE_MULTIPART)
@@ -2425,7 +2509,7 @@ static gint mime_toggle_button_cb(GtkWidget *button, GdkEventButton *event,
 
        mimeview->ctree_mode = !mimeview->ctree_mode;
        if (mimeview->ctree_mode) {
-               gtk_arrow_set(GTK_ARROW(GTK_BIN(button)->child), GTK_ARROW_RIGHT, 
+               gtk_arrow_set(GTK_ARROW(gtk_bin_get_child(GTK_BIN((button)))), GTK_ARROW_RIGHT, 
                                        GTK_SHADOW_NONE);
                gtk_widget_hide(mimeview->icon_mainbox);
                gtk_widget_show(mimeview->ctree_mainbox);
@@ -2436,7 +2520,7 @@ static gint mime_toggle_button_cb(GtkWidget *button, GdkEventButton *event,
                gtk_box_pack_end(GTK_BOX(mimeview->ctree_mainbox), 
                                   button, FALSE, FALSE, 0);
        } else {
-               gtk_arrow_set(GTK_ARROW(GTK_BIN(button)->child), GTK_ARROW_LEFT, 
+               gtk_arrow_set(GTK_ARROW(gtk_bin_get_child(GTK_BIN((button)))), GTK_ARROW_LEFT, 
                              GTK_SHADOW_NONE);
                mimeview->oldsize = mimeview->ctree_mainbox->allocation.height;
                gtk_widget_hide(mimeview->ctree_mainbox);
@@ -2490,8 +2574,10 @@ void mimeview_handle_cmd(MimeView *mimeview, const gchar *cmd, GdkEventButton *e
                mimeview_save_as(mimeview);
        else if (!strcmp(cmd, "sc://display_as_text"))
                mimeview_display_as_text(mimeview);
+#ifndef G_OS_WIN32
        else if (!strcmp(cmd, "sc://open_with"))
                mimeview_open_with(mimeview);
+#endif
        else if (!strcmp(cmd, "sc://open"))
                mimeview_launch(mimeview, NULL);
        else if (!strcmp(cmd, "sc://select_attachment") && data != NULL) {