Coverity fixes
[claws.git] / src / mh.c
index bbed7e84f97e410e1a22b36eb768c1a89998249f..e7b988876fe35774afd3187fdcd0356eef3ed37f 100644 (file)
--- a/src/mh.c
+++ b/src/mh.c
@@ -1,10 +1,10 @@
 /*
  * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2006 Hiroyuki Yamamoto and the Sylpheed-Claws team
+ * Copyright (C) 1999-2013 Hiroyuki Yamamoto and the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
+ * the Free Software Foundation; either version 3 of the License, or
  * (at your option) any later version.
  *
  * This program is distributed in the hope that it will be useful,
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ * 
  */
 
 #ifdef HAVE_CONFIG_H
 #  include "config.h"
+#include "claws-features.h"
 #endif
 
 #include "defs.h"
 #include <unistd.h>
 #include <string.h>
 #include <errno.h>
-
-#undef MEASURE_TIME
-
-#ifdef MEASURE_TIME
-#  include <sys/time.h>
-#endif
+#include <time.h>
 
 #include "folder.h"
+#include "folder_item_prefs.h"
 #include "mh.h"
 #include "procmsg.h"
 #include "procheader.h"
@@ -45,6 +42,7 @@
 #include "codeconv.h"
 #include "statusbar.h"
 #include "gtkutils.h"
+#include "timing.h"
 
 /* Define possible missing constants for Windows. */
 #ifdef G_OS_WIN32
@@ -79,21 +77,21 @@ static gint     mh_add_msg          (Folder         *folder,
 static gint     mh_add_msgs            (Folder         *folder,
                                         FolderItem     *dest,
                                         GSList         *file_list,
-                                        GRelation      *relation);
+                                        GHashTable     *relation);
 static gint     mh_copy_msg            (Folder         *folder,
                                         FolderItem     *dest,
                                         MsgInfo        *msginfo);
 static gint    mh_copy_msgs            (Folder         *folder, 
                                         FolderItem     *dest, 
                                         MsgInfoList    *msglist, 
-                                        GRelation      *relation);
+                                        GHashTable     *relation);
 static gint     mh_remove_msg          (Folder         *folder,
                                         FolderItem     *item,
                                         gint            num);
 static gint    mh_remove_msgs          (Folder         *folder, 
                                         FolderItem     *item, 
                                         MsgInfoList    *msglist, 
-                                        GRelation      *relation);
+                                        GHashTable     *relation);
 static gint     mh_remove_all_msg      (Folder         *folder,
                                         FolderItem     *item);
 static gboolean mh_is_msg_changed      (Folder         *folder,
@@ -132,11 +130,13 @@ static gchar   *mh_item_get_path          (Folder *folder,
 
 static gboolean mh_scan_required       (Folder         *folder,
                                         FolderItem     *item);
+static void mh_set_mtime               (Folder         *folder,
+                                        FolderItem *item);
 static int mh_item_close               (Folder         *folder,
                                         FolderItem     *item);
 #if 0
 static gint mh_get_flags               (Folder *folder, FolderItem *item,
-                                        MsgInfoList *msginfo_list, GRelation *msgflags);
+                                        MsgInfoList *msginfo_list, GHashTable *msgflags);
 #endif
 static void mh_write_sequences         (FolderItem     *item, gboolean remove_unseen);
 
@@ -148,6 +148,7 @@ FolderClass *mh_get_class(void)
                mh_class.type = F_MH;
                mh_class.idstr = "mh";
                mh_class.uistr = "MH";
+               mh_class.supports_server_search = FALSE;
                
                /* Folder functions */
                mh_class.new_folder = mh_folder_new;
@@ -164,6 +165,7 @@ FolderClass *mh_get_class(void)
                mh_class.remove_folder = mh_remove_folder;
                mh_class.get_num_list = mh_get_num_list;
                mh_class.scan_required = mh_scan_required;
+               mh_class.set_mtime = mh_set_mtime;
                mh_class.close = mh_item_close;
                mh_class.get_flags = NULL; /*mh_get_flags */;
 
@@ -174,6 +176,7 @@ FolderClass *mh_get_class(void)
                mh_class.add_msgs = mh_add_msgs;
                mh_class.copy_msg = mh_copy_msg;
                mh_class.copy_msgs = mh_copy_msgs;
+               mh_class.search_msgs = folder_item_search_msgs_local;
                mh_class.remove_msg = mh_remove_msg;
                mh_class.remove_msgs = mh_remove_msgs;
                mh_class.remove_all_msg = mh_remove_all_msg;
@@ -211,9 +214,9 @@ gboolean mh_scan_required(Folder *folder, FolderItem *item)
        struct stat s;
 
        path = folder_item_get_path(item);
-       g_return_val_if_fail(path != NULL, FALSE);
+       cm_return_val_if_fail(path != NULL, FALSE);
 
-       if (stat(path, &s) < 0) {
+       if (g_stat(path, &s) < 0) {
                FILE_OP_ERROR(path, "stat");
                g_free(path);
                return FALSE;
@@ -222,7 +225,7 @@ gboolean mh_scan_required(Folder *folder, FolderItem *item)
        if ((s.st_mtime > item->mtime) &&
                (s.st_mtime - 3600 != item->mtime)) {
                debug_print("MH scan required, folder updated: %s (%ld > %ld)\n",
-                           path,
+                           path?path:"(null)",
                            (long int) s.st_mtime,
                            (long int) item->mtime);
                g_free(path);
@@ -230,14 +233,14 @@ gboolean mh_scan_required(Folder *folder, FolderItem *item)
        }
 
        debug_print("MH scan not required: %s (%ld <= %ld)\n",
-                   path,
+                   path?path:"(null)",
                    (long int) s.st_mtime,
                    (long int) item->mtime);
        g_free(path);
        return FALSE;
 }
 
-void mh_get_last_num(Folder *folder, FolderItem *item)
+static void mh_get_last_num(Folder *folder, FolderItem *item)
 {
        gchar *path;
        DIR *dp;
@@ -245,12 +248,12 @@ void mh_get_last_num(Folder *folder, FolderItem *item)
        gint max = 0;
        gint num;
 
-       g_return_if_fail(item != NULL);
+       cm_return_if_fail(item != NULL);
 
-       debug_print("mh_get_last_num(): Scanning %s ...\n", item->path);
+       debug_print("mh_get_last_num(): Scanning %s ...\n", item->path?item->path:"(null)");
 
        path = folder_item_get_path(item);
-       g_return_if_fail(path != NULL);
+       cm_return_if_fail(path != NULL);
        if (change_dir(path) < 0) {
                g_free(path);
                return;
@@ -268,10 +271,12 @@ void mh_get_last_num(Folder *folder, FolderItem *item)
                        if (max < num)
                                max = num;
                }
+               if (num % 2000 == 0)
+                       GTK_EVENTS_FLUSH();
        }
        closedir(dp);
 
-       debug_print("Last number in dir %s = %d\n", item->path, max);
+       debug_print("Last number in dir %s = %d\n", item->path?item->path:"(null)", max);
        item->last_num = max;
 }
 
@@ -283,14 +288,14 @@ gint mh_get_num_list(Folder *folder, FolderItem *item, GSList **list, gboolean *
        struct dirent *d;
        gint num, nummsgs = 0;
 
-       g_return_val_if_fail(item != NULL, -1);
+       cm_return_val_if_fail(item != NULL, -1);
 
-       debug_print("mh_get_num_list(): Scanning %s ...\n", item->path);
+       debug_print("mh_get_num_list(): Scanning %s ...\n", item->path?item->path:"(null)");
 
        *old_uids_valid = TRUE;
 
        path = folder_item_get_path(item);
-       g_return_val_if_fail(path != NULL, -1);
+       cm_return_val_if_fail(path != NULL, -1);
        if (change_dir(path) < 0) {
                g_free(path);
                return -1;
@@ -310,8 +315,7 @@ gint mh_get_num_list(Folder *folder, FolderItem *item, GSList **list, gboolean *
        }
        closedir(dp);
 
-       item->mtime = time(NULL);
-       debug_print("MH: forced mtime of %s to %ld\n", item->name, item->mtime);
+       mh_set_mtime(folder, item);
        return nummsgs;
 }
 
@@ -320,8 +324,8 @@ static gchar *mh_fetch_msg(Folder *folder, FolderItem *item, gint num)
        gchar *path;
        gchar *file;
 
-       g_return_val_if_fail(item != NULL, NULL);
-       g_return_val_if_fail(num > 0, NULL);
+       cm_return_val_if_fail(item != NULL, NULL);
+       cm_return_val_if_fail(num > 0, NULL);
 
        path = folder_item_get_path(item);
        file = g_strconcat(path, G_DIR_SEPARATOR_S, itos(num), NULL);
@@ -340,7 +344,7 @@ static MsgInfo *mh_get_msginfo(Folder *folder, FolderItem *item, gint num)
        MsgInfo *msginfo;
        gchar *file;
 
-       g_return_val_if_fail(item != NULL, NULL);
+       cm_return_val_if_fail(item != NULL, NULL);
        if (num <= 0)
                return NULL;
 
@@ -362,7 +366,7 @@ static gchar *mh_get_new_msg_filename(FolderItem *dest)
        gchar *destpath;
 
        destpath = folder_item_get_path(dest);
-       g_return_val_if_fail(destpath != NULL, NULL);
+       cm_return_val_if_fail(destpath != NULL, NULL);
 
        if (!is_dir_exist(destpath))
                make_dir_hier(destpath);
@@ -388,7 +392,7 @@ static gint mh_add_msg(Folder *folder, FolderItem *dest, const gchar *file, MsgF
        GSList file_list;
        MsgFileInfo fileinfo;
 
-       g_return_val_if_fail(file != NULL, -1);
+       cm_return_val_if_fail(file != NULL, -1);
 
        fileinfo.msginfo = NULL;
        fileinfo.file = (gchar *)file;
@@ -401,14 +405,14 @@ static gint mh_add_msg(Folder *folder, FolderItem *dest, const gchar *file, MsgF
 } 
  
 static gint mh_add_msgs(Folder *folder, FolderItem *dest, GSList *file_list, 
-                 GRelation *relation)
+                 GHashTable *relation)
 { 
        gchar *destfile;
        GSList *cur;
        MsgFileInfo *fileinfo;
 
-       g_return_val_if_fail(dest != NULL, -1);
-       g_return_val_if_fail(file_list != NULL, -1);
+       cm_return_val_if_fail(dest != NULL, -1);
+       cm_return_val_if_fail(file_list != NULL, -1);
 
        if (dest->last_num < 0) {
                mh_get_last_num(folder, dest);
@@ -435,7 +439,7 @@ static gint mh_add_msgs(Folder *folder, FolderItem *dest, GSList *file_list,
 #endif
 
                if (relation != NULL)
-                       g_relation_insert(relation, fileinfo, GINT_TO_POINTER(dest->last_num + 1));
+                       g_hash_table_insert(relation, fileinfo, GINT_TO_POINTER(dest->last_num + 1));
                g_free(destfile);
                dest->last_num++;
        }
@@ -447,7 +451,7 @@ static gint mh_copy_msg(Folder *folder, FolderItem *dest, MsgInfo *msginfo)
 {
        GSList msglist;
 
-       g_return_val_if_fail(msginfo != NULL, -1);
+       cm_return_val_if_fail(msginfo != NULL, -1);
 
        msglist.data = msginfo;
        msglist.next = NULL;
@@ -456,26 +460,28 @@ static gint mh_copy_msg(Folder *folder, FolderItem *dest, MsgInfo *msginfo)
 }
 
 static gint mh_copy_msgs(Folder *folder, FolderItem *dest, MsgInfoList *msglist, 
-                        GRelation *relation)
+                        GHashTable *relation)
 {
        gboolean dest_need_scan = FALSE;
+       gboolean src_need_scan = FALSE;
+       FolderItem *src = NULL;
        gchar *srcfile;
        gchar *destfile;
-       gint filemode = 0;
        FolderItemPrefs *prefs;
        MsgInfo *msginfo = NULL;
        MsgInfoList *cur = NULL;
        gint curnum = 0, total = 0;
        gchar *srcpath = NULL;
        gboolean full_fetch = FALSE;
-       time_t last_mtime = (time_t)0;
+       time_t last_dest_mtime = (time_t)0;
+       time_t last_src_mtime = (time_t)0;
 
-       g_return_val_if_fail(dest != NULL, -1);
-       g_return_val_if_fail(msglist != NULL, -1);
+       cm_return_val_if_fail(dest != NULL, -1);
+       cm_return_val_if_fail(msglist != NULL, -1);
        
        msginfo = (MsgInfo *)msglist->data;
 
-       g_return_val_if_fail(msginfo != NULL, -1);
+       cm_return_val_if_fail(msginfo != NULL, -1);
 
        if (msginfo->folder == dest) {
                g_warning("the src folder is identical to the dest.\n");
@@ -484,6 +490,10 @@ static gint mh_copy_msgs(Folder *folder, FolderItem *dest, MsgInfoList *msglist,
 
        if (msginfo->folder->folder != dest->folder)
                full_fetch = TRUE;
+       
+       if (FOLDER_TYPE(msginfo->folder->folder) == F_MH) {
+               src = msginfo->folder;
+       }
 
        if (dest->last_num < 0) {
                mh_get_last_num(folder, dest);
@@ -495,7 +505,12 @@ static gint mh_copy_msgs(Folder *folder, FolderItem *dest, MsgInfoList *msglist,
        srcpath = folder_item_get_path(msginfo->folder);
 
        dest_need_scan = mh_scan_required(dest->folder, dest);
-       last_mtime = dest->mtime;
+       last_dest_mtime = dest->mtime;
+
+       if (src) {
+               src_need_scan = mh_scan_required(src->folder, src);
+               last_src_mtime = src->mtime;
+       }
 
        total = g_slist_length(msglist);
        if (total > 100) {
@@ -560,14 +575,13 @@ static gint mh_copy_msgs(Folder *folder, FolderItem *dest, MsgInfoList *msglist,
                if (prefs && prefs->enable_folder_chmod && prefs->folder_chmod) {
                        if (chmod(destfile, prefs->folder_chmod) < 0)
                                FILE_OP_ERROR(destfile, "chmod");
-
-                       /* for mark file */
-                       filemode = prefs->folder_chmod;
-                       if (filemode & S_IRGRP) filemode |= S_IWGRP;
-                       if (filemode & S_IROTH) filemode |= S_IWOTH;
                }
-               if (relation)
-                       g_relation_insert(relation, msginfo, GINT_TO_POINTER(dest->last_num+1));
+               if (relation) {
+                       if (g_hash_table_lookup(relation, msginfo) != NULL)
+                               g_warning("already in : %p", msginfo);
+                       
+                       g_hash_table_insert(relation, msginfo, GINT_TO_POINTER(dest->last_num+1));
+               }
                g_free(srcfile);
                g_free(destfile);
                dest->last_num++;
@@ -576,10 +590,14 @@ static gint mh_copy_msgs(Folder *folder, FolderItem *dest, MsgInfoList *msglist,
        g_free(srcpath);
        mh_write_sequences(dest, TRUE);
 
-       if (dest->mtime == last_mtime && !dest_need_scan) {
-               dest->mtime = time(NULL);
-               debug_print("MH: forced mtime of %s to %ld\n", dest->name, dest->mtime);
+       if (dest->mtime == last_dest_mtime && !dest_need_scan) {
+               mh_set_mtime(folder, dest);
        }
+
+       if (src && src->mtime == last_src_mtime && !src_need_scan) {
+               mh_set_mtime(folder, src);
+       }
+
        if (total > 100) {
                statusbar_progress_all(0,0,0);
                statusbar_pop_all();
@@ -602,30 +620,29 @@ static gint mh_remove_msg(Folder *folder, FolderItem *item, gint num)
        time_t last_mtime = (time_t)0;
        gchar *file;
 
-       g_return_val_if_fail(item != NULL, -1);
+       cm_return_val_if_fail(item != NULL, -1);
 
        file = mh_fetch_msg(folder, item, num);
-       g_return_val_if_fail(file != NULL, -1);
+       cm_return_val_if_fail(file != NULL, -1);
 
        need_scan = mh_scan_required(folder, item);
        last_mtime = item->mtime;
 
-       if (g_unlink(file) < 0) {
+       if (claws_unlink(file) < 0) {
                FILE_OP_ERROR(file, "unlink");
                g_free(file);
                return -1;
        }
 
        if (item->mtime == last_mtime && !need_scan) {
-               item->mtime = time(NULL);
-               debug_print("MH: forced mtime of %s to %ld\n", item->name, item->mtime);
+               mh_set_mtime(folder, item);
        }
        g_free(file);
        return 0;
 }
 
 static gint mh_remove_msgs(Folder *folder, FolderItem *item, 
-                   MsgInfoList *msglist, GRelation *relation)
+                   MsgInfoList *msglist, GHashTable *relation)
 {
        gboolean need_scan = FALSE;
        gchar *path, *file;
@@ -633,7 +650,7 @@ static gint mh_remove_msgs(Folder *folder, FolderItem *item,
        MsgInfoList *cur;
        gint total = 0, curnum = 0;
 
-       g_return_val_if_fail(item != NULL, -1);
+       cm_return_val_if_fail(item != NULL, -1);
 
        path = folder_item_get_path(item);
        
@@ -664,7 +681,7 @@ static gint mh_remove_msgs(Folder *folder, FolderItem *item,
                if (file == NULL)
                        continue;
                
-               if (g_unlink(file) < 0) {
+               if (claws_unlink(file) < 0) {
                        g_free(file);
                        continue;
                }
@@ -677,8 +694,7 @@ static gint mh_remove_msgs(Folder *folder, FolderItem *item,
                statusbar_pop_all();
        }
        if (item->mtime == last_mtime && !need_scan) {
-               item->mtime = time(NULL);
-               debug_print("MH: forced mtime of %s to %ld\n", item->name, item->mtime);
+               mh_set_mtime(folder, item);
        }
 
        g_free(path);
@@ -690,10 +706,10 @@ static gint mh_remove_all_msg(Folder *folder, FolderItem *item)
        gchar *path;
        gint val;
 
-       g_return_val_if_fail(item != NULL, -1);
+       cm_return_val_if_fail(item != NULL, -1);
 
        path = folder_item_get_path(item);
-       g_return_val_if_fail(path != NULL, -1);
+       cm_return_val_if_fail(path != NULL, -1);
        val = remove_all_numbered_files(path);
        g_free(path);
 
@@ -722,7 +738,7 @@ static gint mh_scan_tree(Folder *folder)
        FolderItem *item;
        gchar *rootpath;
 
-       g_return_val_if_fail(folder != NULL, -1);
+       cm_return_val_if_fail(folder != NULL, -1);
 
        if (!folder->node) {
                item = folder_item_new(folder, folder->name, NULL);
@@ -753,26 +769,57 @@ static gint mh_scan_tree(Folder *folder)
                                    "Can't create folder.", dir); \
                        return -1; \
                } \
-               if (make_dir(dir) < 0) \
+               if (make_dir_hier(dir) < 0) \
                        return -1; \
        } \
 }
 
 static gint mh_create_tree(Folder *folder)
 {
-       gchar *rootpath;
+       gchar *rootpath, *f;
 
-       g_return_val_if_fail(folder != NULL, -1);
+       cm_return_val_if_fail(folder != NULL, -1);
 
        CHDIR_RETURN_VAL_IF_FAIL(get_mail_base_dir(), -1);
        rootpath = LOCAL_FOLDER(folder)->rootpath;
        MAKE_DIR_IF_NOT_EXIST(rootpath);
        CHDIR_RETURN_VAL_IF_FAIL(rootpath, -1);
-       MAKE_DIR_IF_NOT_EXIST(INBOX_DIR);
-       MAKE_DIR_IF_NOT_EXIST(OUTBOX_DIR);
-       MAKE_DIR_IF_NOT_EXIST(QUEUE_DIR);
-       MAKE_DIR_IF_NOT_EXIST(DRAFT_DIR);
-       MAKE_DIR_IF_NOT_EXIST(TRASH_DIR);
+
+       /* Create special directories as needed */
+       if (folder->inbox != NULL &&
+                       folder->inbox->path != NULL)
+               f = folder->inbox->path;
+       else
+               f = INBOX_DIR;
+       MAKE_DIR_IF_NOT_EXIST(f);
+
+       if (folder->outbox != NULL &&
+                       folder->outbox->path != NULL)
+               f = folder->outbox->path;
+       else
+               f = OUTBOX_DIR;
+       MAKE_DIR_IF_NOT_EXIST(f);
+
+       if (folder->draft != NULL &&
+                       folder->draft->path != NULL)
+               f = folder->draft->path;
+       else
+               f = DRAFT_DIR;
+       MAKE_DIR_IF_NOT_EXIST(f);
+
+       if (folder->queue != NULL &&
+                       folder->queue->path != NULL)
+               f = folder->queue->path;
+       else
+               f = QUEUE_DIR;
+       MAKE_DIR_IF_NOT_EXIST(f);
+
+       if (folder->trash != NULL &&
+                       folder->trash->path != NULL)
+               f = folder->trash->path;
+       else
+               f = TRASH_DIR;
+       MAKE_DIR_IF_NOT_EXIST(f);
 
        return 0;
 }
@@ -783,11 +830,11 @@ static gchar *mh_item_get_path(Folder *folder, FolderItem *item)
 {
        gchar *folder_path, *path;
        gchar *real_path;
-       g_return_val_if_fail(folder != NULL, NULL);
-       g_return_val_if_fail(item != NULL, NULL);
+       cm_return_val_if_fail(folder != NULL, NULL);
+       cm_return_val_if_fail(item != NULL, NULL);
 
        folder_path = g_strdup(LOCAL_FOLDER(folder)->rootpath);
-       g_return_val_if_fail(folder_path != NULL, NULL);
+       cm_return_val_if_fail(folder_path != NULL, NULL);
 
         /* FIXME: [W32] The code below does not correctly merge
            relative filenames; there should be a function to handle
@@ -812,8 +859,8 @@ static gchar *mh_item_get_path(Folder *folder, FolderItem *item)
        if (!is_dir_exist(real_path) && is_dir_exist(path)) {
                /* mmh, older version did put utf8 filenames instead of
                 * the correct encoding */
-               rename(path, real_path);
-               folder_item_scan(item);
+               if (g_rename(path, real_path) == 0)
+                       folder_item_scan(item);
        }
 
        g_free(path);
@@ -829,9 +876,9 @@ static FolderItem *mh_create_folder(Folder *folder, FolderItem *parent,
        gchar *mh_sequences_filename;
        FILE *mh_sequences_file;
 
-       g_return_val_if_fail(folder != NULL, NULL);
-       g_return_val_if_fail(parent != NULL, NULL);
-       g_return_val_if_fail(name != NULL, NULL);
+       cm_return_val_if_fail(folder != NULL, NULL);
+       cm_return_val_if_fail(parent != NULL, NULL);
+       cm_return_val_if_fail(name != NULL, NULL);
 
        path = folder_item_get_path(parent);
        if (!is_dir_exist(path)) 
@@ -881,10 +928,10 @@ static gint mh_rename_folder(Folder *folder, FolderItem *item,
        gchar *newpath, *utf8newpath;
        gchar *paths[2];
 
-       g_return_val_if_fail(folder != NULL, -1);
-       g_return_val_if_fail(item != NULL, -1);
-       g_return_val_if_fail(item->path != NULL, -1);
-       g_return_val_if_fail(name != NULL, -1);
+       cm_return_val_if_fail(folder != NULL, -1);
+       cm_return_val_if_fail(item != NULL, -1);
+       cm_return_val_if_fail(item->path != NULL, -1);
+       cm_return_val_if_fail(name != NULL, -1);
 
        oldpath = folder_item_get_path(item);
        if (!is_dir_exist(oldpath))
@@ -930,9 +977,9 @@ static gint mh_remove_folder(Folder *folder, FolderItem *item)
 {
        gchar *path;
 
-       g_return_val_if_fail(folder != NULL, -1);
-       g_return_val_if_fail(item != NULL, -1);
-       g_return_val_if_fail(item->path != NULL, -1);
+       cm_return_val_if_fail(folder != NULL, -1);
+       cm_return_val_if_fail(item != NULL, -1);
+       cm_return_val_if_fail(item->path != NULL, -1);
 
        path = folder_item_get_path(item);
        if (remove_dir_recursive(path) < 0) {
@@ -951,8 +998,8 @@ static MsgInfo *mh_parse_msg(const gchar *file, FolderItem *item)
        MsgInfo *msginfo;
        MsgFlags flags;
 
-       g_return_val_if_fail(item != NULL, NULL);
-       g_return_val_if_fail(file != NULL, NULL);
+       cm_return_val_if_fail(item != NULL, NULL);
+       cm_return_val_if_fail(file != NULL, NULL);
 
        flags.perm_flags = MSG_NEW|MSG_UNREAD;
        flags.tmp_flags = 0;
@@ -977,7 +1024,7 @@ static gboolean mh_remove_missing_folder_items_func(GNode *node, gpointer data)
        FolderItem *item;
        gchar *path;
 
-       g_return_val_if_fail(node->data != NULL, FALSE);
+       cm_return_val_if_fail(node->data != NULL, FALSE);
 
        if (G_NODE_IS_ROOT(node))
                return FALSE;
@@ -986,7 +1033,7 @@ static gboolean mh_remove_missing_folder_items_func(GNode *node, gpointer data)
 
        path = folder_item_get_path(item);
        if (!is_dir_exist(path)) {
-               debug_print("folder '%s' not found. removing...\n", path);
+               debug_print("folder '%s' not found. removing...\n", path?path:"(null)");
                folder_item_remove(item);
        }
        g_free(path);
@@ -996,7 +1043,7 @@ static gboolean mh_remove_missing_folder_items_func(GNode *node, gpointer data)
 
 static void mh_remove_missing_folder_items(Folder *folder)
 {
-       g_return_if_fail(folder != NULL);
+       cm_return_if_fail(folder != NULL);
 
        debug_print("searching missing folders...\n");
 
@@ -1018,8 +1065,8 @@ static void mh_scan_tree_recursive(FolderItem *item)
        gchar *real_path, *entry, *utf8entry, *utf8name;
        gint n_msg = 0;
 
-       g_return_if_fail(item != NULL);
-       g_return_if_fail(item->folder != NULL);
+       cm_return_if_fail(item != NULL);
+       cm_return_if_fail(item->folder != NULL);
 
        folder = item->folder;
 
@@ -1078,10 +1125,13 @@ static void mh_scan_tree_recursive(FolderItem *item)
                        node = item->node;
                        for (node = node->children; node != NULL; node = node->next) {
                                FolderItem *cur_item = FOLDER_ITEM(node->data);
-                               if (!strcmp2(cur_item->path, entry)) {
+                               gchar *curpath = mh_filename_from_utf8(cur_item->path);
+                               if (!strcmp2(curpath, entry)) {
                                        new_item = cur_item;
+                                       g_free(curpath);
                                        break;
                                }
+                               g_free(curpath);
                        }
                        if (!new_item) {
                                debug_print("new folder '%s' found.\n", entry);
@@ -1127,8 +1177,7 @@ static void mh_scan_tree_recursive(FolderItem *item)
        closedir(dp);
 #endif
 
-       item->mtime = time(NULL);
-       debug_print("MH: forced mtime of %s to %ld\n", item->name, item->mtime);
+       mh_set_mtime(folder, item);
 }
 
 static gboolean mh_rename_folder_func(GNode *node, gpointer data)
@@ -1165,7 +1214,7 @@ static gchar *mh_filename_from_utf8(const gchar *path)
        gchar *real_path = g_filename_from_utf8(path, -1, NULL, NULL, NULL);
 
        if (!real_path) {
-               g_warning("mh_filename_from_utf8: faild to convert character set\n");
+               g_warning("mh_filename_from_utf8: failed to convert character set\n");
                real_path = g_strdup(path);
        }
 
@@ -1176,7 +1225,7 @@ static gchar *mh_filename_to_utf8(const gchar *path)
 {
        gchar *utf8path = g_filename_to_utf8(path, -1, NULL, NULL, NULL);
        if (!utf8path) {
-               g_warning("mh_filename_to_utf8: faild to convert character set\n");
+               g_warning("mh_filename_to_utf8: failed to convert character set\n");
                utf8path = g_strdup(path);
        }
 
@@ -1223,114 +1272,15 @@ static gchar *get_unseen_seq_name(void)
        return seq_name;        
 }
 
-#if 0
-static gint mh_get_flags(Folder *folder, FolderItem *item,
-                           MsgInfoList *msginfo_list, GRelation *msgflags)
-{
-       gchar *mh_sequences_filename;
-       FILE *mh_sequences_file;
-       gchar buf[BUFFSIZE];
-       gchar *unseen_list = NULL;
-       gchar *path;
-       MsgInfoList *mcur = NULL;
-/*
-       GTimer *timer = g_timer_new();
-       g_timer_start(timer);
-*/
-       if (!item)
-               return 0;
-
-       /* don't update from .mh_sequences if the item's opened: mails may have
-        * been marked read/unread and it's not yet written in the file. */     
-       if (item->opened)
-               return 0;
-
-       path = folder_item_get_path(item);
-
-       mh_sequences_filename = g_strconcat(path, G_DIR_SEPARATOR_S,
-                                           ".mh_sequences", NULL);
-       g_free(path);
-       if ((mh_sequences_file = g_fopen(mh_sequences_filename, "r+b")) != NULL) {
-               while (fgets(buf, sizeof(buf), mh_sequences_file) != NULL) {
-                       if (!strncmp(buf, get_unseen_seq_name(), strlen(get_unseen_seq_name()))) {
-                               unseen_list = g_strdup(buf+strlen(get_unseen_seq_name()));
-                               break;
-                       }
-               }
-               fclose(mh_sequences_file);
-       }
-       
-       g_free(mh_sequences_filename);
-       
-       if (unseen_list) {
-               gchar *cur = NULL;
-               gchar *token = NULL, *next = NULL, *boundary = NULL;
-               gint num = 0;
-               GHashTable *unseen_table = g_hash_table_new(g_direct_hash, g_direct_equal);
-
-               cur = unseen_list = strretchomp(unseen_list);
-               debug_print("found unseen list in .mh_sequences: %s\n", unseen_list);
-next_token:
-               while (*cur && *cur == ' ')
-                       cur++;
-               
-               if ((next = strchr(cur, ' ')) != NULL) {
-                       token = cur;
-                       cur = next+1;
-                       *next = '\0';
-               } else {
-                       token = cur;
-                       cur = NULL;
-               }
-               
-               if ((boundary = strchr(token, '-')) != NULL) {
-                       gchar *start, *end;
-                       int i;
-                       start = token;
-                       end = boundary+1;
-                       *boundary='\0';
-                       for (i = atoi(start); i <= atoi(end); i++) {
-                               g_hash_table_insert(unseen_table, GINT_TO_POINTER(i), GINT_TO_POINTER(1));
-                       }
-               } else if ((num = atoi(token)) > 0) {
-                       g_hash_table_insert(unseen_table, GINT_TO_POINTER(num), GINT_TO_POINTER(1));
-               }
-               
-               if (cur)
-                       goto next_token;
-               for (mcur = msginfo_list; mcur; mcur = mcur->next) {
-                       MsgInfo *msginfo = (MsgInfo *)mcur->data;
-                       MsgPermFlags flags = msginfo->flags.perm_flags;
-                       if (g_hash_table_lookup(unseen_table, GINT_TO_POINTER(msginfo->msgnum))) {
-                               flags |= MSG_UNREAD;
-                       } else if (!(flags & MSG_NEW)) { /* don't mark new msgs as read */
-                               flags &= ~(MSG_UNREAD);
-                       }
-                       if (flags != msginfo->flags.perm_flags)
-                               g_relation_insert(msgflags, msginfo, GINT_TO_POINTER(flags));
-               }
-               g_hash_table_destroy(unseen_table);
-               g_free(unseen_list);
-       }
-/*
-       g_timer_stop(timer);
-       printf("mh_get_flags: %f secs\n", g_timer_elapsed(timer, NULL));
-       g_timer_destroy(timer);
-*/
-       return 0;
-}
-#endif
-
 static void mh_write_sequences(FolderItem *item, gboolean remove_unseen)
 {
        gchar *mh_sequences_old, *mh_sequences_new;
        FILE *mh_sequences_old_fp, *mh_sequences_new_fp;
        gchar buf[BUFFSIZE];
        gchar *path = NULL;
-/*
-       GTimer *timer = g_timer_new();
-       g_timer_start(timer);
-*/
+       gboolean err = FALSE;
+       START_TIMING("");
+
        if (!item)
                return;
        
@@ -1377,34 +1327,45 @@ static void mh_write_sequences(FolderItem *item, gboolean remove_unseen)
                        }
                        cur = cur ? cur->next:NULL;
                } while (cur || (start > 0 && end > 0));
-               if (sequence && strlen(sequence)) {
-                       fprintf(mh_sequences_new_fp, "%s%s\n", 
-                                       get_unseen_seq_name(), sequence);
-                       debug_print("wrote unseen sequence: '%s%s'\n", 
+               if (sequence && *sequence) {
+                       if (fprintf(mh_sequences_new_fp, "%s%s\n", 
+                                       get_unseen_seq_name(), sequence) < 0)
+                               err = TRUE;
+                       else
+                               debug_print("wrote unseen sequence: '%s%s'\n", 
                                        get_unseen_seq_name(), sequence);
                }
                /* rewrite the rest of the file */
                if ((mh_sequences_old_fp = g_fopen(mh_sequences_old, "r+b")) != NULL) {
                        while (fgets(buf, sizeof(buf), mh_sequences_old_fp) != NULL) {
                                if (strncmp(buf, get_unseen_seq_name(), strlen(get_unseen_seq_name())))
-                                       fprintf(mh_sequences_new_fp, "%s", buf);
+                                       if (fprintf(mh_sequences_new_fp, "%s", buf) < 0) {
+                                               err = TRUE;
+                                               break;
+                                       }
                        }
                        fclose(mh_sequences_old_fp);
                }
                
-               fclose(mh_sequences_new_fp);
-               g_rename(mh_sequences_new, mh_sequences_old);
+               fflush(mh_sequences_new_fp);
+#if 0
+               fsync(fileno(mh_sequences_new_fp));
+#endif
+               if (fclose(mh_sequences_new_fp) == EOF)
+                       err = TRUE;
+
+               if (!err) {
+                       if (g_rename(mh_sequences_new, mh_sequences_old) < 0)
+                               FILE_OP_ERROR(mh_sequences_new, "rename");
+               }
                g_free(sequence);
                procmsg_msg_list_free(msglist);
        }
        g_free(mh_sequences_old);
        g_free(mh_sequences_new);
        g_free(path);
-/*
-       g_timer_stop(timer);
-       printf("mh_get_flags: %f secs\n", g_timer_elapsed(timer, NULL));
-       g_timer_destroy(timer);
-*/
+
+       END_TIMING();
 }
 
 static int mh_item_close(Folder *folder, FolderItem *item)
@@ -1416,9 +1377,26 @@ static int mh_item_close(Folder *folder, FolderItem *item)
        mh_write_sequences(item, FALSE);
 
        if (item->mtime == last_mtime && !need_scan) {
-               item->mtime = time(NULL);
-               debug_print("MH: forced mtime of %s to %ld\n", item->name, item->mtime);
+               mh_set_mtime(folder, item);
        }
 
        return 0;
 }
+
+static void mh_set_mtime(Folder *folder, FolderItem *item)
+{
+       struct stat s;
+       gchar *path = folder_item_get_path(item);
+
+       cm_return_if_fail(path != NULL);
+
+       if (g_stat(path, &s) < 0) {
+               FILE_OP_ERROR(path, "stat");
+               g_free(path);
+               return;
+       }
+
+       item->mtime = s.st_mtime;
+       debug_print("MH: forced mtime of %s to %ld\n", item->name?item->name:"(null)", item->mtime);
+       g_free(path);
+}