Fix a segfault caused by freeing a string on incorrect place.
[claws.git] / src / mh.c
index 3cfa7a0f5b0e43659b4be739c14ab6f366b87e6e..0736e58e08b903a59d76a21e63f4b2ac787f83ea 100644 (file)
--- a/src/mh.c
+++ b/src/mh.c
@@ -1,6 +1,6 @@
 /*
  * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2009 Hiroyuki Yamamoto and the Claws Mail team
+ * Copyright (C) 1999-2013 Hiroyuki Yamamoto and the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -19,6 +19,7 @@
 
 #ifdef HAVE_CONFIG_H
 #  include "config.h"
+#include "claws-features.h"
 #endif
 
 #include "defs.h"
@@ -33,6 +34,7 @@
 #include <time.h>
 
 #include "folder.h"
+#include "folder_item_prefs.h"
 #include "mh.h"
 #include "procmsg.h"
 #include "procheader.h"
@@ -41,6 +43,7 @@
 #include "statusbar.h"
 #include "gtkutils.h"
 #include "timing.h"
+#include "msgcache.h"
 
 /* Define possible missing constants for Windows. */
 #ifdef G_OS_WIN32
@@ -75,21 +78,21 @@ static gint     mh_add_msg          (Folder         *folder,
 static gint     mh_add_msgs            (Folder         *folder,
                                         FolderItem     *dest,
                                         GSList         *file_list,
-                                        GRelation      *relation);
+                                        GHashTable     *relation);
 static gint     mh_copy_msg            (Folder         *folder,
                                         FolderItem     *dest,
                                         MsgInfo        *msginfo);
 static gint    mh_copy_msgs            (Folder         *folder, 
                                         FolderItem     *dest, 
                                         MsgInfoList    *msglist, 
-                                        GRelation      *relation);
+                                        GHashTable     *relation);
 static gint     mh_remove_msg          (Folder         *folder,
                                         FolderItem     *item,
                                         gint            num);
 static gint    mh_remove_msgs          (Folder         *folder, 
                                         FolderItem     *item, 
                                         MsgInfoList    *msglist, 
-                                        GRelation      *relation);
+                                        GHashTable     *relation);
 static gint     mh_remove_all_msg      (Folder         *folder,
                                         FolderItem     *item);
 static gboolean mh_is_msg_changed      (Folder         *folder,
@@ -134,7 +137,7 @@ static int mh_item_close            (Folder         *folder,
                                         FolderItem     *item);
 #if 0
 static gint mh_get_flags               (Folder *folder, FolderItem *item,
-                                        MsgInfoList *msginfo_list, GRelation *msgflags);
+                                        MsgInfoList *msginfo_list, GHashTable *msgflags);
 #endif
 static void mh_write_sequences         (FolderItem     *item, gboolean remove_unseen);
 
@@ -146,6 +149,7 @@ FolderClass *mh_get_class(void)
                mh_class.type = F_MH;
                mh_class.idstr = "mh";
                mh_class.uistr = "MH";
+               mh_class.supports_server_search = FALSE;
                
                /* Folder functions */
                mh_class.new_folder = mh_folder_new;
@@ -173,6 +177,7 @@ FolderClass *mh_get_class(void)
                mh_class.add_msgs = mh_add_msgs;
                mh_class.copy_msg = mh_copy_msg;
                mh_class.copy_msgs = mh_copy_msgs;
+               mh_class.search_msgs = folder_item_search_msgs_local;
                mh_class.remove_msg = mh_remove_msg;
                mh_class.remove_msgs = mh_remove_msgs;
                mh_class.remove_all_msg = mh_remove_all_msg;
@@ -207,7 +212,7 @@ static void mh_folder_init(Folder *folder, const gchar *name, const gchar *path)
 gboolean mh_scan_required(Folder *folder, FolderItem *item)
 {
        gchar *path;
-       struct stat s;
+       GStatBuf s;
 
        path = folder_item_get_path(item);
        cm_return_val_if_fail(path != NULL, FALSE);
@@ -238,9 +243,10 @@ gboolean mh_scan_required(Folder *folder, FolderItem *item)
 
 static void mh_get_last_num(Folder *folder, FolderItem *item)
 {
-       gchar *path;
-       DIR *dp;
-       struct dirent *d;
+       gchar *path, *fullpath;
+       GDir *dp;
+       const gchar *d;
+       GError *error = NULL;
        gint max = 0;
        gint num;
 
@@ -250,27 +256,29 @@ static void mh_get_last_num(Folder *folder, FolderItem *item)
 
        path = folder_item_get_path(item);
        cm_return_if_fail(path != NULL);
-       if (change_dir(path) < 0) {
-               g_free(path);
-               return;
-       }
-       g_free(path);
 
-       if ((dp = opendir(".")) == NULL) {
-               FILE_OP_ERROR(item->path, "opendir");
+       if ((dp = g_dir_open(path, 0, &error)) == NULL) {
+               g_message("Couldn't open current directory: %s (%d).\n",
+                               error->message, error->code);
+               g_error_free(error);
+               g_free(path);
                return;
        }
 
-       while ((d = readdir(dp)) != NULL) {
-               if ((num = to_number(d->d_name)) > 0 &&
-                   dirent_is_regular_file(d)) {
+       while ((d = g_dir_read_name(dp)) != NULL) {
+               fullpath = g_strconcat(path, G_DIR_SEPARATOR_S, d, NULL);
+               if ((num = to_number(d)) > 0 &&
+                   g_file_test(fullpath, G_FILE_TEST_IS_REGULAR)) {
                        if (max < num)
                                max = num;
                }
+               g_free(fullpath);
+
                if (num % 2000 == 0)
                        GTK_EVENTS_FLUSH();
        }
-       closedir(dp);
+       g_dir_close(dp);
+       g_free(path);
 
        debug_print("Last number in dir %s = %d\n", item->path?item->path:"(null)", max);
        item->last_num = max;
@@ -280,8 +288,9 @@ gint mh_get_num_list(Folder *folder, FolderItem *item, GSList **list, gboolean *
 {
 
        gchar *path;
-       DIR *dp;
-       struct dirent *d;
+       GDir *dp;
+       const gchar *d;
+       GError *error = NULL;
        gint num, nummsgs = 0;
 
        cm_return_val_if_fail(item != NULL, -1);
@@ -292,24 +301,23 @@ gint mh_get_num_list(Folder *folder, FolderItem *item, GSList **list, gboolean *
 
        path = folder_item_get_path(item);
        cm_return_val_if_fail(path != NULL, -1);
-       if (change_dir(path) < 0) {
+
+       if ((dp = g_dir_open(path, 0, &error)) == NULL) {
+               g_message("Couldn't open current directory: %s (%d).\n",
+                               error->message, error->code);
+               g_error_free(error);
                g_free(path);
                return -1;
        }
        g_free(path);
 
-       if ((dp = opendir(".")) == NULL) {
-               FILE_OP_ERROR(item->path, "opendir");
-               return -1;
-       }
-
-       while ((d = readdir(dp)) != NULL) {
-               if ((num = to_number(d->d_name)) > 0) {
+       while ((d = g_dir_read_name(dp)) != NULL) {
+               if ((num = to_number(d)) > 0) {
                        *list = g_slist_prepend(*list, GINT_TO_POINTER(num));
                        nummsgs++;
                }
        }
-       closedir(dp);
+       g_dir_close(dp);
 
        mh_set_mtime(folder, item);
        return nummsgs;
@@ -364,6 +372,11 @@ static gchar *mh_get_new_msg_filename(FolderItem *dest)
        destpath = folder_item_get_path(dest);
        cm_return_val_if_fail(destpath != NULL, NULL);
 
+       if (dest->last_num < 0) {
+               mh_get_last_num(dest->folder, dest);
+               if (dest->last_num < 0) return NULL;
+       }
+
        if (!is_dir_exist(destpath))
                make_dir_hier(destpath);
 
@@ -401,7 +414,7 @@ static gint mh_add_msg(Folder *folder, FolderItem *dest, const gchar *file, MsgF
 } 
  
 static gint mh_add_msgs(Folder *folder, FolderItem *dest, GSList *file_list, 
-                 GRelation *relation)
+                 GHashTable *relation)
 { 
        gchar *destfile;
        GSList *cur;
@@ -425,7 +438,7 @@ static gint mh_add_msgs(Folder *folder, FolderItem *dest, GSList *file_list,
                if (link(fileinfo->file, destfile) < 0) {
 #endif
                        if (copy_file(fileinfo->file, destfile, TRUE) < 0) {
-                               g_warning(_("can't copy message %s to %s\n"),
+                               g_warning("can't copy message %s to %s",
                                          fileinfo->file, destfile);
                                g_free(destfile);
                                return -1;
@@ -435,7 +448,7 @@ static gint mh_add_msgs(Folder *folder, FolderItem *dest, GSList *file_list,
 #endif
 
                if (relation != NULL)
-                       g_relation_insert(relation, fileinfo, GINT_TO_POINTER(dest->last_num + 1));
+                       g_hash_table_insert(relation, fileinfo, GINT_TO_POINTER(dest->last_num + 1));
                g_free(destfile);
                dest->last_num++;
        }
@@ -456,14 +469,13 @@ static gint mh_copy_msg(Folder *folder, FolderItem *dest, MsgInfo *msginfo)
 }
 
 static gint mh_copy_msgs(Folder *folder, FolderItem *dest, MsgInfoList *msglist, 
-                        GRelation *relation)
+                        GHashTable *relation)
 {
        gboolean dest_need_scan = FALSE;
        gboolean src_need_scan = FALSE;
        FolderItem *src = NULL;
        gchar *srcfile;
        gchar *destfile;
-       gint filemode = 0;
        FolderItemPrefs *prefs;
        MsgInfo *msginfo = NULL;
        MsgInfoList *cur = NULL;
@@ -481,7 +493,7 @@ static gint mh_copy_msgs(Folder *folder, FolderItem *dest, MsgInfoList *msglist,
        cm_return_val_if_fail(msginfo != NULL, -1);
 
        if (msginfo->folder == dest) {
-               g_warning("the src folder is identical to the dest.\n");
+               g_warning("the src folder is identical to the dest.");
                return -1;
        }
 
@@ -572,14 +584,13 @@ static gint mh_copy_msgs(Folder *folder, FolderItem *dest, MsgInfoList *msglist,
                if (prefs && prefs->enable_folder_chmod && prefs->folder_chmod) {
                        if (chmod(destfile, prefs->folder_chmod) < 0)
                                FILE_OP_ERROR(destfile, "chmod");
-
-                       /* for mark file */
-                       filemode = prefs->folder_chmod;
-                       if (filemode & S_IRGRP) filemode |= S_IWGRP;
-                       if (filemode & S_IROTH) filemode |= S_IWOTH;
                }
-               if (relation)
-                       g_relation_insert(relation, msginfo, GINT_TO_POINTER(dest->last_num+1));
+               if (relation) {
+                       if (g_hash_table_lookup(relation, msginfo) != NULL)
+                               g_warning("already in: %p", msginfo);
+                       
+                       g_hash_table_insert(relation, msginfo, GINT_TO_POINTER(dest->last_num+1));
+               }
                g_free(srcfile);
                g_free(destfile);
                dest->last_num++;
@@ -640,7 +651,7 @@ static gint mh_remove_msg(Folder *folder, FolderItem *item, gint num)
 }
 
 static gint mh_remove_msgs(Folder *folder, FolderItem *item, 
-                   MsgInfoList *msglist, GRelation *relation)
+                   MsgInfoList *msglist, GHashTable *relation)
 {
        gboolean need_scan = FALSE;
        gchar *path, *file;
@@ -719,22 +730,27 @@ static gint mh_remove_all_msg(Folder *folder, FolderItem *item)
 static gboolean mh_is_msg_changed(Folder *folder, FolderItem *item,
                                  MsgInfo *msginfo)
 {
-       struct stat s;
+       GStatBuf s;
+       gchar *path;
 
-       if (g_stat(itos(msginfo->msgnum), &s) < 0 ||
+       path = g_strdup_printf("%s%c%d", folder_item_get_path(item),
+                       G_DIR_SEPARATOR, msginfo->msgnum);
+       if (g_stat((path), &s) < 0 ||
            msginfo->size  != s.st_size || (
                (msginfo->mtime - s.st_mtime != 0) &&
                (msginfo->mtime - s.st_mtime != 3600) &&
-               (msginfo->mtime - s.st_mtime != -3600)))
+               (msginfo->mtime - s.st_mtime != -3600))) {
+               g_free(path);
                return TRUE;
+       }
 
+       g_free(path);
        return FALSE;
 }
 
 static gint mh_scan_tree(Folder *folder)
 {
        FolderItem *item;
-       gchar *rootpath;
 
        cm_return_val_if_fail(folder != NULL, -1);
 
@@ -745,13 +761,6 @@ static gint mh_scan_tree(Folder *folder)
        } else
                item = FOLDER_ITEM(folder->node->data);
 
-       rootpath = folder_item_get_path(item);
-       if (change_dir(rootpath) < 0) {
-               g_free(rootpath);
-               return -1;
-       }
-       g_free(rootpath);
-
        mh_create_tree(folder);
        mh_remove_missing_folder_items(folder);
        mh_scan_tree_recursive(item);
@@ -763,31 +772,85 @@ static gint mh_scan_tree(Folder *folder)
 { \
        if (!is_dir_exist(dir)) { \
                if (is_file_exist(dir)) { \
-                       g_warning("File `%s' already exists.\n" \
+                       g_warning("File '%s' already exists. " \
                                    "Can't create folder.", dir); \
                        return -1; \
                } \
                if (make_dir_hier(dir) < 0) \
                        return -1; \
+               debug_print("Created dir '%s'\n", dir); \
        } \
 }
 
 static gint mh_create_tree(Folder *folder)
 {
-       gchar *rootpath;
+       gchar *rootpath, *f, *path;
 
        cm_return_val_if_fail(folder != NULL, -1);
 
-       CHDIR_RETURN_VAL_IF_FAIL(get_mail_base_dir(), -1);
        rootpath = LOCAL_FOLDER(folder)->rootpath;
+#ifdef G_OS_UNIX
+       if (*rootpath == '/') {
+#elif G_OS_WIN32
+       if (g_ascii_isalpha(*rootpath) && !strncmp(rootpath + 1, "\:", 2)) {
+#endif
+               /* Folder path is absolute. */
+               rootpath = g_strdup(rootpath);
+       } else {
+               /* Folder path is relative, using mail base dir. */
+               rootpath = g_strconcat(get_mail_base_dir(), G_DIR_SEPARATOR_S,
+                               rootpath, NULL);
+       }
+
        MAKE_DIR_IF_NOT_EXIST(rootpath);
-       CHDIR_RETURN_VAL_IF_FAIL(rootpath, -1);
-       MAKE_DIR_IF_NOT_EXIST(INBOX_DIR);
-       MAKE_DIR_IF_NOT_EXIST(OUTBOX_DIR);
-       MAKE_DIR_IF_NOT_EXIST(QUEUE_DIR);
-       MAKE_DIR_IF_NOT_EXIST(DRAFT_DIR);
-       MAKE_DIR_IF_NOT_EXIST(TRASH_DIR);
 
+       /* Create special directories as needed */
+       if (folder->inbox != NULL &&
+                       folder->inbox->path != NULL)
+               f = folder->inbox->path;
+       else
+               f = INBOX_DIR;
+       path = g_strconcat(rootpath, G_DIR_SEPARATOR_S, f, NULL);
+       MAKE_DIR_IF_NOT_EXIST(path);
+       g_free(path);
+
+       if (folder->outbox != NULL &&
+                       folder->outbox->path != NULL)
+               f = folder->outbox->path;
+       else
+               f = OUTBOX_DIR;
+       path = g_strconcat(rootpath, G_DIR_SEPARATOR_S, f, NULL);
+       MAKE_DIR_IF_NOT_EXIST(path);
+       g_free(path);
+
+       if (folder->draft != NULL &&
+                       folder->draft->path != NULL)
+               f = folder->draft->path;
+       else
+               f = DRAFT_DIR;
+       path = g_strconcat(rootpath, G_DIR_SEPARATOR_S, f, NULL);
+       MAKE_DIR_IF_NOT_EXIST(path);
+       g_free(path);
+
+       if (folder->queue != NULL &&
+                       folder->queue->path != NULL)
+               f = folder->queue->path;
+       else
+               f = QUEUE_DIR;
+       path = g_strconcat(rootpath, G_DIR_SEPARATOR_S, f, NULL);
+       MAKE_DIR_IF_NOT_EXIST(path);
+       g_free(path);
+
+       if (folder->trash != NULL &&
+                       folder->trash->path != NULL)
+               f = folder->trash->path;
+       else
+               f = TRASH_DIR;
+       path = g_strconcat(rootpath, G_DIR_SEPARATOR_S, f, NULL);
+       MAKE_DIR_IF_NOT_EXIST(path);
+       g_free(path);
+
+       g_free(rootpath);
        return 0;
 }
 
@@ -826,14 +889,38 @@ static gchar *mh_item_get_path(Folder *folder, FolderItem *item)
        if (!is_dir_exist(real_path) && is_dir_exist(path)) {
                /* mmh, older version did put utf8 filenames instead of
                 * the correct encoding */
-               g_rename(path, real_path);
-               folder_item_scan(item);
+               if (g_rename(path, real_path) == 0)
+                       folder_item_scan(item);
        }
 
        g_free(path);
        return real_path;
 }
 
+static gboolean mh_renumber_msg(MsgInfo *info)
+{
+       gchar *src, *dest;
+       gboolean result = FALSE;
+       guint num;
+       cm_return_val_if_fail(info != NULL, FALSE);
+
+       src = folder_item_fetch_msg(info->folder, info->msgnum);
+       dest = mh_get_new_msg_filename(info->folder);
+       num = info->folder->last_num + 1;
+
+       if (move_file(src, dest, FALSE) == 0) {
+               msgcache_remove_msg(info->folder->cache, info->msgnum);
+               info->msgnum = num;
+               msgcache_add_msg(info->folder->cache, info);
+               result = TRUE;
+       }
+
+       g_free(src);
+       g_free(dest);
+
+       return result;
+}
+
 static FolderItem *mh_create_folder(Folder *folder, FolderItem *parent,
                                    const gchar *name)
 {
@@ -851,12 +938,24 @@ static FolderItem *mh_create_folder(Folder *folder, FolderItem *parent,
        if (!is_dir_exist(path)) 
                if (make_dir_hier(path) != 0)
                        return NULL;
-               
+
        real_name = mh_filename_from_utf8(name);
        fullpath = g_strconcat(path, G_DIR_SEPARATOR_S, real_name, NULL);
        g_free(real_name);
        g_free(path);
 
+       if (to_number(name) > 0) {
+               MsgInfo *info = folder_item_get_msginfo(parent, to_number(name));
+               if (info != NULL) {
+                       gboolean ok = mh_renumber_msg(info);
+                       procmsg_msginfo_free(&info);
+                       if (!ok) {
+                               g_free(fullpath);
+                               return NULL;
+                       }
+               }
+       }
+
        if (make_dir(fullpath) < 0) {
                g_free(fullpath);
                return NULL;
@@ -943,16 +1042,17 @@ static gint mh_rename_folder(Folder *folder, FolderItem *item,
 static gint mh_remove_folder(Folder *folder, FolderItem *item)
 {
        gchar *path;
+       gint ret;
 
        cm_return_val_if_fail(folder != NULL, -1);
        cm_return_val_if_fail(item != NULL, -1);
        cm_return_val_if_fail(item->path != NULL, -1);
 
        path = folder_item_get_path(item);
-       if (remove_dir_recursive(path) < 0) {
-               g_warning("can't remove directory `%s'\n", path);
+       if ((ret = remove_dir_recursive(path)) < 0) {
+               g_warning("can't remove directory '%s'", path);
                g_free(path);
-               return -1;
+               return ret;
        }
 
        g_free(path);
@@ -1021,38 +1121,27 @@ static void mh_remove_missing_folder_items(Folder *folder)
 static void mh_scan_tree_recursive(FolderItem *item)
 {
        Folder *folder;
-#ifdef G_OS_WIN32
        GDir *dir;
-#else
-       DIR *dp;
-       struct dirent *d;
-#endif
        const gchar *dir_name;
-       struct stat s;
-       gchar *real_path, *entry, *utf8entry, *utf8name;
+       gchar *entry, *utf8entry, *utf8name, *path;
        gint n_msg = 0;
+       GError *error = NULL;
 
        cm_return_if_fail(item != NULL);
        cm_return_if_fail(item->folder != NULL);
 
        folder = item->folder;
 
-       real_path = item->path ? mh_filename_from_utf8(item->path) : g_strdup(".");
-#ifdef G_OS_WIN32
-       dir = g_dir_open(real_path, 0, NULL);
+       path = folder_item_get_path(item);
+       debug_print("mh_scan_tree_recursive() opening '%s'\n", path);
+       dir = g_dir_open(path, 0, &error);
        if (!dir) {
-               g_warning("failed to open directory: %s\n", real_path);
-               g_free(real_path);
-               return;
-       }
-#else
-       dp = opendir(real_path);
-       if (!dp) {
-               FILE_OP_ERROR(real_path, "opendir");
+               g_warning("failed to open directory '%s': %s (%d)",
+                               path, error->message, error->code);
+               g_error_free(error);
+               g_free(path);
                return;
        }
-#endif
-       g_free(real_path);
 
        debug_print("scanning %s ...\n",
                    item->path ? item->path
@@ -1060,39 +1149,26 @@ static void mh_scan_tree_recursive(FolderItem *item)
        if (folder->ui_func)
                folder->ui_func(folder, item, folder->ui_func_data);
 
-#ifdef G_OS_WIN32
        while ((dir_name = g_dir_read_name(dir)) != NULL) {
-#else
-       while ((d = readdir(dp)) != NULL) {
-               dir_name = d->d_name;
-#endif
                if (dir_name[0] == '.') continue;
 
+               entry = g_strconcat(path, G_DIR_SEPARATOR_S, dir_name, NULL);
+
                utf8name = mh_filename_to_utf8(dir_name);
                if (item->path)
                        utf8entry = g_strconcat(item->path, G_DIR_SEPARATOR_S,
                                                utf8name, NULL);
                else
                        utf8entry = g_strdup(utf8name);
-               entry = mh_filename_from_utf8(utf8entry);
 
-               if (
-#if !defined(G_OS_WIN32) && !defined(MAEMO) && defined(HAVE_DIRENT_D_TYPE)
-                       d->d_type == DT_DIR ||
-                       (d->d_type == DT_UNKNOWN &&
-#endif
-                       g_stat(entry, &s) == 0 && S_ISDIR(s.st_mode)
-#if !defined(G_OS_WIN32) && !defined(MAEMO) && defined(HAVE_DIRENT_D_TYPE)
-                       )
-#endif
-                  ) {
+               if (g_file_test(entry, G_FILE_TEST_IS_DIR)) {
                        FolderItem *new_item = NULL;
                        GNode *node;
 
                        node = item->node;
                        for (node = node->children; node != NULL; node = node->next) {
                                FolderItem *cur_item = FOLDER_ITEM(node->data);
-                               gchar *curpath = mh_filename_from_utf8(cur_item->path);
+                               gchar *curpath = folder_item_get_path(cur_item);
                                if (!strcmp2(curpath, entry)) {
                                        new_item = cur_item;
                                        g_free(curpath);
@@ -1138,11 +1214,8 @@ static void mh_scan_tree_recursive(FolderItem *item)
                g_free(utf8name);
        }
 
-#ifdef G_OS_WIN32
        g_dir_close(dir);
-#else
-       closedir(dp);
-#endif
+       g_free(path);
 
        mh_set_mtime(folder, item);
 }
@@ -1159,7 +1232,7 @@ static gboolean mh_rename_folder_func(GNode *node, gpointer data)
 
        oldpathlen = strlen(oldpath);
        if (strncmp(oldpath, item->path, oldpathlen) != 0) {
-               g_warning("path doesn't match: %s, %s\n", oldpath, item->path);
+               g_warning("path doesn't match: %s, %s", oldpath, item->path);
                return TRUE;
        }
 
@@ -1181,7 +1254,7 @@ static gchar *mh_filename_from_utf8(const gchar *path)
        gchar *real_path = g_filename_from_utf8(path, -1, NULL, NULL, NULL);
 
        if (!real_path) {
-               g_warning("mh_filename_from_utf8: failed to convert character set\n");
+               g_warning("mh_filename_from_utf8: failed to convert character set");
                real_path = g_strdup(path);
        }
 
@@ -1192,7 +1265,7 @@ static gchar *mh_filename_to_utf8(const gchar *path)
 {
        gchar *utf8path = g_filename_to_utf8(path, -1, NULL, NULL, NULL);
        if (!utf8path) {
-               g_warning("mh_filename_to_utf8: failed to convert character set\n");
+               g_warning("mh_filename_to_utf8: failed to convert character set");
                utf8path = g_strdup(path);
        }
 
@@ -1239,104 +1312,6 @@ static gchar *get_unseen_seq_name(void)
        return seq_name;        
 }
 
-#if 0
-static gint mh_get_flags(Folder *folder, FolderItem *item,
-                           MsgInfoList *msginfo_list, GRelation *msgflags)
-{
-       gchar *mh_sequences_filename;
-       FILE *mh_sequences_file;
-       gchar buf[BUFFSIZE];
-       gchar *unseen_list = NULL;
-       gchar *path;
-       MsgInfoList *mcur = NULL;
-/*
-       GTimer *timer = g_timer_new();
-       g_timer_start(timer);
-*/
-       if (!item)
-               return 0;
-
-       /* don't update from .mh_sequences if the item's opened: mails may have
-        * been marked read/unread and it's not yet written in the file. */     
-       if (item->opened)
-               return 0;
-
-       path = folder_item_get_path(item);
-
-       mh_sequences_filename = g_strconcat(path, G_DIR_SEPARATOR_S,
-                                           ".mh_sequences", NULL);
-       g_free(path);
-       if ((mh_sequences_file = g_fopen(mh_sequences_filename, "r+b")) != NULL) {
-               while (fgets(buf, sizeof(buf), mh_sequences_file) != NULL) {
-                       if (!strncmp(buf, get_unseen_seq_name(), strlen(get_unseen_seq_name()))) {
-                               unseen_list = g_strdup(buf+strlen(get_unseen_seq_name()));
-                               break;
-                       }
-               }
-               fclose(mh_sequences_file);
-       }
-       
-       g_free(mh_sequences_filename);
-       
-       if (unseen_list) {
-               gchar *cur = NULL;
-               gchar *token = NULL, *next = NULL, *boundary = NULL;
-               gint num = 0;
-               GHashTable *unseen_table = g_hash_table_new(g_direct_hash, g_direct_equal);
-
-               cur = unseen_list = strretchomp(unseen_list);
-               debug_print("found unseen list in .mh_sequences: %s\n", unseen_list);
-next_token:
-               while (*cur && *cur == ' ')
-                       cur++;
-               
-               if ((next = strchr(cur, ' ')) != NULL) {
-                       token = cur;
-                       cur = next+1;
-                       *next = '\0';
-               } else {
-                       token = cur;
-                       cur = NULL;
-               }
-               
-               if ((boundary = strchr(token, '-')) != NULL) {
-                       gchar *start, *end;
-                       int i;
-                       start = token;
-                       end = boundary+1;
-                       *boundary='\0';
-                       for (i = atoi(start); i <= atoi(end); i++) {
-                               g_hash_table_insert(unseen_table, GINT_TO_POINTER(i), GINT_TO_POINTER(1));
-                       }
-               } else if ((num = atoi(token)) > 0) {
-                       g_hash_table_insert(unseen_table, GINT_TO_POINTER(num), GINT_TO_POINTER(1));
-               }
-               
-               if (cur)
-                       goto next_token;
-               for (mcur = msginfo_list; mcur; mcur = mcur->next) {
-                       MsgInfo *msginfo = (MsgInfo *)mcur->data;
-                       MsgPermFlags flags = msginfo->flags.perm_flags;
-                       if (g_hash_table_lookup(unseen_table, GINT_TO_POINTER(msginfo->msgnum))) {
-                               flags |= MSG_UNREAD;
-                       } else if (!(flags & MSG_NEW)) { /* don't mark new msgs as read */
-                               flags &= ~(MSG_UNREAD);
-                       }
-                       if (flags != msginfo->flags.perm_flags)
-                               g_relation_insert(msgflags, msginfo, GINT_TO_POINTER(flags));
-               }
-               g_hash_table_destroy(unseen_table);
-               g_free(unseen_list);
-       }
-/*
-       g_timer_stop(timer);
-       g_print("mh_get_flags: %f secs\n", g_timer_elapsed(timer, NULL));
-       g_timer_destroy(timer);
-*/
-       return 0;
-}
-#endif
-
 static void mh_write_sequences(FolderItem *item, gboolean remove_unseen)
 {
        gchar *mh_sequences_old, *mh_sequences_new;
@@ -1419,8 +1394,10 @@ static void mh_write_sequences(FolderItem *item, gboolean remove_unseen)
                if (fclose(mh_sequences_new_fp) == EOF)
                        err = TRUE;
 
-               if (!err)
-                       g_rename(mh_sequences_new, mh_sequences_old);
+               if (!err) {
+                       if (g_rename(mh_sequences_new, mh_sequences_old) < 0)
+                               FILE_OP_ERROR(mh_sequences_new, "rename");
+               }
                g_free(sequence);
                procmsg_msg_list_free(msglist);
        }
@@ -1448,7 +1425,7 @@ static int mh_item_close(Folder *folder, FolderItem *item)
 
 static void mh_set_mtime(Folder *folder, FolderItem *item)
 {
-       struct stat s;
+       GStatBuf s;
        gchar *path = folder_item_get_path(item);
 
        cm_return_if_fail(path != NULL);