2009-09-28 [colin] 3.7.2cvs41
[claws.git] / src / matcher.c
index f10b0159e564477c7acb6b46bf10cb7f3a5cdac5..5626e3d9f296bdb9ec252f2b2bebb6a44a2e89f1 100644 (file)
@@ -4,7 +4,7 @@
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
+ * the Free Software Foundation; either version 3 of the License, or
  * (at your option) any later version.
  *
  * This program is distributed in the hope that it will be useful,
@@ -13,8 +13,8 @@
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ * 
  */
 
 #ifdef HAVE_CONFIG_H
@@ -45,6 +45,7 @@
 #include <ctype.h>
 #include "prefs_common.h"
 #include "log.h"
+#include "tags.h"
 
 /*!
  *\brief       Keyword lookup element
@@ -80,8 +81,14 @@ static const MatchParser matchparser_tab[] = {
        {MATCHCRITERIA_NOT_COLORLABEL, "~colorlabel"},
        {MATCHCRITERIA_IGNORE_THREAD, "ignore_thread"},
        {MATCHCRITERIA_NOT_IGNORE_THREAD, "~ignore_thread"},
+       {MATCHCRITERIA_WATCH_THREAD, "watch_thread"},
+       {MATCHCRITERIA_NOT_WATCH_THREAD, "~watch_thread"},
        {MATCHCRITERIA_SPAM, "spam"},
        {MATCHCRITERIA_NOT_SPAM, "~spam"},
+       {MATCHCRITERIA_HAS_ATTACHMENT, "has_attachment"},
+       {MATCHCRITERIA_HAS_NO_ATTACHMENT, "~has_attachment"},
+       {MATCHCRITERIA_SIGNED, "signed"},
+       {MATCHCRITERIA_NOT_SIGNED, "~signed"},
 
        /* msginfo headers */
        {MATCHCRITERIA_SUBJECT, "subject"},
@@ -94,6 +101,10 @@ static const MatchParser matchparser_tab[] = {
        {MATCHCRITERIA_NOT_CC, "~cc"},
        {MATCHCRITERIA_TO_OR_CC, "to_or_cc"},
        {MATCHCRITERIA_NOT_TO_AND_NOT_CC, "~to_or_cc"},
+       {MATCHCRITERIA_TAG, "tag"},
+       {MATCHCRITERIA_NOT_TAG, "~tag"},
+       {MATCHCRITERIA_TAGGED, "tagged"},
+       {MATCHCRITERIA_NOT_TAGGED, "~tagged"},
        {MATCHCRITERIA_AGE_GREATER, "age_greater"},
        {MATCHCRITERIA_AGE_LOWER, "age_lower"},
        {MATCHCRITERIA_NEWSGROUPS, "newsgroups"},
@@ -155,7 +166,11 @@ static const MatchParser matchparser_tab[] = {
        {MATCHACTION_STOP, "stop"},
        {MATCHACTION_HIDE, "hide"},
        {MATCHACTION_IGNORE, "ignore"},
-       {MATCHACTION_ADD_TO_ADDRESSBOOK, "add_to_addressbook"}
+       {MATCHACTION_WATCH, "watch"},
+       {MATCHACTION_ADD_TO_ADDRESSBOOK, "add_to_addressbook"},
+       {MATCHACTION_SET_TAG, "set_tag"},
+       {MATCHACTION_UNSET_TAG, "unset_tag"},
+       {MATCHACTION_CLEAR_TAGS, "clear_tags"},
 };
 
 enum {
@@ -245,7 +260,44 @@ MatcherProp *matcherprop_new(gint criteria, const gchar *header,
        prop = g_new0(MatcherProp, 1);
        prop->criteria = criteria;
        prop->header = header != NULL ? g_strdup(header) : NULL;
+
        prop->expr = expr != NULL ? g_strdup(expr) : NULL;
+
+       prop->matchtype = matchtype;
+       prop->preg = NULL;
+       prop->value = value;
+       prop->error = 0;
+
+       return prop;
+}
+
+/*!
+ *\brief       Allocate a structure for a filtering / scoring
+ *             "condition" (a matcher structure)
+ *             Same as matcherprop_new, except it doesn't change the expr's 
+ *             case.
+ *
+ *\param       criteria Criteria ID (MATCHCRITERIA_XXXX)
+ *\param       header Header string (if criteria is MATCHCRITERIA_HEADER
+                       or MATCHCRITERIA_FOUND_IN_ADDRESSBOOK)
+ *\param       matchtype Type of action (MATCHTYPE_XXX)
+ *\param       expr String value or expression to check
+ *\param       value Integer value to check
+ *
+ *\return      MatcherProp * Pointer to newly allocated structure
+ */
+MatcherProp *matcherprop_new_create(gint criteria, const gchar *header,
+                             gint matchtype, const gchar *expr,
+                             int value)
+{
+       MatcherProp *prop;
+
+       prop = g_new0(MatcherProp, 1);
+       prop->criteria = criteria;
+       prop->header = header != NULL ? g_strdup(header) : NULL;
+
+       prop->expr = expr != NULL ? g_strdup(expr) : NULL;
+
        prop->matchtype = matchtype;
        prop->preg = NULL;
        prop->value = value;
@@ -303,13 +355,13 @@ static gboolean match_with_addresses_in_addressbook
        gboolean found = FALSE;
        gchar *path = NULL;
 
-       g_return_val_if_fail(address_list != NULL, FALSE);
+       cm_return_val_if_fail(address_list != NULL, FALSE);
 
        debug_print("match_with_addresses_in_addressbook(%d, %s)\n",
-                               g_slist_length(address_list), folderpath);
+                               g_slist_length(address_list), folderpath?folderpath:"(null)");
 
        if (folderpath == NULL ||
-               strcasecmp(folderpath, _("Any")) == 0 ||
+               strcasecmp(folderpath, "Any") == 0 ||
                *folderpath == '\0')
                path = NULL;
        else
@@ -346,7 +398,7 @@ static gboolean match_with_addresses_in_addressbook
                                && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH
                                && !found) {
                        log_print(LOG_DEBUG_FILTERING,
-                                       "address [ %s ] doesn't match\n",
+                                       "address [ %s ] does NOT match\n",
                                        (gchar *)walk->data);
                }
                g_free(walk->data);
@@ -392,22 +444,34 @@ static gboolean match_with_addresses_in_addressbook
  *             matcher structure
  */
 static gboolean matcherprop_string_match(MatcherProp *prop, const gchar *str,
-                                                                               const gchar *debug_context)
+                                        const gchar *debug_context)
 {
        gchar *str1;
-       gchar *str2;
+       gchar *down_expr;
        gboolean ret = FALSE;
-
+       gboolean should_free = FALSE;
        if (str == NULL)
                return FALSE;
 
+       if (prop->matchtype == MATCHTYPE_REGEXPCASE ||
+           prop->matchtype == MATCHTYPE_MATCHCASE) {
+               str1 = g_utf8_casefold(str, -1);
+               down_expr = g_utf8_casefold(prop->expr, -1);
+               should_free = TRUE;
+       } else {
+               str1 = (gchar *)str;
+               down_expr = (gchar *)prop->expr;
+               should_free = FALSE;
+       }
+
        switch (prop->matchtype) {
        case MATCHTYPE_REGEXPCASE:
        case MATCHTYPE_REGEXP:
+#ifndef G_OS_WIN32
                if (!prop->preg && (prop->error == 0)) {
                        prop->preg = g_new0(regex_t, 1);
                        /* if regexp then don't use the escaped string */
-                       if (regcomp(prop->preg, prop->expr,
+                       if (regcomp(prop->preg, down_expr,
                                    REG_NOSUB | REG_EXTENDED
                                    | ((prop->matchtype == MATCHTYPE_REGEXPCASE)
                                    ? REG_ICASE : 0)) != 0) {
@@ -416,10 +480,12 @@ static gboolean matcherprop_string_match(MatcherProp *prop, const gchar *str,
                                prop->preg = NULL;
                        }
                }
-               if (prop->preg == NULL)
-                       return FALSE;
+               if (prop->preg == NULL) {
+                       ret = FALSE;
+                       goto free_strs;
+               }
                
-               if (regexec(prop->preg, str, 0, NULL, 0) == 0)
+               if (regexec(prop->preg, str1, 0, NULL, 0) == 0)
                        ret = TRUE;
                else
                        ret = FALSE;
@@ -432,19 +498,22 @@ static gboolean matcherprop_string_match(MatcherProp *prop, const gchar *str,
                        strretchomp(stripped);
                        if (ret) {
                                log_print(LOG_DEBUG_FILTERING,
-                                               "%s value [ %s ] matches regular expression [ %s ]\n",
-                                               debug_context, stripped, prop->expr);
+                                               "%s value [ %s ] matches regular expression [ %s ] (%s)\n",
+                                               debug_context, stripped, prop->expr,
+                                               prop->matchtype == MATCHTYPE_REGEXP ? _("Case sensitive"):_("Case insensitive"));
                        } else {
                                log_print(LOG_DEBUG_FILTERING,
-                                               "%s value [ %s ] doesn't matches regular expression [ %s ]\n",
-                                               debug_context, stripped, prop->expr);
+                                               "%s value [ %s ] does NOT match regular expression [ %s ] (%s)\n",
+                                               debug_context, stripped, prop->expr,
+                                               prop->matchtype == MATCHTYPE_REGEXP ? _("Case sensitive"):_("Case insensitive"));
                        }
                        g_free(stripped);
                }
                break;
-                       
+#endif                 
+       case MATCHTYPE_MATCHCASE:
        case MATCHTYPE_MATCH:
-               ret = (strstr(str, prop->expr) != NULL);
+               ret = (strstr(str1, down_expr) != NULL);
 
                /* debug output */
                if (debug_filtering_session
@@ -454,48 +523,57 @@ static gboolean matcherprop_string_match(MatcherProp *prop, const gchar *str,
                        strretchomp(stripped);
                        if (ret) {
                                log_print(LOG_DEBUG_FILTERING,
-                                               "%s value [ %s ] contains [ %s ] (case sensitive)\n",
-                                               debug_context, stripped, prop->expr);
+                                               "%s value [ %s ] contains [ %s ] (%s)\n",
+                                               debug_context, stripped, prop->expr,
+                                               prop->matchtype == MATCHTYPE_MATCH ? _("Case sensitive"):_("Case insensitive"));
                        } else {
                                log_print(LOG_DEBUG_FILTERING,
-                                               "%s value [ %s ] doesn't contains [ %s ] (case sensitive)\n",
-                                               debug_context, stripped, prop->expr);
+                                               "%s value [ %s ] does NOT contain [ %s ] (%s)\n",
+                                               debug_context, stripped, prop->expr,
+                                               prop->matchtype == MATCHTYPE_MATCH ? _("Case sensitive"):_("Case insensitive"));
                        }
                        g_free(stripped);
                }
                break;
 
-       /* FIXME: put upper in unesc_str */
-       case MATCHTYPE_MATCHCASE:
-               str2 = alloca(strlen(prop->expr) + 1);
-               strcpy(str2, prop->expr);
-               g_strup(str2);
-               str1 = alloca(strlen(str) + 1);
-               strcpy(str1, str);
-               g_strup(str1);
-               ret = (strstr(str1, str2) != NULL);
+       default:
+               break;
+       }
+       
+free_strs:
+       if (should_free) {
+               g_free(str1);
+               g_free(down_expr);
+       }
+       return ret;
+}
 
-               /* debug output */
-               if (debug_filtering_session
-                               && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
-                       gchar *stripped = g_strdup(str);
+/*!
+ *\brief       Find out if a tag matches a condition
+ *
+ *\param       prop Matcher structure
+ *\param       msginfo message to check
+ *
+ *\return      gboolean TRUE if msginfo matches the condition in the 
+ *             matcher structure
+ */
+static gboolean matcherprop_tag_match(MatcherProp *prop, MsgInfo *msginfo,
+                                        const gchar *debug_context)
+{
+       gboolean ret = FALSE;
+       GSList *cur;
 
-                       strretchomp(stripped);
-                       if (ret) {
-                               log_print(LOG_DEBUG_FILTERING,
-                                               "%s value [ %s ] contains [ %s ] (case insensitive)\n",
-                                               debug_context, stripped, prop->expr);
-                       } else {
-                               log_print(LOG_DEBUG_FILTERING,
-                                               "%s [ %s ] doesn't contains [ %s ] (case insensitive)\n",
-                                               debug_context, stripped, prop->expr);
-                       }
-                       g_free(stripped);
+       if (msginfo == NULL || msginfo->tags == NULL)
+               return FALSE;
+
+       for (cur = msginfo->tags; cur; cur = cur->next) {
+               const gchar *str = tags_get_tag(GPOINTER_TO_INT(cur->data));
+               if (!str)
+                       continue;
+               if (matcherprop_string_match(prop, str, debug_context)) {
+                       ret = TRUE;
+                       break;
                }
-               break;
-               
-       default:
-               break;
        }
        return ret;
 }
@@ -583,7 +661,6 @@ static void *matcher_test_thread(void *data)
        pthread_setcanceltype(PTHREAD_CANCEL_ASYNCHRONOUS, NULL);
 
        result = system(td->cmd);
-       if (result) perror("system");
        td->done = TRUE; /* let the caller thread join() */
        return GINT_TO_POINTER(result);
 }
@@ -605,21 +682,30 @@ static gboolean matcherprop_match_test(const MatcherProp *prop,
        gint retval;
 #ifdef USE_PTHREAD
        pthread_t pt;
+       pthread_attr_t pta;
        thread_data *td = g_new0(thread_data, 1);
        void *res = NULL;
        time_t start_time = time(NULL);
 #endif
 
        file = procmsg_get_message_file(info);
-       if (file == NULL)
+       if (file == NULL) {
+#ifdef USE_PTHREAD
+               g_free(td);
+#endif
                return FALSE;
+       }
        g_free(file);           
 
        cmd = matching_build_command(prop->expr, info);
-       if (cmd == NULL)
+       if (cmd == NULL) {
+#ifdef USE_PTHREAD
+               g_free(td);
+#endif 
                return FALSE;
+}
 
-#if (defined USE_PTHREAD && defined __GLIBC__ && (__GLIBC__ > 2 || (__GLIBC__ == 2 && __GLIBC_MINOR__ >= 3)))
+#ifdef USE_PTHREAD
        /* debug output */
        if (debug_filtering_session
                        && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
@@ -630,11 +716,12 @@ static gboolean matcherprop_match_test(const MatcherProp *prop,
 
        td->cmd = cmd;
        td->done = FALSE;
-       if (pthread_create(&pt, PTHREAD_CREATE_JOINABLE, 
-                       matcher_test_thread, td) != 0)
+       if (pthread_attr_init(&pta) != 0 ||
+           pthread_attr_setdetachstate(&pta, PTHREAD_CREATE_JOINABLE) != 0 ||
+           pthread_create(&pt, &pta, matcher_test_thread, td) != 0)
                retval = system(cmd);
        else {
-               printf("waiting for test thread\n");
+               debug_print("waiting for test thread\n");
                while(!td->done) {
                        /* don't let the interface freeze while waiting */
                        claws_do_idle();
@@ -646,7 +733,7 @@ static gboolean matcherprop_match_test(const MatcherProp *prop,
                }
                pthread_join(pt, &res);
                retval = GPOINTER_TO_INT(res);
-               printf(" test thread returned %d\n", retval);
+               debug_print(" test thread returned %d\n", retval);
        }
        g_free(td);
 #else
@@ -723,6 +810,14 @@ gboolean matcherprop_match(MatcherProp *prop,
                return MSG_IS_SPAM(info->flags);
        case MATCHCRITERIA_NOT_SPAM:
                return !MSG_IS_SPAM(info->flags);
+       case MATCHCRITERIA_HAS_ATTACHMENT:
+               return MSG_IS_WITH_ATTACHMENT(info->flags);
+       case MATCHCRITERIA_HAS_NO_ATTACHMENT:
+               return !MSG_IS_WITH_ATTACHMENT(info->flags);
+       case MATCHCRITERIA_SIGNED:
+               return MSG_IS_SIGNED(info->flags);
+       case MATCHCRITERIA_NOT_SIGNED:
+               return !MSG_IS_SIGNED(info->flags);
        case MATCHCRITERIA_COLORLABEL:
        {
                gint color = MSG_GET_COLORLABEL_VALUE(info->flags);
@@ -737,7 +832,7 @@ gboolean matcherprop_match(MatcherProp *prop,
                                                color, prop->value);
                        } else {
                                log_print(LOG_DEBUG_FILTERING,
-                                               "message color value [ %d ] doesn't matches color value [ %d ]\n",
+                                               "message color value [ %d ] does NOT match color value [ %d ]\n",
                                                color, prop->value);
                        }
                }
@@ -757,7 +852,7 @@ gboolean matcherprop_match(MatcherProp *prop,
                                                color, prop->value);
                        } else {
                                log_print(LOG_DEBUG_FILTERING,
-                                               "message color value [ %d ] doesn't matches color value [ %d ]\n",
+                                               "message color value [ %d ] does NOT match color value [ %d ]\n",
                                                color, prop->value);
                        }
                }
@@ -767,28 +862,91 @@ gboolean matcherprop_match(MatcherProp *prop,
                return MSG_IS_IGNORE_THREAD(info->flags);
        case MATCHCRITERIA_NOT_IGNORE_THREAD:
                return !MSG_IS_IGNORE_THREAD(info->flags);
+       case MATCHCRITERIA_WATCH_THREAD:
+               return MSG_IS_WATCH_THREAD(info->flags);
+       case MATCHCRITERIA_NOT_WATCH_THREAD:
+               return !MSG_IS_WATCH_THREAD(info->flags);
        case MATCHCRITERIA_SUBJECT:
-               return matcherprop_string_match(prop, info->subject, _("subject"));
+               return matcherprop_string_match(prop, info->subject,
+                                               prefs_common_translated_header_name("Subject:"));
        case MATCHCRITERIA_NOT_SUBJECT:
-               return !matcherprop_string_match(prop, info->subject, _("subject"));
+               return !matcherprop_string_match(prop, info->subject,
+                                               prefs_common_translated_header_name("Subject:"));
        case MATCHCRITERIA_FROM:
-               return matcherprop_string_match(prop, info->from, _("From: header"));
        case MATCHCRITERIA_NOT_FROM:
-               return !matcherprop_string_match(prop, info->from, _("From: header"));
+       {
+               gchar *context;
+               gboolean ret;
+
+               context = g_strdup_printf(_("%s header"), prefs_common_translated_header_name("From:"));
+               ret = matcherprop_string_match(prop, info->from, context);
+               g_free(context);
+               return (prop->criteria == MATCHCRITERIA_FROM)? ret : !ret;
+       }
        case MATCHCRITERIA_TO:
-               return matcherprop_string_match(prop, info->to, _("To: header"));
        case MATCHCRITERIA_NOT_TO:
-               return !matcherprop_string_match(prop, info->to, _("To: header"));
+       {
+               gchar *context;
+               gboolean ret;
+
+               context = g_strdup_printf(_("%s header"), prefs_common_translated_header_name("To:"));
+               ret = matcherprop_string_match(prop, info->to, context);
+               g_free(context);
+               return (prop->criteria == MATCHCRITERIA_TO)? ret : !ret;
+       }
        case MATCHCRITERIA_CC:
-               return matcherprop_string_match(prop, info->cc, _("Cc: header"));
        case MATCHCRITERIA_NOT_CC:
-               return !matcherprop_string_match(prop, info->cc, _("Cc: header"));
+       {
+               gchar *context;
+               gboolean ret;
+
+               context = g_strdup_printf(_("%s header"), prefs_common_translated_header_name("Cc:"));
+               ret = matcherprop_string_match(prop, info->cc, context);
+               g_free(context);
+               return (prop->criteria == MATCHCRITERIA_CC)? ret : !ret;
+       }
        case MATCHCRITERIA_TO_OR_CC:
-               return matcherprop_string_match(prop, info->to, _("To: header"))
-                       || matcherprop_string_match(prop, info->cc, _("Cc: header"));
+       {
+               gchar *context1, *context2;
+               gboolean ret;
+
+               context1 = g_strdup_printf(_("%s header"), prefs_common_translated_header_name("To:"));
+               context2 = g_strdup_printf(_("%s header"), prefs_common_translated_header_name("Cc:"));
+               ret = matcherprop_string_match(prop, info->to, context1)
+                       || matcherprop_string_match(prop, info->cc, context2);
+               g_free(context1);
+               g_free(context2);
+               return ret;
+       }
        case MATCHCRITERIA_NOT_TO_AND_NOT_CC:
-               return !(matcherprop_string_match(prop, info->to, _("To:"))
-               || matcherprop_string_match(prop, info->cc, _("Cc:")));
+       {
+               gchar *context1, *context2;
+               gboolean ret;
+
+               context1 = g_strdup_printf(_("%s header"), prefs_common_translated_header_name("To:"));
+               context2 = g_strdup_printf(_("%s header"), prefs_common_translated_header_name("Cc:"));
+               ret = !(matcherprop_string_match(prop, info->to, context1)
+                       || matcherprop_string_match(prop, info->cc, context2));
+               g_free(context1);
+               g_free(context2);
+               return ret;
+       }
+       case MATCHCRITERIA_TAG:
+       case MATCHCRITERIA_NOT_TAG:
+       {
+               gboolean ret;
+
+               ret = matcherprop_tag_match(prop, info, _("Tag"));
+               return (prop->criteria == MATCHCRITERIA_TAG)? ret : !ret;
+       }
+       case MATCHCRITERIA_TAGGED:
+       case MATCHCRITERIA_NOT_TAGGED:
+       {
+               gboolean ret;
+
+               ret = (info->tags != NULL);
+               return (prop->criteria == MATCHCRITERIA_TAGGED)? ret : !ret;
+       }
        case MATCHCRITERIA_AGE_GREATER:
        {
                gboolean ret;
@@ -896,76 +1054,76 @@ gboolean matcherprop_match(MatcherProp *prop,
        }
        case MATCHCRITERIA_SIZE_GREATER:
        {
-               /* FIXME: info->size is an off_t */
-               gboolean ret = (info->size > (off_t) prop->value);
+               /* FIXME: info->size is a goffset */
+               gboolean ret = (info->size > (goffset) prop->value);
 
                /* debug output */
                if (debug_filtering_session
                                && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
                        if (ret) {
                                log_print(LOG_DEBUG_FILTERING,
-                                               "message size [ %ld ] is greater than [ %d ]\n",
-                                               info->size, prop->value);
+                                               "message size is greater than [ %d ]\n",
+                                               prop->value);
                        } else {
                                log_print(LOG_DEBUG_FILTERING,
-                                               "message size [ %ld ] is not greater than [ %d ]\n",
-                                               info->size, prop->value);
+                                               "message size is not greater than [ %d ]\n",
+                                               prop->value);
                        }
                }
                return ret;
        }
        case MATCHCRITERIA_SIZE_SMALLER:
        {
-               /* FIXME: info->size is an off_t */
-               gboolean ret = (info->size < (off_t) prop->value);
+               /* FIXME: info->size is a goffset */
+               gboolean ret = (info->size < (goffset) prop->value);
 
                /* debug output */
                if (debug_filtering_session
                                && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
                        if (ret) {
                                log_print(LOG_DEBUG_FILTERING,
-                                               "message size [ %ld ] is smaller than [ %d ]\n",
-                                               info->size, prop->value);
+                                               "message size is smaller than [ %d ]\n",
+                                               prop->value);
                        } else {
                                log_print(LOG_DEBUG_FILTERING,
-                                               "message size [ %ld ] is not smaller than [ %d ]\n",
-                                               info->size, prop->value);
+                                               "message size is not smaller than [ %d ]\n",
+                                               prop->value);
                        }
                }
                return ret;
        }
        case MATCHCRITERIA_SIZE_EQUAL:
        {
-               /* FIXME: info->size is an off_t */
-               gboolean ret = (info->size == (off_t) prop->value);
+               /* FIXME: info->size is a goffset */
+               gboolean ret = (info->size == (goffset) prop->value);
 
                /* debug output */
                if (debug_filtering_session
                                && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
                        if (ret) {
                                log_print(LOG_DEBUG_FILTERING,
-                                               "message size [ %ld ] is equal to [ %d ]\n",
-                                               info->size, prop->value);
+                                               "message size is equal to [ %d ]\n",
+                                               prop->value);
                        } else {
                                log_print(LOG_DEBUG_FILTERING,
-                                               "message size [ %ld ] is not equal to [ %d ]\n",
-                                               info->size, prop->value);
+                                               "message size is not equal to [ %d ]\n",
+                                               prop->value);
                        }
                }
                return ret;
        }
        case MATCHCRITERIA_PARTIAL:
        {
-               /* FIXME: info->size is an off_t */
-               gboolean ret = (info->total_size != 0 && info->size != (off_t)info->total_size);
+               /* FIXME: info->size is a goffset */
+               gboolean ret = (info->total_size != 0 && info->size != (goffset)info->total_size);
 
                /* debug output */
                if (debug_filtering_session
                                && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
                        if (ret) {
                                log_print(LOG_DEBUG_FILTERING,
-                                               "message is partially downloaded, size [ %ld ] is less than total size [ %d ])\n",
-                                               info->size, info->total_size);
+                                               "message is partially downloaded, size is less than total size [ %d ])\n",
+                                               info->total_size);
                        } else {
                                log_print(LOG_DEBUG_FILTERING,
                                                "message is not partially downloaded\n");
@@ -975,8 +1133,8 @@ gboolean matcherprop_match(MatcherProp *prop,
        }
        case MATCHCRITERIA_NOT_PARTIAL:
        {
-               /* FIXME: info->size is an off_t */
-               gboolean ret = (info->total_size == 0 || info->size == (off_t)info->total_size);
+               /* FIXME: info->size is a goffset */
+               gboolean ret = (info->total_size == 0 || info->size == (goffset)info->total_size);
 
                /* debug output */
                if (debug_filtering_session
@@ -986,24 +1144,48 @@ gboolean matcherprop_match(MatcherProp *prop,
                                                "message is not partially downloaded\n");
                        } else {
                                log_print(LOG_DEBUG_FILTERING,
-                                               "message is partially downloaded, size [ %ld ] is less than total size [ %d ])\n",
-                                               info->size, info->total_size);
+                                               "message is partially downloaded, size is less than total size [ %d ])\n",
+                                               info->total_size);
                        }
                }
                return ret;
        }
        case MATCHCRITERIA_NEWSGROUPS:
-               return matcherprop_string_match(prop, info->newsgroups, _("Newsgroups: header"));
        case MATCHCRITERIA_NOT_NEWSGROUPS:
-               return !matcherprop_string_match(prop, info->newsgroups, _("Newsgroups: header"));
+       {
+               gchar *context;
+               gboolean ret;
+
+               context = g_strdup_printf(_("%s header"),
+                                               prefs_common_translated_header_name("Newsgroups:"));
+               ret = matcherprop_string_match(prop, info->newsgroups, context);
+               g_free(context);
+               return (prop->criteria == MATCHCRITERIA_NEWSGROUPS)? ret : !ret;
+       }
        case MATCHCRITERIA_INREPLYTO:
-               return matcherprop_string_match(prop, info->inreplyto, _("InReplyTo: header"));
        case MATCHCRITERIA_NOT_INREPLYTO:
-               return !matcherprop_string_match(prop, info->inreplyto, _("InReplyTo: header"));
+       {
+               gchar *context;
+               gboolean ret;
+
+               context = g_strdup_printf(_("%s header"),
+                                               prefs_common_translated_header_name("In-Reply-To:"));
+               ret = matcherprop_string_match(prop, info->inreplyto, context);
+               g_free(context);
+               return (prop->criteria == MATCHCRITERIA_INREPLYTO)? ret : !ret;
+       }
        case MATCHCRITERIA_REFERENCES:
-               return matcherprop_list_match(prop, info->references, _("References: header"));
        case MATCHCRITERIA_NOT_REFERENCES:
-               return !matcherprop_list_match(prop, info->references, _("References: header"));
+       {
+               gchar *context;
+               gboolean ret;
+
+               context = g_strdup_printf(_("%s header"),
+                                               prefs_common_translated_header_name("References:"));
+               ret = matcherprop_list_match(prop, info->references, context);
+               g_free(context);
+               return (prop->criteria == MATCHCRITERIA_REFERENCES)? ret : !ret;
+       }
        case MATCHCRITERIA_TEST:
                return matcherprop_match_test(prop, info);
        case MATCHCRITERIA_NOT_TEST:
@@ -1044,10 +1226,11 @@ void matcherlist_free(MatcherList *cond)
 {
        GSList *l;
 
-       g_return_if_fail(cond);
+       cm_return_if_fail(cond);
        for (l = cond->matchers ; l != NULL ; l = g_slist_next(l)) {
                matcherprop_free((MatcherProp *) l->data);
        }
+       g_slist_free(cond->matchers);
        g_free(cond);
 }
 
@@ -1113,9 +1296,9 @@ static gboolean matcherprop_match_one_header(MatcherProp *matcher,
                        gboolean found = FALSE;
 
                        /* how many address headers are me trying to mach? */
-                       if (strcasecmp(matcher->header, _("Any")) == 0)
+                       if (strcasecmp(matcher->header, "Any") == 0)
                                match = MATCH_ANY;
-                       else if (strcasecmp(matcher->header, Q_("Filtering Matcher Menu|All")) == 0)
+                       else if (strcasecmp(matcher->header, "All") == 0)
                                        match = MATCH_ALL;
 
                        if (match == MATCH_ONE) {
@@ -1246,9 +1429,9 @@ static gboolean matcherlist_match_headers(MatcherList *matchers, FILE *fp)
                                         procheader_headername_equal(header->name, "Reply-To") ||
                                         procheader_headername_equal(header->name, "Sender"))) {
 
-                                       if (strcasecmp(matcher->header, _("Any")) == 0)
+                                       if (strcasecmp(matcher->header, "Any") == 0)
                                                match = MATCH_ANY;
-                                       else if (strcasecmp(matcher->header, Q_("Filtering Matcher Menu|All")) == 0)
+                                       else if (strcasecmp(matcher->header, "All") == 0)
                                                match = MATCH_ALL;
                                        else
                                                match = MATCH_ONE;
@@ -1523,10 +1706,16 @@ gboolean matcherlist_match(MatcherList *matchers, MsgInfo *info)
                case MATCHCRITERIA_NOT_LOCKED:
                case MATCHCRITERIA_SPAM:
                case MATCHCRITERIA_NOT_SPAM:
+               case MATCHCRITERIA_HAS_ATTACHMENT:
+               case MATCHCRITERIA_HAS_NO_ATTACHMENT:
+               case MATCHCRITERIA_SIGNED:
+               case MATCHCRITERIA_NOT_SIGNED:
                case MATCHCRITERIA_COLORLABEL:
                case MATCHCRITERIA_NOT_COLORLABEL:
                case MATCHCRITERIA_IGNORE_THREAD:
                case MATCHCRITERIA_NOT_IGNORE_THREAD:
+               case MATCHCRITERIA_WATCH_THREAD:
+               case MATCHCRITERIA_NOT_WATCH_THREAD:
                case MATCHCRITERIA_SUBJECT:
                case MATCHCRITERIA_NOT_SUBJECT:
                case MATCHCRITERIA_FROM:
@@ -1537,6 +1726,10 @@ gboolean matcherlist_match(MatcherList *matchers, MsgInfo *info)
                case MATCHCRITERIA_NOT_CC:
                case MATCHCRITERIA_TO_OR_CC:
                case MATCHCRITERIA_NOT_TO_AND_NOT_CC:
+               case MATCHCRITERIA_TAG:
+               case MATCHCRITERIA_NOT_TAG:
+               case MATCHCRITERIA_TAGGED:
+               case MATCHCRITERIA_NOT_TAGGED:
                case MATCHCRITERIA_AGE_GREATER:
                case MATCHCRITERIA_AGE_LOWER:
                case MATCHCRITERIA_NEWSGROUPS:
@@ -1712,10 +1905,18 @@ gchar *matcherprop_to_string(MatcherProp *matcher)
        case MATCHCRITERIA_NOT_LOCKED:
        case MATCHCRITERIA_SPAM:
        case MATCHCRITERIA_NOT_SPAM:
+       case MATCHCRITERIA_HAS_ATTACHMENT:
+       case MATCHCRITERIA_HAS_NO_ATTACHMENT:
+       case MATCHCRITERIA_SIGNED:
+       case MATCHCRITERIA_NOT_SIGNED:
        case MATCHCRITERIA_PARTIAL:
        case MATCHCRITERIA_NOT_PARTIAL:
        case MATCHCRITERIA_IGNORE_THREAD:
        case MATCHCRITERIA_NOT_IGNORE_THREAD:
+       case MATCHCRITERIA_WATCH_THREAD:
+       case MATCHCRITERIA_NOT_WATCH_THREAD:
+       case MATCHCRITERIA_TAGGED:
+       case MATCHCRITERIA_NOT_TAGGED:
                return g_strdup(criteria_str);
        case MATCHCRITERIA_TEST:
        case MATCHCRITERIA_NOT_TEST:
@@ -1830,9 +2031,9 @@ static void add_str_default(gchar ** dest,
 
 /* matching_build_command() - preferably cmd should be unescaped */
 /*!
- *\brief       Build the command line to execute
+ *\brief       Build the command-line to execute
  *
- *\param       cmd String with command line specifiers
+ *\param       cmd String with command-line specifiers
  *\param       info Message info to use for command
  *
  *\return      gchar * Newly allocated string
@@ -1987,7 +2188,7 @@ gchar *matching_build_command(const gchar *cmd, MsgInfo *info)
  *\param       fp File
  *\param       prefs_filtering List of filtering conditions
  */
-static void prefs_filtering_write(FILE *fp, GSList *prefs_filtering)
+static int prefs_filtering_write(FILE *fp, GSList *prefs_filtering)
 {
        GSList *cur = NULL;
 
@@ -2005,19 +2206,19 @@ static void prefs_filtering_write(FILE *fp, GSList *prefs_filtering)
                if (prop->enabled) {
                        if (fputs("enabled ", fp) == EOF) {
                                FILE_OP_ERROR("filtering config", "fputs");
-                               return;
+                               return -1;
                        }
                } else {
                        if (fputs("disabled ", fp) == EOF) {
                                FILE_OP_ERROR("filtering config", "fputs");
-                               return;
+                               return -1;
                        }
                }
 
                if (fputs("rulename \"", fp) == EOF) {
                        FILE_OP_ERROR("filtering config", "fputs");
                        g_free(filtering_str);
-                       return;
+                       return -1;
                }
                tmp_name = prop->name;
                while (tmp_name && *tmp_name != '\0') {
@@ -2025,14 +2226,14 @@ static void prefs_filtering_write(FILE *fp, GSList *prefs_filtering)
                                if (fputc(*tmp_name, fp) == EOF) {
                                        FILE_OP_ERROR("filtering config", "fputs || fputc");
                                        g_free(filtering_str);
-                                       return;
+                                       return -1;
                                }
                        } else if (*tmp_name == '"') {
                                if (fputc('\\', fp) == EOF ||
                                    fputc('"', fp) == EOF) {
                                        FILE_OP_ERROR("filtering config", "fputs || fputc");
                                        g_free(filtering_str);
-                                       return;
+                                       return -1;
                                }
                        }
                        tmp_name ++;
@@ -2040,7 +2241,7 @@ static void prefs_filtering_write(FILE *fp, GSList *prefs_filtering)
                if (fputs("\" ", fp) == EOF) {
                        FILE_OP_ERROR("filtering config", "fputs");
                        g_free(filtering_str);
-                       return;
+                       return -1;
                }
 
                if (prop->account_id != 0) {
@@ -2050,7 +2251,7 @@ static void prefs_filtering_write(FILE *fp, GSList *prefs_filtering)
                        if (fputs(tmp, fp) == EOF) {
                                FILE_OP_ERROR("filtering config", "fputs");
                                g_free(tmp);
-                               return;
+                               return -1;
                        }
                        g_free(tmp);
                }
@@ -2059,12 +2260,19 @@ static void prefs_filtering_write(FILE *fp, GSList *prefs_filtering)
                    fputc('\n', fp) == EOF) {
                        FILE_OP_ERROR("filtering config", "fputs || fputc");
                        g_free(filtering_str);
-                       return;
+                       return -1;
                }
                g_free(filtering_str);
        }
+       
+       return 0;
 }
 
+typedef struct _NodeLoopData {
+       FILE *fp;
+       gboolean error;
+} NodeLoopData;
+
 /*!
  *\brief       Write matchers from a folder item
  *
@@ -2073,10 +2281,10 @@ static void prefs_filtering_write(FILE *fp, GSList *prefs_filtering)
  *
  *\return      gboolean FALSE
  */
-static gboolean prefs_matcher_write_func(GNode *node, gpointer data)
+static gboolean prefs_matcher_write_func(GNode *node, gpointer d)
 {
        FolderItem *item;
-       FILE *fp = data;
+       NodeLoopData *data = (NodeLoopData *)d;
        gchar *id;
        GSList *prefs_filtering;
 
@@ -2090,11 +2298,20 @@ static gboolean prefs_matcher_write_func(GNode *node, gpointer data)
         prefs_filtering = item->prefs->processing;
 
        if (prefs_filtering != NULL) {
-               fprintf(fp, "[%s]\n", id);
-               prefs_filtering_write(fp, prefs_filtering);
-               fputc('\n', fp);
+               if (fprintf(data->fp, "[%s]\n", id) < 0) {
+                       data->error = TRUE;
+                       goto fail;
+               }
+               if (prefs_filtering_write(data->fp, prefs_filtering) < 0) {
+                       data->error = TRUE;
+                       goto fail;
+               }
+               if (fputc('\n', data->fp) == EOF) {
+                       data->error = TRUE;
+                       goto fail;
+               }
        }
-
+fail:
        g_free(id);
 
        return FALSE;
@@ -2105,32 +2322,44 @@ static gboolean prefs_matcher_write_func(GNode *node, gpointer data)
  *
  *\param       fp File
  */
-static void prefs_matcher_save(FILE *fp)
+static int prefs_matcher_save(FILE *fp)
 {
        GList *cur;
+       NodeLoopData data;
+       
+       data.fp = fp;
+       data.error = FALSE;
 
        for (cur = folder_get_list() ; cur != NULL ; cur = g_list_next(cur)) {
                Folder *folder;
 
                folder = (Folder *) cur->data;
                g_node_traverse(folder->node, G_PRE_ORDER, G_TRAVERSE_ALL, -1,
-                               prefs_matcher_write_func, fp);
+                               prefs_matcher_write_func, &data);
        }
         
+       if (data.error == TRUE)
+               return -1;
+
         /* pre global rules */
-        fprintf(fp, "[preglobal]\n");
-        prefs_filtering_write(fp, pre_global_processing);
-        fputc('\n', fp);
+        if (fprintf(fp, "[preglobal]\n") < 0 ||
+            prefs_filtering_write(fp, pre_global_processing) < 0 ||
+            fputc('\n', fp) == EOF)
+               return -1;
 
         /* post global rules */
-        fprintf(fp, "[postglobal]\n");
-        prefs_filtering_write(fp, post_global_processing);
-        fputc('\n', fp);
+        if (fprintf(fp, "[postglobal]\n") < 0 ||
+            prefs_filtering_write(fp, post_global_processing) < 0 ||
+            fputc('\n', fp) == EOF)
+               return -1;
         
         /* filtering rules */
-        fprintf(fp, "[filtering]\n");
-        prefs_filtering_write(fp, filtering_rules);
-        fputc('\n', fp);
+       if (fprintf(fp, "[filtering]\n") < 0 ||
+            prefs_filtering_write(fp, filtering_rules) < 0 ||
+            fputc('\n', fp) == EOF)
+               return -1;
+
+       return 0;
 }
 
 /*!
@@ -2152,14 +2381,13 @@ void prefs_matcher_write_config(void)
                return;
        }
 
-
-       prefs_matcher_save(pfile->fp);
-
        g_free(rcpath);
 
-       if (prefs_file_close(pfile) < 0) {
+       if (prefs_matcher_save(pfile->fp) < 0) {
                g_warning("failed to write configuration to file\n");
-               return;
+               prefs_file_close_revert(pfile);
+       } else if (prefs_file_close(pfile) < 0) {
+               g_warning("failed to save configuration to file\n");
        }
 }
 
@@ -2171,9 +2399,18 @@ static void matcher_add_rulenames(const gchar *rcpath)
        FILE *src = g_fopen(rcpath, "rb");
        FILE *dst = g_fopen(newpath, "wb");
        gchar buf[BUFFSIZE];
-
+       int r;
+       if (src == NULL) {
+               perror("fopen");
+               if (dst)
+                       fclose(dst);
+               g_free(newpath);
+               return;
+       }
        if (dst == NULL) {
                perror("fopen");
+               if (src)
+                       fclose(src);
                g_free(newpath);
                return;
        }
@@ -2183,10 +2420,10 @@ static void matcher_add_rulenames(const gchar *rcpath)
                && strncmp(buf, "rulename \"", 10)
                && strncmp(buf, "enabled rulename \"", 18)
                && strncmp(buf, "disabled rulename \"", 18)) {
-                       fwrite("enabled rulename \"\" ",
+                       r = fwrite("enabled rulename \"\" ",
                                strlen("enabled rulename \"\" "), 1, dst);
                }
-               fwrite(buf, strlen(buf), 1, dst);
+               r = fwrite(buf, strlen(buf), 1, dst);
        }
        fclose(dst);
        fclose(src);
@@ -2230,7 +2467,7 @@ void prefs_matcher_read_config(void)
        else {
                /* previous version compatibility */
 
-               /* printf("reading filtering\n"); */
+               /* g_print("reading filtering\n"); */
                rcpath = g_strconcat(get_rc_dir(), G_DIR_SEPARATOR_S,
                                     FILTERING_RC, NULL);
                f = g_fopen(rcpath, "rb");
@@ -2241,7 +2478,7 @@ void prefs_matcher_read_config(void)
                        fclose(matcher_parserin);
                }
                
-               /* printf("reading scoring\n"); */
+               /* g_print("reading scoring\n"); */
                rcpath = g_strconcat(get_rc_dir(), G_DIR_SEPARATOR_S,
                                     SCORING_RC, NULL);
                f = g_fopen(rcpath, "rb");