2008-05-12 [wwp] 3.4.0cvs30
[claws.git] / src / matcher.c
index 5fdfd86f4d751e3eb748618b3f214ef40bfdf9b7..00c4734f2abd348ee416dbfab42c316ba45f37b3 100644 (file)
@@ -1,10 +1,10 @@
 /*
  * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 2002-2004 by the Sylpheed Claws Team and Hiroyuki Yamamoto
+ * Copyright (C) 2002-2004 by the Claws Mail Team and Hiroyuki Yamamoto
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
+ * the Free Software Foundation; either version 3 of the License, or
  * (at your option) any later version.
  *
  * This program is distributed in the hope that it will be useful,
@@ -13,8 +13,8 @@
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ * 
  */
 
 #ifdef HAVE_CONFIG_H
 #include "addr_compl.h"
 #include "codeconv.h"
 #include "quoted-printable.h"
+#include "claws.h"
 #include <ctype.h>
+#include "prefs_common.h"
+#include "log.h"
+#include "tags.h"
 
 /*!
  *\brief       Keyword lookup element
@@ -77,6 +81,10 @@ static const MatchParser matchparser_tab[] = {
        {MATCHCRITERIA_NOT_COLORLABEL, "~colorlabel"},
        {MATCHCRITERIA_IGNORE_THREAD, "ignore_thread"},
        {MATCHCRITERIA_NOT_IGNORE_THREAD, "~ignore_thread"},
+       {MATCHCRITERIA_WATCH_THREAD, "watch_thread"},
+       {MATCHCRITERIA_NOT_WATCH_THREAD, "~watch_thread"},
+       {MATCHCRITERIA_SPAM, "spam"},
+       {MATCHCRITERIA_NOT_SPAM, "~spam"},
 
        /* msginfo headers */
        {MATCHCRITERIA_SUBJECT, "subject"},
@@ -89,6 +97,10 @@ static const MatchParser matchparser_tab[] = {
        {MATCHCRITERIA_NOT_CC, "~cc"},
        {MATCHCRITERIA_TO_OR_CC, "to_or_cc"},
        {MATCHCRITERIA_NOT_TO_AND_NOT_CC, "~to_or_cc"},
+       {MATCHCRITERIA_TAG, "tag"},
+       {MATCHCRITERIA_NOT_TAG, "~tag"},
+       {MATCHCRITERIA_TAGGED, "tagged"},
+       {MATCHCRITERIA_NOT_TAGGED, "~tagged"},
        {MATCHCRITERIA_AGE_GREATER, "age_greater"},
        {MATCHCRITERIA_AGE_LOWER, "age_lower"},
        {MATCHCRITERIA_NEWSGROUPS, "newsgroups"},
@@ -102,6 +114,8 @@ static const MatchParser matchparser_tab[] = {
        {MATCHCRITERIA_SCORE_EQUAL, "score_equal"},
        {MATCHCRITERIA_PARTIAL, "partial"},
        {MATCHCRITERIA_NOT_PARTIAL, "~partial"},
+       {MATCHCRITERIA_FOUND_IN_ADDRESSBOOK, "found_in_addressbook"},
+       {MATCHCRITERIA_NOT_FOUND_IN_ADDRESSBOOK, "~found_in_addressbook"},
 
        {MATCHCRITERIA_SIZE_GREATER, "size_greater"},
        {MATCHCRITERIA_SIZE_SMALLER, "size_smaller"},
@@ -124,8 +138,6 @@ static const MatchParser matchparser_tab[] = {
        {MATCHTYPE_MATCH, "match"},
        {MATCHTYPE_REGEXPCASE, "regexpcase"},
        {MATCHTYPE_REGEXP, "regexp"},
-       {MATCHTYPE_ANY_IN_ADDRESSBOOK, "any_in_addressbook"},
-       {MATCHTYPE_ALL_IN_ADDRESSBOOK, "all_in_addressbook"},
 
        /* actions */
        {MATCHACTION_SCORE, "score"},    /* for backward compatibility */
@@ -138,6 +150,8 @@ static const MatchParser matchparser_tab[] = {
        {MATCHACTION_UNLOCK, "unlock"},
        {MATCHACTION_MARK_AS_READ, "mark_as_read"},
        {MATCHACTION_MARK_AS_UNREAD, "mark_as_unread"},
+       {MATCHACTION_MARK_AS_SPAM, "mark_as_spam"},
+       {MATCHACTION_MARK_AS_HAM, "mark_as_ham"},
        {MATCHACTION_FORWARD, "forward"},
        {MATCHACTION_FORWARD_AS_ATTACHMENT, "forward_as_attachment"},
        {MATCHACTION_EXECUTE, "execute"},
@@ -148,8 +162,21 @@ static const MatchParser matchparser_tab[] = {
        {MATCHACTION_STOP, "stop"},
        {MATCHACTION_HIDE, "hide"},
        {MATCHACTION_IGNORE, "ignore"},
+       {MATCHACTION_WATCH, "watch"},
+       {MATCHACTION_ADD_TO_ADDRESSBOOK, "add_to_addressbook"},
+       {MATCHACTION_SET_TAG, "set_tag"},
+       {MATCHACTION_UNSET_TAG, "unset_tag"},
+       {MATCHACTION_CLEAR_TAGS, "clear_tags"},
 };
 
+enum {
+       MATCH_ANY = 0,
+       MATCH_ALL = 1,
+       MATCH_ONE = 2
+};
+
+extern gboolean debug_filtering_session;
+
 /*!
  *\brief       Look up table with keywords defined in \sa matchparser_tab
  */
@@ -212,7 +239,8 @@ gint get_matchparser_tab_id(const gchar *str)
  *             "condition" (a matcher structure)
  *
  *\param       criteria Criteria ID (MATCHCRITERIA_XXXX)
- *\param       header Header string (if criteria is MATCHCRITERIA_HEADER)
+ *\param       header Header string (if criteria is MATCHCRITERIA_HEADER
+                       or MATCHCRITERIA_FOUND_IN_ADDRESSBOOK)
  *\param       matchtype Type of action (MATCHTYPE_XXX)
  *\param       expr String value or expression to check
  *\param       value Integer value to check
@@ -228,7 +256,44 @@ MatcherProp *matcherprop_new(gint criteria, const gchar *header,
        prop = g_new0(MatcherProp, 1);
        prop->criteria = criteria;
        prop->header = header != NULL ? g_strdup(header) : NULL;
+
+       prop->expr = expr != NULL ? g_strdup(expr) : NULL;
+
+       prop->matchtype = matchtype;
+       prop->preg = NULL;
+       prop->value = value;
+       prop->error = 0;
+
+       return prop;
+}
+
+/*!
+ *\brief       Allocate a structure for a filtering / scoring
+ *             "condition" (a matcher structure)
+ *             Same as matcherprop_new, except it doesn't change the expr's 
+ *             case.
+ *
+ *\param       criteria Criteria ID (MATCHCRITERIA_XXXX)
+ *\param       header Header string (if criteria is MATCHCRITERIA_HEADER
+                       or MATCHCRITERIA_FOUND_IN_ADDRESSBOOK)
+ *\param       matchtype Type of action (MATCHTYPE_XXX)
+ *\param       expr String value or expression to check
+ *\param       value Integer value to check
+ *
+ *\return      MatcherProp * Pointer to newly allocated structure
+ */
+MatcherProp *matcherprop_new_create(gint criteria, const gchar *header,
+                             gint matchtype, const gchar *expr,
+                             int value)
+{
+       MatcherProp *prop;
+
+       prop = g_new0(MatcherProp, 1);
+       prop->criteria = criteria;
+       prop->header = header != NULL ? g_strdup(header) : NULL;
+
        prop->expr = expr != NULL ? g_strdup(expr) : NULL;
+
        prop->matchtype = matchtype;
        prop->preg = NULL;
        prop->value = value;
@@ -279,38 +344,90 @@ MatcherProp *matcherprop_copy(const MatcherProp *src)
 /* ************** match ******************************/
 
 static gboolean match_with_addresses_in_addressbook
-       (MatcherProp *prop, const gchar *str, gint type)
+       (MatcherProp *prop, GSList *address_list, gint type,
+        gchar* folderpath, gint match)
 {
-       GSList *address_list = NULL;
-       GSList *walk;
-       gboolean res = FALSE;
+       GSList *walk = NULL;
+       gboolean found = FALSE;
+       gchar *path = NULL;
 
-       if (str == NULL || *str == 0) 
-               return FALSE;
+       g_return_val_if_fail(address_list != NULL, FALSE);
+
+       debug_print("match_with_addresses_in_addressbook(%d, %s)\n",
+                               g_slist_length(address_list), folderpath?folderpath:"(null)");
+
+       if (folderpath == NULL ||
+               strcasecmp(folderpath, "Any") == 0 ||
+               *folderpath == '\0')
+               path = NULL;
+       else
+               path = folderpath;
        
-       /* XXX: perhaps complete with comments too */
-       address_list = address_list_append(address_list, str);
-       if (!address_list) 
-               return FALSE;
+       start_address_completion(path);
 
-       start_address_completion();             
-       res = FALSE;
        for (walk = address_list; walk != NULL; walk = walk->next) {
-               gboolean found = complete_address(walk->data) ? TRUE : FALSE;
-               
+               /* exact matching of email address */
+               guint num_addr = complete_address(walk->data);
+               found = FALSE;
+               if (num_addr > 1) {
+                       /* skip first item (this is the search string itself) */
+                       int i = 1;
+                       for (; i < num_addr && !found; i++) {
+                               gchar *addr = get_complete_address(i);
+                               extract_address(addr);
+                               if (strcasecmp(addr, walk->data) == 0) {
+                                       found = TRUE;
+
+                                       /* debug output */
+                                       if (debug_filtering_session
+                                                       && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
+                                               log_print(LOG_DEBUG_FILTERING,
+                                                               "address [ %s ] matches\n",
+                                                               (gchar *)walk->data);
+                                       }
+                               }
+                               g_free(addr);
+                       }
+               }
+               /* debug output */
+               if (debug_filtering_session
+                               && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH
+                               && !found) {
+                       log_print(LOG_DEBUG_FILTERING,
+                                       "address [ %s ] does NOT match\n",
+                                       (gchar *)walk->data);
+               }
                g_free(walk->data);
-               if (!found && type == MATCHTYPE_ALL_IN_ADDRESSBOOK) {
-                       res = FALSE;
-                       break;
-               } else if (found) 
-                       res = TRUE;
-       }
 
-       g_slist_free(address_list);
+               if (match == MATCH_ALL) {
+                       /* if matching all addresses, stop if one doesn't match */
+                       if (!found) {
+                               /* debug output */
+                               if (debug_filtering_session
+                                               && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
+                                       log_print(LOG_DEBUG_FILTERING,
+                                                       "not all address match (matching all)\n");
+                               }
+                               break;
+                       }
+               } else if (match == MATCH_ANY) {
+                       /* if matching any address, stop if one does match */
+                       if (found) {
+                               /* debug output */
+                               if (debug_filtering_session
+                                               && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
+                                       log_print(LOG_DEBUG_FILTERING,
+                                                       "at least one address matches (matching any)\n");
+                               }
+                               break;
+                       }
+               }
+               /* MATCH_ONE: there should be only one loop iteration */
+       }
 
        end_address_completion();
        
-       return res;
+       return found;
 }
 
 /*!
@@ -322,21 +439,34 @@ static gboolean match_with_addresses_in_addressbook
  *\return      gboolean TRUE if str matches the condition in the 
  *             matcher structure
  */
-static gboolean matcherprop_string_match(MatcherProp *prop, const gchar *str)
+static gboolean matcherprop_string_match(MatcherProp *prop, const gchar *str,
+                                        const gchar *debug_context)
 {
        gchar *str1;
-       gchar *str2;
-
+       gchar *down_expr;
+       gboolean ret = FALSE;
+       gboolean should_free = FALSE;
        if (str == NULL)
                return FALSE;
 
+       if (prop->matchtype == MATCHTYPE_REGEXPCASE ||
+           prop->matchtype == MATCHTYPE_MATCHCASE) {
+               str1 = g_utf8_casefold(str, -1);
+               down_expr = g_utf8_casefold(prop->expr, -1);
+               should_free = TRUE;
+       } else {
+               str1 = (gchar *)str;
+               down_expr = (gchar *)prop->expr;
+               should_free = FALSE;
+       }
+
        switch (prop->matchtype) {
        case MATCHTYPE_REGEXPCASE:
        case MATCHTYPE_REGEXP:
                if (!prop->preg && (prop->error == 0)) {
                        prop->preg = g_new0(regex_t, 1);
                        /* if regexp then don't use the escaped string */
-                       if (regcomp(prop->preg, prop->expr,
+                       if (regcomp(prop->preg, down_expr,
                                    REG_NOSUB | REG_EXTENDED
                                    | ((prop->matchtype == MATCHTYPE_REGEXPCASE)
                                    ? REG_ICASE : 0)) != 0) {
@@ -345,39 +475,128 @@ static gboolean matcherprop_string_match(MatcherProp *prop, const gchar *str)
                                prop->preg = NULL;
                        }
                }
-               if (prop->preg == NULL)
-                       return FALSE;
+               if (prop->preg == NULL) {
+                       ret = FALSE;
+                       goto free_strs;
+               }
                
-               if (regexec(prop->preg, str, 0, NULL, 0) == 0)
-                       return TRUE;
+               if (regexec(prop->preg, str1, 0, NULL, 0) == 0)
+                       ret = TRUE;
                else
-                       return FALSE;
+                       ret = FALSE;
+
+               /* debug output */
+               if (debug_filtering_session
+                               && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
+                       gchar *stripped = g_strdup(str);
+
+                       strretchomp(stripped);
+                       if (ret) {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "%s value [ %s ] matches regular expression [ %s ] (%s)\n",
+                                               debug_context, stripped, prop->expr,
+                                               prop->matchtype == MATCHTYPE_REGEXP ? _("Case sensitive"):_("Case insensitive"));
+                       } else {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "%s value [ %s ] does NOT match regular expression [ %s ] (%s)\n",
+                                               debug_context, stripped, prop->expr,
+                                               prop->matchtype == MATCHTYPE_REGEXP ? _("Case sensitive"):_("Case insensitive"));
+                       }
+                       g_free(stripped);
+               }
+               break;
                        
-       case MATCHTYPE_ALL_IN_ADDRESSBOOK:      
-       case MATCHTYPE_ANY_IN_ADDRESSBOOK:
-               return match_with_addresses_in_addressbook
-                       (prop, str, prop->matchtype);
-
+       case MATCHTYPE_MATCHCASE:
        case MATCHTYPE_MATCH:
-               return (strstr(str, prop->expr) != NULL);
+               ret = (strstr(str1, down_expr) != NULL);
+
+               /* debug output */
+               if (debug_filtering_session
+                               && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
+                       gchar *stripped = g_strdup(str);
+
+                       strretchomp(stripped);
+                       if (ret) {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "%s value [ %s ] contains [ %s ] (%s)\n",
+                                               debug_context, stripped, prop->expr,
+                                               prop->matchtype == MATCHTYPE_MATCH ? _("Case sensitive"):_("Case insensitive"));
+                       } else {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "%s value [ %s ] does NOT contain [ %s ] (%s)\n",
+                                               debug_context, stripped, prop->expr,
+                                               prop->matchtype == MATCHTYPE_MATCH ? _("Case sensitive"):_("Case insensitive"));
+                       }
+                       g_free(stripped);
+               }
+               break;
 
-       /* FIXME: put upper in unesc_str */
-       case MATCHTYPE_MATCHCASE:
-               str2 = alloca(strlen(prop->expr) + 1);
-               strcpy(str2, prop->expr);
-               g_strup(str2);
-               str1 = alloca(strlen(str) + 1);
-               strcpy(str1, str);
-               g_strup(str1);
-               return (strstr(str1, str2) != NULL);
-               
        default:
+               break;
+       }
+       
+free_strs:
+       if (should_free) {
+               g_free(str1);
+               g_free(down_expr);
+       }
+       return ret;
+}
+
+/*!
+ *\brief       Find out if a tag matches a condition
+ *
+ *\param       prop Matcher structure
+ *\param       msginfo message to check
+ *
+ *\return      gboolean TRUE if msginfo matches the condition in the 
+ *             matcher structure
+ */
+static gboolean matcherprop_tag_match(MatcherProp *prop, MsgInfo *msginfo,
+                                        const gchar *debug_context)
+{
+       gboolean ret = FALSE;
+       GSList *cur;
+
+       if (msginfo == NULL || msginfo->tags == NULL)
                return FALSE;
+
+       for (cur = msginfo->tags; cur; cur = cur->next) {
+               const gchar *str = tags_get_tag(GPOINTER_TO_INT(cur->data));
+               if (!str)
+                       continue;
+               if (matcherprop_string_match(prop, str, debug_context)) {
+                       ret = TRUE;
+                       break;
+               }
        }
+       return ret;
+}
+
+/*!
+ *\brief       Find out if the string-ed list matches a condition
+ *
+ *\param       prop Matcher structure
+ *\param       list GSList of strings to check
+ *
+ *\return      gboolean TRUE if str matches the condition in the 
+ *             matcher structure
+ */
+static gboolean matcherprop_list_match(MatcherProp *prop, const GSList *list,
+const gchar *debug_context)
+{
+       const GSList *cur;
+
+       for(cur = list; cur != NULL; cur = cur->next) {
+               if (matcherprop_string_match(prop, (gchar *)cur->data, debug_context))
+                       return TRUE;
+       }
+       return FALSE;
 }
 
 /* FIXME body search is a hack. */
-static gboolean matcherprop_string_decode_match(MatcherProp *prop, const gchar *str)
+static gboolean matcherprop_string_decode_match(MatcherProp *prop, const gchar *str,
+                                                                                               const gchar *debug_context)
 {
        gchar *utf = NULL;
        gchar tmp[BUFFSIZE];
@@ -392,13 +611,14 @@ static gboolean matcherprop_string_decode_match(MatcherProp *prop, const gchar *
                utf = conv_codeset_strdup
                        (tmp, conv_get_locale_charset_str_no_utf8(),
                         CS_INTERNAL);
-               res = matcherprop_string_match(prop, utf);
+               res = matcherprop_string_match(prop, utf, debug_context);
                g_free(utf);
        } else {
-               res = matcherprop_string_match(prop, tmp);
+               res = matcherprop_string_match(prop, tmp, debug_context);
        }
        
-       if (res == FALSE && (strchr(prop->expr, '=') || strchr(prop->expr, '_')) ) {
+       if (res == FALSE && (strchr(prop->expr, '=') || strchr(prop->expr, '_')
+                           || strchr(str, '=') || strchr(str, '_'))) {
                /* if searching for something with an equal char, maybe 
                 * we should try to match the non-decoded string. 
                 * In case it was not qp-encoded. */
@@ -406,9 +626,10 @@ static gboolean matcherprop_string_decode_match(MatcherProp *prop, const gchar *
                        utf = conv_codeset_strdup
                                (str, conv_get_locale_charset_str_no_utf8(),
                                 CS_INTERNAL);
-                       res = matcherprop_string_match(prop, utf);
+                       res = matcherprop_string_match(prop, utf, debug_context);
+                       g_free(utf);
                } else {
-                       res = matcherprop_string_match(prop, str);
+                       res = matcherprop_string_match(prop, str, debug_context);
                }
        }
 
@@ -426,7 +647,7 @@ typedef struct _thread_data {
 #endif
 
 #ifdef USE_PTHREAD
-void *matcher_test_thread(void *data)
+static void *matcher_test_thread(void *data)
 {
        thread_data *td = (thread_data *)data;
        int result = -1;
@@ -435,7 +656,6 @@ void *matcher_test_thread(void *data)
        pthread_setcanceltype(PTHREAD_CANCEL_ASYNCHRONOUS, NULL);
 
        result = system(td->cmd);
-       if (result) perror("system");
        td->done = TRUE; /* let the caller thread join() */
        return GINT_TO_POINTER(result);
 }
@@ -457,6 +677,7 @@ static gboolean matcherprop_match_test(const MatcherProp *prop,
        gint retval;
 #ifdef USE_PTHREAD
        pthread_t pt;
+       pthread_attr_t pta;
        thread_data *td = g_new0(thread_data, 1);
        void *res = NULL;
        time_t start_time = time(NULL);
@@ -471,17 +692,26 @@ static gboolean matcherprop_match_test(const MatcherProp *prop,
        if (cmd == NULL)
                return FALSE;
 
-#if (defined USE_PTHREAD && defined __GLIBC__ && (__GLIBC__ > 2 || (__GLIBC__ == 2 && __GLIBC_MINOR__ >= 3)))
+#ifdef USE_PTHREAD
+       /* debug output */
+       if (debug_filtering_session
+                       && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
+               log_print(LOG_DEBUG_FILTERING,
+                               "starting threaded command [ %s ]\n",
+                               cmd);
+       }
+
        td->cmd = cmd;
        td->done = FALSE;
-       if (pthread_create(&pt, PTHREAD_CREATE_JOINABLE, 
-                       matcher_test_thread, td) != 0)
+       if (pthread_attr_init(&pta) != 0 ||
+           pthread_attr_setdetachstate(&pta, PTHREAD_CREATE_JOINABLE) != 0 ||
+           pthread_create(&pt, &pta, matcher_test_thread, td) != 0)
                retval = system(cmd);
        else {
-               printf("waiting for test thread\n");
+               debug_print("waiting for test thread\n");
                while(!td->done) {
                        /* don't let the interface freeze while waiting */
-                       sylpheed_do_idle();
+                       claws_do_idle();
                        if (time(NULL) - start_time > 30) {
                                pthread_cancel(pt);
                                td->done = TRUE;
@@ -490,14 +720,30 @@ static gboolean matcherprop_match_test(const MatcherProp *prop,
                }
                pthread_join(pt, &res);
                retval = GPOINTER_TO_INT(res);
-               printf(" test thread returned %d\n", retval);
+               debug_print(" test thread returned %d\n", retval);
        }
        g_free(td);
 #else
+       /* debug output */
+       if (debug_filtering_session
+                       && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
+               log_print(LOG_DEBUG_FILTERING,
+                               "starting synchronous command [ %s ]\n",
+                               cmd);
+       }
+
        retval = system(cmd);
 #endif
        debug_print("Command exit code: %d\n", retval);
 
+       /* debug output */
+       if (debug_filtering_session
+                       && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
+               log_print(LOG_DEBUG_FILTERING,
+                               "command returned [ %d ]\n",
+                               retval);
+       }
+
        g_free(cmd);
        return (retval == 0);
 }
@@ -518,7 +764,7 @@ gboolean matcherprop_match(MatcherProp *prop,
 
        switch(prop->criteria) {
        case MATCHCRITERIA_ALL:
-               return 1;
+               return TRUE;
        case MATCHCRITERIA_UNREAD:
                return MSG_IS_UNREAD(info->flags);
        case MATCHCRITERIA_NOT_UNREAD:
@@ -547,83 +793,384 @@ gboolean matcherprop_match(MatcherProp *prop,
                return MSG_IS_LOCKED(info->flags);
        case MATCHCRITERIA_NOT_LOCKED:
                return !MSG_IS_LOCKED(info->flags);
+       case MATCHCRITERIA_SPAM:
+               return MSG_IS_SPAM(info->flags);
+       case MATCHCRITERIA_NOT_SPAM:
+               return !MSG_IS_SPAM(info->flags);
        case MATCHCRITERIA_COLORLABEL:
-               return MSG_GET_COLORLABEL_VALUE(info->flags) == prop->value; 
+       {
+               gint color = MSG_GET_COLORLABEL_VALUE(info->flags);
+               gboolean ret = (color == prop->value);
+
+               /* debug output */
+               if (debug_filtering_session
+                               && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
+                       if (ret) {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "message color value [ %d ] matches color value [ %d ]\n",
+                                               color, prop->value);
+                       } else {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "message color value [ %d ] does NOT match color value [ %d ]\n",
+                                               color, prop->value);
+                       }
+               }
+               return ret;
+       }
        case MATCHCRITERIA_NOT_COLORLABEL:
-               return MSG_GET_COLORLABEL_VALUE(info->flags) != prop->value;
+       {
+               gint color = MSG_GET_COLORLABEL_VALUE(info->flags);
+               gboolean ret = (color != prop->value);
+
+               /* debug output */
+               if (debug_filtering_session
+                               && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
+                       if (ret) {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "message color value [ %d ] matches color value [ %d ]\n",
+                                               color, prop->value);
+                       } else {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "message color value [ %d ] does NOT match color value [ %d ]\n",
+                                               color, prop->value);
+                       }
+               }
+               return ret;
+       }
        case MATCHCRITERIA_IGNORE_THREAD:
                return MSG_IS_IGNORE_THREAD(info->flags);
        case MATCHCRITERIA_NOT_IGNORE_THREAD:
                return !MSG_IS_IGNORE_THREAD(info->flags);
+       case MATCHCRITERIA_WATCH_THREAD:
+               return MSG_IS_WATCH_THREAD(info->flags);
+       case MATCHCRITERIA_NOT_WATCH_THREAD:
+               return !MSG_IS_WATCH_THREAD(info->flags);
        case MATCHCRITERIA_SUBJECT:
-               return matcherprop_string_match(prop, info->subject);
+               return matcherprop_string_match(prop, info->subject,
+                                               prefs_common_translated_header_name("Subject:"));
        case MATCHCRITERIA_NOT_SUBJECT:
-               return !matcherprop_string_match(prop, info->subject);
+               return !matcherprop_string_match(prop, info->subject,
+                                               prefs_common_translated_header_name("Subject:"));
        case MATCHCRITERIA_FROM:
-               return matcherprop_string_match(prop, info->from);
        case MATCHCRITERIA_NOT_FROM:
-               return !matcherprop_string_match(prop, info->from);
+       {
+               gchar *context;
+               gboolean ret;
+
+               context = g_strdup_printf(_("%s header"), prefs_common_translated_header_name("From:"));
+               ret = matcherprop_string_match(prop, info->from, context);
+               g_free(context);
+               return (prop->criteria == MATCHCRITERIA_FROM)? ret : !ret;
+       }
        case MATCHCRITERIA_TO:
-               return matcherprop_string_match(prop, info->to);
        case MATCHCRITERIA_NOT_TO:
-               return !matcherprop_string_match(prop, info->to);
+       {
+               gchar *context;
+               gboolean ret;
+
+               context = g_strdup_printf(_("%s header"), prefs_common_translated_header_name("To:"));
+               ret = matcherprop_string_match(prop, info->to, context);
+               g_free(context);
+               return (prop->criteria == MATCHCRITERIA_TO)? ret : !ret;
+       }
        case MATCHCRITERIA_CC:
-               return matcherprop_string_match(prop, info->cc);
        case MATCHCRITERIA_NOT_CC:
-               return !matcherprop_string_match(prop, info->cc);
+       {
+               gchar *context;
+               gboolean ret;
+
+               context = g_strdup_printf(_("%s header"), prefs_common_translated_header_name("Cc:"));
+               ret = matcherprop_string_match(prop, info->cc, context);
+               g_free(context);
+               return (prop->criteria == MATCHCRITERIA_CC)? ret : !ret;
+       }
        case MATCHCRITERIA_TO_OR_CC:
-               return matcherprop_string_match(prop, info->to)
-                       || matcherprop_string_match(prop, info->cc);
+       {
+               gchar *context1, *context2;
+               gboolean ret;
+
+               context1 = g_strdup_printf(_("%s header"), prefs_common_translated_header_name("To:"));
+               context2 = g_strdup_printf(_("%s header"), prefs_common_translated_header_name("Cc:"));
+               ret = matcherprop_string_match(prop, info->to, context1)
+                       || matcherprop_string_match(prop, info->cc, context2);
+               g_free(context1);
+               g_free(context2);
+               return ret;
+       }
        case MATCHCRITERIA_NOT_TO_AND_NOT_CC:
-               return !(matcherprop_string_match(prop, info->to)
-               || matcherprop_string_match(prop, info->cc));
+       {
+               gchar *context1, *context2;
+               gboolean ret;
+
+               context1 = g_strdup_printf(_("%s header"), prefs_common_translated_header_name("To:"));
+               context2 = g_strdup_printf(_("%s header"), prefs_common_translated_header_name("Cc:"));
+               ret = !(matcherprop_string_match(prop, info->to, context1)
+                       || matcherprop_string_match(prop, info->cc, context2));
+               g_free(context1);
+               g_free(context2);
+               return ret;
+       }
+       case MATCHCRITERIA_TAG:
+       case MATCHCRITERIA_NOT_TAG:
+       {
+               gboolean ret;
+
+               ret = matcherprop_tag_match(prop, info, _("Tag"));
+               return (prop->criteria == MATCHCRITERIA_TAG)? ret : !ret;
+       }
+       case MATCHCRITERIA_TAGGED:
+       case MATCHCRITERIA_NOT_TAGGED:
+       {
+               gboolean ret;
+
+               ret = (info->tags != NULL);
+               return (prop->criteria == MATCHCRITERIA_TAGGED)? ret : !ret;
+       }
        case MATCHCRITERIA_AGE_GREATER:
+       {
+               gboolean ret;
+               gint age;
+
                t = time(NULL);
-               return ((t - info->date_t) / (60 * 60 * 24)) > prop->value;
+               age = ((t - info->date_t) / (60 * 60 * 24));
+               ret = (age > prop->value);
+
+               /* debug output */
+               if (debug_filtering_session
+                               && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
+                       if (ret) {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "message age [ %d ] is greater than [ %d ]\n",
+                                               age, prop->value);
+                       } else {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "message age [ %d ] is not greater than [ %d ]\n",
+                                               age, prop->value);
+                       }
+               }
+               return ret;
+       }
        case MATCHCRITERIA_AGE_LOWER:
+       {
+               gboolean ret;
+               gint age;
+
                t = time(NULL);
-               return ((t - info->date_t) / (60 * 60 * 24)) < prop->value;
+               age = ((t - info->date_t) / (60 * 60 * 24));
+               ret = (age < prop->value);
+
+               /* debug output */
+               if (debug_filtering_session
+                               && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
+                       if (ret) {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "message age [ %d ] is lower than [ %d ]\n",
+                                               age, prop->value);
+                       } else {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "message age [ %d ] is not lower than [ %d ]\n",
+                                               age, prop->value);
+                       }
+               }
+               return ret;
+       }
        case MATCHCRITERIA_SCORE_GREATER:
-               return info->score > prop->value;
+       {
+               gboolean ret = (info->score > prop->value);
+
+               /* debug output */
+               if (debug_filtering_session
+                               && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
+                       if (ret) {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "message score [ %d ] is greater than [ %d ]\n",
+                                               info->score, prop->value);
+                       } else {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "message score [ %d ] is not greater than [ %d ]\n",
+                                               info->score, prop->value);
+                       }
+               }
+               return ret;
+       }
        case MATCHCRITERIA_SCORE_LOWER:
-               return info->score < prop->value;
+       {
+               gboolean ret = (info->score < prop->value);
+
+               /* debug output */
+               if (debug_filtering_session
+                               && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
+                       if (ret) {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "message score [ %d ] is lower than [ %d ]\n",
+                                               info->score, prop->value);
+                       } else {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "message score [ %d ] is not lower than [ %d ]\n",
+                                               info->score, prop->value);
+                       }
+               }
+               return ret;
+       }
        case MATCHCRITERIA_SCORE_EQUAL:
-               return info->score == prop->value;
+       {
+               gboolean ret = (info->score == prop->value);
+
+               /* debug output */
+               if (debug_filtering_session
+                               && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
+                       if (ret) {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "message score [ %d ] is equal to [ %d ]\n",
+                                               info->score, prop->value);
+                       } else {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "message score [ %d ] is not equal to [ %d ]\n",
+                                               info->score, prop->value);
+                       }
+               }
+               return ret;
+       }
        case MATCHCRITERIA_SIZE_GREATER:
+       {
                /* FIXME: info->size is an off_t */
-               return info->size > (off_t) prop->value;
-       case MATCHCRITERIA_SIZE_EQUAL:
-               /* FIXME: info->size is an off_t */
-               return info->size == (off_t) prop->value;
+               gboolean ret = (info->size > (off_t) prop->value);
+
+               /* debug output */
+               if (debug_filtering_session
+                               && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
+                       if (ret) {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "message size [ %ld ] is greater than [ %d ]\n",
+                                               info->size, prop->value);
+                       } else {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "message size [ %ld ] is not greater than [ %d ]\n",
+                                               info->size, prop->value);
+                       }
+               }
+               return ret;
+       }
        case MATCHCRITERIA_SIZE_SMALLER:
+       {
                /* FIXME: info->size is an off_t */
-               return info->size <  (off_t) prop->value;
+               gboolean ret = (info->size < (off_t) prop->value);
+
+               /* debug output */
+               if (debug_filtering_session
+                               && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
+                       if (ret) {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "message size [ %ld ] is smaller than [ %d ]\n",
+                                               info->size, prop->value);
+                       } else {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "message size [ %ld ] is not smaller than [ %d ]\n",
+                                               info->size, prop->value);
+                       }
+               }
+               return ret;
+       }
+       case MATCHCRITERIA_SIZE_EQUAL:
+       {
+               /* FIXME: info->size is an off_t */
+               gboolean ret = (info->size == (off_t) prop->value);
+
+               /* debug output */
+               if (debug_filtering_session
+                               && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
+                       if (ret) {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "message size [ %ld ] is equal to [ %d ]\n",
+                                               info->size, prop->value);
+                       } else {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "message size [ %ld ] is not equal to [ %d ]\n",
+                                               info->size, prop->value);
+                       }
+               }
+               return ret;
+       }
        case MATCHCRITERIA_PARTIAL:
+       {
                /* FIXME: info->size is an off_t */
-               return (info->total_size != 0 && info->size != (off_t)info->total_size);
+               gboolean ret = (info->total_size != 0 && info->size != (off_t)info->total_size);
+
+               /* debug output */
+               if (debug_filtering_session
+                               && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
+                       if (ret) {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "message is partially downloaded, size [ %ld ] is less than total size [ %d ])\n",
+                                               info->size, info->total_size);
+                       } else {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "message is not partially downloaded\n");
+                       }
+               }
+               return ret;
+       }
        case MATCHCRITERIA_NOT_PARTIAL:
+       {
                /* FIXME: info->size is an off_t */
-               return (info->total_size == 0 || info->size == (off_t)info->total_size);
+               gboolean ret = (info->total_size == 0 || info->size == (off_t)info->total_size);
+
+               /* debug output */
+               if (debug_filtering_session
+                               && prefs_common.filtering_debug_level >= FILTERING_DEBUG_LEVEL_HIGH) {
+                       if (ret) {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "message is not partially downloaded\n");
+                       } else {
+                               log_print(LOG_DEBUG_FILTERING,
+                                               "message is partially downloaded, size [ %ld ] is less than total size [ %d ])\n",
+                                               info->size, info->total_size);
+                       }
+               }
+               return ret;
+       }
        case MATCHCRITERIA_NEWSGROUPS:
-               return matcherprop_string_match(prop, info->newsgroups);
        case MATCHCRITERIA_NOT_NEWSGROUPS:
-               return !matcherprop_string_match(prop, info->newsgroups);
+       {
+               gchar *context;
+               gboolean ret;
+
+               context = g_strdup_printf(_("%s header"),
+                                               prefs_common_translated_header_name("Newsgroups:"));
+               ret = matcherprop_string_match(prop, info->newsgroups, context);
+               g_free(context);
+               return (prop->criteria == MATCHCRITERIA_NEWSGROUPS)? ret : !ret;
+       }
        case MATCHCRITERIA_INREPLYTO:
-               return matcherprop_string_match(prop, info->inreplyto);
        case MATCHCRITERIA_NOT_INREPLYTO:
-               return !matcherprop_string_match(prop, info->inreplyto);
-       /* FIXME: Using inreplyto, but matching the (newly implemented)
-         * list of references is better */
-        case MATCHCRITERIA_REFERENCES:
-               return matcherprop_string_match(prop, info->inreplyto);
+       {
+               gchar *context;
+               gboolean ret;
+
+               context = g_strdup_printf(_("%s header"),
+                                               prefs_common_translated_header_name("In-Reply-To:"));
+               ret = matcherprop_string_match(prop, info->inreplyto, context);
+               g_free(context);
+               return (prop->criteria == MATCHCRITERIA_INREPLYTO)? ret : !ret;
+       }
+       case MATCHCRITERIA_REFERENCES:
        case MATCHCRITERIA_NOT_REFERENCES:
-               return !matcherprop_string_match(prop, info->inreplyto);
+       {
+               gchar *context;
+               gboolean ret;
+
+               context = g_strdup_printf(_("%s header"),
+                                               prefs_common_translated_header_name("References:"));
+               ret = matcherprop_list_match(prop, info->references, context);
+               g_free(context);
+               return (prop->criteria == MATCHCRITERIA_REFERENCES)? ret : !ret;
+       }
        case MATCHCRITERIA_TEST:
                return matcherprop_match_test(prop, info);
        case MATCHCRITERIA_NOT_TEST:
                return !matcherprop_match_test(prop, info);
        default:
-               return 0;
+               return FALSE;
        }
 }
 
@@ -689,8 +1236,8 @@ static void matcherlist_skip_headers(FILE *fp)
 static gboolean matcherprop_match_one_header(MatcherProp *matcher,
                                             gchar *buf)
 {
-       gboolean result;
-       Header *header;
+       gboolean result = FALSE;
+       Header *header = NULL;
 
        switch (matcher->criteria) {
        case MATCHCRITERIA_HEADER:
@@ -701,9 +1248,9 @@ static gboolean matcherprop_match_one_header(MatcherProp *matcher,
                if (procheader_headername_equal(header->name,
                                                matcher->header)) {
                        if (matcher->criteria == MATCHCRITERIA_HEADER)
-                               result = matcherprop_string_match(matcher, header->body);
+                               result = matcherprop_string_match(matcher, header->body, _("header"));
                        else
-                               result = !matcherprop_string_match(matcher, header->body);
+                               result = !matcherprop_string_match(matcher, header->body, _("header"));
                        procheader_header_free(header);
                        return result;
                }
@@ -712,14 +1259,64 @@ static gboolean matcherprop_match_one_header(MatcherProp *matcher,
                }
                break;
        case MATCHCRITERIA_HEADERS_PART:
-               return matcherprop_string_match(matcher, buf);
+               return matcherprop_string_match(matcher, buf, _("header line"));
+       case MATCHCRITERIA_NOT_HEADERS_PART:
+               return !matcherprop_string_match(matcher, buf, _("headers line"));
        case MATCHCRITERIA_MESSAGE:
-               return matcherprop_string_decode_match(matcher, buf);
+               return matcherprop_string_decode_match(matcher, buf, _("message line"));
        case MATCHCRITERIA_NOT_MESSAGE:
-               return !matcherprop_string_decode_match(matcher, buf);
-       case MATCHCRITERIA_NOT_HEADERS_PART:
-               return !matcherprop_string_match(matcher, buf);
+               return !matcherprop_string_decode_match(matcher, buf, _("message line"));
+       case MATCHCRITERIA_FOUND_IN_ADDRESSBOOK:
+       case MATCHCRITERIA_NOT_FOUND_IN_ADDRESSBOOK:
+               {
+                       GSList *address_list = NULL;
+                       gint match = MATCH_ONE;
+                       gboolean found = FALSE;
+
+                       /* how many address headers are me trying to mach? */
+                       if (strcasecmp(matcher->header, "Any") == 0)
+                               match = MATCH_ANY;
+                       else if (strcasecmp(matcher->header, "All") == 0)
+                                       match = MATCH_ALL;
+
+                       if (match == MATCH_ONE) {
+                               /* matching one address header exactly, is that the right one? */
+                               header = procheader_parse_header(buf);
+                               if (!header ||
+                                               !procheader_headername_equal(header->name, matcher->header))
+                                       return FALSE;
+                               address_list = address_list_append(address_list, header->body);
+                               if (address_list == NULL)
+                                       return FALSE;
+
+                       } else {
+                               header = procheader_parse_header(buf);
+                               if (!header)
+                                       return FALSE;
+                               /* address header is one of the headers we have to match when checking
+                                  for any address header or all address headers? */
+                               if (procheader_headername_equal(header->name, "From") ||
+                                        procheader_headername_equal(header->name, "To") ||
+                                        procheader_headername_equal(header->name, "Cc") ||
+                                        procheader_headername_equal(header->name, "Reply-To") ||
+                                        procheader_headername_equal(header->name, "Sender"))
+                                       address_list = address_list_append(address_list, header->body);
+                               if (address_list == NULL)
+                                       return FALSE;
+                       }
+
+                       found = match_with_addresses_in_addressbook
+                                                       (matcher, address_list, matcher->criteria,
+                                                        matcher->expr, match);
+                       g_slist_free(address_list);
+
+                       if (matcher->criteria == MATCHCRITERIA_NOT_FOUND_IN_ADDRESSBOOK)
+                               return !found;
+                       else
+                               return found;
+       }
        }
+
        return FALSE;
 }
 
@@ -739,6 +1336,8 @@ static gboolean matcherprop_criteria_headers(const MatcherProp *matcher)
        case MATCHCRITERIA_NOT_HEADER:
        case MATCHCRITERIA_HEADERS_PART:
        case MATCHCRITERIA_NOT_HEADERS_PART:
+       case MATCHCRITERIA_FOUND_IN_ADDRESSBOOK:
+       case MATCHCRITERIA_NOT_FOUND_IN_ADDRESSBOOK:
                return TRUE;
        default:
                return FALSE;
@@ -784,14 +1383,46 @@ static gboolean matcherlist_match_headers(MatcherList *matchers, FILE *fp)
        while (procheader_get_one_field(buf, sizeof(buf), fp, NULL) != -1) {
                for (l = matchers->matchers ; l != NULL ; l = g_slist_next(l)) {
                        MatcherProp *matcher = (MatcherProp *) l->data;
+                       gint match = MATCH_ANY;
 
                        if (matcher->done)
                                continue;
 
-                       /* if the criteria is ~headers_part or ~message, ZERO lines
-                        * must NOT match for the rule to match. */
+                       /* determine the match range (all, any are our concern here) */
                        if (matcher->criteria == MATCHCRITERIA_NOT_HEADERS_PART ||
                            matcher->criteria == MATCHCRITERIA_NOT_MESSAGE) {
+                               match = MATCH_ALL;
+
+                       } else if (matcher->criteria == MATCHCRITERIA_FOUND_IN_ADDRESSBOOK ||
+                                          matcher->criteria == MATCHCRITERIA_NOT_FOUND_IN_ADDRESSBOOK) {
+                               Header *header = NULL;
+
+                               /* address header is one of the headers we have to match when checking
+                                  for any address header or all address headers? */
+                               header = procheader_parse_header(buf);
+                               if (header &&
+                                       (procheader_headername_equal(header->name, "From") ||
+                                        procheader_headername_equal(header->name, "To") ||
+                                        procheader_headername_equal(header->name, "Cc") ||
+                                        procheader_headername_equal(header->name, "Reply-To") ||
+                                        procheader_headername_equal(header->name, "Sender"))) {
+
+                                       if (strcasecmp(matcher->header, "Any") == 0)
+                                               match = MATCH_ANY;
+                                       else if (strcasecmp(matcher->header, "All") == 0)
+                                               match = MATCH_ALL;
+                                       else
+                                               match = MATCH_ONE;
+                               } else {
+                                       /* further call to matcherprop_match_one_header() can't match
+                                          and it irrelevant, so: don't alter the match result */
+                                       continue;
+                               }
+                       }
+
+                       /* ZERO line must NOT match for the rule to match.
+                        */
+                       if (match == MATCH_ALL) {
                                if (matcherprop_match_one_header(matcher, buf)) {
                                        matcher->result = TRUE;
                                } else {
@@ -801,7 +1432,7 @@ static gboolean matcherlist_match_headers(MatcherList *matchers, FILE *fp)
                        /* else, just one line matching is enough for the rule to match
                         */
                        } else if (matcherprop_criteria_headers(matcher) ||
-                                  matcherprop_criteria_message(matcher)){
+                                  matcherprop_criteria_message(matcher)) {
                                if (matcherprop_match_one_header(matcher, buf)) {
                                        matcher->result = TRUE;
                                        matcher->done = TRUE;
@@ -816,6 +1447,7 @@ static gboolean matcherlist_match_headers(MatcherList *matchers, FILE *fp)
                        }
                }
        }
+
        return FALSE;
 }
 
@@ -851,10 +1483,10 @@ static gboolean matcherprop_match_line(MatcherProp *matcher, const gchar *line)
        switch (matcher->criteria) {
        case MATCHCRITERIA_BODY_PART:
        case MATCHCRITERIA_MESSAGE:
-               return matcherprop_string_decode_match(matcher, line);
+               return matcherprop_string_decode_match(matcher, line, _("body line"));
        case MATCHCRITERIA_NOT_BODY_PART:
        case MATCHCRITERIA_NOT_MESSAGE:
-               return !matcherprop_string_decode_match(matcher, line);
+               return !matcherprop_string_decode_match(matcher, line, _("body line"));
        }
        return FALSE;
 }
@@ -919,7 +1551,7 @@ static gboolean matcherlist_match_body(MatcherList *matchers, FILE *fp)
  *
  *\return      gboolean TRUE if matched
  */
-gboolean matcherlist_match_file(MatcherList *matchers, MsgInfo *info,
+static gboolean matcherlist_match_file(MatcherList *matchers, MsgInfo *info,
                                gboolean result)
 {
        gboolean read_headers;
@@ -1028,6 +1660,12 @@ gboolean matcherlist_match(MatcherList *matchers, MsgInfo *info)
        for (l = matchers->matchers; l != NULL ;l = g_slist_next(l)) {
                MatcherProp *matcher = (MatcherProp *) l->data;
 
+               if (debug_filtering_session) {
+                       gchar *buf = matcherprop_to_string(matcher);
+                       log_print(LOG_DEBUG_FILTERING, _("checking if message matches [ %s ]\n"), buf);
+                       g_free(buf);
+               }
+
                switch(matcher->criteria) {
                case MATCHCRITERIA_ALL:
                case MATCHCRITERIA_UNREAD:
@@ -1044,10 +1682,14 @@ gboolean matcherlist_match(MatcherList *matchers, MsgInfo *info)
                case MATCHCRITERIA_NOT_FORWARDED:
                case MATCHCRITERIA_LOCKED:
                case MATCHCRITERIA_NOT_LOCKED:
+               case MATCHCRITERIA_SPAM:
+               case MATCHCRITERIA_NOT_SPAM:
                case MATCHCRITERIA_COLORLABEL:
                case MATCHCRITERIA_NOT_COLORLABEL:
                case MATCHCRITERIA_IGNORE_THREAD:
                case MATCHCRITERIA_NOT_IGNORE_THREAD:
+               case MATCHCRITERIA_WATCH_THREAD:
+               case MATCHCRITERIA_NOT_WATCH_THREAD:
                case MATCHCRITERIA_SUBJECT:
                case MATCHCRITERIA_NOT_SUBJECT:
                case MATCHCRITERIA_FROM:
@@ -1058,6 +1700,10 @@ gboolean matcherlist_match(MatcherList *matchers, MsgInfo *info)
                case MATCHCRITERIA_NOT_CC:
                case MATCHCRITERIA_TO_OR_CC:
                case MATCHCRITERIA_NOT_TO_AND_NOT_CC:
+               case MATCHCRITERIA_TAG:
+               case MATCHCRITERIA_NOT_TAG:
+               case MATCHCRITERIA_TAGGED:
+               case MATCHCRITERIA_NOT_TAGGED:
                case MATCHCRITERIA_AGE_GREATER:
                case MATCHCRITERIA_AGE_LOWER:
                case MATCHCRITERIA_NEWSGROUPS:
@@ -1078,11 +1724,15 @@ gboolean matcherlist_match(MatcherList *matchers, MsgInfo *info)
                case MATCHCRITERIA_NOT_PARTIAL:
                        if (matcherprop_match(matcher, info)) {
                                if (!matchers->bool_and) {
+                                       if (debug_filtering_session)
+                                               log_status_ok(LOG_DEBUG_FILTERING, _("message matches\n"));
                                        return TRUE;
                                }
                        }
                        else {
                                if (matchers->bool_and) {
+                                       if (debug_filtering_session)
+                                               log_status_nok(LOG_DEBUG_FILTERING, _("message does not match\n"));
                                        return FALSE;
                                }
                        }
@@ -1092,14 +1742,25 @@ gboolean matcherlist_match(MatcherList *matchers, MsgInfo *info)
        /* test the condition on the file */
 
        if (matcherlist_match_file(matchers, info, result)) {
-               if (!matchers->bool_and)
+               if (!matchers->bool_and) {
+                       if (debug_filtering_session)
+                               log_status_ok(LOG_DEBUG_FILTERING, _("message matches\n"));
                        return TRUE;
-       }
-       else {
-               if (matchers->bool_and)
+               }
+       } else {
+               if (matchers->bool_and) {
+                       if (debug_filtering_session)
+                               log_status_nok(LOG_DEBUG_FILTERING, _("message does not match\n"));
                        return FALSE;
+               }
        }
 
+       if (debug_filtering_session) {
+               if (result)
+                       log_status_ok(LOG_DEBUG_FILTERING, _("message matches\n"));
+               else
+                       log_status_nok(LOG_DEBUG_FILTERING, _("message does not match\n"));
+       }
        return result;
 }
 
@@ -1179,6 +1840,7 @@ gchar *matcherprop_to_string(MatcherProp *matcher)
        const gchar *matchtype_str;
        int i;
        gchar * quoted_expr;
+       gchar * quoted_header;
        
        criteria_str = NULL;
        for (i = 0; i < (int) (sizeof(matchparser_tab) / sizeof(MatchParser)); i++) {
@@ -1215,10 +1877,16 @@ gchar *matcherprop_to_string(MatcherProp *matcher)
        case MATCHCRITERIA_NOT_FORWARDED:
        case MATCHCRITERIA_LOCKED:
        case MATCHCRITERIA_NOT_LOCKED:
+       case MATCHCRITERIA_SPAM:
+       case MATCHCRITERIA_NOT_SPAM:
        case MATCHCRITERIA_PARTIAL:
        case MATCHCRITERIA_NOT_PARTIAL:
        case MATCHCRITERIA_IGNORE_THREAD:
        case MATCHCRITERIA_NOT_IGNORE_THREAD:
+       case MATCHCRITERIA_WATCH_THREAD:
+       case MATCHCRITERIA_NOT_WATCH_THREAD:
+       case MATCHCRITERIA_TAGGED:
+       case MATCHCRITERIA_NOT_TAGGED:
                return g_strdup(criteria_str);
        case MATCHCRITERIA_TEST:
        case MATCHCRITERIA_NOT_TEST:
@@ -1227,6 +1895,15 @@ gchar *matcherprop_to_string(MatcherProp *matcher)
                                              criteria_str, quoted_expr);
                g_free(quoted_expr);
                 return matcher_str;
+       case MATCHCRITERIA_FOUND_IN_ADDRESSBOOK:
+       case MATCHCRITERIA_NOT_FOUND_IN_ADDRESSBOOK:
+               quoted_header = matcher_quote_str(matcher->header);
+               quoted_expr = matcher_quote_str(matcher->expr);
+               matcher_str = g_strdup_printf("%s \"%s\" in \"%s\"",
+                                             criteria_str, quoted_header, quoted_expr);
+               g_free(quoted_header);
+               g_free(quoted_expr);
+               return matcher_str;
        }
 
        matchtype_str = NULL;
@@ -1243,12 +1920,8 @@ gchar *matcherprop_to_string(MatcherProp *matcher)
        case MATCHTYPE_MATCHCASE:
        case MATCHTYPE_REGEXP:
        case MATCHTYPE_REGEXPCASE:
-       case MATCHTYPE_ALL_IN_ADDRESSBOOK:
-       case MATCHTYPE_ANY_IN_ADDRESSBOOK:
                quoted_expr = matcher_quote_str(matcher->expr);
                if (matcher->header) {
-                       gchar * quoted_header;
-                       
                        quoted_header = matcher_quote_str(matcher->header);
                        matcher_str = g_strdup_printf
                                        ("%s \"%s\" %s \"%s\"",
@@ -1485,14 +2158,14 @@ gchar *matching_build_command(const gchar *cmd, MsgInfo *info)
  *\param       fp File
  *\param       prefs_filtering List of filtering conditions
  */
-static void prefs_filtering_write(FILE *fp, GSList *prefs_filtering)
+static int prefs_filtering_write(FILE *fp, GSList *prefs_filtering)
 {
-       GSList *cur;
+       GSList *cur = NULL;
 
        for (cur = prefs_filtering; cur != NULL; cur = cur->next) {
-               gchar *filtering_str;
+               gchar *filtering_str = NULL;
                gchar *tmp_name = NULL;
-               FilteringProp *prop;
+               FilteringProp *prop = NULL;
 
                if (NULL == (prop = (FilteringProp *) cur->data))
                        continue;
@@ -1502,50 +2175,74 @@ static void prefs_filtering_write(FILE *fp, GSList *prefs_filtering)
 
                if (prop->enabled) {
                        if (fputs("enabled ", fp) == EOF) {
-                               FILE_OP_ERROR("filtering config", "fputs || fputc");
-                               return;
+                               FILE_OP_ERROR("filtering config", "fputs");
+                               return -1;
                        }
                } else {
                        if (fputs("disabled ", fp) == EOF) {
-                               FILE_OP_ERROR("filtering config", "fputs || fputc");
-                               return;
+                               FILE_OP_ERROR("filtering config", "fputs");
+                               return -1;
                        }
                }
 
                if (fputs("rulename \"", fp) == EOF) {
-                       FILE_OP_ERROR("filtering config", "fputs || fputc");
+                       FILE_OP_ERROR("filtering config", "fputs");
                        g_free(filtering_str);
-                       return;
+                       return -1;
                }
                tmp_name = prop->name;
                while (tmp_name && *tmp_name != '\0') {
                        if (*tmp_name != '"') {
                                if (fputc(*tmp_name, fp) == EOF) {
-                                       FILE_OP_ERROR("filtering config", "fputc");
+                                       FILE_OP_ERROR("filtering config", "fputs || fputc");
                                        g_free(filtering_str);
-                                       return;
+                                       return -1;
                                }
                        } else if (*tmp_name == '"') {
                                if (fputc('\\', fp) == EOF ||
                                    fputc('"', fp) == EOF) {
-                                       FILE_OP_ERROR("filtering config", "fputc");
+                                       FILE_OP_ERROR("filtering config", "fputs || fputc");
                                        g_free(filtering_str);
-                                       return;
+                                       return -1;
                                }
                        }
                        tmp_name ++;
                }
-               if(fputs("\" ", fp) == EOF ||
-                   fputs(filtering_str, fp) == EOF ||
+               if (fputs("\" ", fp) == EOF) {
+                       FILE_OP_ERROR("filtering config", "fputs");
+                       g_free(filtering_str);
+                       return -1;
+               }
+
+               if (prop->account_id != 0) {
+                       gchar *tmp = NULL;
+
+                       tmp = g_strdup_printf("account %d ", prop->account_id);
+                       if (fputs(tmp, fp) == EOF) {
+                               FILE_OP_ERROR("filtering config", "fputs");
+                               g_free(tmp);
+                               return -1;
+                       }
+                       g_free(tmp);
+               }
+
+               if(fputs(filtering_str, fp) == EOF ||
                    fputc('\n', fp) == EOF) {
                        FILE_OP_ERROR("filtering config", "fputs || fputc");
                        g_free(filtering_str);
-                       return;
+                       return -1;
                }
                g_free(filtering_str);
        }
+       
+       return 0;
 }
 
+typedef struct _NodeLoopData {
+       FILE *fp;
+       gboolean error;
+} NodeLoopData;
+
 /*!
  *\brief       Write matchers from a folder item
  *
@@ -1554,10 +2251,10 @@ static void prefs_filtering_write(FILE *fp, GSList *prefs_filtering)
  *
  *\return      gboolean FALSE
  */
-static gboolean prefs_matcher_write_func(GNode *node, gpointer data)
+static gboolean prefs_matcher_write_func(GNode *node, gpointer d)
 {
        FolderItem *item;
-       FILE *fp = data;
+       NodeLoopData *data = (NodeLoopData *)d;
        gchar *id;
        GSList *prefs_filtering;
 
@@ -1571,11 +2268,20 @@ static gboolean prefs_matcher_write_func(GNode *node, gpointer data)
         prefs_filtering = item->prefs->processing;
 
        if (prefs_filtering != NULL) {
-               fprintf(fp, "[%s]\n", id);
-               prefs_filtering_write(fp, prefs_filtering);
-               fputc('\n', fp);
+               if (fprintf(data->fp, "[%s]\n", id) < 0) {
+                       data->error = TRUE;
+                       goto fail;
+               }
+               if (prefs_filtering_write(data->fp, prefs_filtering) < 0) {
+                       data->error = TRUE;
+                       goto fail;
+               }
+               if (fputc('\n', data->fp) == EOF) {
+                       data->error = TRUE;
+                       goto fail;
+               }
        }
-
+fail:
        g_free(id);
 
        return FALSE;
@@ -1586,32 +2292,44 @@ static gboolean prefs_matcher_write_func(GNode *node, gpointer data)
  *
  *\param       fp File
  */
-static void prefs_matcher_save(FILE *fp)
+static int prefs_matcher_save(FILE *fp)
 {
        GList *cur;
+       NodeLoopData data;
+       
+       data.fp = fp;
+       data.error = FALSE;
 
        for (cur = folder_get_list() ; cur != NULL ; cur = g_list_next(cur)) {
                Folder *folder;
 
                folder = (Folder *) cur->data;
                g_node_traverse(folder->node, G_PRE_ORDER, G_TRAVERSE_ALL, -1,
-                               prefs_matcher_write_func, fp);
+                               prefs_matcher_write_func, &data);
        }
         
+       if (data.error == TRUE)
+               return -1;
+
         /* pre global rules */
-        fprintf(fp, "[preglobal]\n");
-        prefs_filtering_write(fp, pre_global_processing);
-        fputc('\n', fp);
+        if (fprintf(fp, "[preglobal]\n") < 0 ||
+            prefs_filtering_write(fp, pre_global_processing) < 0 ||
+            fputc('\n', fp) == EOF)
+               return -1;
 
         /* post global rules */
-        fprintf(fp, "[postglobal]\n");
-        prefs_filtering_write(fp, post_global_processing);
-        fputc('\n', fp);
+        if (fprintf(fp, "[postglobal]\n") < 0 ||
+            prefs_filtering_write(fp, post_global_processing) < 0 ||
+            fputc('\n', fp) == EOF)
+               return -1;
         
         /* filtering rules */
-        fprintf(fp, "[filtering]\n");
-        prefs_filtering_write(fp, filtering_rules);
-        fputc('\n', fp);
+       if (fprintf(fp, "[filtering]\n") < 0 ||
+            prefs_filtering_write(fp, filtering_rules) < 0 ||
+            fputc('\n', fp) == EOF)
+               return -1;
+
+       return 0;
 }
 
 /*!
@@ -1633,26 +2351,25 @@ void prefs_matcher_write_config(void)
                return;
        }
 
-
-       prefs_matcher_save(pfile->fp);
-
        g_free(rcpath);
 
-       if (prefs_file_close(pfile) < 0) {
+       if (prefs_matcher_save(pfile->fp) < 0) {
                g_warning("failed to write configuration to file\n");
-               return;
+               prefs_file_close_revert(pfile);
+       } else if (prefs_file_close(pfile) < 0) {
+               g_warning("failed to save configuration to file\n");
        }
 }
 
 /* ******************************************************************* */
 
-void matcher_add_rulenames(const gchar *rcpath)
+static void matcher_add_rulenames(const gchar *rcpath)
 {
        gchar *newpath = g_strconcat(rcpath, ".new", NULL);
        FILE *src = g_fopen(rcpath, "rb");
        FILE *dst = g_fopen(newpath, "wb");
        gchar buf[BUFFSIZE];
-
+       int r;
        if (dst == NULL) {
                perror("fopen");
                g_free(newpath);
@@ -1661,11 +2378,13 @@ void matcher_add_rulenames(const gchar *rcpath)
 
        while (fgets (buf, sizeof(buf), src) != NULL) {
                if (strlen(buf) > 2 && buf[0] != '['
-               && strncmp(buf, "rulename \"", 10)) {
-                       fwrite("rulename \"\" ",
-                               strlen("rulename \"\" "), 1, dst);
+               && strncmp(buf, "rulename \"", 10)
+               && strncmp(buf, "enabled rulename \"", 18)
+               && strncmp(buf, "disabled rulename \"", 18)) {
+                       r = fwrite("enabled rulename \"\" ",
+                               strlen("enabled rulename \"\" "), 1, dst);
                }
-               fwrite(buf, strlen(buf), 1, dst);
+               r = fwrite(buf, strlen(buf), 1, dst);
        }
        fclose(dst);
        fclose(src);
@@ -1707,9 +2426,9 @@ void prefs_matcher_read_config(void)
                fclose(matcher_parserin);
        }
        else {
-               /* previous version compatibily */
+               /* previous version compatibility */
 
-               /* printf("reading filtering\n"); */
+               /* g_print("reading filtering\n"); */
                rcpath = g_strconcat(get_rc_dir(), G_DIR_SEPARATOR_S,
                                     FILTERING_RC, NULL);
                f = g_fopen(rcpath, "rb");
@@ -1720,7 +2439,7 @@ void prefs_matcher_read_config(void)
                        fclose(matcher_parserin);
                }
                
-               /* printf("reading scoring\n"); */
+               /* g_print("reading scoring\n"); */
                rcpath = g_strconcat(get_rc_dir(), G_DIR_SEPARATOR_S,
                                     SCORING_RC, NULL);
                f = g_fopen(rcpath, "rb");