more sanitizing of translatable strings
[claws.git] / src / main.c
index 451eac97b3e9b59b4e805453b60f36845aa5628d..9368487f8945af91fb574cc801d80f841565a134 100644 (file)
@@ -1,6 +1,6 @@
 /*
- * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2013 Hiroyuki Yamamoto and the Claws Mail team
+ * Claws Mail -- a GTK+ based, lightweight, and fast e-mail client
+ * Copyright (C) 1999-2015 Hiroyuki Yamamoto and the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -14,7 +14,7 @@
  *
  * You should have received a copy of the GNU General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
- * 
+ *
  */
 
 #ifdef HAVE_CONFIG_H
@@ -49,6 +49,7 @@
 #include <sys/file.h>
 #endif
 
+#include "file_checker.h"
 #include "wizard.h"
 #ifdef HAVE_STARTUP_NOTIFICATION
 # define SN_API_NOT_YET_FROZEN
 #include "menu.h"
 #include "quicksearch.h"
 #include "advsearch.h"
+#include "avatars.h"
 
 #ifdef HAVE_LIBETPAN
 #include "imap-thread.h"
@@ -627,7 +629,7 @@ static void sc_session_manager_connect(MainWindow *mainwin)
                                256, error_string_ret);
 
                if (error_string_ret[0] || mainwin->smc_conn == NULL)
-                       g_warning ("While connecting to session manager:\n%s.",
+                       g_warning ("While connecting to session manager: %s.",
                                error_string_ret);
                else {
                        SmPropValue *vals;
@@ -641,6 +643,8 @@ static void sc_session_manager_connect(MainWindow *mainwin)
                        vals[0].length = strlen(g_get_user_name()?g_get_user_name():"");
                        vals[0].value = g_strdup(g_get_user_name()?g_get_user_name():"");
                        sc_client_set_value (mainwin, SmUserID, SmARRAY8, 1, vals);
+
+                       g_free(vals);
                }
        }
 }
@@ -790,21 +794,21 @@ static void main_dump_features_list(gboolean show_debug_only)
 #endif
 #if USE_ENCHANT
        if (show_debug_only)
-               debug_print(" aspell\n");
+               debug_print(" Enchant\n");
        else
-               g_print(" aspell\n");
+               g_print(" Enchant\n");
 #endif
 #if USE_GNUTLS
        if (show_debug_only)
-               debug_print(" gnutls\n");
+               debug_print(" GnuTLS\n");
        else
-               g_print(" gnutls\n");
+               g_print(" GnuTLS\n");
 #endif
 #if INET6
        if (show_debug_only)
-               debug_print(" ipv6\n");
+               debug_print(" IPv6\n");
        else
-               g_print(" ipv6\n");
+               g_print(" IPv6\n");
 #endif
 #if HAVE_ICONV
        if (show_debug_only)
@@ -814,15 +818,15 @@ static void main_dump_features_list(gboolean show_debug_only)
 #endif
 #if USE_JPILOT
        if (show_debug_only)
-               debug_print(" jpilot\n");
+               debug_print(" JPilot\n");
        else
-               g_print(" jpilot\n");
+               g_print(" JPilot\n");
 #endif
 #if USE_LDAP
        if (show_debug_only)
-               debug_print(" ldap\n");
+               debug_print(" LDAP\n");
        else
-               g_print(" ldap\n");
+               g_print(" LDAP\n");
 #endif
 #if HAVE_LIBETPAN
        if (show_debug_only)
@@ -832,9 +836,9 @@ static void main_dump_features_list(gboolean show_debug_only)
 #endif
 #if HAVE_LIBSM
        if (show_debug_only)
-               debug_print(" libsm\n");
+               debug_print(" libSM\n");
        else
-               g_print(" libsm\n");
+               g_print(" libSM\n");
 #endif
 #if HAVE_NETWORKMANAGER_SUPPORT
        if (show_debug_only)
@@ -930,14 +934,14 @@ static void install_dbus_status_handler(void)
                        "com.google.code.Awn");
        dbus_item_hook_id = hooks_register_hook (FOLDER_ITEM_UPDATE_HOOKLIST, dbus_status_update_item_hook, NULL);
        if (dbus_item_hook_id == -1) {
-               g_warning(_("Failed to register folder item update hook"));
+               g_warning("Failed to register folder item update hook");
                uninstall_dbus_status_handler();
                return;
        }
 
        dbus_folder_hook_id = hooks_register_hook (FOLDER_UPDATE_HOOKLIST, dbus_status_update_folder_hook, NULL);
        if (dbus_folder_hook_id == -1) {
-               g_warning(_("Failed to register folder update hook"));
+               g_warning("Failed to register folder update hook");
                uninstall_dbus_status_handler();
                return;
        }
@@ -953,7 +957,7 @@ static void reset_statistics(void)
        session_stats.forwarded = 0;
        session_stats.time_started = time(NULL);
 }
-               
+
 int main(int argc, char *argv[])
 {
 #ifdef HAVE_DBUS_GLIB
@@ -1056,6 +1060,10 @@ int main(int argc, char *argv[])
                        "gtk-theme-name",
                        "MS-Windows",
                        "XProperty");
+       gtk_settings_set_long_property(gtk_settings_get_default(),
+                       "gtk-auto-mnemonics",
+                       TRUE,
+                       "XProperty");
 #endif
 
 #ifdef HAVE_NETWORKMANAGER_SUPPORT
@@ -1125,13 +1133,16 @@ int main(int argc, char *argv[])
                 * and migration succeeded, and FALSE otherwise.
                 */
                if (is_dir_exist(OLD_GTK2_RC_DIR)) {
-                       r = migrate_old_config(OLD_GTK2_RC_DIR, RC_DIR, _("Sylpheed-Claws 2.6.0 (or older)"));
+                       r = migrate_old_config(OLD_GTK2_RC_DIR, RC_DIR,
+                                              g_strconcat("Sylpheed-Claws 2.6.0 ", _("(or older)"), NULL));
                        asked_for_migration = TRUE;
                } else if (is_dir_exist(OLDER_GTK2_RC_DIR)) {
-                       r = migrate_old_config(OLDER_GTK2_RC_DIR, RC_DIR, _("Sylpheed-Claws 1.9.15 (or older)"));
+                       r = migrate_old_config(OLDER_GTK2_RC_DIR, RC_DIR,
+                                              g_strconcat("Sylpheed-Claws 1.9.15 ",_("(or older)"), NULL));
                        asked_for_migration = TRUE;
                } else if (is_dir_exist(OLD_GTK1_RC_DIR)) {
-                       r = migrate_old_config(OLD_GTK1_RC_DIR, RC_DIR, _("Sylpheed-Claws 1.0.5 (or older)"));
+                       r = migrate_old_config(OLD_GTK1_RC_DIR, RC_DIR,
+                                              g_strconcat("Sylpheed-Claws 1.0.5 ",_("(or older)"), NULL));
                        asked_for_migration = TRUE;
                } else if (is_dir_exist(SYLPHEED_RC_DIR)) {
                        r = migrate_old_config(SYLPHEED_RC_DIR, RC_DIR, "Sylpheed");
@@ -1277,6 +1288,9 @@ int main(int argc, char *argv[])
 
        mainwin = main_window_create();
 
+       if (!check_file_integrity())
+               exit(1);
+
 #ifdef HAVE_NETWORKMANAGER_SUPPORT
        networkmanager_state_change_cb(nm_proxy,NULL,mainwin);
 #endif
@@ -1399,6 +1413,7 @@ int main(int argc, char *argv[])
 
        claws_register_idle_function(claws_gtk_idle);
 
+       avatars_init();
        prefs_toolbar_init();
 
        num_folder_class = g_list_length(folder_get_list());
@@ -1596,9 +1611,15 @@ static void exit_claws(MainWindow *mainwin)
        if(mainwin->folderview->opened) {
                FolderItem *item;
 
-               item = gtk_cmctree_node_get_row_data(GTK_CMCTREE(mainwin->folderview->ctree), mainwin->folderview->opened);
-               summary_save_prefs_to_folderitem(mainwin->folderview->summaryview, item);
-               prefs_common.last_opened_folder = folder_item_get_identifier(item);
+               item = gtk_cmctree_node_get_row_data(
+                       GTK_CMCTREE(mainwin->folderview->ctree),
+                       mainwin->folderview->opened);
+               if (item) {
+                       summary_save_prefs_to_folderitem(
+                               mainwin->folderview->summaryview, item);
+                       prefs_common.last_opened_folder = 
+                               folder_item_get_identifier(item);
+               }
        }
 
        /* save all state before exiting */
@@ -1651,6 +1672,7 @@ static void exit_claws(MainWindow *mainwin)
 
        matcher_done();
        prefs_toolbar_done();
+       avatars_done();
 
 #ifndef USE_NEW_ADDRBOOK
        addressbook_destroy();
@@ -1735,11 +1757,7 @@ static GString * parse_cmd_compose_from_file(const gchar *fn)
                        g_string_append_c(headers, '&');
                        g_string_append(headers, tmp);
                        g_string_append_c(headers, '=');
-#if GLIB_CHECK_VERSION(2,16,0)
                        g_string_append_uri_escaped(headers, v, NULL, TRUE);
-#else
-                       G_STRING_APPEND_ENCODED_URI(headers, v);
-#endif 
                }
                g_free(tmp);
        }
@@ -1749,11 +1767,7 @@ static GString * parse_cmd_compose_from_file(const gchar *fn)
        g_free(to);
        g_string_append(body, "?body=");
        while (fgets(fb, sizeof(fb), fp)) {
-#if GLIB_CHECK_VERSION(2,16,0)
                g_string_append_uri_escaped(body, fb, NULL, TRUE);
-#else
-               G_STRING_APPEND_ENCODED_URI(body, fb);
-#endif
        }
        if (!isstdin)
                fclose(fp);
@@ -2017,7 +2031,7 @@ static void initial_processing(FolderItem *item, gpointer data)
 
 static gboolean draft_all_messages(void)
 {
-       GList *compose_list = NULL;
+       const GList *compose_list = NULL;
        
        compose_clear_exit_drafts();
        compose_list = compose_get_compose_list();
@@ -2125,11 +2139,13 @@ gboolean claws_is_starting(void)
 gchar *claws_get_socket_name(void)
 {
        static gchar *filename = NULL;
-       const gchar *socket_dir = NULL;
+       gchar *socket_dir = NULL;
        gchar md5sum[33];
 
        if (filename == NULL) {
-               struct stat st;
+               GStatBuf st;
+               gint stat_ok;
+
                socket_dir = g_strdup_printf("%s%cclaws-mail-%d",
                                           g_get_tmp_dir(), G_DIR_SEPARATOR,
 #if HAVE_GETUID
@@ -2137,10 +2153,11 @@ gchar *claws_get_socket_name(void)
 #else
                                           0);
 #endif
-               if (stat(socket_dir, &st) < 0 && errno != ENOENT) {
+               stat_ok = g_stat(socket_dir, &st);
+               if (stat_ok < 0 && errno != ENOENT) {
                        g_print("Error stat'ing socket_dir %s: %s\n",
-                               socket_dir, strerror(errno));
-               } else if (S_ISSOCK(st.st_mode)) {
+                               socket_dir, g_strerror(errno));
+               } else if (stat_ok == 0 && S_ISSOCK(st.st_mode)) {
                        /* old versions used a sock in $TMPDIR/claws-mail-$UID */
                        debug_print("Using legacy socket %s\n", socket_dir);
                        filename = g_strdup(socket_dir);
@@ -2149,13 +2166,14 @@ gchar *claws_get_socket_name(void)
 
                if (!is_dir_exist(socket_dir) && make_dir(socket_dir) < 0) {
                        g_print("Error creating socket_dir %s: %s\n",
-                               socket_dir, strerror(errno));
+                               socket_dir, g_strerror(errno));
                }
 
                md5_hex_digest(md5sum, get_rc_dir());
 
                filename = g_strdup_printf("%s%c%s", socket_dir, G_DIR_SEPARATOR,
                                           md5sum);
+               g_free(socket_dir);
                debug_print("Using control socket %s\n", filename);
        }
 
@@ -2190,10 +2208,10 @@ static gint prohibit_duplicate_launch(void)
                x_display = g_strdup(g_getenv("DISPLAY"));
 
        if (uxsock < 0) {
+               gint ret;
 #if HAVE_FLOCK
                gchar *socket_lock;
                gint lock_fd;
-               gint ret;
                /* If connect failed, no other process is running.
                 * Unlink the potentially existing socket, then
                 * open it. This has to be done locking a temporary
@@ -2206,13 +2224,13 @@ static gint prohibit_duplicate_launch(void)
                lock_fd = g_open(socket_lock, O_RDWR|O_CREAT, 0);
                if (lock_fd < 0) {
                        debug_print("Couldn't open %s: %s (%d)\n", socket_lock,
-                               strerror(errno), errno);
+                               g_strerror(errno), errno);
                        g_free(socket_lock);
                        return -1;
                }
                if (flock(lock_fd, LOCK_EX) < 0) {
                        debug_print("Couldn't lock %s: %s (%d)\n", socket_lock,
-                               strerror(errno), errno);
+                               g_strerror(errno), errno);
                        close(lock_fd);
                        g_free(socket_lock);
                        return -1;
@@ -2224,6 +2242,7 @@ static gint prohibit_duplicate_launch(void)
                ret = fd_open_unix(path);
 #if HAVE_FLOCK
                flock(lock_fd, LOCK_UN);
+               close(lock_fd);
                claws_unlink(socket_lock);
                g_free(socket_lock);
 #endif
@@ -2323,7 +2342,8 @@ static gint prohibit_duplicate_launch(void)
                }
                fd_write_all(uxsock, ".\n", 2);
                for (;;) {
-                       fd_gets(uxsock, buf, sizeof(buf));
+                       fd_gets(uxsock, buf, sizeof(buf) - 1);
+                       buf[sizeof(buf) - 1] = '\0';
                        if (!strncmp(buf, ".\n", 2)) break;
                        fputs(buf, stdout);
                }
@@ -2333,7 +2353,8 @@ static gint prohibit_duplicate_launch(void)
                gchar buf[BUFSIZ];
                fd_write(uxsock, "statistics\n", 11);
                for (;;) {
-                       fd_gets(uxsock, buf, sizeof(buf));
+                       fd_gets(uxsock, buf, sizeof(buf) - 1);
+                       buf[sizeof(buf) - 1] = '\0';
                        if (!strncmp(buf, ".\n", 2)) break;
                        fputs(buf, stdout);
                }
@@ -2352,7 +2373,8 @@ static gint prohibit_duplicate_launch(void)
                fd_write_all(uxsock, str, strlen(str));
                g_free(str);
                for (;;) {
-                       fd_gets(uxsock, buf, sizeof(buf));
+                       fd_gets(uxsock, buf, sizeof(buf) - 1);
+                       buf[sizeof(buf) - 1] = '\0';
                        if (!strncmp(buf, ".\n", 2)) break;
                        fputs(buf, stdout);
                }
@@ -2361,7 +2383,8 @@ static gint prohibit_duplicate_launch(void)
                gchar buf[BUFSIZ];
                fd_write_all(uxsock, "get_display\n", 12);
                memset(buf, 0, sizeof(buf));
-               fd_gets(uxsock, buf, sizeof(buf));
+               fd_gets(uxsock, buf, sizeof(buf) - 1);
+               buf[sizeof(buf) - 1] = '\0';
                if (strcmp2(buf, x_display)) {
                        g_print("Claws Mail is already running on display %s.\n",
                                buf);
@@ -2411,7 +2434,8 @@ static GPtrArray *get_folder_item_list(gint sock)
        GPtrArray *folders = NULL;
 
        for (;;) {
-               fd_gets(sock, buf, sizeof(buf));
+               fd_gets(sock, buf, sizeof(buf) - 1);
+               buf[sizeof(buf) - 1] = '\0';
                if (!strncmp(buf, ".\n", 2)) {
                        break;
                }
@@ -2423,7 +2447,7 @@ static GPtrArray *get_folder_item_list(gint sock)
                if (item) {
                        g_ptr_array_add(folders, item);
                } else {
-                       g_warning("no such folder: %s\n", buf);
+                       g_warning("no such folder: %s", buf);
                }
        }
 
@@ -2439,7 +2463,11 @@ static void lock_socket_input_cb(gpointer data,
        gchar buf[BUFFSIZE];
 
        sock = fd_accept(source);
-       fd_gets(sock, buf, sizeof(buf));
+       if (sock < 0)
+               return;
+
+       fd_gets(sock, buf, sizeof(buf) - 1);
+       buf[sizeof(buf) - 1] = '\0';
 
        if (!strncmp(buf, "popup", 5)) {
                main_window_popup(mainwin);
@@ -2461,7 +2489,8 @@ static void lock_socket_input_cb(gpointer data,
                gchar *mailto;
 
                mailto = g_strdup(buf + strlen("compose_attach") + 1);
-               while (fd_gets(sock, buf, sizeof(buf)) > 0) {
+               while (fd_gets(sock, buf, sizeof(buf) - 1) > 0) {
+                       buf[sizeof(buf) - 1] = '\0';
                        strretchomp(buf);
                        if (!strcmp2(buf, "."))
                                break;
@@ -2577,8 +2606,9 @@ static void lock_socket_input_cb(gpointer data,
                folder_name = g_strdup(buf+7);
                strretchomp(folder_name);
 
-               if (fd_gets(sock, buf, sizeof(buf)) <= 0) 
+               if (fd_gets(sock, buf, sizeof(buf) - 1) <= 0) 
                        goto search_exit;
+               buf[sizeof(buf) - 1] = '\0';
 
                switch (toupper(buf[0])) {
                case 'S': searchType = ADVANCED_SEARCH_SUBJECT; break;
@@ -2589,22 +2619,24 @@ static void lock_socket_input_cb(gpointer data,
                case 'E': searchType = ADVANCED_SEARCH_EXTENDED; break;
                }
 
-               if (fd_gets(sock, buf, sizeof(buf)) <= 0) 
+               if (fd_gets(sock, buf, sizeof(buf) - 1) <= 0) 
                        goto search_exit;
 
+               buf[sizeof(buf) - 1] = '\0';
                request = g_strdup(buf);
                strretchomp(request);
 
                recursive = TRUE;
-               if (fd_gets(sock, buf, sizeof(buf)) > 0)
+               if (fd_gets(sock, buf, sizeof(buf) - 1) > 0)
                        recursive = buf[0] != '0';
 
+               buf[sizeof(buf) - 1] = '\0';
+
                debug_print("search: %s %i %s %i\n", folder_name, searchType, request, recursive);
 
-               if (folder_name)
-                       folderItem = folder_find_item_from_identifier(folder_name);
+               folderItem = folder_find_item_from_identifier(folder_name);
 
-               if (folder_name && folderItem == NULL) {
+               if (folderItem == NULL) {
                        debug_print("Unknown folder item : '%s', searching folder\n",folder_name);
                        Folder* folder = folder_find_from_path(folder_name);
                        if (folder != NULL)
@@ -2761,7 +2793,7 @@ static void install_memory_sighandler()
        mem_notify_fd = g_open("/dev/mem_notify", O_RDONLY|O_NONBLOCK, 0);
        if (mem_notify_fd == -1) {
                debug_print("/dev/mem_notify not available (%s)\n", 
-                       strerror(errno));
+                       g_strerror(errno));
                return;
        }
        
@@ -2801,10 +2833,9 @@ static void networkmanager_state_change_cb(DBusGProxy *proxy, gchar *dev,
                return;
 
        if (mainWin) {
-               GError *error;
+               GError *error = NULL;
                gboolean online;
 
-               error = NULL;           
                online = networkmanager_is_online(&error);
                if(!error) {
                        if(online && went_offline_nm) {