Fix CID 1492329: use after free (proper fix for CID 1491230).

[claws.git] / src / ldapctrl.c

diff --git a/src/ldapctrl.c b/src/ldapctrl.c
index b296a2a4284aca02ebf47d9b3b7f6876506dd1ed..3bf8acecfba4352ae5ab9ed58cbf25b2f840d1af 100644 (file)
--- a/src/ldapctrl.c
+++ b/src/ldapctrl.c
@@ -575,7 +575,6 @@ gchar *ldapctl_format_criteria( LdapControl *ctl, const gchar *searchVal ) {
        }
 
        if( p2 == NULL ) {
-               g_free( p1 );
                /* Nothing processed - format a default attribute */
                retVal = g_strdup_printf( "(%s=*)", LDAPCTL_ATTR_EMAIL );
        }
@@ -583,6 +582,8 @@ gchar *ldapctl_format_criteria( LdapControl *ctl, const gchar *searchVal ) {
                /* We have something - free up previous result */
                retVal = p2;
        }
+       if (p1)
+               g_free( p1 );
        debug_print("current search string: %s\n", retVal);
        return retVal;
 }