Fix wrong time unit shown in offline-override dialog (IMAP), and
[claws.git] / src / inc.c
index 7d8162f5e8624d956c5defd534e31b165aaf9027..ed681fb3ab85c6200ca00dd611dfc4e518393447 100644 (file)
--- a/src/inc.c
+++ b/src/inc.c
@@ -1,10 +1,10 @@
 /*
- * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2006 Hiroyuki Yamamoto and the Sylpheed-Claws team
+ * Claws Mail -- a GTK+ based, lightweight, and fast e-mail client
+ * Copyright (C) 1999-2016 Hiroyuki Yamamoto and the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
+ * the Free Software Foundation; either version 3 of the License, or
  * (at your option) any later version.
  *
  * This program is distributed in the hope that it will be useful,
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
  */
 
 #ifdef HAVE_CONFIG_H
 #  include "config.h"
+#include "claws-features.h"
 #endif
 
 #include "defs.h"
 
 #include <glib.h>
 #include <glib/gi18n.h>
-#include <gtk/gtkmain.h>
-#include <gtk/gtkwindow.h>
-#include <gtk/gtksignal.h>
-#include <gtk/gtkprogressbar.h>
+#include <gtk/gtk.h>
 #include <stdio.h>
 #include <unistd.h>
 #include <string.h>
@@ -42,6 +39,7 @@
 #include "prefs_account.h"
 #include "account.h"
 #include "procmsg.h"
+#include "proxy.h"
 #include "socket.h"
 #include "ssl.h"
 #include "pop.h"
 #include "filtering.h"
 #include "log.h"
 #include "hooks.h"
+#include "logwindow.h"
+#include "passwordstore.h"
+
+extern SessionStats session_stats;
 
 static GList *inc_dialog_list = NULL;
 
-static guint inc_lock_count = 0;
+static time_t inc_offline_overridden_yes = 0;
+static time_t inc_offline_overridden_no  = 0;
+
+guint inc_lock_count = 0;
 
 static GdkPixbuf *currentpix;
 static GdkPixbuf *errorpix;
 static GdkPixbuf *okpix;
 
-#define MSGBUFSIZE     8192
+#define MESSAGEBUFSIZE 8192
 
+static void inc_update_stats(gint new_msgs);
 static void inc_finished               (MainWindow             *mainwin,
-                                        gboolean                new_messages);
+                                        gboolean                new_messages,
+                                        gboolean                autocheck);
 static gint inc_account_mail_real      (MainWindow             *mainwin,
                                         PrefsAccount           *account);
 
@@ -116,6 +123,8 @@ static gint inc_drop_message                (Pop3Session    *session,
 static void inc_put_error              (IncState        istate,
                                         Pop3Session    *session);
 
+static void inc_showlog_cb             (GtkWidget      *widget,
+                                        gpointer        data);
 static void inc_cancel_cb              (GtkWidget      *widget,
                                         gpointer        data);
 static gint inc_dialog_delete_cb       (GtkWidget      *widget,
@@ -123,16 +132,22 @@ static gint inc_dialog_delete_cb  (GtkWidget      *widget,
                                         gpointer        data);
 
 static gint get_spool                  (FolderItem     *dest,
-                                        const gchar    *mbox);
+                                        const gchar    *mbox,
+                                        PrefsAccount   *account);
 
 static gint inc_spool_account(PrefsAccount *account);
-static gint inc_all_spool(void);
 static void inc_autocheck_timer_set_interval   (guint           interval);
 static gint inc_autocheck_func                 (gpointer        data);
 
 static void inc_notify_cmd             (gint new_msgs, 
                                         gboolean notify);
-       
+
+static void inc_update_stats(gint new_msgs)
+{
+       /* update session statistics */
+       session_stats.received += new_msgs;
+}
+
 /**
  * inc_finished:
  * @mainwin: Main window.
@@ -142,22 +157,25 @@ static void inc_notify_cmd                (gint new_msgs,
  * messages.  If @new_messages is FALSE, this function avoids unneeded
  * updating.
  **/
-static void inc_finished(MainWindow *mainwin, gboolean new_messages)
+static void inc_finished(MainWindow *mainwin, gboolean new_messages, gboolean autocheck)
 {
-       FolderItem *item;
-
        if (prefs_common.scan_all_after_inc)
                folderview_check_new(NULL);
 
-       if (!new_messages && !prefs_common.scan_all_after_inc) return;
+       if (!autocheck && new_messages && prefs_common.open_inbox_on_inc) {
+               FolderItem *item = NULL;
+
+               if (cur_account && cur_account->inbox)
+                       item = folder_find_item_from_identifier(cur_account->inbox);
+               if (item == NULL && cur_account && cur_account->folder)
+                       item = cur_account->folder->inbox;
+               if (item == NULL)
+                       item = folder_get_default_inbox();
 
-       if (prefs_common.open_inbox_on_inc) {
-               item = cur_account && cur_account->inbox
-                       ? folder_find_item_from_identifier(cur_account->inbox)
-                       : folder_get_default_inbox();
                folderview_unselect(mainwin->folderview);
                folderview_select(mainwin->folderview, item);
        }
+       statusbar_progress_all(0,0,0);
 }
 
 void inc_mail(MainWindow *mainwin, gboolean notify)
@@ -168,8 +186,8 @@ void inc_mail(MainWindow *mainwin, gboolean notify)
        if (inc_lock_count) return;
 
        if (prefs_common.work_offline && 
-           !inc_offline_should_override(
-               _("Sylpheed-Claws needs network access in order "
+           !inc_offline_should_override(TRUE,
+               _("Claws Mail needs network access in order "
                  "to get mails.")))
                return;
 
@@ -179,9 +197,10 @@ void inc_mail(MainWindow *mainwin, gboolean notify)
 
        if (prefs_common.use_extinc && prefs_common.extinc_cmd) {
                /* external incorporating program */
-               if (execute_command_line(prefs_common.extinc_cmd, FALSE) < 0) {
+               if (execute_command_line(prefs_common.extinc_cmd, FALSE, NULL) < 0) {
                        main_window_unlock(mainwin);
                        inc_autocheck_timer_set();
+                       inc_unlock();
                        return;
                }
        } else {
@@ -190,7 +209,8 @@ void inc_mail(MainWindow *mainwin, gboolean notify)
                        new_msgs += account_new_msgs;
        }
 
-       inc_finished(mainwin, new_msgs > 0);
+       inc_update_stats(new_msgs);
+       inc_finished(mainwin, new_msgs > 0, FALSE);
        main_window_unlock(mainwin);
        inc_notify_cmd(new_msgs, notify);
        inc_autocheck_timer_set();
@@ -240,7 +260,6 @@ static gint inc_account_mail_real(MainWindow *mainwin, PrefsAccount *account)
                folderview_check_new(FOLDER(account->folder));
                return 0;
        case A_POP3:
-       case A_APOP:
                session = inc_session_new(account);
                if (!session) return 0;
                
@@ -272,9 +291,11 @@ gint inc_account_mail(MainWindow *mainwin, PrefsAccount *account)
 
        if (inc_lock_count) return 0;
 
+       if (account->receive_in_progress) return 0;
+
        if (prefs_common.work_offline && 
-           !inc_offline_should_override(
-               _("Sylpheed-Claws needs network access in order "
+           !inc_offline_should_override(TRUE,
+               _("Claws Mail needs network access in order "
                  "to get mails.")))
                return 0;
 
@@ -283,67 +304,96 @@ gint inc_account_mail(MainWindow *mainwin, PrefsAccount *account)
 
        new_msgs = inc_account_mail_real(mainwin, account);
 
-       inc_finished(mainwin, new_msgs > 0);
+       inc_update_stats(new_msgs);
+       inc_finished(mainwin, new_msgs > 0, FALSE);
        main_window_unlock(mainwin);
        inc_autocheck_timer_set();
 
        return new_msgs;
 }
 
-void inc_all_account_mail(MainWindow *mainwin, gboolean autocheck,
+void inc_account_list_mail(MainWindow *mainwin, GList *account_list, gboolean autocheck,
                          gboolean notify)
 {
        GList *list, *queue_list = NULL;
        IncProgressDialog *inc_dialog;
-       gint new_msgs = 0;
-       gint account_new_msgs = 0;
-       
+       gint new_msgs = 0, num;
+
        if (prefs_common.work_offline && 
-           !inc_offline_should_override(
-               _("Sylpheed-Claws needs network access in order "
+           !inc_offline_should_override( (autocheck == FALSE),
+               _("Claws Mail needs network access in order "
                  "to get mails.")))
                return;
 
        if (inc_lock_count) return;
 
-       inc_autocheck_timer_remove();
        main_window_lock(mainwin);
 
-       list = account_get_list();
-       if (!list) {
-               inc_finished(mainwin, new_msgs > 0);
+       if (!account_list) {
+               inc_update_stats(new_msgs);
+               inc_finished(mainwin, new_msgs > 0, autocheck);
                main_window_unlock(mainwin);
                inc_notify_cmd(new_msgs, notify);
-               inc_autocheck_timer_set();
                return;
        }
 
-       /* check local folders */
-       account_new_msgs = inc_all_spool();
-       if (account_new_msgs > 0)
-               new_msgs += account_new_msgs;
-
-       /* check IMAP4 / News folders */
-       for (list = account_get_list(); list != NULL; list = list->next) {
-               PrefsAccount *account = list->data;
-               if ((account->protocol == A_IMAP4 ||
-                    account->protocol == A_NNTP) && account->recv_at_getall) {
-                       new_msgs += folderview_check_new(FOLDER(account->folder));
+       if (prefs_common.use_extinc && prefs_common.extinc_cmd) {
+               /* external incorporating program */
+               if (execute_command_line(prefs_common.extinc_cmd, FALSE, NULL) < 0) {
+                       log_error(LOG_PROTOCOL, _("%s failed\n"), prefs_common.extinc_cmd);
+                       
+                       main_window_unlock(mainwin);
+                       return;
                }
        }
 
-       /* check POP3 accounts */
-       for (list = account_get_list(); list != NULL; list = list->next) {
-               IncSession *session;
+       /* Check all accounts in the list, one by one. */
+       for (list = account_list; list != NULL; list = list->next) {
                PrefsAccount *account = list->data;
 
-               if (account->recv_at_getall) {
-                       session = inc_session_new(account);
-                       if (session)
-                               queue_list = g_list_append(queue_list, session);
+               if (account == NULL) {
+                       debug_print("INC: Huh? inc_account_list_mail() got a NULL account, this should not happen!\n");
+                       continue;
+               }
+
+               debug_print("INC: checking account %d\n", account->account_id);
+               switch (account->protocol) {
+                       case A_POP3:
+                               if (!(account->receive_in_progress)) {
+                                       IncSession *session = inc_session_new(account);
+
+                                       if (session != NULL) {
+                                               debug_print("INC: adding POP3 account %d to inc queue\n",
+                                                               account->account_id);
+                                               queue_list = g_list_append(queue_list, session);
+                                       }
+                               }
+                               break;
+
+                       case A_IMAP4:
+                       case A_NNTP:
+                               new_msgs += folderview_check_new(FOLDER(account->folder));
+                               break;
+
+                       case A_LOCAL:
+                               num = inc_spool_account(account);
+                               if (num > 0)
+                                       new_msgs += num;
+                               break;
+
+                       case A_NONE:
+                               /* Nothing to do here, it's a SMTP-only account. */
+                               break;
+
+                       default:
+                               debug_print("INC: encountered account %d with unknown protocol %d, ignoring\n",
+                                               account->account_id, account->protocol);
+                               break;
                }
        }
 
+
+
        if (queue_list) {
                inc_dialog = inc_progress_dialog_create(autocheck);
                inc_dialog->queue_list = queue_list;
@@ -355,36 +405,96 @@ void inc_all_account_mail(MainWindow *mainwin, gboolean autocheck,
                new_msgs += inc_start(inc_dialog);
        }
 
-       inc_finished(mainwin, new_msgs > 0);
+       inc_update_stats(new_msgs);
+       inc_finished(mainwin, new_msgs > 0, autocheck);
        main_window_unlock(mainwin);
        inc_notify_cmd(new_msgs, notify);
-       inc_autocheck_timer_set();
+}
+
+void inc_all_account_mail(MainWindow *mainwin, gboolean autocheck,
+                         gboolean notify)
+{
+       GList *list, *list2 = NULL;
+       gboolean condition;
+
+       debug_print("INC: inc_all_account_mail(), autocheck: %s\n",
+                       autocheck ? "YES" : "NO");
+
+       /* Collect list of accounts which use the global autocheck interval. */
+       for (list = account_get_list(); list != NULL; list = list->next) {
+               PrefsAccount *account = list->data;
+
+               /* Nothing to do for SMTP-only accounts. */
+               if (account->protocol == A_NONE)
+                       continue;
+
+               /* Set up condition which decides whether or not to check
+                * this account, based on whether we're doing global autocheck
+                * or a manual 'Get all' check. */
+               if (autocheck)
+                       condition = prefs_common_get_prefs()->autochk_newmail
+                               && account->autochk_use_default;
+               else
+                       condition = account->recv_at_getall;
+
+               if (condition) {
+                       debug_print("INC: will check account %d\n", account->account_id);
+                       list2 = g_list_append(list2, account);
+               }
+       }
+
+       /* Do the check on the collected accounts. */
+       if (list2 != NULL) {
+               inc_account_list_mail(mainwin, list2, autocheck, notify);
+               g_list_free(list2);
+       }
+}
+
+static void inc_progress_dialog_size_allocate_cb(GtkWidget *widget,
+                                        GtkAllocation *allocation)
+{
+       cm_return_if_fail(allocation != NULL);
+
+       prefs_common.receivewin_width = allocation->width;
+       prefs_common.receivewin_height = allocation->height;
 }
 
 static IncProgressDialog *inc_progress_dialog_create(gboolean autocheck)
 {
        IncProgressDialog *dialog;
        ProgressDialog *progress;
+       static GdkGeometry geometry;
 
        dialog = g_new0(IncProgressDialog, 1);
 
        progress = progress_dialog_create();
        gtk_window_set_title(GTK_WINDOW(progress->window),
                             _("Retrieving new messages"));
+       g_signal_connect(G_OBJECT(progress->showlog_btn), "clicked",
+                        G_CALLBACK(inc_showlog_cb), dialog);
        g_signal_connect(G_OBJECT(progress->cancel_btn), "clicked",
                         G_CALLBACK(inc_cancel_cb), dialog);
        g_signal_connect(G_OBJECT(progress->window), "delete_event",
                         G_CALLBACK(inc_dialog_delete_cb), dialog);
-       /* manage_window_set_transient(GTK_WINDOW(progress->window)); */
+       g_signal_connect(G_OBJECT(progress->window), "size_allocate",
+                        G_CALLBACK(inc_progress_dialog_size_allocate_cb), NULL);
+       /* manage_window_set_transient(GTK_WINDOW(progress->window)); */
 
        progress_dialog_get_fraction(progress);
 
-       stock_pixbuf_gdk(progress->treeview, STOCK_PIXMAP_COMPLETE,
-                        &okpix);
-       stock_pixbuf_gdk(progress->treeview, STOCK_PIXMAP_CONTINUE,
-                        &currentpix);
-       stock_pixbuf_gdk(progress->treeview, STOCK_PIXMAP_ERROR,
-                        &errorpix);
+       stock_pixbuf_gdk(STOCK_PIXMAP_COMPLETE, &okpix);
+       stock_pixbuf_gdk(STOCK_PIXMAP_CONTINUE, &currentpix);
+       stock_pixbuf_gdk(STOCK_PIXMAP_ERROR, &errorpix);
+
+       if (!geometry.min_height) {
+               geometry.min_width = 460;
+               geometry.min_height = 250;
+       }
+
+       gtk_window_set_geometry_hints(GTK_WINDOW(progress->window), NULL, &geometry,
+                                     GDK_HINT_MIN_SIZE);
+       gtk_widget_set_size_request(progress->window, prefs_common.receivewin_width,
+                                   prefs_common.receivewin_height);
 
        if (prefs_common.recv_dialog_mode == RECV_DIALOG_ALWAYS ||
            (prefs_common.recv_dialog_mode == RECV_DIALOG_MANUAL &&
@@ -431,7 +541,7 @@ static void inc_progress_dialog_clear(IncProgressDialog *inc_dialog)
 
 static void inc_progress_dialog_destroy(IncProgressDialog *inc_dialog)
 {
-       g_return_if_fail(inc_dialog != NULL);
+       cm_return_if_fail(inc_dialog != NULL);
 
        inc_dialog_list = g_list_remove(inc_dialog_list, inc_dialog);
 
@@ -446,7 +556,7 @@ static IncSession *inc_session_new(PrefsAccount *account)
 {
        IncSession *session;
 
-       g_return_val_if_fail(account != NULL, NULL);
+       cm_return_val_if_fail(account != NULL, NULL);
 
        if (account->protocol != A_POP3)
                return NULL;
@@ -471,12 +581,24 @@ static IncSession *inc_session_new(PrefsAccount *account)
 
 static void inc_session_destroy(IncSession *session)
 {
-       g_return_if_fail(session != NULL);
+       cm_return_if_fail(session != NULL);
 
        session_destroy(session->session);
        g_free(session);
 }
 
+static gint pop3_get_port(Pop3Session *pop3_session)
+{
+#ifdef USE_GNUTLS
+       return pop3_session->ac_prefs->set_popport ?
+               pop3_session->ac_prefs->popport :
+               pop3_session->ac_prefs->ssl_pop == SSL_TUNNEL ? 995 : 110;
+#else
+       return pop3_session->ac_prefs->set_popport ?
+               pop3_session->ac_prefs->popport : 110;
+#endif
+}
+
 static gint inc_start(IncProgressDialog *inc_dialog)
 {
        IncSession *session;
@@ -488,7 +610,6 @@ static gint inc_start(IncProgressDialog *inc_dialog)
        gchar *msg;
        gchar *fin_msg;
        FolderItem *processing, *inbox;
-       MsgInfo *msginfo;
        GSList *msglist, *msglist_element;
        gboolean cancelled = FALSE;
 
@@ -499,36 +620,36 @@ static gint inc_start(IncProgressDialog *inc_dialog)
                session = qlist->data;
                pop3_session = POP3_SESSION(session->session); 
                pop3_session->user = g_strdup(pop3_session->ac_prefs->userid);
-               if (pop3_session->ac_prefs->passwd)
-                       pop3_session->pass =
-                               g_strdup(pop3_session->ac_prefs->passwd);
-               else if (pop3_session->ac_prefs->tmp_pass)
-                       pop3_session->pass =
-                               g_strdup(pop3_session->ac_prefs->tmp_pass);
-               else {
-                       gchar *pass;
 
-                       if (inc_dialog->show_dialog)
-                               manage_window_focus_in
-                                       (inc_dialog->dialog->window,
-                                        NULL, NULL);
+               if (inc_dialog->show_dialog)
+                       manage_window_focus_in
+                               (inc_dialog->dialog->window,
+                                NULL, NULL);
+
+               if (password_get(pop3_session->user,
+                                       pop3_session->ac_prefs->recv_server,
+                                       "pop3", pop3_get_port(pop3_session),
+                                       &(pop3_session->pass))) {
+                       /* NOP */;
+               } else if ((pop3_session->pass = passwd_store_get_account(
+                                               pop3_session->ac_prefs->account_id, PWS_ACCOUNT_RECV)) == NULL) {
+                       gchar *pass;
 
-                       pass = input_dialog_query_password
+                       pass = input_dialog_query_password_keep
                                (pop3_session->ac_prefs->recv_server,
-                                pop3_session->user);
-
-                       if (inc_dialog->show_dialog)
-                               manage_window_focus_out
-                                       (inc_dialog->dialog->window,
-                                        NULL, NULL);
+                                pop3_session->user,
+                                &(pop3_session->ac_prefs->session_passwd));
 
                        if (pass) {
-                               pop3_session->ac_prefs->tmp_pass =
-                                       g_strdup(pass);
                                pop3_session->pass = pass;
                        }
                }
 
+               if (inc_dialog->show_dialog)
+                       manage_window_focus_out
+                               (inc_dialog->dialog->window,
+                                NULL, NULL);
+
                qlist = next;
        }
 
@@ -542,9 +663,9 @@ static gint inc_start(IncProgressDialog *inc_dialog)
 }
 
        for (; inc_dialog->queue_list != NULL && !cancelled; inc_dialog->cur_row++) {
-               int cur = 1, total = 0;
                session = inc_dialog->queue_list->data;
                pop3_session = POP3_SESSION(session->session);
+               GSList *filtered, *unfiltered;
 
                if (pop3_session->pass == NULL) {
                        SET_PIXMAP_AND_TEXT(okpix, _("Cancelled"));
@@ -571,7 +692,7 @@ static gint inc_start(IncProgressDialog *inc_dialog)
                                                 "Done (%d messages (%s) received)",
                                         pop3_session->cur_total_num),
                                         pop3_session->cur_total_num,
-                                        to_human_readable(pop3_session->cur_total_recv_bytes));
+                                        to_human_readable((goffset)pop3_session->cur_total_recv_bytes));
                        else
                                msg = g_strdup_printf(_("Done (no new messages)"));
                        SET_PIXMAP_AND_TEXT(okpix, msg);
@@ -582,6 +703,10 @@ static gint inc_start(IncProgressDialog *inc_dialog)
                        break;
                case INC_AUTH_FAILED:
                        SET_PIXMAP_AND_TEXT(errorpix, _("Auth failed"));
+                       if (pop3_session->ac_prefs->session_passwd) {
+                               g_free(pop3_session->ac_prefs->session_passwd);
+                               pop3_session->ac_prefs->session_passwd = NULL;
+                       }
                        break;
                case INC_LOCKED:
                        SET_PIXMAP_AND_TEXT(errorpix, _("Locked"));
@@ -624,53 +749,35 @@ static gint inc_start(IncProgressDialog *inc_dialog)
                        inbox = folder_get_default_inbox();
 
                /* get list of messages in processing */
-               processing = folder_get_default_processing();
+               processing = folder_get_default_processing(pop3_session->ac_prefs->account_id);
                folder_item_scan(processing);
                msglist = folder_item_get_msg_list(processing);
 
                /* process messages */
                folder_item_update_freeze();
-               if (pop3_session->ac_prefs->filter_on_recv)
-                       statusbar_print_all(_("Filtering messages...\n"));
-               total = g_slist_length(msglist);
-
-               for(msglist_element = msglist; msglist_element != NULL; 
-                   msglist_element = msglist_element->next) {
-                       gchar *filename;
-                       msginfo = (MsgInfo *) msglist_element->data;
-                       filename = folder_item_fetch_msg(processing, msginfo->msgnum);
-                       g_free(filename);
-
-                       if (pop3_session->ac_prefs->filter_on_recv)
-                               statusbar_progress_all(cur++,total, prefs_common.statusbar_update_step);
+               
+               procmsg_msglist_filter(msglist, pop3_session->ac_prefs, 
+                               &filtered, &unfiltered, 
+                               pop3_session->ac_prefs->filter_on_recv);
 
-                       if (!pop3_session->ac_prefs->filter_on_recv || 
-                           !procmsg_msginfo_filter(msginfo, pop3_session->ac_prefs))
-                               folder_item_move_msg(inbox, msginfo);
-               }
                filtering_move_and_copy_msgs(msglist);
+               if (unfiltered != NULL)         
+                       folder_item_move_msgs(inbox, unfiltered);
+
                for(msglist_element = msglist; msglist_element != NULL; 
                    msglist_element = msglist_element->next) {
-                       MsgInfo *msginfo = (MsgInfo *)msglist_element->data;
-                       procmsg_msginfo_free(msginfo);
+                       procmsg_msginfo_free((MsgInfo**)&(msglist_element->data));
                }
                folder_item_update_thaw();
                
-               statusbar_progress_all(0,0,0);
-               statusbar_pop_all();
-
                g_slist_free(msglist);
+               g_slist_free(filtered);
+               g_slist_free(unfiltered);
 
                statusbar_pop_all();
 
                new_msgs += pop3_session->cur_total_num;
 
-               if (pop3_session->error_val == PS_AUTHFAIL &&
-                   pop3_session->ac_prefs->tmp_pass) {
-                       g_free(pop3_session->ac_prefs->tmp_pass);
-                       pop3_session->ac_prefs->tmp_pass = NULL;
-               }
-
                pop3_write_uidl_list(pop3_session);
 
                if (inc_state != INC_SUCCESS && inc_state != INC_CANCEL) {
@@ -731,35 +838,38 @@ static IncState inc_pop3_session_do(IncSession *session)
 {
        Pop3Session *pop3_session = POP3_SESSION(session->session);
        IncProgressDialog *inc_dialog = (IncProgressDialog *)session->data;
+       PrefsAccount *ac = pop3_session->ac_prefs;
        gchar *server;
+       gchar *account_name;
        gushort port;
        gchar *buf;
+       ProxyInfo *proxy_info = NULL;
 
        debug_print("getting new messages of account %s...\n",
-                   pop3_session->ac_prefs->account_name);
+                   ac->account_name);
                    
-       pop3_session->ac_prefs->last_pop_login_time = time(NULL);
+       ac->last_pop_login_time = time(NULL);
 
        buf = g_strdup_printf(_("%s: Retrieving new messages"),
-                             pop3_session->ac_prefs->recv_server);
+                             ac->recv_server);
        gtk_window_set_title(GTK_WINDOW(inc_dialog->dialog->window), buf);
        g_free(buf);
 
-       server = pop3_session->ac_prefs->recv_server;
-#if USE_OPENSSL
-       port = pop3_session->ac_prefs->set_popport ?
-               pop3_session->ac_prefs->popport :
-               pop3_session->ac_prefs->ssl_pop == SSL_TUNNEL ? 995 : 110;
-       SESSION(pop3_session)->ssl_type = pop3_session->ac_prefs->ssl_pop;
-       if (pop3_session->ac_prefs->ssl_pop != SSL_NONE)
+       server = ac->recv_server;
+       account_name = ac->account_name;
+       port = pop3_get_port(pop3_session);
+
+#ifdef USE_GNUTLS
+       SESSION(pop3_session)->ssl_type = ac->ssl_pop;
+       if (ac->ssl_pop != SSL_NONE)
                SESSION(pop3_session)->nonblocking =
-                       pop3_session->ac_prefs->use_nonblocking_ssl;
+                       ac->use_nonblocking_ssl;
 #else
-       if (pop3_session->ac_prefs->ssl_pop != SSL_NONE) {
+       if (ac->ssl_pop != SSL_NONE) {
                if (alertpanel_full(_("Insecure connection"),
                        _("This connection is configured to be secured "
-                         "using SSL, but SSL is not available in this "
-                         "build of Sylpheed-Claws. \n\n"
+                         "using SSL/TLS, but SSL/TLS is not available "
+                         "in this build of Claws Mail. \n\n"
                          "Do you want to continue connecting to this "
                          "server? The communication would not be "
                          "secure."),
@@ -768,15 +878,30 @@ static IncState inc_pop3_session_do(IncSession *session)
                          G_ALERTDEFAULT) != G_ALERTALTERNATE)
                        return INC_CANCEL;
        }
-       port = pop3_session->ac_prefs->set_popport ?
-               pop3_session->ac_prefs->popport : 110;
 #endif
 
-       buf = g_strdup_printf(_("Connecting to POP3 server: %s..."), server);
+       buf = g_strdup_printf(_("Account '%s': Connecting to POP3 server: %s:%d..."),
+                               account_name, server, port);
        statusbar_print_all("%s", buf);
-       log_message("%s\n", buf);
+       log_message(LOG_PROTOCOL, "%s\n", buf);
 
        progress_dialog_set_label(inc_dialog->dialog, buf);
+
+       if (ac->use_proxy) {
+               if (ac->use_default_proxy) {
+                       proxy_info = (ProxyInfo *)&(prefs_common.proxy_info);
+                       if (proxy_info->use_proxy_auth)
+                               proxy_info->proxy_pass = passwd_store_get(PWS_CORE, PWS_CORE_PROXY,
+                                       PWS_CORE_PROXY_PASS);
+               } else {
+                       proxy_info = (ProxyInfo *)&(ac->proxy_info);
+                       if (proxy_info->use_proxy_auth)
+                               proxy_info->proxy_pass = passwd_store_get_account(ac->account_id,
+                                       PWS_ACCOUNT_PROXY_PASS);
+               }
+       }
+       SESSION(pop3_session)->proxy_info = proxy_info;
+
        GTK_EVENTS_FLUSH();
        g_free(buf);
 
@@ -784,8 +909,6 @@ static IncState inc_pop3_session_do(IncSession *session)
                            prefs_common.io_timeout_secs * 1000);
        
        if (session_connect(SESSION(pop3_session), server, port) < 0) {
-               log_warning(_("Can't connect to POP3 server: %s:%d\n"),
-                           server, port);
                if(!prefs_common.no_recv_err_panel) {
                        if((prefs_common.recv_dialog_mode == RECV_DIALOG_ALWAYS) ||
                            ((prefs_common.recv_dialog_mode == RECV_DIALOG_MANUAL) && focus_window)) {
@@ -794,13 +917,16 @@ static IncState inc_pop3_session_do(IncSession *session)
                        alertpanel_error(_("Can't connect to POP3 server: %s:%d"),
                                         server, port);
                        manage_window_focus_out(inc_dialog->dialog->window, NULL, NULL);
+               } else {
+                       log_error(LOG_PROTOCOL, _("Can't connect to POP3 server: %s:%d\n"),
+                           server, port);
                }
                session->inc_state = INC_CONNECT_ERROR;
                statusbar_pop_all();
                return INC_CONNECT_ERROR;
        }
 
-       while (session_is_connected(SESSION(pop3_session)) &&
+       while (session_is_running(SESSION(pop3_session)) &&
               session->inc_state != INC_CANCEL)
                gtk_main_iteration();
 
@@ -862,7 +988,7 @@ static void inc_progress_dialog_set_label(IncProgressDialog *inc_dialog,
        ProgressDialog *dialog = inc_dialog->dialog;
        Pop3Session *session;
 
-       g_return_if_fail(inc_session != NULL);
+       cm_return_if_fail(inc_session != NULL);
 
        session = POP3_SESSION(inc_session->session);
 
@@ -874,7 +1000,7 @@ static void inc_progress_dialog_set_label(IncProgressDialog *inc_dialog,
        case POP3_GETAUTH_APOP:
                progress_dialog_set_label(dialog, _("Authenticating..."));
                statusbar_pop_all();
-               statusbar_print_all(_("Retrieving messages from %s (%s) ..."),
+               statusbar_print_all(_("Retrieving messages from %s (%s)..."),
                                    SESSION(session)->server,
                                    session->ac_prefs->account_name);
                break;
@@ -909,7 +1035,7 @@ static void inc_progress_dialog_set_label(IncProgressDialog *inc_dialog,
 static void inc_progress_dialog_set_progress(IncProgressDialog *inc_dialog,
                                             IncSession *inc_session)
 {
-       gchar buf[MSGBUFSIZE];
+       gchar buf[MESSAGEBUFSIZE];
        Pop3Session *pop3_session = POP3_SESSION(inc_session->session);
        gchar *total_size_str;
        gint cur_total;
@@ -922,24 +1048,18 @@ static void inc_progress_dialog_set_progress(IncProgressDialog *inc_dialog,
        if (pop3_session->state == POP3_RETR ||
            pop3_session->state == POP3_RETR_RECV ||
            pop3_session->state == POP3_DELETE) {
-               Xstrdup_a(total_size_str, to_human_readable(total), return);
+               Xstrdup_a(total_size_str, to_human_readable((goffset)total), return);
                g_snprintf(buf, sizeof(buf),
                           _("Retrieving message (%d / %d) (%s / %s)"),
                           pop3_session->cur_msg, pop3_session->count,
-                          to_human_readable(cur_total), total_size_str);
+                          to_human_readable((goffset)cur_total), total_size_str);
                progress_dialog_set_label(inc_dialog->dialog, buf);
        }
 
        progress_dialog_set_fraction
                (inc_dialog->dialog, (total == 0) ? 0: (gfloat)cur_total / (gfloat)total);
 
-       g_snprintf(buf, sizeof(buf), "%d / %d",
-                  pop3_session->cur_msg, pop3_session->count);
-       gtk_progress_bar_set_text
-               (GTK_PROGRESS_BAR(inc_dialog->mainwin->progressbar), buf);
-       gtk_progress_bar_set_fraction
-               (GTK_PROGRESS_BAR(inc_dialog->mainwin->progressbar),
-                (total == 0) ? 0 : (gfloat)cur_total / (gfloat)total);
+       statusbar_progress_all(pop3_session->cur_msg, pop3_session->count, 1);
 
        if (pop3_session->cur_total_num > 0) {
                g_snprintf(buf, sizeof(buf),
@@ -948,7 +1068,7 @@ static void inc_progress_dialog_set_progress(IncProgressDialog *inc_dialog,
                                    pop3_session->cur_total_num),
                           pop3_session->cur_total_num,
                           to_human_readable
-                          (pop3_session->cur_total_recv_bytes));
+                          ((goffset)pop3_session->cur_total_recv_bytes));
                progress_dialog_list_set_status(inc_dialog->dialog,
                                                inc_dialog->cur_row,
                                                buf);
@@ -987,7 +1107,7 @@ static gint inc_recv_data_progressive(Session *session, guint cur_len,
        IncProgressDialog *inc_dialog;
        gint cur_total;
 
-       g_return_val_if_fail(inc_session != NULL, -1);
+       cm_return_val_if_fail(inc_session != NULL, -1);
 
        if (pop3_session->state != POP3_RETR &&
            pop3_session->state != POP3_RETR_RECV &&
@@ -1012,7 +1132,7 @@ static gint inc_recv_data_finished(Session *session, guint len, gpointer data)
        IncSession *inc_session = (IncSession *)data;
        IncProgressDialog *inc_dialog;
 
-       g_return_val_if_fail(inc_session != NULL, -1);
+       cm_return_val_if_fail(inc_session != NULL, -1);
 
        inc_dialog = (IncProgressDialog *)inc_session->data;
 
@@ -1030,7 +1150,7 @@ static gint inc_recv_message(Session *session, const gchar *msg, gpointer data)
        IncSession *inc_session = (IncSession *)data;
        IncProgressDialog *inc_dialog;
 
-       g_return_val_if_fail(inc_session != NULL, -1);
+       cm_return_val_if_fail(inc_session != NULL, -1);
 
        inc_dialog = (IncProgressDialog *)inc_session->data;
 
@@ -1064,7 +1184,7 @@ static gint inc_drop_message(Pop3Session *session, const gchar *file)
        IncSession *inc_session = (IncSession *)(SESSION(session)->data);
        gint msgnum;
 
-       g_return_val_if_fail(inc_session != NULL, -1);
+       cm_return_val_if_fail(inc_session != NULL, -1);
 
        if (session->ac_prefs->inbox) {
                inbox = folder_find_item_from_identifier
@@ -1074,17 +1194,17 @@ static gint inc_drop_message(Pop3Session *session, const gchar *file)
        } else
                inbox = folder_get_default_inbox();
        if (!inbox) {
-               g_unlink(file);
+               claws_unlink(file);
                return -1;
        }
 
        /* CLAWS: claws uses a global .processing folder for the filtering. */
-       dropfolder = folder_get_default_processing();
+       dropfolder = folder_get_default_processing(session->ac_prefs->account_id);
 
        /* add msg file to drop folder */
        if ((msgnum = folder_item_add_msg(
                        dropfolder, file, NULL, TRUE)) < 0) {
-               g_unlink(file);
+               claws_unlink(file);
                return -1;
        }
 
@@ -1099,7 +1219,7 @@ static void inc_put_error(IncState istate, Pop3Session *session)
 
        switch (istate) {
        case INC_CONNECT_ERROR:
-               log_msg = _("Connection failed.");
+               fatal_error = TRUE;
                if (prefs_common.no_recv_err_panel)
                        break;
                err_msg = g_strdup_printf(_("Connection to %s:%d failed."),
@@ -1108,6 +1228,7 @@ static void inc_put_error(IncState istate, Pop3Session *session)
                break;
        case INC_ERROR:
                log_msg = _("Error occurred while processing mail.");
+               fatal_error = TRUE;
                if (prefs_common.no_recv_err_panel)
                        break;
                if (session->error_msg)
@@ -1155,6 +1276,7 @@ static void inc_put_error(IncState istate, Pop3Session *session)
                break;
        case INC_AUTH_FAILED:
                log_msg = _("Authentication failed.");
+               fatal_error = TRUE;
                if (prefs_common.no_recv_err_panel)
                        break;
                if (session->error_msg)
@@ -1164,7 +1286,9 @@ static void inc_put_error(IncState istate, Pop3Session *session)
                        err_msg = g_strdup(log_msg);
                break;
        case INC_TIMEOUT:
-               log_msg = _("Session timed out.");
+               log_msg = _("Session timed out. You may be able to "
+                           "recover by increasing the timeout value in "
+                           "Preferences/Other/Miscellaneous.");
                if (prefs_common.no_recv_err_panel)
                        break;
                err_msg = g_strdup_printf(_("Connection to %s:%d timed out."), 
@@ -1177,12 +1301,15 @@ static void inc_put_error(IncState istate, Pop3Session *session)
 
        if (log_msg) {
                if (fatal_error)
-                       log_error("%s\n", log_msg);
+                       log_error(LOG_PROTOCOL, "%s\n", log_msg);
                else
-                       log_warning("%s\n", log_msg);
+                       log_warning(LOG_PROTOCOL, "%s\n", log_msg);
        }
+       if (prefs_common.no_recv_err_panel && fatal_error)
+               mainwindow_show_error();
+
        if (err_msg) {
-               alertpanel_error_log(err_msg);
+               alertpanel_error_log("%s", err_msg);
                g_free(err_msg);
        }
 }
@@ -1191,7 +1318,7 @@ static void inc_cancel(IncProgressDialog *dialog)
 {
        IncSession *session;
 
-       g_return_if_fail(dialog != NULL);
+       cm_return_if_fail(dialog != NULL);
 
        if (dialog->queue_list == NULL) {
                inc_progress_dialog_destroy(dialog);
@@ -1202,7 +1329,7 @@ static void inc_cancel(IncProgressDialog *dialog)
 
        session->inc_state = INC_CANCEL;
 
-       log_message(_("Incorporation cancelled\n"));
+       log_message(LOG_PROTOCOL, _("Incorporation cancelled\n"));
 }
 
 gboolean inc_is_active(void)
@@ -1218,6 +1345,13 @@ void inc_cancel_all(void)
                inc_cancel((IncProgressDialog *)cur->data);
 }
 
+static void inc_showlog_cb(GtkWidget *widget, gpointer data)
+{
+       MainWindow *mainwin = mainwindow_get_mainwindow();
+
+       log_window_show(mainwin->logwin);
+}
+
 static void inc_cancel_cb(GtkWidget *widget, gpointer data)
 {
        inc_cancel((IncProgressDialog *)data);
@@ -1247,18 +1381,23 @@ static gint inc_spool_account(PrefsAccount *account)
        } else
                inbox = folder_get_default_inbox();
 
-       if (is_file_exist(account->local_mbox))
-               mbox = g_strdup(account->local_mbox);
-       else if (is_dir_exist(account->local_mbox)) 
-               mbox = g_strconcat(account->local_mbox, G_DIR_SEPARATOR_S,
-                                  g_get_user_name(), NULL);
-       else {
-               debug_print("%s: local mailbox not found.\n", 
-                           account->local_mbox);
+       if (account->local_mbox) {
+               if (is_file_exist(account->local_mbox))
+                       mbox = g_strdup(account->local_mbox);
+               else if (is_dir_exist(account->local_mbox)) 
+                       mbox = g_strconcat(account->local_mbox, G_DIR_SEPARATOR_S,
+                                          g_get_user_name(), NULL);
+               else {
+                       debug_print("%s: local mailbox not found.\n", 
+                                   account->local_mbox);
+                       return -1;
+               }
+       } else {
+               debug_print("local mailbox not set in account info.\n");
                return -1;
-       }
-       
-       result = get_spool(inbox, mbox);
+       }       
+
+       result = get_spool(inbox, mbox, account);
        g_free(mbox);
        
        statusbar_pop_all();
@@ -1266,37 +1405,15 @@ static gint inc_spool_account(PrefsAccount *account)
        return result;
 }
 
-static gint inc_all_spool(void)
-{
-       GList *list = NULL;
-       gint new_msgs = 0;
-       gint account_new_msgs = 0;
-
-       list = account_get_list();
-       if (!list) return 0;
-
-       for (; list != NULL; list = list->next) {
-               PrefsAccount *account = list->data;
-
-               if ((account->protocol == A_LOCAL) &&
-                   (account->recv_at_getall)) {
-                       account_new_msgs = inc_spool_account(account);
-                       if (account_new_msgs > 0)
-                               new_msgs += account_new_msgs;
-               }
-       }
-
-       return new_msgs;
-}
-
-static gint get_spool(FolderItem *dest, const gchar *mbox)
+static gint get_spool(FolderItem *dest, const gchar *mbox, PrefsAccount *account)
 {
        gint msgs, size;
        gint lockfd;
        gchar tmp_mbox[MAXPATHLEN + 1];
 
-       g_return_val_if_fail(dest != NULL, -1);
-       g_return_val_if_fail(mbox != NULL, -1);
+       cm_return_val_if_fail(dest != NULL, -1);
+       cm_return_val_if_fail(mbox != NULL, -1);
+       cm_return_val_if_fail(account != NULL, -1);
 
        if (!is_file_exist(mbox) || (size = get_file_size(mbox)) == 0) {
                debug_print("%s: no messages in local mailbox.\n", mbox);
@@ -1307,10 +1424,10 @@ static gint get_spool(FolderItem *dest, const gchar *mbox)
        if ((lockfd = lock_mbox(mbox, LOCK_FLOCK)) < 0)
                return -1;
 
-       g_snprintf(tmp_mbox, sizeof(tmp_mbox), "%s%ctmpmbox.%08x",
-                  get_tmp_dir(), G_DIR_SEPARATOR, (gint)mbox);
+       g_snprintf(tmp_mbox, sizeof(tmp_mbox), "%s%ctmpmbox.%p",
+                  get_tmp_dir(), G_DIR_SEPARATOR, mbox);
 
-       if (copy_mbox(mbox, tmp_mbox) < 0) {
+       if (copy_mbox(lockfd, tmp_mbox) < 0) {
                unlock_mbox(mbox, lockfd, LOCK_FLOCK);
                return -1;
        }
@@ -1318,21 +1435,21 @@ static gint get_spool(FolderItem *dest, const gchar *mbox)
        debug_print("Getting new messages from %s into %s...\n",
                    mbox, dest->path);
 
-       msgs = proc_mbox(dest, tmp_mbox, TRUE);
+       msgs = proc_mbox(dest, tmp_mbox, account->filter_on_recv, account);
 
-       g_unlink(tmp_mbox);
+       claws_unlink(tmp_mbox);
        if (msgs >= 0) empty_mbox(mbox);
        unlock_mbox(mbox, lockfd, LOCK_FLOCK);
 
        return msgs;
 }
 
-void inc_lock(void)
+void inc_lock_real(void)
 {
        inc_lock_count++;
 }
 
-void inc_unlock(void)
+void inc_unlock_real(void)
 {
        if (inc_lock_count > 0)
                inc_lock_count--;
@@ -1343,13 +1460,13 @@ static gpointer autocheck_data = NULL;
 
 static void inc_notify_cmd(gint new_msgs, gboolean notify)
 {
-
        gchar *buf, *numpos, *ret_str;
        gssize by_read = 0, by_written = 0;
 
        if (!(new_msgs && notify && prefs_common.newmail_notify_cmd &&
            *prefs_common.newmail_notify_cmd))
                     return;
+
        buf = g_strdup(prefs_common.newmail_notify_cmd);
        if ((numpos = strstr(buf, "%d")) != NULL) {
                gchar *buf2;
@@ -1367,40 +1484,47 @@ static void inc_notify_cmd(gint new_msgs, gboolean notify)
                buf = ret_str;
        }
        debug_print("executing new mail notification command: %s\n", buf);
-       execute_command_line(buf, TRUE);
+       execute_command_line(buf, TRUE, NULL);
 
        g_free(buf);
 }
+
 void inc_autocheck_timer_init(MainWindow *mainwin)
 {
        autocheck_data = mainwin;
        inc_autocheck_timer_set();
 }
 
-static void inc_autocheck_timer_set_interval(guint interval)
+static void inc_autocheck_timer_set_interval(guint _interval)
 {
+       guint interval = _interval;
+
+       /* Convert the interval to seconds if needed. */
+       if (_interval % 1000 == 0)
+               interval /= 1000;
+
        inc_autocheck_timer_remove();
        /* last test is to avoid re-enabling auto_check after modifying 
           the common preferences */
        if (prefs_common.autochk_newmail && autocheck_data
            && prefs_common.work_offline == FALSE) {
-               autocheck_timer = gtk_timeout_add
-                       (interval, inc_autocheck_func, autocheck_data);
-               debug_print("added timer = %d\n", autocheck_timer);
+                       autocheck_timer =
+                               g_timeout_add_seconds(interval, inc_autocheck_func, autocheck_data);
+               debug_print("added global inc timer %d at %u seconds\n",
+                               autocheck_timer, interval);
        }
 }
 
 void inc_autocheck_timer_set(void)
 {
-       inc_autocheck_timer_set_interval(prefs_common.autochk_itv * 60000);
+       inc_autocheck_timer_set_interval(prefs_common.autochk_itv * 1000);
 }
 
 void inc_autocheck_timer_remove(void)
 {
        if (autocheck_timer) {
-               debug_print("removed timer = %d\n", autocheck_timer);
-               gtk_timeout_remove(autocheck_timer);
+               debug_print("removed global inc timer %d\n", autocheck_timer);
+               g_source_remove(autocheck_timer);
                autocheck_timer = 0;
        }
 }
@@ -1410,55 +1534,151 @@ static gint inc_autocheck_func(gpointer data)
        MainWindow *mainwin = (MainWindow *)data;
 
        if (inc_lock_count) {
-               debug_print("autocheck is locked.\n");
+               debug_print("global inc: autocheck is locked.\n");
                inc_autocheck_timer_set_interval(1000);
                return FALSE;
        }
 
        inc_all_account_mail(mainwin, TRUE, prefs_common.newmail_notify_auto);
+       inc_autocheck_timer_set();
 
        return FALSE;
 }
 
-gboolean inc_offline_should_override(const gchar *msg)
+static gboolean inc_account_autocheck_func(gpointer data)
 {
-       static time_t overridden_yes = 0;
-       static time_t overridden_no  = 0;
-       int length = 10; /* minutes */
+       PrefsAccount *account = (PrefsAccount *)data;
+       GList *list = NULL;
+
+       cm_return_val_if_fail(account != NULL, FALSE);
+
+       debug_print("account %d: inc_account_autocheck_func\n",
+                       account->account_id);
+
+       list = g_list_append(list, account);
+       inc_account_list_mail(mainwindow_get_mainwindow(),
+                       list, TRUE, prefs_common.newmail_notify_auto);
+       g_list_free(list);
+
+       inc_account_autocheck_timer_set_interval(account);
+
+       return FALSE;
+}
+
+void inc_account_autocheck_timer_remove(PrefsAccount *account)
+{
+       cm_return_if_fail(account != NULL);
+
+       if (account->autocheck_timer != 0) {
+               g_source_remove(account->autocheck_timer);
+               debug_print("INC: account %d: removed inc timer %d\n", account->account_id,
+                               account->autocheck_timer);
+               account->autocheck_timer = 0;
+       }
+}
+
+void inc_account_autocheck_timer_set_interval(PrefsAccount *account)
+{
+       cm_return_if_fail(account != NULL);
+
+       inc_account_autocheck_timer_remove(account);
+
+       if (account->autochk_use_default
+                       || !account->autochk_use_custom
+                       || account->autochk_itv == 0)
+               return;
+
+       account->autocheck_timer = g_timeout_add_seconds(
+                       account->autochk_itv, inc_account_autocheck_func, account);
+       debug_print("INC: account %d: added inc timer %d at %u seconds\n",
+                       account->account_id, account->autocheck_timer, account->autochk_itv);
+}
+
+gboolean inc_offline_should_override(gboolean force_ask, const gchar *msg)
+{
+       gint length = 10; /* seconds */
        gint answer = G_ALERTDEFAULT;
-       
+
+#ifdef HAVE_NETWORKMANAGER_SUPPORT
+       /* If no network connection is available, override is not possible */
+       if(!networkmanager_is_online(NULL))
+               return FALSE;
+#endif
+
        if (prefs_common.autochk_newmail)
-               length = prefs_common.autochk_itv; /* minutes */
+               length = prefs_common.autochk_itv; /* seconds */
+
+       if (force_ask) {
+               inc_offline_overridden_no = (time_t)0;
+       }
 
        if (prefs_common.work_offline) {
                gchar *tmp = NULL;
                
-               if (time(NULL) - overridden_yes < length * 60) /* seconds */
+               if (time(NULL) - inc_offline_overridden_yes < length * 60) /* seconds */
                         return TRUE;
-               else if (time(NULL) - overridden_no < 3) /* seconds */
+               else if (time(NULL) - inc_offline_overridden_no < length * 60) /* seconds */
                         return FALSE;
 
-               tmp = g_strdup_printf(
-                               _("%s%sYou're working offline. Override for %d minutes?"),
+               if (!force_ask) {
+                       gchar *unit = _("seconds");
+
+                       /* show the offline override time (length) using the must appropriate unit:
+                          the biggest unit possible (hours, minutes, seconds), provided that there
+                          is not inferior unit involved: 1 hour, 150 minutes, 25 minutes, 90 minutes,
+                          30 seconds, 90 seconds. */
+                       if ((length / 3600) > 0) { /* hours? */
+                               if (((length % 3600) % 60) == 0) { /* no seconds left? */
+                                       if ((length % 3600) > 0) { /* minutes left? */
+                                               length = length / 60;
+                                               unit = ngettext("minute", "minutes", length);
+                                       } else {
+                                               length = length / 3600;
+                                               unit = ngettext("hour", "hours", length);
+                                       }
+                               } /* else: seconds */
+                       } else {
+                               if ((length / 60) > 0) { /* minutes left? */
+                                       if ((length % 60) == 0) {
+                                               length = length / 60;
+                                               unit = ngettext("minute", "minutes", length);
+                                       }
+                               } /* else: seconds */
+                       }
+                       tmp = g_strdup_printf(
+                               _("%s%sYou're working offline. Override for %d %s?"),
                                msg?msg:"", 
                                msg?"\n\n":"",
-                               length);
+                               length, unit);
+               } else
+                       tmp = g_strdup_printf(
+                               _("%s%sYou're working offline. Override?"),
+                               msg?msg:"", 
+                               msg?"\n\n":"");
 
                answer = alertpanel(_("Offline warning"), 
                               tmp,
-                              GTK_STOCK_NO, "+" GTK_STOCK_YES, _("On_ly once"));
+                              GTK_STOCK_NO, GTK_STOCK_YES,
+                               !force_ask? _("On_ly once"):NULL, ALERTFOCUS_SECOND);
                g_free(tmp);
                if (answer == G_ALERTALTERNATE) {
-                       overridden_yes = time(NULL);
+                       inc_offline_overridden_yes = time(NULL);
                        return TRUE;
                } else if (answer == G_ALERTDEFAULT) {
-                       overridden_no  = time(NULL);
+                       if (!force_ask)
+                               inc_offline_overridden_no  = time(NULL);
                        return FALSE;
                } else {
-                       overridden_yes = (time_t)0;
-                       overridden_no  = (time_t)0;
+                       inc_reset_offline_override_timers();
                        return TRUE;
                }
        }
        return TRUE;
 }
+
+void inc_reset_offline_override_timers()
+{
+       debug_print("resetting offline override timers\n");
+       inc_offline_overridden_yes = (time_t)0;
+       inc_offline_overridden_no  = (time_t)0;
+}