make sure that we use the inbox set per account when filtering
[claws.git] / src / inc.c
index 99cf3477987356fac366e75fda044c070ff85281..8fac19b42312c38c263122a8a76785fbaf8959b3 100644 (file)
--- a/src/inc.c
+++ b/src/inc.c
 #include "pixmaps/complete.xpm"
 #include "pixmaps/error.xpm"
 
-GdkPixmap *currentxpm;
-GdkBitmap *currentxpmmask;
-GdkPixmap *errorxpm;
-GdkBitmap *errorxpmmask;
-GdkPixmap *okxpm;
-GdkBitmap *okxpmmask;
+static guint inc_lock_count = 0;
+
+static GdkPixmap *currentxpm;
+static GdkBitmap *currentxpmmask;
+static GdkPixmap *errorxpm;
+static GdkBitmap *errorxpmmask;
+static GdkPixmap *okxpm;
+static GdkBitmap *okxpmmask;
 
 #define MSGBUFSIZE     8192
 
@@ -116,8 +118,8 @@ static gint get_spool                       (FolderItem     *dest,
                                         const gchar    *mbox);
 
 static void inc_all_spool(void);
-
-static gint inc_autocheck_func         (gpointer        data);
+static void inc_autocheck_timer_set_interval   (guint           interval);
+static gint inc_autocheck_func                 (gpointer        data);
 
 /**
  * inc_finished:
@@ -134,22 +136,6 @@ static void inc_finished(MainWindow *mainwin, gboolean new_messages)
 
        if (prefs_common.scan_all_after_inc)
                folderview_update_all_node();
-       /* XXX: major problems right here. if we change marks after
-        * incorporation of mail, folderview_select() rewrites it
-        * right under our nose. folderview_select() eventually
-        * calls summary_show(), which rewrites the cache twice:
-        * one for the previously selected FolderItem*, and one
-        * for the newly selected FolderItem* 
-        *
-        * since filtering also allows changing mark files, 
-        * i've solved this by using a global variable (in 
-        * SummmaryView*). a better solution is to use the folder
-        * hash table, and see whether the newly and currently 
-        * selected FolderItem* where updated by the filtering. */
-
-       mainwin->summaryview->filtering_happened = TRUE;
-
-       /* XXX: filtering_happened is reset by summary_show() */
 
        if (!new_messages && !prefs_common.scan_all_after_inc) return;
 
@@ -170,34 +156,20 @@ void inc_mail(MainWindow *mainwin)
 {
        gint new_msgs = 0;
 
+       if (inc_lock_count) return;
+
        inc_autocheck_timer_remove();
        summary_write_cache(mainwin->summaryview);
        main_window_lock(mainwin);
 
-       if (prefs_common.use_extinc && prefs_common.extinc_path) {
-               gint pid;
-
+       if (prefs_common.use_extinc && prefs_common.extinc_cmd) {
                /* external incorporating program */
-               if ((pid = fork()) < 0) {
-                       perror("fork");
+               if (execute_command_line(prefs_common.extinc_cmd, FALSE) < 0) {
                        main_window_unlock(mainwin);
                        inc_autocheck_timer_set();
                        return;
                }
 
-               if (pid == 0) {
-                       execlp(prefs_common.extinc_path,
-                              g_basename(prefs_common.extinc_path),
-                              NULL);
-
-                       /* this will be called when failed */
-                       perror("exec");
-                       _exit(1);
-               }
-
-               /* wait until child process is terminated */
-               waitpid(pid, NULL, 0);
-
                if (prefs_common.inc_local)
                        new_msgs = inc_spool();
        } else {
@@ -240,6 +212,8 @@ void inc_all_account_mail(MainWindow *mainwin)
        IncProgressDialog *inc_dialog;
        gint new_msgs = 0;
 
+       if (inc_lock_count) return;
+
        inc_autocheck_timer_remove();
        summary_write_cache(mainwin->summaryview);
        main_window_lock(mainwin);
@@ -309,6 +283,7 @@ static IncProgressDialog *inc_progress_dialog_create(void)
                           GTK_SIGNAL_FUNC(inc_cancel), dialog);
        gtk_signal_connect(GTK_OBJECT(progress->window), "delete_event",
                           GTK_SIGNAL_FUNC(gtk_true), NULL);
+       /* manage_window_set_transient(GTK_WINDOW(progress->window)); */
 
        progress_dialog_set_value(progress, 0.0);
 
@@ -423,9 +398,6 @@ static gint inc_start(IncProgressDialog *inc_dialog)
        gint error_num = 0;
        gint new_msgs = 0;
 
-       /* gtk_label_set_text(GTK_LABEL(inc_dialog->mainwin->statuslabel),
-                          _("Receiving"));  */
-
        while (inc_dialog->queue_list != NULL) {
                session = inc_dialog->queue_list->data;
                pop3_state = session->pop3_state;
@@ -538,8 +510,6 @@ static gint inc_start(IncProgressDialog *inc_dialog)
                num++;
        }
 
-       /* gtk_label_set_text(GTK_LABEL(inc_dialog->mainwin->statuslabel), "");  */
-
        if (error_num && !prefs_common.noerrorpanel) {
                if (inc_dialog->show_dialog)
                        manage_window_focus_in(inc_dialog->dialog->window,
@@ -674,13 +644,14 @@ static IncState inc_pop3_session_do(IncSession *session)
                                      automaton_input_cb, atm);
 #endif
 
-       gtk_main();
+       while (!atm->terminated)
+               gtk_main_iteration();
 
        log_verbosity_set(FALSE);
        recv_set_ui_func(NULL, NULL);
 
 #if USE_THREADS
-       //pthread_join(sockinfo->connect_thr, NULL);
+       /* pthread_join(sockinfo->connect_thr, NULL); */
 #endif
        automaton_destroy(atm);
 
@@ -689,6 +660,8 @@ static IncState inc_pop3_session_do(IncSession *session)
 
 static gint pop3_automaton_terminate(SockInfo *source, Automaton *atm)
 {
+       if (atm->terminated) return 0;
+
        if (atm->tag > 0) {
                gdk_input_remove(atm->tag);
                atm->tag = 0;
@@ -697,10 +670,8 @@ static gint pop3_automaton_terminate(SockInfo *source, Automaton *atm)
                gtk_timeout_remove(atm->timeout_tag);
                atm->timeout_tag = 0;
        }
-       if (source) {
+       if (source)
                sock_close(source);
-               gtk_main_quit();
-       }
 
        atm->terminated = TRUE;
 
@@ -792,6 +763,7 @@ static gint connection_check_cb(Automaton *atm)
                        manage_window_focus_out(inc_dialog->dialog->window, NULL, NULL);
                }
                pop3_automaton_terminate(sockinfo, atm);
+               state->sockinfo = NULL;
                return FALSE;
        } else if (sockinfo->state == CONN_ESTABLISHED) {
                atm->timeout_tag = 0;
@@ -910,7 +882,8 @@ gint inc_drop_message(const gchar *file, Pop3State *state)
        FolderItem *dropfolder;
        gint val;
        gint msgnum;
-       
+
+       /* get default inbox (perhaps per account) */
        if (state->ac_prefs->inbox) {
                inbox = folder_find_item_from_path(state->ac_prefs->inbox);
                if (!inbox)
@@ -922,7 +895,7 @@ gint inc_drop_message(const gchar *file, Pop3State *state)
                return -1;
        }
 
-       if (prefs_filtering == NULL) {
+       if (global_processing == NULL) {
                /* old filtering */
                if (state->ac_prefs->filter_on_recv) {
                        dropfolder =
@@ -935,8 +908,8 @@ gint inc_drop_message(const gchar *file, Pop3State *state)
                } else
                        dropfolder = inbox;
        } else {
-               /* new filtering */
-               dropfolder = inbox;
+               /* CLAWS: new filtering */
+               dropfolder = folder_get_default_processing();
        }
 
        val = GPOINTER_TO_INT(g_hash_table_lookup
@@ -946,16 +919,19 @@ gint inc_drop_message(const gchar *file, Pop3State *state)
                g_hash_table_insert(state->folder_table, dropfolder,
                                    GINT_TO_POINTER(1));
        }
+       
+       /* add msg file to drop folder */
+       if ((msgnum = folder_item_add_msg(dropfolder, file, TRUE)) < 0) {
+               unlink(file);
+               return -1;
+       }
 
-       if (prefs_filtering == NULL || !state->ac_prefs->filter_on_recv) {
-               if ((msgnum = folder_item_add_msg(dropfolder, file, TRUE)) < 0) {
-                       unlink(file);
-                       return -1;
-               }
+       /* CLAWS: perform filtering actions on dropped message */
+       if (global_processing != NULL) { 
+               if (state->ac_prefs->filter_on_recv)
+                       filter_message(global_processing, inbox, msgnum,
+                                      state->folder_table);
        }
-       else {
-               filter_incoming_message(dropfolder, file, state->folder_table);
-        }              
 
        return 0;
 }
@@ -982,6 +958,8 @@ static void inc_cancel(GtkWidget *widget, gpointer data)
        IncSession *session = dialog->queue_list->data;
        SockInfo *sockinfo = session->pop3_state->sockinfo;
 
+       if (!sockinfo || session->atm->terminated == TRUE) return;
+
 #if USE_THREADS
        if (sockinfo->state == CONN_READY ||
            sockinfo->state == CONN_LOOKUPSUCCESS) {
@@ -993,6 +971,7 @@ static void inc_cancel(GtkWidget *widget, gpointer data)
 
        session->pop3_state->inc_state = INC_CANCEL;
        pop3_automaton_terminate(sockinfo, session->atm);
+       session->pop3_state->sockinfo = NULL;
 }
 
 static gint inc_spool(void)
@@ -1094,6 +1073,17 @@ static gint get_spool(FolderItem *dest, const gchar *mbox)
        return msgs;
 }
 
+void inc_lock(void)
+{
+       inc_lock_count++;
+}
+
+void inc_unlock(void)
+{
+       if (inc_lock_count > 0)
+               inc_lock_count--;
+}
+
 static guint autocheck_timer = 0;
 static gpointer autocheck_data = NULL;
 
@@ -1103,21 +1093,26 @@ void inc_autocheck_timer_init(MainWindow *mainwin)
        inc_autocheck_timer_set();
 }
 
-void inc_autocheck_timer_set(void)
+static void inc_autocheck_timer_set_interval(guint interval)
 {
        inc_autocheck_timer_remove();
 
        if (prefs_common.autochk_newmail && autocheck_data) {
                autocheck_timer = gtk_timeout_add
-                       (prefs_common.autochk_itv * 60000,
-                        inc_autocheck_func,
-                        autocheck_data);
+                       (interval, inc_autocheck_func, autocheck_data);
+               debug_print("added timer = %d\n", autocheck_timer);
        }
 }
 
+void inc_autocheck_timer_set(void)
+{
+       inc_autocheck_timer_set_interval(prefs_common.autochk_itv * 60000);
+}
+
 void inc_autocheck_timer_remove(void)
 {
        if (autocheck_timer) {
+               debug_print("removed timer = %d\n", autocheck_timer);
                gtk_timeout_remove(autocheck_timer);
                autocheck_timer = 0;
        }
@@ -1127,6 +1122,12 @@ static gint inc_autocheck_func(gpointer data)
 {
        MainWindow *mainwin = (MainWindow *)data;
 
+       if (inc_lock_count) {
+               debug_print("autocheck is locked.\n");
+               inc_autocheck_timer_set_interval(1000);
+               return FALSE;
+       }
+
        inc_all_account_mail(mainwin);
 
        return FALSE;