and another one
[claws.git] / src / inc.c
index 8a20a276022f634e2bdea03de207c4621556b893..7811ed89c16b5a99e0c27385b9ca5b2ad1b27393 100644 (file)
--- a/src/inc.c
+++ b/src/inc.c
@@ -31,6 +31,7 @@
 #include <stdio.h>
 #include <unistd.h>
 #include <string.h>
+#include <time.h>
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <sys/wait.h>
@@ -66,6 +67,8 @@
 #include "filtering.h"
 #include "selective_download.h"
 
+static GList *inc_dialog_list = NULL;
+
 static guint inc_lock_count = 0;
 
 static GdkPixmap *currentxpm;
@@ -104,13 +107,14 @@ static gboolean inc_pop3_recv_func        (SockInfo       *sock,
 
 static void inc_put_error              (IncState        istate);
 
-static void inc_cancel                 (GtkWidget      *widget,
+static void inc_cancel_cb              (GtkWidget      *widget,
                                         gpointer        data);
 
 static gint inc_spool                  (void);
 static gint get_spool                  (FolderItem     *dest,
                                         const gchar    *mbox);
 
+static void inc_spool_account(PrefsAccount *account);
 static void inc_all_spool(void);
 static void inc_autocheck_timer_set_interval   (guint           interval);
 static gint inc_autocheck_func                 (gpointer        data);
@@ -142,17 +146,16 @@ static void inc_finished(MainWindow *mainwin, gboolean new_messages)
 
        if (prefs_common.open_inbox_on_inc) {
                item = cur_account && cur_account->inbox
-                       ? folder_find_item_from_path(cur_account->inbox)
+                       ? folder_find_item_from_identifier(cur_account->inbox)
                        : folder_get_default_inbox();
                if (FOLDER_SUMMARY_MISMATCH(item, mainwin->summaryview)) {      
                        folderview_unselect(mainwin->folderview);
                        folderview_select(mainwin->folderview, item);
                }       
-       } else {
+       } else if (prefs_common.scan_all_after_inc) {
                item = mainwin->summaryview->folder_item;
                if (FOLDER_SUMMARY_MISMATCH(item, mainwin->summaryview)) {
-                       folderview_unselect(mainwin->folderview);
-                       folderview_select(mainwin->folderview, item);
+                       folderview_update_item(item, TRUE);
                }       
        }
 }
@@ -163,8 +166,13 @@ void inc_mail(MainWindow *mainwin, gboolean notify)
 
        if (inc_lock_count) return;
 
+       if (prefs_common.work_offline)
+               if (alertpanel(_("Offline warning"), 
+                              _("You're working offline. Override?"),
+                              _("Yes"), _("No"), NULL) != G_ALERTDEFAULT)
+               return;
+
        inc_autocheck_timer_remove();
-       summary_write_cache(mainwin->summaryview);
        main_window_lock(mainwin);
 
        if (prefs_common.use_extinc && prefs_common.extinc_cmd) {
@@ -177,6 +185,9 @@ void inc_mail(MainWindow *mainwin, gboolean notify)
 
                if (prefs_common.inc_local)
                        new_msgs = inc_spool();
+
+               if (new_msgs <= 0)
+                       new_msgs = 1;
        } else {
                if (prefs_common.inc_local)
                        new_msgs = inc_spool();
@@ -190,16 +201,28 @@ void inc_mail(MainWindow *mainwin, gboolean notify)
        inc_autocheck_timer_set();
 }
 
-gint inc_selective_download(MainWindow *mainwin, gint session_type)
+void inc_selective_download(MainWindow *mainwin, PrefsAccount *acc, gint session)
 {
-       PrefsAccount *account = cur_account;
-       gint new_msgs = 0;      
+       GSList *cur;
+       gint new_msgs = 0;
 
-       account->session_type = session_type;
-       new_msgs = inc_account_mail(account, mainwin);
-       account->session_type = RETR_NORMAL;
+       acc->session = session;
+       inc_account_mail(acc, mainwin);
+       acc->session = STYPE_NORMAL;
        
-       return new_msgs;
+       for (cur = acc->msg_list; cur != NULL; cur = cur->next) {
+               HeaderItems *items =(HeaderItems*)cur->data;
+
+               if (items->state == SD_DOWNLOADED && 
+                   items->del_by_old_session == FALSE) {
+                       new_msgs++;                     
+               }
+       }
+
+       if (new_msgs) {
+               inc_finished(mainwin, TRUE);
+               inc_notify_cmd(new_msgs, prefs_common.newmail_notify_manu);
+       }
 }
 
 static gint inc_account_mail(PrefsAccount *account, MainWindow *mainwin)
@@ -208,25 +231,38 @@ static gint inc_account_mail(PrefsAccount *account, MainWindow *mainwin)
        IncSession *session;
        gchar *text[3];
 
-       if (account->protocol == A_IMAP4 || account->protocol == A_NNTP) {
+       switch (account->protocol) {
+       case A_IMAP4:
+       case A_NNTP:
                folderview_check_new(FOLDER(account->folder));
                return 1;
-       }
-
-       session = inc_session_new(account);
-       if (!session) return 0;
-
-       inc_dialog = inc_progress_dialog_create();
-       inc_dialog->queue_list = g_list_append(inc_dialog->queue_list, session);
-       inc_dialog->mainwin = mainwin;
-       session->data = inc_dialog;
 
-       text[0] = NULL;
-       text[1] = account->account_name;
-       text[2] = _("Standby");
-       gtk_clist_append(GTK_CLIST(inc_dialog->dialog->clist), text);
-
-       return inc_start(inc_dialog);
+       case A_POP3:
+       case A_APOP:
+               session = inc_session_new(account);
+               if (!session) return 0;
+               
+               inc_dialog = inc_progress_dialog_create();
+               inc_dialog->queue_list = g_list_append(inc_dialog->queue_list,
+                                                      session);
+               inc_dialog->mainwin = mainwin;
+               session->data = inc_dialog;
+       
+               text[0] = NULL;
+               text[1] = account->account_name;
+               text[2] = _("Standby");
+               gtk_clist_append(GTK_CLIST(inc_dialog->dialog->clist), text);
+               
+               toolbar_set_sensitive(mainwin);
+               main_window_set_menu_sensitive(mainwin);
+               
+               return inc_start(inc_dialog);
+
+       case A_LOCAL:
+               inc_spool_account(account);
+               return 1;
+       }
+       return 0;
 }
 
 void inc_all_account_mail(MainWindow *mainwin, gboolean notify)
@@ -234,15 +270,23 @@ void inc_all_account_mail(MainWindow *mainwin, gboolean notify)
        GList *list, *queue_list = NULL;
        IncProgressDialog *inc_dialog;
        gint new_msgs = 0;
+       
+       if (prefs_common.work_offline)
+               if (alertpanel(_("Offline warning"), 
+                              _("You're working offline. Override?"),
+                              _("Yes"), _("No"), NULL) != G_ALERTDEFAULT)
+               return;
 
        if (inc_lock_count) return;
 
        inc_autocheck_timer_remove();
-       summary_write_cache(mainwin->summaryview);
        main_window_lock(mainwin);
 
-       if (prefs_common.inc_local)
+       if (prefs_common.inc_local) {
                new_msgs = inc_spool();
+               if (new_msgs < 0)
+                       new_msgs = 0;
+       }
 
        list = account_get_list();
        if (!list) {
@@ -253,6 +297,9 @@ void inc_all_account_mail(MainWindow *mainwin, gboolean notify)
                return;
        }
 
+       /* check local folders */
+       inc_all_spool();
+
        /* check IMAP4 folders */
        for (; list != NULL; list = list->next) {
                PrefsAccount *account = list->data;
@@ -265,7 +312,7 @@ void inc_all_account_mail(MainWindow *mainwin, gboolean notify)
        for (list = account_get_list(); list != NULL; list = list->next) {
                IncSession *session;
                PrefsAccount *account = list->data;
-               account->session_type = RETR_NORMAL;
+               account->session = STYPE_NORMAL;
                if (account->recv_at_getall) {
                        session = inc_session_new(account);
                        if (session)
@@ -296,6 +343,9 @@ void inc_all_account_mail(MainWindow *mainwin, gboolean notify)
                gtk_clist_append(GTK_CLIST(inc_dialog->dialog->clist), text);
        }
 
+       toolbar_set_sensitive(mainwin);
+       main_window_set_menu_sensitive(mainwin);
+
        new_msgs += inc_start(inc_dialog);
 
        inc_finished(mainwin, new_msgs > 0);
@@ -315,7 +365,7 @@ static IncProgressDialog *inc_progress_dialog_create(void)
        gtk_window_set_title(GTK_WINDOW(progress->window),
                             _("Retrieving new messages"));
        gtk_signal_connect(GTK_OBJECT(progress->cancel_btn), "clicked",
-                          GTK_SIGNAL_FUNC(inc_cancel), dialog);
+                          GTK_SIGNAL_FUNC(inc_cancel_cb), dialog);
        gtk_signal_connect(GTK_OBJECT(progress->window), "delete_event",
                           GTK_SIGNAL_FUNC(gtk_true), NULL);
        /* manage_window_set_transient(GTK_WINDOW(progress->window)); */
@@ -339,6 +389,8 @@ static IncProgressDialog *inc_progress_dialog_create(void)
        dialog->dialog = progress;
        dialog->queue_list = NULL;
 
+       inc_dialog_list = g_list_append(inc_dialog_list, dialog);
+
        return dialog;
 }
 
@@ -354,6 +406,8 @@ static void inc_progress_dialog_destroy(IncProgressDialog *inc_dialog)
 {
        g_return_if_fail(inc_dialog != NULL);
 
+       inc_dialog_list = g_list_remove(inc_dialog_list, inc_dialog);
+
        gtk_progress_bar_update
                (GTK_PROGRESS_BAR(inc_dialog->mainwin->progressbar), 0.0);
        progress_dialog_destroy(inc_dialog->dialog);
@@ -395,8 +449,10 @@ static Pop3State *inc_pop3_state_new(PrefsAccount *account)
 
        state->ac_prefs = account;
        state->folder_table = g_hash_table_new(NULL, NULL);
+       state->uidl_todelete_list = NULL;
        state->uidl_table = inc_get_uidl_table(account);
        state->inc_state = INC_SUCCESS;
+       state->current_time = time(NULL);
 
        return state;
 }
@@ -415,7 +471,7 @@ static void inc_pop3_state_destroy(Pop3State *state)
                hash_free_strings(state->uidl_table);
                g_hash_table_destroy(state->uidl_table);
        }
-
+       g_slist_free(state->uidl_todelete_list);
        g_free(state->greeting);
        g_free(state->user);
        g_free(state->pass);
@@ -496,7 +552,7 @@ static gint inc_start(IncProgressDialog *inc_dialog)
                }
 
                if (pop3_state->error_val == PS_AUTHFAIL) {
-                       if(!prefs_common.noerrorpanel) {
+                       if(!prefs_common.no_recv_err_panel) {
                                if((prefs_common.recv_dialog_mode == RECV_DIALOG_ALWAYS) ||
                                    ((prefs_common.recv_dialog_mode == RECV_DIALOG_ACTIVE) && focus_window)) {
                                        manage_window_focus_in(inc_dialog->dialog->window, NULL, NULL);
@@ -513,7 +569,6 @@ static gint inc_start(IncProgressDialog *inc_dialog)
                /* CLAWS: perform filtering actions on dropped message */
                if (global_processing != NULL) {
                        FolderItem *processing, *inbox;
-                       Folder *folder;
                        MsgInfo *msginfo;
                        GSList *msglist, *msglist_element;
 
@@ -529,8 +584,7 @@ static gint inc_start(IncProgressDialog *inc_dialog)
                        /* get list of messages in processing */
                        processing = folder_get_default_processing();
                        folder_item_scan(processing);
-                       folder = processing->folder;
-                       msglist = folder->get_msg_list(folder, processing, FALSE);
+                       msglist = folder_item_get_msg_list(processing);
 
                        /* process messages */
                        for(msglist_element = msglist; msglist_element != NULL; msglist_element = msglist_element->next) {
@@ -553,11 +607,8 @@ static gint inc_start(IncProgressDialog *inc_dialog)
 
                new_msgs += pop3_state->cur_total_num;
 
-               if (!prefs_common.scan_all_after_inc) {
-                       folder_item_scan_foreach(pop3_state->folder_table);
-                       folderview_update_item_foreach
-                               (pop3_state->folder_table);
-               }
+               folderview_update_item_foreach
+                       (pop3_state->folder_table, TRUE);
 
                if (pop3_state->error_val == PS_AUTHFAIL &&
                    pop3_state->ac_prefs->tmp_pass) {
@@ -582,7 +633,7 @@ static gint inc_start(IncProgressDialog *inc_dialog)
                num++;
        }
 
-       if (error_num && !prefs_common.noerrorpanel) {
+       if (error_num && !prefs_common.no_recv_err_panel) {
                if (inc_dialog->show_dialog)
                        manage_window_focus_in(inc_dialog->dialog->window,
                                               NULL, NULL);
@@ -616,6 +667,9 @@ static IncState inc_pop3_session_do(IncSession *session)
        gchar *buf;
        static AtmHandler handlers[] = {
                pop3_greeting_recv      ,
+#if USE_SSL
+               pop3_stls_send          , pop3_stls_recv,
+#endif
                pop3_getauth_user_send  , pop3_getauth_user_recv,
                pop3_getauth_pass_send  , pop3_getauth_pass_recv,
                pop3_getauth_apop_send  , pop3_getauth_apop_recv,
@@ -629,7 +683,7 @@ static IncState inc_pop3_session_do(IncSession *session)
                pop3_logout_send        , pop3_logout_recv
        };
 
-       debug_print(_("getting new messages of account %s...\n"),
+       debug_print("getting new messages of account %s...\n",
                    pop3_state->ac_prefs->account_name);
 
        atm = automaton_create(N_POP3_PHASE);
@@ -645,12 +699,13 @@ static IncState inc_pop3_session_do(IncSession *session)
        for (i = POP3_GREETING_RECV; i < N_POP3_PHASE; i++)
                atm->state[i].handler = handlers[i];
        atm->state[POP3_GREETING_RECV].condition = GDK_INPUT_READ;
-       for (i = POP3_GETAUTH_USER_SEND; i < N_POP3_PHASE; ) {
+       for (i = POP3_GREETING_RECV + 1; i < N_POP3_PHASE; ) {
                atm->state[i++].condition = GDK_INPUT_WRITE;
                atm->state[i++].condition = GDK_INPUT_READ;
        }
 
        atm->terminate = (AtmHandler)pop3_automaton_terminate;
+       atm->ui_func = (AtmUIFunc)inc_progress_update;
 
        atm->num = POP3_GREETING_RECV;
 
@@ -658,7 +713,7 @@ static IncState inc_pop3_session_do(IncSession *session)
 #if USE_SSL
        port = pop3_state->ac_prefs->set_popport ?
                pop3_state->ac_prefs->popport :
-               pop3_state->ac_prefs->ssl_pop ? 995 : 110;
+               pop3_state->ac_prefs->ssl_pop == SSL_TUNNEL ? 995 : 110;
 #else
        port = pop3_state->ac_prefs->set_popport ?
                pop3_state->ac_prefs->popport : 110;
@@ -674,7 +729,7 @@ static IncState inc_pop3_session_do(IncSession *session)
        if ((sockinfo = sock_connect(server, port)) == NULL) {
                log_warning(_("Can't connect to POP3 server: %s:%d\n"),
                            server, port);
-               if(!prefs_common.noerrorpanel) {
+               if(!prefs_common.no_recv_err_panel) {
                        if((prefs_common.recv_dialog_mode == RECV_DIALOG_ALWAYS) ||
                            ((prefs_common.recv_dialog_mode == RECV_DIALOG_ACTIVE) && focus_window)) {
                                manage_window_focus_in(inc_dialog->dialog->window, NULL, NULL);
@@ -689,7 +744,8 @@ static IncState inc_pop3_session_do(IncSession *session)
        }
 
 #if USE_SSL
-       if (pop3_state->ac_prefs->ssl_pop && !ssl_init_socket(sockinfo)) {
+       if (pop3_state->ac_prefs->ssl_pop == SSL_TUNNEL &&
+           !ssl_init_socket(sockinfo)) {
                pop3_automaton_terminate(NULL, atm);
                automaton_destroy(atm);
                return INC_CONNECT_ERROR;
@@ -702,6 +758,13 @@ static IncState inc_pop3_session_do(IncSession *session)
        atm->help_sock = sockinfo;
 
        log_verbosity_set(TRUE);
+       /* oha: this messes up inc_progress update:
+          disabling this would avoid the label "Retrieve Header"
+          being overwritten by "Retrieve Message"
+          Setting inc_pop3_recv_func is not necessary
+          since atm already handles the progress dialog ui
+          just fine.
+       */
        recv_set_ui_func(inc_pop3_recv_func, session);
 
        atm->tag = sock_gdk_input_add(sockinfo,
@@ -712,6 +775,7 @@ static IncState inc_pop3_session_do(IncSession *session)
                gtk_main_iteration();
 
        log_verbosity_set(FALSE);
+       /* oha: see above */
        recv_set_ui_func(NULL, NULL);
 
        automaton_destroy(atm);
@@ -745,26 +809,48 @@ static GHashTable *inc_get_uidl_table(PrefsAccount *ac_prefs)
        gchar *path;
        FILE *fp;
        gchar buf[IDLEN + 3];
+       gchar uidl[IDLEN + 3];
+       time_t recv_time;
+       time_t now;
 
        path = g_strconcat(get_rc_dir(), G_DIR_SEPARATOR_S,
-                          "uidl-", ac_prefs->recv_server,
+                          "uidl", G_DIR_SEPARATOR_S, ac_prefs->recv_server,
                           "-", ac_prefs->userid, NULL);
-       if ((fp = fopen(path, "r")) == NULL) {
+       if ((fp = fopen(path, "rb")) == NULL) {
                if (ENOENT != errno) FILE_OP_ERROR(path, "fopen");
                g_free(path);
-               return NULL;
-       }
-       g_free(path);
+               path = g_strconcat(get_rc_dir(), G_DIR_SEPARATOR_S,
+                                  "uidl-", ac_prefs->recv_server,
+                                  "-", ac_prefs->userid, NULL);
+               if ((fp = fopen(path, "rb")) == NULL) {
+                       if (ENOENT != errno) FILE_OP_ERROR(path, "fopen");
+                       g_free(path);
+                       return NULL;
+               }
+               g_free(path);
+       } else 
+               g_free(path);
 
        table = g_hash_table_new(g_str_hash, g_str_equal);
 
+       now = time(NULL);
+
        while (fgets(buf, sizeof(buf), fp) != NULL) {
                strretchomp(buf);
-               g_hash_table_insert(table, g_strdup(buf), GINT_TO_POINTER(1));
+               recv_time = 0;
+               if (sscanf(buf, "%s\t%ld", uidl, &recv_time) != 2) {
+                       if (sscanf(buf, "%s", uidl) != 1)
+                               continue;
+                       else
+                               recv_time = now;
+               }
+               if (recv_time == 0)
+                       recv_time = 1;
+               g_hash_table_insert(table, g_strdup(uidl),
+                                   GINT_TO_POINTER(recv_time));
        }
 
        fclose(fp);
-
        return table;
 }
 
@@ -772,31 +858,25 @@ static void inc_write_uidl_list(Pop3State *state)
 {
        gchar *path;
        FILE *fp;
+       Pop3MsgInfo *msg;
        gint n;
 
        if (!state->uidl_is_valid) return;
 
        path = g_strconcat(get_rc_dir(), G_DIR_SEPARATOR_S,
-                          "uidl-", state->ac_prefs->recv_server,
-                          "-", state->user, NULL);
-       if ((fp = fopen(path, "w")) == NULL) {
+                          "uidl", G_DIR_SEPARATOR_S,
+                          state->ac_prefs->recv_server,
+                          "-", state->ac_prefs->userid, NULL);
+       if ((fp = fopen(path, "wb")) == NULL) {
                FILE_OP_ERROR(path, "fopen");
                g_free(path);
                return;
        }
 
        for (n = 1; n <= state->count; n++) {
-               if (state->msg[n].uidl && state->msg[n].received &&
-                   !state->msg[n].deleted) {
-                       if (fputs(state->msg[n].uidl, fp) == EOF) {
-                               FILE_OP_ERROR(path, "fputs");
-                               break;
-                       }
-                       if (fputc('\n', fp) == EOF) {
-                               FILE_OP_ERROR(path, "fputc");
-                               break;
-                       }
-               }
+               msg = &state->msg[n];
+               if (msg->uidl && msg->received && !msg->deleted)
+                       fprintf(fp, "%s\t%ld\n", msg->uidl, msg->recv_time);
        }
 
        if (fclose(fp) == EOF) FILE_OP_ERROR(path, "fclose");
@@ -850,35 +930,27 @@ void inc_progress_update(Pop3State *state, Pop3Phase phase)
        case POP3_GREETING_RECV:
                break;
        case POP3_GETAUTH_USER_SEND:
-       case POP3_GETAUTH_USER_RECV:
        case POP3_GETAUTH_PASS_SEND:
-       case POP3_GETAUTH_PASS_RECV:
        case POP3_GETAUTH_APOP_SEND:
-       case POP3_GETAUTH_APOP_RECV:
                progress_dialog_set_label(dialog, _("Authenticating..."));
                break;
        case POP3_GETRANGE_STAT_SEND:
-       case POP3_GETRANGE_STAT_RECV:
                progress_dialog_set_label
                        (dialog, _("Getting the number of new messages (STAT)..."));
                break;
        case POP3_GETRANGE_LAST_SEND:
-       case POP3_GETRANGE_LAST_RECV:
                progress_dialog_set_label
                        (dialog, _("Getting the number of new messages (LAST)..."));
                break;
        case POP3_GETRANGE_UIDL_SEND:
-       case POP3_GETRANGE_UIDL_RECV:
                progress_dialog_set_label
                        (dialog, _("Getting the number of new messages (UIDL)..."));
                break;
        case POP3_GETSIZE_LIST_SEND:
-       case POP3_GETSIZE_LIST_RECV:
                progress_dialog_set_label
                        (dialog, _("Getting the size of messages (LIST)..."));
                break;
        case POP3_TOP_SEND:
-       case POP3_TOP_RECV:
                g_snprintf(buf, sizeof(buf),
                           _("Retrieving header (%d / %d)"),
                           state->cur_msg, state->count);
@@ -893,7 +965,6 @@ void inc_progress_update(Pop3State *state, Pop3Phase phase)
                         (gfloat)(state->count));
                break;
        case POP3_RETR_SEND:
-       case POP3_RETR_RECV:
                Xstrdup_a(total_size, to_human_readable(state->total_bytes), return);
                g_snprintf(buf, sizeof(buf),
                           _("Retrieving message (%d / %d) (%s / %s)"),
@@ -911,11 +982,13 @@ void inc_progress_update(Pop3State *state, Pop3Phase phase)
                         (gfloat)(state->total_bytes));
                break;
        case POP3_DELETE_SEND:
-       case POP3_DELETE_RECV:
-               progress_dialog_set_label(dialog, _("Deleting message"));
+               if (state->msg[state->cur_msg].recv_time < state->current_time) {
+                       g_snprintf(buf, sizeof(buf), _("Deleting message %d"),
+                                  state->cur_msg);
+                       progress_dialog_set_label(dialog, buf);
+               }
                break;
        case POP3_LOGOUT_SEND:
-       case POP3_LOGOUT_RECV:
                progress_dialog_set_label(dialog, _("Quitting"));
                break;
        default:
@@ -933,7 +1006,8 @@ gint inc_drop_message(const gchar *file, Pop3State *state)
        /* CLAWS: get default inbox (perhaps per account) */
        if (state->ac_prefs->inbox) {
                /* CLAWS: get destination folder / mailbox */
-               inbox = folder_find_item_from_identifier(state->ac_prefs->inbox);
+               inbox = folder_find_item_from_identifier
+                       (state->ac_prefs->inbox);
                if (!inbox)
                        inbox = folder_get_default_inbox();
        } else
@@ -963,6 +1037,9 @@ gint inc_drop_message(const gchar *file, Pop3State *state)
                              (state->folder_table, dropfolder));
        if (val == 0) {
                folder_item_scan(dropfolder);
+               /* force updating */
+               if (FOLDER_IS_LOCAL(dropfolder->folder))
+                       dropfolder->mtime = 0;
                g_hash_table_insert(state->folder_table, dropfolder,
                                    GINT_TO_POINTER(1));
        }
@@ -980,9 +1057,9 @@ static void inc_put_error(IncState istate)
 {
        switch (istate) {
        case INC_ERROR:
-               if(!prefs_common.noerrorpanel) {
-                       alertpanel_error(_("Error occurred while processing mail."));
-               }
+               if (!prefs_common.no_recv_err_panel)
+                       alertpanel_error
+                               (_("Error occurred while processing mail."));
                break;
        case INC_NOSPACE:
                alertpanel_error(_("No disk space left."));
@@ -992,11 +1069,15 @@ static void inc_put_error(IncState istate)
        }
 }
 
-static void inc_cancel(GtkWidget *widget, gpointer data)
+static void inc_cancel(IncProgressDialog *dialog)
 {
-       IncProgressDialog *dialog = data;
-       IncSession *session = dialog->queue_list->data;
-       SockInfo *sockinfo = session->pop3_state->sockinfo;
+       IncSession *session;
+       SockInfo *sockinfo;
+
+       g_return_if_fail(dialog != NULL);
+
+       session = dialog->queue_list->data;
+       sockinfo = session->pop3_state->sockinfo;
 
        if (!sockinfo || session->atm->terminated == TRUE) return;
 
@@ -1005,6 +1086,24 @@ static void inc_cancel(GtkWidget *widget, gpointer data)
        session->pop3_state->sockinfo = NULL;
 }
 
+gboolean inc_is_active(void)
+{
+       return (inc_dialog_list != NULL);
+}
+
+void inc_cancel_all(void)
+{
+       GList *cur;
+
+       for (cur = inc_dialog_list; cur != NULL; cur = cur->next)
+               inc_cancel((IncProgressDialog *)cur->data);
+}
+
+static void inc_cancel_cb(GtkWidget *widget, gpointer data)
+{
+       inc_cancel((IncProgressDialog *)data);
+}
+
 static gint inc_spool(void)
 {
        gchar *mbox, *logname;
@@ -1023,8 +1122,6 @@ static gint inc_spool(void)
 static void inc_spool_account(PrefsAccount *account)
 {
        FolderItem *inbox;
-       FolderItem *dropfolder;
-       gint val;
 
        if (account->inbox) {
                inbox = folder_find_item_from_path(account->inbox);
@@ -1044,10 +1141,10 @@ static void inc_all_spool(void)
        if (!list) return;
 
        for (; list != NULL; list = list->next) {
-               IncSession *session;
                PrefsAccount *account = list->data;
 
-               if (account->protocol == A_LOCAL)
+               if ((account->protocol == A_LOCAL) &&
+                   (account->recv_at_getall))
                        inc_spool_account(account);
        }
 }
@@ -1063,7 +1160,7 @@ static gint get_spool(FolderItem *dest, const gchar *mbox)
        g_return_val_if_fail(mbox != NULL, -1);
 
        if (!is_file_exist(mbox) || (size = get_file_size(mbox)) == 0) {
-               debug_print(_("no messages in local mailbox.\n"));
+               debug_print("no messages in local mailbox.\n");
                return 0;
        } else if (size < 0)
                return -1;
@@ -1071,15 +1168,15 @@ static gint get_spool(FolderItem *dest, const gchar *mbox)
        if ((lockfd = lock_mbox(mbox, LOCK_FLOCK)) < 0)
                return -1;
 
-       g_snprintf(tmp_mbox, sizeof(tmp_mbox), "%s%ctmpmbox%d",
-                  get_rc_dir(), G_DIR_SEPARATOR, (gint)mbox);
+       g_snprintf(tmp_mbox, sizeof(tmp_mbox), "%s%ctmpmbox.%08x",
+                  get_tmp_dir(), G_DIR_SEPARATOR, (gint)mbox);
 
        if (copy_mbox(mbox, tmp_mbox) < 0) {
                unlock_mbox(mbox, lockfd, LOCK_FLOCK);
                return -1;
        }
 
-       debug_print(_("Getting new messages from %s into %s...\n"),
+       debug_print("Getting new messages from %s into %s...\n",
                    mbox, dest->path);
 
        if (prefs_common.filter_on_inc)
@@ -1094,13 +1191,11 @@ static gint get_spool(FolderItem *dest, const gchar *mbox)
                if (!prefs_common.scan_all_after_inc) {
                g_hash_table_insert(folder_table, dest,
                                    GINT_TO_POINTER(1));
-                       folder_item_scan_foreach(folder_table);
-                       folderview_update_item_foreach(folder_table);
+                       folderview_update_item_foreach(folder_table, TRUE);
                }
                g_hash_table_destroy(folder_table);
        } else if (!prefs_common.scan_all_after_inc) {
-               folder_item_scan(dest);
-               folderview_update_item(dest, FALSE);
+               folderview_update_item(dest, TRUE);
        }
 
        return msgs;
@@ -1135,7 +1230,7 @@ static void inc_notify_cmd(gint new_msgs, gboolean notify)
        else
                buf = g_strdup(prefs_common.newmail_notify_cmd);
 
-       system(buf);
+       execute_command_line(buf, TRUE);
 
        g_free(buf);
 }
@@ -1149,8 +1244,10 @@ void inc_autocheck_timer_init(MainWindow *mainwin)
 static void inc_autocheck_timer_set_interval(guint interval)
 {
        inc_autocheck_timer_remove();
-
-       if (prefs_common.autochk_newmail && autocheck_data) {
+       /* last test is to avoid re-enabling auto_check after modifying 
+          the common preferences */
+       if (prefs_common.autochk_newmail && autocheck_data
+           && prefs_common.work_offline == FALSE) {
                autocheck_timer = gtk_timeout_add
                        (interval, inc_autocheck_func, autocheck_data);
                debug_print("added timer = %d\n", autocheck_timer);