fix bug [14] where new mail notification worked incorrectly with IMAP accounts
[claws.git] / src / inc.c
index 7f5ce9c1bd670e83f092146fd2dcca35beace2c6..3ed19f99524da50faf6acdf45b2874d10fca8841 100644 (file)
--- a/src/inc.c
+++ b/src/inc.c
 #include "progressdialog.h"
 #include "inputdialog.h"
 #include "alertpanel.h"
-#include "filter.h"
 #include "automaton.h"
 #include "folder.h"
 #include "filtering.h"
 #include "selective_download.h"
+#include "log.h"
+#include "hooks.h"
 
 static GList *inc_dialog_list = NULL;
 
@@ -112,8 +113,8 @@ static gint inc_spool                       (void);
 static gint get_spool                  (FolderItem     *dest,
                                         const gchar    *mbox);
 
-static void inc_spool_account(PrefsAccount *account);
-static void inc_all_spool(void);
+static gint inc_spool_account(PrefsAccount *account);
+static gint inc_all_spool(void);
 static void inc_autocheck_timer_set_interval   (guint           interval);
 static gint inc_autocheck_func                 (gpointer        data);
 
@@ -150,17 +151,13 @@ static void inc_finished(MainWindow *mainwin, gboolean new_messages)
                        folderview_unselect(mainwin->folderview);
                        folderview_select(mainwin->folderview, item);
                }       
-       } else if (prefs_common.scan_all_after_inc) {
-               item = mainwin->summaryview->folder_item;
-               if (FOLDER_SUMMARY_MISMATCH(item, mainwin->summaryview)) {
-                       folderview_update_item(item, TRUE);
-               }       
        }
 }
 
 void inc_mail(MainWindow *mainwin, gboolean notify)
 {
        gint new_msgs = 0;
+       gint account_new_msgs = 0;
 
        if (inc_lock_count) return;
 
@@ -170,6 +167,7 @@ void inc_mail(MainWindow *mainwin, gboolean notify)
                               _("Yes"), _("No"), NULL) != G_ALERTDEFAULT)
                return;
 
+       inc_lock();
        inc_autocheck_timer_remove();
        main_window_lock(mainwin);
 
@@ -181,25 +179,28 @@ void inc_mail(MainWindow *mainwin, gboolean notify)
                        return;
                }
 
-               if (prefs_common.inc_local)
-                       new_msgs = inc_spool();
-
-               if (new_msgs <= 0)
-                       new_msgs = 1;
+               if (prefs_common.inc_local) {
+                       account_new_msgs = inc_spool();
+                       if (account_new_msgs > 0)
+                               new_msgs += account_new_msgs;
+               }
        } else {
                if (prefs_common.inc_local) {
-                       new_msgs = inc_spool();
-                       if (new_msgs < 0)
-                               new_msgs = 0;
+                       account_new_msgs = inc_spool();
+                       if (account_new_msgs > 0)
+                               new_msgs += account_new_msgs;
                }
                cur_account->session = STYPE_NORMAL;
-               new_msgs += inc_account_mail(cur_account, mainwin);
+               account_new_msgs = inc_account_mail(cur_account, mainwin);
+               if (account_new_msgs > 0)
+                       new_msgs += account_new_msgs;
        }
 
        inc_finished(mainwin, new_msgs > 0);
        main_window_unlock(mainwin);
        inc_notify_cmd(new_msgs, notify);
        inc_autocheck_timer_set();
+       inc_unlock();
 }
 
 void inc_selective_download(MainWindow *mainwin, PrefsAccount *acc, gint session)
@@ -237,12 +238,15 @@ static gint inc_account_mail(PrefsAccount *account, MainWindow *mainwin)
        IncProgressDialog *inc_dialog;
        IncSession *session;
        gchar *text[3];
+       FolderItem *item = NULL;
+       
+       if(mainwin && mainwin->summaryview)
+               item = mainwin->summaryview->folder_item;
 
        switch (account->protocol) {
        case A_IMAP4:
        case A_NNTP:
-               folderview_check_new(FOLDER(account->folder));
-               return 1;
+               return folderview_check_new(FOLDER(account->folder));
 
        case A_POP3:
        case A_APOP:
@@ -261,15 +265,17 @@ static gint inc_account_mail(PrefsAccount *account, MainWindow *mainwin)
                gtk_clist_append(GTK_CLIST(inc_dialog->dialog->clist), text);
                
                if (mainwin) {
-                       toolbar_set_sensitive(mainwin);
+                       toolbar_main_set_sensitive(mainwin);
                        main_window_set_menu_sensitive(mainwin);
                }
                        
                return inc_start(inc_dialog);
 
        case A_LOCAL:
-               inc_spool_account(account);
-               return 1;
+               return inc_spool_account(account);
+
+       default:
+               break;
        }
        return 0;
 }
@@ -279,6 +285,7 @@ void inc_all_account_mail(MainWindow *mainwin, gboolean notify)
        GList *list, *queue_list = NULL;
        IncProgressDialog *inc_dialog;
        gint new_msgs = 0;
+       gint account_new_msgs = 0;
        
        if (prefs_common.work_offline)
                if (alertpanel(_("Offline warning"), 
@@ -292,9 +299,9 @@ void inc_all_account_mail(MainWindow *mainwin, gboolean notify)
        main_window_lock(mainwin);
 
        if (prefs_common.inc_local) {
-               new_msgs = inc_spool();
-               if (new_msgs < 0)
-                       new_msgs = 0;
+               account_new_msgs = inc_spool();
+               if (account_new_msgs > 0)
+                       new_msgs += account_new_msgs;   
        }
 
        list = account_get_list();
@@ -307,14 +314,19 @@ void inc_all_account_mail(MainWindow *mainwin, gboolean notify)
        }
 
        /* check local folders */
-       inc_all_spool();
+       account_new_msgs = inc_all_spool();
+       if (account_new_msgs > 0)
+               new_msgs += account_new_msgs;
 
        /* check IMAP4 folders */
        for (; list != NULL; list = list->next) {
                PrefsAccount *account = list->data;
                if ((account->protocol == A_IMAP4 ||
-                    account->protocol == A_NNTP) && account->recv_at_getall)
-                       folderview_check_new(FOLDER(account->folder));
+                    account->protocol == A_NNTP) && account->recv_at_getall) {
+                       FolderItem *item = mainwin->summaryview->folder_item;
+
+                       new_msgs += folderview_check_new(FOLDER(account->folder));
+               }
        }
 
        /* check POP3 accounts */
@@ -352,11 +364,10 @@ void inc_all_account_mail(MainWindow *mainwin, gboolean notify)
                gtk_clist_append(GTK_CLIST(inc_dialog->dialog->clist), text);
        }
 
-       toolbar_set_sensitive(mainwin);
+       toolbar_main_set_sensitive(mainwin);
        main_window_set_menu_sensitive(mainwin);
 
-       new_msgs += inc_start(inc_dialog);
-
+       new_msgs = inc_start(inc_dialog);
        inc_finished(mainwin, new_msgs > 0);
        main_window_unlock(mainwin);
        inc_notify_cmd(new_msgs, notify);
@@ -439,7 +450,6 @@ static IncSession *inc_session_new(PrefsAccount *account)
        session = g_new0(IncSession, 1);
        session->pop3_state = pop3_state_new(account);
        session->pop3_state->data = session;
-       session->folder_table = g_hash_table_new(NULL, NULL);
 
        return session;
 }
@@ -449,7 +459,6 @@ static void inc_session_destroy(IncSession *session)
        g_return_if_fail(session != NULL);
 
        pop3_state_destroy(session->pop3_state);
-       g_hash_table_destroy(session->folder_table);
        g_free(session);
 }
 
@@ -464,6 +473,9 @@ static gint inc_start(IncProgressDialog *inc_dialog)
        gint new_msgs = 0;
        gchar *msg;
        gchar *fin_msg;
+       FolderItem *processing, *inbox;
+       MsgInfo *msginfo;
+       GSList *msglist, *msglist_element;
 
        while (inc_dialog->queue_list != NULL) {
                session = inc_dialog->queue_list->data;
@@ -534,7 +546,9 @@ static gint inc_start(IncProgressDialog *inc_dialog)
                        gtk_clist_set_text(clist, num, 2, _("Locked"));
                        break;
                case INC_ERROR:
-               case INC_NOSPACE:
+               case INC_NO_SPACE:
+               case INC_IO_ERROR:
+               case INC_SOCKET_ERROR:
                        gtk_clist_set_pixmap(clist, num, 0, errorxpm, errorxpmmask);
                        gtk_clist_set_text(clist, num, 2, _("Error"));
                        break;
@@ -559,55 +573,47 @@ static gint inc_start(IncProgressDialog *inc_dialog)
                        }
                }
 
-               statusbar_pop_all();
-
                /* CLAWS: perform filtering actions on dropped message */
-               if (global_processing != NULL) {
-                       FolderItem *processing, *inbox;
-                       MsgInfo *msginfo;
-                       GSList *msglist, *msglist_element;
-
-                       /* CLAWS: get default inbox (perhaps per account) */
-                       if (pop3_state->ac_prefs->inbox) {
-                               /* CLAWS: get destination folder / mailbox */
-                               inbox = folder_find_item_from_identifier(pop3_state->ac_prefs->inbox);
-                               if (!inbox)
-                                       inbox = folder_get_default_inbox();
-                       } else
+               /* CLAWS: get default inbox (perhaps per account) */
+               if (pop3_state->ac_prefs->inbox) {
+                       /* CLAWS: get destination folder / mailbox */
+                       inbox = folder_find_item_from_identifier(pop3_state->ac_prefs->inbox);
+                       if (!inbox)
                                inbox = folder_get_default_inbox();
+               } else
+                       inbox = folder_get_default_inbox();
 
-                       /* get list of messages in processing */
-                       processing = folder_get_default_processing();
-                       folder_item_scan(processing);
-                       msglist = folder_item_get_msg_list(processing);
+               /* get list of messages in processing */
+               processing = folder_get_default_processing();
+               folder_item_scan(processing);
+               msglist = folder_item_get_msg_list(processing);
 
-                       /* process messages */
-                       for(msglist_element = msglist; msglist_element != NULL; msglist_element = msglist_element->next) {
-                               msginfo = (MsgInfo *) msglist_element->data;
+               folder_item_update_freeze();
+
+               /* process messages */
+               for(msglist_element = msglist; msglist_element != NULL; msglist_element = msglist_element->next) {
+                       MailFilteringData mail_filtering_data;
+                       msginfo = (MsgInfo *) msglist_element->data;
+                       
+                       mail_filtering_data.msginfo = msginfo;
+                       
+                       if (!hooks_invoke(MAIL_FILTERING_HOOKLIST, &mail_filtering_data)) {
                                /* filter if enabled in prefs or move to inbox if not */
-                               if(pop3_state->ac_prefs->filter_on_recv) {
+                               if(global_processing && pop3_state->ac_prefs->filter_on_recv) {
                                        filter_message_by_msginfo_with_inbox(global_processing, msginfo,
-                                                                            session->folder_table,
                                                                             inbox);
                                } else {
                                        folder_item_move_msg(inbox, msginfo);
-                                       g_hash_table_insert(session->folder_table, inbox,
-                                                           GINT_TO_POINTER(1));
                                }
-                               procmsg_msginfo_free(msginfo);
                        }
-                       g_slist_free(msglist);
+                       procmsg_msginfo_free(msginfo);
                }
+               g_slist_free(msglist);
 
+               folder_item_update_thaw();
 
-               new_msgs += pop3_state->cur_total_num;
 
-               if (!prefs_common.scan_all_after_inc) {
-                       folder_item_scan_foreach(session->folder_table);
-                       folderview_update_item_foreach
-                               (session->folder_table,
-                                !prefs_common.open_inbox_on_inc);
-               }
+               new_msgs += pop3_state->cur_total_num;
 
                if (pop3_state->error_val == PS_AUTHFAIL &&
                    pop3_state->ac_prefs->tmp_pass) {
@@ -619,7 +625,10 @@ static gint inc_start(IncProgressDialog *inc_dialog)
 
                if (inc_state != INC_SUCCESS && inc_state != INC_CANCEL) {
                        error_num++;
-                       if (inc_state == INC_NOSPACE) {
+                       if (inc_state == INC_ERROR    ||
+                           inc_state == INC_NO_SPACE ||
+                           inc_state == INC_IO_ERROR ||
+                           inc_state == INC_SOCKET_ERROR) {
                                inc_put_error(inc_state);
                                break;
                        }
@@ -644,7 +653,7 @@ static gint inc_start(IncProgressDialog *inc_dialog)
                if (inc_dialog->show_dialog)
                        manage_window_focus_in(inc_dialog->dialog->window,
                                               NULL, NULL);
-               alertpanel_error(_("Some errors occurred while getting mail."));
+               alertpanel_error_log(_("Some errors occurred while getting mail."));
                if (inc_dialog->show_dialog)
                        manage_window_focus_out(inc_dialog->dialog->window,
                                                NULL, NULL);
@@ -683,7 +692,7 @@ static IncState inc_pop3_session_do(IncSession *session)
        gchar *buf;
        static AtmHandler handlers[] = {
                pop3_greeting_recv      ,
-#if USE_SSL
+#if USE_OPENSSL
                pop3_stls_send          , pop3_stls_recv,
 #endif
                pop3_getauth_user_send  , pop3_getauth_user_recv,
@@ -715,10 +724,10 @@ static IncState inc_pop3_session_do(IncSession *session)
 
        for (i = POP3_GREETING_RECV; i < N_POP3_PHASE; i++)
                atm->state[i].handler = handlers[i];
-       atm->state[POP3_GREETING_RECV].condition = GDK_INPUT_READ;
+       atm->state[POP3_GREETING_RECV].condition = (G_IO_IN | G_IO_HUP | G_IO_ERR);
        for (i = POP3_GREETING_RECV + 1; i < N_POP3_PHASE; ) {
-               atm->state[i++].condition = GDK_INPUT_WRITE;
-               atm->state[i++].condition = GDK_INPUT_READ;
+               atm->state[i++].condition = (G_IO_OUT | G_IO_ERR);
+               atm->state[i++].condition = (G_IO_IN | G_IO_HUP | G_IO_ERR);
        }
 
        atm->terminate = (AtmHandler)pop3_automaton_terminate;
@@ -727,7 +736,7 @@ static IncState inc_pop3_session_do(IncSession *session)
        atm->num = POP3_GREETING_RECV;
 
        server = pop3_state->ac_prefs->recv_server;
-#if USE_SSL
+#if USE_OPENSSL
        port = pop3_state->ac_prefs->set_popport ?
                pop3_state->ac_prefs->popport :
                pop3_state->ac_prefs->ssl_pop == SSL_TUNNEL ? 995 : 110;
@@ -741,7 +750,6 @@ static IncState inc_pop3_session_do(IncSession *session)
        progress_dialog_set_label(inc_dialog->dialog, buf);
        g_free(buf);
        GTK_EVENTS_FLUSH();
-       statusbar_pop_all();
 
        if ((sockinfo = sock_connect(server, port)) == NULL) {
                log_warning(_("Can't connect to POP3 server: %s:%d\n"),
@@ -761,10 +769,10 @@ static IncState inc_pop3_session_do(IncSession *session)
                return INC_CONNECT_ERROR;
        }
 
-#if USE_SSL
+#if USE_OPENSSL
        if (pop3_state->ac_prefs->ssl_pop == SSL_TUNNEL &&
            !ssl_init_socket(sockinfo)) {
-               pop3_automaton_terminate(NULL, atm);
+               pop3_automaton_terminate(sockinfo, atm);
                automaton_destroy(atm);
                session->inc_state = INC_CONNECT_ERROR;
                return INC_CONNECT_ERROR;
@@ -776,7 +784,7 @@ static IncState inc_pop3_session_do(IncSession *session)
        pop3_state->sockinfo = sockinfo;
        atm->help_sock = sockinfo;
 
-       log_verbosity_set(TRUE);
+       statusbar_verbosity_set(TRUE);
        /* oha: this messes up inc_progress update:
           disabling this would avoid the label "Retrieve Header"
           being overwritten by "Retrieve Message"
@@ -786,14 +794,17 @@ static IncState inc_pop3_session_do(IncSession *session)
        */
        recv_set_ui_func(inc_pop3_recv_func, session);
 
-       atm->tag = sock_gdk_input_add(sockinfo,
-                                     atm->state[atm->num].condition,
-                                     automaton_input_cb, atm);
+       atm->tag = sock_input_add(sockinfo,
+                                 atm->state[atm->num].condition,
+                                 automaton_input_cb, atm);
 
-       while (!atm->terminated)
+       while (!atm->terminated && !atm->cancelled)
                gtk_main_iteration();
 
-       log_verbosity_set(FALSE);
+       if (!atm->terminated)
+               pop3_automaton_terminate(sockinfo, atm);
+
+       statusbar_verbosity_set(FALSE);
        /* oha: see above */
        recv_set_ui_func(NULL, NULL);
 
@@ -810,7 +821,10 @@ static IncState inc_pop3_session_do(IncSession *session)
                session->inc_state = INC_AUTH_FAILED;
                break;
        case PS_IOERR:
-               session->inc_state = INC_NOSPACE;
+               session->inc_state = INC_IO_ERROR;
+               break;
+       case PS_SOCKET:
+               session->inc_state = INC_SOCKET_ERROR;
                break;
        case PS_LOCKBUSY:
                session->inc_state = INC_LOCKED;
@@ -964,8 +978,6 @@ gint inc_drop_message(const gchar *file, Pop3State *state)
 {
        FolderItem *inbox;
        FolderItem *dropfolder;
-       IncSession *session = (IncSession *)state->data;
-       gint val;
        gint msgnum;
 
        /* CLAWS: get default inbox (perhaps per account) */
@@ -983,32 +995,8 @@ gint inc_drop_message(const gchar *file, Pop3State *state)
        }
 
        /* CLAWS: claws uses a global .processing folder for the filtering. */
-       if (global_processing == NULL) {
-               if (state->ac_prefs->filter_on_recv) {
-                       dropfolder =
-                               filter_get_dest_folder(prefs_common.fltlist, file);
-                       if (!dropfolder) dropfolder = inbox;
-                       else if (!strcmp(dropfolder->path, FILTER_NOT_RECEIVE)) {
-                               g_warning(_("a message won't be received\n"));
-                               return 1;
-                       }
-               } else
-                       dropfolder = inbox;
-       } else {
-               dropfolder = folder_get_default_processing();
-       }
+       dropfolder = folder_get_default_processing();
 
-       val = GPOINTER_TO_INT(g_hash_table_lookup
-                             (session->folder_table, dropfolder));
-       if (val == 0) {
-               folder_item_scan(dropfolder);
-               /* force updating */
-               if (FOLDER_IS_LOCAL(dropfolder->folder))
-                       dropfolder->mtime = 0;
-               g_hash_table_insert(session->folder_table, dropfolder,
-                                   GINT_TO_POINTER(1));
-       }
-       
        /* add msg file to drop folder */
        if ((msgnum = folder_item_add_msg(dropfolder, file, TRUE)) < 0) {
                unlink(file);
@@ -1026,9 +1014,15 @@ static void inc_put_error(IncState istate)
                        alertpanel_error
                                (_("Error occurred while processing mail."));
                break;
-       case INC_NOSPACE:
+       case INC_NO_SPACE:
                alertpanel_error(_("No disk space left."));
                break;
+       case INC_IO_ERROR:
+               alertpanel_error(_("Can't write file."));
+               break;
+       case INC_SOCKET_ERROR:
+               alertpanel_error(_("Socket error."));
+               break;
        case INC_LOCKED:
                if (!prefs_common.no_recv_err_panel)
                        alertpanel_error(_("Mailbox is locked."));
@@ -1106,7 +1100,7 @@ static gint inc_spool(void)
        return msgs;
 }
 
-static void inc_spool_account(PrefsAccount *account)
+static gint inc_spool_account(PrefsAccount *account)
 {
        FolderItem *inbox;
 
@@ -1117,23 +1111,30 @@ static void inc_spool_account(PrefsAccount *account)
        } else
                inbox = folder_get_default_inbox();
 
-       get_spool(inbox, account->local_mbox);
+       return get_spool(inbox, account->local_mbox);
 }
 
-static void inc_all_spool(void)
+static gint inc_all_spool(void)
 {
        GList *list = NULL;
+       gint new_msgs = 0;
+       gint account_new_msgs = 0;
 
        list = account_get_list();
-       if (!list) return;
+       if (!list) return 0;
 
        for (; list != NULL; list = list->next) {
                PrefsAccount *account = list->data;
 
                if ((account->protocol == A_LOCAL) &&
-                   (account->recv_at_getall))
-                       inc_spool_account(account);
+                   (account->recv_at_getall)) {
+                       account_new_msgs = inc_spool_account(account);
+                       if (account_new_msgs > 0)
+                               new_msgs += account_new_msgs;
+               }
        }
+
+       return new_msgs;
 }
 
 static gint get_spool(FolderItem *dest, const gchar *mbox)
@@ -1141,7 +1142,6 @@ static gint get_spool(FolderItem *dest, const gchar *mbox)
        gint msgs, size;
        gint lockfd;
        gchar tmp_mbox[MAXPATHLEN + 1];
-       GHashTable *folder_table = NULL;
 
        g_return_val_if_fail(dest != NULL, -1);
        g_return_val_if_fail(mbox != NULL, -1);
@@ -1166,26 +1166,12 @@ static gint get_spool(FolderItem *dest, const gchar *mbox)
        debug_print("Getting new messages from %s into %s...\n",
                    mbox, dest->path);
 
-       if (prefs_common.filter_on_inc)
-               folder_table = g_hash_table_new(NULL, NULL);
-       msgs = proc_mbox(dest, tmp_mbox, folder_table);
+       msgs = proc_mbox(dest, tmp_mbox);
 
        unlink(tmp_mbox);
        if (msgs >= 0) empty_mbox(mbox);
        unlock_mbox(mbox, lockfd, LOCK_FLOCK);
 
-       if (folder_table) {
-               if (!prefs_common.scan_all_after_inc) {
-               g_hash_table_insert(folder_table, dest,
-                                   GINT_TO_POINTER(1));
-                       folderview_update_item_foreach
-                               (folder_table, !prefs_common.open_inbox_on_inc);
-               }
-               g_hash_table_destroy(folder_table);
-       } else if (!prefs_common.scan_all_after_inc) {
-               folderview_update_item(dest, TRUE);
-       }
-
        return msgs;
 }