fix bug [14] where new mail notification worked incorrectly with IMAP accounts
[claws.git] / src / inc.c
index 181d234dd2bf0001f7954faafcd16d5413794e93..3ed19f99524da50faf6acdf45b2874d10fca8841 100644 (file)
--- a/src/inc.c
+++ b/src/inc.c
@@ -66,6 +66,7 @@
 #include "filtering.h"
 #include "selective_download.h"
 #include "log.h"
+#include "hooks.h"
 
 static GList *inc_dialog_list = NULL;
 
@@ -112,8 +113,8 @@ static gint inc_spool                       (void);
 static gint get_spool                  (FolderItem     *dest,
                                         const gchar    *mbox);
 
-static void inc_spool_account(PrefsAccount *account);
-static void inc_all_spool(void);
+static gint inc_spool_account(PrefsAccount *account);
+static gint inc_all_spool(void);
 static void inc_autocheck_timer_set_interval   (guint           interval);
 static gint inc_autocheck_func                 (gpointer        data);
 
@@ -150,17 +151,13 @@ static void inc_finished(MainWindow *mainwin, gboolean new_messages)
                        folderview_unselect(mainwin->folderview);
                        folderview_select(mainwin->folderview, item);
                }       
-       } else if (prefs_common.scan_all_after_inc) {
-               item = mainwin->summaryview->folder_item;
-               if (FOLDER_SUMMARY_MISMATCH(item, mainwin->summaryview)) {
-                       folder_update_item(item, TRUE);
-               }       
        }
 }
 
 void inc_mail(MainWindow *mainwin, gboolean notify)
 {
        gint new_msgs = 0;
+       gint account_new_msgs = 0;
 
        if (inc_lock_count) return;
 
@@ -182,19 +179,21 @@ void inc_mail(MainWindow *mainwin, gboolean notify)
                        return;
                }
 
-               if (prefs_common.inc_local)
-                       new_msgs = inc_spool();
-
-               if (new_msgs <= 0)
-                       new_msgs = 1;
+               if (prefs_common.inc_local) {
+                       account_new_msgs = inc_spool();
+                       if (account_new_msgs > 0)
+                               new_msgs += account_new_msgs;
+               }
        } else {
                if (prefs_common.inc_local) {
-                       new_msgs = inc_spool();
-                       if (new_msgs < 0)
-                               new_msgs = 0;
+                       account_new_msgs = inc_spool();
+                       if (account_new_msgs > 0)
+                               new_msgs += account_new_msgs;
                }
                cur_account->session = STYPE_NORMAL;
-               new_msgs += inc_account_mail(cur_account, mainwin);
+               account_new_msgs = inc_account_mail(cur_account, mainwin);
+               if (account_new_msgs > 0)
+                       new_msgs += account_new_msgs;
        }
 
        inc_finished(mainwin, new_msgs > 0);
@@ -247,11 +246,7 @@ static gint inc_account_mail(PrefsAccount *account, MainWindow *mainwin)
        switch (account->protocol) {
        case A_IMAP4:
        case A_NNTP:
-               folderview_check_new(FOLDER(account->folder));
-               if (!prefs_common.scan_all_after_inc && item != NULL &&
-                   FOLDER(account->folder) == item->folder)
-                       folder_update_item(item, TRUE);
-               return 1;
+               return folderview_check_new(FOLDER(account->folder));
 
        case A_POP3:
        case A_APOP:
@@ -270,15 +265,14 @@ static gint inc_account_mail(PrefsAccount *account, MainWindow *mainwin)
                gtk_clist_append(GTK_CLIST(inc_dialog->dialog->clist), text);
                
                if (mainwin) {
-                       toolbar_set_sensitive(mainwin);
+                       toolbar_main_set_sensitive(mainwin);
                        main_window_set_menu_sensitive(mainwin);
                }
                        
                return inc_start(inc_dialog);
 
        case A_LOCAL:
-               inc_spool_account(account);
-               return 1;
+               return inc_spool_account(account);
 
        default:
                break;
@@ -291,6 +285,7 @@ void inc_all_account_mail(MainWindow *mainwin, gboolean notify)
        GList *list, *queue_list = NULL;
        IncProgressDialog *inc_dialog;
        gint new_msgs = 0;
+       gint account_new_msgs = 0;
        
        if (prefs_common.work_offline)
                if (alertpanel(_("Offline warning"), 
@@ -304,9 +299,9 @@ void inc_all_account_mail(MainWindow *mainwin, gboolean notify)
        main_window_lock(mainwin);
 
        if (prefs_common.inc_local) {
-               new_msgs = inc_spool();
-               if (new_msgs < 0)
-                       new_msgs = 0;
+               account_new_msgs = inc_spool();
+               if (account_new_msgs > 0)
+                       new_msgs += account_new_msgs;   
        }
 
        list = account_get_list();
@@ -319,7 +314,9 @@ void inc_all_account_mail(MainWindow *mainwin, gboolean notify)
        }
 
        /* check local folders */
-       inc_all_spool();
+       account_new_msgs = inc_all_spool();
+       if (account_new_msgs > 0)
+               new_msgs += account_new_msgs;
 
        /* check IMAP4 folders */
        for (; list != NULL; list = list->next) {
@@ -328,10 +325,7 @@ void inc_all_account_mail(MainWindow *mainwin, gboolean notify)
                     account->protocol == A_NNTP) && account->recv_at_getall) {
                        FolderItem *item = mainwin->summaryview->folder_item;
 
-                       folderview_check_new(FOLDER(account->folder));
-                       if (!prefs_common.scan_all_after_inc && item != NULL &&
-                           FOLDER(account->folder) == item->folder)
-                               folder_update_item(item, TRUE);
+                       new_msgs += folderview_check_new(FOLDER(account->folder));
                }
        }
 
@@ -370,11 +364,10 @@ void inc_all_account_mail(MainWindow *mainwin, gboolean notify)
                gtk_clist_append(GTK_CLIST(inc_dialog->dialog->clist), text);
        }
 
-       toolbar_set_sensitive(mainwin);
+       toolbar_main_set_sensitive(mainwin);
        main_window_set_menu_sensitive(mainwin);
 
-       new_msgs += inc_start(inc_dialog);
-
+       new_msgs = inc_start(inc_dialog);
        inc_finished(mainwin, new_msgs > 0);
        main_window_unlock(mainwin);
        inc_notify_cmd(new_msgs, notify);
@@ -595,27 +588,32 @@ static gint inc_start(IncProgressDialog *inc_dialog)
                folder_item_scan(processing);
                msglist = folder_item_get_msg_list(processing);
 
+               folder_item_update_freeze();
+
                /* process messages */
                for(msglist_element = msglist; msglist_element != NULL; msglist_element = msglist_element->next) {
+                       MailFilteringData mail_filtering_data;
                        msginfo = (MsgInfo *) msglist_element->data;
-                       /* filter if enabled in prefs or move to inbox if not */
-                       if(global_processing && pop3_state->ac_prefs->filter_on_recv) {
-                               filter_message_by_msginfo_with_inbox(global_processing, msginfo,
-                                                                    inbox);
-                       } else {
-                               folder_item_move_msg(inbox, msginfo);
+                       
+                       mail_filtering_data.msginfo = msginfo;
+                       
+                       if (!hooks_invoke(MAIL_FILTERING_HOOKLIST, &mail_filtering_data)) {
+                               /* filter if enabled in prefs or move to inbox if not */
+                               if(global_processing && pop3_state->ac_prefs->filter_on_recv) {
+                                       filter_message_by_msginfo_with_inbox(global_processing, msginfo,
+                                                                            inbox);
+                               } else {
+                                       folder_item_move_msg(inbox, msginfo);
+                               }
                        }
                        procmsg_msginfo_free(msginfo);
                }
                g_slist_free(msglist);
 
+               folder_item_update_thaw();
 
-               new_msgs += pop3_state->cur_total_num;
 
-               if (!prefs_common.scan_all_after_inc) {
-                       folder_update_items_when_required
-                                (!prefs_common.open_inbox_on_inc);
-               }
+               new_msgs += pop3_state->cur_total_num;
 
                if (pop3_state->error_val == PS_AUTHFAIL &&
                    pop3_state->ac_prefs->tmp_pass) {
@@ -655,7 +653,7 @@ static gint inc_start(IncProgressDialog *inc_dialog)
                if (inc_dialog->show_dialog)
                        manage_window_focus_in(inc_dialog->dialog->window,
                                               NULL, NULL);
-               alertpanel_error(_("Some errors occurred while getting mail."));
+               alertpanel_error_log(_("Some errors occurred while getting mail."));
                if (inc_dialog->show_dialog)
                        manage_window_focus_out(inc_dialog->dialog->window,
                                                NULL, NULL);
@@ -1102,7 +1100,7 @@ static gint inc_spool(void)
        return msgs;
 }
 
-static void inc_spool_account(PrefsAccount *account)
+static gint inc_spool_account(PrefsAccount *account)
 {
        FolderItem *inbox;
 
@@ -1113,23 +1111,30 @@ static void inc_spool_account(PrefsAccount *account)
        } else
                inbox = folder_get_default_inbox();
 
-       get_spool(inbox, account->local_mbox);
+       return get_spool(inbox, account->local_mbox);
 }
 
-static void inc_all_spool(void)
+static gint inc_all_spool(void)
 {
        GList *list = NULL;
+       gint new_msgs = 0;
+       gint account_new_msgs = 0;
 
        list = account_get_list();
-       if (!list) return;
+       if (!list) return 0;
 
        for (; list != NULL; list = list->next) {
                PrefsAccount *account = list->data;
 
                if ((account->protocol == A_LOCAL) &&
-                   (account->recv_at_getall))
-                       inc_spool_account(account);
+                   (account->recv_at_getall)) {
+                       account_new_msgs = inc_spool_account(account);
+                       if (account_new_msgs > 0)
+                               new_msgs += account_new_msgs;
+               }
        }
+
+       return new_msgs;
 }
 
 static gint get_spool(FolderItem *dest, const gchar *mbox)
@@ -1167,13 +1172,6 @@ static gint get_spool(FolderItem *dest, const gchar *mbox)
        if (msgs >= 0) empty_mbox(mbox);
        unlock_mbox(mbox, lockfd, LOCK_FLOCK);
 
-       if (!prefs_common.scan_all_after_inc) {
-               folder_update_items_when_required
-                       (!prefs_common.open_inbox_on_inc);
-       } else if (!prefs_common.scan_all_after_inc) {
-               folder_update_item(dest, TRUE);
-       }
-
        return msgs;
 }