sync with 0.8.11cvs22
[claws.git] / src / imap.c
index 9454fd5d1cff1c9daf84107a22cfc80a918ddb6d..ac720e433bfa1bf2a6055ba44ea7491b92adff18 100644 (file)
@@ -69,6 +69,8 @@
        }                                                       \
 }
 
+typedef gchar * IMAPSet;
+
 struct _IMAPFolderItem
 {
        FolderItem item;
@@ -78,7 +80,40 @@ struct _IMAPFolderItem
        GSList *uid_list;
 };
 
-static GList *session_list = NULL;
+static Folder *imap_folder_new(const gchar * name, const gchar * path);
+static void imap_folder_destroy(Folder * folder);
+
+static Session *imap_session_new(const PrefsAccount * account);
+static void imap_session_authenticate(IMAPSession * session,
+                                     const PrefsAccount * account);
+static void imap_session_destroy(Session * session);
+
+static gchar *imap_fetch_msg(Folder * folder, FolderItem * item, gint uid);
+static gint imap_add_msg(Folder * folder,
+                        FolderItem * dest,
+                        const gchar * file, gboolean remove_source);
+
+static gint imap_copy_msg(Folder * folder,
+                         FolderItem * dest, MsgInfo * msginfo);
+
+static gint imap_remove_msg(Folder * folder, FolderItem * item, gint uid);
+static gint imap_remove_all_msg(Folder * folder, FolderItem * item);
+
+static gboolean imap_is_msg_changed(Folder * folder,
+                                   FolderItem * item, MsgInfo * msginfo);
+
+static gint imap_scan_folder(Folder * folder, FolderItem * item);
+static void imap_scan_tree(Folder * folder);
+
+static gint imap_create_tree(Folder * folder);
+
+static FolderItem *imap_create_folder(Folder * folder,
+                                     FolderItem * parent,
+                                     const gchar * name);
+static gint imap_rename_folder(Folder * folder,
+                              FolderItem * item, const gchar * name);
+static gint imap_remove_folder(Folder * folder, FolderItem * item);
+
 
 static gint imap_cmd_count = 0;
 
@@ -109,17 +144,7 @@ static gint imap_do_copy           (Folder         *folder,
                                         FolderItem     *dest,
                                         MsgInfo        *msginfo,
                                         gboolean        remove_source);
-#if 0
-static gint imap_do_copy_msgs_with_dest        (Folder         *folder,
-                                        FolderItem     *dest, 
-                                        GSList         *msglist,
-                                        gboolean        remove_source);
-#endif
 
-static GSList *imap_get_uncached_messages      (IMAPSession    *session,
-                                                FolderItem     *item,
-                                                guint32         first_uid,
-                                                guint32         last_uid);
 static void imap_delete_all_cached_messages    (FolderItem     *item);
 
 #if USE_OPENSSL
@@ -141,14 +166,13 @@ static SockInfo *imap_open_tunnel(const gchar *server,
 #endif
 
 #if USE_OPENSSL
-static SockInfo *imap_init_sock(SockInfo *sock, SSLType         ssl_type);
+static SockInfo *imap_init_sock(SockInfo *sock, SSLType        ssl_type);
 #else
 static SockInfo *imap_init_sock(SockInfo *sock);
 #endif
 
 static gint imap_set_message_flags     (IMAPSession    *session,
-                                        guint32         first_uid,
-                                        guint32         last_uid,
+                                        MsgNumberList  *numlist,
                                         IMAPFlags       flag,
                                         gboolean        is_set);
 static gint imap_select                        (IMAPSession    *session,
@@ -192,6 +216,7 @@ static gint imap_greeting           (SockInfo       *sock,
 static void imap_get_capability                (Session        *session);
 static gboolean imap_has_capability    (IMAPSession    *session,
                                         const gchar    *cap);
+static const IMAPSet numberlist_to_imapset(MsgNumberList *list);
 
 /* low-level IMAP4rev1 commands */
 static gint imap_cmd_login     (SockInfo       *sock,
@@ -233,12 +258,7 @@ static gint imap_cmd_rename        (SockInfo       *sock,
 static gint imap_cmd_delete    (SockInfo       *sock,
                                 const gchar    *folder);
 static gint imap_cmd_envelope  (SockInfo       *sock,
-                                guint32         first_uid,
-                                guint32         last_uid);
-#if 0
-static gint imap_cmd_search    (SockInfo       *sock,
-                                GSList         *numlist);
-#endif
+                                IMAPSet         set);
 static gint imap_cmd_fetch     (SockInfo       *sock,
                                 guint32         uid,
                                 const gchar    *filename);
@@ -251,8 +271,7 @@ static gint imap_cmd_copy   (IMAPSession    *session,
                                 const gchar    *destfolder,
                                 gint32         *new_uid);
 static gint imap_cmd_store     (SockInfo       *sock,
-                                guint32         first_uid,
-                                guint32         last_uid,
+                                IMAPSet         set,
                                 gchar          *sub_cmd);
 static gint imap_cmd_expunge   (SockInfo       *sock);
 
@@ -284,18 +303,18 @@ static gchar *imap_locale_to_modified_utf7        (const gchar    *from);
 
 static gboolean imap_rename_folder_func                (GNode          *node,
                                                 gpointer        data);
-gint imap_get_num_list                         (Folder         *folder,
+static gint imap_get_num_list                  (Folder         *folder,
                                                 FolderItem     *item,
                                                 GSList        **list);
-GSList *imap_get_msginfos                      (Folder         *folder,
+static GSList *imap_get_msginfos               (Folder         *folder,
                                                 FolderItem     *item,
                                                 GSList         *msgnum_list);
-MsgInfo *imap_get_msginfo                      (Folder         *folder,
+static MsgInfo *imap_get_msginfo               (Folder         *folder,
                                                 FolderItem     *item,
                                                 gint            num);
-gboolean imap_check_msgnum_validity            (Folder         *folder,
+static gboolean imap_check_msgnum_validity     (Folder         *folder,
                                                 FolderItem     *item);
-void imap_change_flags                         (Folder         *folder,
+static void imap_change_flags                  (Folder         *folder,
                                                 FolderItem     *item,
                                                 MsgInfo        *msginfo,
                                                 MsgPermFlags   newflags);
@@ -329,12 +348,8 @@ FolderClass imap_class =
        imap_get_msginfos,
        imap_fetch_msg,
        imap_add_msg,
-       imap_move_msg,
-       NULL,
        imap_copy_msg,
-       NULL,
        imap_remove_msg,
-       imap_remove_msgs,
        imap_remove_all_msg,
        imap_is_msg_changed,
        imap_change_flags,
@@ -350,7 +365,7 @@ Folder *imap_folder_new(const gchar *name, const gchar *path)
        Folder *folder;
 
        folder = (Folder *)g_new0(IMAPFolder, 1);
-       folder->class = &imap_class;
+       folder->klass = &imap_class;
        imap_folder_init(folder, name, path);
 
        return folder;
@@ -446,6 +461,13 @@ static IMAPSession *imap_session_get(Folder *folder)
        if(session == NULL)
                return NULL;
 
+       if (session->sock->state == CONN_DISCONNECTED) {
+               debug_print("IMAP server disconnected\n");
+               session_destroy(session);
+               imap_reset_uid_lists(folder);
+               session = imap_session_new(folder->account);
+       }               
+
        /* Get CAPABILITY */
        imap_get_capability(session); 
 
@@ -555,7 +577,7 @@ Session *imap_session_new(const PrefsAccount *account)
        log_message("IMAP connection is %s-authenticated\n",
                    (is_preauth) ? "pre" : "un");
 
-       session = g_new(IMAPSession, 1);
+       session = g_new0(IMAPSession, 1);
        session_init(SESSION(session));
        SESSION(session)->type             = SESSION_IMAP;
        SESSION(session)->server           = g_strdup(account->recv_server);
@@ -568,8 +590,6 @@ Session *imap_session_new(const PrefsAccount *account)
        session->mbox = NULL;
        session->authenticated = is_preauth;
 
-       session_list = g_list_append(session_list, session);
-
        return SESSION(session);
 }
 
@@ -605,18 +625,6 @@ void imap_session_destroy(Session *session)
        g_free(IMAP_SESSION(session)->mbox);
 
        g_strfreev(IMAP_SESSION(session)->capability);
-
-       session_list = g_list_remove(session_list, session);
-}
-
-void imap_session_destroy_all(void)
-{
-       while (session_list != NULL) {
-               IMAPSession *session = (IMAPSession *)session_list->data;
-
-               imap_cmd_logout(SESSION(session)->sock);
-               session_destroy(SESSION(session));
-       }
 }
 
 gchar *imap_fetch_msg(Folder *folder, FolderItem *item, gint uid)
@@ -701,10 +709,9 @@ static gint imap_do_copy(Folder *folder, FolderItem *dest, MsgInfo *msginfo,
 {
        gchar *destdir;
        IMAPSession *session;
-       IMAPFlags iflags = 0;
        guint32 newuid = 0;
        gint ok;
-    
+       
        g_return_val_if_fail(folder != NULL, -1);
        g_return_val_if_fail(FOLDER_CLASS(folder) == &imap_class, -1);
        g_return_val_if_fail(dest != NULL, -1);
@@ -738,26 +745,16 @@ static gint imap_do_copy(Folder *folder, FolderItem *dest, MsgInfo *msginfo,
        ok = imap_cmd_copy(session, msginfo->msgnum, destdir, &newuid);
 
        if (ok == IMAP_SUCCESS && remove_source) {
-               imap_set_message_flags(session, msginfo->msgnum, msginfo->msgnum,
+               MsgNumberList numlist;
+
+               numlist.next = NULL;
+               numlist.data = GINT_TO_POINTER(msginfo->msgnum);
+               
+               imap_set_message_flags(session, &numlist,
                                       IMAP_FLAG_DELETED, TRUE);
                ok = imap_cmd_expunge(SESSION(session)->sock);
        }
 
-       /* get the dest folder to set the flags */
-       if (newuid) {
-               ok = imap_select(session, IMAP_FOLDER(folder), dest->path,
-                                NULL, NULL, NULL, NULL);
-               if (ok != IMAP_SUCCESS)         /* the folder disappeared? */
-                       return -1;
-
-               if (msginfo->flags.perm_flags & MSG_MARKED)  iflags |= IMAP_FLAG_FLAGGED;
-               if (msginfo->flags.perm_flags & MSG_REPLIED) iflags |= IMAP_FLAG_ANSWERED;
-               if (iflags)
-                       if (imap_set_message_flags(session, newuid, newuid, iflags, TRUE)
-                           != IMAP_SUCCESS)
-                               newuid = 0;
-       }
-
        g_free(destdir);
 
        if (ok == IMAP_SUCCESS)
@@ -766,122 +763,6 @@ static gint imap_do_copy(Folder *folder, FolderItem *dest, MsgInfo *msginfo,
                return -1;
 }
 
-#if 0
-static gint imap_do_copy_msgs_with_dest(Folder *folder, FolderItem *dest, 
-                                       GSList *msglist,
-                                       gboolean remove_source)
-{
-       gchar *destdir;
-       GSList *cur;
-       MsgInfo *msginfo;
-       IMAPSession *session;
-       gint ok = IMAP_SUCCESS;
-
-       g_return_val_if_fail(folder != NULL, -1);
-       g_return_val_if_fail(dest != NULL, -1);
-       g_return_val_if_fail(msglist != NULL, -1);
-
-       session = imap_session_get(folder);
-       if (!session) return -1;
-
-       destdir = imap_get_real_path(IMAP_FOLDER(folder), dest->path);
-
-       for (cur = msglist; cur != NULL; cur = cur->next) {
-               msginfo = (MsgInfo *)cur->data;
-
-               if (msginfo->folder == dest) {
-                       g_warning("the src folder is identical to the dest.\n");
-                       continue;
-               }
-
-               /* ensure source folder selected */
-               ok = imap_select(session, IMAP_FOLDER(folder), 
-                                msginfo->folder->path, NULL, NULL, NULL, NULL);
-        
-               if (remove_source)
-                       debug_print("Moving message %s%c%d to %s ...\n",
-                                   msginfo->folder->path, G_DIR_SEPARATOR,
-                                   msginfo->msgnum, destdir);
-               else
-                       debug_print("Copying message %s%c%d to %s ...\n",
-                                   msginfo->folder->path, G_DIR_SEPARATOR,
-                                   msginfo->msgnum, destdir);
-
-               ok = imap_cmd_copy(session, msginfo, destdir);
-
-               if (ok == IMAP_SUCCESS && remove_source) {
-                       imap_set_message_flags
-                               (session, msginfo->msgnum, msginfo->msgnum,
-                                IMAP_FLAG_DELETED, TRUE);
-               }
-       }
-
-       if (remove_source)
-               ok = imap_cmd_expunge(SESSION(session)->sock);
-
-       g_free(destdir);
-
-       if (ok == IMAP_SUCCESS)
-               return 0;
-       else
-               return -1;
-}
-#endif
-
-gint imap_move_msg(Folder *folder, FolderItem *dest, MsgInfo *msginfo)
-{
-       gchar *srcfile;
-       gint ret = 0;
-
-       g_return_val_if_fail(folder != NULL, -1);
-       g_return_val_if_fail(dest != NULL, -1);
-       g_return_val_if_fail(msginfo != NULL, -1);
-       g_return_val_if_fail(msginfo->folder != NULL, -1);
-
-       if (folder == msginfo->folder->folder)
-               return imap_do_copy(folder, dest, msginfo, TRUE);
-
-       srcfile = procmsg_get_message_file(msginfo);
-       if (!srcfile) return -1;
-
-       ret = imap_add_msg(folder, dest, srcfile, FALSE);
-       g_free(srcfile);
-
-       if (ret != -1) {
-               if(folder_item_remove_msg(msginfo->folder, msginfo->msgnum)) {
-                       ret = -1;
-               }
-       }
-               
-       return ret;
-}
-
-#if 0
-gint imap_move_msgs_with_dest(Folder *folder, FolderItem *dest, 
-                             GSList *msglist)
-{
-       MsgInfo *msginfo;
-       GSList *cur;
-       gint ret = 0;
-
-       g_return_val_if_fail(folder != NULL, -1);
-       g_return_val_if_fail(dest != NULL, -1);
-       g_return_val_if_fail(msglist != NULL, -1);
-
-       msginfo = (MsgInfo *)msglist->data;
-       if (folder == msginfo->folder->folder)
-               return imap_do_copy_msgs_with_dest(folder, dest, msglist, TRUE);
-
-       for (cur = msglist; cur != NULL; cur = cur->next) {
-               msginfo = (MsgInfo *)cur->data;
-               ret = imap_move_msg(folder, dest, msginfo);
-               if (ret == -1) break;
-       }
-
-       return ret;
-}
-#endif
-
 gint imap_copy_msg(Folder *folder, FolderItem *dest, MsgInfo *msginfo)
 {
        gchar *srcfile;
@@ -905,39 +786,13 @@ gint imap_copy_msg(Folder *folder, FolderItem *dest, MsgInfo *msginfo)
        return ret;
 }
 
-#if 0
-gint imap_copy_msgs_with_dest(Folder *folder, FolderItem *dest, 
-                             GSList *msglist)
-{
-       MsgInfo *msginfo;
-       GSList *cur;
-       gint ret = 0;
-
-       g_return_val_if_fail(folder != NULL, -1);
-       g_return_val_if_fail(dest != NULL, -1);
-       g_return_val_if_fail(msglist != NULL, -1);
-
-       msginfo = (MsgInfo *)msglist->data;
-       if (folder == msginfo->folder->folder)
-               return imap_do_copy_msgs_with_dest
-                       (folder, dest, msglist, FALSE);
-
-       for (cur = msglist; cur != NULL; cur = cur->next) {
-               msginfo = (MsgInfo *)cur->data;
-               ret = imap_copy_msg(folder, dest, msginfo);
-               if (ret == -1) break;
-       }
-
-       return ret;
-}
-#endif
-
 gint imap_remove_msg(Folder *folder, FolderItem *item, gint uid)
 {
        gint ok;
        IMAPSession *session;
        gchar *dir;
-
+       MsgNumberList numlist;
+       
        g_return_val_if_fail(folder != NULL, -1);
        g_return_val_if_fail(FOLDER_CLASS(folder) == &imap_class, -1);
        g_return_val_if_fail(item != NULL, -1);
@@ -950,9 +805,12 @@ gint imap_remove_msg(Folder *folder, FolderItem *item, gint uid)
        if (ok != IMAP_SUCCESS)
                return ok;
 
+       numlist.next = NULL;
+       numlist.data = GINT_TO_POINTER(uid);
+       
        ok = imap_set_message_flags
                (IMAP_SESSION(REMOTE_FOLDER(folder)->session),
-                (guint32)uid, (guint32)uid, IMAP_FLAG_DELETED, TRUE);
+               &numlist, IMAP_FLAG_DELETED, TRUE);
        if (ok != IMAP_SUCCESS) {
                log_warning(_("can't set deleted flags: %d\n"), uid);
                return ok;
@@ -972,59 +830,6 @@ gint imap_remove_msg(Folder *folder, FolderItem *item, gint uid)
        return IMAP_SUCCESS;
 }
 
-gint imap_remove_msgs(Folder *folder, FolderItem *item, GSList *msglist)
-{
-       gint ok;
-       IMAPSession *session;
-       gchar *dir;
-       MsgInfo *msginfo;
-       GSList *cur;
-       guint32 uid;
-
-       g_return_val_if_fail(folder != NULL, -1);
-       g_return_val_if_fail(FOLDER_CLASS(folder) == &imap_class, -1);
-       g_return_val_if_fail(item != NULL, -1);
-       g_return_val_if_fail(msglist != NULL, -1);
-
-       session = imap_session_get(folder);
-       if (!session) return -1;
-
-       ok = imap_select(session, IMAP_FOLDER(folder), item->path,
-                        NULL, NULL, NULL, NULL);
-       if (ok != IMAP_SUCCESS)
-               return ok;
-
-       for (cur = msglist; cur != NULL; cur = cur->next) {
-               msginfo = (MsgInfo *)cur->data;
-               uid = msginfo->msgnum;
-               ok = imap_set_message_flags
-                       (IMAP_SESSION(REMOTE_FOLDER(folder)->session),
-                        uid, uid, IMAP_FLAG_DELETED, TRUE);
-               if (ok != IMAP_SUCCESS) {
-                       log_warning(_("can't set deleted flags: %d\n"), uid);
-                       return ok;
-               }
-       }
-
-       ok = imap_cmd_expunge(SESSION(session)->sock);
-       if (ok != IMAP_SUCCESS) {
-               log_warning(_("can't expunge\n"));
-               return ok;
-       }
-
-       dir = folder_item_get_path(item);
-       if (is_dir_exist(dir)) {
-               for (cur = msglist; cur != NULL; cur = cur->next) {
-                       msginfo = (MsgInfo *)cur->data;
-                       uid = msginfo->msgnum;
-                       remove_numbered_files(dir, uid, uid);
-               }
-       }
-       g_free(dir);
-       return IMAP_SUCCESS;
-}
-
 gint imap_remove_all_msg(Folder *folder, FolderItem *item)
 {
         gint exists, recent, unseen;
@@ -1091,9 +896,9 @@ gint imap_scan_folder(Folder *folder, FolderItem *item)
                         &messages, &recent, &uid_next, &uid_validity, &unseen);
        if (ok != IMAP_SUCCESS) return -1;
 
-       item->new = unseen > 0 ? recent : 0;
-       item->unread = unseen;
-       item->total = messages;
+       item->new_msgs = unseen > 0 ? recent : 0;
+       item->unread_msgs = unseen;
+       item->total_msgs = messages;
        item->last_num = (messages > 0 && uid_next > 0) ? uid_next - 1 : 0;
        /* item->mtime = uid_validity; */
 
@@ -1240,7 +1045,7 @@ static GSList *imap_parse_list(Folder *folder, IMAPSession *session,
 
        for (;;) {
                if (sock_gets(SESSION(session)->sock, buf, sizeof(buf)) <= 0) {
-                       log_warning(_("error occured while getting LIST.\n"));
+                       log_warning(_("error occurred while getting LIST.\n"));
                        break;
                }
                strretchomp(buf);
@@ -1598,7 +1403,7 @@ gint imap_remove_folder(Folder *folder, FolderItem *item)
 
 static GSList *imap_get_uncached_messages(IMAPSession *session,
                                          FolderItem *item,
-                                         guint32 first_uid, guint32 last_uid)
+                                         MsgNumberList *numlist)
 {
        gchar *tmp;
        GSList *newlist = NULL;
@@ -1610,9 +1415,8 @@ static GSList *imap_get_uncached_messages(IMAPSession *session,
        g_return_val_if_fail(item != NULL, NULL);
        g_return_val_if_fail(item->folder != NULL, NULL);
        g_return_val_if_fail(FOLDER_CLASS(item->folder) == &imap_class, NULL);
-       g_return_val_if_fail(first_uid <= last_uid, NULL);
 
-       if (imap_cmd_envelope(SESSION(session)->sock, first_uid, last_uid)
+       if (imap_cmd_envelope(SESSION(session)->sock, numberlist_to_imapset(numlist))
            != IMAP_SUCCESS) {
                log_warning(_("can't get envelope\n"));
                return NULL;
@@ -2191,77 +1995,8 @@ static MsgInfo *imap_parse_envelope(SockInfo *sock, FolderItem *item,
        return msginfo;
 }
 
-gint imap_msg_set_perm_flags(MsgInfo *msginfo, MsgPermFlags flags)
-{
-       Folder *folder;
-       IMAPSession *session;
-       IMAPFlags iflags = 0;
-       gint ok = IMAP_SUCCESS;
-
-       g_return_val_if_fail(msginfo != NULL, -1);
-       g_return_val_if_fail(msginfo->folder != NULL, -1);
-       g_return_val_if_fail(msginfo->folder->folder != NULL, -1);
-
-       folder = msginfo->folder->folder;
-       g_return_val_if_fail(FOLDER_CLASS(folder) == &imap_class, -1);
-
-       session = imap_session_get(folder);
-       if (!session) return -1;
-
-       if ((ok = imap_select(session, IMAP_FOLDER(folder), msginfo->folder->path,
-           NULL, NULL, NULL, NULL)) != IMAP_SUCCESS)
-               return ok;
-
-       if (flags & MSG_MARKED)  iflags |= IMAP_FLAG_FLAGGED;
-       if (flags & MSG_REPLIED) iflags |= IMAP_FLAG_ANSWERED;
-       if (iflags) {
-               ok = imap_set_message_flags(session, msginfo->msgnum,
-                                           msginfo->msgnum, iflags, TRUE);
-               if (ok != IMAP_SUCCESS) return ok;
-       }
-
-       if (flags & MSG_UNREAD)
-               ok = imap_set_message_flags(session, msginfo->msgnum,
-                                           msginfo->msgnum, IMAP_FLAG_SEEN,
-                                           FALSE);
-       return ok;
-}
-
-gint imap_msg_unset_perm_flags(MsgInfo *msginfo, MsgPermFlags flags)
-{
-       Folder *folder;
-       IMAPSession *session;
-       IMAPFlags iflags = 0;
-       gint ok = IMAP_SUCCESS;
-
-       g_return_val_if_fail(msginfo != NULL, -1);
-       g_return_val_if_fail(msginfo->folder != NULL, -1);
-       g_return_val_if_fail(msginfo->folder->folder != NULL, -1);
-
-       folder = msginfo->folder->folder;
-       g_return_val_if_fail(FOLDER_CLASS(folder) == &imap_class, -1);
-
-       session = imap_session_get(folder);
-       if (!session) return -1;
-
-       if (flags & MSG_MARKED)  iflags |= IMAP_FLAG_FLAGGED;
-       if (flags & MSG_REPLIED) iflags |= IMAP_FLAG_ANSWERED;
-       if (iflags) {
-               ok = imap_set_message_flags(session, msginfo->msgnum,
-                                           msginfo->msgnum, iflags, FALSE);
-               if (ok != IMAP_SUCCESS) return ok;
-       }
-
-       if (flags & MSG_UNREAD)
-               ok = imap_set_message_flags(session, msginfo->msgnum,
-                                           msginfo->msgnum, IMAP_FLAG_SEEN,
-                                           TRUE);
-       return ok;
-}
-
 static gint imap_set_message_flags(IMAPSession *session,
-                                  guint32 first_uid,
-                                  guint32 last_uid,
+                                  MsgNumberList *numlist,
                                   IMAPFlags flags,
                                   gboolean is_set)
 {
@@ -2281,7 +2016,7 @@ static gint imap_set_message_flags(IMAPSession *session,
 
        g_string_append_c(buf, ')');
 
-       ok = imap_cmd_store(SESSION(session)->sock, first_uid, last_uid,
+       ok = imap_cmd_store(SESSION(session)->sock, numberlist_to_imapset(numlist),
                            buf->str);
        g_string_free(buf, TRUE);
 
@@ -2470,6 +2205,48 @@ static gboolean imap_has_capability(IMAPSession *session, const gchar *cap)
        return FALSE;
 }
 
+static const IMAPSet numberlist_to_imapset(MsgNumberList *list)
+{
+       static GString *imapset = NULL;
+       MsgNumberList *numlist, *elem;
+       guint first, last, next;
+
+       if (imapset == NULL)
+               imapset = g_string_sized_new(256);
+       else
+               g_string_truncate(imapset, 0);
+
+       numlist = g_slist_copy(list);
+       numlist = g_slist_sort(numlist, g_int_compare);
+
+       first = GPOINTER_TO_INT(numlist->data);
+       last = first;
+       for(elem = g_slist_next(numlist); elem != NULL; elem = g_slist_next(elem)) {
+               next = GPOINTER_TO_INT(elem->data);
+               if(next != (last + 1)) {
+                       if (imapset->len > 0)
+                               g_string_append(imapset, ",");
+                       if (first == last)
+                               g_string_sprintfa(imapset, "%d", first);
+                       else
+                               g_string_sprintfa(imapset, "%d:%d", first, last);
+
+                       first = next;
+               }
+               last = next;
+       }
+       if (imapset->len > 0)
+               g_string_append(imapset, ",");
+       if (first == last)
+               g_string_sprintfa(imapset, "%d", first);
+       else
+               g_string_sprintfa(imapset, "%d:%d", first, last);
+
+       g_slist_free(numlist);
+
+       return imapset->str;
+}
+
 static gint imap_cmd_noop(SockInfo *sock)
 {
        imap_cmd_gen_send(sock, "NOOP");
@@ -2689,7 +2466,7 @@ static gint imap_cmd_fetch(SockInfo *sock, guint32 uid, const gchar *filename)
 
        g_return_val_if_fail(filename != NULL, IMAP_ERROR);
 
-       imap_cmd_gen_send(sock, "UID FETCH %d BODY[]", uid);
+       imap_cmd_gen_send(sock, "UID FETCH %d BODY.PEEK[]", uid);
 
        while ((ok = imap_cmd_gen_recv(sock, &buf))
               == IMAP_SUCCESS) {
@@ -2777,7 +2554,6 @@ static gint imap_cmd_append(IMAPSession *session, const gchar *destfolder,
                strretchomp(buf);
                if (sock_puts(SESSION(session)->sock, buf) < 0) {
                        fclose(fp);
-                       sock_close(SESSION(session)->sock);
                        return -1;
                }
        }
@@ -2785,7 +2561,6 @@ static gint imap_cmd_append(IMAPSession *session, const gchar *destfolder,
        if (ferror(fp)) {
                FILE_OP_ERROR(file, "fgets");
                fclose(fp);
-               sock_close(SESSION(session)->sock);
                return -1;
        }
 
@@ -2847,7 +2622,7 @@ static gint imap_cmd_copy(IMAPSession * session,
        return ok;
 }
 
-gint imap_cmd_envelope(SockInfo *sock, guint32 first_uid, guint32 last_uid)
+gint imap_cmd_envelope(SockInfo *sock, IMAPSet set)
 {
        static GString *header_fields = NULL;
 
@@ -2878,24 +2653,23 @@ gint imap_cmd_envelope(SockInfo *sock, guint32 first_uid, guint32 last_uid)
        }
        
        imap_cmd_gen_send
-               (sock, "UID FETCH %d:%d (UID FLAGS RFC822.SIZE BODY.PEEK[HEADER.FIELDS (%s)])",
-                first_uid, last_uid,
-                header_fields->str);
+               (sock, "UID FETCH %s (UID FLAGS RFC822.SIZE BODY.PEEK[HEADER.FIELDS (%s)])",
+                set, header_fields->str);
 
        return IMAP_SUCCESS;
 }
 
-static gint imap_cmd_store(SockInfo *sock, guint32 first_uid, guint32 last_uid,
+static gint imap_cmd_store(SockInfo *sock, IMAPSet set,
                           gchar *sub_cmd)
 {
        gint ok;
 
-       imap_cmd_gen_send(sock, "UID STORE %d:%d %s",
-                         first_uid, last_uid, sub_cmd);
+       imap_cmd_gen_send(sock, "UID STORE %s %s",
+                         set, sub_cmd);
 
        if ((ok = imap_cmd_ok(sock, NULL)) != IMAP_SUCCESS) {
-               log_warning(_("error while imap command: STORE %d:%d %s\n"),
-                           first_uid, last_uid, sub_cmd);
+               log_warning(_("error while imap command: STORE %s %s\n"),
+                           set, sub_cmd);
                return ok;
        }
 
@@ -3450,16 +3224,11 @@ static MsgInfo *imap_parse_msg(const gchar *file, FolderItem *item)
        return msginfo;
 }
 
-static int compare_uint(gconstpointer a, gconstpointer b)
-{
-       return a-b;
-}
-
 GSList *imap_get_msginfos(Folder *folder, FolderItem *item, GSList *msgnum_list)
 {
        IMAPSession *session;
-       GSList *sorted_list, *elem, *ret = NULL;
-       gint ok, startnum, lastnum;
+       MsgInfoList *ret = NULL;
+       gint ok;
 
        g_return_val_if_fail(folder != NULL, NULL);
        g_return_val_if_fail(item != NULL, NULL);
@@ -3473,22 +3242,25 @@ GSList *imap_get_msginfos(Folder *folder, FolderItem *item, GSList *msgnum_list)
        if (ok != IMAP_SUCCESS)
                return NULL;
 
-       sorted_list = g_slist_sort(g_slist_copy(msgnum_list), compare_uint);
+       if (!(item->stype == F_QUEUE || item->stype == F_DRAFT)) {
+               ret = g_slist_concat(ret,
+                       imap_get_uncached_messages(
+                       session, item, msgnum_list));
+       } else {
+               MsgNumberList *sorted_list, *elem;
+               gint startnum, lastnum;
 
-       startnum = lastnum = GPOINTER_TO_INT(sorted_list->data);
+               sorted_list = g_slist_sort(g_slist_copy(msgnum_list), g_int_compare);
 
-       for (elem = sorted_list;; elem = g_slist_next(elem)) {
-               guint num;
+               startnum = lastnum = GPOINTER_TO_INT(sorted_list->data);
 
-               if (elem)
-                       num = GPOINTER_TO_INT(elem->data);
+               for (elem = sorted_list;; elem = g_slist_next(elem)) {
+                       guint num;
 
-               if (num > lastnum + 1 || elem == NULL) {
-                       if (!(item->stype == F_QUEUE || item->stype == F_DRAFT)) {
-                               ret = g_slist_concat(ret,
-                                       imap_get_uncached_messages(
-                                               session, item, startnum, lastnum));
-                       } else {
+                       if (elem)
+                               num = GPOINTER_TO_INT(elem->data);
+
+                       if (num > lastnum + 1 || elem == NULL) {
                                int i;
                                for (i = startnum; i <= lastnum; ++i) {
                                        gchar *file;
@@ -3503,59 +3275,36 @@ GSList *imap_get_msginfos(Folder *folder, FolderItem *item, GSList *msgnum_list)
                                                g_free(file);
                                        }
                                }
-                       }
 
-                       if (elem == NULL)
-                               break;
+                               if (elem == NULL)
+                                       break;
 
-                       startnum = num;
+                               startnum = num;
+                       }
+                       lastnum = num;
                }
-               lastnum = num;
-       }
 
-       g_slist_free(sorted_list);
+               g_slist_free(sorted_list);
+       }
 
        return ret;
 }
 
 MsgInfo *imap_get_msginfo(Folder *folder, FolderItem *item, gint uid)
 {
-       IMAPSession *session;
        MsgInfo *msginfo = NULL;
-       gint ok;
-
-       g_return_val_if_fail(folder != NULL, NULL);
-       g_return_val_if_fail(item != NULL, NULL);
+       MsgInfoList *msginfolist;
+       MsgNumberList numlist;
 
-       session = imap_session_get(folder);
-       g_return_val_if_fail(session != NULL, NULL);
+       numlist.next = NULL;
+       numlist.data = GINT_TO_POINTER(uid);
 
-       ok = imap_select(session, IMAP_FOLDER(folder), item->path,
-                        NULL, NULL, NULL, NULL);
-       if (ok != IMAP_SUCCESS)
-               return NULL;
-
-       if (!(item->stype == F_QUEUE || item->stype == F_DRAFT)) {
-               GSList *list;
-
-               list = imap_get_uncached_messages(session, item, uid, uid);
-               if (list) {
-                       msginfo = (MsgInfo *)list->data;
-                       list->data = NULL;
-               }
-               procmsg_msg_list_free(list);
-       } else {
-               gchar *file;
-
-               file = imap_fetch_msg(folder, item, uid);
-               if (file != NULL) {
-                       msginfo = imap_parse_msg(file, item);
-                       if (msginfo != NULL)
-                               msginfo->msgnum = uid;
-                       g_free(file);
-               }
+       msginfolist = imap_get_msginfos(folder, item, &numlist);
+       if (msginfolist != NULL) {
+               msginfo = msginfolist->data;
+               g_slist_free(msginfolist);
        }
-       
+
        return msginfo;
 }
 
@@ -3599,9 +3348,10 @@ void imap_change_flags(Folder *folder, FolderItem *item, MsgInfo *msginfo, MsgPe
        IMAPSession *session;
        IMAPFlags flags_set = 0, flags_unset = 0;
        gint ok = IMAP_SUCCESS;
-
+       MsgNumberList numlist;
+       
        g_return_if_fail(folder != NULL);
-       g_return_if_fail(folder->class == &imap_class);
+       g_return_if_fail(folder->klass == &imap_class);
        g_return_if_fail(item != NULL);
        g_return_if_fail(item->folder == folder);
        g_return_if_fail(msginfo != NULL);
@@ -3629,15 +3379,16 @@ void imap_change_flags(Folder *folder, FolderItem *item, MsgInfo *msginfo, MsgPe
        if ( MSG_IS_REPLIED(msginfo->flags) && !(newflags & MSG_REPLIED))
                flags_set |= IMAP_FLAG_ANSWERED;
 
+       numlist.next = NULL;
+       numlist.data = GINT_TO_POINTER(msginfo->msgnum);
+       
        if (flags_set) {
-               ok = imap_set_message_flags(session, msginfo->msgnum,
-                                           msginfo->msgnum, flags_set, TRUE);
+               ok = imap_set_message_flags(session, &numlist, flags_set, TRUE);
                if (ok != IMAP_SUCCESS) return;
        }
 
        if (flags_unset) {
-               ok = imap_set_message_flags(session, msginfo->msgnum,
-                                           msginfo->msgnum, flags_unset, FALSE);
+               ok = imap_set_message_flags(session, &numlist, flags_unset, FALSE);
                if (ok != IMAP_SUCCESS) return;
        }