2012-10-12 [mones] 3.8.1cvs98
[claws.git] / src / imap.c
index c98c5e76d664d0c4c9d91791bd3015d04217cd96..8c9df8509ef63f959991a0a43ad1f68db1e95997 100644 (file)
@@ -1,6 +1,6 @@
 /*
  * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2007 Hiroyuki Yamamoto and the Claws Mail team
+ * Copyright (C) 1999-2012 Hiroyuki Yamamoto and the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -19,6 +19,7 @@
 
 #ifdef HAVE_CONFIG_H
 #  include "config.h"
+#include "claws-features.h"
 #endif
 
 #include "defs.h"
@@ -212,7 +213,7 @@ static gint         imap_add_msg            (Folder         *folder,
 static gint    imap_add_msgs           (Folder         *folder, 
                                         FolderItem     *dest,
                                         GSList         *file_list,
-                                        GRelation      *relation);
+                                        GHashTable     *relation);
 
 static gint    imap_copy_msg           (Folder         *folder,
                                         FolderItem     *dest, 
@@ -220,7 +221,15 @@ static gint        imap_copy_msg           (Folder         *folder,
 static gint    imap_copy_msgs          (Folder         *folder, 
                                         FolderItem     *dest, 
                                         MsgInfoList    *msglist, 
-                                        GRelation      *relation);
+                                        GHashTable     *relation);
+
+static gint    search_msgs             (Folder                 *folder,
+                                        FolderItem             *container,
+                                        MsgNumberList          **msgs,
+                                        gboolean               *on_server,
+                                        MatcherList            *predicate,
+                                        SearchProgressNotify   progress_cb,
+                                        gpointer               progress_data);
 
 static gint    imap_remove_msg         (Folder         *folder, 
                                         FolderItem     *item, 
@@ -228,7 +237,9 @@ static gint         imap_remove_msg         (Folder         *folder,
 static gint    imap_remove_msgs        (Folder         *folder, 
                                         FolderItem     *dest, 
                                         MsgInfoList    *msglist, 
-                                        GRelation      *relation);
+                                        GHashTable     *relation);
+static gint    imap_expunge            (Folder         *folder, 
+                                        FolderItem     *dest);
 static gint    imap_remove_all_msg     (Folder         *folder, 
                                         FolderItem     *item);
 
@@ -276,7 +287,7 @@ static FolderItem *imap_create_special_folder
 static gint imap_do_copy_msgs          (Folder         *folder,
                                         FolderItem     *dest,
                                         MsgInfoList    *msglist,
-                                        GRelation      *relation);
+                                        GHashTable     *relation);
 
 static void imap_delete_all_cached_messages    (FolderItem     *item);
 static void imap_set_batch             (Folder         *folder,
@@ -373,7 +384,6 @@ static gint imap_cmd_append (IMAPSession    *session,
 static gint imap_cmd_copy       (IMAPSession *session,
                                 struct mailimap_set * set,
                                 const gchar *destfolder,
-                                GRelation *uid_mapping,
                                 struct mailimap_set ** source,
                                 struct mailimap_set ** dest);
 static gint imap_cmd_store     (IMAPSession    *session,
@@ -382,7 +392,7 @@ static gint imap_cmd_store  (IMAPSession    *session,
                                 IMAPFlags flags,
                                 GSList *tags,
                                 int do_add);
-static gint imap_cmd_expunge   (IMAPSession    *session);
+static gint imap_cmd_expunge   (IMAPSession    *session, gboolean force);
 
 static void imap_path_separator_subst          (gchar          *str,
                                                 gchar           separator);
@@ -408,7 +418,7 @@ static void imap_change_flags                       (Folder         *folder,
 static gint imap_get_flags                     (Folder         *folder,
                                                 FolderItem     *item,
                                                 MsgInfoList    *msglist,
-                                                GRelation      *msgflags);
+                                                GHashTable     *msgflags);
 static gchar *imap_folder_get_path             (Folder         *folder);
 static gchar *imap_item_get_path               (Folder         *folder,
                                                 FolderItem     *item);
@@ -420,7 +430,7 @@ static GSList * imap_list_from_lep(IMAPFolder * folder,
                                   clist * list, const gchar * real_path, gboolean all);
 static GSList * imap_get_lep_set_from_numlist(IMAPFolder *folder, MsgNumberList *numlist);
 static GSList * imap_get_lep_set_from_msglist(IMAPFolder *folder, MsgInfoList *msglist);
-static GSList * imap_uid_list_from_lep(clist * list);
+static GSList * imap_uid_list_from_lep(clist * list, gint* length);
 static GSList * imap_uid_list_from_lep_tab(carray * list);
 static void imap_flags_hash_from_lep_uid_flags_tab(carray * list,
                                                   GHashTable * hash,
@@ -443,6 +453,7 @@ FolderClass *imap_get_class(void)
                imap_class.type = F_IMAP;
                imap_class.idstr = "imap";
                imap_class.uistr = "IMAP4";
+               imap_class.supports_server_search = TRUE;
 
                /* Folder functions */
                imap_class.new_folder = imap_folder_new;
@@ -474,8 +485,10 @@ FolderClass *imap_get_class(void)
                imap_class.add_msgs = imap_add_msgs;
                imap_class.copy_msg = imap_copy_msg;
                imap_class.copy_msgs = imap_copy_msgs;
+               imap_class.search_msgs = search_msgs;
                imap_class.remove_msg = imap_remove_msg;
                imap_class.remove_msgs = imap_remove_msgs;
+               imap_class.expunge = imap_expunge;
                imap_class.remove_all_msg = imap_remove_all_msg;
                imap_class.is_msg_changed = imap_is_msg_changed;
                imap_class.change_flags = imap_change_flags;
@@ -531,11 +544,14 @@ static void unlock_session(IMAPSession *session)
 
 static void imap_disc_session_destroy(IMAPSession *session)
 {
-       RemoteFolder *rfolder = REMOTE_FOLDER(IMAP_SESSION(session)->folder);
-       
-       if (!rfolder)
+       RemoteFolder *rfolder = NULL;
+
+       if (session == NULL)
                return;
-       if (!session)
+
+       rfolder = REMOTE_FOLDER(IMAP_SESSION(session)->folder);
+       
+       if (rfolder == NULL)
                return;
        log_warning(LOG_PROTOCOL, _("IMAP4 connection broken\n"));
        SESSION(session)->state = SESSION_DISCONNECTED;
@@ -555,9 +571,15 @@ static gboolean is_fatal(int libetpan_errcode)
        }
 }
 
-static void imap_handle_error(Session *session, int libetpan_errcode)
+static void imap_handle_error(Session *session, const gchar *server, int libetpan_errcode)
 {
-       const gchar *session_server = (session ? session->server:"(null)");
+       const gchar *session_server = (session ? session->server : NULL);
+
+       if (session_server == NULL)
+               session_server = server;
+       if (session_server == NULL)
+               session_server = "(null)";
+
        switch(libetpan_errcode) {
        case MAILIMAP_NO_ERROR:
                return;
@@ -824,7 +846,7 @@ static gint imap_auth(IMAPSession *session, const gchar *user, const gchar *pass
        int r;
        gchar *server = NULL;
        if ((r = imap_get_capabilities(session)) != MAILIMAP_NO_ERROR) {
-               imap_handle_error(SESSION(session), r);
+               imap_handle_error(SESSION(session), NULL, r);
                return r;
        }
        server = g_strdup(SESSION(session)->server);
@@ -1028,7 +1050,8 @@ static IMAPSession *imap_session_new(Folder * folder,
        gushort port;
        int r;
        int authenticated = FALSE;
-       
+       gchar *buf;
+
 #ifdef USE_GNUTLS
        /* FIXME: IMAP over SSL only... */ 
        SSLType ssl_type;
@@ -1055,7 +1078,13 @@ static IMAPSession *imap_session_new(Folder * folder,
 #endif
 
        imap_init(folder);
-       statuswindow_print_all(_("Connecting to IMAP4 server: %s..."), folder->account->recv_server);
+       buf = g_strdup_printf(_("Account '%s': Connecting to IMAP4 server: %s:%d..."),
+                               folder->account->account_name, folder->account->recv_server,
+                               port);
+       statuswindow_print_all("%s", buf);
+       log_message(LOG_PROTOCOL, "%s\n", buf);
+       g_free(buf);
+
 #ifndef G_OS_WIN32
        if (account->set_tunnelcmd) {
                r = imap_threaded_connect_cmd(folder,
@@ -1094,7 +1123,7 @@ static IMAPSession *imap_session_new(Folder * folder,
                        log_error(LOG_PROTOCOL, _("SSL handshake failed\n"));
                else
 #endif
-                       imap_handle_error(NULL, r);
+                       imap_handle_error(NULL, account->recv_server, r);
 
                if(!prefs_common.no_recv_err_panel) {
                        alertpanel_error_log(_("Can't connect to IMAP4 server: %s:%d"),
@@ -1163,7 +1192,7 @@ static gint imap_session_authenticate(IMAPSession *session,
        acc_pass = account->passwd;
 try_again:
        pass = acc_pass;
-       if (!pass && account->imap_auth_type != IMAP_AUTH_ANON) {
+       if (!pass && account->imap_auth_type != IMAP_AUTH_ANON && account->imap_auth_type != IMAP_AUTH_GSSAPI) {
                gchar *tmp_pass;
                tmp_pass = input_dialog_query_password_keep(account->recv_server, 
                                                            account->userid,
@@ -1172,13 +1201,10 @@ try_again:
                        return MAILIMAP_NO_ERROR;
                Xstrdup_a(pass, tmp_pass, {g_free(tmp_pass); return MAILIMAP_NO_ERROR;});
                g_free(tmp_pass);
-       } else if (account->imap_auth_type == IMAP_AUTH_ANON) {
+       } else if (account->imap_auth_type == IMAP_AUTH_ANON || account->imap_auth_type == IMAP_AUTH_GSSAPI) {
                pass = "";
        }
-       statuswindow_print_all(_("Connecting to IMAP4 server %s...\n"),
-                               account->recv_server);
        if ((ok = imap_auth(session, account->userid, pass, account->imap_auth_type)) != MAILIMAP_NO_ERROR) {
-               statusbar_pop_all();
                
                if (!failed && !is_fatal(ok)) {
                        acc_pass = NULL;
@@ -1347,14 +1373,13 @@ static void imap_commit_tags(FolderItem *item, MsgInfo *msginfo, GSList *tags_se
                for (cur = tags_set; cur; cur = cur->next) {
                        gint cur_tag = GPOINTER_TO_INT(cur->data);
                        const gchar *str = tags_get_tag(cur_tag);
-                       if (strcmp(str, "$Forwarded") && strcmp(str, "Junk") && strcmp(str, "NonJunk") && strcmp(str, "NotJunk") && strcmp(str, "NoJunk") && strcmp(str, "Junk") )
+                       if (IS_NOT_RESERVED_TAG(str))
                                list_set = g_slist_prepend(list_set, g_strdup(str));
                }
                if (list_set) {
                        ok = imap_set_message_flags(session, 
                                IMAP_FOLDER_ITEM(item), &numlist, 0, list_set, TRUE);
-                       slist_free_strings(list_set);
-                       g_slist_free(list_set);
+                       slist_free_strings_full(list_set);
                        if (ok != MAILIMAP_NO_ERROR) {
                                return;
                        }
@@ -1363,14 +1388,13 @@ static void imap_commit_tags(FolderItem *item, MsgInfo *msginfo, GSList *tags_se
                for (cur = tags_unset; cur; cur = cur->next) {
                        gint cur_tag = GPOINTER_TO_INT(cur->data);
                        const gchar *str = tags_get_tag(cur_tag);
-                       if (strcmp(str, "$Forwarded") && strcmp(str, "Junk") && strcmp(str, "NonJunk") && strcmp(str, "NotJunk") && strcmp(str, "NoJunk") && strcmp(str, "Junk") )
+                       if (IS_NOT_RESERVED_TAG(str))
                                list_unset = g_slist_prepend(list_unset, g_strdup(str));
                }
                if (list_unset) {
                        ok = imap_set_message_flags(session, 
                                IMAP_FOLDER_ITEM(item), &numlist, 0, list_unset, FALSE);
-                       slist_free_strings(list_unset);
-                       g_slist_free(list_unset);
+                       slist_free_strings_full(list_unset);
                        if (ok != MAILIMAP_NO_ERROR) {
                                return;
                        }
@@ -1566,7 +1590,7 @@ static gint imap_add_msg(Folder *folder, FolderItem *dest,
 }
 
 static gint imap_add_msgs(Folder *folder, FolderItem *dest, GSList *file_list,
-                  GRelation *relation)
+                  GHashTable *relation)
 {
        gchar *destdir;
        IMAPSession *session;
@@ -1661,7 +1685,7 @@ static gint imap_add_msgs(Folder *folder, FolderItem *dest, GSList *file_list,
                }
 
                if (relation != NULL)
-                       g_relation_insert(relation, fileinfo->msginfo != NULL ? 
+                       g_hash_table_insert(relation, fileinfo->msginfo != NULL ? 
                                          (gpointer) fileinfo->msginfo : (gpointer) fileinfo,
                                          GINT_TO_POINTER(new_uid));
                if (last_uid < new_uid) {
@@ -1695,7 +1719,7 @@ static GSList *flatten_mailimap_set(struct mailimap_set * set)
 {
        GSList *result = NULL;
        clistiter *list;
-       int start, end, t;
+       guint32 start, end, t;
        GSList *cur;
 
        if (!set || !set->set_list)
@@ -1705,8 +1729,10 @@ static GSList *flatten_mailimap_set(struct mailimap_set * set)
                struct mailimap_set_item *item = (struct mailimap_set_item *)clist_content(list);
                start = item->set_first;
                end = item->set_last;
-               for (t = start; t <= end; t++) {
-                       result = g_slist_prepend(result, GINT_TO_POINTER(t));
+               if (start <= end) {
+                       for (t = start; t <= end; t++) {
+                               result = g_slist_prepend(result, GINT_TO_POINTER(t));
+                       }
                }
        }
        result = g_slist_reverse(result);
@@ -1721,7 +1747,7 @@ static GSList *flatten_mailimap_set(struct mailimap_set * set)
        return result;
 }
 static gint imap_do_copy_msgs(Folder *folder, FolderItem *dest, 
-                             MsgInfoList *msglist, GRelation *relation)
+                             MsgInfoList *msglist, GHashTable *relation)
 {
        FolderItem *src;
        gchar *destdir;
@@ -1729,9 +1755,8 @@ static gint imap_do_copy_msgs(Folder *folder, FolderItem *dest,
        MsgInfo *msginfo;
        IMAPSession *session;
        gint ok = MAILIMAP_NO_ERROR;
-       GRelation *uid_mapping;
+       GHashTable *uid_hash;
        gint last_num = 0;
-       gboolean single = FALSE;
 
        g_return_val_if_fail(folder != NULL, -1);
        g_return_val_if_fail(dest != NULL, -1);
@@ -1745,8 +1770,6 @@ static gint imap_do_copy_msgs(Folder *folder, FolderItem *dest,
        }
 
        msginfo = (MsgInfo *)msglist->data;
-       if (msglist->next == NULL)
-               single = TRUE;
        src = msginfo->folder;
        if (src == dest) {
                g_warning("the src folder is identical to the dest.\n");
@@ -1790,8 +1813,7 @@ static gint imap_do_copy_msgs(Folder *folder, FolderItem *dest,
                return ok;
 
        seq_list = imap_get_lep_set_from_msglist(IMAP_FOLDER(folder), msglist);
-       uid_mapping = g_relation_new(2);
-       g_relation_index(uid_mapping, 0, g_direct_hash, g_direct_equal);
+       uid_hash = g_hash_table_new(g_direct_hash, g_direct_equal);
        
        statusbar_print_all(_("Copying messages..."));
        for (cur = seq_list; cur != NULL; cur = g_slist_next(cur)) {
@@ -1804,7 +1826,7 @@ static gint imap_do_copy_msgs(Folder *folder, FolderItem *dest,
                            src->path, destdir);
 
                lock_session(session); /* unlocked later in the function */
-               ok = imap_cmd_copy(session, seq_set, destdir, uid_mapping,
+               ok = imap_cmd_copy(session, seq_set, destdir,
                        &source, &dest);
                
                if (is_fatal(ok)) {
@@ -1822,7 +1844,7 @@ static gint imap_do_copy_msgs(Folder *folder, FolderItem *dest,
                                        for (s_cur = s_list, d_cur = d_list; 
                                             s_cur && d_cur; 
                                             s_cur = s_cur->next, d_cur = d_cur->next) {
-                                               g_relation_insert(uid_mapping, s_cur->data, d_cur->data);
+                                               g_hash_table_insert(uid_hash, s_cur->data, d_cur->data);
                                        }
 
                                } else {
@@ -1840,7 +1862,7 @@ static gint imap_do_copy_msgs(Folder *folder, FolderItem *dest,
                        mailimap_set_free(dest);
 
                if (ok != MAILIMAP_NO_ERROR) {
-                       g_relation_destroy(uid_mapping);
+                       g_hash_table_destroy(uid_hash);
                        imap_lep_set_free(seq_list);
                        statusbar_pop_all();
                        return -1;
@@ -1849,14 +1871,13 @@ static gint imap_do_copy_msgs(Folder *folder, FolderItem *dest,
 
        for (cur = msglist; cur != NULL; cur = g_slist_next(cur)) {
                MsgInfo *msginfo = (MsgInfo *)cur->data;
-               GTuples *tuples;
-
-               tuples = g_relation_select(uid_mapping, 
-                                          GINT_TO_POINTER(msginfo->msgnum),
-                                          0);
-               if (tuples->len > 0) {
-                       gint num = GPOINTER_TO_INT(g_tuples_index(tuples, 0, 1));
-                       g_relation_insert(relation, msginfo,
+               gpointer hashval;
+
+               hashval = g_hash_table_lookup(uid_hash, GINT_TO_POINTER(msginfo->msgnum));
+               
+               if (hashval != NULL) {
+                       gint num = GPOINTER_TO_INT(hashval);
+                       g_hash_table_insert(relation, msginfo,
                                          GINT_TO_POINTER(num));
                        if (num > last_num)
                                last_num = num;
@@ -1885,13 +1906,12 @@ static gint imap_do_copy_msgs(Folder *folder, FolderItem *dest,
                                g_free(cache_path);
                        }
                } else
-                       g_relation_insert(relation, msginfo,
+                       g_hash_table_insert(relation, msginfo,
                                          GINT_TO_POINTER(0));
-               g_tuples_destroy(tuples);
        }
        statusbar_pop_all();
 
-       g_relation_destroy(uid_mapping);
+       g_hash_table_destroy(uid_hash);
        imap_lep_set_free(seq_list);
 
        g_free(destdir);
@@ -1921,7 +1941,7 @@ static gint imap_copy_msg(Folder *folder, FolderItem *dest, MsgInfo *msginfo)
 }
 
 static gint imap_copy_msgs(Folder *folder, FolderItem *dest, 
-                   MsgInfoList *msglist, GRelation *relation)
+                   MsgInfoList *msglist, GHashTable *relation)
 {
        MsgInfo *msginfo;
        gint ret;
@@ -1938,15 +1958,308 @@ static gint imap_copy_msgs(Folder *folder, FolderItem *dest,
 }
 
 
+static IMAPSearchKey* search_make_key(MatcherProp* match, gboolean* is_all)
+{
+       if (match->matchtype == MATCHTYPE_MATCHCASE || match->matchtype == MATCHTYPE_MATCH) {
+               IMAPSearchKey* result = NULL;
+               gboolean invert = FALSE;
+               gint matchertype = match->criteria;
+
+               if (is_all) {
+                       *is_all = FALSE;
+               }
+
+               switch (matchertype) {
+               case MATCHCRITERIA_NOT_NEW: invert = TRUE; matchertype = MATCHCRITERIA_NEW; break;
+               case MATCHCRITERIA_NOT_MARKED: invert = TRUE; matchertype = MATCHCRITERIA_MARKED; break;
+               case MATCHCRITERIA_NOT_FORWARDED: invert = TRUE; matchertype = MATCHCRITERIA_FORWARDED; break;
+               case MATCHCRITERIA_NOT_SPAM: invert = TRUE; matchertype = MATCHCRITERIA_SPAM; break;
+               case MATCHCRITERIA_NOT_SUBJECT: invert = TRUE; matchertype = MATCHCRITERIA_SUBJECT; break;
+               case MATCHCRITERIA_NOT_FROM: invert = TRUE; matchertype = MATCHCRITERIA_FROM; break;
+               case MATCHCRITERIA_NOT_TO: invert = TRUE; matchertype = MATCHCRITERIA_TO; break;
+               case MATCHCRITERIA_NOT_CC: invert = TRUE; matchertype = MATCHCRITERIA_CC; break;
+               case MATCHCRITERIA_NOT_REFERENCES: invert = TRUE; matchertype = MATCHCRITERIA_REFERENCES; break;
+               case MATCHCRITERIA_NOT_HEADER: invert = TRUE; matchertype = MATCHCRITERIA_HEADER; break;
+               case MATCHCRITERIA_NOT_TAG: invert = TRUE; matchertype = MATCHCRITERIA_TAG; break;
+               case MATCHCRITERIA_NOT_HEADERS_PART: invert = TRUE; matchertype = MATCHCRITERIA_HEADERS_PART; break;
+               case MATCHCRITERIA_NOT_MESSAGE: invert = TRUE; matchertype = MATCHCRITERIA_MESSAGE; break;
+               case MATCHCRITERIA_NOT_BODY_PART: invert = TRUE; matchertype = MATCHCRITERIA_BODY_PART; break;
+               case MATCHCRITERIA_NOT_TO_AND_NOT_CC: invert = TRUE; matchertype = MATCHCRITERIA_TO_OR_CC; break;
+               case MATCHCRITERIA_NOT_INREPLYTO: invert = TRUE; matchertype = MATCHCRITERIA_INREPLYTO; break;
+               }
+
+               /* 
+                * this aborts conversion even for predicates understood by the following code.
+                * while that might seem wasteful, claws local search for information listed below
+                * has proven faster than IMAP search plus network roundtrips. once this changes,
+                * consider removing these exceptions.
+                */
+               switch (matchertype) {
+               case MATCHCRITERIA_FROM:
+               case MATCHCRITERIA_TO:
+               case MATCHCRITERIA_CC:
+               case MATCHCRITERIA_TO_OR_CC:
+               case MATCHCRITERIA_SUBJECT:
+               case MATCHCRITERIA_REFERENCES:
+               case MATCHCRITERIA_INREPLYTO:
+               case MATCHCRITERIA_AGE_GREATER:
+               case MATCHCRITERIA_AGE_LOWER:
+               case MATCHCRITERIA_FORWARDED:
+               case MATCHCRITERIA_SPAM:
+               case MATCHCRITERIA_UNREAD:
+               case MATCHCRITERIA_NEW:
+               case MATCHCRITERIA_MARKED:
+               case MATCHCRITERIA_REPLIED:
+               case MATCHCRITERIA_DELETED:
+               case MATCHCRITERIA_SIZE_GREATER:
+               case MATCHCRITERIA_SIZE_SMALLER:
+               case MATCHCRITERIA_SIZE_EQUAL:
+                       return NULL;
+               }
+
+               /* the Message-ID header is also cached */
+               if (matchertype == MATCHCRITERIA_HEADER && g_strcmp0("Message-ID", match->header) == 0) {
+                       return NULL;
+               }
+
+               switch (matchertype) {
+               case MATCHCRITERIA_FORWARDED:
+                       result = imap_search_new(IMAP_SEARCH_CRITERIA_TAG, NULL, RTAG_FORWARDED, 0);
+                       break;
+
+               case MATCHCRITERIA_SPAM:
+                       result = imap_search_new(IMAP_SEARCH_CRITERIA_TAG, NULL, RTAG_JUNK, 0);
+                       break;
+
+               case MATCHCRITERIA_INREPLYTO:
+                       result = imap_search_new(IMAP_SEARCH_CRITERIA_HEADER, "In-Reply-To", match->expr, 0);
+                       break;
+
+               case MATCHCRITERIA_REFERENCES:
+                       result = imap_search_new(IMAP_SEARCH_CRITERIA_HEADER, "References", match->expr, 0);
+                       break;
+
+               case MATCHCRITERIA_TO_OR_CC:
+                       result = imap_search_or(
+                                       imap_search_new(IMAP_SEARCH_CRITERIA_TO, NULL, match->expr, 0),
+                                       imap_search_new(IMAP_SEARCH_CRITERIA_CC, NULL, match->expr, 0)
+                                       );
+                       break;
+
+               case MATCHCRITERIA_HEADERS_PART:
+                       result = imap_search_and(
+                                       imap_search_not(imap_search_new(IMAP_SEARCH_CRITERIA_BODY, NULL, match->expr, 0)),
+                                       imap_search_new(IMAP_SEARCH_CRITERIA_MESSAGE, NULL, match->expr, 0)
+                                       );
+                       break;
+
+               case MATCHCRITERIA_SIZE_EQUAL:
+                       result = imap_search_and(
+                                       imap_search_not(imap_search_new(IMAP_SEARCH_CRITERIA_SIZE_SMALLER, NULL, NULL, match->value)),
+                                       imap_search_not(imap_search_new(IMAP_SEARCH_CRITERIA_SIZE_GREATER, NULL, NULL, match->value))
+                                       );
+                       break;
+
+               case MATCHCRITERIA_NOT_UNREAD:
+                       result = imap_search_new(IMAP_SEARCH_CRITERIA_READ, NULL, NULL, 0);
+                       break;
+
+               case MATCHCRITERIA_UNREAD:
+                       result = imap_search_new(IMAP_SEARCH_CRITERIA_UNREAD, NULL, NULL, 0);
+                       break;
+
+               case MATCHCRITERIA_NEW:
+                       result = imap_search_new(IMAP_SEARCH_CRITERIA_NEW, NULL, NULL, 0);
+                       break;
+
+               case MATCHCRITERIA_MARKED:
+                       result = imap_search_new(IMAP_SEARCH_CRITERIA_MARKED, NULL, NULL, 0);
+                       break;
+
+               case MATCHCRITERIA_DELETED:
+                       result = imap_search_new(IMAP_SEARCH_CRITERIA_DELETED, NULL, NULL, 0);
+                       break;
+
+               case MATCHCRITERIA_REPLIED:
+                       result = imap_search_new(IMAP_SEARCH_CRITERIA_REPLIED, NULL, NULL, 0);
+                       break;
+
+               case MATCHCRITERIA_TAG:
+                       {
+                               gchar *tmp = imap_utf8_to_modified_utf7(match->expr, TRUE);
+                               result = imap_search_new(IMAP_SEARCH_CRITERIA_TAG, NULL, tmp, 0);
+                               g_free(tmp);
+                       }
+                       break;
+
+               case MATCHCRITERIA_SUBJECT:
+                       result = imap_search_new(IMAP_SEARCH_CRITERIA_SUBJECT, NULL, match->expr, 0);
+                       break;
+
+               case MATCHCRITERIA_FROM:
+                       result = imap_search_new(IMAP_SEARCH_CRITERIA_FROM, NULL, match->expr, 0);
+                       break;
+
+               case MATCHCRITERIA_TO:
+                       result = imap_search_new(IMAP_SEARCH_CRITERIA_TO, NULL, match->expr, 0);
+                       break;
+
+               case MATCHCRITERIA_CC:
+                       result = imap_search_new(IMAP_SEARCH_CRITERIA_CC, NULL, match->expr, 0);
+                       break;
+
+               case MATCHCRITERIA_AGE_GREATER:
+                       result = imap_search_new(IMAP_SEARCH_CRITERIA_AGE_GREATER, NULL, NULL, match->value);
+                       break;
+
+               case MATCHCRITERIA_AGE_LOWER:
+                       result = imap_search_new(IMAP_SEARCH_CRITERIA_AGE_LOWER, NULL, NULL, match->value);
+                       break;
+
+               case MATCHCRITERIA_BODY_PART:
+                       result = imap_search_new(IMAP_SEARCH_CRITERIA_BODY, NULL, match->expr, 0);
+                       break;
+
+               case MATCHCRITERIA_MESSAGE:
+                       result = imap_search_new(IMAP_SEARCH_CRITERIA_MESSAGE, NULL, match->expr, 0);
+                       break;
+
+               case MATCHCRITERIA_HEADER:
+                       result = imap_search_new(IMAP_SEARCH_CRITERIA_HEADER, match->header, match->expr, 0);
+                       break;
+
+               case MATCHCRITERIA_SIZE_GREATER:
+                       result = imap_search_new(IMAP_SEARCH_CRITERIA_SIZE_GREATER, NULL, NULL, match->value);
+                       break;
+
+               case MATCHCRITERIA_SIZE_SMALLER:
+                       result = imap_search_new(IMAP_SEARCH_CRITERIA_SIZE_SMALLER, NULL, NULL, match->value);
+                       break;
+
+               default:
+                       result = imap_search_new(IMAP_SEARCH_CRITERIA_ALL, NULL, NULL, 0);
+                       if (is_all) {
+                               *is_all = TRUE;
+                       }
+                       break;
+               }
+
+               if (invert) {
+                       result = imap_search_not(result);
+                       if (is_all && *is_all) {
+                               *is_all = FALSE;
+                       }
+               }
+
+               return result;
+       }
+
+       return NULL;
+}
+
+static gint    search_msgs             (Folder                 *folder,
+                                        FolderItem             *container,
+                                        MsgNumberList          **msgs,
+                                        gboolean               *on_server,
+                                        MatcherList            *predicate,
+                                        SearchProgressNotify   progress_cb,
+                                        gpointer               progress_data)
+{
+       IMAPSearchKey* key = NULL;
+       GSList* cur;
+       int result = -1;
+       clist* uidlist = NULL;
+       gboolean server_filtering_useless = FALSE;
+        IMAPSession *session;
+
+       if (on_server == NULL || !*on_server) {
+               return folder_item_search_msgs_local(folder, container, msgs, on_server,
+                               predicate, progress_cb, progress_data);
+       }
+
+       for (cur = predicate->matchers; cur != NULL; cur = cur->next) {
+               IMAPSearchKey* matcherPart = NULL;
+               MatcherProp* prop = (MatcherProp*) cur->data;
+               gboolean is_all;
+
+               matcherPart = search_make_key(prop, &is_all);
+
+               if (on_server) {
+                       *on_server &= matcherPart != NULL && prop->matchtype == MATCHTYPE_MATCHCASE;
+               }
+
+               if (matcherPart) {
+                       if (key == NULL) {
+                               key = matcherPart;
+                               server_filtering_useless = is_all;
+                       } else if (predicate->bool_and) {
+                               key = imap_search_and(key, matcherPart);
+                               server_filtering_useless &= is_all;
+                       } else {
+                               key = imap_search_or(key, matcherPart);
+                               server_filtering_useless |= is_all;
+                       }
+               }
+       }
+
+       if (server_filtering_useless) {
+               imap_search_free(key);
+               key = NULL;
+       }
+
+       if (key == NULL && progress_cb != NULL) {
+               GSList* cur;
+               GSList* list;
+               int count = 0;
+
+               progress_cb(progress_data, TRUE, 0, 0, container->total_msgs);
+               progress_cb(progress_data, TRUE, container->total_msgs, 0, container->total_msgs);
+
+               list = folder_item_get_msg_list(container);
+               for (cur = list; cur != NULL; cur = cur->next) {
+                       *msgs = g_slist_prepend(*msgs, GUINT_TO_POINTER(((MsgInfo*) cur->data)->msgnum));
+                       count++;
+               }
+               *msgs = g_slist_reverse(*msgs);
+               return count;
+       }
+
+       session = imap_session_get(folder);
+        if (!session) {
+                return -1;
+        }
+       result = imap_select(session, IMAP_FOLDER(folder), FOLDER_ITEM(container),
+                        NULL, NULL, NULL, NULL, NULL, TRUE);
+       if (result != MAILIMAP_NO_ERROR)
+               return -1;
+
+       if (progress_cb)
+               progress_cb(progress_data, TRUE, 0, 0, container->total_msgs);
+       result = imap_threaded_search(folder, IMAP_SEARCH_TYPE_KEYED, key, NULL, &uidlist);
+       if (progress_cb)
+               progress_cb(progress_data, TRUE, container->total_msgs, 0, container->total_msgs);
+
+       if (result == MAILIMAP_NO_ERROR) {
+               gint result = 0;
+
+               *msgs = imap_uid_list_from_lep(uidlist, &result);
+               mailimap_search_result_free(uidlist);
+
+               return result;
+       } else {
+               return -1;
+       }
+}
+
+
 static gint imap_do_remove_msgs(Folder *folder, FolderItem *dest, 
-                               MsgInfoList *msglist, GRelation *relation)
+                               MsgInfoList *msglist, GHashTable *relation)
 {
        gchar *destdir, *dir;
        GSList *numlist = NULL, *cur;
        MsgInfo *msginfo;
        IMAPSession *session;
        gint ok = MAILIMAP_NO_ERROR;
-       GRelation *uid_mapping;
        
        g_return_val_if_fail(folder != NULL, -1);
        g_return_val_if_fail(dest != NULL, -1);
@@ -1969,8 +2282,10 @@ static gint imap_do_remove_msgs(Folder *folder, FolderItem *dest,
        }
 
        destdir = imap_get_real_path(session, IMAP_FOLDER(folder), dest->path, &ok);
-       if (is_fatal(ok))
+       if (is_fatal(ok)) {
+               g_free(destdir);
                return ok;
+       }
        for (cur = msglist; cur; cur = cur->next) {
                msginfo = (MsgInfo *)cur->data;
                if (!MSG_IS_DELETED(msginfo->flags))
@@ -1978,20 +2293,19 @@ static gint imap_do_remove_msgs(Folder *folder, FolderItem *dest,
        }
        numlist = g_slist_reverse(numlist);
 
-       uid_mapping = g_relation_new(2);
-       g_relation_index(uid_mapping, 0, g_direct_hash, g_direct_equal);
-
        if (numlist != NULL) {
                ok = imap_set_message_flags
                        (session, IMAP_FOLDER_ITEM(msginfo->folder), numlist, IMAP_FLAG_DELETED, NULL, TRUE);
                if (ok != MAILIMAP_NO_ERROR) {
                        log_warning(LOG_PROTOCOL, _("can't set deleted flags\n"));
+                       g_free(destdir);
                        return ok;
                }
        } /* else we just need to expunge */
-       ok = imap_cmd_expunge(session);
+       ok = imap_cmd_expunge(session, folder->account->imap_use_trash);
        if (ok != MAILIMAP_NO_ERROR) {
                log_warning(LOG_PROTOCOL, _("can't expunge\n"));
+               g_free(destdir);
                return ok;
        }
        
@@ -2007,7 +2321,6 @@ static gint imap_do_remove_msgs(Folder *folder, FolderItem *dest,
        }
        g_free(dir);
 
-       g_relation_destroy(uid_mapping);
        g_slist_free(numlist);
 
        imap_scan_required(folder, dest);
@@ -2020,7 +2333,7 @@ static gint imap_do_remove_msgs(Folder *folder, FolderItem *dest,
 }
 
 static gint imap_remove_msgs(Folder *folder, FolderItem *dest, 
-                   MsgInfoList *msglist, GRelation *relation)
+                   MsgInfoList *msglist, GHashTable *relation)
 {
        MsgInfo *msginfo;
 
@@ -2078,7 +2391,7 @@ static gint imap_scan_tree_real(Folder *folder, gboolean subs_only)
 
        if (folder->account->imap_dir && *folder->account->imap_dir) {
                gchar *real_path;
-               int r;
+               int r = MAILIMAP_NO_ERROR;
                clist * lep_list;
 
                Xstrdup_a(root_folder, folder->account->imap_dir, {return -1;});
@@ -2102,7 +2415,7 @@ static gint imap_scan_tree_real(Folder *folder, gboolean subs_only)
                                       &lep_list);
 
                if (r != MAILIMAP_NO_ERROR)
-                       imap_handle_error(SESSION(session), r);
+                       imap_handle_error(SESSION(session), NULL, r);
 
                if ((r != MAILIMAP_NO_ERROR) || (clist_count(lep_list) == 0)) {
                        if (!folder->node) {
@@ -2160,7 +2473,7 @@ static gint imap_scan_tree_recursive(IMAPSession *session, FolderItem *item, gbo
        gchar separator;
        gchar wildcard[3];
        clist * lep_list;
-       int r;
+       int r = MAILIMAP_NO_ERROR;
        
        g_return_val_if_fail(item != NULL, -1);
        g_return_val_if_fail(item->folder != NULL, -1);
@@ -2181,8 +2494,10 @@ static gint imap_scan_tree_recursive(IMAPSession *session, FolderItem *item, gbo
                wildcard[1] = '%';
                wildcard[2] = '\0';
                real_path = imap_get_real_path(session, imapfolder, item->path, &r);
-               if (is_fatal(r))
+               if (is_fatal(r)) {
+                       g_free(real_path);
                        return r;
+               }
        } else {
                wildcard[0] = '%';
                wildcard[1] = '\0';
@@ -2199,8 +2514,9 @@ static gint imap_scan_tree_recursive(IMAPSession *session, FolderItem *item, gbo
                r = imap_threaded_list(folder, "", wildcard_path, &lep_list);
 
        if (r != MAILIMAP_NO_ERROR) {
-               imap_handle_error(SESSION(session), r);
+               imap_handle_error(SESSION(session), NULL, r);
                item_list = NULL;
+               g_free(real_path);
                return r;
        }
        else {
@@ -2310,7 +2626,7 @@ GList *imap_scan_subtree(Folder *folder, FolderItem *item, gboolean unsubs_only,
        GSList *item_list = NULL, *cur;
        GList *child_list = NULL, *tmplist = NULL;
        GSList *sub_list = NULL;
-       int r;
+       int r = MAILIMAP_NO_ERROR;
 
        if (!session)
                return NULL;
@@ -2324,8 +2640,10 @@ GList *imap_scan_subtree(Folder *folder, FolderItem *item, gboolean unsubs_only,
                wildcard[1] = '%';
                wildcard[2] = '\0';
                real_path = imap_get_real_path(session, IMAP_FOLDER(folder), item->path, &r);
-               if (is_fatal(r))
+               if (is_fatal(r)) {
+                       g_free(real_path);
                        return NULL;
+               }
        } else {
                wildcard[0] = '%';
                wildcard[1] = '\0';
@@ -2345,6 +2663,7 @@ GList *imap_scan_subtree(Folder *folder, FolderItem *item, gboolean unsubs_only,
 
        r = imap_threaded_list(folder, "", wildcard_path, &lep_list);
        if (r) {
+               g_free(real_path);
                statusbar_pop_all();
                return NULL;
        }
@@ -2364,6 +2683,7 @@ GList *imap_scan_subtree(Folder *folder, FolderItem *item, gboolean unsubs_only,
                                imap_get_real_path(session, 
                                        IMAP_FOLDER(folder), cur_item->path, &r));
                if (is_fatal(r)) {
+                       g_free(real_path);
                        statusbar_pop_all();
                        return NULL;
                }
@@ -2375,6 +2695,7 @@ GList *imap_scan_subtree(Folder *folder, FolderItem *item, gboolean unsubs_only,
        if (unsubs_only) {
                r = imap_threaded_lsub(folder, "", wildcard_path, &lep_list);
                if (r) {
+                       g_free(real_path);
                        statusbar_pop_all();
                        return NULL;
                }
@@ -2388,6 +2709,7 @@ GList *imap_scan_subtree(Folder *folder, FolderItem *item, gboolean unsubs_only,
                        gchar *tmp = imap_get_real_path(session, 
                                        IMAP_FOLDER(folder), cur_item->path, &r);
                        if (r) {
+                               g_free(real_path);
                                statusbar_pop_all();
                                return NULL;
                        }
@@ -2403,6 +2725,7 @@ GList *imap_scan_subtree(Folder *folder, FolderItem *item, gboolean unsubs_only,
                }
        }
 
+       g_free(real_path);
        statusbar_pop_all();
 
        return child_list;
@@ -2571,7 +2894,7 @@ static FolderItem *imap_create_folder(Folder *folder, FolderItem *parent,
        gchar separator;
        gchar *new_name;
        const gchar *p;
-       gint ok;
+       gint ok = MAILIMAP_NO_ERROR;
        gboolean no_select = FALSE, no_sub = FALSE;
        gboolean exist = FALSE;
        
@@ -2610,11 +2933,14 @@ static FolderItem *imap_create_folder(Folder *folder, FolderItem *parent,
        strtailchomp(dirpath, '/');
        Xstrdup_a(new_name, name, {
                g_free(dirpath); 
+               g_free(imap_path);
                return NULL;});
 
        separator = imap_get_path_separator(session, IMAP_FOLDER(folder), imap_path, &ok);
-       if (is_fatal(ok))
+       if (is_fatal(ok)) {
+               g_free(imap_path);
                return NULL;
+       }
        imap_path_separator_subst(imap_path, separator);
        /* remove trailing / for display */
        strtailchomp(new_name, '/');
@@ -2627,7 +2953,7 @@ static FolderItem *imap_create_folder(Folder *folder, FolderItem *parent,
                argbuf = g_ptr_array_new();
                r = imap_threaded_list(folder, "", imap_path, &lep_list);
                if (r != MAILIMAP_NO_ERROR) {
-                       imap_handle_error(SESSION(session), r);
+                       imap_handle_error(SESSION(session), NULL, r);
                        log_warning(LOG_PROTOCOL, _("can't create mailbox: LIST failed\n"));
                        g_free(imap_path);
                        g_free(dirpath);
@@ -2660,7 +2986,7 @@ static FolderItem *imap_create_folder(Folder *folder, FolderItem *parent,
                                } 
                                mailimap_list_result_free(lep_list);
                        } else {
-                               imap_handle_error(SESSION(session), r);
+                               imap_handle_error(SESSION(session), NULL, r);
                        }
                }
                imap_threaded_subscribe(folder, imap_path, TRUE);
@@ -2680,7 +3006,7 @@ static FolderItem *imap_create_folder(Folder *folder, FolderItem *parent,
                        } 
                        mailimap_list_result_free(lep_list);
                } else {
-                       imap_handle_error(SESSION(session), r);
+                       imap_handle_error(SESSION(session), NULL, r);
                }
        }
 
@@ -2717,7 +3043,7 @@ static gint imap_rename_folder(Folder *folder, FolderItem *item,
        gchar *new_cache_dir;
        IMAPSession *session;
        gchar separator;
-       gint ok;
+       gint ok = MAILIMAP_NO_ERROR;
        gint exists, recent, unseen;
        guint32 uid_validity;
 
@@ -2790,7 +3116,7 @@ static gint imap_rename_folder(Folder *folder, FolderItem *item,
 
        if (is_dir_exist(old_cache_dir)) {
                new_cache_dir = folder_item_get_path(item);
-               if (rename(old_cache_dir, new_cache_dir) < 0) {
+               if (g_rename(old_cache_dir, new_cache_dir) < 0) {
                        FILE_OP_ERROR(old_cache_dir, "rename");
                }
                g_free(new_cache_dir);
@@ -2807,7 +3133,7 @@ static gint imap_rename_folder(Folder *folder, FolderItem *item,
 gint imap_subscribe(Folder *folder, FolderItem *item, gchar *rpath, gboolean sub)
 {
        gchar *path;
-       gint r = -1;
+       gint r = MAILIMAP_NO_ERROR;
        IMAPSession *session;
        debug_print("getting session...\n");
 
@@ -2817,10 +3143,16 @@ gint imap_subscribe(Folder *folder, FolderItem *item, gchar *rpath, gboolean sub
        }
        if (item && item->path) {
                path = imap_get_real_path(session, IMAP_FOLDER(folder), item->path, &r);
-               if (!path || is_fatal(r))
+               if (!path)
                        return -1;
-               if (!strcmp(path, "INBOX") && sub == FALSE)
+               if (is_fatal(r)) {
+                       g_free(path);
                        return -1;
+               }
+               if (!strcmp(path, "INBOX") && sub == FALSE) {
+                       g_free(path);
+                       return -1;
+               }
                debug_print("%ssubscribing %s\n", sub?"":"un", path);
                r = imap_threaded_subscribe(folder, path, sub);
                g_free(path);
@@ -2833,7 +3165,7 @@ gint imap_subscribe(Folder *folder, FolderItem *item, gchar *rpath, gboolean sub
 
 static gint imap_remove_folder_real(Folder *folder, FolderItem *item)
 {
-       gint ok;
+       gint ok = MAILIMAP_NO_ERROR;
        IMAPSession *session;
        gchar *path;
        gchar *cache_dir;
@@ -2865,7 +3197,10 @@ static gint imap_remove_folder_real(Folder *folder, FolderItem *item)
        }
        ok = imap_cmd_delete(session, path);
        if (ok != MAILIMAP_NO_ERROR && !is_fatal(ok)) {
-               gchar *tmp = g_strdup_printf("%s%c", path, 
+               gchar *tmp = NULL;
+               
+               ok = MAILIMAP_NO_ERROR;
+               tmp = g_strdup_printf("%s%c", path, 
                                imap_get_path_separator(session, IMAP_FOLDER(folder), path, &ok));
                g_free(path);
                path = tmp;
@@ -2956,7 +3291,7 @@ static void *imap_get_uncached_messages_thread(void *data)
                r = imap_threaded_fetch_env(session->folder,
                                            imapset, &env_list);
                if (r != MAILIMAP_NO_ERROR) {
-                       imap_handle_error(SESSION(session), r);
+                       imap_handle_error(SESSION(session), NULL, r);
                        if (is_fatal(r)) {
                                stuff->ok = r;
                                return NULL;
@@ -2975,14 +3310,12 @@ static void *imap_get_uncached_messages_thread(void *data)
                        tags = carray_get(env_list, i+1);
                        msginfo = imap_envelope_from_lep(info, item);
                        if (msginfo == NULL) {
-                               slist_free_strings(tags);
-                               g_slist_free(tags);
+                               slist_free_strings_full(tags);
                                continue;
                        }
-                       if (tags != NULL) {
-                               g_slist_free(msginfo->tags);
-                               msginfo->tags = NULL;
-                       }
+                       g_slist_free(msginfo->tags);
+                       msginfo->tags = NULL;
+
                        for (cur = tags; cur; cur = cur->next) {
                                gchar *real_tag = imap_modified_utf7_to_utf8(cur->data, TRUE);
                                gint id = 0;
@@ -2992,14 +3325,15 @@ static void *imap_get_uncached_messages_thread(void *data)
                                        got_alien_tags = TRUE;
                                }
                                if (!g_slist_find(msginfo->tags, GINT_TO_POINTER(id))) {
-                                       msginfo->tags = g_slist_append(
+                                       msginfo->tags = g_slist_prepend(
                                                        msginfo->tags,
                                                        GINT_TO_POINTER(id));
                                }
                                g_free(real_tag);
                        }
-                       slist_free_strings(tags);
-                       g_slist_free(tags);
+                       if (msginfo->tags)
+                               msginfo->tags = g_slist_reverse(msginfo->tags);
+                       slist_free_strings_full(tags);
                        msginfo->folder = item;
                        if (!newlist)
                                llast = newlist = g_slist_append(newlist, msginfo);
@@ -3040,9 +3374,7 @@ static GSList *imap_get_uncached_messages(IMAPSession *session,
        GSList *result = NULL;
        GSList * cur;
        uncached_data *data = g_new0(uncached_data, 1);
-       int finished;
        
-       finished = 0;
        cur = numlist;
        data->total = g_slist_length(numlist);
        data->ok = MAILIMAP_NO_ERROR;
@@ -3134,7 +3466,7 @@ gchar imap_get_path_separator_for_item(FolderItem *item)
        IMAPFolder *imap_folder = NULL;
        IMAPSession *session = NULL;
        gchar result = '/';
-       gint ok;
+       gint ok = MAILIMAP_NO_ERROR;
        if (!item)
                return '/';
        folder = item->folder;
@@ -3163,7 +3495,7 @@ static gchar imap_refresh_path_separator(IMAPSession *session, IMAPFolder *folde
        r = imap_threaded_list((Folder *)folder, "", subfolder, &lep_list);
        
        if (r != MAILIMAP_NO_ERROR) {
-               imap_handle_error(SESSION(session), r);
+               imap_handle_error(SESSION(session), NULL, r);
                log_warning(LOG_PROTOCOL, _("LIST failed\n"));
                *ok = r;
                return '\0';
@@ -3185,7 +3517,7 @@ static gchar imap_refresh_path_separator(IMAPSession *session, IMAPFolder *folde
 static gchar imap_get_path_separator(IMAPSession *session, IMAPFolder *folder, const gchar *path, gint *ok)
 {
        gchar separator = '/';
-
+       *ok = MAILIMAP_NO_ERROR;
        if (folder->last_seen_separator == 0) {
                folder->last_seen_separator = imap_refresh_path_separator(session, folder, "", ok);
        }
@@ -3204,15 +3536,18 @@ static gchar imap_get_path_separator(IMAPSession *session, IMAPFolder *folder, c
 
 static gchar *imap_get_real_path(IMAPSession *session, IMAPFolder *folder, const gchar *path, gint *ok)
 {
-       gchar *real_path;
+       gchar *real_path = NULL;
        gchar separator;
-
+       
        g_return_val_if_fail(folder != NULL, NULL);
        g_return_val_if_fail(path != NULL, NULL);
 
+       *ok = MAILIMAP_NO_ERROR;
+       
        real_path = imap_utf8_to_modified_utf7(path, FALSE);
        separator = imap_get_path_separator(session, folder, path, ok);
-       imap_path_separator_subst(real_path, separator);
+       if (*ok == MAILIMAP_NO_ERROR)
+               imap_path_separator_subst(real_path, separator);
 
        return real_path;
 }
@@ -3257,6 +3592,9 @@ static gint imap_set_message_flags(IMAPSession *session,
                else
                        continue;
 
+               if (set_item == NULL)
+                       continue;
+
                statusbar_progress_all(set_item->set_first, total, 1);
 
                ok = imap_cmd_store(session, item, imapset,
@@ -3298,7 +3636,7 @@ static gint imap_select(IMAPSession *session, IMAPFolder *folder,
                        gboolean block)
 {
        gchar *real_path;
-       gint ok;
+       gint ok = MAILIMAP_NO_ERROR;
        gint exists_, recent_, unseen_;
        guint32 uid_validity_;
        gint can_create_flags_;
@@ -3373,7 +3711,7 @@ static gint imap_status(IMAPSession *session, IMAPFolder *folder,
                        guint32 *uid_next, guint32 *uid_validity,
                        gint *unseen, gboolean block)
 {
-       int r;
+       int r = MAILIMAP_NO_ERROR;
        clistiter * iter;
        struct mailimap_mailbox_data_status * data_status;
        int got_values;
@@ -3381,9 +3719,10 @@ static gint imap_status(IMAPSession *session, IMAPFolder *folder,
        guint mask = 0;
        
        real_path = imap_get_real_path(session, folder, path, &r);
-       if (is_fatal(r))
+       if (is_fatal(r)) {
+               g_free(real_path);
                return r;
-
+       }
        if (messages) {
                mask |= 1 << 0;
                *messages = 0;
@@ -3406,6 +3745,7 @@ static gint imap_status(IMAPSession *session, IMAPFolder *folder,
                r = imap_cmd_close(session);
                if (r != MAILIMAP_NO_ERROR) {
                        debug_print("close err %d\n", r);
+                       g_free(real_path);
                        return r;
                }
        }
@@ -3415,14 +3755,17 @@ static gint imap_status(IMAPSession *session, IMAPFolder *folder,
 
        g_free(real_path);
        if (r != MAILIMAP_NO_ERROR) {
-               imap_handle_error(SESSION(session), r);
+               imap_handle_error(SESSION(session), NULL, r);
                debug_print("status err %d\n", r);
                return r;
        }
        
-       if (data_status->st_info_list == NULL) {
-               mailimap_mailbox_data_status_free(data_status);
-               debug_print("status->st_info_list == NULL\n");
+       if (data_status == NULL || data_status->st_info_list == NULL) {
+               debug_print("data_status %p\n", data_status);
+               if (data_status) {
+                       debug_print("data_status->st_info_list %p\n", data_status->st_info_list);
+                       mailimap_mailbox_data_status_free(data_status);
+               }
                return MAILIMAP_ERROR_BAD_STATE;
        }
        
@@ -3474,8 +3817,7 @@ static gint imap_status(IMAPSession *session, IMAPFolder *folder,
 
 static void imap_free_capabilities(IMAPSession *session)
 {
-       slist_free_strings(session->capability);
-       g_slist_free(session->capability);
+       slist_free_strings_full(session->capability);
        session->capability = NULL;
 }
 
@@ -3501,7 +3843,7 @@ static gint imap_cmd_login(IMAPSession *session,
                                /* refresh capas */
                                imap_free_capabilities(session);
                                if ((r = imap_get_capabilities(session)) != MAILIMAP_NO_ERROR) {
-                                       imap_handle_error(SESSION(session), r);
+                                       imap_handle_error(SESSION(session), NULL, r);
                                        log_warning(LOG_PROTOCOL, _("Can't refresh capabilities.\n"));
                                        return r;
                                }
@@ -3526,7 +3868,7 @@ static gint imap_cmd_login(IMAPSession *session,
                        type);
        r = imap_threaded_login(session->folder, user, pass, type);
        if (r != MAILIMAP_NO_ERROR) {
-               imap_handle_error(SESSION(session), r);
+               imap_handle_error(SESSION(session), NULL, r);
                log_print(LOG_PROTOCOL, "IMAP4< Error logging in to %s\n",
                                SESSION(session)->server);
                ok = r;
@@ -3545,7 +3887,7 @@ static gint imap_cmd_noop(IMAPSession *session)
        
        r = imap_threaded_noop(session->folder, &exists, &recent, &expunge, &unseen, &uidnext, &uidval);
        if (r != MAILIMAP_NO_ERROR) {
-               imap_handle_error(SESSION(session), r);
+               imap_handle_error(SESSION(session), NULL, r);
                debug_print("noop err %d\n", r);
                return r;
        }
@@ -3585,7 +3927,7 @@ static gint imap_cmd_starttls(IMAPSession *session)
        r = imap_threaded_starttls(session->folder, 
                SESSION(session)->server, SESSION(session)->port);
        if (r != MAILIMAP_NO_ERROR) {
-               imap_handle_error(SESSION(session), r);
+               imap_handle_error(SESSION(session), NULL, r);
                debug_print("starttls err %d\n", r);
                return r;
        }
@@ -3603,7 +3945,7 @@ static gint imap_cmd_select(IMAPSession *session, const gchar *folder,
        r = imap_threaded_select(session->folder, folder,
                                 exists, recent, unseen, uid_validity, can_create_flags, ok_flags);
        if (r != MAILIMAP_NO_ERROR) {
-               imap_handle_error(SESSION(session), r);
+               imap_handle_error(SESSION(session), NULL, r);
                debug_print("select err %d\n", r);
                return r;
        }
@@ -3616,7 +3958,7 @@ static gint imap_cmd_close(IMAPSession *session)
 
        r = imap_threaded_close(session->folder);
        if (r != MAILIMAP_NO_ERROR) {
-               imap_handle_error(SESSION(session), r);
+               imap_handle_error(SESSION(session), NULL, r);
                debug_print("close err %d\n", r);
                return r;
        }
@@ -3637,7 +3979,7 @@ static gint imap_cmd_examine(IMAPSession *session, const gchar *folder,
        r = imap_threaded_examine(session->folder, folder,
                                  exists, recent, unseen, uid_validity);
        if (r != MAILIMAP_NO_ERROR) {
-               imap_handle_error(SESSION(session), r);
+               imap_handle_error(SESSION(session), NULL, r);
                debug_print("examine err %d\n", r);
                
                return r;
@@ -3651,7 +3993,7 @@ static gint imap_cmd_create(IMAPSession *session, const gchar *folder)
 
        r = imap_threaded_create(session->folder, folder);
        if (r != MAILIMAP_NO_ERROR) {
-               imap_handle_error(SESSION(session), r);
+               imap_handle_error(SESSION(session), NULL, r);
                return r;
        }
 
@@ -3666,7 +4008,7 @@ static gint imap_cmd_rename(IMAPSession *session, const gchar *old_folder,
        r = imap_threaded_rename(session->folder, old_folder,
                                 new_folder);
        if (r != MAILIMAP_NO_ERROR) {
-               imap_handle_error(SESSION(session), r);
+               imap_handle_error(SESSION(session), NULL, r);
                return r;
        }
 
@@ -3680,7 +4022,7 @@ static gint imap_cmd_delete(IMAPSession *session, const gchar *folder)
 
        r = imap_threaded_delete(session->folder, folder);
        if (r != MAILIMAP_NO_ERROR) {
-               imap_handle_error(SESSION(session), r);
+               imap_handle_error(SESSION(session), NULL, r);
                return r;
        }
 
@@ -3713,7 +4055,7 @@ static void *imap_cmd_fetch_thread(void *data)
                                                uid, 0, filename);
        }
        if (r != MAILIMAP_NO_ERROR) {
-               imap_handle_error(SESSION(session), r);
+               imap_handle_error(SESSION(session), NULL, r);
                debug_print("fetch err %d\n", r);
                return GINT_TO_POINTER(r);
        }
@@ -3757,7 +4099,7 @@ static gint imap_cmd_append(IMAPSession *session,
        struct mailimap_flag_list * flag_list;
        int r;
        
-       g_return_val_if_fail(file != NULL, MAILIMAP_ERROR_BAD_STATE);
+       cm_return_val_if_fail(file != NULL, MAILIMAP_ERROR_BAD_STATE);
 
        flag_list = imap_flag_to_lep(item, flags, NULL);
        lock_session(session);
@@ -3766,7 +4108,7 @@ static gint imap_cmd_append(IMAPSession *session,
        mailimap_flag_list_free(flag_list);
 
        if (r != MAILIMAP_NO_ERROR) {
-               imap_handle_error(SESSION(session), r);
+               imap_handle_error(SESSION(session), NULL, r);
                debug_print("append err %d\n", r);
                return r;
        }
@@ -3777,7 +4119,7 @@ static gint imap_cmd_append(IMAPSession *session,
 }
 
 static gint imap_cmd_copy(IMAPSession *session, struct mailimap_set * set,
-                         const gchar *destfolder, GRelation *uid_mapping,
+                         const gchar *destfolder,
                          struct mailimap_set **source, struct mailimap_set **dest)
 {
        int r;
@@ -3788,7 +4130,7 @@ static gint imap_cmd_copy(IMAPSession *session, struct mailimap_set * set,
 
        r = imap_threaded_copy(session->folder, set, destfolder, source, dest);
        if (r != MAILIMAP_NO_ERROR) {
-               imap_handle_error(SESSION(session), r);
+               imap_handle_error(SESSION(session), NULL, r);
                return r;
        }
 
@@ -3816,17 +4158,20 @@ static gint imap_cmd_store(IMAPSession *session,
        r = imap_threaded_store(session->folder, set, store_att_flags);
        mailimap_store_att_flags_free(store_att_flags);
        if (r != MAILIMAP_NO_ERROR) {
-               imap_handle_error(SESSION(session), r);
+               imap_handle_error(SESSION(session), NULL, r);
                return r;
        }
        
        return MAILIMAP_NO_ERROR;
 }
 
-static gint imap_cmd_expunge(IMAPSession *session)
+static gint imap_cmd_expunge(IMAPSession *session, gboolean do_expunge)
 {
        int r;
        
+       if (!do_expunge)
+               return MAILIMAP_NO_ERROR;
+
        if (prefs_common.work_offline && 
            !inc_offline_should_override(FALSE,
                _("Claws Mail needs network access in order "
@@ -3836,13 +4181,22 @@ static gint imap_cmd_expunge(IMAPSession *session)
 
        r = imap_threaded_expunge(session->folder);
        if (r != MAILIMAP_NO_ERROR) {
-               imap_handle_error(SESSION(session), r);
+               imap_handle_error(SESSION(session), NULL, r);
                return r;
        }
 
        return MAILIMAP_NO_ERROR;
 }
 
+gint imap_expunge(Folder *folder, FolderItem *item)
+{
+       IMAPSession *session = imap_session_get(folder);
+       if (session == NULL)
+               return -1;
+       
+       return imap_cmd_expunge(session, TRUE);
+}
+
 static void imap_path_separator_subst(gchar *str, gchar separator)
 {
        gchar *p;
@@ -3871,7 +4225,7 @@ static gboolean imap_rename_folder_func(GNode *node, gpointer data)
        gchar *new_itempath;
        gint oldpathlen;
        IMAPSession *session = imap_session_get(item->folder);
-       gint ok;
+       gint ok = MAILIMAP_NO_ERROR;
        oldpathlen = strlen(oldpath);
        if (strncmp(oldpath, item->path, oldpathlen) != 0) {
                g_warning("path doesn't match: %s, %s\n", oldpath, item->path);
@@ -3905,7 +4259,7 @@ static gint get_list_of_uids(IMAPSession *session, Folder *folder, IMAPFolderIte
        GSList *uidlist, *elem;
        int r = -1;
        clist * lep_uidlist;
-       gint ok, nummsgs = 0, lastuid_old;
+       gint ok, nummsgs = 0;
 
        if (session == NULL) {
                return -1;
@@ -3923,20 +4277,20 @@ static gint get_list_of_uids(IMAPSession *session, Folder *folder, IMAPFolderIte
        uidlist = NULL;
        
        if (folder->account && folder->account->low_bandwidth) {
-               r = imap_threaded_search(folder, IMAP_SEARCH_TYPE_SIMPLE, NULL,
-                                &lep_uidlist);
+               r = imap_threaded_search(folder, IMAP_SEARCH_TYPE_SIMPLE,
+                               NULL, NULL, &lep_uidlist);
        }
        
        if (r == MAILIMAP_NO_ERROR) {
                GSList * fetchuid_list =
-                       imap_uid_list_from_lep(lep_uidlist);
+                       imap_uid_list_from_lep(lep_uidlist, NULL);
                mailimap_search_result_free(lep_uidlist);
                
                uidlist = g_slist_concat(fetchuid_list, uidlist);
        } else {
                carray * lep_uidtab;
                if (r != -1) { /* inited */
-                       imap_handle_error(SESSION(session), r);
+                       imap_handle_error(SESSION(session), NULL, r);
                        if (is_fatal(r))
                                return -1;
                }
@@ -3951,12 +4305,10 @@ static gint get_list_of_uids(IMAPSession *session, Folder *folder, IMAPFolderIte
        }
        
        if (r != MAILIMAP_NO_ERROR) {
-               imap_handle_error(SESSION(session), r);
+               imap_handle_error(SESSION(session), NULL, r);
                return -1;
        }
 
-       lastuid_old = item->lastuid;
-
        for (elem = uidlist; elem != NULL; elem = g_slist_next(elem)) {
                guint msgnum;
 
@@ -3981,7 +4333,6 @@ gint imap_get_num_list(Folder *folder, FolderItem *_item, GSList **msgnum_list,
        gint nummsgs;
        GSList *uidlist = NULL;
        gchar *dir;
-       gboolean selected_folder;
        gint known_list_len = 0;
        debug_print("get_num_list\n");
        
@@ -4025,9 +4376,6 @@ gint imap_get_num_list(Folder *folder, FolderItem *_item, GSList **msgnum_list,
                statusbar_print_all(_("Scanning folder %s ..."),
                                      FOLDER_ITEM(item)->folder->name);
 
-       selected_folder = (session->mbox != NULL) &&
-                         (!strcmp(session->mbox, item->item.path));
-       
        if (item->should_trash_cache) {
                *old_uids_valid = FALSE;
                debug_print("get_num_list: trashing num list\n");
@@ -4433,15 +4781,8 @@ static gint imap_remove_msg(Folder *folder, FolderItem *item, gint uid)
                return ok;
        }
 
-       if (!session->uidplus) {
-               ok = imap_cmd_expunge(session);
-       } else {
-               gchar *uidstr;
+       ok = imap_cmd_expunge(session, folder->account->imap_use_trash);
 
-               uidstr = g_strdup_printf("%u", uid);
-               ok = imap_cmd_expunge(session);
-               g_free(uidstr);
-       }
        if (ok != MAILIMAP_NO_ERROR) {
                log_warning(LOG_PROTOCOL, _("can't expunge\n"));
                return ok;
@@ -4500,7 +4841,7 @@ typedef struct _get_flags_data {
        Folder *folder;
        FolderItem *item;
        MsgInfoList *msginfo_list;
-       GRelation *msgflags;
+       GHashTable *msgflags;
        gboolean full_search;
        gboolean done;
 } get_flags_data;
@@ -4511,7 +4852,7 @@ static /*gint*/ void *imap_get_flags_thread(void *data)
        Folder *folder = stuff->folder;
        FolderItem *fitem = (FolderItem *) stuff->item;
        MsgInfoList *msginfo_list = stuff->msginfo_list;
-       GRelation *msgflags = stuff->msgflags;
+       GHashTable *msgflags = stuff->msgflags;
        GSList *elem;
        carray * lep_uidtab;
        IMAPSession *session;
@@ -4571,98 +4912,98 @@ static /*gint*/ void *imap_get_flags_thread(void *data)
 
                        imapset = cur->data;
                        if (reverse_seen) {
-                               r = imap_threaded_search(folder, IMAP_SEARCH_TYPE_SEEN,
+                               r = imap_threaded_search(folder, IMAP_SEARCH_TYPE_SEEN, NULL,
                                                         full_search ? NULL:imapset, &lep_uidlist);
                        }
                        else {
                                r = imap_threaded_search(folder,
-                                                        IMAP_SEARCH_TYPE_UNSEEN,
+                                                        IMAP_SEARCH_TYPE_UNSEEN, NULL,
                                                         full_search ? NULL:imapset, &lep_uidlist);
                        }
                        if (r == MAILIMAP_NO_ERROR) {
                                GSList * uidlist;
 
-                               uidlist = imap_uid_list_from_lep(lep_uidlist);
+                               uidlist = imap_uid_list_from_lep(lep_uidlist, NULL);
                                mailimap_search_result_free(lep_uidlist);
 
                                unseen = g_slist_concat(unseen, uidlist);
                        } else {
-                               imap_handle_error(SESSION(session), r);
+                               imap_handle_error(SESSION(session), NULL, r);
                                goto bail;
                        }
 
-                       r = imap_threaded_search(folder, IMAP_SEARCH_TYPE_FLAGGED,
+                       r = imap_threaded_search(folder, IMAP_SEARCH_TYPE_FLAGGED, NULL,
                                                 full_search ? NULL:imapset, &lep_uidlist);
                        if (r == MAILIMAP_NO_ERROR) {
                                GSList * uidlist;
 
-                               uidlist = imap_uid_list_from_lep(lep_uidlist);
+                               uidlist = imap_uid_list_from_lep(lep_uidlist, NULL);
                                mailimap_search_result_free(lep_uidlist);
 
                                flagged = g_slist_concat(flagged, uidlist);
                        } else {
-                               imap_handle_error(SESSION(session), r);
+                               imap_handle_error(SESSION(session), NULL, r);
                                goto bail;
                        }
 
                        if (fitem->opened || fitem->processing_pending || fitem == folder->inbox) {
-                               r = imap_threaded_search(folder, IMAP_SEARCH_TYPE_ANSWERED,
+                               r = imap_threaded_search(folder, IMAP_SEARCH_TYPE_ANSWERED, NULL,
                                                         full_search ? NULL:imapset, &lep_uidlist);
                                if (r == MAILIMAP_NO_ERROR) {
                                        GSList * uidlist;
 
-                                       uidlist = imap_uid_list_from_lep(lep_uidlist);
+                                       uidlist = imap_uid_list_from_lep(lep_uidlist, NULL);
                                        mailimap_search_result_free(lep_uidlist);
 
                                        answered = g_slist_concat(answered, uidlist);
                                } else {
-                                       imap_handle_error(SESSION(session), r);
+                                       imap_handle_error(SESSION(session), NULL, r);
                                        goto bail;
                                }
 
                                if (flag_ok(IMAP_FOLDER_ITEM(fitem), IMAP_FLAG_FORWARDED)) {
-                                       r = imap_threaded_search(folder, IMAP_SEARCH_TYPE_FORWARDED,
+                                       r = imap_threaded_search(folder, IMAP_SEARCH_TYPE_FORWARDED, NULL,
                                                                 full_search ? NULL:imapset, &lep_uidlist);
                                        if (r == MAILIMAP_NO_ERROR) {
                                                GSList * uidlist;
 
-                                               uidlist = imap_uid_list_from_lep(lep_uidlist);
+                                               uidlist = imap_uid_list_from_lep(lep_uidlist, NULL);
                                                mailimap_search_result_free(lep_uidlist);
 
                                                forwarded = g_slist_concat(forwarded, uidlist);
                                        } else {
-                                               imap_handle_error(SESSION(session), r);
+                                               imap_handle_error(SESSION(session), NULL, r);
                                                goto bail;
                                        }
                                }
 
                                if (flag_ok(IMAP_FOLDER_ITEM(fitem), IMAP_FLAG_SPAM)) {
-                                       r = imap_threaded_search(folder, IMAP_SEARCH_TYPE_SPAM,
+                                       r = imap_threaded_search(folder, IMAP_SEARCH_TYPE_SPAM, NULL,
                                                                 full_search ? NULL:imapset, &lep_uidlist);
                                        if (r == MAILIMAP_NO_ERROR) {
                                                GSList * uidlist;
 
-                                               uidlist = imap_uid_list_from_lep(lep_uidlist);
+                                               uidlist = imap_uid_list_from_lep(lep_uidlist, NULL);
                                                mailimap_search_result_free(lep_uidlist);
 
                                                spam = g_slist_concat(spam, uidlist);
                                        } else {
-                                               imap_handle_error(SESSION(session), r);
+                                               imap_handle_error(SESSION(session), NULL, r);
                                                goto bail;
                                        }
                                }
 
-                               r = imap_threaded_search(folder, IMAP_SEARCH_TYPE_DELETED,
+                               r = imap_threaded_search(folder, IMAP_SEARCH_TYPE_DELETED, NULL,
                                                         full_search ? NULL:imapset, &lep_uidlist);
                                if (r == MAILIMAP_NO_ERROR) {
                                        GSList * uidlist;
 
-                                       uidlist = imap_uid_list_from_lep(lep_uidlist);
+                                       uidlist = imap_uid_list_from_lep(lep_uidlist, NULL);
                                        mailimap_search_result_free(lep_uidlist);
 
                                        deleted = g_slist_concat(deleted, uidlist);
                                } else {
-                                       imap_handle_error(SESSION(session), r);
+                                       imap_handle_error(SESSION(session), NULL, r);
                                        goto bail;
                                }
                        }
@@ -4676,7 +5017,7 @@ static /*gint*/ void *imap_get_flags_thread(void *data)
                        imap_flags_hash_from_lep_uid_flags_tab(lep_uidtab, flags_hash, tags_hash);
                        imap_fetch_uid_flags_list_free(lep_uidtab);
                } else {
-                       imap_handle_error(SESSION(session), r);
+                       imap_handle_error(SESSION(session), NULL, r);
                        goto bail;
                }
        }
@@ -4751,10 +5092,9 @@ bail:
                                GSList *tags = g_hash_table_lookup(tags_hash, GINT_TO_POINTER(msginfo->msgnum));
                                GSList *cur;
 
-                               if (tags != NULL) {
-                                       g_slist_free(msginfo->tags);
-                                       msginfo->tags = NULL;
-                               }
+                               g_slist_free(msginfo->tags);
+                               msginfo->tags = NULL;
+
                                for (cur = tags; cur; cur = cur->next) {
                                        gchar *real_tag = imap_modified_utf7_to_utf8(cur->data, TRUE);
                                        gint id = 0;
@@ -4763,19 +5103,16 @@ bail:
                                                id = tags_add_tag(real_tag);
                                                got_alien_tags = TRUE;
                                        }
-                                       if (!g_slist_find(msginfo->tags, GINT_TO_POINTER(id))) {
-                                               msginfo->tags = g_slist_append(
+                                       msginfo->tags = g_slist_append(
                                                                msginfo->tags,
                                                                GINT_TO_POINTER(id));
-                                       }
                                        g_free(real_tag);
                                }
-                               slist_free_strings(tags);
-                               g_slist_free(tags);
+                               slist_free_strings_full(tags);
                        }
                }
 
-               g_relation_insert(msgflags, msginfo, GINT_TO_POINTER(flags));
+               g_hash_table_insert(msgflags, msginfo, GINT_TO_POINTER(flags));
        }
        
        if (got_alien_tags) {
@@ -4802,7 +5139,7 @@ bail:
 }
 
 static gint imap_get_flags(Folder *folder, FolderItem *item,
-                           MsgInfoList *msginfo_list, GRelation *msgflags)
+                           MsgInfoList *msginfo_list, GHashTable *msgflags)
 {
        gint result;
        get_flags_data *data = g_new0(get_flags_data, 1);
@@ -5185,25 +5522,21 @@ static GSList * imap_get_lep_set_from_numlist(IMAPFolder *folder, MsgNumberList
 static GSList * imap_get_lep_set_from_msglist(IMAPFolder *folder, MsgInfoList *msglist)
 {
        MsgNumberList *numlist = NULL;
-       MsgInfoList *cur;
        GSList *seq_list;
 
-       for (cur = msglist; cur != NULL; cur = g_slist_next(cur)) {
-               MsgInfo *msginfo = (MsgInfo *) cur->data;
+       numlist = procmsg_get_number_list_for_msgs(msglist);
 
-               numlist = g_slist_prepend(numlist, GINT_TO_POINTER(msginfo->msgnum));
-       }
-       numlist = g_slist_reverse(numlist);
        seq_list = imap_get_lep_set_from_numlist(folder, numlist);
        g_slist_free(numlist);
 
        return seq_list;
 }
 
-static GSList * imap_uid_list_from_lep(clist * list)
+static GSList * imap_uid_list_from_lep(clist * list, gint* length)
 {
        clistiter * iter;
        GSList * result;
+       gint len = 0;
        
        result = NULL;
        
@@ -5214,9 +5547,12 @@ static GSList * imap_uid_list_from_lep(clist * list)
 
                        puid = clist_content(iter);
                        result = g_slist_prepend(result, GINT_TO_POINTER(* puid));
+                       len++;
                }
                result = g_slist_reverse(result);
-       }       
+       }
+       if (length)
+               *length = len;
        return result;
 }
 
@@ -5242,9 +5578,6 @@ static void imap_flags_hash_from_lep_uid_flags_tab(carray * list,
                                                   GHashTable * tags_hash)
 {
        unsigned int i;
-       GSList * result;
-       
-       result = NULL;
        
        for(i = 0 ; i < carray_count(list) ; i += 3) {
                uint32_t * puid;
@@ -5328,13 +5661,13 @@ static struct mailimap_flag_list * imap_flag_to_lep(IMAPFolderItem *item, IMAPFl
                                       mailimap_flag_new_draft());
        if (IMAP_IS_FORWARDED(flags) && flag_ok(item, IMAP_FLAG_FORWARDED))
                mailimap_flag_list_add(flag_list,
-                                      mailimap_flag_new_flag_keyword(strdup("$Forwarded")));
+                                      mailimap_flag_new_flag_keyword(strdup(RTAG_FORWARDED)));
        if (IMAP_IS_SPAM(flags) && flag_ok(item, IMAP_FLAG_SPAM))
                mailimap_flag_list_add(flag_list,
-                                      mailimap_flag_new_flag_keyword(strdup("Junk")));
+                                      mailimap_flag_new_flag_keyword(strdup(RTAG_JUNK)));
        else if (IMAP_IS_HAM(flags) && flag_ok(item, IMAP_FLAG_HAM))
                mailimap_flag_list_add(flag_list,
-                                      mailimap_flag_new_flag_keyword(strdup("NonJunk")));
+                                      mailimap_flag_new_flag_keyword(strdup(RTAG_NON_JUNK)));
        
        for (; cur; cur = cur->next) {
                gchar *enc_str = 
@@ -5358,7 +5691,7 @@ void imap_folder_ref(Folder *folder)
        ((IMAPFolder *)folder)->refcnt++;
 }
 
-void imap_disconnect_all(void)
+void imap_disconnect_all(gboolean have_connectivity)
 {
        GList *list;
        gboolean short_timeout;
@@ -5386,7 +5719,8 @@ void imap_disconnect_all(void)
                        RemoteFolder *folder = (RemoteFolder *)account->folder;
                        if (folder && folder->session) {
                                IMAPSession *session = (IMAPSession *)folder->session;
-                               imap_threaded_disconnect(FOLDER(folder));
+                               if (have_connectivity)
+                                       imap_threaded_disconnect(FOLDER(folder));
                                SESSION(session)->state = SESSION_DISCONNECTED;
                                SESSION(session)->sock = NULL;
                                session_destroy(SESSION(session));
@@ -5531,7 +5865,7 @@ FolderClass *imap_get_class(void)
        return &imap_class;
 }
 
-void imap_disconnect_all(void)
+void imap_disconnect_all(gboolean have_connectivity)
 {
 }
 
@@ -5649,9 +5983,8 @@ char* imap_modified_utf7_to_utf8(const char *mbox, gboolean change_spaces)
   unsigned long ucs4, utf16, bitbuf;
   unsigned char base64[256];
   const char *src;
-  char *dst, *res  = malloc(2*strlen(mbox)+1);
+  char *dst, *res  = g_malloc(2*strlen(mbox)+1);
 
-  bitbuf = 0;
   dst = res;
   src = mbox;
   if(!dst) return NULL;
@@ -5740,7 +6073,11 @@ char* imap_utf8_to_modified_utf7(const char *src, gboolean change_spaces)
   unsigned long ucs4 = 0, bitbuf = 0;
 
   /* initialize hex lookup table */
-  char *dst, *res = malloc(2*strlen(src)+1);
+  char *dst, *res;
+
+  if (!src) return NULL;
+
+  res = malloc(2*strlen(src)+1);
   dst = res;
   if(!dst) return NULL;
 
@@ -5781,7 +6118,6 @@ char* imap_utf8_to_modified_utf7(const char *src, gboolean change_spaces)
     /* Encode US-ASCII characters as themselves */
     if (c < 0x80) {
       ucs4 = c;
-      utf8total = 1;
     } else if (utf8total) {
       /* save UTF8 bits into UCS4 */
       ucs4 = (ucs4 << 6) | (c & 0x3FUL);