2009-03-30 [colin] 3.7.1cvs30
[claws.git] / src / imap.c
index c1aed25f4d8906b248b8185fc23fcc48e4c55d66..712d0fdb150a54d405f15fb5b230b44cb47a4f23 100644 (file)
@@ -1,6 +1,6 @@
 /*
  * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2007 Hiroyuki Yamamoto and the Claws Mail team
+ * Copyright (C) 1999-2009 Hiroyuki Yamamoto and the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -45,7 +45,7 @@
 #  include <iconv.h>
 #endif
 
-#if (defined(USE_OPENSSL) || defined (USE_GNUTLS))
+#ifdef USE_GNUTLS
 #  include "ssl.h"
 #endif
 
@@ -142,7 +142,7 @@ struct _IMAPNameSpace
 
 
 #define IMAP4_PORT     143
-#if (defined(USE_OPENSSL) || defined (USE_GNUTLS))
+#ifdef USE_GNUTLS
 #define IMAPS_PORT     993
 #endif
 
@@ -229,6 +229,8 @@ static gint         imap_remove_msgs        (Folder         *folder,
                                         FolderItem     *dest, 
                                         MsgInfoList    *msglist, 
                                         GRelation      *relation);
+static gint    imap_expunge            (Folder         *folder, 
+                                        FolderItem     *dest);
 static gint    imap_remove_all_msg     (Folder         *folder, 
                                         FolderItem     *item);
 
@@ -332,7 +334,7 @@ static gint imap_cmd_login  (IMAPSession    *session,
                                 const gchar    *pass,
                                 const gchar    *type);
 static gint imap_cmd_noop      (IMAPSession    *session);
-#if (defined(USE_OPENSSL) || defined (USE_GNUTLS))
+#ifdef USE_GNUTLS
 static gint imap_cmd_starttls  (IMAPSession    *session);
 #endif
 static gint imap_cmd_select    (IMAPSession    *session,
@@ -382,7 +384,7 @@ static gint imap_cmd_store  (IMAPSession    *session,
                                 IMAPFlags flags,
                                 GSList *tags,
                                 int do_add);
-static gint imap_cmd_expunge   (IMAPSession    *session);
+static gint imap_cmd_expunge   (IMAPSession    *session, gboolean force);
 
 static void imap_path_separator_subst          (gchar          *str,
                                                 gchar           separator);
@@ -476,6 +478,7 @@ FolderClass *imap_get_class(void)
                imap_class.copy_msgs = imap_copy_msgs;
                imap_class.remove_msg = imap_remove_msg;
                imap_class.remove_msgs = imap_remove_msgs;
+               imap_class.expunge = imap_expunge;
                imap_class.remove_all_msg = imap_remove_all_msg;
                imap_class.is_msg_changed = imap_is_msg_changed;
                imap_class.change_flags = imap_change_flags;
@@ -531,11 +534,14 @@ static void unlock_session(IMAPSession *session)
 
 static void imap_disc_session_destroy(IMAPSession *session)
 {
-       RemoteFolder *rfolder = REMOTE_FOLDER(IMAP_SESSION(session)->folder);
-       
-       if (!rfolder)
+       RemoteFolder *rfolder = NULL;
+
+       if (session == NULL)
                return;
-       if (!session)
+
+       rfolder = REMOTE_FOLDER(IMAP_SESSION(session)->folder);
+       
+       if (rfolder == NULL)
                return;
        log_warning(LOG_PROTOCOL, _("IMAP4 connection broken\n"));
        SESSION(session)->state = SESSION_DISCONNECTED;
@@ -557,139 +563,140 @@ static gboolean is_fatal(int libetpan_errcode)
 
 static void imap_handle_error(Session *session, int libetpan_errcode)
 {
+       const gchar *session_server = (session ? session->server:"(null)");
        switch(libetpan_errcode) {
        case MAILIMAP_NO_ERROR:
                return;
        case MAILIMAP_NO_ERROR_AUTHENTICATED:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: authenticated\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: authenticated\n"), session_server);
                break;
        case MAILIMAP_NO_ERROR_NON_AUTHENTICATED:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: not authenticated\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: not authenticated\n"), session_server);
                break;
        case MAILIMAP_ERROR_BAD_STATE:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: bad state\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: bad state\n"), session_server);
                break;
        case MAILIMAP_ERROR_STREAM:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: stream error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: stream error\n"), session_server);
                break;
        case MAILIMAP_ERROR_PARSE:
                log_warning(LOG_PROTOCOL, _("IMAP error on %s: parse error "
-                                           "(very probably non-RFC compliance from the server)\n"), session->server);
+                                           "(very probably non-RFC compliance from the server)\n"), session_server);
                break;
        case MAILIMAP_ERROR_CONNECTION_REFUSED:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: connection refused\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: connection refused\n"), session_server);
                break;
        case MAILIMAP_ERROR_MEMORY:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: memory error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: memory error\n"), session_server);
                break;
        case MAILIMAP_ERROR_FATAL:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: fatal error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: fatal error\n"), session_server);
                break;
        case MAILIMAP_ERROR_PROTOCOL:
                log_warning(LOG_PROTOCOL, _("IMAP error on %s: protocol error"
-                                           "(very probably non-RFC compliance from the server)\n"), session->server);
+                                           "(very probably non-RFC compliance from the server)\n"), session_server);
                break;
        case MAILIMAP_ERROR_DONT_ACCEPT_CONNECTION:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: connection not accepted\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: connection not accepted\n"), session_server);
                break;
        case MAILIMAP_ERROR_APPEND:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: APPEND error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: APPEND error\n"), session_server);
                break;
        case MAILIMAP_ERROR_NOOP:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: NOOP error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: NOOP error\n"), session_server);
                break;
        case MAILIMAP_ERROR_LOGOUT:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: LOGOUT error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: LOGOUT error\n"), session_server);
                break;
        case MAILIMAP_ERROR_CAPABILITY:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: CAPABILITY error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: CAPABILITY error\n"), session_server);
                break;
        case MAILIMAP_ERROR_CHECK:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: CHECK error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: CHECK error\n"), session_server);
                break;
        case MAILIMAP_ERROR_CLOSE:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: CLOSE error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: CLOSE error\n"), session_server);
                break;
        case MAILIMAP_ERROR_EXPUNGE:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: EXPUNGE error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: EXPUNGE error\n"), session_server);
                break;
        case MAILIMAP_ERROR_COPY:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: COPY error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: COPY error\n"), session_server);
                break;
        case MAILIMAP_ERROR_UID_COPY:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: UID COPY error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: UID COPY error\n"), session_server);
                break;
        case MAILIMAP_ERROR_CREATE:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: CREATE error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: CREATE error\n"), session_server);
                break;
        case MAILIMAP_ERROR_DELETE:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: DELETE error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: DELETE error\n"), session_server);
                break;
        case MAILIMAP_ERROR_EXAMINE:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: EXAMINE error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: EXAMINE error\n"), session_server);
                break;
        case MAILIMAP_ERROR_FETCH:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: FETCH error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: FETCH error\n"), session_server);
                break;
        case MAILIMAP_ERROR_UID_FETCH:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: UID FETCH error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: UID FETCH error\n"), session_server);
                break;
        case MAILIMAP_ERROR_LIST:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: LIST error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: LIST error\n"), session_server);
                break;
        case MAILIMAP_ERROR_LOGIN:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: LOGIN error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: LOGIN error\n"), session_server);
                break;
        case MAILIMAP_ERROR_LSUB:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: LSUB error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: LSUB error\n"), session_server);
                break;
        case MAILIMAP_ERROR_RENAME:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: RENAME error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: RENAME error\n"), session_server);
                break;
        case MAILIMAP_ERROR_SEARCH:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: SEARCH error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: SEARCH error\n"), session_server);
                break;
        case MAILIMAP_ERROR_UID_SEARCH:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: UID SEARCH error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: UID SEARCH error\n"), session_server);
                break;
        case MAILIMAP_ERROR_SELECT:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: SELECT error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: SELECT error\n"), session_server);
                break;
        case MAILIMAP_ERROR_STATUS:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: STATUS error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: STATUS error\n"), session_server);
                break;
        case MAILIMAP_ERROR_STORE:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: STORE error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: STORE error\n"), session_server);
                break;
        case MAILIMAP_ERROR_UID_STORE:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: UID STORE error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: UID STORE error\n"), session_server);
                break;
        case MAILIMAP_ERROR_SUBSCRIBE:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: SUBSCRIBE error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: SUBSCRIBE error\n"), session_server);
                break;
        case MAILIMAP_ERROR_UNSUBSCRIBE:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: UNSUBSCRIBE error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: UNSUBSCRIBE error\n"), session_server);
                break;
        case MAILIMAP_ERROR_STARTTLS:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: STARTTLS error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: STARTTLS error\n"), session_server);
                break;
        case MAILIMAP_ERROR_INVAL:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: INVAL error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: INVAL error\n"), session_server);
                break;
        case MAILIMAP_ERROR_EXTENSION:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: EXTENSION error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: EXTENSION error\n"), session_server);
                break;
        case MAILIMAP_ERROR_SASL:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: SASL error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: SASL error\n"), session_server);
                break;
-#if (defined(USE_OPENSSL) || defined (USE_GNUTLS))
+#ifdef USE_GNUTLS
        case MAILIMAP_ERROR_SSL:
-               log_warning(LOG_PROTOCOL, _("IMAP error on %s: SSL error\n"), session->server);
+               log_warning(LOG_PROTOCOL, _("IMAP error on %s: SSL error\n"), session_server);
                break;
 #endif
        default:
                log_warning(LOG_PROTOCOL, _("IMAP error on %s: Unknown error [%d]\n"),
-                       session->server, libetpan_errcode);
+                       session_server, libetpan_errcode);
                break;
        }
 
@@ -785,7 +792,7 @@ static int imap_get_capabilities(IMAPSession *session)
                return result;
        }
 
-       if (capabilities == NULL) {
+       if (capabilities == NULL || capabilities->cap_list == NULL) {
                return MAILIMAP_NO_ERROR;
        }
 
@@ -1028,7 +1035,7 @@ static IMAPSession *imap_session_new(Folder * folder,
        int r;
        int authenticated = FALSE;
        
-#if (defined(USE_OPENSSL) || defined (USE_GNUTLS))
+#ifdef USE_GNUTLS
        /* FIXME: IMAP over SSL only... */ 
        SSLType ssl_type;
 
@@ -1065,7 +1072,7 @@ static IMAPSession *imap_session_new(Folder * folder,
        else 
 #endif
        {
-#if (defined(USE_OPENSSL) || defined (USE_GNUTLS))
+#ifdef USE_GNUTLS
                if (ssl_type == SSL_TUNNEL) {
                        r = imap_threaded_connect_ssl(folder,
                                                      account->recv_server,
@@ -1088,7 +1095,7 @@ static IMAPSession *imap_session_new(Folder * folder,
                authenticated = FALSE;
        }
        else {
-#if (defined(USE_OPENSSL) || defined (USE_GNUTLS))
+#ifdef USE_GNUTLS
                if (r == MAILIMAP_ERROR_SSL)
                        log_error(LOG_PROTOCOL, _("SSL handshake failed\n"));
                else
@@ -1126,7 +1133,7 @@ static IMAPSession *imap_session_new(Folder * folder,
        session->folder = folder;
        IMAP_FOLDER(session->folder)->last_seen_separator = 0;
 
-#if (defined(USE_OPENSSL) || defined (USE_GNUTLS))
+#ifdef USE_GNUTLS
        if (account->ssl_imap == SSL_STARTTLS) {
                gint ok;
 
@@ -1162,7 +1169,7 @@ static gint imap_session_authenticate(IMAPSession *session,
        acc_pass = account->passwd;
 try_again:
        pass = acc_pass;
-       if (!pass && account->imap_auth_type != IMAP_AUTH_ANON) {
+       if (!pass && account->imap_auth_type != IMAP_AUTH_ANON && account->imap_auth_type != IMAP_AUTH_GSSAPI) {
                gchar *tmp_pass;
                tmp_pass = input_dialog_query_password_keep(account->recv_server, 
                                                            account->userid,
@@ -1171,7 +1178,7 @@ try_again:
                        return MAILIMAP_NO_ERROR;
                Xstrdup_a(pass, tmp_pass, {g_free(tmp_pass); return MAILIMAP_NO_ERROR;});
                g_free(tmp_pass);
-       } else if (account->imap_auth_type == IMAP_AUTH_ANON) {
+       } else if (account->imap_auth_type == IMAP_AUTH_ANON || account->imap_auth_type == IMAP_AUTH_GSSAPI) {
                pass = "";
        }
        statuswindow_print_all(_("Connecting to IMAP4 server %s...\n"),
@@ -1697,6 +1704,9 @@ static GSList *flatten_mailimap_set(struct mailimap_set * set)
        int start, end, t;
        GSList *cur;
 
+       if (!set || !set->set_list)
+               return NULL;
+
        for (list = clist_begin(set->set_list); list; list = clist_next(list)) {
                struct mailimap_set_item *item = (struct mailimap_set_item *)clist_content(list);
                start = item->set_first;
@@ -1965,8 +1975,10 @@ static gint imap_do_remove_msgs(Folder *folder, FolderItem *dest,
        }
 
        destdir = imap_get_real_path(session, IMAP_FOLDER(folder), dest->path, &ok);
-       if (is_fatal(ok))
+       if (is_fatal(ok)) {
+               g_free(destdir);
                return ok;
+       }
        for (cur = msglist; cur; cur = cur->next) {
                msginfo = (MsgInfo *)cur->data;
                if (!MSG_IS_DELETED(msginfo->flags))
@@ -1982,12 +1994,14 @@ static gint imap_do_remove_msgs(Folder *folder, FolderItem *dest,
                        (session, IMAP_FOLDER_ITEM(msginfo->folder), numlist, IMAP_FLAG_DELETED, NULL, TRUE);
                if (ok != MAILIMAP_NO_ERROR) {
                        log_warning(LOG_PROTOCOL, _("can't set deleted flags\n"));
+                       g_free(destdir);
                        return ok;
                }
        } /* else we just need to expunge */
-       ok = imap_cmd_expunge(session);
+       ok = imap_cmd_expunge(session, folder->account->imap_use_trash);
        if (ok != MAILIMAP_NO_ERROR) {
                log_warning(LOG_PROTOCOL, _("can't expunge\n"));
+               g_free(destdir);
                return ok;
        }
        
@@ -2074,7 +2088,7 @@ static gint imap_scan_tree_real(Folder *folder, gboolean subs_only)
 
        if (folder->account->imap_dir && *folder->account->imap_dir) {
                gchar *real_path;
-               int r;
+               int r = MAILIMAP_NO_ERROR;
                clist * lep_list;
 
                Xstrdup_a(root_folder, folder->account->imap_dir, {return -1;});
@@ -2156,7 +2170,7 @@ static gint imap_scan_tree_recursive(IMAPSession *session, FolderItem *item, gbo
        gchar separator;
        gchar wildcard[3];
        clist * lep_list;
-       int r;
+       int r = MAILIMAP_NO_ERROR;
        
        g_return_val_if_fail(item != NULL, -1);
        g_return_val_if_fail(item->folder != NULL, -1);
@@ -2177,8 +2191,10 @@ static gint imap_scan_tree_recursive(IMAPSession *session, FolderItem *item, gbo
                wildcard[1] = '%';
                wildcard[2] = '\0';
                real_path = imap_get_real_path(session, imapfolder, item->path, &r);
-               if (is_fatal(r))
+               if (is_fatal(r)) {
+                       g_free(real_path);
                        return r;
+               }
        } else {
                wildcard[0] = '%';
                wildcard[1] = '\0';
@@ -2197,6 +2213,7 @@ static gint imap_scan_tree_recursive(IMAPSession *session, FolderItem *item, gbo
        if (r != MAILIMAP_NO_ERROR) {
                imap_handle_error(SESSION(session), r);
                item_list = NULL;
+               g_free(real_path);
                return r;
        }
        else {
@@ -2306,7 +2323,7 @@ GList *imap_scan_subtree(Folder *folder, FolderItem *item, gboolean unsubs_only,
        GSList *item_list = NULL, *cur;
        GList *child_list = NULL, *tmplist = NULL;
        GSList *sub_list = NULL;
-       int r;
+       int r = MAILIMAP_NO_ERROR;
 
        if (!session)
                return NULL;
@@ -2320,8 +2337,10 @@ GList *imap_scan_subtree(Folder *folder, FolderItem *item, gboolean unsubs_only,
                wildcard[1] = '%';
                wildcard[2] = '\0';
                real_path = imap_get_real_path(session, IMAP_FOLDER(folder), item->path, &r);
-               if (is_fatal(r))
+               if (is_fatal(r)) {
+                       g_free(real_path);
                        return NULL;
+               }
        } else {
                wildcard[0] = '%';
                wildcard[1] = '\0';
@@ -2341,6 +2360,7 @@ GList *imap_scan_subtree(Folder *folder, FolderItem *item, gboolean unsubs_only,
 
        r = imap_threaded_list(folder, "", wildcard_path, &lep_list);
        if (r) {
+               g_free(real_path);
                statusbar_pop_all();
                return NULL;
        }
@@ -2360,6 +2380,7 @@ GList *imap_scan_subtree(Folder *folder, FolderItem *item, gboolean unsubs_only,
                                imap_get_real_path(session, 
                                        IMAP_FOLDER(folder), cur_item->path, &r));
                if (is_fatal(r)) {
+                       g_free(real_path);
                        statusbar_pop_all();
                        return NULL;
                }
@@ -2371,6 +2392,7 @@ GList *imap_scan_subtree(Folder *folder, FolderItem *item, gboolean unsubs_only,
        if (unsubs_only) {
                r = imap_threaded_lsub(folder, "", wildcard_path, &lep_list);
                if (r) {
+                       g_free(real_path);
                        statusbar_pop_all();
                        return NULL;
                }
@@ -2384,6 +2406,7 @@ GList *imap_scan_subtree(Folder *folder, FolderItem *item, gboolean unsubs_only,
                        gchar *tmp = imap_get_real_path(session, 
                                        IMAP_FOLDER(folder), cur_item->path, &r);
                        if (r) {
+                               g_free(real_path);
                                statusbar_pop_all();
                                return NULL;
                        }
@@ -2399,6 +2422,7 @@ GList *imap_scan_subtree(Folder *folder, FolderItem *item, gboolean unsubs_only,
                }
        }
 
+       g_free(real_path);
        statusbar_pop_all();
 
        return child_list;
@@ -2486,31 +2510,74 @@ static gchar *imap_folder_get_path(Folder *folder)
        return folder_path;
 }
 
+#ifdef G_OS_WIN32
+static gchar *imap_encode_unsafe_chars(const gchar *str)
+{
+       gchar *ret = NULL, *o_ret;
+       gchar *i;
+       if (!str) 
+               return NULL;
+       ret = g_malloc(3*strlen(str)+1);
+       o_ret = ret;
+       for (i = str; *i; i++) {
+               switch(*i) {
+                       case ':':
+                       case '|':
+                       case '<':
+                       case '>':
+                       case '*':
+                       case '?':
+                       case '#':
+                               *ret++ = '%';
+                               *ret++ = '0'+(*i/10);
+                               *ret++ = '0'+(*i%10);
+                               break;
+                       default:
+                               *ret++ = *i;
+               }
+       }
+       *ret++ = '\0';
+       return o_ret;
+}
+#endif
 static gchar *imap_item_get_path(Folder *folder, FolderItem *item)
 {
        gchar *folder_path, *path;
-
+       gchar *item_path = NULL;
+       
        g_return_val_if_fail(folder != NULL, NULL);
        g_return_val_if_fail(item != NULL, NULL);
        folder_path = imap_folder_get_path(folder);
 
        g_return_val_if_fail(folder_path != NULL, NULL);
-        if (folder_path[0] == G_DIR_SEPARATOR) {
-                if (item->path)
+
+#ifdef G_OS_UNIX
+       item_path = g_strdup(item->path);
+#else
+       item_path = imap_encode_unsafe_chars(item->path);
+#endif 
+
+        if (g_path_is_absolute(folder_path)) {
+                if (item_path)
                         path = g_strconcat(folder_path, G_DIR_SEPARATOR_S,
-                                           item->path, NULL);
+                                           item_path, NULL);
                 else
                         path = g_strdup(folder_path);
         } else {
-                if (item->path)
+                if (item_path)
                         path = g_strconcat(get_home_dir(), G_DIR_SEPARATOR_S,
                                            folder_path, G_DIR_SEPARATOR_S,
-                                           item->path, NULL);
+                                           item_path, NULL);
                 else
                         path = g_strconcat(get_home_dir(), G_DIR_SEPARATOR_S,
                                            folder_path, NULL);
         }
         g_free(folder_path);
+        g_free(item_path);
+#ifdef G_OS_WIN32
+       while (strchr(path, '/'))
+               *strchr(path, '/') = '\\';
+#endif
 
        return path;
 }
@@ -2524,7 +2591,7 @@ static FolderItem *imap_create_folder(Folder *folder, FolderItem *parent,
        gchar separator;
        gchar *new_name;
        const gchar *p;
-       gint ok;
+       gint ok = MAILIMAP_NO_ERROR;
        gboolean no_select = FALSE, no_sub = FALSE;
        gboolean exist = FALSE;
        
@@ -2563,11 +2630,14 @@ static FolderItem *imap_create_folder(Folder *folder, FolderItem *parent,
        strtailchomp(dirpath, '/');
        Xstrdup_a(new_name, name, {
                g_free(dirpath); 
+               g_free(imap_path);
                return NULL;});
 
        separator = imap_get_path_separator(session, IMAP_FOLDER(folder), imap_path, &ok);
-       if (is_fatal(ok))
+       if (is_fatal(ok)) {
+               g_free(imap_path);
                return NULL;
+       }
        imap_path_separator_subst(imap_path, separator);
        /* remove trailing / for display */
        strtailchomp(new_name, '/');
@@ -2670,7 +2740,7 @@ static gint imap_rename_folder(Folder *folder, FolderItem *item,
        gchar *new_cache_dir;
        IMAPSession *session;
        gchar separator;
-       gint ok;
+       gint ok = MAILIMAP_NO_ERROR;
        gint exists, recent, unseen;
        guint32 uid_validity;
 
@@ -2743,7 +2813,7 @@ static gint imap_rename_folder(Folder *folder, FolderItem *item,
 
        if (is_dir_exist(old_cache_dir)) {
                new_cache_dir = folder_item_get_path(item);
-               if (rename(old_cache_dir, new_cache_dir) < 0) {
+               if (g_rename(old_cache_dir, new_cache_dir) < 0) {
                        FILE_OP_ERROR(old_cache_dir, "rename");
                }
                g_free(new_cache_dir);
@@ -2760,7 +2830,7 @@ static gint imap_rename_folder(Folder *folder, FolderItem *item,
 gint imap_subscribe(Folder *folder, FolderItem *item, gchar *rpath, gboolean sub)
 {
        gchar *path;
-       gint r = -1;
+       gint r = MAILIMAP_NO_ERROR;
        IMAPSession *session;
        debug_print("getting session...\n");
 
@@ -2770,10 +2840,16 @@ gint imap_subscribe(Folder *folder, FolderItem *item, gchar *rpath, gboolean sub
        }
        if (item && item->path) {
                path = imap_get_real_path(session, IMAP_FOLDER(folder), item->path, &r);
-               if (!path || is_fatal(r))
+               if (!path)
                        return -1;
-               if (!strcmp(path, "INBOX") && sub == FALSE)
+               if (is_fatal(r)) {
+                       g_free(path);
                        return -1;
+               }
+               if (!strcmp(path, "INBOX") && sub == FALSE) {
+                       g_free(path);
+                       return -1;
+               }
                debug_print("%ssubscribing %s\n", sub?"":"un", path);
                r = imap_threaded_subscribe(folder, path, sub);
                g_free(path);
@@ -2786,7 +2862,7 @@ gint imap_subscribe(Folder *folder, FolderItem *item, gchar *rpath, gboolean sub
 
 static gint imap_remove_folder_real(Folder *folder, FolderItem *item)
 {
-       gint ok;
+       gint ok = MAILIMAP_NO_ERROR;
        IMAPSession *session;
        gchar *path;
        gchar *cache_dir;
@@ -2818,7 +2894,10 @@ static gint imap_remove_folder_real(Folder *folder, FolderItem *item)
        }
        ok = imap_cmd_delete(session, path);
        if (ok != MAILIMAP_NO_ERROR && !is_fatal(ok)) {
-               gchar *tmp = g_strdup_printf("%s%c", path, 
+               gchar *tmp = NULL;
+               
+               ok = MAILIMAP_NO_ERROR;
+               tmp = g_strdup_printf("%s%c", path, 
                                imap_get_path_separator(session, IMAP_FOLDER(folder), path, &ok));
                g_free(path);
                path = tmp;
@@ -2932,10 +3011,9 @@ static void *imap_get_uncached_messages_thread(void *data)
                                g_slist_free(tags);
                                continue;
                        }
-                       if (tags != NULL) {
-                               g_slist_free(msginfo->tags);
-                               msginfo->tags = NULL;
-                       }
+                       g_slist_free(msginfo->tags);
+                       msginfo->tags = NULL;
+
                        for (cur = tags; cur; cur = cur->next) {
                                gchar *real_tag = imap_modified_utf7_to_utf8(cur->data, TRUE);
                                gint id = 0;
@@ -2945,12 +3023,14 @@ static void *imap_get_uncached_messages_thread(void *data)
                                        got_alien_tags = TRUE;
                                }
                                if (!g_slist_find(msginfo->tags, GINT_TO_POINTER(id))) {
-                                       msginfo->tags = g_slist_append(
+                                       msginfo->tags = g_slist_prepend(
                                                        msginfo->tags,
                                                        GINT_TO_POINTER(id));
                                }
                                g_free(real_tag);
                        }
+                       if (msginfo->tags)
+                               msginfo->tags = g_slist_reverse(msginfo->tags);
                        slist_free_strings(tags);
                        g_slist_free(tags);
                        msginfo->folder = item;
@@ -3087,7 +3167,7 @@ gchar imap_get_path_separator_for_item(FolderItem *item)
        IMAPFolder *imap_folder = NULL;
        IMAPSession *session = NULL;
        gchar result = '/';
-       gint ok;
+       gint ok = MAILIMAP_NO_ERROR;
        if (!item)
                return '/';
        folder = item->folder;
@@ -3122,7 +3202,7 @@ static gchar imap_refresh_path_separator(IMAPSession *session, IMAPFolder *folde
                return '\0';
        }
 
-       if (clist_count(lep_list) > 0) {
+       if (lep_list != NULL && clist_count(lep_list) > 0) {
                clistiter * iter = clist_begin(lep_list); 
                struct mailimap_mailbox_list * mb;
                mb = clist_content(iter);
@@ -3138,7 +3218,7 @@ static gchar imap_refresh_path_separator(IMAPSession *session, IMAPFolder *folde
 static gchar imap_get_path_separator(IMAPSession *session, IMAPFolder *folder, const gchar *path, gint *ok)
 {
        gchar separator = '/';
-
+       *ok = MAILIMAP_NO_ERROR;
        if (folder->last_seen_separator == 0) {
                folder->last_seen_separator = imap_refresh_path_separator(session, folder, "", ok);
        }
@@ -3157,15 +3237,18 @@ static gchar imap_get_path_separator(IMAPSession *session, IMAPFolder *folder, c
 
 static gchar *imap_get_real_path(IMAPSession *session, IMAPFolder *folder, const gchar *path, gint *ok)
 {
-       gchar *real_path;
+       gchar *real_path = NULL;
        gchar separator;
-
+       
        g_return_val_if_fail(folder != NULL, NULL);
        g_return_val_if_fail(path != NULL, NULL);
 
+       *ok = MAILIMAP_NO_ERROR;
+       
        real_path = imap_utf8_to_modified_utf7(path, FALSE);
        separator = imap_get_path_separator(session, folder, path, ok);
-       imap_path_separator_subst(real_path, separator);
+       if (*ok == MAILIMAP_NO_ERROR)
+               imap_path_separator_subst(real_path, separator);
 
        return real_path;
 }
@@ -3203,8 +3286,15 @@ static gint imap_set_message_flags(IMAPSession *session,
 
        for(cur = seq_list ; cur != NULL ; cur = g_slist_next(cur)) {
                struct mailimap_set * imapset = (struct mailimap_set *)cur->data;
-               struct mailimap_set_item *set_item = clist_content(
-                                                       clist_begin(imapset->set_list));
+               struct mailimap_set_item *set_item = NULL;
+               
+               if (imapset->set_list)
+                       set_item = clist_content(clist_begin(imapset->set_list));
+               else
+                       continue;
+
+               if (set_item == NULL)
+                       continue;
 
                statusbar_progress_all(set_item->set_first, total, 1);
 
@@ -3247,7 +3337,7 @@ static gint imap_select(IMAPSession *session, IMAPFolder *folder,
                        gboolean block)
 {
        gchar *real_path;
-       gint ok;
+       gint ok = MAILIMAP_NO_ERROR;
        gint exists_, recent_, unseen_;
        guint32 uid_validity_;
        gint can_create_flags_;
@@ -3322,7 +3412,7 @@ static gint imap_status(IMAPSession *session, IMAPFolder *folder,
                        guint32 *uid_next, guint32 *uid_validity,
                        gint *unseen, gboolean block)
 {
-       int r;
+       int r = MAILIMAP_NO_ERROR;
        clistiter * iter;
        struct mailimap_mailbox_data_status * data_status;
        int got_values;
@@ -3330,9 +3420,10 @@ static gint imap_status(IMAPSession *session, IMAPFolder *folder,
        guint mask = 0;
        
        real_path = imap_get_real_path(session, folder, path, &r);
-       if (is_fatal(r))
+       if (is_fatal(r)) {
+               g_free(real_path);
                return r;
-
+       }
        if (messages) {
                mask |= 1 << 0;
                *messages = 0;
@@ -3355,6 +3446,7 @@ static gint imap_status(IMAPSession *session, IMAPFolder *folder,
                r = imap_cmd_close(session);
                if (r != MAILIMAP_NO_ERROR) {
                        debug_print("close err %d\n", r);
+                       g_free(real_path);
                        return r;
                }
        }
@@ -3376,39 +3468,41 @@ static gint imap_status(IMAPSession *session, IMAPFolder *folder,
        }
        
        got_values = 0;
-       for(iter = clist_begin(data_status->st_info_list) ; iter != NULL ;
-           iter = clist_next(iter)) {
-               struct mailimap_status_info * info;             
-               
-               info = clist_content(iter);
-               switch (info->st_att) {
-               case MAILIMAP_STATUS_ATT_MESSAGES:
-                       if (messages) {
-                               * messages = info->st_value;
-                               got_values |= 1 << 0;
-                       }
-                       break;
-                       
-               case MAILIMAP_STATUS_ATT_UIDNEXT:
-                       if (uid_next) {
-                               * uid_next = info->st_value;
-                               got_values |= 1 << 2;
-                       }
-                       break;
-                       
-               case MAILIMAP_STATUS_ATT_UIDVALIDITY:
-                       if (uid_validity) {
-                               * uid_validity = info->st_value;
-                               got_values |= 1 << 3;
-                       }
-                       break;
-                       
-               case MAILIMAP_STATUS_ATT_UNSEEN:
-                       if (unseen) {
-                               * unseen = info->st_value;
-                               got_values |= 1 << 4;
+       if (data_status->st_info_list) {
+               for(iter = clist_begin(data_status->st_info_list) ; iter != NULL ;
+                   iter = clist_next(iter)) {
+                       struct mailimap_status_info * info;             
+
+                       info = clist_content(iter);
+                       switch (info->st_att) {
+                       case MAILIMAP_STATUS_ATT_MESSAGES:
+                               if (messages) {
+                                       * messages = info->st_value;
+                                       got_values |= 1 << 0;
+                               }
+                               break;
+
+                       case MAILIMAP_STATUS_ATT_UIDNEXT:
+                               if (uid_next) {
+                                       * uid_next = info->st_value;
+                                       got_values |= 1 << 2;
+                               }
+                               break;
+
+                       case MAILIMAP_STATUS_ATT_UIDVALIDITY:
+                               if (uid_validity) {
+                                       * uid_validity = info->st_value;
+                                       got_values |= 1 << 3;
+                               }
+                               break;
+
+                       case MAILIMAP_STATUS_ATT_UNSEEN:
+                               if (unseen) {
+                                       * unseen = info->st_value;
+                                       got_values |= 1 << 4;
+                               }
+                               break;
                        }
-                       break;
                }
        }
        mailimap_mailbox_data_status_free(data_status);
@@ -3438,7 +3532,7 @@ static gint imap_cmd_login(IMAPSession *session,
        if (!strcmp(type, "LOGIN") && imap_has_capability(session, "LOGINDISABLED")) {
                gint ok = MAILIMAP_ERROR_BAD_STATE;
                if (imap_has_capability(session, "STARTTLS")) {
-#if (defined(USE_OPENSSL) || defined (USE_GNUTLS))
+#ifdef USE_GNUTLS
                        log_warning(LOG_PROTOCOL, _("Server requires TLS to log in.\n"));
                        ok = imap_cmd_starttls(session);
                        if (ok != MAILIMAP_NO_ERROR) {
@@ -3524,7 +3618,7 @@ static gint imap_cmd_noop(IMAPSession *session)
        return MAILIMAP_NO_ERROR;
 }
 
-#if (defined(USE_OPENSSL) || defined (USE_GNUTLS))
+#ifdef USE_GNUTLS
 static gint imap_cmd_starttls(IMAPSession *session)
 {
        int r;
@@ -3704,7 +3798,7 @@ static gint imap_cmd_append(IMAPSession *session,
        struct mailimap_flag_list * flag_list;
        int r;
        
-       g_return_val_if_fail(file != NULL, MAILIMAP_ERROR_BAD_STATE);
+       cm_return_val_if_fail(file != NULL, MAILIMAP_ERROR_BAD_STATE);
 
        flag_list = imap_flag_to_lep(item, flags, NULL);
        lock_session(session);
@@ -3770,10 +3864,13 @@ static gint imap_cmd_store(IMAPSession *session,
        return MAILIMAP_NO_ERROR;
 }
 
-static gint imap_cmd_expunge(IMAPSession *session)
+static gint imap_cmd_expunge(IMAPSession *session, gboolean do_expunge)
 {
        int r;
        
+       if (!do_expunge)
+               return MAILIMAP_NO_ERROR;
+
        if (prefs_common.work_offline && 
            !inc_offline_should_override(FALSE,
                _("Claws Mail needs network access in order "
@@ -3790,6 +3887,15 @@ static gint imap_cmd_expunge(IMAPSession *session)
        return MAILIMAP_NO_ERROR;
 }
 
+gint imap_expunge(Folder *folder, FolderItem *item)
+{
+       IMAPSession *session = imap_session_get(folder);
+       if (session == NULL)
+               return -1;
+       
+       return imap_cmd_expunge(session, TRUE);
+}
+
 static void imap_path_separator_subst(gchar *str, gchar separator)
 {
        gchar *p;
@@ -3818,7 +3924,7 @@ static gboolean imap_rename_folder_func(GNode *node, gpointer data)
        gchar *new_itempath;
        gint oldpathlen;
        IMAPSession *session = imap_session_get(item->folder);
-       gint ok;
+       gint ok = MAILIMAP_NO_ERROR;
        oldpathlen = strlen(oldpath);
        if (strncmp(oldpath, item->path, oldpathlen) != 0) {
                g_warning("path doesn't match: %s, %s\n", oldpath, item->path);
@@ -4380,15 +4486,8 @@ static gint imap_remove_msg(Folder *folder, FolderItem *item, gint uid)
                return ok;
        }
 
-       if (!session->uidplus) {
-               ok = imap_cmd_expunge(session);
-       } else {
-               gchar *uidstr;
+       ok = imap_cmd_expunge(session, folder->account->imap_use_trash);
 
-               uidstr = g_strdup_printf("%u", uid);
-               ok = imap_cmd_expunge(session);
-               g_free(uidstr);
-       }
        if (ok != MAILIMAP_NO_ERROR) {
                log_warning(LOG_PROTOCOL, _("can't expunge\n"));
                return ok;
@@ -4970,19 +5069,20 @@ static int imap_flags_to_flags(struct mailimap_mbx_list_flags * imap_flags)
     }
   }
   
-  for(cur = clist_begin(imap_flags->mbf_oflags) ; cur != NULL ;
-      cur = clist_next(cur)) {
-    struct mailimap_mbx_list_oflag * oflag;
-    
-    oflag = clist_content(cur);
-    
-    switch (oflag->of_type) {
-    case MAILIMAP_MBX_LIST_OFLAG_NOINFERIORS:
-      flags |= ETPAN_IMAP_MB_NOINFERIORS;
-      break;
+  if (imap_flags->mbf_oflags) {
+    for(cur = clist_begin(imap_flags->mbf_oflags) ; cur != NULL ;
+       cur = clist_next(cur)) {
+      struct mailimap_mbx_list_oflag * oflag;
+
+      oflag = clist_content(cur);
+
+      switch (oflag->of_type) {
+      case MAILIMAP_MBX_LIST_OFLAG_NOINFERIORS:
+       flags |= ETPAN_IMAP_MB_NOINFERIORS;
+       break;
+      }
     }
-  }
-  
+  }  
   return flags;
 }
 
@@ -4992,74 +5092,75 @@ static GSList * imap_list_from_lep(IMAPFolder * folder,
        clistiter * iter;
        GSList * item_list = NULL, *llast = NULL;
        
-       for(iter = clist_begin(list) ; iter != NULL ;
-           iter = clist_next(iter)) {
-               struct mailimap_mailbox_list * mb;
-               int flags;
-               char delimiter;
-               char * name;
-               char * dup_name;
-               gchar * base;
-               gchar * loc_name;
-               gchar * loc_path;
-               FolderItem *new_item;
-               
-               mb = clist_content(iter);
+       if (list) {
+               for(iter = clist_begin(list) ; iter != NULL ;
+                   iter = clist_next(iter)) {
+                       struct mailimap_mailbox_list * mb;
+                       int flags;
+                       char delimiter;
+                       char * name;
+                       char * dup_name;
+                       gchar * base;
+                       gchar * loc_name;
+                       gchar * loc_path;
+                       FolderItem *new_item;
+
+                       mb = clist_content(iter);
+
+                       if (mb == NULL)
+                               continue;
 
-               if (mb == NULL)
-                       continue;
+                       flags = 0;
+                       if (mb->mb_flag != NULL)
+                               flags = imap_flags_to_flags(mb->mb_flag);
 
-               flags = 0;
-               if (mb->mb_flag != NULL)
-                       flags = imap_flags_to_flags(mb->mb_flag);
-               
-               delimiter = mb->mb_delimiter;
-               name = mb->mb_name;
-               
-               dup_name = strdup(name);                
-               if (delimiter != '\0')
-                       subst_char(dup_name, delimiter, '/');
-               
-               base = g_path_get_basename(dup_name);
-               if (base[0] == '.') {
-                       g_free(base);
-                       free(dup_name);
-                       continue;
-               }
-               if (!all && path_cmp(name, real_path) == 0) {
+                       delimiter = mb->mb_delimiter;
+                       name = mb->mb_name;
+
+                       dup_name = strdup(name);                
+                       if (delimiter != '\0')
+                               subst_char(dup_name, delimiter, '/');
+
+                       base = g_path_get_basename(dup_name);
+                       if (base[0] == '.') {
+                               g_free(base);
+                               free(dup_name);
+                               continue;
+                       }
+                       if (!all && path_cmp(name, real_path) == 0) {
+                               g_free(base);
+                               free(dup_name);
+                               continue;
+                       }
+
+                       if (!all && dup_name[strlen(dup_name)-1] == '/') {
+                               dup_name[strlen(dup_name)-1] = '\0';
+                       }
+
+                       loc_name = imap_modified_utf7_to_utf8(base, FALSE);
+                       loc_path = imap_modified_utf7_to_utf8(dup_name, FALSE);
+
+                       new_item = folder_item_new(FOLDER(folder), loc_name, loc_path);
+                       if ((flags & ETPAN_IMAP_MB_NOINFERIORS) != 0)
+                               new_item->no_sub = TRUE;
+                       if (strcmp(dup_name, "INBOX") != 0 &&
+                           ((flags & ETPAN_IMAP_MB_NOSELECT) != 0))
+                               new_item->no_select = TRUE;
+
+                       if (item_list == NULL)
+                               llast = item_list = g_slist_append(item_list, new_item);
+                       else {
+                               llast = g_slist_append(llast, new_item);
+                               llast = llast->next;
+                       }
+                       debug_print("folder '%s' found.\n", loc_path);
                        g_free(base);
-                       free(dup_name);
-                       continue;
-               }
+                       g_free(loc_path);
+                       g_free(loc_name);
 
-               if (!all && dup_name[strlen(dup_name)-1] == '/') {
-                       dup_name[strlen(dup_name)-1] = '\0';
-               }
-               
-               loc_name = imap_modified_utf7_to_utf8(base, FALSE);
-               loc_path = imap_modified_utf7_to_utf8(dup_name, FALSE);
-               
-               new_item = folder_item_new(FOLDER(folder), loc_name, loc_path);
-               if ((flags & ETPAN_IMAP_MB_NOINFERIORS) != 0)
-                       new_item->no_sub = TRUE;
-               if (strcmp(dup_name, "INBOX") != 0 &&
-                   ((flags & ETPAN_IMAP_MB_NOSELECT) != 0))
-                       new_item->no_select = TRUE;
-               
-               if (item_list == NULL)
-                       llast = item_list = g_slist_append(item_list, new_item);
-               else {
-                       llast = g_slist_append(llast, new_item);
-                       llast = llast->next;
+                       free(dup_name);
                }
-               debug_print("folder '%s' found.\n", loc_path);
-               g_free(base);
-               g_free(loc_path);
-               g_free(loc_name);
-               
-               free(dup_name);
-       }
-       
+       }       
        return item_list;
 }
 
@@ -5152,15 +5253,16 @@ static GSList * imap_uid_list_from_lep(clist * list)
        
        result = NULL;
        
-       for(iter = clist_begin(list) ; iter != NULL ;
-           iter = clist_next(iter)) {
-               uint32_t * puid;
-               
-               puid = clist_content(iter);
-               result = g_slist_prepend(result, GINT_TO_POINTER(* puid));
-       }
-       
-       result = g_slist_reverse(result);
+       if (list) {
+               for(iter = clist_begin(list) ; iter != NULL ;
+                   iter = clist_next(iter)) {
+                       uint32_t * puid;
+
+                       puid = clist_content(iter);
+                       result = g_slist_prepend(result, GINT_TO_POINTER(* puid));
+               }
+               result = g_slist_reverse(result);
+       }       
        return result;
 }
 
@@ -5684,7 +5786,11 @@ char* imap_utf8_to_modified_utf7(const char *src, gboolean change_spaces)
   unsigned long ucs4 = 0, bitbuf = 0;
 
   /* initialize hex lookup table */
-  char *dst, *res = malloc(2*strlen(src)+1);
+  char *dst, *res;
+
+  if (!src) return NULL;
+
+  res = malloc(2*strlen(src)+1);
   dst = res;
   if(!dst) return NULL;