2008-09-01 [colin] 3.5.0cvs88
[claws.git] / src / imap.c
index 8b52e8a843ffb1d431464e30e906887eabea2371..1b50b767fc7d056fa639fbcaabdd6337351957ae 100644 (file)
@@ -137,6 +137,8 @@ struct _IMAPNameSpace
 #define IMAP_IS_DELETED(flags) ((flags & IMAP_FLAG_DELETED) != 0)
 #define IMAP_IS_DRAFT(flags)   ((flags & IMAP_FLAG_DRAFT) != 0)
 #define IMAP_IS_FORWARDED(flags)       ((flags & IMAP_FLAG_FORWARDED) != 0)
+#define IMAP_IS_SPAM(flags)    ((flags & IMAP_FLAG_SPAM) != 0)
+#define IMAP_IS_HAM(flags)     ((flags & IMAP_FLAG_HAM) != 0)
 
 
 #define IMAP4_PORT     143
@@ -188,7 +190,7 @@ static void  imap_folder_destroy    (Folder         *folder);
 
 static IMAPSession *imap_session_new   (Folder         *folder,
                                         const PrefsAccount     *account);
-static void    imap_session_authenticate(IMAPSession           *session,
+static gint    imap_session_authenticate(IMAPSession           *session,
                                          const PrefsAccount    *account);
 static void    imap_session_destroy    (Session        *session);
 
@@ -311,10 +313,12 @@ static void       imap_commit_tags        (FolderItem     *item,
 
 static gchar imap_get_path_separator           (IMAPSession    *session,
                                                 IMAPFolder     *folder,
-                                                const gchar    *path);
+                                                const gchar    *path,
+                                                gint           *ok);
 static gchar *imap_get_real_path               (IMAPSession    *session,
                                                 IMAPFolder     *folder,
-                                                const gchar    *path);
+                                                const gchar    *path,
+                                                gint           *ok);
 #ifdef HAVE_LIBETPAN
 static void imap_synchronise           (FolderItem     *item, gint days);
 #endif
@@ -433,16 +437,6 @@ typedef struct _hashtable_data {
 
 static FolderClass imap_class;
 
-typedef struct _thread_data {
-       gchar *server;
-       gushort port;
-       gboolean done;
-       SockInfo *sock;
-#if (defined(USE_OPENSSL) || defined (USE_GNUTLS))
-       SSLType ssl_type;
-#endif
-} thread_data;
-
 FolderClass *imap_get_class(void)
 {
        if (imap_class.idstr == NULL) {
@@ -535,20 +529,17 @@ static void unlock_session(IMAPSession *session)
        }
 }
 
-static void imap_disc_session_destroy(Folder *folder)
+static void imap_disc_session_destroy(IMAPSession *session)
 {
-       RemoteFolder *rfolder = REMOTE_FOLDER(folder);
-       IMAPSession *session = NULL;
+       RemoteFolder *rfolder = REMOTE_FOLDER(IMAP_SESSION(session)->folder);
        
        if (!rfolder)
                return;
-       session = IMAP_SESSION(rfolder->session);
        if (!session)
                return;
-       rfolder->session = NULL;
        log_warning(LOG_PROTOCOL, _("IMAP4 connection broken\n"));
        SESSION(session)->state = SESSION_DISCONNECTED;
-       session_destroy(SESSION(session));
+       SESSION(session)->sock = NULL;
 }
 
 static gboolean is_fatal(int libetpan_errcode)
@@ -691,12 +682,10 @@ static void imap_handle_error(Session *session, int libetpan_errcode)
        case MAILIMAP_ERROR_SASL:
                log_warning(LOG_PROTOCOL, _("IMAP error: SASL error\n"));
                break;
-#if (LIBETPAN_VERSION_MAJOR > 0 || LIBETPAN_VERSION_MINOR > 48)
 #if (defined(USE_OPENSSL) || defined (USE_GNUTLS))
        case MAILIMAP_ERROR_SSL:
                log_warning(LOG_PROTOCOL, _("IMAP error: SSL error\n"));
                break;
-#endif
 #endif
        default:
                log_warning(LOG_PROTOCOL, _("IMAP error: Unknown error [%d]\n"),
@@ -705,7 +694,7 @@ static void imap_handle_error(Session *session, int libetpan_errcode)
        }
 
        if (session && is_fatal(libetpan_errcode)) {
-               imap_disc_session_destroy(IMAP_SESSION(session)->folder);
+               imap_disc_session_destroy(IMAP_SESSION(session));
        } else if (session && !is_fatal(libetpan_errcode)) {
                if (IMAP_SESSION(session)->busy)
                        unlock_session(IMAP_SESSION(session));
@@ -793,8 +782,7 @@ static int imap_get_capabilities(IMAPSession *session)
        capabilities = imap_threaded_capability(session->folder, &result);
 
        if (result != MAILIMAP_NO_ERROR) {
-               imap_handle_error(SESSION(session), result);
-               return MAILIMAP_ERROR_CAPABILITY;
+               return result;
        }
 
        if (capabilities == NULL) {
@@ -829,14 +817,16 @@ static gboolean imap_has_capability(IMAPSession *session, const gchar *cap)
 static gint imap_auth(IMAPSession *session, const gchar *user, const gchar *pass,
                      IMAPAuthType type)
 {
-       gint ok = MAILIMAP_ERROR_BAD_STATE;
+       gint ok = MAILIMAP_ERROR_LOGIN;
        static time_t last_login_err = 0;
        gchar *ext_info = "";
        int r;
+       gchar *server = NULL;
        if ((r = imap_get_capabilities(session)) != MAILIMAP_NO_ERROR) {
                imap_handle_error(SESSION(session), r);
                return r;
        }
+       server = g_strdup(SESSION(session)->server);
        switch(type) {
        case IMAP_AUTH_ANON:
                ok = imap_cmd_login(session, user, pass, "ANONYMOUS");
@@ -867,14 +857,11 @@ static gint imap_auth(IMAPSession *session, const gchar *user, const gchar *pass
                        imap_has_capability(session, "GSSAPI"));
                if (imap_has_capability(session, "CRAM-MD5"))
                        ok = imap_cmd_login(session, user, pass, "CRAM-MD5");
-               if ((ok == MAILIMAP_ERROR_BAD_STATE ||
-                    ok == MAILIMAP_ERROR_LOGIN) && imap_has_capability(session, "DIGEST-MD5"))
+               if (ok == MAILIMAP_ERROR_LOGIN && imap_has_capability(session, "DIGEST-MD5"))
                        ok = imap_cmd_login(session, user, pass, "DIGEST-MD5");
-               if ((ok == MAILIMAP_ERROR_BAD_STATE ||
-                    ok == MAILIMAP_ERROR_LOGIN) && imap_has_capability(session, "GSSAPI"))
+               if (ok == MAILIMAP_ERROR_LOGIN && imap_has_capability(session, "GSSAPI"))
                        ok = imap_cmd_login(session, user, pass, "GSSAPI");
-               if (ok == MAILIMAP_ERROR_BAD_STATE||
-                   ok == MAILIMAP_ERROR_LOGIN) /* we always try LOGIN before giving up */
+               if (ok == MAILIMAP_ERROR_LOGIN) /* we always try LOGIN before giving up */
                        ok = imap_cmd_login(session, user, pass, "LOGIN");
        }
 
@@ -895,17 +882,18 @@ static gint imap_auth(IMAPSession *session, const gchar *user, const gchar *pass
 
                if (time(NULL) - last_login_err > 10) {
                        if (!prefs_common.no_recv_err_panel) {
-                               alertpanel_error(_("Connection to %s failed: "
+                               alertpanel_error_log(_("Connection to %s failed: "
                                        "login refused.%s"),
-                                       SESSION(session)->server, ext_info);
+                                       server, ext_info);
                        } else {
                                log_error(LOG_PROTOCOL, _("Connection to %s failed: "
                                        "login refused.%s\n"),
-                                       SESSION(session)->server, ext_info);
+                                       server, ext_info);
                        }
                }
                last_login_err = time(NULL);
        }
+       g_free(server);
        return ok;
 }
 
@@ -918,6 +906,7 @@ static IMAPSession *imap_reconnect_if_possible(Folder *folder, IMAPSession *sess
        if (rfolder->session == NULL) {
                log_warning(LOG_PROTOCOL, _("Connecting to %s failed"),
                            folder->account->recv_server);
+               SESSION(session)->sock = NULL;
                session_destroy(SESSION(session));
                session = NULL;
        } else {
@@ -929,6 +918,7 @@ static IMAPSession *imap_reconnect_if_possible(Folder *folder, IMAPSession *sess
                            " disconnected. Reconnecting...\n"),
                            folder->account->recv_server);
                SESSION(session)->state = SESSION_DISCONNECTED;
+               SESSION(session)->sock = NULL;
                session_destroy(SESSION(session));
                /* Clear folders session to make imap_session_get create
                   a new session, because of rfolder->session == NULL
@@ -960,12 +950,17 @@ static IMAPSession *imap_session_get(Folder *folder)
        }
 
        /* Make sure we have a session */
-       if (rfolder->session != NULL) {
+       if (rfolder->session != NULL && rfolder->session->state != SESSION_DISCONNECTED) {
                session = IMAP_SESSION(rfolder->session);
+       } else if (rfolder->session != NULL && rfolder->session->state == SESSION_DISCONNECTED) {
+               session_destroy(SESSION(rfolder->session));
+               rfolder->session = NULL;
+               goto new_conn;
        } else if (rfolder->connecting) {
                debug_print("already connecting\n");
                return NULL;
        } else {
+new_conn:
                imap_reset_uid_lists(folder);
                if (time(NULL) - rfolder->last_failure <= 2)
                        return NULL;
@@ -980,13 +975,16 @@ static IMAPSession *imap_session_get(Folder *folder)
 
        /* Make sure session is authenticated */
        if (!IMAP_SESSION(session)->authenticated)
-               imap_session_authenticate(IMAP_SESSION(session), folder->account);
+               r = imap_session_authenticate(IMAP_SESSION(session), folder->account);
        
-       if (!IMAP_SESSION(session)->authenticated) {
-               imap_threaded_disconnect(session->folder);
+       if (r != MAILIMAP_NO_ERROR || (!is_fatal(r) && !IMAP_SESSION(session)->authenticated)) {
                rfolder->session = NULL;
-               SESSION(session)->state = SESSION_DISCONNECTED;
-               session_destroy(SESSION(session));
+               if (!is_fatal(r)) {
+                       imap_threaded_disconnect(session->folder);
+                       SESSION(session)->state = SESSION_DISCONNECTED;
+                       SESSION(session)->sock = NULL;
+                       session_destroy(SESSION(session));
+               }
                rfolder->last_failure = time(NULL);
                rfolder->connecting = FALSE;
                return NULL;
@@ -1090,12 +1088,10 @@ static IMAPSession *imap_session_new(Folder * folder,
                authenticated = FALSE;
        }
        else {
-#if (LIBETPAN_VERSION_MAJOR > 0 || LIBETPAN_VERSION_MINOR > 48)
 #if (defined(USE_OPENSSL) || defined (USE_GNUTLS))
                if (r == MAILIMAP_ERROR_SSL)
                        log_error(LOG_PROTOCOL, _("SSL handshake failed\n"));
                else
-#endif
 #endif
                        imap_handle_error(NULL, r);
 
@@ -1111,9 +1107,10 @@ static IMAPSession *imap_session_new(Folder * folder,
        }
        
        session = g_new0(IMAPSession, 1);
-       session_init(SESSION(session));
+       session_init(SESSION(session), account, FALSE);
        SESSION(session)->type             = SESSION_IMAP;
        SESSION(session)->server           = g_strdup(account->recv_server);
+       SESSION(session)->port             = port;
        SESSION(session)->sock             = NULL;
        
        SESSION(session)->destroy          = imap_session_destroy;
@@ -1136,7 +1133,10 @@ static IMAPSession *imap_session_new(Folder * folder,
                ok = imap_cmd_starttls(session);
                if (ok != MAILIMAP_NO_ERROR) {
                        log_warning(LOG_PROTOCOL, _("Can't start TLS session.\n"));
-                       session_destroy(SESSION(session));
+                       if (!is_fatal(ok)) {
+                               SESSION(session)->sock = NULL;
+                               session_destroy(SESSION(session));
+                       }
                        return NULL;
                }
 
@@ -1152,13 +1152,13 @@ static IMAPSession *imap_session_new(Folder * folder,
        return session;
 }
 
-static void imap_session_authenticate(IMAPSession *session, 
+static gint imap_session_authenticate(IMAPSession *session, 
                                      const PrefsAccount *account)
 {
        gchar *pass, *acc_pass;
        gboolean failed = FALSE;
-
-       g_return_if_fail(account->userid != NULL);
+       gint ok = MAILIMAP_NO_ERROR;
+       g_return_val_if_fail(account->userid != NULL, MAILIMAP_ERROR_BAD_STATE);
        acc_pass = account->passwd;
 try_again:
        pass = acc_pass;
@@ -1166,35 +1166,35 @@ try_again:
                gchar *tmp_pass;
                tmp_pass = input_dialog_query_password(account->recv_server, account->userid);
                if (!tmp_pass)
-                       return;
-               Xstrdup_a(pass, tmp_pass, {g_free(tmp_pass); return;});
+                       return MAILIMAP_NO_ERROR;
+               Xstrdup_a(pass, tmp_pass, {g_free(tmp_pass); return MAILIMAP_NO_ERROR;});
                g_free(tmp_pass);
        } else if (account->imap_auth_type == IMAP_AUTH_ANON) {
                pass = "";
        }
        statuswindow_print_all(_("Connecting to IMAP4 server %s...\n"),
                                account->recv_server);
-       if (imap_auth(session, account->userid, pass, account->imap_auth_type) != MAILIMAP_NO_ERROR) {
+       if ((ok = imap_auth(session, account->userid, pass, account->imap_auth_type)) != MAILIMAP_NO_ERROR) {
                statusbar_pop_all();
                
-               if (!failed) {
+               if (!failed && !is_fatal(ok)) {
                        acc_pass = NULL;
                        failed = TRUE;
                        goto try_again;
                } else {
                        if (prefs_common.no_recv_err_panel) {
-                               log_error(LOG_PROTOCOL, _("Couldn't login to IMAP server %s."), account->recv_server);
+                               log_error(LOG_PROTOCOL, _("Couldn't login to IMAP server %s.\n"), account->recv_server);
                                mainwindow_show_error();
                        } else
                                alertpanel_error_log(_("Couldn't login to IMAP server %s."), account->recv_server);
                }               
 
-               return;
+               return ok;
        } 
 
        statuswindow_pop_all();
        session->authenticated = TRUE;
-       return;
+       return MAILIMAP_NO_ERROR;
 }
 
 static void imap_session_destroy(Session *session)
@@ -1204,8 +1204,6 @@ static void imap_session_destroy(Session *session)
        
        imap_free_capabilities(IMAP_SESSION(session));
        g_free(IMAP_SESSION(session)->mbox);
-       sock_close(session->sock);
-       session->sock = NULL;
 }
 
 static gchar *imap_fetch_msg(Folder *folder, FolderItem *item, gint uid)
@@ -1251,7 +1249,7 @@ static void imap_remove_cached_msg(Folder *folder, FolderItem *item, MsgInfo *ms
        g_free(path);
 
        if (is_file_exist(filename)) {
-               g_unlink(filename);
+               claws_unlink(filename);
        }
        g_free(filename);
 }
@@ -1286,7 +1284,6 @@ static void imap_commit_tags(FolderItem *item, MsgInfo *msginfo, GSList *tags_se
                         NULL, NULL, NULL, NULL, &can_create_tags, FALSE);
 
        if (ok != MAILIMAP_NO_ERROR) {
-               imap_handle_error(SESSION(session), ok);
                return;
        }
 
@@ -1343,7 +1340,8 @@ static void imap_commit_tags(FolderItem *item, MsgInfo *msginfo, GSList *tags_se
                for (cur = tags_set; cur; cur = cur->next) {
                        gint cur_tag = GPOINTER_TO_INT(cur->data);
                        const gchar *str = tags_get_tag(cur_tag);
-                       list_set = g_slist_prepend(list_set, g_strdup(str));
+                       if (strcmp(str, "$Forwarded") && strcmp(str, "Junk") && strcmp(str, "NonJunk") && strcmp(str, "NotJunk") && strcmp(str, "NoJunk") && strcmp(str, "Junk") )
+                               list_set = g_slist_prepend(list_set, g_strdup(str));
                }
                if (list_set) {
                        ok = imap_set_message_flags(session, 
@@ -1358,7 +1356,8 @@ static void imap_commit_tags(FolderItem *item, MsgInfo *msginfo, GSList *tags_se
                for (cur = tags_unset; cur; cur = cur->next) {
                        gint cur_tag = GPOINTER_TO_INT(cur->data);
                        const gchar *str = tags_get_tag(cur_tag);
-                       list_unset = g_slist_prepend(list_unset, g_strdup(str));
+                       if (strcmp(str, "$Forwarded") && strcmp(str, "Junk") && strcmp(str, "NonJunk") && strcmp(str, "NotJunk") && strcmp(str, "NoJunk") && strcmp(str, "Junk") )
+                               list_unset = g_slist_prepend(list_unset, g_strdup(str));
                }
                if (list_unset) {
                        ok = imap_set_message_flags(session, 
@@ -1580,8 +1579,9 @@ static gint imap_add_msgs(Folder *folder, FolderItem *dest, GSList *file_list,
        if (!session) {
                return -1;
        }
-       destdir = imap_get_real_path(session, IMAP_FOLDER(folder), dest->path);
-
+       destdir = imap_get_real_path(session, IMAP_FOLDER(folder), dest->path, &ok);
+       if (is_fatal(ok))
+               return -1;
        statusbar_print_all(_("Adding messages..."));
        total = g_slist_length(file_list);
        for (cur = file_list; cur != NULL; cur = cur->next) {
@@ -1600,6 +1600,10 @@ static gint imap_add_msgs(Folder *folder, FolderItem *dest, GSList *file_list,
                                iflags |= IMAP_FLAG_ANSWERED;
                        if (MSG_IS_FORWARDED(*fileinfo->flags))
                                iflags |= IMAP_FLAG_FORWARDED;
+                       if (MSG_IS_SPAM(*fileinfo->flags))
+                               iflags |= IMAP_FLAG_SPAM;
+                       else
+                               iflags |= IMAP_FLAG_HAM;
                        if (!MSG_IS_UNREAD(*fileinfo->flags))
                                iflags |= IMAP_FLAG_SEEN;
                        
@@ -1770,7 +1774,11 @@ static gint imap_do_copy_msgs(Folder *folder, FolderItem *dest,
 
        unlock_session(session);
 
-       destdir = imap_get_real_path(session, IMAP_FOLDER(folder), dest->path);
+       destdir = imap_get_real_path(session, IMAP_FOLDER(folder), dest->path, &ok);
+
+       if (is_fatal(ok))
+               return ok;
+
        seq_list = imap_get_lep_set_from_msglist(IMAP_FOLDER(folder), msglist);
        uid_mapping = g_relation_new(2);
        g_relation_index(uid_mapping, 0, g_direct_hash, g_direct_equal);
@@ -1950,7 +1958,9 @@ static gint imap_do_remove_msgs(Folder *folder, FolderItem *dest,
                return ok;
        }
 
-       destdir = imap_get_real_path(session, IMAP_FOLDER(folder), dest->path);
+       destdir = imap_get_real_path(session, IMAP_FOLDER(folder), dest->path, &ok);
+       if (is_fatal(ok))
+               return ok;
        for (cur = msglist; cur; cur = cur->next) {
                msginfo = (MsgInfo *)cur->data;
                if (!MSG_IS_DELETED(msginfo->flags))
@@ -2065,11 +2075,15 @@ static gint imap_scan_tree_real(Folder *folder, gboolean subs_only)
                extract_quote(root_folder, '"');
                subst_char(root_folder,
                           imap_get_path_separator(session, IMAP_FOLDER(folder),
-                                                  root_folder),
+                                                  root_folder, &r),
                           '/');
+               if (is_fatal(r))
+                       return -1;
                strtailchomp(root_folder, '/');
                real_path = imap_get_real_path
-                       (session, IMAP_FOLDER(folder), root_folder);
+                       (session, IMAP_FOLDER(folder), root_folder, &r);
+               if (is_fatal(r))
+                       return -1;
                debug_print("IMAP root directory: %s\n", real_path);
 
                /* check if root directory exist */
@@ -2145,7 +2159,9 @@ static gint imap_scan_tree_recursive(IMAPSession *session, FolderItem *item, gbo
        folder = item->folder;
        imapfolder = IMAP_FOLDER(folder);
 
-       separator = imap_get_path_separator(session, imapfolder, item->path);
+       separator = imap_get_path_separator(session, imapfolder, item->path, &r);
+       if (is_fatal(r))
+               return r;
 
        if (folder->ui_func)
                folder->ui_func(folder, item, folder->ui_func_data);
@@ -2154,7 +2170,9 @@ static gint imap_scan_tree_recursive(IMAPSession *session, FolderItem *item, gbo
                wildcard[0] = separator;
                wildcard[1] = '%';
                wildcard[2] = '\0';
-               real_path = imap_get_real_path(session, imapfolder, item->path);
+               real_path = imap_get_real_path(session, imapfolder, item->path, &r);
+               if (is_fatal(r))
+                       return r;
        } else {
                wildcard[0] = '%';
                wildcard[1] = '\0';
@@ -2173,6 +2191,7 @@ static gint imap_scan_tree_recursive(IMAPSession *session, FolderItem *item, gbo
        if (r != MAILIMAP_NO_ERROR) {
                imap_handle_error(SESSION(session), r);
                item_list = NULL;
+               return r;
        }
        else {
                item_list = imap_list_from_lep(imapfolder,
@@ -2286,13 +2305,17 @@ GList *imap_scan_subtree(Folder *folder, FolderItem *item, gboolean unsubs_only,
        if (!session)
                return NULL;
 
-       separator = imap_get_path_separator(session, IMAP_FOLDER(folder), item->path);
+       separator = imap_get_path_separator(session, IMAP_FOLDER(folder), item->path, &r);
+       if (is_fatal(r))
+               return NULL;
 
        if (item->path) {
                wildcard[0] = separator;
                wildcard[1] = '%';
                wildcard[2] = '\0';
-               real_path = imap_get_real_path(session, IMAP_FOLDER(folder), item->path);
+               real_path = imap_get_real_path(session, IMAP_FOLDER(folder), item->path, &r);
+               if (is_fatal(r))
+                       return NULL;
        } else {
                wildcard[0] = '%';
                wildcard[1] = '\0';
@@ -2329,8 +2352,11 @@ GList *imap_scan_subtree(Folder *folder, FolderItem *item, gboolean unsubs_only,
                }
                child_list = g_list_prepend(child_list,
                                imap_get_real_path(session, 
-                                       IMAP_FOLDER(folder), cur_item->path));
-               
+                                       IMAP_FOLDER(folder), cur_item->path, &r));
+               if (is_fatal(r)) {
+                       statusbar_pop_all();
+                       return NULL;
+               }
                folder_item_destroy(cur_item);
        }
        child_list = g_list_reverse(child_list);
@@ -2350,7 +2376,11 @@ GList *imap_scan_subtree(Folder *folder, FolderItem *item, gboolean unsubs_only,
                        FolderItem *cur_item = FOLDER_ITEM(cur->data);
                        GList *oldlitem = NULL;
                        gchar *tmp = imap_get_real_path(session, 
-                                       IMAP_FOLDER(folder), cur_item->path);
+                                       IMAP_FOLDER(folder), cur_item->path, &r);
+                       if (r) {
+                               statusbar_pop_all();
+                               return NULL;
+                       }
                        folder_item_destroy(cur_item);
                        oldlitem = g_list_find_custom(
                                        child_list, tmp, (GCompareFunc)strcmp2);
@@ -2529,7 +2559,9 @@ static FolderItem *imap_create_folder(Folder *folder, FolderItem *parent,
                g_free(dirpath); 
                return NULL;});
 
-       separator = imap_get_path_separator(session, IMAP_FOLDER(folder), imap_path);
+       separator = imap_get_path_separator(session, IMAP_FOLDER(folder), imap_path, &ok);
+       if (is_fatal(ok))
+               return NULL;
        imap_path_separator_subst(imap_path, separator);
        /* remove trailing / for display */
        strtailchomp(new_name, '/');
@@ -2647,13 +2679,17 @@ static gint imap_rename_folder(Folder *folder, FolderItem *item,
                return -1;
        }
 
-       if (strchr(name, imap_get_path_separator(session, IMAP_FOLDER(folder), item->path)) != NULL) {
+       if (strchr(name, imap_get_path_separator(session, IMAP_FOLDER(folder), item->path, &ok)) != NULL ||
+               is_fatal(ok)) {
                g_warning(_("New folder name must not contain the namespace "
                            "path separator"));
                return -1;
        }
 
-       real_oldpath = imap_get_real_path(session, IMAP_FOLDER(folder), item->path);
+       real_oldpath = imap_get_real_path(session, IMAP_FOLDER(folder), item->path, &ok);
+       if (is_fatal(ok)) {
+               return -1;
+       }
 
        g_free(session->mbox);
        session->mbox = NULL;
@@ -2667,7 +2703,9 @@ static gint imap_rename_folder(Folder *folder, FolderItem *item,
                return -1;
        }
 
-       separator = imap_get_path_separator(session, IMAP_FOLDER(folder), item->path);
+       separator = imap_get_path_separator(session, IMAP_FOLDER(folder), item->path, &ok);
+       if (is_fatal(ok))
+               return -1;
        if (strchr(item->path, G_DIR_SEPARATOR)) {
                dirpath = g_path_get_dirname(item->path);
                newpath = g_strconcat(dirpath, G_DIR_SEPARATOR_S, name, NULL);
@@ -2725,8 +2763,8 @@ gint imap_subscribe(Folder *folder, FolderItem *item, gchar *rpath, gboolean sub
                return -1;
        }
        if (item && item->path) {
-               path = imap_get_real_path(session, IMAP_FOLDER(folder), item->path);
-               if (!path)
+               path = imap_get_real_path(session, IMAP_FOLDER(folder), item->path, &r);
+               if (!path || is_fatal(r))
                        return -1;
                if (!strcmp(path, "INBOX") && sub == FALSE)
                        return -1;
@@ -2757,7 +2795,9 @@ static gint imap_remove_folder_real(Folder *folder, FolderItem *item)
        if (!session) {
                return -1;
        }
-       path = imap_get_real_path(session, IMAP_FOLDER(folder), item->path);
+       path = imap_get_real_path(session, IMAP_FOLDER(folder), item->path, &ok);
+       if (is_fatal(ok))
+               return -1;
 
        imap_threaded_subscribe(folder, path, FALSE);
 
@@ -2767,17 +2807,17 @@ static gint imap_remove_folder_real(Folder *folder, FolderItem *item)
                ok = imap_cmd_close(session);
                if (ok != MAILIMAP_NO_ERROR) {
                        debug_print("close err %d\n", ok);
-                       imap_handle_error(SESSION(session), ok);
                        return ok;
                }
        }
        ok = imap_cmd_delete(session, path);
-       if (ok != MAILIMAP_NO_ERROR) {
+       if (ok != MAILIMAP_NO_ERROR && !is_fatal(ok)) {
                gchar *tmp = g_strdup_printf("%s%c", path, 
-                               imap_get_path_separator(session, IMAP_FOLDER(folder), path));
+                               imap_get_path_separator(session, IMAP_FOLDER(folder), path, &ok));
                g_free(path);
                path = tmp;
-               ok = imap_cmd_delete(session, path);
+               if (!is_fatal(ok))
+                       ok = imap_cmd_delete(session, path);
        }
 
        if (ok != MAILIMAP_NO_ERROR) {
@@ -2894,7 +2934,6 @@ static void *imap_get_uncached_messages_thread(void *data)
                                gchar *real_tag = imap_modified_utf7_to_utf8(cur->data, TRUE);
                                gint id = 0;
                                id = tags_get_id_for_str(real_tag);
-                               printf("tag %s %d\n", real_tag, id);
                                if (id == -1) {
                                        id = tags_add_tag(real_tag);
                                        got_alien_tags = TRUE;
@@ -3042,7 +3081,7 @@ gchar imap_get_path_separator_for_item(FolderItem *item)
        IMAPFolder *imap_folder = NULL;
        IMAPSession *session = NULL;
        gchar result = '/';
-       
+       gint ok;
        if (!item)
                return '/';
        folder = item->folder;
@@ -3057,11 +3096,11 @@ gchar imap_get_path_separator_for_item(FolderItem *item)
        
        debug_print("getting session...");
        session = imap_session_get(FOLDER(folder));
-       result = imap_get_path_separator(session, imap_folder, item->path);
+       result = imap_get_path_separator(session, imap_folder, item->path, &ok);
        return result;
 }
 
-static gchar imap_refresh_path_separator(IMAPSession *session, IMAPFolder *folder, const gchar *subfolder)
+static gchar imap_refresh_path_separator(IMAPSession *session, IMAPFolder *folder, const gchar *subfolder, gint *ok)
 {
        clist * lep_list;
        int r;
@@ -3073,6 +3112,7 @@ static gchar imap_refresh_path_separator(IMAPSession *session, IMAPFolder *folde
        if (r != MAILIMAP_NO_ERROR) {
                imap_handle_error(SESSION(session), r);
                log_warning(LOG_PROTOCOL, _("LIST failed\n"));
+               *ok = r;
                return '\0';
        }
 
@@ -3084,20 +3124,21 @@ static gchar imap_refresh_path_separator(IMAPSession *session, IMAPFolder *folde
                separator = mb->mb_delimiter;
                debug_print("got separator: %c\n", folder->last_seen_separator);
        }
+       *ok = MAILIMAP_NO_ERROR;
        mailimap_list_result_free(lep_list);
        return separator;
 }
 
-static gchar imap_get_path_separator(IMAPSession *session, IMAPFolder *folder, const gchar *path)
+static gchar imap_get_path_separator(IMAPSession *session, IMAPFolder *folder, const gchar *path, gint *ok)
 {
        gchar separator = '/';
 
        if (folder->last_seen_separator == 0) {
-               folder->last_seen_separator = imap_refresh_path_separator(session, folder, "");
+               folder->last_seen_separator = imap_refresh_path_separator(session, folder, "", ok);
        }
 
        if (folder->last_seen_separator == 0) {
-               folder->last_seen_separator = imap_refresh_path_separator(session, folder, "INBOX");
+               folder->last_seen_separator = imap_refresh_path_separator(session, folder, "INBOX", ok);
        }
 
        if (folder->last_seen_separator != 0) {
@@ -3108,7 +3149,7 @@ static gchar imap_get_path_separator(IMAPSession *session, IMAPFolder *folder, c
        return separator;
 }
 
-static gchar *imap_get_real_path(IMAPSession *session, IMAPFolder *folder, const gchar *path)
+static gchar *imap_get_real_path(IMAPSession *session, IMAPFolder *folder, const gchar *path, gint *ok)
 {
        gchar *real_path;
        gchar separator;
@@ -3117,7 +3158,7 @@ static gchar *imap_get_real_path(IMAPSession *session, IMAPFolder *folder, const
        g_return_val_if_fail(path != NULL, NULL);
 
        real_path = imap_utf8_to_modified_utf7(path, FALSE);
-       separator = imap_get_path_separator(session, folder, path);
+       separator = imap_get_path_separator(session, folder, path, ok);
        imap_path_separator_subst(real_path, separator);
 
        return real_path;
@@ -3237,8 +3278,9 @@ static gint imap_select(IMAPSession *session, IMAPFolder *folder,
        session->recent = 0;
        session->expunge = 0;
 
-       real_path = imap_get_real_path(session, folder, path);
-
+       real_path = imap_get_real_path(session, folder, path, &ok);
+       if (is_fatal(ok))
+               return ok;              
        g_slist_free(IMAP_FOLDER_ITEM(item)->ok_flags);
        IMAP_FOLDER_ITEM(item)->ok_flags = NULL;
        ok = imap_cmd_select(session, real_path,
@@ -3281,7 +3323,9 @@ static gint imap_status(IMAPSession *session, IMAPFolder *folder,
        gchar *real_path;
        guint mask = 0;
        
-       real_path = imap_get_real_path(session, folder, path);
+       real_path = imap_get_real_path(session, folder, path, &r);
+       if (is_fatal(r))
+               return r;
 
        if (messages) {
                mask |= 1 << 0;
@@ -3304,7 +3348,6 @@ static gint imap_status(IMAPSession *session, IMAPFolder *folder,
            !strcmp(session->mbox, item->item.path)) {
                r = imap_cmd_close(session);
                if (r != MAILIMAP_NO_ERROR) {
-                       imap_handle_error(SESSION(session), r);
                        debug_print("close err %d\n", r);
                        return r;
                }
@@ -3410,11 +3453,11 @@ static gint imap_cmd_login(IMAPSession *session,
                                        "has been compiled without OpenSSL "
                                        "support.\n"),
                                        SESSION(session)->server);
-                       return MAILIMAP_ERROR_BAD_STATE;
+                       return MAILIMAP_ERROR_LOGIN;
 #endif
                } else {
                        log_error(LOG_PROTOCOL, _("Server logins are disabled.\n"));
-                       return MAILIMAP_ERROR_BAD_STATE;
+                       return MAILIMAP_ERROR_LOGIN;
                }
        }
 
@@ -3550,7 +3593,6 @@ static gint imap_cmd_create(IMAPSession *session, const gchar *folder)
        r = imap_threaded_create(session->folder, folder);
        if (r != MAILIMAP_NO_ERROR) {
                imap_handle_error(SESSION(session), r);
-               
                return r;
        }
 
@@ -3614,7 +3656,7 @@ static void *imap_cmd_fetch_thread(void *data)
        if (r != MAILIMAP_NO_ERROR) {
                imap_handle_error(SESSION(session), r);
                debug_print("fetch err %d\n", r);
-               return GINT_TO_POINTER(MAILIMAP_ERROR_BAD_STATE);
+               return GINT_TO_POINTER(r);
        }
        return GINT_TO_POINTER(MAILIMAP_NO_ERROR);
 }
@@ -3770,7 +3812,7 @@ static gboolean imap_rename_folder_func(GNode *node, gpointer data)
        gchar *new_itempath;
        gint oldpathlen;
        IMAPSession *session = imap_session_get(item->folder);
-
+       gint ok;
        oldpathlen = strlen(oldpath);
        if (strncmp(oldpath, item->path, oldpathlen) != 0) {
                g_warning("path doesn't match: %s, %s\n", oldpath, item->path);
@@ -3785,11 +3827,11 @@ static gboolean imap_rename_folder_func(GNode *node, gpointer data)
                new_itempath = g_strconcat(newpath, G_DIR_SEPARATOR_S, base,
                                           NULL);
 
-       real_oldpath = imap_get_real_path(session, IMAP_FOLDER(item->folder), item->path);
+       real_oldpath = imap_get_real_path(session, IMAP_FOLDER(item->folder), item->path, &ok);
        g_free(item->path);
        item->path = new_itempath;
        
-       real_newpath = imap_get_real_path(session, IMAP_FOLDER(item->folder), item->path);
+       real_newpath = imap_get_real_path(session, IMAP_FOLDER(item->folder), item->path, &ok);
        
        imap_threaded_subscribe(item->folder, real_oldpath, FALSE);
        imap_threaded_subscribe(item->folder, real_newpath, TRUE);
@@ -4219,6 +4261,14 @@ void imap_change_flags(Folder *folder, FolderItem *item, MsgInfo *msginfo, MsgPe
        if ( MSG_IS_FORWARDED(msginfo->flags) && !(newflags & MSG_FORWARDED))
                flags_unset |= IMAP_FLAG_FORWARDED;
 
+       if (!MSG_IS_SPAM(msginfo->flags) &&  (newflags & MSG_SPAM)) {
+               flags_set |= IMAP_FLAG_SPAM;
+               flags_unset |= IMAP_FLAG_HAM;
+       }
+       if ( MSG_IS_SPAM(msginfo->flags) && !(newflags & MSG_SPAM)) {
+               flags_set |= IMAP_FLAG_HAM;
+               flags_unset |= IMAP_FLAG_SPAM;
+       }
        if (!MSG_IS_DELETED(msginfo->flags) &&  (newflags & MSG_DELETED))
                flags_set |= IMAP_FLAG_DELETED;
        if ( MSG_IS_DELETED(msginfo->flags) && !(newflags & MSG_DELETED))
@@ -4412,8 +4462,7 @@ static /*gint*/ void *imap_get_flags_thread(void *data)
        GHashTable *tags_hash = NULL;
        gboolean full_search = stuff->full_search;
        GSList *sorted_list = NULL;
-       GSList *unseen = NULL, *answered = NULL, *flagged = NULL, *deleted = NULL, *forwarded = NULL;
-       GSList *p_unseen, *p_answered, *p_flagged, *p_deleted, *p_forwarded;
+       GSList *unseen = NULL, *answered = NULL, *flagged = NULL, *deleted = NULL, *forwarded = NULL, *spam = NULL;
        GSList *seq_list, *cur;
        gboolean reverse_seen = FALSE;
        gboolean selected_folder;
@@ -4528,6 +4577,22 @@ static /*gint*/ void *imap_get_flags_thread(void *data)
                                        }
                                }
 
+                               if (flag_ok(IMAP_FOLDER_ITEM(fitem), IMAP_FLAG_SPAM)) {
+                                       r = imap_threaded_search(folder, IMAP_SEARCH_TYPE_SPAM,
+                                                                full_search ? NULL:imapset, &lep_uidlist);
+                                       if (r == MAILIMAP_NO_ERROR) {
+                                               GSList * uidlist;
+
+                                               uidlist = imap_uid_list_from_lep(lep_uidlist);
+                                               mailimap_search_result_free(lep_uidlist);
+
+                                               spam = g_slist_concat(spam, uidlist);
+                                       } else {
+                                               imap_handle_error(SESSION(session), r);
+                                               goto bail;
+                                       }
+                               }
+
                                r = imap_threaded_search(folder, IMAP_SEARCH_TYPE_DELETED,
                                                         full_search ? NULL:imapset, &lep_uidlist);
                                if (r == MAILIMAP_NO_ERROR) {
@@ -4543,11 +4608,6 @@ static /*gint*/ void *imap_get_flags_thread(void *data)
                                }
                        }
                }
-               p_unseen = unseen;
-               p_answered = answered;
-               p_forwarded = forwarded;
-               p_flagged = flagged;
-               p_deleted = deleted;
 
        } else {
                r = imap_threaded_fetch_uid_flags(folder, 1, &lep_uidtab);
@@ -4574,17 +4634,17 @@ bail:
                msginfo = (MsgInfo *) elem->data;
                flags = msginfo->flags.perm_flags;
                wasnew = (flags & MSG_NEW);
-               oldflags = flags & ~(MSG_NEW|MSG_UNREAD|MSG_REPLIED|MSG_FORWARDED|MSG_MARKED|MSG_DELETED);
+               oldflags = flags & ~(MSG_NEW|MSG_UNREAD|MSG_REPLIED|MSG_FORWARDED|MSG_MARKED|MSG_DELETED|MSG_SPAM);
 
                if (folder->account && folder->account->low_bandwidth) {
                        if (fitem->opened || fitem->processing_pending || fitem == folder->inbox) {
-                               flags &= ~((reverse_seen ? 0 : MSG_UNREAD | MSG_NEW) | MSG_REPLIED | MSG_FORWARDED | MSG_MARKED);
+                               flags &= ~((reverse_seen ? 0 : MSG_UNREAD | MSG_NEW) | MSG_REPLIED | MSG_FORWARDED | MSG_MARKED | MSG_SPAM);
                        } else {
                                flags &= ~((reverse_seen ? 0 : MSG_UNREAD | MSG_NEW | MSG_MARKED));
                        }
                        if (reverse_seen)
                                flags |= MSG_UNREAD | (wasnew ? MSG_NEW : 0);
-                       if (gslist_find_next_num(&p_unseen, msginfo->msgnum) == msginfo->msgnum) {
+                       if (gslist_find_next_num(&unseen, msginfo->msgnum) == msginfo->msgnum) {
                                if (!reverse_seen) {
                                        flags |= MSG_UNREAD | (wasnew ? MSG_NEW : 0);
                                } else {
@@ -4592,21 +4652,25 @@ bail:
                                }
                        }
 
-                       if (gslist_find_next_num(&p_flagged, msginfo->msgnum) == msginfo->msgnum)
+                       if (gslist_find_next_num(&flagged, msginfo->msgnum) == msginfo->msgnum)
                                flags |= MSG_MARKED;
                        else
                                flags &= ~MSG_MARKED;
 
                        if (fitem->opened || fitem->processing_pending || fitem == folder->inbox) {
-                               if (gslist_find_next_num(&p_answered, msginfo->msgnum) == msginfo->msgnum)
+                               if (gslist_find_next_num(&answered, msginfo->msgnum) == msginfo->msgnum)
                                        flags |= MSG_REPLIED;
                                else
                                        flags &= ~MSG_REPLIED;
-                               if (gslist_find_next_num(&p_forwarded, msginfo->msgnum) == msginfo->msgnum)
+                               if (gslist_find_next_num(&forwarded, msginfo->msgnum) == msginfo->msgnum)
                                        flags |= MSG_FORWARDED;
                                else
                                        flags &= ~MSG_FORWARDED;
-                               if (gslist_find_next_num(&p_deleted, msginfo->msgnum) == msginfo->msgnum)
+                               if (gslist_find_next_num(&spam, msginfo->msgnum) == msginfo->msgnum)
+                                       flags |= MSG_SPAM;
+                               else
+                                       flags &= ~MSG_SPAM;
+                               if (gslist_find_next_num(&deleted, msginfo->msgnum) == msginfo->msgnum)
                                        flags |= MSG_DELETED;
                                else
                                        flags &= ~MSG_DELETED;
@@ -4670,6 +4734,7 @@ bail:
        g_slist_free(deleted);
        g_slist_free(answered);
        g_slist_free(forwarded);
+       g_slist_free(spam);
        g_slist_free(unseen);
        g_slist_free(sorted_list);
 
@@ -5138,7 +5203,7 @@ static MsgInfo *imap_envelope_from_lep(struct imap_fetch_env_info * info,
 {
        MsgInfo *msginfo = NULL;
        guint32 uid = 0;
-       size_t size = 0;
+       goffset size = 0;
        MsgFlags flags = {0, 0};
        
        if (info->headers == NULL)
@@ -5153,7 +5218,7 @@ static MsgInfo *imap_envelope_from_lep(struct imap_fetch_env_info * info,
        flags.perm_flags = info->flags;
        
        uid = info->uid;
-       size = info->size;
+       size = (goffset) info->size;
        msginfo = procheader_parse_str(info->headers, flags, FALSE, FALSE);
        
        if (msginfo) {
@@ -5184,24 +5249,30 @@ static struct mailimap_flag_list * imap_flag_to_lep(IMAPFolderItem *item, IMAPFl
 
        flag_list = mailimap_flag_list_new_empty();
        
-       if (IMAP_IS_SEEN(flags) && flag_ok(item, IMAP_FLAG_SEEN))
+       if (IMAP_IS_SEEN(flags))
                mailimap_flag_list_add(flag_list,
                                       mailimap_flag_new_seen());
-       if (IMAP_IS_ANSWERED(flags) && flag_ok(item, IMAP_FLAG_ANSWERED))
+       if (IMAP_IS_ANSWERED(flags))
                mailimap_flag_list_add(flag_list,
                                       mailimap_flag_new_answered());
-       if (IMAP_IS_FLAGGED(flags) && flag_ok(item, IMAP_FLAG_FLAGGED))
+       if (IMAP_IS_FLAGGED(flags))
                mailimap_flag_list_add(flag_list,
                                       mailimap_flag_new_flagged());
-       if (IMAP_IS_DELETED(flags) && flag_ok(item, IMAP_FLAG_DELETED))
+       if (IMAP_IS_DELETED(flags))
                mailimap_flag_list_add(flag_list,
                                       mailimap_flag_new_deleted());
-       if (IMAP_IS_DRAFT(flags) && flag_ok(item, IMAP_FLAG_DRAFT))
+       if (IMAP_IS_DRAFT(flags))
                mailimap_flag_list_add(flag_list,
                                       mailimap_flag_new_draft());
        if (IMAP_IS_FORWARDED(flags) && flag_ok(item, IMAP_FLAG_FORWARDED))
                mailimap_flag_list_add(flag_list,
                                       mailimap_flag_new_flag_keyword(strdup("$Forwarded")));
+       if (IMAP_IS_SPAM(flags) && flag_ok(item, IMAP_FLAG_SPAM))
+               mailimap_flag_list_add(flag_list,
+                                      mailimap_flag_new_flag_keyword(strdup("Junk")));
+       else if (IMAP_IS_HAM(flags) && flag_ok(item, IMAP_FLAG_HAM))
+               mailimap_flag_list_add(flag_list,
+                                      mailimap_flag_new_flag_keyword(strdup("NonJunk")));
        
        for (; cur; cur = cur->next) {
                gchar *enc_str = 
@@ -5255,6 +5326,7 @@ void imap_disconnect_all(void)
                                IMAPSession *session = (IMAPSession *)folder->session;
                                imap_threaded_disconnect(FOLDER(folder));
                                SESSION(session)->state = SESSION_DISCONNECTED;
+                               SESSION(session)->sock = NULL;
                                session_destroy(SESSION(session));
                                folder->session = NULL;
                        }