2005-10-20 [colin] 1.9.15cvs81
[claws.git] / src / imap.c
index 1228491fe7669301468d24f517ea2593a558f983..1052c6389252c46c05974c1a1f1e2a13521e91ca 100644 (file)
@@ -14,7 +14,7 @@
  *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  */
 
 #ifdef HAVE_CONFIG_H
@@ -107,6 +107,7 @@ struct _IMAPSession
        gboolean folder_content_changed;
        guint exists;
        Folder * folder;
+       gboolean busy;
 };
 
 struct _IMAPNameSpace
@@ -156,6 +157,15 @@ struct _IMAPFolderItem
        guint uid_next;
        GSList *uid_list;
        gboolean batching;
+
+       time_t use_cache;
+       gint c_messages;
+       guint32 c_uid_next;
+       guint32 c_uid_validity;
+       gint c_unseen;
+
+       GHashTable *flags_set_table;
+       GHashTable *flags_unset_table;
 };
 
 static void imap_folder_init           (Folder         *folder,
@@ -271,8 +281,8 @@ static gint imap_select                     (IMAPSession    *session,
 static gint imap_status                        (IMAPSession    *session,
                                         IMAPFolder     *folder,
                                         const gchar    *path,
+                                        IMAPFolderItem *item,
                                         gint           *messages,
-                                        gint           *recent,
                                         guint32        *uid_next,
                                         guint32        *uid_validity,
                                         gint           *unseen,
@@ -375,7 +385,7 @@ static MsgInfo *imap_parse_msg(const gchar *file, FolderItem *item);
 
 /* data types conversion libetpan <-> sylpheed */
 static GSList * imap_list_from_lep(IMAPFolder * folder,
-                                  clist * list, const gchar * real_path);
+                                  clist * list, const gchar * real_path, gboolean all);
 static GSList * imap_get_lep_set_from_numlist(MsgNumberList *numlist);
 static GSList * imap_get_lep_set_from_msglist(MsgInfoList *msglist);
 static GSList * imap_uid_list_from_lep(clist * list);
@@ -385,12 +395,10 @@ static MsgInfo *imap_envelope_from_lep(struct imap_fetch_env_info * info,
 static void imap_lep_set_free(GSList *seq_list);
 static struct mailimap_flag_list * imap_flag_to_lep(IMAPFlags flags);
 
-
-static GHashTable *flags_set_table = NULL;
-static GHashTable *flags_unset_table = NULL;
 typedef struct _hashtable_data {
        IMAPSession *session;
        GSList *msglist;
+       IMAPFolderItem *item;
 } hashtable_data;
 
 static FolderClass imap_class;
@@ -607,8 +615,15 @@ static gint imap_auth(IMAPSession *session, const gchar *user, const gchar *pass
                }
                
                if (time(NULL) - last_login_err > 10) {
-                       alertpanel_error(_("Connection to %s failed: login refused.%s"),
+                       if (!prefs_common.no_recv_err_panel) {
+                               alertpanel_error(_("Connection to %s failed: "
+                                       "login refused.%s"),
                                        SESSION(session)->server, ext_info);
+                       } else {
+                               log_error(_("Connection to %s failed: "
+                                       "login refused.%s\n"),
+                                       SESSION(session)->server, ext_info);
+                       }
                }
                last_login_err = time(NULL);
        }
@@ -647,6 +662,16 @@ static IMAPSession *imap_reconnect_if_possible(Folder *folder, IMAPSession *sess
        return session;
 }
 
+#define lock_session() {\
+       debug_print("locking session\n"); \
+       session->busy = TRUE;\
+}
+
+#define unlock_session() {\
+       debug_print("unlocking session\n"); \
+       session->busy = FALSE;\
+}
+
 static IMAPSession *imap_session_get(Folder *folder)
 {
        RemoteFolder *rfolder = REMOTE_FOLDER(folder);
@@ -663,6 +688,10 @@ static IMAPSession *imap_session_get(Folder *folder)
        /* Make sure we have a session */
        if (rfolder->session != NULL) {
                session = IMAP_SESSION(rfolder->session);
+               /* don't do that yet... 
+               if (session->busy) {
+                       return NULL;
+               } */
        } else {
                imap_reset_uid_lists(folder);
                session = imap_session_new(folder, folder->account);
@@ -680,12 +709,6 @@ static IMAPSession *imap_session_get(Folder *folder)
                return NULL;
        }
 
-#if 0
-       /* Make sure we have parsed the IMAP namespace */
-       imap_parse_namespace(IMAP_SESSION(session),
-                            IMAP_FOLDER(folder));
-#endif
-
        /* I think the point of this code is to avoid sending a
         * keepalive if we've used the session recently and therefore
         * think it's still alive.  Unfortunately, most of the code
@@ -731,7 +754,7 @@ static IMAPSession *imap_session_new(Folder * folder,
                          "Do you want to continue connecting to this "
                          "server? The communication would not be "
                          "secure."),
-                         _("Continue connecting"), 
+                         _("Con_tinue connecting"), 
                          GTK_STOCK_CANCEL, NULL,
                          FALSE, NULL, ALERT_WARNING,
                          G_ALERTALTERNATE) != G_ALERTDEFAULT)
@@ -777,7 +800,7 @@ static IMAPSession *imap_session_new(Folder * folder,
                        alertpanel_error(_("Can't connect to IMAP4 server: %s:%d"),
                                         account->recv_server, port);
                } else {
-                       log_error(_("Can't connect to IMAP4 server: %s:%d"),
+                       log_error(_("Can't connect to IMAP4 server: %s:%d\n"),
                                         account->recv_server, port);
                } 
                
@@ -935,17 +958,21 @@ static gchar *imap_fetch_msg_full(Folder *folder, FolderItem *item, gint uid,
        }
 
        session = imap_session_get(folder);
+       
        if (!session) {
                g_free(filename);
                return NULL;
        }
 
+       lock_session();
+
        debug_print("IMAP fetching messages\n");
        ok = imap_select(session, IMAP_FOLDER(folder), item->path,
                         NULL, NULL, NULL, NULL, FALSE);
        if (ok != IMAP_SUCCESS) {
                g_warning("can't select mailbox %s\n", item->path);
                g_free(filename);
+               unlock_session();
                return NULL;
        }
 
@@ -955,9 +982,11 @@ static gchar *imap_fetch_msg_full(Folder *folder, FolderItem *item, gint uid,
        if (ok != IMAP_SUCCESS) {
                g_warning("can't fetch message %d\n", uid);
                g_free(filename);
+               unlock_session();
                return NULL;
        }
 
+       unlock_session();
        file_strip_crs(filename);
        return filename;
 }
@@ -990,6 +1019,7 @@ static gint imap_add_msgs(Folder *folder, FolderItem *dest, GSList *file_list,
        GSList *cur;
        MsgFileInfo *fileinfo;
        gint ok;
+       gint curnum = 0, total = 0;
 
 
        g_return_val_if_fail(folder != NULL, -1);
@@ -1000,8 +1030,11 @@ static gint imap_add_msgs(Folder *folder, FolderItem *dest, GSList *file_list,
        if (!session) {
                return -1;
        }
+       lock_session();
        destdir = imap_get_real_path(IMAP_FOLDER(folder), dest->path);
 
+       statusbar_print_all(_("Adding messages..."));
+       total = g_slist_length(file_list);
        for (cur = file_list; cur != NULL; cur = cur->next) {
                IMAPFlags iflags = 0;
                guint32 new_uid = 0;
@@ -1009,6 +1042,9 @@ static gint imap_add_msgs(Folder *folder, FolderItem *dest, GSList *file_list,
                gboolean file_is_tmp = FALSE;
                fileinfo = (MsgFileInfo *)cur->data;
 
+               statusbar_progress_all(curnum, total, 1);
+               curnum++;
+
                if (fileinfo->flags) {
                        if (MSG_IS_MARKED(*fileinfo->flags))
                                iflags |= IMAP_FLAG_FLAGGED;
@@ -1030,6 +1066,7 @@ static gint imap_add_msgs(Folder *folder, FolderItem *dest, GSList *file_list,
                                                real_file) !=0) {
                                        g_free(real_file);
                                        g_free(destdir);
+                                       unlock_session();
                                        return -1;
                                }
                        } 
@@ -1052,6 +1089,9 @@ static gint imap_add_msgs(Folder *folder, FolderItem *dest, GSList *file_list,
                                g_unlink(real_file);
                        g_free(real_file);
                        g_free(destdir);
+                       unlock_session();
+                       statusbar_progress_all(0,0,0);
+                       statusbar_pop_all();
                        return -1;
                }
 
@@ -1064,7 +1104,11 @@ static gint imap_add_msgs(Folder *folder, FolderItem *dest, GSList *file_list,
                if (file_is_tmp)
                        g_unlink(real_file);
        }
-
+       statusbar_progress_all(0,0,0);
+       statusbar_pop_all();
+       
+       unlock_session();
+       
        g_free(destdir);
 
        return last_uid;
@@ -1081,7 +1125,7 @@ static gint imap_do_copy_msgs(Folder *folder, FolderItem *dest,
        gint ok = IMAP_SUCCESS;
        GRelation *uid_mapping;
        gint last_num = 0;
-       
+
        g_return_val_if_fail(folder != NULL, -1);
        g_return_val_if_fail(dest != NULL, -1);
        g_return_val_if_fail(msglist != NULL, -1);
@@ -1091,17 +1135,20 @@ static gint imap_do_copy_msgs(Folder *folder, FolderItem *dest,
        if (!session) {
                return -1;
        }
+       lock_session();
        msginfo = (MsgInfo *)msglist->data;
 
        src = msginfo->folder;
        if (src == dest) {
                g_warning("the src folder is identical to the dest.\n");
+               unlock_session();
                return -1;
        }
 
        ok = imap_select(session, IMAP_FOLDER(folder), msginfo->folder->path,
                         NULL, NULL, NULL, NULL, FALSE);
        if (ok != IMAP_SUCCESS) {
+               unlock_session();
                return ok;
        }
 
@@ -1110,11 +1157,11 @@ static gint imap_do_copy_msgs(Folder *folder, FolderItem *dest,
        uid_mapping = g_relation_new(2);
        g_relation_index(uid_mapping, 0, g_direct_hash, g_direct_equal);
        
+       statusbar_print_all(_("Copying messages..."));
        for (cur = seq_list; cur != NULL; cur = g_slist_next(cur)) {
                struct mailimap_set * seq_set;
-               
                seq_set = cur->data;
-               
+
                debug_print("Copying messages from %s to %s ...\n",
                            src->path, destdir);
 
@@ -1122,6 +1169,7 @@ static gint imap_do_copy_msgs(Folder *folder, FolderItem *dest,
                if (ok != IMAP_SUCCESS) {
                        g_relation_destroy(uid_mapping);
                        imap_lep_set_free(seq_list);
+                       unlock_session();
                        return -1;
                }
        }
@@ -1144,6 +1192,7 @@ static gint imap_do_copy_msgs(Folder *folder, FolderItem *dest,
                                          GPOINTER_TO_INT(0));
                g_tuples_destroy(tuples);
        }
+       statusbar_pop_all();
 
        g_relation_destroy(uid_mapping);
        imap_lep_set_free(seq_list);
@@ -1155,6 +1204,7 @@ static gint imap_do_copy_msgs(Folder *folder, FolderItem *dest,
        g_slist_free(IMAP_FOLDER_ITEM(dest)->uid_list);
        IMAP_FOLDER_ITEM(dest)->uid_list = NULL;
 
+       unlock_session();
        if (ok == IMAP_SUCCESS)
                return last_num;
        else
@@ -1209,7 +1259,7 @@ static gint imap_do_remove_msgs(Folder *folder, FolderItem *dest,
                                MsgInfoList *msglist, GRelation *relation)
 {
        gchar *destdir;
-       GSList *seq_list = NULL, *cur;
+       GSList *numlist = NULL, *cur;
        MsgInfo *msginfo;
        IMAPSession *session;
        gint ok = IMAP_SUCCESS;
@@ -1223,18 +1273,21 @@ static gint imap_do_remove_msgs(Folder *folder, FolderItem *dest,
        if (!session) {
                return -1;
        }
+       lock_session();
        msginfo = (MsgInfo *)msglist->data;
 
        ok = imap_select(session, IMAP_FOLDER(folder), msginfo->folder->path,
                         NULL, NULL, NULL, NULL, FALSE);
        if (ok != IMAP_SUCCESS) {
+               unlock_session();
                return ok;
        }
 
        destdir = imap_get_real_path(IMAP_FOLDER(folder), dest->path);
        for (cur = msglist; cur; cur = cur->next) {
                msginfo = (MsgInfo *)cur->data;
-               seq_list = g_slist_append(seq_list, GINT_TO_POINTER(msginfo->msgnum));
+               if (!MSG_IS_DELETED(msginfo->flags))
+                       numlist = g_slist_append(numlist, GINT_TO_POINTER(msginfo->msgnum));
        }
 
        uid_mapping = g_relation_new(2);
@@ -1242,22 +1295,24 @@ static gint imap_do_remove_msgs(Folder *folder, FolderItem *dest,
 
        ok = imap_set_message_flags
                (IMAP_SESSION(REMOTE_FOLDER(folder)->session),
-               seq_list, IMAP_FLAG_DELETED, TRUE);
+               numlist, IMAP_FLAG_DELETED, TRUE);
        if (ok != IMAP_SUCCESS) {
                log_warning(_("can't set deleted flags\n"));
+               unlock_session();
                return ok;
        }
        ok = imap_cmd_expunge(session);
        if (ok != IMAP_SUCCESS) {
                log_warning(_("can't expunge\n"));
+               unlock_session();
                return ok;
        }
        
        g_relation_destroy(uid_mapping);
-       g_slist_free(seq_list);
+       g_slist_free(numlist);
 
        g_free(destdir);
-
+       unlock_session();
        if (ok == IMAP_SUCCESS)
                return 0;
        else
@@ -1320,12 +1375,13 @@ static gint imap_scan_tree(Folder *folder)
                return -1;
        }
 
+       lock_session();
        if (folder->account->imap_dir && *folder->account->imap_dir) {
                gchar *real_path;
                int r;
                clist * lep_list;
 
-               Xstrdup_a(root_folder, folder->account->imap_dir, {return -1;});
+               Xstrdup_a(root_folder, folder->account->imap_dir, {unlock_session();return -1;});
                extract_quote(root_folder, '"');
                subst_char(root_folder,
                           imap_get_path_separator(IMAP_FOLDER(folder),
@@ -1346,9 +1402,9 @@ static gint imap_scan_tree(Folder *folder)
                                item->folder = folder;
                                folder->node = item->node = g_node_new(item);
                        }
+                       unlock_session();
                        return -1;
                }
-               
                mailimap_list_result_free(lep_list);
                
                g_free(real_path);
@@ -1366,6 +1422,7 @@ static gint imap_scan_tree(Folder *folder)
 
        imap_scan_tree_recursive(session, FOLDER_ITEM(folder->node->data));
        imap_create_missing_folders(folder);
+       unlock_session();
 
        return 0;
 }
@@ -1416,7 +1473,7 @@ static gint imap_scan_tree_recursive(IMAPSession *session, FolderItem *item)
        }
        else {
                item_list = imap_list_from_lep(imapfolder,
-                                              lep_list, real_path);
+                                              lep_list, real_path, FALSE);
                mailimap_list_result_free(lep_list);
        }
        
@@ -1456,6 +1513,7 @@ static gint imap_scan_tree_recursive(IMAPSession *session, FolderItem *item)
        for (cur = item_list; cur != NULL; cur = cur->next) {
                FolderItem *cur_item = FOLDER_ITEM(cur->data);
                new_item = NULL;
+
                for (node = item->node->children; node != NULL;
                     node = node->next) {
                        if (!strcmp2(FOLDER_ITEM(node->data)->path,
@@ -1626,7 +1684,8 @@ static FolderItem *imap_create_folder(Folder *folder, FolderItem *parent,
        gchar *new_name;
        const gchar *p;
        gint ok;
-
+       gboolean no_select = FALSE, no_sub = FALSE;
+       
        g_return_val_if_fail(folder != NULL, NULL);
        g_return_val_if_fail(folder->account != NULL, NULL);
        g_return_val_if_fail(parent != NULL, NULL);
@@ -1637,35 +1696,40 @@ static FolderItem *imap_create_folder(Folder *folder, FolderItem *parent,
                return NULL;
        }
 
-       if (!folder_item_parent(parent) && strcmp(name, "INBOX") == 0)
+       lock_session();
+       if (!folder_item_parent(parent) && strcmp(name, "INBOX") == 0) {
                dirpath = g_strdup(name);
-       else if (parent->path)
+       }else if (parent->path)
                dirpath = g_strconcat(parent->path, "/", name, NULL);
        else if ((p = strchr(name, '/')) != NULL && *(p + 1) != '\0')
                dirpath = g_strdup(name);
        else if (folder->account->imap_dir && *folder->account->imap_dir) {
                gchar *imap_dir;
 
-               Xstrdup_a(imap_dir, folder->account->imap_dir, {return NULL;});
+               Xstrdup_a(imap_dir, folder->account->imap_dir, {unlock_session();return NULL;});
                strtailchomp(imap_dir, '/');
                dirpath = g_strconcat(imap_dir, "/", name, NULL);
        } else
                dirpath = g_strdup(name);
+               
+       
 
        /* keep trailing directory separator to create a folder that contains
           sub folder */
        imap_path = imap_utf8_to_modified_utf7(dirpath);
+
        strtailchomp(dirpath, '/');
        Xstrdup_a(new_name, name, {
-               g_free(dirpath);                
+               g_free(dirpath); 
+               unlock_session();               
                return NULL;});
 
-       strtailchomp(new_name, '/');
        separator = imap_get_path_separator(IMAP_FOLDER(folder), imap_path);
        imap_path_separator_subst(imap_path, separator);
-       subst_char(new_name, '/', separator);
+       /* remove trailing / for display */
+       strtailchomp(new_name, '/');
 
-       if (strcmp(name, "INBOX") != 0) {
+       if (strcmp(dirpath, "INBOX") != 0) {
                GPtrArray *argbuf;
                gboolean exist = FALSE;
                int r;
@@ -1679,24 +1743,58 @@ static FolderItem *imap_create_folder(Folder *folder, FolderItem *parent,
                        g_free(dirpath);
                        ptr_array_free_strings(argbuf);
                        g_ptr_array_free(argbuf, TRUE);
+                       unlock_session();
                        return NULL;
                }
                
                if (clist_count(lep_list) > 0)
                        exist = TRUE;
-               
+               mailimap_list_result_free(lep_list);
+               lep_list = NULL;
                if (!exist) {
                        ok = imap_cmd_create(session, imap_path);
                        if (ok != IMAP_SUCCESS) {
                                log_warning(_("can't create mailbox\n"));
                                g_free(imap_path);
                                g_free(dirpath);
+                               unlock_session();
                                return NULL;
                        }
+                       r = imap_threaded_list(folder, "", imap_path, &lep_list);
+                       if (r == MAILIMAP_NO_ERROR) {
+                               GSList *item_list = imap_list_from_lep(IMAP_FOLDER(folder),
+                                              lep_list, dirpath, TRUE);
+                               if (item_list) {
+                                       FolderItem *cur_item = FOLDER_ITEM(item_list->data);
+                                       no_select = cur_item->no_select;
+                                       no_sub = cur_item->no_sub;
+                                       g_slist_free(item_list);
+                               } 
+                               mailimap_list_result_free(lep_list);
+                       }
+
+               }
+       } else {
+               clist *lep_list;
+               int r;
+               /* just get flags */
+               r = imap_threaded_list(folder, "", "INBOX", &lep_list);
+               if (r == MAILIMAP_NO_ERROR) {
+                       GSList *item_list = imap_list_from_lep(IMAP_FOLDER(folder),
+                                      lep_list, dirpath, TRUE);
+                       if (item_list) {
+                               FolderItem *cur_item = FOLDER_ITEM(item_list->data);
+                               no_select = cur_item->no_select;
+                               no_sub = cur_item->no_sub;
+                               g_slist_free(item_list);
+                       } 
+                       mailimap_list_result_free(lep_list);
                }
        }
 
        new_item = folder_item_new(folder, new_name, dirpath);
+       new_item->no_select = no_select;
+       new_item->no_sub = no_sub;
        folder_item_append(parent, new_item);
        g_free(imap_path);
        g_free(dirpath);
@@ -1705,7 +1803,7 @@ static FolderItem *imap_create_folder(Folder *folder, FolderItem *parent,
        if (!is_dir_exist(dirpath))
                make_dir_hier(dirpath);
        g_free(dirpath);
-
+       unlock_session();
        return new_item;
 }
 
@@ -1740,6 +1838,7 @@ static gint imap_rename_folder(Folder *folder, FolderItem *item,
        if (!session) {
                return -1;
        }
+       lock_session();
        real_oldpath = imap_get_real_path(IMAP_FOLDER(folder), item->path);
 
        g_free(session->mbox);
@@ -1748,6 +1847,7 @@ static gint imap_rename_folder(Folder *folder, FolderItem *item,
                              &exists, &recent, &unseen, &uid_validity, FALSE);
        if (ok != IMAP_SUCCESS) {
                g_free(real_oldpath);
+               unlock_session();
                return -1;
        }
 
@@ -1769,6 +1869,7 @@ static gint imap_rename_folder(Folder *folder, FolderItem *item,
                g_free(real_oldpath);
                g_free(newpath);
                g_free(real_newpath);
+               unlock_session();
                return -1;
        }
 
@@ -1795,7 +1896,7 @@ static gint imap_rename_folder(Folder *folder, FolderItem *item,
        g_free(newpath);
        g_free(real_oldpath);
        g_free(real_newpath);
-
+       unlock_session();
        return 0;
 }
 
@@ -1816,19 +1917,30 @@ static gint imap_remove_folder_real(Folder *folder, FolderItem *item)
        if (!session) {
                return -1;
        }
+       lock_session();
        path = imap_get_real_path(IMAP_FOLDER(folder), item->path);
 
        ok = imap_cmd_examine(session, "INBOX",
                              &exists, &recent, &unseen, &uid_validity, FALSE);
        if (ok != IMAP_SUCCESS) {
                g_free(path);
+               unlock_session();
                return -1;
        }
 
        ok = imap_cmd_delete(session, path);
+       if (ok != IMAP_SUCCESS) {
+               gchar *tmp = g_strdup_printf("%s%c", path, 
+                               imap_get_path_separator(IMAP_FOLDER(folder), path));
+               g_free(path);
+               path = tmp;
+               ok = imap_cmd_delete(session, path);
+       }
+
        if (ok != IMAP_SUCCESS) {
                log_warning(_("can't delete mailbox\n"));
                g_free(path);
+               unlock_session();
                return -1;
        }
 
@@ -1838,7 +1950,7 @@ static gint imap_remove_folder_real(Folder *folder, FolderItem *item)
                g_warning("can't remove directory '%s'\n", cache_dir);
        g_free(cache_dir);
        folder_item_remove(item);
-
+       unlock_session();
        return 0;
 }
 
@@ -1915,6 +2027,8 @@ static void *imap_get_uncached_messages_thread(void *data)
                        
                        info = carray_get(env_list, i);
                        msginfo = imap_envelope_from_lep(info, item);
+                       if (msginfo == NULL)
+                               continue;
                        msginfo->folder = item;
                        if (!newlist)
                                llast = newlist = g_slist_append(newlist, msginfo);
@@ -2160,14 +2274,18 @@ static gint imap_select(IMAPSession *session, IMAPFolder *folder,
        gint exists_, recent_, unseen_;
        guint32 uid_validity_;
        
-       if (!exists || !recent || !unseen || !uid_validity) {
+       if (!exists && !recent && !unseen && !uid_validity) {
                if (session->mbox && strcmp(session->mbox, path) == 0)
                        return IMAP_SUCCESS;
+       }
+       if (!exists)
                exists = &exists_;
+       if (!recent)
                recent = &recent_;
+       if (!unseen)
                unseen = &unseen_;
+       if (!uid_validity)
                uid_validity = &uid_validity_;
-       }
 
        g_free(session->mbox);
        session->mbox = NULL;
@@ -2188,8 +2306,8 @@ static gint imap_select(IMAPSession *session, IMAPFolder *folder,
 }
 
 static gint imap_status(IMAPSession *session, IMAPFolder *folder,
-                       const gchar *path,
-                       gint *messages, gint *recent,
+                       const gchar *path, IMAPFolderItem *item,
+                       gint *messages,
                        guint32 *uid_next, guint32 *uid_validity,
                        gint *unseen, gboolean block)
 {
@@ -2198,10 +2316,64 @@ static gint imap_status(IMAPSession *session, IMAPFolder *folder,
        struct mailimap_mailbox_data_status * data_status;
        int got_values;
        gchar *real_path;
-
+       guint mask = 0;
+       
        real_path = imap_get_real_path(folder, path);
 
-       r = imap_threaded_status(FOLDER(folder), real_path, &data_status);
+#if 0
+       if (time(NULL) - item->last_update >= 5 && item->last_update != 1) {
+               /* do the full stuff */
+               item->last_update = 1; /* force update */
+               debug_print("updating everything\n");
+               r = imap_status(session, folder, path, item,
+               &item->c_messages, &item->c_uid_next,
+               &item->c_uid_validity, &item->c_unseen, block);
+               if (r != MAILIMAP_NO_ERROR) {
+                       debug_print("status err %d\n", r);
+                       return IMAP_ERROR;
+               }
+               item->last_update = time(NULL);
+               if (messages) 
+                       *messages = item->c_messages;
+               if (uid_next)
+                       *uid_next = item->c_uid_next;
+               if (uid_validity)
+                       *uid_validity = item->c_uid_validity;
+               if (unseen)
+                       *unseen = item->c_unseen;
+               return 0;
+       } else if (time(NULL) - item->last_update < 5) {
+               /* return cached stuff */
+               debug_print("using cache\n");
+               if (messages) 
+                       *messages = item->c_messages;
+               if (uid_next)
+                       *uid_next = item->c_uid_next;
+               if (uid_validity)
+                       *uid_validity = item->c_uid_validity;
+               if (unseen)
+                       *unseen = item->c_unseen;
+               return 0;
+       }
+#endif
+
+       /* if we get there, we're updating cache */
+
+       if (messages) {
+               mask |= 1 << 0;
+       }
+       if (uid_next) {
+               mask |= 1 << 2;
+       }
+       if (uid_validity) {
+               mask |= 1 << 3;
+       }
+       if (unseen) {
+               mask |= 1 << 4;
+       }
+       r = imap_threaded_status(FOLDER(folder), real_path, 
+               &data_status, mask);
+
        g_free(real_path);
        if (r != MAILIMAP_NO_ERROR) {
                debug_print("status err %d\n", r);
@@ -2226,11 +2398,6 @@ static gint imap_status(IMAPSession *session, IMAPFolder *folder,
                        got_values |= 1 << 0;
                        break;
                        
-               case MAILIMAP_STATUS_ATT_RECENT:
-                       * recent = info->st_value;
-                       got_values |= 1 << 1;
-                       break;
-                       
                case MAILIMAP_STATUS_ATT_UIDNEXT:
                        * uid_next = info->st_value;
                        got_values |= 1 << 2;
@@ -2249,8 +2416,7 @@ static gint imap_status(IMAPSession *session, IMAPFolder *folder,
        }
        mailimap_mailbox_data_status_free(data_status);
        
-       if (got_values != ((1 << 4) + (1 << 3) +
-                          (1 << 2) + (1 << 1) + (1 << 0))) {
+       if (got_values != mask) {
                debug_print("status: incomplete values received (%d)\n", got_values);
                return IMAP_ERROR;
        }
@@ -2509,10 +2675,8 @@ static gint imap_cmd_append(IMAPSession *session, const gchar *destfolder,
        g_return_val_if_fail(file != NULL, IMAP_ERROR);
 
        flag_list = imap_flag_to_lep(flags);
-       statusbar_print_all(_("Adding messages..."));
        r = imap_threaded_append(session->folder, destfolder,
                         file, flag_list);
-       statusbar_pop_all();
        if (new_uid != NULL)
                *new_uid = 0;
 
@@ -2532,9 +2696,7 @@ static gint imap_cmd_copy(IMAPSession *session, struct mailimap_set * set,
        g_return_val_if_fail(set != NULL, IMAP_ERROR);
        g_return_val_if_fail(destfolder != NULL, IMAP_ERROR);
 
-       statusbar_print_all(_("Copying messages..."));
        r = imap_threaded_copy(session->folder, set, destfolder);
-       statusbar_pop_all();
        if (r != MAILIMAP_NO_ERROR) {
                
                return IMAP_ERROR;
@@ -2812,6 +2974,7 @@ static gboolean imap_rename_folder_func(GNode *node, gpointer data)
 
 typedef struct _get_list_uid_data {
        Folder *folder;
+       IMAPSession *session;
        IMAPFolderItem *item;
        GSList **msgnum_list;
        gboolean done;
@@ -2830,12 +2993,12 @@ static void *get_list_of_uids_thread(void *data)
        clist * lep_uidlist;
        int r;
 
-       session = imap_session_get(folder);
+       session = stuff->session;
        if (session == NULL) {
                stuff->done = TRUE;
                return GINT_TO_POINTER(-1);
        }
-
+       /* no session locking here, it's already locked by caller */
        ok = imap_select(session, IMAP_FOLDER(folder), item->item.path,
                         NULL, NULL, NULL, NULL, TRUE);
        if (ok != IMAP_SUCCESS) {
@@ -2846,6 +3009,7 @@ static void *get_list_of_uids_thread(void *data)
        uidlist = NULL;
        
        set = mailimap_set_new_interval(item->lastuid + 1, 0);
+
        r = imap_threaded_search(folder, IMAP_SEARCH_TYPE_SIMPLE, set,
                                 &lep_uidlist);
        if (r == MAILIMAP_NO_ERROR) {
@@ -2887,12 +3051,11 @@ static void *get_list_of_uids_thread(void *data)
                }
        }
        g_slist_free(uidlist);
-
        stuff->done = TRUE;
        return GINT_TO_POINTER(nummsgs);
 }
 
-static gint get_list_of_uids(Folder *folder, IMAPFolderItem *item, GSList **msgnum_list)
+static gint get_list_of_uids(IMAPSession *session, Folder *folder, IMAPFolderItem *item, GSList **msgnum_list)
 {
        gint result;
        get_list_uid_data *data = g_new0(get_list_uid_data, 1);
@@ -2900,7 +3063,7 @@ static gint get_list_of_uids(Folder *folder, IMAPFolderItem *item, GSList **msgn
        data->folder = folder;
        data->item = item;
        data->msgnum_list = msgnum_list;
-
+       data->session = session;
        if (prefs_common.work_offline && !inc_offline_should_override()) {
                g_free(data);
                return -1;
@@ -2916,7 +3079,7 @@ gint imap_get_num_list(Folder *folder, FolderItem *_item, GSList **msgnum_list,
 {
        IMAPFolderItem *item = (IMAPFolderItem *)_item;
        IMAPSession *session;
-       gint ok, nummsgs = 0, exists, recent, uid_val, uid_next, unseen;
+       gint ok, nummsgs = 0, exists, uid_val, uid_next;
        GSList *uidlist = NULL;
        gchar *dir;
        gboolean selected_folder;
@@ -2931,7 +3094,7 @@ gint imap_get_num_list(Folder *folder, FolderItem *_item, GSList **msgnum_list,
 
        session = imap_session_get(folder);
        g_return_val_if_fail(session != NULL, -1);
-
+       lock_session();
        statusbar_print_all("Scanning %s...\n", FOLDER_ITEM(item)->path 
                                ? FOLDER_ITEM(item)->path:"");
 
@@ -2944,6 +3107,7 @@ gint imap_get_num_list(Folder *folder, FolderItem *_item, GSList **msgnum_list,
                        session = imap_reconnect_if_possible(folder, session);
                        if (session == NULL) {
                                statusbar_pop_all();
+                               unlock_session();
                                return -1;
                        }
                }
@@ -2951,10 +3115,20 @@ gint imap_get_num_list(Folder *folder, FolderItem *_item, GSList **msgnum_list,
 
                *old_uids_valid = TRUE;
        } else {
-               ok = imap_status(session, IMAP_FOLDER(folder), item->item.path,
-                                &exists, &recent, &uid_next, &uid_val, &unseen, FALSE);
+               if (item->use_cache && time(NULL) - item->use_cache < 2) {
+                       exists = item->c_messages;
+                       uid_next = item->c_uid_next;
+                       uid_val = item->c_uid_validity;
+                       ok = IMAP_SUCCESS;
+                       debug_print("using cache %d %d %d\n", exists, uid_next, uid_val);
+               } else {
+                       ok = imap_status(session, IMAP_FOLDER(folder), item->item.path, item,
+                                &exists, &uid_next, &uid_val, NULL, FALSE);
+               }
+               item->use_cache = (time_t)0;
                if (ok != IMAP_SUCCESS) {
                        statusbar_pop_all();
+                       unlock_session();
                        return -1;
                }
                if(item->item.mtime == uid_val)
@@ -2990,6 +3164,7 @@ gint imap_get_num_list(Folder *folder, FolderItem *_item, GSList **msgnum_list,
                if (exists == nummsgs) {
                        *msgnum_list = g_slist_copy(item->uid_list);
                        statusbar_pop_all();
+                       unlock_session();
                        return nummsgs;
                } else if (exists < nummsgs) {
                        debug_print("Freeing imap uid cache");
@@ -3002,13 +3177,15 @@ gint imap_get_num_list(Folder *folder, FolderItem *_item, GSList **msgnum_list,
        if (exists == 0) {
                *msgnum_list = NULL;
                statusbar_pop_all();
+               unlock_session();
                return 0;
        }
 
-       nummsgs = get_list_of_uids(folder, item, &uidlist);
+       nummsgs = get_list_of_uids(session, folder, item, &uidlist);
 
        if (nummsgs < 0) {
                statusbar_pop_all();
+               unlock_session();
                return -1;
        }
 
@@ -3024,7 +3201,7 @@ gint imap_get_num_list(Folder *folder, FolderItem *_item, GSList **msgnum_list,
 
                g_slist_free(*msgnum_list);
 
-               nummsgs = get_list_of_uids(folder, item, &uidlist);
+               nummsgs = get_list_of_uids(session, folder, item, &uidlist);
        }
 
        *msgnum_list = uidlist;
@@ -3036,6 +3213,7 @@ gint imap_get_num_list(Folder *folder, FolderItem *_item, GSList **msgnum_list,
        
        debug_print("get_num_list - ok - %i\n", nummsgs);
        statusbar_pop_all();
+       unlock_session();
        return nummsgs;
 }
 
@@ -3080,13 +3258,14 @@ GSList *imap_get_msginfos(Folder *folder, FolderItem *item,
 
        session = imap_session_get(folder);
        g_return_val_if_fail(session != NULL, NULL);
-
+       lock_session();
        debug_print("IMAP getting msginfos\n");
        ok = imap_select(session, IMAP_FOLDER(folder), item->path,
                         NULL, NULL, NULL, NULL, FALSE);
-       if (ok != IMAP_SUCCESS)
+       if (ok != IMAP_SUCCESS) {
+               unlock_session();
                return NULL;
-
+       }
        if (!(folder_has_parent_of_type(item, F_DRAFT) || 
              folder_has_parent_of_type(item, F_QUEUE))) {
                ret = g_slist_concat(ret,
@@ -3132,7 +3311,7 @@ GSList *imap_get_msginfos(Folder *folder, FolderItem *item,
 
                g_slist_free(sorted_list);
        }
-
+       unlock_session();
        return ret;
 }
 
@@ -3158,8 +3337,8 @@ gboolean imap_scan_required(Folder *folder, FolderItem *_item)
 {
        IMAPSession *session;
        IMAPFolderItem *item = (IMAPFolderItem *)_item;
-       gint ok, exists = 0, recent = 0, unseen = 0;
-       guint32 uid_next, uid_val = 0;
+       gint ok, exists = 0, unseen = 0;
+       guint32 uid_next, uid_val;
        gboolean selected_folder;
        
        g_return_val_if_fail(folder != NULL, FALSE);
@@ -3172,7 +3351,7 @@ gboolean imap_scan_required(Folder *folder, FolderItem *_item)
 
        session = imap_session_get(folder);
        g_return_val_if_fail(session != NULL, FALSE);
-
+       lock_session();
        selected_folder = (session->mbox != NULL) &&
                          (!strcmp(session->mbox, item->item.path));
        if (selected_folder) {
@@ -3182,21 +3361,34 @@ gboolean imap_scan_required(Folder *folder, FolderItem *_item)
                        session = imap_reconnect_if_possible(folder, session);
                        if (session == NULL)
                                return FALSE;
+                       lock_session();
                }
 
                if (session->folder_content_changed
-               ||  session->exists != item->item.total_msgs)
+               ||  session->exists != item->item.total_msgs) {
+                       unlock_session();
                        return TRUE;
+               }
        } else {
-               ok = imap_status(session, IMAP_FOLDER(folder), item->item.path,
-                                &exists, &recent, &uid_next, &uid_val, &unseen, FALSE);
-               if (ok != IMAP_SUCCESS)
+               ok = imap_status(session, IMAP_FOLDER(folder), item->item.path, IMAP_FOLDER_ITEM(item),
+                                &exists, &uid_next, &uid_val, &unseen, FALSE);
+               if (ok != IMAP_SUCCESS) {
+                       unlock_session();
                        return FALSE;
+               }
 
-               if ((uid_next != item->uid_next) || (exists != item->item.total_msgs))
+               item->use_cache = time(NULL);
+               item->c_messages = exists;
+               item->c_uid_next = uid_next;
+               item->c_uid_validity = uid_val;
+               item->c_unseen = unseen;
+
+               if ((uid_next != item->uid_next) || (exists != item->item.total_msgs)) {
+                       unlock_session();
                        return TRUE;
+               }
        }
-
+       unlock_session();
        return FALSE;
 }
 
@@ -3219,8 +3411,10 @@ void imap_change_flags(Folder *folder, FolderItem *item, MsgInfo *msginfo, MsgPe
        if (!session) {
                return;
        }
+       lock_session();
        if ((ok = imap_select(session, IMAP_FOLDER(folder), msginfo->folder->path,
            NULL, NULL, NULL, NULL, FALSE)) != IMAP_SUCCESS) {
+               unlock_session();
                return;
        }
 
@@ -3255,30 +3449,38 @@ void imap_change_flags(Folder *folder, FolderItem *item, MsgInfo *msginfo, MsgPe
                 */
                debug_print("IMAP batch mode on, deferring flags change\n");
                if (flags_set) {
-                       ht_data = g_hash_table_lookup(flags_set_table, GINT_TO_POINTER(flags_set));
+                       ht_data = g_hash_table_lookup(IMAP_FOLDER_ITEM(item)->flags_set_table, 
+                               GINT_TO_POINTER(flags_set));
                        if (ht_data == NULL) {
                                ht_data = g_new0(hashtable_data, 1);
                                ht_data->session = session;
-                               g_hash_table_insert(flags_set_table, GINT_TO_POINTER(flags_set), ht_data);
+                               ht_data->item = IMAP_FOLDER_ITEM(item);
+                               g_hash_table_insert(IMAP_FOLDER_ITEM(item)->flags_set_table, 
+                                       GINT_TO_POINTER(flags_set), ht_data);
                        }
                        if (!g_slist_find(ht_data->msglist, GINT_TO_POINTER(msginfo->msgnum)))
                                ht_data->msglist = g_slist_prepend(ht_data->msglist, GINT_TO_POINTER(msginfo->msgnum));
                } 
                if (flags_unset) {
-                       ht_data = g_hash_table_lookup(flags_unset_table, GINT_TO_POINTER(flags_unset));
+                       ht_data = g_hash_table_lookup(IMAP_FOLDER_ITEM(item)->flags_unset_table, 
+                               GINT_TO_POINTER(flags_unset));
                        if (ht_data == NULL) {
                                ht_data = g_new0(hashtable_data, 1);
                                ht_data->session = session;
-                               g_hash_table_insert(flags_unset_table, GINT_TO_POINTER(flags_unset), ht_data);
+                               ht_data->item = IMAP_FOLDER_ITEM(item);
+                               g_hash_table_insert(IMAP_FOLDER_ITEM(item)->flags_unset_table, 
+                                       GINT_TO_POINTER(flags_unset), ht_data);
                        }
                        if (!g_slist_find(ht_data->msglist, GINT_TO_POINTER(msginfo->msgnum)))
-                               ht_data->msglist = g_slist_prepend(ht_data->msglist, GINT_TO_POINTER(msginfo->msgnum));         
+                               ht_data->msglist = g_slist_prepend(ht_data->msglist, 
+                                       GINT_TO_POINTER(msginfo->msgnum));              
                }
        } else {
                debug_print("IMAP changing flags\n");
                if (flags_set) {
                        ok = imap_set_message_flags(session, &numlist, flags_set, TRUE);
                        if (ok != IMAP_SUCCESS) {
+                               unlock_session();
                                return;
                        }
                }
@@ -3286,12 +3488,13 @@ void imap_change_flags(Folder *folder, FolderItem *item, MsgInfo *msginfo, MsgPe
                if (flags_unset) {
                        ok = imap_set_message_flags(session, &numlist, flags_unset, FALSE);
                        if (ok != IMAP_SUCCESS) {
+                               unlock_session();
                                return;
                        }
                }
        }
        msginfo->flags.perm_flags = newflags;
-       
+       unlock_session();
        return;
 }
 
@@ -3308,12 +3511,13 @@ static gint imap_remove_msg(Folder *folder, FolderItem *item, gint uid)
 
        session = imap_session_get(folder);
        if (!session) return -1;
-
+       lock_session();
        ok = imap_select(session, IMAP_FOLDER(folder), item->path,
                         NULL, NULL, NULL, NULL, FALSE);
-       if (ok != IMAP_SUCCESS)
+       if (ok != IMAP_SUCCESS) {
+               unlock_session();
                return ok;
-
+       }
        numlist.next = NULL;
        numlist.data = GINT_TO_POINTER(uid);
        
@@ -3322,6 +3526,7 @@ static gint imap_remove_msg(Folder *folder, FolderItem *item, gint uid)
                &numlist, IMAP_FLAG_DELETED, TRUE);
        if (ok != IMAP_SUCCESS) {
                log_warning(_("can't set deleted flags: %d\n"), uid);
+               unlock_session();
                return ok;
        }
 
@@ -3336,6 +3541,7 @@ static gint imap_remove_msg(Folder *folder, FolderItem *item, gint uid)
        }
        if (ok != IMAP_SUCCESS) {
                log_warning(_("can't expunge\n"));
+               unlock_session();
                return ok;
        }
 
@@ -3345,7 +3551,7 @@ static gint imap_remove_msg(Folder *folder, FolderItem *item, gint uid)
        if (is_dir_exist(dir))
                remove_numbered_files(dir, uid, uid);
        g_free(dir);
-
+       unlock_session();
        return IMAP_SUCCESS;
 }
 
@@ -3381,6 +3587,7 @@ typedef struct _get_flags_data {
        FolderItem *item;
        MsgInfoList *msginfo_list;
        GRelation *msgflags;
+       gboolean full_search;
        gboolean done;
 } get_flags_data;
 
@@ -3391,8 +3598,9 @@ static /*gint*/ void *imap_get_flags_thread(void *data)
        FolderItem *item = stuff->item;
        MsgInfoList *msginfo_list = stuff->msginfo_list;
        GRelation *msgflags = stuff->msgflags;
+       gboolean full_search = stuff->full_search;
        IMAPSession *session;
-       GSList *sorted_list;
+       GSList *sorted_list = NULL;
        GSList *unseen = NULL, *answered = NULL, *flagged = NULL, *deleted = NULL;
        GSList *p_unseen, *p_answered, *p_flagged, *p_deleted;
        GSList *elem;
@@ -3400,35 +3608,29 @@ static /*gint*/ void *imap_get_flags_thread(void *data)
        gboolean reverse_seen = FALSE;
        GString *cmd_buf;
        gint ok;
-       gint exists_cnt, recent_cnt, unseen_cnt, uid_next;
-       guint32 uidvalidity;
+       gint exists_cnt, unseen_cnt;
        gboolean selected_folder;
        
        if (folder == NULL || item == NULL) {
                stuff->done = TRUE;
                return GINT_TO_POINTER(-1);
        }
-       if (msginfo_list == NULL) {
-               stuff->done = TRUE;
-               return GINT_TO_POINTER(0);
-       }
 
        session = imap_session_get(folder);
        if (session == NULL) {
                stuff->done = TRUE;
                return GINT_TO_POINTER(-1);
        }
-
+       lock_session();
        selected_folder = (session->mbox != NULL) &&
                          (!strcmp(session->mbox, item->path));
 
        if (!selected_folder) {
-               ok = imap_status(session, IMAP_FOLDER(folder), item->path,
-                        &exists_cnt, &recent_cnt, &uid_next, &uidvalidity, &unseen_cnt, TRUE);
                ok = imap_select(session, IMAP_FOLDER(folder), item->path,
-                       NULL, NULL, NULL, NULL, TRUE);
+                       &exists_cnt, NULL, &unseen_cnt, NULL, TRUE);
                if (ok != IMAP_SUCCESS) {
                        stuff->done = TRUE;
+                       unlock_session();
                        return GINT_TO_POINTER(-1);
                }
 
@@ -3443,8 +3645,13 @@ static /*gint*/ void *imap_get_flags_thread(void *data)
        cmd_buf = g_string_new(NULL);
 
        sorted_list = g_slist_sort(g_slist_copy(msginfo_list), compare_msginfo);
-
-       seq_list = imap_get_lep_set_from_msglist(msginfo_list);
+       if (!full_search) {
+               seq_list = imap_get_lep_set_from_msglist(msginfo_list);
+       } else {
+               struct mailimap_set * set;
+               set = mailimap_set_new_interval(1, 0);
+               seq_list = g_slist_append(NULL, set);
+       }
 
        for (cur = seq_list; cur != NULL; cur = g_slist_next(cur)) {
                struct mailimap_set * imapset;
@@ -3551,6 +3758,7 @@ static /*gint*/ void *imap_get_flags_thread(void *data)
        g_string_free(cmd_buf, TRUE);
 
        stuff->done = TRUE;
+       unlock_session();
        return GINT_TO_POINTER(0);
 }
 
@@ -3564,12 +3772,25 @@ static gint imap_get_flags(Folder *folder, FolderItem *item,
        data->item = item;
        data->msginfo_list = msginfo_list;
        data->msgflags = msgflags;
+       data->full_search = FALSE;
 
+       GSList *tmp = NULL, *cur;
+       
        if (prefs_common.work_offline && !inc_offline_should_override()) {
                g_free(data);
                return -1;
        }
 
+       tmp = folder_item_get_msg_list(item);
+
+       if (g_slist_length(tmp) == g_slist_length(msginfo_list))
+               data->full_search = TRUE;
+       
+       for (cur = tmp; cur; cur = cur->next)
+               procmsg_msginfo_free((MsgInfo *)cur->data);
+       
+       g_slist_free(tmp);
+
        result = GPOINTER_TO_INT(imap_get_flags_thread(data));
        
        g_free(data);
@@ -3582,70 +3803,72 @@ static gboolean process_flags(gpointer key, gpointer value, gpointer user_data)
        gboolean flags_set = GPOINTER_TO_INT(user_data);
        gint flags_value = GPOINTER_TO_INT(key);
        hashtable_data *data = (hashtable_data *)value;
-       
+       IMAPFolderItem *_item = data->item;
+       FolderItem *item = (FolderItem *)_item;
+       gint ok = IMAP_ERROR;
+       IMAPSession *session = imap_session_get(item->folder);
+
        data->msglist = g_slist_reverse(data->msglist);
        
        debug_print("IMAP %ssetting flags to %d for %d messages\n",
                flags_set?"":"un",
                flags_value,
                g_slist_length(data->msglist));
-       imap_set_message_flags(data->session, data->msglist, flags_value, flags_set);
        
+       if (session) {
+               lock_session();
+               ok = imap_select(session, IMAP_FOLDER(item->folder), item->path,
+                        NULL, NULL, NULL, NULL, FALSE);
+       }
+       if (ok == IMAP_SUCCESS) {
+               imap_set_message_flags(data->session, data->msglist, flags_value, flags_set);
+       } else {
+               g_warning("can't select mailbox %s\n", item->path);
+       }
+       if (session)
+               unlock_session();
        g_slist_free(data->msglist);    
        g_free(data);
        return TRUE;
 }
 
-static void process_hashtable(void)
+static void process_hashtable(IMAPFolderItem *item)
 {
-       if (flags_set_table) {
-               g_hash_table_foreach_remove(flags_set_table, process_flags, GINT_TO_POINTER(TRUE));
-               g_free(flags_set_table);
-               flags_set_table = NULL;
+       if (item->flags_set_table) {
+               g_hash_table_foreach_remove(item->flags_set_table, process_flags, GINT_TO_POINTER(TRUE));
+               g_free(item->flags_set_table);
+               item->flags_set_table = NULL;
        }
-       if (flags_unset_table) {
-               g_hash_table_foreach_remove(flags_unset_table, process_flags, GINT_TO_POINTER(FALSE));
-               g_free(flags_unset_table);
-               flags_unset_table = NULL;
+       if (item->flags_unset_table) {
+               g_hash_table_foreach_remove(item->flags_unset_table, process_flags, GINT_TO_POINTER(FALSE));
+               g_free(item->flags_unset_table);
+               item->flags_unset_table = NULL;
        }
 }
 
-static IMAPFolderItem *batching_item = NULL;
-
 static void imap_set_batch (Folder *folder, FolderItem *_item, gboolean batch)
 {
        IMAPFolderItem *item = (IMAPFolderItem *)_item;
 
        g_return_if_fail(item != NULL);
        
-       if (batch && batching_item != NULL) {
-               g_warning("already batching on %s\n", batching_item->item.path);
-               return;
-       }
-       
        if (item->batching == batch)
                return;
        
-       item->batching = batch;
-       
-       batching_item = batch?item:NULL;
-       
        if (batch) {
+               item->batching = TRUE;
                debug_print("IMAP switching to batch mode\n");
-               if (flags_set_table) {
-                       g_warning("flags_set_table non-null but we just entered batch mode!\n");
-                       flags_set_table = NULL;
+               if (!item->flags_set_table) {
+                       item->flags_set_table = g_hash_table_new(NULL, g_direct_equal);
                }
-               if (flags_unset_table) {
-                       g_warning("flags_unset_table non-null but we just entered batch mode!\n");
-                       flags_unset_table = NULL;
+               if (!item->flags_unset_table) {
+                       item->flags_unset_table = g_hash_table_new(NULL, g_direct_equal);
                }
-               flags_set_table = g_hash_table_new(NULL, g_direct_equal);
-               flags_unset_table = g_hash_table_new(NULL, g_direct_equal);
        } else {
                debug_print("IMAP switching away from batch mode\n");
                /* process stuff */
-               process_hashtable();
+               process_hashtable(item);
+               item->batching = FALSE;
        }
 }
 
@@ -3697,7 +3920,7 @@ static int imap_flags_to_flags(struct mailimap_mbx_list_flags * imap_flags)
 }
 
 static GSList * imap_list_from_lep(IMAPFolder * folder,
-                                  clist * list, const gchar * real_path)
+                                  clist * list, const gchar * real_path, gboolean all)
 {
        clistiter * iter;
        GSList * item_list;
@@ -3717,7 +3940,10 @@ static GSList * imap_list_from_lep(IMAPFolder * folder,
                FolderItem *new_item;
                
                mb = clist_content(iter);
-               
+
+               if (mb == NULL)
+                       continue;
+
                flags = 0;
                if (mb->mb_flag != NULL)
                        flags = imap_flags_to_flags(mb->mb_flag);
@@ -3736,13 +3962,13 @@ static GSList * imap_list_from_lep(IMAPFolder * folder,
                        continue;
                }
                
-               if (strcmp(dup_name, real_path) == 0) {
+               if (!all && strcmp(dup_name, real_path) == 0) {
                        g_free(base);
                        free(dup_name);
                        continue;
                }
 
-               if (dup_name[strlen(dup_name)-1] == '/') {
+               if (!all && dup_name[strlen(dup_name)-1] == '/') {
                        g_free(base);
                        free(dup_name);
                        continue;
@@ -3797,7 +4023,7 @@ static GSList * imap_get_lep_set_from_numlist(MsgNumberList *numlist)
                        continue;
                
                item_count ++;
-               
+
                last = GPOINTER_TO_INT(cur->data);
                if (cur->next)
                        next = GPOINTER_TO_INT(cur->next->data);
@@ -3893,6 +4119,9 @@ static MsgInfo *imap_envelope_from_lep(struct imap_fetch_env_info * info,
        size_t size = 0;
        MsgFlags flags = {0, 0};
        
+       if (info->headers == NULL)
+               return NULL;
+
        MSG_SET_TMP_FLAGS(flags, MSG_IMAP);
        if (folder_has_parent_of_type(item, F_QUEUE)) {
                MSG_SET_TMP_FLAGS(flags, MSG_QUEUED);