2012-08-09 [colin] 3.8.1cvs27
[claws.git] / src / gtk / sslcertwindow.c
index ea0b4c97e6650dce585b40e21125285dad5c5740..f064765290bda412f13b3ac198806e133bf3b9a7 100644 (file)
@@ -1,6 +1,6 @@
 /*
  * Claws Mail -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2007 Colin Leroy <colin@colino.net> 
+ * Copyright (C) 1999-2012 Colin Leroy <colin@colino.net> 
  * and the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
 
 #ifdef HAVE_CONFIG_H
 #  include "config.h"
+#include "claws-features.h"
 #endif
 
-#if (defined(USE_OPENSSL) || defined (USE_GNUTLS))
+#ifdef USE_GNUTLS
 
-#if USE_OPENSSL
-#include <openssl/ssl.h>
-#else
 #include <gnutls/gnutls.h>
 #include <gnutls/x509.h>
 #include <sys/types.h>
@@ -34,7 +32,7 @@
 #include <stdio.h>
 #include <unistd.h>
 #include <string.h>
-#endif
+
 #include <glib.h>
 #include <glib/gi18n.h>
 #include <gtk/gtk.h>
@@ -66,72 +64,14 @@ static GtkWidget *cert_presenter(SSLCertificate *cert)
        char *subject_commonname, *subject_location, *subject_organization;
        char *sig_status, *exp_date;
        char *md5_fingerprint, *sha1_fingerprint, *fingerprint;
-       unsigned int n;
+       size_t n;
        char buf[100];
        unsigned char md[128];  
-#if USE_OPENSSL
-       ASN1_TIME *validity;
-#else
        char *tmp;
-#endif
        time_t exp_time_t;
        struct tm lt;
 
        /* issuer */    
-#if USE_OPENSSL
-       if (X509_NAME_get_text_by_NID(X509_get_issuer_name(cert->x509_cert), 
-                                      NID_commonName, buf, 100) >= 0)
-               issuer_commonname = g_strdup(buf);
-       else
-               issuer_commonname = g_strdup(_("<not in certificate>"));
-       if (X509_NAME_get_text_by_NID(X509_get_issuer_name(cert->x509_cert), 
-                                      NID_localityName, buf, 100) >= 0) {
-               issuer_location = g_strdup(buf);
-               if (X509_NAME_get_text_by_NID(X509_get_issuer_name(cert->x509_cert), 
-                                      NID_countryName, buf, 100) >= 0)
-                       issuer_location = g_strconcat(issuer_location,", ",buf, NULL);
-       } else if (X509_NAME_get_text_by_NID(X509_get_issuer_name(cert->x509_cert), 
-                                      NID_countryName, buf, 100) >= 0)
-               issuer_location = g_strdup(buf);
-       else
-               issuer_location = g_strdup(_("<not in certificate>"));
-
-       if (X509_NAME_get_text_by_NID(X509_get_issuer_name(cert->x509_cert), 
-                                      NID_organizationName, buf, 100) >= 0)
-               issuer_organization = g_strdup(buf);
-       else 
-               issuer_organization = g_strdup(_("<not in certificate>"));
-        
-       /* subject */   
-       if (X509_NAME_get_text_by_NID(X509_get_subject_name(cert->x509_cert), 
-                                      NID_commonName, buf, 100) >= 0)
-               subject_commonname = g_strdup(buf);
-       else
-               subject_commonname = g_strdup(_("<not in certificate>"));
-       if (X509_NAME_get_text_by_NID(X509_get_subject_name(cert->x509_cert), 
-                                      NID_localityName, buf, 100) >= 0) {
-               subject_location = g_strdup(buf);
-               if (X509_NAME_get_text_by_NID(X509_get_subject_name(cert->x509_cert), 
-                                      NID_countryName, buf, 100) >= 0)
-                       subject_location = g_strconcat(subject_location,", ",buf, NULL);
-       } else if (X509_NAME_get_text_by_NID(X509_get_subject_name(cert->x509_cert), 
-                                      NID_countryName, buf, 100) >= 0)
-               subject_location = g_strdup(buf);
-       else
-               subject_location = g_strdup(_("<not in certificate>"));
-
-       if (X509_NAME_get_text_by_NID(X509_get_subject_name(cert->x509_cert), 
-                                      NID_organizationName, buf, 100) >= 0)
-               subject_organization = g_strdup(buf);
-       else 
-               subject_organization = g_strdup(_("<not in certificate>"));
-        
-       if ((validity = X509_get_notAfter(cert->x509_cert)) != NULL) {
-               exp_time_t = asn1toTime(validity);
-       } else {
-               exp_time_t = (time_t)0;
-       }
-#else
        issuer_commonname = g_malloc(BUFFSIZE);
        issuer_location = g_malloc(BUFFSIZE);
        issuer_organization = g_malloc(BUFFSIZE);
@@ -155,8 +95,8 @@ static GtkWidget *cert_presenter(SSLCertificate *cert)
                tmp = g_malloc(BUFFSIZE);
                if (gnutls_x509_crt_get_issuer_dn_by_oid(cert->x509_cert, 
                        GNUTLS_OID_X520_COUNTRY_NAME, 0, 0, tmp, &n) == 0) {
-                       strncat(issuer_location, ", ", BUFFSIZE-strlen(issuer_location));
-                       strncat(issuer_location, tmp, BUFFSIZE-strlen(issuer_location));
+                       strncat(issuer_location, ", ", BUFFSIZE-strlen(issuer_location)-1);
+                       strncat(issuer_location, tmp, BUFFSIZE-strlen(issuer_location)-1);
                }
                g_free(tmp);
        }
@@ -182,8 +122,8 @@ static GtkWidget *cert_presenter(SSLCertificate *cert)
                tmp = g_malloc(BUFFSIZE);
                if (gnutls_x509_crt_get_dn_by_oid(cert->x509_cert, 
                        GNUTLS_OID_X520_COUNTRY_NAME, 0, 0, tmp, &n) == 0) {
-                       strncat(subject_location, ", ", BUFFSIZE-strlen(subject_location));
-                       strncat(subject_location, tmp, BUFFSIZE-strlen(subject_location));
+                       strncat(subject_location, ", ", BUFFSIZE-strlen(subject_location)-1);
+                       strncat(subject_location, tmp, BUFFSIZE-strlen(subject_location)-1);
                }
                g_free(tmp);
        }
@@ -194,22 +134,15 @@ static GtkWidget *cert_presenter(SSLCertificate *cert)
                strncpy(subject_organization, _("<not in certificate>"), BUFFSIZE);
                
        exp_time_t = gnutls_x509_crt_get_expiration_time(cert->x509_cert);
-#endif 
 
        memset(buf, 0, sizeof(buf));
-       strftime(buf, sizeof(buf)-1, prefs_common.date_format, localtime_r(&exp_time_t, &lt));
-       exp_date = (*buf) ? g_strdup(buf):g_strdup("?");
+       if (exp_time_t > 0) {
+               fast_strftime(buf, sizeof(buf)-1, prefs_common.date_format, localtime_r(&exp_time_t, &lt));
+               exp_date = (*buf) ? g_strdup(buf):g_strdup("?");
+       } else
+               exp_date = g_strdup("");
 
        /* fingerprint */
-#if USE_OPENSSL
-       X509_digest(cert->x509_cert, EVP_md5(), md, &n);
-       md5_fingerprint = readable_fingerprint(md, (int)n);
-       X509_digest(cert->x509_cert, EVP_sha1(), md, &n);
-       sha1_fingerprint = readable_fingerprint(md, (int)n);
-
-       /* signature */
-       sig_status = ssl_certificate_check_signer(cert->x509_cert);
-#else
        n = 128;
        gnutls_x509_crt_get_fingerprint(cert->x509_cert, GNUTLS_DIG_MD5, md, &n);
        md5_fingerprint = readable_fingerprint(md, (int)n);
@@ -219,10 +152,9 @@ static GtkWidget *cert_presenter(SSLCertificate *cert)
 
        /* signature */
        sig_status = ssl_certificate_check_signer(cert->x509_cert, cert->status);
-#endif
 
        if (sig_status==NULL)
-               sig_status = g_strdup(_("correct"));
+               sig_status = g_strdup(_("Correct"));
 
        vbox = gtk_vbox_new(FALSE, 5);
        hbox = gtk_hbox_new(FALSE, 5);
@@ -336,12 +268,15 @@ static gboolean sslcert_ask_hook(gpointer source, gpointer data)
 {
        SSLCertHookData *hookdata = (SSLCertHookData *)source;
 
-       if (prefs_common.skip_ssl_cert_check)
-               return TRUE;
-
        if (hookdata == NULL) {
                return FALSE;
        }
+       
+       if (prefs_common.skip_ssl_cert_check) {
+               hookdata->accept = TRUE;
+               return TRUE;
+       }
+
        if (hookdata->old_cert == NULL) {
                if (hookdata->expired)
                        hookdata->accept = sslcertwindow_ask_expired_cert(hookdata->cert);
@@ -350,6 +285,7 @@ static gboolean sslcert_ask_hook(gpointer source, gpointer data)
        } else {
                hookdata->accept = sslcertwindow_ask_changed_cert(hookdata->old_cert, hookdata->cert);
        }
+
        return TRUE;
 }
 
@@ -369,6 +305,24 @@ void sslcertwindow_show_cert(SSLCertificate *cert)
        g_free(buf);
 }
 
+static gchar *sslcertwindow_get_invalid_str(SSLCertificate *cert)
+{
+       gchar *subject_cn = NULL;
+       gchar *str = NULL;
+
+       if (ssl_certificate_check_subject_cn(cert))
+               return g_strdup("");
+       
+       subject_cn = ssl_certificate_get_subject_cn(cert);
+       
+       str = g_strdup_printf(_("Certificate is for %s, but connection is to %s.\n"
+                               "You may be connecting to a rogue server.\n\n"), 
+                               subject_cn, cert->host);
+       g_free(subject_cn);
+       
+       return str;
+}
+
 static gboolean sslcertwindow_ask_new_cert(SSLCertificate *cert)
 {
        gchar *buf, *sig_status;
@@ -377,21 +331,21 @@ static gboolean sslcertwindow_ask_new_cert(SSLCertificate *cert)
        GtkWidget *label;
        GtkWidget *button;
        GtkWidget *cert_widget;
-       
+       gchar *invalid_str = sslcertwindow_get_invalid_str(cert);
+       const gchar *title;
+
        vbox = gtk_vbox_new(FALSE, 5);
-       buf = g_strdup_printf(_("Certificate for %s is unknown.\nDo you want to accept it?"), cert->host);
+       buf = g_strdup_printf(_("Certificate for %s is unknown.\n%sDo you want to accept it?"), cert->host, invalid_str);
+       g_free(invalid_str);
+
        label = gtk_label_new(buf);
        gtk_misc_set_alignment (GTK_MISC (label), 0, 0.5);
        gtk_box_pack_start(GTK_BOX(vbox), label, TRUE, TRUE, 0);
        g_free(buf);
        
-#if USE_OPENSSL
-       sig_status = ssl_certificate_check_signer(cert->x509_cert);
-#else
        sig_status = ssl_certificate_check_signer(cert->x509_cert, cert->status);
-#endif
        if (sig_status==NULL)
-               sig_status = g_strdup(_("correct"));
+               sig_status = g_strdup(_("Correct"));
 
        buf = g_strdup_printf(_("Signature status: %s"), sig_status);
        label = gtk_label_new(buf);
@@ -406,7 +360,12 @@ static gboolean sslcertwindow_ask_new_cert(SSLCertificate *cert)
        cert_widget = cert_presenter(cert);
        gtk_container_add(GTK_CONTAINER(button), cert_widget);
 
-       val = alertpanel_full(_("Unknown SSL Certificate"), NULL,
+       if (!ssl_certificate_check_subject_cn(cert))
+               title = _("SSL certificate is invalid");
+       else
+               title = _("SSL Certificate is unknown");
+
+       val = alertpanel_full(title, NULL,
                              _("_Cancel connection"), _("_Accept and save"), NULL,
                              FALSE, vbox, ALERT_QUESTION, G_ALERTDEFAULT);
        
@@ -421,22 +380,22 @@ static gboolean sslcertwindow_ask_expired_cert(SSLCertificate *cert)
        GtkWidget *label;
        GtkWidget *button;
        GtkWidget *cert_widget;
-       
+       gchar *invalid_str = sslcertwindow_get_invalid_str(cert);
+       const gchar *title;
+
        vbox = gtk_vbox_new(FALSE, 5);
-       buf = g_strdup_printf(_("Certificate for %s is expired.\nDo you want to continue?"), cert->host);
+       buf = g_strdup_printf(_("Certificate for %s is expired.\n%sDo you want to continue?"), cert->host, invalid_str);
+       g_free(invalid_str);
+
        label = gtk_label_new(buf);
        gtk_misc_set_alignment (GTK_MISC (label), 0, 0.5);
        gtk_box_pack_start(GTK_BOX(vbox), label, TRUE, TRUE, 0);
        g_free(buf);
        
-#if USE_OPENSSL
-       sig_status = ssl_certificate_check_signer(cert->x509_cert);
-#else
        sig_status = ssl_certificate_check_signer(cert->x509_cert, cert->status);
-#endif
 
        if (sig_status==NULL)
-               sig_status = g_strdup(_("correct"));
+               sig_status = g_strdup(_("Correct"));
 
        buf = g_strdup_printf(_("Signature status: %s"), sig_status);
        label = gtk_label_new(buf);
@@ -451,7 +410,12 @@ static gboolean sslcertwindow_ask_expired_cert(SSLCertificate *cert)
        cert_widget = cert_presenter(cert);
        gtk_container_add(GTK_CONTAINER(button), cert_widget);
 
-       val = alertpanel_full(_("Expired SSL Certificate"), NULL,
+       if (!ssl_certificate_check_subject_cn(cert))
+               title = _("SSL certificate is invalid and expired");
+       else
+               title = _("SSL certificate is expired");
+
+       val = alertpanel_full(title, NULL,
                              _("_Cancel connection"), _("_Accept"), NULL,
                              FALSE, vbox, ALERT_QUESTION, G_ALERTDEFAULT);
        
@@ -468,7 +432,9 @@ static gboolean sslcertwindow_ask_changed_cert(SSLCertificate *old_cert, SSLCert
        GtkWidget *label;
        GtkWidget *button;
        AlertValue val;
-       
+       gchar *invalid_str = sslcertwindow_get_invalid_str(new_cert);
+       const gchar *title;
+
        vbox = gtk_vbox_new(FALSE, 5);
        label = gtk_label_new(_("New certificate:"));
        gtk_misc_set_alignment (GTK_MISC (label), 0, 0.5);
@@ -482,20 +448,18 @@ static gboolean sslcertwindow_ask_changed_cert(SSLCertificate *old_cert, SSLCert
        gtk_widget_show_all(vbox);
        
        vbox2 = gtk_vbox_new(FALSE, 5);
-       buf = g_strdup_printf(_("Certificate for %s has changed. Do you want to accept it?"), new_cert->host);
+       buf = g_strdup_printf(_("Certificate for %s has changed.\n%sDo you want to accept it?"), new_cert->host, invalid_str);
+       g_free(invalid_str);
+
        label = gtk_label_new(buf);
        gtk_misc_set_alignment (GTK_MISC (label), 0, 0.5);
        gtk_box_pack_start(GTK_BOX(vbox2), label, TRUE, TRUE, 0);
        g_free(buf);
        
-#if USE_OPENSSL
-       sig_status = ssl_certificate_check_signer(new_cert->x509_cert);
-#else
        sig_status = ssl_certificate_check_signer(new_cert->x509_cert, new_cert->status);
-#endif
 
        if (sig_status==NULL)
-               sig_status = g_strdup(_("correct"));
+               sig_status = g_strdup(_("Correct"));
 
        buf = g_strdup_printf(_("Signature status: %s"), sig_status);
        label = gtk_label_new(buf);
@@ -509,7 +473,11 @@ static gboolean sslcertwindow_ask_changed_cert(SSLCertificate *old_cert, SSLCert
        gtk_box_pack_start(GTK_BOX(vbox2), button, FALSE, FALSE, 0);
        gtk_container_add(GTK_CONTAINER(button), vbox);
 
-       val = alertpanel_full(_("Changed SSL Certificate"), NULL,
+       if (!ssl_certificate_check_subject_cn(new_cert))
+               title = _("SSL certificate changed and is invalid");
+       else
+               title = _("SSL certificate changed");
+       val = alertpanel_full(title, NULL,
                              _("_Cancel connection"), _("_Accept and save"), NULL,
                              FALSE, vbox2, ALERT_WARNING, G_ALERTDEFAULT);