fix bug 4239, 'Preferences: Text Options Header Display modal is not modal' (sic)
[claws.git] / src / gtk / about.c
index d95f50a351f21fe207c15b65130499c4bf566051..b613d2c1e3ae6b464abf5790178413125ec87b7d 100644 (file)
@@ -1,6 +1,6 @@
 /*
- * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2012 Hiroyuki Yamamoto and the Claws Mail team
+ * Claws Mail -- a GTK+ based, lightweight, and fast e-mail client
+ * Copyright (C) 1999-2019 Hiroyuki Yamamoto and the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  *
  * You should have received a copy of the GNU General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
- * 
  */
 
 #ifdef HAVE_CONFIG_H
 #  include "config.h"
+#include "claws-features.h"
 #endif
 
 #include "defs.h"
@@ -43,6 +43,7 @@
 #include "menu.h"
 #include "textview.h"
 #include "main.h"
+#include "file-utils.h"
 
 extern SessionStats session_stats;
 static GtkTextBuffer *stats_text_buffer;
@@ -84,6 +85,8 @@ void about_show(void)
        
 }
 
+#define ADD_TEXT(text) gtk_text_buffer_insert(buffer, &iter, text, -1)
+
 static GtkWidget *about_create_child_page_info(void)
 {
        GtkWidget *scrolledwin;
@@ -116,7 +119,7 @@ static GtkWidget *about_create_child_page_info(void)
        gtk_text_buffer_get_iter_at_offset(buffer, &iter, 0);
 
        /* textview link style (based upon main prefs) */
-       gtkut_convert_int_to_gdk_color(prefs_common.uri_col,
+       gtkut_convert_int_to_gdk_color(prefs_common.color[COL_URI],
                                (GdkColor*)&uri_color);
        tag = gtk_text_buffer_create_tag(buffer, "link",
                                "foreground-gdk", &uri_color,
@@ -127,18 +130,25 @@ static GtkWidget *about_create_child_page_info(void)
                                "underline", PANGO_UNDERLINE_SINGLE,
                                NULL);
 
-       gtk_text_buffer_insert(buffer, &iter, _(
-                               "Claws Mail is a lightweight, fast and "
-                               "highly-configurable email client.\n\n"
-                               "For further information visit the Claws Mail "
-                               "website:\n"), -1);
+       ADD_TEXT(_("Claws Mail is a lightweight, fast and highly-configurable "
+                               "email client."));
+       ADD_TEXT("\n\n");
+       ADD_TEXT(_("For further information visit the Claws Mail website:"));
+       ADD_TEXT("\n");
        gtk_text_buffer_insert_with_tags_by_name(buffer, &iter, HOMEPAGE_URI, -1,
                                "link", NULL);
-       gtk_text_buffer_insert(buffer, &iter, _("\n\n"
-                               "Claws Mail is free software released "
+       ADD_TEXT("\n\n");
+       ADD_TEXT(_("For support and discussion subscribe to the Claws Mail "
+                               "users' mailing list:"));
+       ADD_TEXT("\n");
+       gtk_text_buffer_insert_with_tags_by_name(buffer, &iter, USERS_ML_URI, -1,
+                               "link", NULL);
+       ADD_TEXT("\n\n");
+       ADD_TEXT(_("Claws Mail is free software released "
                                "under the GPL. If you wish to donate "
                                "to the Claws Mail project you can do "
-                               "so at:\n"), -1);
+                               "so at:"));
+       ADD_TEXT("\n");
        gtk_text_buffer_insert_with_tags_by_name(buffer, &iter, DONATE_URI, -1,
                                "link", NULL);
 
@@ -149,37 +159,38 @@ static GtkWidget *about_create_child_page_info(void)
                                "underline", PANGO_UNDERLINE_SINGLE,
                                NULL);
 #ifdef GENERIC_UMPC
-       gtk_text_buffer_insert(buffer, &iter, _(
-                               "\n\nCopyright (C) 1999-2012\nThe Claws Mail Team\n"
-                               " and Hiroyuki Yamamoto"), -1);
+       ADD_TEXT("\n\n");
+       ADD_TEXT(_("Copyright (C) 1999-2019\nThe Claws Mail Team\n"
+                               "and Hiroyuki Yamamoto"));
 #endif
-       gtk_text_buffer_insert_with_tags_by_name(buffer, &iter, (_("\n\nSystem Information\n")), -1,
-                       "underlined-list-title", NULL);
+       ADD_TEXT("\n\n");
+       gtk_text_buffer_insert_with_tags_by_name(buffer, &iter,
+                       (_("System Information\n")), -1, "underlined-list-title", NULL);
 
 #if HAVE_SYS_UTSNAME_H
        uname(&utsbuf);
-       g_snprintf(buf, sizeof(buf),
-                  _("GTK+ %d.%d.%d / GLib %d.%d.%d\n"
-                    "Locale: %s (charset: %s)\n"
-                    "Operating System: %s %s (%s)"),
+       g_snprintf(buf, sizeof(buf),g_strconcat(
+                      "GTK+ %d.%d.%d / GLib %d.%d.%d\n",
+                    _("Locale: %s (charset: %s)\n"
+                    "Operating System: %s %s (%s)"), NULL),
                   gtk_major_version, gtk_minor_version, gtk_micro_version,
                   glib_major_version, glib_minor_version, glib_micro_version,
                   conv_get_current_locale(), conv_get_locale_charset_str(),
                   utsbuf.sysname, utsbuf.release, utsbuf.machine);
 #elif defined(G_OS_WIN32)
-       g_snprintf(buf, sizeof(buf),
-                  _("GTK+ %d.%d.%d / GLib %d.%d.%d\n"
-                    "Locale: %s (charset: %s)\n"
-                    "Operating System: %s"),
+       g_snprintf(buf, sizeof(buf),g_strconcat(
+                      "GTK+ %d.%d.%d / GLib %d.%d.%d\n",
+                    _("Locale: %s (charset: %s)\n"
+                    "Operating System: %s"), NULL),
                   gtk_major_version, gtk_minor_version, gtk_micro_version,
                   glib_major_version, glib_minor_version, glib_micro_version,
                   conv_get_current_locale(), conv_get_locale_charset_str(),
                   "Win32");
 #else
-       g_snprintf(buf, sizeof(buf),
-                  _("GTK+ %d.%d.%d / GLib %d.%d.%d\n"
-                    "Locale: %s (charset: %s)\n"
-                    "Operating System: unknown"),
+       g_snprintf(buf, sizeof(buf),g_strconcat(
+                      "GTK+ %d.%d.%d / GLib %d.%d.%d\n",
+                    _("Locale: %s (charset: %s)\n"
+                    "Operating System: unknown"), NULL),
                   gtk_major_version, gtk_minor_version, gtk_micro_version,
                   glib_major_version, glib_minor_version, glib_micro_version,
                   conv_get_current_locale(), conv_get_locale_charset_str());
@@ -187,8 +198,7 @@ static GtkWidget *about_create_child_page_info(void)
 
        gtk_text_buffer_insert_with_tags_by_name(buffer, &iter, buf, -1,
                                                 "indented-list-item", NULL);
-
-       gtk_text_buffer_insert(buffer, &iter, "\n", -1);
+       ADD_TEXT("\n");
 
        g_signal_connect(G_OBJECT(tag), "event",
                                G_CALLBACK(about_textview_uri_clicked), text);
@@ -234,8 +244,8 @@ static GtkWidget *about_create_child_page_authors(void)
                                "underline", PANGO_UNDERLINE_SINGLE,
                                NULL);
 
-       gtk_text_buffer_insert_with_tags_by_name(buffer, &iter, (_("The Claws Mail Team")), -1,
-                       "underlined-list-title", NULL);
+       gtk_text_buffer_insert_with_tags_by_name(buffer, &iter,
+                       (_("The Claws Mail Team")), -1, "underlined-list-title", NULL);
        gtk_text_buffer_insert(buffer, &iter, "\n", 1);
 
        for (i = 0; TEAM_LIST[i] != NULL; i++) {
@@ -252,10 +262,10 @@ static GtkWidget *about_create_child_page_authors(void)
                gtk_text_buffer_insert(buffer, &iter, "\n", 1);
        }
 
-       gtk_text_buffer_insert(buffer, &iter, "\n", 1);
-       gtk_text_buffer_insert_with_tags_by_name(buffer, &iter, (_("Previous team members")), -1,
-                       "underlined-list-title", NULL);
-       gtk_text_buffer_insert(buffer, &iter, "\n", 1);
+       ADD_TEXT("\n");
+       gtk_text_buffer_insert_with_tags_by_name(buffer, &iter,
+                       (_("Previous team members")), -1, "underlined-list-title", NULL);
+       ADD_TEXT("\n");
 
        for (i = 0; EX_TEAM_LIST[i] != NULL; i++) {
                if (g_utf8_validate(EX_TEAM_LIST[i], -1, NULL))
@@ -268,13 +278,13 @@ static GtkWidget *about_create_child_page_authors(void)
                                                "indented-list-item", NULL);
                        g_free(conv);
                }
-               gtk_text_buffer_insert(buffer, &iter, "\n", 1);
+               ADD_TEXT("\n");
        }
 
-       gtk_text_buffer_insert(buffer, &iter, "\n", 1);
-       gtk_text_buffer_insert_with_tags_by_name(buffer, &iter, (_("The translation team")), -1,
-                       "underlined-list-title", NULL);
-       gtk_text_buffer_insert(buffer, &iter, "\n", 1);
+       ADD_TEXT("\n");
+       gtk_text_buffer_insert_with_tags_by_name(buffer, &iter,
+                       (_("The translation team")), -1, "underlined-list-title", NULL);
+       ADD_TEXT("\n");
 
        for (i = 0; TRANS_TEAM_LIST[i] != NULL; i++) {
                if (g_utf8_validate(TRANS_TEAM_LIST[i], -1, NULL))
@@ -287,13 +297,13 @@ static GtkWidget *about_create_child_page_authors(void)
                                                "indented-list-item", NULL);
                        g_free(conv);
                }
-               gtk_text_buffer_insert(buffer, &iter, "\n", 1);
+               ADD_TEXT("\n");
        }
 
-       gtk_text_buffer_insert(buffer, &iter, "\n", 1);
-       gtk_text_buffer_insert_with_tags_by_name(buffer, &iter, (_("Documentation team")), -1,
-                       "underlined-list-title", NULL);
-       gtk_text_buffer_insert(buffer, &iter, "\n", 1);
+       ADD_TEXT("\n");
+       gtk_text_buffer_insert_with_tags_by_name(buffer, &iter,
+                       (_("Documentation team")), -1, "underlined-list-title", NULL);
+       ADD_TEXT("\n");
 
        for (i = 0; DOC_TEAM_LIST[i] != NULL; i++) {
                if (g_utf8_validate(DOC_TEAM_LIST[i], -1, NULL))
@@ -306,13 +316,13 @@ static GtkWidget *about_create_child_page_authors(void)
                                                "indented-list-item", NULL);
                        g_free(conv);
                }
-               gtk_text_buffer_insert(buffer, &iter, "\n", 1);
+               ADD_TEXT("\n");
        }
 
-       gtk_text_buffer_insert(buffer, &iter, "\n", 1);
+       ADD_TEXT("\n");
        gtk_text_buffer_insert_with_tags_by_name(buffer, &iter, (_("Logo")), -1,
                        "underlined-list-title", NULL);
-       gtk_text_buffer_insert(buffer, &iter, "\n", 1);
+       ADD_TEXT("\n");
 
        for (i = 0; LOGO_LIST[i] != NULL; i++) {
                if (g_utf8_validate(LOGO_LIST[i], -1, NULL))
@@ -325,13 +335,13 @@ static GtkWidget *about_create_child_page_authors(void)
                                                "indented-list-item", NULL);
                        g_free(conv);
                }
-               gtk_text_buffer_insert(buffer, &iter, "\n", 1);
+               ADD_TEXT("\n");
        }
 
-       gtk_text_buffer_insert(buffer, &iter, "\n", 1);
+       ADD_TEXT("\n");
        gtk_text_buffer_insert_with_tags_by_name(buffer, &iter, (_("Icons")), -1,
                        "underlined-list-title", NULL);
-       gtk_text_buffer_insert(buffer, &iter, "\n", 1);
+       ADD_TEXT("\n");
 
        for (i = 0; ICONS_LIST[i] != NULL; i++) {
                if (g_utf8_validate(ICONS_LIST[i], -1, NULL))
@@ -344,13 +354,13 @@ static GtkWidget *about_create_child_page_authors(void)
                                                "indented-list-item", NULL);
                        g_free(conv);
                }
-               gtk_text_buffer_insert(buffer, &iter, "\n", 1);
+               ADD_TEXT("\n");
        }
 
-       gtk_text_buffer_insert(buffer, &iter, "\n", 1);
+       ADD_TEXT("\n");
        gtk_text_buffer_insert_with_tags_by_name(buffer, &iter, (_("Contributors")), -1,
                        "underlined-list-title", NULL);
-       gtk_text_buffer_insert(buffer, &iter, "\n", 1);
+       ADD_TEXT("\n");
 
        for (i = 0; CONTRIBS_LIST[i] != NULL; i++) {
                if (g_utf8_validate(CONTRIBS_LIST[i], -1, NULL))
@@ -363,7 +373,7 @@ static GtkWidget *about_create_child_page_authors(void)
                                                "indented-list-item", NULL);
                        g_free(conv);
                }
-               gtk_text_buffer_insert(buffer, &iter, "\n", 1);
+               ADD_TEXT("\n");
        }
 
        return scrolledwin;
@@ -396,13 +406,14 @@ static GtkWidget *about_create_child_page_features(void)
        buffer = gtk_text_view_get_buffer(GTK_TEXT_VIEW(text));
        gtk_text_buffer_get_iter_at_offset(buffer, &iter, 0);
 
-       gtk_text_buffer_insert(buffer, &iter, _("Compiled-in Features\n"), -1);
+       ADD_TEXT(_("Compiled-in Features"));
+       ADD_TEXT("\n");
 
        gtk_text_buffer_create_tag(buffer, "bold", "weight", PANGO_WEIGHT_BOLD,
                                   NULL);
 
-       stock_pixbuf_gdk(window, STOCK_PIXMAP_CHECKBOX_ON, &active_pixbuf);
-       stock_pixbuf_gdk(window, STOCK_PIXMAP_CHECKBOX_OFF, &inactive_pixbuf);
+       stock_pixbuf_gdk(STOCK_PIXMAP_CHECKBOX_ON, &active_pixbuf);
+       stock_pixbuf_gdk(STOCK_PIXMAP_CHECKBOX_OFF, &inactive_pixbuf);
 
 #if HAVE_LIBCOMPFACE
        gtk_text_buffer_insert_pixbuf(buffer, &iter, active_pixbuf);
@@ -412,7 +423,7 @@ static GtkWidget *about_create_child_page_features(void)
        gtk_text_buffer_insert_with_tags_by_name(buffer, &iter, (" compface "), -1,
                                                 "bold", NULL);
        gtk_text_buffer_insert(buffer, &iter, 
-               (gchar *)Q_("compface|adds support for the X-Face header\n"), -1);
+               (gchar *)C_("compface", "adds support for the X-Face header\n"), -1);
 
 #if USE_ENCHANT
        gtk_text_buffer_insert_pixbuf(buffer, &iter, active_pixbuf);
@@ -422,7 +433,7 @@ static GtkWidget *about_create_child_page_features(void)
        gtk_text_buffer_insert_with_tags_by_name(buffer, &iter, (" Enchant "), -1,
                                                 "bold", NULL);
        gtk_text_buffer_insert(buffer, &iter, 
-               (gchar *)Q_("Enchant|adds support for spell checking\n"), -1);
+               (gchar *)C_("Enchant", "adds support for spell checking\n"), -1);
 
 #if USE_GNUTLS
        gtk_text_buffer_insert_pixbuf(buffer, &iter, active_pixbuf);
@@ -432,7 +443,7 @@ static GtkWidget *about_create_child_page_features(void)
        gtk_text_buffer_insert_with_tags_by_name(buffer, &iter, (" GnuTLS "), -1,
                                                 "bold", NULL);
        gtk_text_buffer_insert(buffer, &iter, 
-               (gchar *)Q_("GnuTLS|adds support for encrypted connections to servers\n"), -1);
+               (gchar *)C_("GnuTLS", "adds support for encrypted connections to servers\n"), -1);
 
 #if INET6
        gtk_text_buffer_insert_pixbuf(buffer, &iter, active_pixbuf);
@@ -442,7 +453,7 @@ static GtkWidget *about_create_child_page_features(void)
        gtk_text_buffer_insert_with_tags_by_name(buffer, &iter, (" IPv6 "), -1,
                                                 "bold", NULL);
        gtk_text_buffer_insert(buffer, &iter, 
-               (gchar *)Q_("IPv6|adds support for IPv6 addresses, the new Internet "
+               (gchar *)C_("IPv6", "adds support for IPv6 addresses, the new Internet "
                            "addressing protocol\n"), -1);
 
 #if HAVE_ICONV
@@ -453,7 +464,7 @@ static GtkWidget *about_create_child_page_features(void)
        gtk_text_buffer_insert_with_tags_by_name(buffer, &iter, (" iconv "), -1,
                                                 "bold", NULL);
        gtk_text_buffer_insert(buffer, &iter, 
-               (gchar *)Q_("iconv|allows converting to and from different character sets\n"), -1);
+               (gchar *)C_("iconv", "allows converting to and from different character sets\n"), -1);
 
 #if USE_JPILOT
        gtk_text_buffer_insert_pixbuf(buffer, &iter, active_pixbuf);
@@ -463,7 +474,7 @@ static GtkWidget *about_create_child_page_features(void)
        gtk_text_buffer_insert_with_tags_by_name(buffer, &iter, (" JPilot "), -1,
                                                 "bold", NULL);
        gtk_text_buffer_insert(buffer, &iter, 
-               (gchar *)Q_("JPilot|adds support for PalmOS addressbooks\n"), -1);
+               (gchar *)C_("JPilot", "adds support for PalmOS addressbooks\n"), -1);
 
 #if USE_LDAP
        gtk_text_buffer_insert_pixbuf(buffer, &iter, active_pixbuf);
@@ -473,7 +484,7 @@ static GtkWidget *about_create_child_page_features(void)
        gtk_text_buffer_insert_with_tags_by_name(buffer, &iter, (" LDAP "), -1,
                                                 "bold", NULL);
        gtk_text_buffer_insert(buffer, &iter, 
-               (gchar *)Q_("LDAP|adds support for LDAP shared addressbooks\n"), -1);
+               (gchar *)C_("LDAP", "adds support for LDAP shared addressbooks\n"), -1);
 
 #if HAVE_LIBETPAN
        gtk_text_buffer_insert_pixbuf(buffer, &iter, active_pixbuf);
@@ -483,7 +494,7 @@ static GtkWidget *about_create_child_page_features(void)
        gtk_text_buffer_insert_with_tags_by_name(buffer, &iter, (" libetpan "), -1,
                                                 "bold", NULL);
        gtk_text_buffer_insert(buffer, &iter, 
-               (gchar *)Q_("libetpan|adds support for IMAP and NNTP servers\n"), -1);
+               (gchar *)C_("libetpan", "adds support for IMAP and NNTP servers\n"), -1);
 
 #if HAVE_LIBSM
        gtk_text_buffer_insert_pixbuf(buffer, &iter, active_pixbuf);
@@ -493,7 +504,7 @@ static GtkWidget *about_create_child_page_features(void)
        gtk_text_buffer_insert_with_tags_by_name(buffer, &iter, (" libSM "), -1,
                                                 "bold", NULL);
        gtk_text_buffer_insert(buffer, &iter, 
-               (gchar *)Q_("libSM|adds support for session handling\n"), -1);
+               (gchar *)C_("libSM", "adds support for session handling\n"), -1);
 
 #if HAVE_NETWORKMANAGER_SUPPORT
        gtk_text_buffer_insert_pixbuf(buffer, &iter, active_pixbuf);
@@ -503,7 +514,17 @@ static GtkWidget *about_create_child_page_features(void)
        gtk_text_buffer_insert_with_tags_by_name(buffer, &iter, (" NetworkManager "), -1,
                                                 "bold", NULL);
        gtk_text_buffer_insert(buffer, &iter,
-               (gchar *)Q_("NetworkManager|adds support for detection of network connection changes\n"), -1);
+               (gchar *)C_("NetworkManager", "adds support for detection of network connection changes\n"), -1);
+
+#if HAVE_SVG
+       gtk_text_buffer_insert_pixbuf(buffer, &iter, active_pixbuf);
+#else
+       gtk_text_buffer_insert_pixbuf(buffer, &iter, inactive_pixbuf);
+#endif
+       gtk_text_buffer_insert_with_tags_by_name(buffer, &iter, (" librSVG "), -1,
+                                                "bold", NULL);
+       gtk_text_buffer_insert(buffer, &iter,
+               (gchar *)C_("librSVG", "adds support for SVG themes\n"), -1);
 
        return scrolledwin;
 }
@@ -534,20 +555,22 @@ static GtkWidget *about_create_child_page_license(void)
        buffer = gtk_text_view_get_buffer(GTK_TEXT_VIEW(text));
        gtk_text_buffer_get_iter_at_offset(buffer, &iter, 0);
 
-       gtk_text_buffer_insert(buffer, &iter,
+       ADD_TEXT(
                _("This program is free software; you can redistribute it and/or modify "
                  "it under the terms of the GNU General Public License as published by "
                  "the Free Software Foundation; either version 3, or (at your option) "
-                 "any later version.\n\n"), -1);
+                 "any later version."));
+       ADD_TEXT("\n\n");
 
-       gtk_text_buffer_insert(buffer, &iter,
+       ADD_TEXT(
                _("This program is distributed in the hope that it will be useful, "
                  "but WITHOUT ANY WARRANTY; without even the implied warranty of "
                  "MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. "
-                 "See the GNU General Public License for more details.\n\n"), -1);
+                 "See the GNU General Public License for more details."));
+       ADD_TEXT("\n\n");
 
        /* textview link style (based upon main prefs) */
-       gtkut_convert_int_to_gdk_color(prefs_common.uri_col,
+       gtkut_convert_int_to_gdk_color(prefs_common.color[COL_URI],
                        (GdkColor*)&uri_color);
 
        tag = gtk_text_buffer_create_tag(buffer, "link",
@@ -558,13 +581,13 @@ static GtkWidget *about_create_child_page_license(void)
                "underline", PANGO_UNDERLINE_SINGLE,
                NULL);
 
-       gtk_text_buffer_insert(buffer, &iter,
+       gtk_text_buffer_insert(buffer, &iter, g_strconcat(
                _("You should have received a copy of the GNU General Public License "
-                 "along with this program. If not, see <"), -1);
+                 "along with this program. If not, see "), "<", NULL), -1);
        gtk_text_buffer_insert_with_tags_by_name(buffer, &iter, 
                "http://www.gnu.org/licenses/", -1,
                "link", NULL);
-       gtk_text_buffer_insert(buffer, &iter, _(">. \n\n"), -1);
+       gtk_text_buffer_insert(buffer, &iter, ">. \n\n", -1);
 
        g_signal_connect(G_OBJECT(tag), "event",
                                G_CALLBACK(about_textview_uri_clicked), text);
@@ -576,6 +599,8 @@ static GtkWidget *about_create_child_page_license(void)
        return scrolledwin;
 }
 
+#undef ADD_TEXT
+
 static gboolean release_notes_available(void)
 {
        gboolean ret = FALSE;
@@ -614,28 +639,28 @@ static GtkWidget *about_create_child_page_release_notes(void)
        gtk_text_buffer_get_iter_at_offset(buffer, &iter, 0);
 
        path = g_strconcat(DOCDIR, G_DIR_SEPARATOR_S, RELEASE_NOTES_FILE, NULL);
-       if ((fp = g_fopen(path, "rb")) == NULL) {
-               if (ENOENT != errno) FILE_OP_ERROR(path, "fopen");
+       if ((fp = claws_fopen(path, "rb")) == NULL) {
+               if (ENOENT != errno) FILE_OP_ERROR(path, "claws_fopen");
                g_free(path);
                return scrolledwin;
        }
        g_free(path);
 
-       while (fgets(buf, sizeof(buf), fp) != NULL) {
+       while (claws_fgets(buf, sizeof(buf), fp) != NULL) {
                const gchar *src_codeset = conv_get_locale_charset_str();
                const gchar *dest_codeset = CS_UTF_8;
                gchar *tmp;
 
                tmp = conv_codeset_strdup(buf, src_codeset, dest_codeset);
                if (!tmp) {
-                       g_warning("Failed to convert character set of action configuration\n");
+                       g_warning("Failed to convert character set of action configuration");
                        tmp = g_strdup(buf);
                }
 
                gtk_text_buffer_insert(buffer, &iter, tmp, -1);
                g_free(tmp);
        }
-       fclose(fp);
+       claws_fclose(fp);
 
        return scrolledwin;
 }
@@ -693,11 +718,22 @@ static void about_update_stats(void)
                                (_("Session statistics\n")), -1,
                                "underlined-list-title", NULL);
 
-               g_snprintf(buf, sizeof(buf), _("Started: %s\n"),
-                                       ctime(&session_stats.time_started));
+               if (prefs_common.date_format) {
+                       struct tm *lt;
+                       gint len = 100;
+                       gchar date[len];
+
+                       lt = localtime(&session_stats.time_started);
+                       fast_strftime(date, len, prefs_common.date_format, lt);
+                       g_snprintf(buf, sizeof(buf), _("Started: %s\n"),
+                                               lt ? date : ctime(&session_stats.time_started));
+               } else
+                       g_snprintf(buf, sizeof(buf), _("Started: %s\n"),
+                                               ctime(&session_stats.time_started));
                gtk_text_buffer_insert_with_tags_by_name(stats_text_buffer, &iter, buf, -1,
                                "indented-list-item", NULL);
 
+               gtk_text_buffer_insert(stats_text_buffer, &iter, "\n", 1);
                gtk_text_buffer_insert_with_tags_by_name(stats_text_buffer, &iter,
                                (_("Incoming traffic\n")), -1,
                                "underlined-list-title", NULL);
@@ -755,6 +791,7 @@ static void about_create(void)
        window = gtkut_window_new(GTK_WINDOW_TOPLEVEL, "about");
        gtk_window_set_position(GTK_WINDOW(window), GTK_WIN_POS_CENTER_ALWAYS);
        gtk_window_set_title(GTK_WINDOW(window), _("About Claws Mail"));
+       gtk_window_set_type_hint(GTK_WINDOW(window), GDK_WINDOW_TYPE_HINT_DIALOG);
        gtk_container_set_border_width(GTK_CONTAINER(window), 8);
        gtk_widget_set_size_request(window, -1, -1);
        g_signal_connect(G_OBJECT(window), "size_allocate",
@@ -788,7 +825,7 @@ static void about_create(void)
        gtk_table_set_row_spacings (GTK_TABLE (table), 8);
        gtk_table_set_col_spacings (GTK_TABLE (table), 8);
 
-       image = stock_pixmap_widget(window, STOCK_PIXMAP_CLAWS_MAIL_LOGO);
+       image = stock_pixmap_widget(STOCK_PIXMAP_CLAWS_MAIL_LOGO);
        gtk_table_attach (GTK_TABLE (table), image, 0, 1, 0, 1,
                        (GtkAttachOptions) (GTK_EXPAND),
                        (GtkAttachOptions) (0), 0, 0);
@@ -812,7 +849,7 @@ static void about_create(void)
        gtk_box_pack_start(GTK_BOX(vbox2), button, FALSE, FALSE, 0);
 #ifndef GENERIC_UMPC
        label = gtk_label_new
-               (_("Copyright (C) 1999-2012\nThe Claws Mail Team\n"
+               (_("Copyright (C) 1999-2019\nThe Claws Mail Team\n"
                 "and Hiroyuki Yamamoto"));
        gtk_label_set_selectable(GTK_LABEL(label), TRUE);
        gtk_label_set_justify(GTK_LABEL(label), GTK_JUSTIFY_CENTER);