2007-11-20 [colin] 3.1.0cvs11
[claws.git] / src / folderview.c
index 302d948707beaa03548579d200ed40b525106347..f0733d8de8d3b7b387bfd3caa44d31a0ae642952 100644 (file)
@@ -263,8 +263,10 @@ static void folderview_drag_received_cb  (GtkWidget        *widget,
                                          guint             info,
                                          guint             time,
                                          FolderView       *folderview);
+#ifndef MAEMO
 static void folderview_start_drag       (GtkWidget *widget, gint button, GdkEvent *event,
                                          FolderView       *folderview);
+#endif
 static void folderview_drag_data_get     (GtkWidget        *widget,
                                          GdkDragContext   *drag_context,
                                          GtkSelectionData *selection_data,
@@ -292,7 +294,7 @@ static GtkItemFactoryEntry folderview_common_popup_entries[] =
 {
        {N_("/Mark all re_ad"),         NULL, mark_all_read_cb, 0, NULL},
        {"/---",                        NULL, NULL, 0, "<Separator>"},
-       {N_("/Run processing rules"),   NULL, folderview_run_processing_cb, 0, NULL},
+       {N_("/R_un processing rules"),  NULL, folderview_run_processing_cb, 0, NULL},
        {N_("/_Search folder..."),      NULL, folderview_search_cb, 0, NULL},
        {N_("/_Properties..."),         NULL, folderview_property_cb, 0, NULL},
        {N_("/Process_ing..."),         NULL, folderview_processing_cb, 0, NULL},
@@ -754,7 +756,7 @@ static gboolean folderview_defer_set(gpointer data)
        if (mainwin->lock_count)
                return TRUE;
                
-       printf("doing deferred folderview_set now\n");
+       debug_print("doing deferred folderview_set now\n");
        folderview_set(folderview);
 
        folderview->deferred_refresh_id = -1;
@@ -774,7 +776,7 @@ void folderview_set(FolderView *folderview)
                if (folderview->deferred_refresh_id == -1)
                        folderview->deferred_refresh_id = 
                                g_timeout_add(500, folderview_defer_set, folderview);
-               printf("deferred folderview_set\n");
+               debug_print("deferred folderview_set\n");
                return;
        }
 
@@ -1130,6 +1132,7 @@ void folderview_rescan_tree(Folder *folder, gboolean rebuild)
                pos = gtk_scrolled_window_get_vadjustment(
                                        GTK_SCROLLED_WINDOW(folderview->scrolledwin));
                gtk_adjustment_set_value(pos, height);
+               gtk_adjustment_changed(pos);
        }
        label_window_destroy(window);
        inc_unlock();
@@ -1170,6 +1173,7 @@ void folderview_fast_rescan_tree(Folder *folder)
                pos = gtk_scrolled_window_get_vadjustment(
                                        GTK_SCROLLED_WINDOW(folderview->scrolledwin));
                gtk_adjustment_set_value(pos, height);
+               gtk_adjustment_changed(pos);
        }
        label_window_destroy(window);
        inc_unlock();
@@ -1195,7 +1199,7 @@ gint folderview_check_new(Folder *folder)
        for (list = folderview_list; list != NULL; list = list->next) {
                folderview = (FolderView *)list->data;
                ctree = GTK_CTREE(folderview->ctree);
-
+               folderview->scanning_folder = folder;
                inc_lock();
                main_window_lock(folderview->mainwin);
 
@@ -1213,6 +1217,11 @@ gint folderview_check_new(Folder *folder)
                                        item->path ? item->path : item->name);
                                continue;
                        }
+                       if (item->scanning == TRUE) {
+                               debug_print("skipping %s, scanning\n",
+                                       item->path ? item->path : item->name);
+                               continue;
+                       }
 
                        str = get_scan_str(item);
 
@@ -1262,7 +1271,7 @@ gint folderview_check_new(Folder *folder)
                        former_new_msgs += former_new;
                        STATUSBAR_POP(folderview->mainwin);
                }
-
+               folderview->scanning_folder = NULL;
                main_window_unlock(folderview->mainwin);
                inc_unlock();
        }
@@ -1925,13 +1934,19 @@ static void folderview_set_sens_and_popup_menu(FolderView *folderview, gint row,
 #define SET_SENS(name, sens) \
        menu_set_sensitive(fpopup_factory, name, sens)
 
+       if ( FOLDER_TYPE(item->folder) == F_NEWS || FOLDER_TYPE(item->folder) == F_IMAP )
+               SET_SENS("/Download messages", !item->no_select);
+
        SET_SENS("/Mark all read", item->unread_msgs >= 1);
        SET_SENS("/Search folder...", item->total_msgs >= 1 && 
                 folderview->selected == folderview->opened);
+       SET_SENS("/Properties...", !item->no_select);
+
        SET_SENS("/Run processing rules", item->prefs->processing &&
-                item->total_msgs >= 1);
-       SET_SENS("/Properties...", TRUE);
-       SET_SENS("/Processing...", item->node->parent != NULL);
+                item->total_msgs >= 1 && !item->processing_pending);
+       SET_SENS("/Processing...", item->node->parent != NULL && 
+               !item->no_select && !item->processing_pending);
+
        if (item == folder->trash || item == special_trash
            || folder_has_parent_of_type(item, F_TRASH)) {
                GSList *msglist = folder_item_get_msg_list(item);
@@ -1949,8 +1964,6 @@ static void folderview_set_sens_and_popup_menu(FolderView *folderview, gint row,
        popup = gtk_item_factory_get_widget(fpopup_factory, fpopup->path);
        gtk_menu_popup(GTK_MENU(popup), NULL, NULL, NULL, NULL,
                       event->button, event->time);
-
-
 }
 
 static gboolean folderview_button_pressed(GtkWidget *ctree, GdkEventButton *event,
@@ -2016,8 +2029,13 @@ static gboolean folderview_button_pressed(GtkWidget *ctree, GdkEventButton *even
 static gboolean folderview_button_released(GtkWidget *ctree, GdkEventButton *event,
                                           FolderView *folderview)
 {
+       int row = -1, column = -1;
+
        if (!event) return FALSE;
 
+       if (!gtk_clist_get_selection_info(GTK_CLIST(ctree), event->x, event->y,
+                                         &row, &column))
+               return FALSE;
        if (event->button == 1 && folderview->open_folder == FALSE &&
            folderview->opened != NULL) {
                gtkut_ctree_set_focus_row(GTK_CTREE(ctree),
@@ -2143,6 +2161,13 @@ static void folderview_selected(GtkCTree *ctree, GtkCTreeNode *row,
                return;
        }
        
+       item = gtk_ctree_node_get_row_data(ctree, row);
+       if (!item) {
+               END_TIMING();
+               folderview->open_folder = FALSE;
+               return;
+       }
+
        if (!can_select || summary_is_locked(folderview->summaryview)) {
                if (folderview->opened) {
                        gtkut_ctree_set_focus_row(ctree, folderview->opened);
@@ -2157,12 +2182,6 @@ static void folderview_selected(GtkCTree *ctree, GtkCTreeNode *row,
                END_TIMING();
                return;
        }
-       item = gtk_ctree_node_get_row_data(ctree, row);
-       if (!item || item->no_select) {
-               END_TIMING();
-               folderview->open_folder = FALSE;
-               return;
-       }
 
        can_select = FALSE;
 
@@ -2193,6 +2212,7 @@ static void folderview_selected(GtkCTree *ctree, GtkCTreeNode *row,
        }
 
        /* Open Folder */
+       /* TODO: wwp: avoid displaying (null) in the status bar */
        buf = g_strdup_printf(_("Opening Folder %s..."), item->path ? 
                                        item->path : "(null)");
        debug_print("%s\n", buf);
@@ -2201,8 +2221,13 @@ static void folderview_selected(GtkCTree *ctree, GtkCTreeNode *row,
 
        main_window_cursor_wait(folderview->mainwin);
 
-       res = folder_item_open(item);
-       if (res == -1) {
+       if (folderview->scanning_folder == item->folder) {
+               res = -2;
+       } else {
+               res = folder_item_open(item);
+       }
+
+       if (res == -1 && item->no_select == FALSE) {
                main_window_cursor_normal(folderview->mainwin);
                STATUSBAR_POP(folderview->mainwin);
 
@@ -2212,7 +2237,7 @@ static void folderview_selected(GtkCTree *ctree, GtkCTreeNode *row,
                can_select = TRUE;
                END_TIMING();
                return;
-        } else if (res == -2) {
+        } else if (res == -2 && item->no_select == FALSE) {
                PostponedSelectData *data = g_new0(PostponedSelectData, 1);
                data->ctree = ctree;
                data->row = row;
@@ -2439,11 +2464,9 @@ static void folderview_send_queue_cb(FolderView *folderview, guint action,
                        alertpanel_error_log(_("Some errors occurred while "
                                           "sending queued messages."));
                else {
-                       gchar *tmp = g_strdup_printf(_("Some errors occurred "
+                       alertpanel_error_log(_("Some errors occurred "
                                        "while sending queued messages:\n%s"), errstr);
                        g_free(errstr);
-                       alertpanel_error_log(tmp);
-                       g_free(tmp);
                }
        }
 }
@@ -2466,7 +2489,9 @@ static void folderview_run_processing_cb(FolderView *folderview, guint action,
        g_return_if_fail(item != NULL);
        g_return_if_fail(item->folder != NULL);
 
+       item->processing_pending = TRUE;
        folder_item_apply_processing(item);
+       item->processing_pending = FALSE;
 }
 
 static void folderview_property_cb(FolderView *folderview, guint action,
@@ -2706,6 +2731,7 @@ void folderview_reflect_prefs(void)
        pos = gtk_scrolled_window_get_vadjustment(
                                GTK_SCROLLED_WINDOW(folderview->scrolledwin));
        gtk_adjustment_set_value(pos, height);
+       gtk_adjustment_changed(pos);
        gtk_clist_thaw(GTK_CLIST(folderview->ctree));
 }
 
@@ -2747,7 +2773,7 @@ static void drag_state_start(FolderView *folderview, GtkCTreeNode *node, FolderI
                folderview->drag_item = item;
        }                        
 }
-
+#ifndef MAEMO
 static void folderview_start_drag(GtkWidget *widget, gint button, GdkEvent *event,
                                  FolderView       *folderview)
 {
@@ -2762,7 +2788,7 @@ static void folderview_start_drag(GtkWidget *widget, gint button, GdkEvent *even
                                 GDK_ACTION_MOVE|GDK_ACTION_COPY|GDK_ACTION_DEFAULT, button, event);
        gtk_drag_set_icon_default(context);
 }
-
+#endif
 static void folderview_drag_data_get(GtkWidget        *widget,
                                     GdkDragContext   *drag_context,
                                     GtkSelectionData *selection_data,
@@ -2846,16 +2872,20 @@ static gboolean folderview_drag_motion_cb(GtkWidget      *widget,
        int height = (int)pos->page_size;
        int total_height = (int)pos->upper;
        int vpos = (int) pos->value;
-
+       int offset = prefs_common.show_col_headers ? 24:0;
+       
        if (gtk_clist_get_selection_info
-               (GTK_CLIST(widget), x - 24, y - 24, &row, &column)) {
+               (GTK_CLIST(widget), x - offset, y - offset, &row, &column)) {
                GtkWidget *srcwidget;
 
-               if (y > height - 24 && height + vpos < total_height)
+               if (y > height - 24 && height + vpos < total_height) {
                        gtk_adjustment_set_value(pos, (vpos+5 > height ? height : vpos+5));
-
-               if (y < 48 && y > 0)
+                       gtk_adjustment_changed(pos);
+               }
+               if (y < 48 && y > 0) {
                        gtk_adjustment_set_value(pos, (vpos-5 < 0 ? 0 : vpos-5));
+                       gtk_adjustment_changed(pos);
+               }
 
                node = gtk_ctree_node_nth(GTK_CTREE(widget), row);
                item = gtk_ctree_node_get_row_data(GTK_CTREE(widget), node);
@@ -2984,19 +3014,25 @@ static void folderview_drag_received_cb(GtkWidget        *widget,
        gint row, column;
        FolderItem *item = NULL, *src_item;
        GtkCTreeNode *node;
+       int offset = prefs_common.show_col_headers ? 24:0;
 
        if (info == TARGET_DUMMY) {
                drag_state_stop(folderview);
                if ((void *)strstr(data->data, "FROM_OTHER_FOLDER") != (void *)data->data) {
                        /* comes from summaryview */
                        if (gtk_clist_get_selection_info
-                               (GTK_CLIST(widget), x - 24, y - 24, &row, &column) == 0)
+                               (GTK_CLIST(widget), x - offset, y - offset, &row, &column) == 0)
                                return;
 
                        node = gtk_ctree_node_nth(GTK_CTREE(widget), row);
                        item = gtk_ctree_node_get_row_data(GTK_CTREE(widget), node);
                        src_item = folderview->summaryview->folder_item;
 
+                       if (item->no_select) {
+                               alertpanel_error(_("The destination folder can only be used to "
+                                                  "store subfolders."));
+                               return;
+                       }
                        /* re-check (due to acceptable possibly set for folder moves */
                        if (!(item && item->folder && item->path && !item->no_select && 
                              src_item && src_item != item && FOLDER_CLASS(item->folder)->copy_msg != NULL)) {
@@ -3027,7 +3063,7 @@ static void folderview_drag_received_cb(GtkWidget        *widget,
 
                        source = data->data + 17;
                        if (gtk_clist_get_selection_info
-                           (GTK_CLIST(widget), x - 24, y - 24, &row, &column) == 0
+                           (GTK_CLIST(widget), x - offset, y - offset, &row, &column) == 0
                            || *source == 0) {
                                gtk_drag_finish(drag_context, FALSE, FALSE, time);                      
                                return;
@@ -3043,8 +3079,7 @@ static void folderview_drag_received_cb(GtkWidget        *widget,
                                !folder_has_parent_of_type(src_item, F_DRAFT) &&
                                !folder_has_parent_of_type(src_item, F_QUEUE) &&
                                !folder_has_parent_of_type(src_item, F_TRASH);
-                       if (!item || item->no_select || !src_item 
-                       ||  !folder_is_normal) {
+                       if (!item || !src_item || !folder_is_normal) {
                                gtk_drag_finish(drag_context, FALSE, FALSE, time);                      
                                return;
                        }
@@ -3055,7 +3090,7 @@ static void folderview_drag_received_cb(GtkWidget        *widget,
                folderview->nodes_to_recollapse = NULL;
        } else if (info == TARGET_MAIL_URI_LIST) {
                if (gtk_clist_get_selection_info
-                       (GTK_CLIST(widget), x - 24, y - 24, &row, &column) == 0)
+                       (GTK_CLIST(widget), x - offset, y - offset, &row, &column) == 0)
                        return;
 
                node = gtk_ctree_node_nth(GTK_CTREE(widget), row);