Fix g_timeout usage
[claws.git] / src / folderview.c
index 9c792b011d0ef5bec4e6a7704193f60828c6d780..94d708d6261c0dc73832f787a81c29494e5c92fe 100644 (file)
@@ -1,6 +1,6 @@
 /*
  * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2009 Hiroyuki Yamamoto and the Claws Mail team
+ * Copyright (C) 1999-2013 Hiroyuki Yamamoto and the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -445,15 +445,9 @@ static GtkWidget *folderview_ctree_create(FolderView *folderview)
        gtk_cmclist_set_column_justification(GTK_CMCLIST(ctree), 
                                           col_pos[F_COL_TOTAL],
                                           GTK_JUSTIFY_RIGHT);
-       if (prefs_common.enable_dotted_lines) {
-               gtk_cmctree_set_line_style(GTK_CMCTREE(ctree), GTK_CMCTREE_LINES_DOTTED);
-               gtk_cmctree_set_expander_style(GTK_CMCTREE(ctree),
-                                    GTK_CMCTREE_EXPANDER_SQUARE);
-       } else {
-               gtk_cmctree_set_line_style(GTK_CMCTREE(ctree), GTK_CMCTREE_LINES_NONE);
-               gtk_cmctree_set_expander_style(GTK_CMCTREE(ctree),
-                                    GTK_CMCTREE_EXPANDER_TRIANGLE);
-       }
+       gtk_cmctree_set_line_style(GTK_CMCTREE(ctree), GTK_CMCTREE_LINES_NONE);
+       gtk_cmctree_set_expander_style(GTK_CMCTREE(ctree),
+                            GTK_CMCTREE_EXPANDER_TRIANGLE);
 
        gtk_sctree_set_stripes(GTK_SCTREE(ctree), prefs_common.use_stripes_in_summaries);
        gtk_sctree_set_recursive_expand(GTK_SCTREE(ctree), FALSE);
@@ -463,8 +457,7 @@ static GtkWidget *folderview_ctree_create(FolderView *folderview)
 
        /* don't let title buttons take key focus */
        for (i = 0; i < N_FOLDER_COLS; i++) {
-               GTK_WIDGET_UNSET_FLAGS(GTK_CMCLIST(ctree)->column[i].button,
-                                      GTK_CAN_FOCUS);
+               gtkut_widget_set_can_focus(GTK_CMCLIST(ctree)->column[i].button, FALSE);
                gtk_cmclist_set_column_width(GTK_CMCLIST(ctree), col_pos[i],
                                   prefs_common.folder_col_size[i]);
                gtk_cmclist_set_column_visibility
@@ -477,15 +470,8 @@ static GtkWidget *folderview_ctree_create(FolderView *folderview)
        g_signal_connect(G_OBJECT(ctree), "button_press_event",
                         G_CALLBACK(folderview_button_pressed),
                         folderview);
-#ifndef MAEMO
        g_signal_connect(G_OBJECT(ctree), "popup-menu",
                         G_CALLBACK(folderview_popup_menu), folderview);
-#else
-       gtk_widget_tap_and_hold_setup(GTK_WIDGET(ctree), NULL, NULL,
-                       GTK_TAP_AND_HOLD_NONE | GTK_TAP_AND_HOLD_NO_INTERNALS);
-       g_signal_connect(G_OBJECT(ctree), "tap-and-hold",
-                        G_CALLBACK(folderview_popup_menu), folderview);
-#endif
        g_signal_connect(G_OBJECT(ctree), "button_release_event",
                         G_CALLBACK(folderview_button_released),
                         folderview);
@@ -541,6 +527,23 @@ void folderview_set_column_order(FolderView *folderview)
        FolderItem *sel_item = NULL, *op_item = NULL;
        GtkWidget *scrolledwin = folderview->scrolledwin;
 
+       if (folderview->drag_timer_id != 0) {
+               g_source_remove(folderview->drag_timer_id);
+               folderview->drag_timer_id = 0;
+       }
+       if (folderview->deferred_refresh_id != 0) {
+               g_source_remove(folderview->deferred_refresh_id);
+               folderview->deferred_refresh_id = 0;
+       }
+       if (folderview->scroll_timeout_id != 0) {
+               g_source_remove(folderview->scroll_timeout_id);
+               folderview->scroll_timeout_id = 0;
+       }
+       if (folderview->postpone_select_id != 0) {
+               g_source_remove(folderview->postpone_select_id);
+               folderview->postpone_select_id = 0;
+       }
+
        if (folderview->selected)
                sel_item = gtk_cmctree_node_get_row_data(GTK_CMCTREE(ctree), folderview->selected);
        if (folderview->opened)
@@ -604,7 +607,11 @@ FolderView *folderview_create(void)
        
        folderview->target_list = gtk_target_list_new(folderview_drag_types, 2);
        folderview_list = g_list_append(folderview_list, folderview);
-       folderview->deferred_refresh_id = -1;
+
+       folderview->drag_timer_id       = 0;
+       folderview->deferred_refresh_id = 0;
+       folderview->scroll_timeout_id   = 0;
+       folderview->postpone_select_id  = 0;
 
        return folderview;
 }
@@ -715,7 +722,7 @@ static gboolean folderview_defer_set(gpointer data)
        debug_print("doing deferred folderview_set now\n");
        folderview_set(folderview);
 
-       folderview->deferred_refresh_id = -1;
+       folderview->deferred_refresh_id = 0;
        return FALSE;
 }
 
@@ -729,7 +736,7 @@ void folderview_set(FolderView *folderview)
                return;
 
        if (mainwin->lock_count) {
-               if (folderview->deferred_refresh_id == -1)
+               if (folderview->deferred_refresh_id == 0)
                        folderview->deferred_refresh_id = 
                                g_timeout_add(500, folderview_defer_set, folderview);
                debug_print("deferred folderview_set\n");
@@ -803,7 +810,7 @@ static void mark_all_read_cb(GtkAction *action, gpointer data)
        &&  prefs_common.ask_mark_all_read) {
                val = alertpanel_full(_("Mark all as read"),
                        _("Do you really want to mark all mails in this "
-                         "folder as read ?"), GTK_STOCK_NO, GTK_STOCK_YES, NULL,
+                         "folder as read?"), GTK_STOCK_NO, GTK_STOCK_YES, NULL,
                          TRUE, NULL, ALERT_QUESTION, G_ALERTDEFAULT);
 
                if ((val & ~G_ALERTDISABLE) != G_ALERTALTERNATE)
@@ -1025,11 +1032,11 @@ static void folderview_set_folders(FolderView *folderview)
 static gchar *get_scan_str(FolderItem *item)
 {
        if (item->path)
-               return g_strdup_printf(_("Scanning folder %s%c%s ..."),
+               return g_strdup_printf(_("Scanning folder %s%c%s..."),
                                      item->folder->name, G_DIR_SEPARATOR,
                                      item->path);
        else
-               return g_strdup_printf(_("Scanning folder %s ..."),
+               return g_strdup_printf(_("Scanning folder %s..."),
                                      item->folder->name);      
 }
 static void folderview_scan_tree_func(Folder *folder, FolderItem *item,
@@ -1081,7 +1088,7 @@ void folderview_rescan_tree(Folder *folder, gboolean rebuild)
        if (folderview) {
                pos = gtk_scrolled_window_get_vadjustment(
                                        GTK_SCROLLED_WINDOW(folderview->scrolledwin));
-               height = pos->value;
+               height = gtk_adjustment_get_value(pos);
        }
 
        folder_set_ui_func(folder, folderview_scan_tree_func, NULL);
@@ -1100,47 +1107,6 @@ void folderview_rescan_tree(Folder *folder, gboolean rebuild)
        inc_unlock();
 }
 
-void folderview_fast_rescan_tree(Folder *folder)
-{
-       GtkWidget *window;
-       MainWindow *mainwin = mainwindow_get_mainwindow();
-       FolderView *folderview = NULL;
-       GtkAdjustment *pos = NULL;
-       gint height = 0;
-
-       cm_return_if_fail(folder != NULL);
-
-       if (!folder->klass->scan_tree) return;
-
-       inc_lock();
-
-       window = label_window_create(_("Scanning folder tree..."));
-
-       if (mainwin)
-               folderview = mainwin->folderview;
-       
-       if (folderview) {
-               pos = gtk_scrolled_window_get_vadjustment(
-                                       GTK_SCROLLED_WINDOW(folderview->scrolledwin));
-               height = pos->value;
-       }
-
-       folder_set_ui_func(folder, folderview_scan_tree_func, NULL);
-       folder_fast_scan_tree(folder);
-       folder_set_ui_func(folder, NULL, NULL);
-
-       folderview_set_all();
-
-       if (folderview) {
-               pos = gtk_scrolled_window_get_vadjustment(
-                                       GTK_SCROLLED_WINDOW(folderview->scrolledwin));
-               gtk_adjustment_set_value(pos, height);
-               gtk_adjustment_changed(pos);
-       }
-       label_window_destroy(window);
-       inc_unlock();
-}
-
 /** folderview_check_new()
  *  Scan and update the folder and return the 
  *  count the number of new messages since last check. 
@@ -1468,7 +1434,7 @@ static void folderview_update_node(FolderView *folderview, GtkCMCTreeNode *node)
        }
        switch (stype) {
        case F_INBOX:
-               if (item->hide_read_msgs) {
+               if (item->hide_read_msgs || item->hide_read_threads) {
                        xpm = mark?m_inboxhrmxpm:inboxhrmxpm;
                        openxpm = mark?m_inboxopenhrmxpm:inboxopenhrmxpm;
                } else {
@@ -1477,7 +1443,7 @@ static void folderview_update_node(FolderView *folderview, GtkCMCTreeNode *node)
                }
                break;
        case F_OUTBOX:
-               if (item->hide_read_msgs) {
+               if (item->hide_read_msgs || item->hide_read_threads) {
                        xpm = mark?m_outboxhrmxpm:outboxhrmxpm;
                        openxpm = mark?m_outboxopenhrmxpm:outboxopenhrmxpm;
                } else {
@@ -1486,7 +1452,7 @@ static void folderview_update_node(FolderView *folderview, GtkCMCTreeNode *node)
                }
                break;
        case F_QUEUE:
-               if (item->hide_read_msgs) {
+               if (item->hide_read_msgs || item->hide_read_threads) {
                        xpm = mark?m_queuehrmxpm:queuehrmxpm;
                        openxpm = mark?m_queueopenhrmxpm:queueopenhrmxpm;
                } else {
@@ -1495,7 +1461,7 @@ static void folderview_update_node(FolderView *folderview, GtkCMCTreeNode *node)
                }
                break;
        case F_TRASH:
-               if (item->hide_read_msgs) {
+               if (item->hide_read_msgs || item->hide_read_threads) {
                        xpm = mark?m_trashhrmxpm:trashhrmxpm;
                        openxpm = mark?m_trashopenhrmxpm:trashopenhrmxpm;
                } else {
@@ -1508,7 +1474,7 @@ static void folderview_update_node(FolderView *folderview, GtkCMCTreeNode *node)
                openxpm = mark?m_draftsopenxpm:draftsopenxpm;
                break;
        default:
-               if (item->hide_read_msgs) {
+               if (item->hide_read_msgs || item->hide_read_threads) {
                        xpm = mark?m_folderhrmxpm:folderhrmxpm;
                        openxpm = mark?m_folderopenhrmxpm:folderopenhrmxpm;
                } else {
@@ -1596,7 +1562,7 @@ static void folderview_update_node(FolderView *folderview, GtkCMCTreeNode *node)
                        str = g_strdup_printf("%s", name);
                }
        }
-       gtk_sctree_set_node_info(ctree, node, str, FOLDER_SPACING,
+       gtk_cmctree_set_node_info(ctree, node, str, FOLDER_SPACING,
                                xpm, openxpm, 
                                FALSE, GTK_CMCTREE_ROW(node)->expanded);
        g_free(str);
@@ -1613,12 +1579,21 @@ static void folderview_update_node(FolderView *folderview, GtkCMCTreeNode *node)
        }
 
        if (folder_has_parent_of_type(item, F_OUTBOX) ||
-           folder_has_parent_of_type(item, F_DRAFT) ||
            folder_has_parent_of_type(item, F_TRASH)) {
                use_bold = use_color = FALSE;
        } else if (folder_has_parent_of_type(item, F_QUEUE)) {
-               /* highlight queue folder if there are any messages */
-               use_bold = use_color = (item->total_msgs > 0);
+               GSList *list = folder_item_get_msg_list(item);
+               GSList *cur;
+               use_bold = use_color = FALSE;
+               for (cur = list; cur; cur = cur->next) {
+                       MsgInfo *msginfo = (MsgInfo *)cur->data;
+                       if (!MSG_IS_DELETED(msginfo->flags)) {
+                               /* highlight queue folder if there are any messages */
+                               use_bold = use_color = TRUE;
+                               break;
+                       }
+               }
+               procmsg_msg_list_free(list);
        } else {
                /* if unread messages exist, print with bold font */
                use_bold = (item->unread_msgs > 0|| item->new_msgs > 0) 
@@ -1683,7 +1658,7 @@ void folderview_update_search_icon(FolderItem *item, gboolean matches)
                ctree = GTK_CMCTREE(folderview->ctree);
 
                node = gtk_cmctree_find_by_row_data(ctree, NULL, item);
-               if (node) {
+               if (node && item->search_match != matches) {
                        item->search_match = matches;
                        folderview_update_node(folderview, node);
                }
@@ -1711,7 +1686,7 @@ static gboolean folderview_update_item_claws(gpointer source, gpointer data)
                if ((update_info->update_flags & F_ITEM_UPDATE_CONTENT) && 
                     update_info->item == folderview->summaryview->folder_item &&
                     update_info->item != NULL)
-                       if (!quicksearch_is_active(folderview->summaryview->quicksearch))
+                       if (!quicksearch_has_sat_predicate(folderview->summaryview->quicksearch))
                                summary_show(folderview->summaryview, update_info->item);
        }
        
@@ -2011,10 +1986,10 @@ static gboolean folderview_key_pressed(GtkWidget *widget, GdkEventKey *event,
                return FALSE;
 
        switch (event->keyval) {
-       case GDK_Right:
+       case GDK_KEY_Right:
 #ifndef GENERIC_UMPC
-       case GDK_Return:
-       case GDK_KP_Enter:
+       case GDK_KEY_Return:
+       case GDK_KEY_KP_Enter:
 #endif
                if (folderview->selected) {
                        folderview_select_node(folderview,
@@ -2022,7 +1997,7 @@ static gboolean folderview_key_pressed(GtkWidget *widget, GdkEventKey *event,
                }
                break;
 #ifdef GENERIC_UMPC
-       case GDK_Return:
+       case GDK_KEY_Return:
                if (folderview->selected && GTK_CMCTREE_ROW(folderview->selected)->children) {
                        gtk_cmctree_toggle_expansion(
                                GTK_CMCTREE(folderview->ctree),
@@ -2030,7 +2005,7 @@ static gboolean folderview_key_pressed(GtkWidget *widget, GdkEventKey *event,
                }
                break;  
 #endif
-       case GDK_space:
+       case GDK_KEY_space:
                BREAK_ON_MODIFIER_KEY();
                if (folderview->selected) {
                        if (folderview->opened == folderview->selected &&
@@ -2061,6 +2036,8 @@ static gboolean postpone_select(void *data)
 {
        PostponedSelectData *psdata = (PostponedSelectData *)data;
        debug_print("trying again\n");
+
+       psdata->folderview->postpone_select_id = 0;
        psdata->folderview->open_folder = TRUE;
        main_window_cursor_normal(psdata->folderview->mainwin);
        STATUSBAR_POP(psdata->folderview->mainwin);
@@ -2078,7 +2055,7 @@ void folderview_close_opened(FolderView *folderview)
                olditem = gtk_cmctree_node_get_row_data(GTK_CMCTREE(folderview->ctree), 
                                                      folderview->opened);
                if (olditem) {
-                       gchar *buf = g_strdup_printf(_("Closing Folder %s..."), 
+                       gchar *buf = g_strdup_printf(_("Closing folder %s..."), 
                                olditem->path ? olditem->path:olditem->name);
                        /* will be null if we just moved the previously opened folder */
                        STATUSBAR_PUSH(folderview->mainwin, buf);
@@ -2165,7 +2142,7 @@ static void folderview_selected(GtkCMCTree *ctree, GtkCMCTreeNode *row,
                gtk_cmctree_expand(ctree, row);
 
        /* ungrab the mouse event */
-       if (GTK_WIDGET_HAS_GRAB(ctree)) {
+       if (gtk_widget_has_grab(GTK_WIDGET(ctree))) {
                gtk_grab_remove(GTK_WIDGET(ctree));
                if (gdk_pointer_is_grabbed())
                        gdk_pointer_ungrab(GDK_CURRENT_TIME);
@@ -2173,7 +2150,7 @@ static void folderview_selected(GtkCMCTree *ctree, GtkCMCTreeNode *row,
 
        /* Open Folder */
        /* TODO: wwp: avoid displaying (null) in the status bar */
-       buf = g_strdup_printf(_("Opening Folder %s..."), item->path ? 
+       buf = g_strdup_printf(_("Opening folder %s..."), item->path ? 
                                        item->path : "(null)");
        debug_print("%s\n", buf);
        STATUSBAR_PUSH(folderview->mainwin, buf);
@@ -2207,7 +2184,9 @@ static void folderview_selected(GtkCMCTree *ctree, GtkCMCTreeNode *row,
                        item->path ? item->path:item->name);
                folderview->open_folder = FALSE;
                can_select = TRUE;
-               g_timeout_add(500, postpone_select, data);
+               if (folderview->postpone_select_id != 0)
+                       g_source_remove(folderview->postpone_select_id);
+               folderview->postpone_select_id = g_timeout_add(500, postpone_select, data);
                END_TIMING();
                return;
        }
@@ -2471,9 +2450,7 @@ static void folderview_recollapse_nodes(FolderView *folderview, GtkCMCTreeNode *
 void folderview_move_folder(FolderView *folderview, FolderItem *from_folder,
                            FolderItem *to_folder, gboolean copy)
 {
-       FolderItem *from_parent = NULL;
        FolderItem *new_folder = NULL;
-       GtkCMCTreeNode *src_node = NULL;
        gchar *buf;
        gint status;
 
@@ -2481,12 +2458,9 @@ void folderview_move_folder(FolderView *folderview, FolderItem *from_folder,
        cm_return_if_fail(from_folder != NULL);
        cm_return_if_fail(to_folder != NULL);
 
-       src_node = gtk_cmctree_find_by_row_data(GTK_CMCTREE(folderview->ctree), NULL, from_folder);
-       from_parent = folder_item_parent(from_folder);
-       
        if (prefs_common.warn_dnd) {
-               buf = g_strdup_printf(copy ? _("Do you really want to copy folder '%s' in '%s' ?"):
-                                            _("Do you really want to make folder '%s' a subfolder of '%s' ?"), 
+               buf = g_strdup_printf(copy ? _("Do you really want to copy folder '%s' in '%s'?"):
+                                            _("Do you really want to make folder '%s' a subfolder of '%s'?"), 
                                        from_folder->name, to_folder->name);
                status = alertpanel_full(copy ? _("Copy folder"):_("Move folder"), buf,
                                         GTK_STOCK_NO, GTK_STOCK_YES, NULL, TRUE,
@@ -2621,7 +2595,7 @@ static gchar *last_normalfont = NULL;
 static gchar *last_boldfont = NULL;
 static gboolean last_derive = 0;
 
-void folderview_reflect_prefs_pixmap_theme(FolderView *folderview)
+void folderview_reinit_fonts(FolderView *folderview)
 {
        /* force reinit */
        g_free(last_smallfont);
@@ -2639,7 +2613,7 @@ void folderview_reflect_prefs(void)
        FolderItem *item = folderview_get_selected_item(folderview);
        GtkAdjustment *pos = gtk_scrolled_window_get_vadjustment(
                                GTK_SCROLLED_WINDOW(folderview->scrolledwin));
-       gint height = pos->value;
+       gint height = gtk_adjustment_get_value(pos);
 
        if (!last_smallfont || strcmp(last_smallfont, SMALL_FONT) ||
                        !last_normalfont || strcmp(last_normalfont, NORMAL_FONT) ||
@@ -2691,13 +2665,13 @@ void folderview_reflect_prefs(void)
 
 static void drag_state_stop(FolderView *folderview)
 {
-       if (folderview->drag_timer)
-               g_source_remove(folderview->drag_timer);
-       folderview->drag_timer = 0;
+       if (folderview->drag_timer_id)
+               g_source_remove(folderview->drag_timer_id);
+       folderview->drag_timer_id = 0;
        folderview->drag_node = NULL;
 }
 
-static gint folderview_defer_expand(FolderView *folderview)
+static gboolean folderview_defer_expand(FolderView *folderview)
 {
        if (folderview->drag_node) {
                folderview_recollapse_nodes(folderview, folderview->drag_node);
@@ -2708,7 +2682,7 @@ static gint folderview_defer_expand(FolderView *folderview)
                }
        }
        folderview->drag_item  = NULL;
-       folderview->drag_timer = 0;
+       folderview->drag_timer_id = 0;
        return FALSE;
 }
 
@@ -2719,9 +2693,9 @@ static void drag_state_start(FolderView *folderview, GtkCMCTreeNode *node, Folde
         * we need to call drag_state_stop() */
        drag_state_stop(folderview);
        /* request expansion */
-       if (0 != (folderview->drag_timer = g_timeout_add
+       if (0 != (folderview->drag_timer_id = g_timeout_add
                        (prefs_common.hover_timeout, 
-                        (GtkFunction)folderview_defer_expand,
+                        (GSourceFunc)folderview_defer_expand,
                         folderview))) {
                folderview->drag_node = node;
                folderview->drag_item = item;
@@ -2762,7 +2736,7 @@ static void folderview_drag_data_get(GtkWidget        *widget,
                        if (item) {
                                source = g_strdup_printf ("FROM_OTHER_FOLDER%s", folder_item_get_identifier(item));
                                gtk_selection_data_set(selection_data,
-                                                      selection_data->target, 8,
+                                                      gtk_selection_data_get_target(selection_data), 8,
                                                       source, strlen(source));
                                break;
                        } else
@@ -2810,6 +2784,30 @@ static gboolean folderview_update_folder(gpointer source, gpointer userdata)
        return FALSE;
 }
 
+static gboolean folderview_dnd_scroll_cb(gpointer data)
+{
+       FolderView *folderview = (FolderView *)data;
+       GtkAdjustment *pos = gtk_scrolled_window_get_vadjustment(
+                               GTK_SCROLLED_WINDOW(folderview->scrolledwin));
+       gint new_val = (int)gtk_adjustment_get_value(pos) + folderview->scroll_value;
+       gint max = (int)gtk_adjustment_get_upper(pos) -
+               (int)gtk_adjustment_get_page_size(pos);
+
+       if (folderview->scroll_value == 0) {
+               folderview->scroll_timeout_id = 0;
+               return FALSE;
+       }
+
+       if (folderview->scroll_value > 0 && new_val > max) {
+               new_val = max;
+       } else if (folderview->scroll_value < 0 && new_val < 0) {
+               new_val = 0;
+       }
+       gtk_adjustment_set_value(pos, new_val);
+       
+       return TRUE;
+}
+
 static gboolean folderview_drag_motion_cb(GtkWidget      *widget,
                                          GdkDragContext *context,
                                          gint            x,
@@ -2823,22 +2821,29 @@ static gboolean folderview_drag_motion_cb(GtkWidget      *widget,
        gboolean acceptable = FALSE;
        GtkAdjustment *pos = gtk_scrolled_window_get_vadjustment(
                                GTK_SCROLLED_WINDOW(folderview->scrolledwin));
-       int height = (int)pos->page_size;
-       int total_height = (int)pos->upper;
-       int vpos = (int) pos->value;
+       int height = (int)gtk_adjustment_get_page_size(pos);
+       int total_height = (int)gtk_adjustment_get_upper(pos);
+       int vpos = (int)gtk_adjustment_get_value(pos);
        int offset = prefs_common.show_col_headers ? 24:0;
-       
+       int dist;
+
        if (gtk_cmclist_get_selection_info
                (GTK_CMCLIST(widget), x - offset, y - offset, &row, &column)) {
                GtkWidget *srcwidget;
 
-               if (y > height - 24 && height + vpos < total_height) {
-                       gtk_adjustment_set_value(pos, (vpos+5 > total_height ? total_height : vpos+5));
-                       gtk_adjustment_changed(pos);
+               if (y > height - (48 - offset) && height + vpos < total_height) {
+                       dist = -(height - (48 - offset) - y);
+                       folderview->scroll_value = 1.41f * (1+(dist / 6));
+               } else if (y < 72 - (24 - offset) && y >= 0) {
+                       dist = 72 - (24 - offset) - y;
+                       folderview->scroll_value = -1.41f * (1+(dist / 6));
+               } else {
+                       folderview->scroll_value = 0;
                }
-               if (y < 48 && y > 0) {
-                       gtk_adjustment_set_value(pos, (vpos-5 < 0 ? 0 : vpos-5));
-                       gtk_adjustment_changed(pos);
+               if (folderview->scroll_value != 0 && folderview->scroll_timeout_id == 0) {
+                       folderview->scroll_timeout_id = 
+                               g_timeout_add(30, folderview_dnd_scroll_cb,
+                                             folderview);
                }
 
                node = gtk_cmctree_node_nth(GTK_CMCTREE(widget), row);
@@ -2887,7 +2892,7 @@ static gboolean folderview_drag_motion_cb(GtkWidget      *widget,
                        (G_OBJECT(widget),
                         G_CALLBACK(folderview_selected), folderview);
                gdk_drag_status(context, 
-                                       (context->actions == GDK_ACTION_COPY ?
+                                       (gdk_drag_context_get_actions(context) == GDK_ACTION_COPY ?
                                        GDK_ACTION_COPY : GDK_ACTION_MOVE) , time);
        } else {
                if (folderview->opened)
@@ -2904,6 +2909,7 @@ static void folderview_drag_leave_cb(GtkWidget      *widget,
                                     FolderView     *folderview)
 {
        drag_state_stop(folderview);
+       folderview->scroll_value = 0;
        gtk_cmctree_select(GTK_CMCTREE(widget), folderview->opened);
 }
 
@@ -2970,9 +2976,12 @@ static void folderview_drag_received_cb(GtkWidget        *widget,
        GtkCMCTreeNode *node;
        int offset = prefs_common.show_col_headers ? 24:0;
 
+       folderview->scroll_value = 0;
+
        if (info == TARGET_DUMMY) {
                drag_state_stop(folderview);
-               if ((void *)strstr(data->data, "FROM_OTHER_FOLDER") != (void *)data->data) {
+               const gchar *ddata = (const gchar *)gtk_selection_data_get_data(data);
+               if ((gchar *)strstr(ddata, "FROM_OTHER_FOLDER") != ddata) {
                        /* comes from summaryview */
                        if (gtk_cmclist_get_selection_info
                                (GTK_CMCLIST(widget), x - offset, y - offset, &row, &column) == 0)
@@ -2993,7 +3002,7 @@ static void folderview_drag_received_cb(GtkWidget        *widget,
                                return;
                        }
                        if (item && src_item) {
-                               switch (drag_context->action) {
+                               switch (gdk_drag_context_get_selected_action(drag_context)) {
                                case GDK_ACTION_COPY:
                                        summary_copy_selected_to(folderview->summaryview, item);
                                        gtk_drag_finish(drag_context, TRUE, FALSE, time);
@@ -3013,9 +3022,10 @@ static void folderview_drag_received_cb(GtkWidget        *widget,
                        /* comes from folderview */
                        char *source;
                        gboolean folder_is_normal = TRUE;
-                       gboolean copy = (drag_context->action == GDK_ACTION_COPY);
+                       gboolean copy = (GDK_ACTION_COPY ==
+                               gdk_drag_context_get_selected_action(drag_context));
 
-                       source = data->data + 17;
+                       source = (char *)gtk_selection_data_get_data(data) + 17;
                        if (gtk_cmclist_get_selection_info
                            (GTK_CMCLIST(widget), x - offset, y - offset, &row, &column) == 0
                            || *source == 0) {
@@ -3059,7 +3069,8 @@ static void folderview_drag_received_cb(GtkWidget        *widget,
                        debug_print("no item\n");
                        return;
                }
-               folderview_finish_dnd(data->data, drag_context, time, item);
+               folderview_finish_dnd(gtk_selection_data_get_data(data),
+                       drag_context, time, item);
        }
 }
 
@@ -3068,6 +3079,7 @@ static void folderview_drag_end_cb(GtkWidget          *widget,
                                    FolderView      *folderview)
 {
        drag_state_stop(folderview);
+       folderview->scroll_value = 0;
        g_slist_free(folderview->nodes_to_recollapse);
        folderview->nodes_to_recollapse = NULL;
 }