2004-11-09 [colin] 0.9.12cvs144.1
[claws.git] / src / folder.c
index af8abe5b1e91209edb43039fd5a7039a6f9851e6..f50b6d784a97fd74a0f217b185af64552d7c3244 100644 (file)
@@ -236,18 +236,18 @@ XMLTag *folder_get_xml(Folder *folder)
 {
        XMLTag *tag;
 
-       tag = xml_new_tag("folder");
+       tag = xml_tag_new("folder");
 
        if (folder->name)
-               xml_tag_add_attr(tag, "name", g_strdup(folder->name));
+               xml_tag_add_attr(tag, xml_attr_new("name", folder->name));
        if (folder->account)
-               xml_tag_add_attr(tag, "account_id", g_strdup_printf("%d", folder->account->account_id));
+               xml_tag_add_attr(tag, xml_attr_new_int("account_id", folder->account->account_id));
        if (folder->node && folder->node->data) {
                FolderItem *rootitem = (FolderItem *) folder->node->data;
 
-               xml_tag_add_attr(tag, "collapsed", g_strdup(rootitem->collapsed ? "1" : "0"));
+               xml_tag_add_attr(tag, xml_attr_new("collapsed", rootitem->collapsed ? "1" : "0"));
        }
-       xml_tag_add_attr(tag, "sort", g_strdup_printf("%d", folder->sort));
+       xml_tag_add_attr(tag, xml_attr_new_int("sort", folder->sort));
 
        return tag;
 }
@@ -413,17 +413,17 @@ void folder_item_set_xml(Folder *folder, FolderItem *item, XMLTag *tag)
 
                if (!attr || !attr->name || !attr->value) continue;
                if (!strcmp(attr->name, "type")) {
-                       if (!strcasecmp(attr->value, "normal"))
+                       if (!g_ascii_strcasecmp(attr->value, "normal"))
                                item->stype = F_NORMAL;
-                       else if (!strcasecmp(attr->value, "inbox"))
+                       else if (!g_ascii_strcasecmp(attr->value, "inbox"))
                                item->stype = F_INBOX;
-                       else if (!strcasecmp(attr->value, "outbox"))
+                       else if (!g_ascii_strcasecmp(attr->value, "outbox"))
                                item->stype = F_OUTBOX;
-                       else if (!strcasecmp(attr->value, "draft"))
+                       else if (!g_ascii_strcasecmp(attr->value, "draft"))
                                item->stype = F_DRAFT;
-                       else if (!strcasecmp(attr->value, "queue"))
+                       else if (!g_ascii_strcasecmp(attr->value, "queue"))
                                item->stype = F_QUEUE;
-                       else if (!strcasecmp(attr->value, "trash"))
+                       else if (!g_ascii_strcasecmp(attr->value, "trash"))
                                item->stype = F_TRASH;
                } else if (!strcmp(attr->name, "name")) {
                        if (item->name != NULL)
@@ -511,40 +511,43 @@ XMLTag *folder_item_get_xml(Folder *folder, FolderItem *item)
                                        "mark", "unread", "mime", "to", 
                                        "locked"};
        XMLTag *tag;
+       gchar *value;
 
-       tag = xml_new_tag("folderitem");
+       tag = xml_tag_new("folderitem");
 
-       xml_tag_add_attr(tag, "type", g_strdup(folder_item_stype_str[item->stype]));
+       xml_tag_add_attr(tag, xml_attr_new("type", folder_item_stype_str[item->stype]));
        if (item->name)
-               xml_tag_add_attr(tag, "name", g_strdup(item->name));
+               xml_tag_add_attr(tag, xml_attr_new("name", item->name));
        if (item->path)
-               xml_tag_add_attr(tag, "path", g_strdup(item->path));
+               xml_tag_add_attr(tag, xml_attr_new("path", item->path));
        if (item->no_sub)
-               xml_tag_add_attr(tag, "no_sub", g_strdup("1"));
+               xml_tag_add_attr(tag, xml_attr_new("no_sub", "1"));
        if (item->no_select)
-               xml_tag_add_attr(tag, "no_select", g_strdup("1"));
-       xml_tag_add_attr(tag, "collapsed", g_strdup(item->collapsed && item->node->children ? "1" : "0"));
-       xml_tag_add_attr(tag, "thread_collapsed", g_strdup(item->thread_collapsed ? "1" : "0"));
-       xml_tag_add_attr(tag, "threaded", g_strdup(item->threaded ? "1" : "0"));
-       xml_tag_add_attr(tag, "hidereadmsgs", g_strdup(item->hide_read_msgs ? "1" : "0"));
+               xml_tag_add_attr(tag, xml_attr_new("no_select", "1"));
+       xml_tag_add_attr(tag, xml_attr_new("collapsed", item->collapsed && item->node->children ? "1" : "0"));
+       xml_tag_add_attr(tag, xml_attr_new("thread_collapsed", item->thread_collapsed ? "1" : "0"));
+       xml_tag_add_attr(tag, xml_attr_new("threaded", item->threaded ? "1" : "0"));
+       xml_tag_add_attr(tag, xml_attr_new("hidereadmsgs", item->hide_read_msgs ? "1" : "0"));
        if (item->ret_rcpt)
-               xml_tag_add_attr(tag, "reqretrcpt", g_strdup("1"));
+               xml_tag_add_attr(tag, xml_attr_new("reqretrcpt", "1"));
 
        if (item->sort_key != SORT_BY_NONE) {
-               xml_tag_add_attr(tag, "sort_key", g_strdup(sort_key_str[item->sort_key]));
-               xml_tag_add_attr(tag, "sort_type", g_strdup(item->sort_type == SORT_ASCENDING ? "ascending" : "descending"));
+               xml_tag_add_attr(tag, xml_attr_new("sort_key", sort_key_str[item->sort_key]));
+               xml_tag_add_attr(tag, xml_attr_new("sort_type", item->sort_type == SORT_ASCENDING ? "ascending" : "descending"));
        }
 
-       xml_tag_add_attr(tag, "mtime", g_strdup_printf("%ld", (unsigned long int) item->mtime));
-       xml_tag_add_attr(tag, "new", g_strdup_printf("%d", item->new_msgs));
-       xml_tag_add_attr(tag, "unread", g_strdup_printf("%d", item->unread_msgs));
-       xml_tag_add_attr(tag, "unreadmarked", g_strdup_printf("%d", item->unreadmarked_msgs));
-       xml_tag_add_attr(tag, "total", g_strdup_printf("%d", item->total_msgs));
+       value = g_strdup_printf("%ld", (unsigned long int) item->mtime);
+       xml_tag_add_attr(tag, xml_attr_new("mtime", value));
+       g_free(value);
+       xml_tag_add_attr(tag, xml_attr_new_int("new", item->new_msgs));
+       xml_tag_add_attr(tag, xml_attr_new_int("unread", item->unread_msgs));
+       xml_tag_add_attr(tag, xml_attr_new_int("unreadmarked", item->unreadmarked_msgs));
+       xml_tag_add_attr(tag, xml_attr_new_int("total", item->total_msgs));
 
        if (item->account)
-               xml_tag_add_attr(tag, "account_id", g_strdup_printf("%d", item->account->account_id));
+               xml_tag_add_attr(tag, xml_attr_new_int("account_id", item->account->account_id));
        if (item->apply_sub)
-               xml_tag_add_attr(tag, "apply_sub", g_strdup("1"));
+               xml_tag_add_attr(tag, xml_attr_new("apply_sub", "1"));
 
        return tag;
 }
@@ -701,13 +704,10 @@ void folder_write_list(void)
        path = folder_get_list_path();
        if ((pfile = prefs_write_open(path)) == NULL) return;
 
-       fprintf(pfile->fp, "<?xml version=\"1.0\" encoding=\"%s\"?>\n",
-               conv_get_current_charset_str());
-       tag = xml_new_tag("folderlist");
+       xml_file_put_xml_decl(pfile->fp);
+       tag = xml_tag_new("folderlist");
 
-       xmlnode = g_new0(XMLNode, 1);
-       xmlnode->tag = tag;
-       xmlnode->element = NULL;
+       xmlnode = xml_node_new(tag, NULL);
 
        rootnode = g_node_new(xmlnode);
 
@@ -899,7 +899,7 @@ static gboolean folder_get_status_full_all_func(GNode *node, gpointer data)
 
        if (status->str) {
                id = folder_item_get_identifier(item);
-               g_string_sprintfa(status->str, "%5d %5d %5d %s\n",
+               g_string_append_printf(status->str, "%5d %5d %5d %s\n",
                                  item->new_msgs, item->unread_msgs,
                                  item->total_msgs, id);
                g_free(id);
@@ -958,7 +958,7 @@ gchar *folder_get_status(GPtrArray *folders, gboolean full)
                                gchar *id;
 
                                id = folder_item_get_identifier(item);
-                               g_string_sprintfa(str, "%5d %5d %5d %s\n",
+                               g_string_append_printf(str, "%5d %5d %5d %s\n",
                                                  item->new_msgs, item->unread_msgs,
                                                  item->total_msgs, id);
                                g_free(id);
@@ -970,9 +970,9 @@ gchar *folder_get_status(GPtrArray *folders, gboolean full)
        }
 
        if (full)
-               g_string_sprintfa(str, "%5d %5d %5d\n", new, unread, total);
+               g_string_append_printf(str, "%5d %5d %5d\n", new, unread, total);
        else
-               g_string_sprintfa(str, "%d %d %d\n", new, unread, total);
+               g_string_append_printf(str, "%d %d %d\n", new, unread, total);
 
        ret = str->str;
        g_string_free(str, FALSE);
@@ -1077,7 +1077,7 @@ FolderClass *folder_get_class_from_string(const gchar *str)
        classlist = folder_get_class_list();
        for (; classlist != NULL; classlist = g_slist_next(classlist)) {
                FolderClass *class = (FolderClass *) classlist->data;
-               if (g_strcasecmp(class->idstr, str) == 0)
+               if (g_ascii_strcasecmp(class->idstr, str) == 0)
                        return class;
        }
 
@@ -1096,8 +1096,8 @@ gchar *folder_get_identifier(Folder *folder)
 
 gchar *folder_item_get_identifier(FolderItem *item)
 {
-       gchar *id;
-       gchar *folder_id;
+       gchar *id = NULL;
+       gchar *folder_id = NULL;
 
        g_return_val_if_fail(item != NULL, NULL);
        g_return_val_if_fail(item->path != NULL, NULL);
@@ -1403,7 +1403,6 @@ void folder_item_set_default_flags(FolderItem *dest, MsgFlags *flags)
        } else {
                flags->perm_flags = 0;
        }
-       flags->tmp_flags = MSG_CACHED;
        if (FOLDER_TYPE(dest->folder) == F_MH) {
                if (dest->stype == F_QUEUE) {
                        MSG_SET_TMP_FLAGS(*flags, MSG_QUEUED);
@@ -1487,40 +1486,10 @@ gint folder_item_close(FolderItem *item)
        return folder->klass->close(folder, item);
 }
 
-static void msginfo_set_mime_flags(GNode *node, gpointer data)
-{
-       MsgInfo *msginfo = data;
-       MimeInfo *mimeinfo = node->data;
-
-       if (mimeinfo->disposition == DISPOSITIONTYPE_ATTACHMENT) {
-               MSG_SET_TMP_FLAGS(msginfo->flags, MSG_HAS_ATTACHMENT);
-       } else if (mimeinfo->disposition == DISPOSITIONTYPE_UNKNOWN && 
-                mimeinfo->type != MIMETYPE_TEXT &&
-                mimeinfo->type != MIMETYPE_MULTIPART) {
-               MSG_SET_TMP_FLAGS(msginfo->flags, MSG_HAS_ATTACHMENT)
-       }
-
-       /* don't descend below top level message for signed and encrypted info */
-       if (mimeinfo->type == MIMETYPE_MESSAGE)
-               return;
-
-       if (privacy_mimeinfo_is_signed(mimeinfo)) {
-               MSG_SET_TMP_FLAGS(msginfo->flags, MSG_SIGNED);
-       }
-
-       if (privacy_mimeinfo_is_encrypted(mimeinfo)) {
-               MSG_SET_TMP_FLAGS(msginfo->flags, MSG_ENCRYPTED);
-       } else {
-               /* searching inside encrypted parts doesn't really make sense */
-               g_node_children_foreach(mimeinfo->node, G_TRAVERSE_ALL, msginfo_set_mime_flags, msginfo);
-       }
-}
-
 static MsgInfoList *get_msginfos(FolderItem *item, MsgNumberList *numlist)
 {
        MsgInfoList *msglist = NULL;
        Folder *folder = item->folder;
-       MsgInfoList *elem;
 
        if (folder->klass->get_msginfos != NULL)
                msglist = folder->klass->get_msginfos(folder, item, numlist);
@@ -1538,19 +1507,6 @@ static MsgInfoList *get_msginfos(FolderItem *item, MsgNumberList *numlist)
                }               
        }
 
-       for (elem = msglist; elem != NULL; elem = g_slist_next(elem)) {
-               MsgInfo *msginfo = elem->data;
-
-               if (MSG_IS_MULTIPART(msginfo->flags)) {
-                       MimeInfo *mimeinfo;
-
-                       mimeinfo = procmime_scan_message(msginfo);
-                       g_node_children_foreach(mimeinfo->node, G_TRAVERSE_ALL, msginfo_set_mime_flags, msginfo);
-                       procmime_mimeinfo_free_all(mimeinfo);
-                       /* check for attachments */
-               }
-       }
-
        return msglist;
 }
 
@@ -1570,6 +1526,50 @@ static MsgInfo *get_msginfo(FolderItem *item, guint num)
        return msginfo;
 }
 
+static gint syncronize_flags(FolderItem *item, MsgInfoList *msglist)
+{
+       GRelation *relation;
+       gint ret = 0;
+       GSList *cur;
+
+       if(msglist == NULL)
+               return 0;
+       if(item->folder->klass->get_flags == NULL)
+               return 0;
+
+       relation = g_relation_new(2);
+       g_relation_index(relation, 0, g_direct_hash, g_direct_equal);
+       if ((ret = item->folder->klass->get_flags(
+           item->folder, item, msglist, relation)) == 0) {
+               GTuples *tuples;
+               MsgInfo *msginfo;
+               MsgPermFlags permflags;
+               gboolean skip;
+
+               for (cur = msglist; cur != NULL; cur = g_slist_next(cur)) {
+                       msginfo = (MsgInfo *) cur->data;
+               
+                       tuples = g_relation_select(relation, msginfo, 0);
+                       skip = tuples->len < 1;
+                       if (!skip)
+                               permflags = GPOINTER_TO_INT(g_tuples_index(tuples, 0, 1));
+                       g_tuples_destroy(tuples);
+                       if (skip)
+                               continue;
+                       
+                       if (msginfo->flags.perm_flags != permflags) {
+                               procmsg_msginfo_set_flags(msginfo,
+                                       permflags & ~msginfo->flags.perm_flags, 0);
+                               procmsg_msginfo_unset_flags(msginfo,
+                                       ~permflags & msginfo->flags.perm_flags, 0);
+                       }
+               }
+       }
+       g_relation_destroy(relation);   
+
+       return ret;
+}
+
 gint folder_item_scan_full(FolderItem *item, gboolean filtering)
 {
        Folder *folder;
@@ -1580,30 +1580,21 @@ gint folder_item_scan_full(FolderItem *item, gboolean filtering)
        guint newcnt = 0, unreadcnt = 0, totalcnt = 0, unreadmarkedcnt = 0;
        guint cache_max_num, folder_max_num, cache_cur_num, folder_cur_num;
        gboolean update_flags = 0, old_uids_valid = FALSE;
-       gint err = -1;
-#ifdef USE_GPGME
-       gint old_auto_check = 0;
-       old_auto_check = prefs_common.auto_check_signatures;
-       prefs_common.auto_check_signatures = 0;
-#endif
-       if (item == NULL)
-               goto bail_scan;
-       if (item->path == NULL)
-               goto bail_scan;
+    
+       g_return_val_if_fail(item != NULL, -1);
+       if (item->path == NULL) return -1;
 
        folder = item->folder;
 
-       if (folder == NULL)
-               goto bail_scan;
-       if (folder->klass->get_num_list == NULL)
-               goto bail_scan;
+       g_return_val_if_fail(folder != NULL, -1);
+       g_return_val_if_fail(folder->klass->get_num_list != NULL, -1);
 
        debug_print("Scanning folder %s for cache changes.\n", item->path);
 
        /* Get list of messages for folder and cache */
        if (folder->klass->get_num_list(item->folder, item, &folder_list, &old_uids_valid) < 0) {
                debug_print("Error fetching list of message numbers\n");
-               goto bail_scan;
+               return(-1);
        }
 
        if (old_uids_valid) {
@@ -1757,6 +1748,8 @@ gint folder_item_scan_full(FolderItem *item, gboolean filtering)
                g_slist_free(new_list);
        }
 
+       syncronize_flags(item, exists_list);
+
        folder_item_update_freeze();
        if (newmsg_list != NULL) {
                GSList *elem;
@@ -1816,66 +1809,8 @@ gint folder_item_scan_full(FolderItem *item, gboolean filtering)
 
        folder_item_update(item, update_flags);
        folder_item_update_thaw();
-       err = 0;
-bail_scan:
-#ifdef USE_GPGME
-       prefs_common.auto_check_signatures = old_auto_check;
-#endif
-       return err;
-}
 
-gint folder_item_syncronize_flags(FolderItem *item)
-{
-       MsgInfoList *msglist = NULL;
-       GSList *cur;
-       GRelation *relation;
-       gint ret = 0;
-       
-       g_return_val_if_fail(item != NULL, -1);
-       g_return_val_if_fail(item->folder != NULL, -1);
-       g_return_val_if_fail(item->folder->klass != NULL, -1);
-       if(item->folder->klass->get_flags == NULL)
-               return 0;
-       
-       if (item->cache == NULL)
-               folder_item_read_cache(item);
-       
-       msglist = msgcache_get_msg_list(item->cache);
-       
-       relation = g_relation_new(2);
-       g_relation_index(relation, 0, g_direct_hash, g_direct_equal);
-       if ((ret = item->folder->klass->get_flags(
-           item->folder, item, msglist, relation)) == 0) {
-               GTuples *tuples;
-               MsgInfo *msginfo;
-               MsgPermFlags permflags;
-               gboolean skip;
-
-               for (cur = msglist; cur != NULL; cur = g_slist_next(cur)) {
-                       msginfo = (MsgInfo *) cur->data;
-               
-                       tuples = g_relation_select(relation, msginfo, 0);
-                       skip = tuples->len < 1;
-                       if (!skip)
-                               permflags = GPOINTER_TO_INT(g_tuples_index(tuples, 0, 1));
-                       g_tuples_destroy(tuples);
-                       if (skip)
-                               continue;
-                       
-                       if (msginfo->flags.perm_flags != permflags) {
-                               procmsg_msginfo_set_flags(msginfo,
-                                       permflags & ~msginfo->flags.perm_flags, 0);
-                               procmsg_msginfo_unset_flags(msginfo,
-                                       ~permflags & msginfo->flags.perm_flags, 0);
-                       }
-               }
-       }
-       g_relation_destroy(relation);
-       
-       for (cur = msglist; cur != NULL; cur = g_slist_next(cur))
-               procmsg_msginfo_free((MsgInfo *) cur->data);
-       
-       return ret;
+       return 0;
 }
 
 gint folder_item_scan(FolderItem *item)
@@ -1919,6 +1854,29 @@ void folder_count_total_cache_memusage(FolderItem *item, gpointer data)
        *memusage += msgcache_get_memory_usage(item->cache);
 }
 
+gint folder_item_syncronize_flags(FolderItem *item)
+{
+       MsgInfoList *msglist = NULL;
+       GSList *cur;
+       gint ret = 0;
+       
+       g_return_val_if_fail(item != NULL, -1);
+       g_return_val_if_fail(item->folder != NULL, -1);
+       g_return_val_if_fail(item->folder->klass != NULL, -1);
+       
+       if (item->cache == NULL)
+               folder_item_read_cache(item);
+       
+       msglist = msgcache_get_msg_list(item->cache);
+       
+       ret = syncronize_flags(item, msglist);
+
+       for (cur = msglist; cur != NULL; cur = g_slist_next(cur))
+               procmsg_msginfo_free((MsgInfo *) cur->data);
+       
+       return ret;
+}
+
 gint folder_cache_time_compare_func(gconstpointer a, gconstpointer b)
 {
        FolderItem *fa = (FolderItem *)a;
@@ -1998,10 +1956,33 @@ void folder_item_read_cache(FolderItem *item)
                mark_file = folder_item_get_mark_file(item);
                item->cache = msgcache_read_cache(item, cache_file);
                if (!item->cache) {
+                       MsgInfoList *list, *cur;
+                       guint newcnt = 0, unreadcnt = 0, unreadmarkedcnt = 0;
+                       MsgInfo *msginfo;
+
                        item->cache = msgcache_new();
                        folder_item_scan_full(item, TRUE);
-               }
-               msgcache_read_mark(item->cache, mark_file);
+
+                       msgcache_read_mark(item->cache, mark_file);
+
+                       list = msgcache_get_msg_list(item->cache);
+                       for (cur = list; cur != NULL; cur = g_slist_next(cur)) {
+                               msginfo = cur->data;
+
+                               if (MSG_IS_NEW(msginfo->flags))
+                                       newcnt++;
+                               if (MSG_IS_UNREAD(msginfo->flags))
+                                       unreadcnt++;
+                               if (MSG_IS_UNREAD(msginfo->flags) && procmsg_msg_has_marked_parent(msginfo))
+                                       unreadmarkedcnt++;
+                       }
+                       item->new_msgs = newcnt;
+                       item->unread_msgs = unreadcnt;
+                       item->unreadmarked_msgs = unreadmarkedcnt;
+                       procmsg_msg_list_free(list);
+               } else
+                       msgcache_read_mark(item->cache, mark_file);
+
                g_free(cache_file);
                g_free(mark_file);
        } else {
@@ -2095,9 +2076,40 @@ GSList *folder_item_get_msg_list(FolderItem *item)
        return msgcache_get_msg_list(item->cache);
 }
 
+static void msginfo_set_mime_flags(GNode *node, gpointer data)
+{
+       MsgInfo *msginfo = data;
+       MimeInfo *mimeinfo = node->data;
+
+       if (mimeinfo->disposition == DISPOSITIONTYPE_ATTACHMENT) {
+               procmsg_msginfo_set_flags(msginfo, 0, MSG_HAS_ATTACHMENT);
+       } else if (mimeinfo->disposition == DISPOSITIONTYPE_UNKNOWN && 
+                mimeinfo->type != MIMETYPE_TEXT &&
+                mimeinfo->type != MIMETYPE_MULTIPART) {
+               procmsg_msginfo_set_flags(msginfo, 0, MSG_HAS_ATTACHMENT);
+       }
+
+       /* don't descend below top level message for signed and encrypted info */
+       if (mimeinfo->type == MIMETYPE_MESSAGE)
+               return;
+
+       if (privacy_mimeinfo_is_signed(mimeinfo)) {
+               procmsg_msginfo_set_flags(msginfo, 0, MSG_SIGNED);
+       }
+
+       if (privacy_mimeinfo_is_encrypted(mimeinfo)) {
+               procmsg_msginfo_set_flags(msginfo, 0, MSG_ENCRYPTED);
+       } else {
+               /* searching inside encrypted parts doesn't really make sense */
+               g_node_children_foreach(mimeinfo->node, G_TRAVERSE_ALL, msginfo_set_mime_flags, msginfo);
+       }
+}
+
 gchar *folder_item_fetch_msg(FolderItem *item, gint num)
 {
        Folder *folder;
+       gchar *msgfile;
+       MsgInfo *msginfo;
 
        g_return_val_if_fail(item != NULL, NULL);
 
@@ -2105,7 +2117,29 @@ gchar *folder_item_fetch_msg(FolderItem *item, gint num)
 
        g_return_val_if_fail(folder->klass->fetch_msg != NULL, NULL);
 
-       return folder->klass->fetch_msg(folder, item, num);
+       msgfile = folder->klass->fetch_msg(folder, item, num);
+
+       if (msgfile != NULL) {
+               msginfo = folder_item_get_msginfo(item, num);
+               if ((msginfo != NULL) && !MSG_IS_SCANNED(msginfo->flags)) {
+                       MimeInfo *mimeinfo;
+
+                       if (msginfo->folder->stype != F_QUEUE && 
+                           msginfo->folder->stype != F_DRAFT)
+                               mimeinfo = procmime_scan_file(msgfile);
+                       else
+                               mimeinfo = procmime_scan_queue_file(msgfile);
+                       /* check for attachments */
+                       if (mimeinfo != NULL) { 
+                               g_node_children_foreach(mimeinfo->node, G_TRAVERSE_ALL, msginfo_set_mime_flags, msginfo);
+                               procmime_mimeinfo_free_all(mimeinfo);
+
+                               procmsg_msginfo_set_flags(msginfo, 0, MSG_SCANNED);
+                       }
+               }
+       }
+
+       return msgfile;
 }
 
 gint folder_item_fetch_all_msg(FolderItem *item)
@@ -2397,12 +2431,7 @@ FolderItem *folder_item_move_recursive(FolderItem *src, FolderItem *dest)
        FolderItem *next_item;
        GNode *srcnode;
        gchar *old_id, *new_id;
-       gint err = 1;
-#ifdef USE_GPGME
-       gint old_auto_check = 0;
-       old_auto_check = prefs_common.auto_check_signatures;
-       prefs_common.auto_check_signatures = 0;
-#endif
+
        mlist = folder_item_get_msg_list(src);
 
        /* move messages */
@@ -2410,7 +2439,7 @@ FolderItem *folder_item_move_recursive(FolderItem *src, FolderItem *dest)
        new_item = folder_create_folder(dest, src->name);
        if (new_item == NULL) {
                printf("Can't create folder\n");
-               goto bail_move;
+               return NULL;
        }
        
        if (new_item->folder == NULL)
@@ -2443,7 +2472,7 @@ FolderItem *folder_item_move_recursive(FolderItem *src, FolderItem *dest)
                        next_item = (FolderItem*) srcnode->data;
                        srcnode = srcnode->next;
                        if (folder_item_move_recursive(next_item, new_item) == NULL)
-                               goto bail_move;
+                               return NULL;
                }
        }
        old_id = folder_item_get_identifier(src);
@@ -2459,17 +2488,8 @@ FolderItem *folder_item_move_recursive(FolderItem *src, FolderItem *dest)
                prefs_filtering_rename_path(old_id, new_id);
        g_free(old_id);
        g_free(new_id);
-       err = 0;
-
-bail_move:
-#ifdef USE_GPGME
-       prefs_common.auto_check_signatures = old_auto_check;
-#endif
 
-       if (err != 0)
-               return NULL;
-       else
-               return new_item;
+       return new_item;
 }
 
 gint folder_item_move_to(FolderItem *src, FolderItem *dest, FolderItem **new_item)
@@ -2601,7 +2621,7 @@ static gint do_copy_msgs(FolderItem *dest, GSList *msglist, gboolean remove_sour
                 g_tuples_destroy(tuples);
 
                if (num >= 0) {
-                       MsgInfo *newmsginfo;
+                       MsgInfo *newmsginfo = NULL;
 
                        if (folderscan) {
                                if (msginfo->msgid != NULL) {
@@ -2975,7 +2995,6 @@ static gchar *folder_get_list_path(void)
 static gpointer folder_item_to_xml(gpointer nodedata, gpointer data)
 {
        FolderItem *item = (FolderItem *) nodedata;
-       XMLNode *xmlnode;
        XMLTag *tag;
 
        g_return_val_if_fail(item != NULL, NULL);
@@ -2985,11 +3004,7 @@ static gpointer folder_item_to_xml(gpointer nodedata, gpointer data)
        else
                tag = folder_item_get_xml(item->folder, item);
 
-       xmlnode = g_new0(XMLNode, 1);
-       xmlnode->tag = tag;
-       xmlnode->element = NULL;
-
-       return xmlnode;
+       return xml_node_new(tag, NULL);;
 }
 
 static GNode *folder_get_xml_node(Folder *folder)
@@ -3005,11 +3020,9 @@ static GNode *folder_get_xml_node(Folder *folder)
        else
                tag = folder_get_xml(folder);
 
-       xml_tag_add_attr(tag, "type", g_strdup(folder->klass->idstr));
+       xml_tag_add_attr(tag, xml_attr_new("type", folder->klass->idstr));
 
-       xmlnode = g_new0(XMLNode, 1);
-       xmlnode->tag = tag;
-       xmlnode->element = NULL;
+       xmlnode = xml_node_new(tag, NULL);
 
        node = g_node_new(xmlnode);
        if (folder->node->children) {
@@ -3289,7 +3302,7 @@ static gint folder_item_update_freeze_cnt = 0;
 
 static void folder_item_update_with_msg(FolderItem *item, FolderItemUpdateFlags update_flags, MsgInfo *msg)
 {
-       if (folder_item_update_freeze_cnt == 0 || (msg != NULL && item->opened)) {
+       if (folder_item_update_freeze_cnt == 0 /* || (msg != NULL && item->opened) */) {
                FolderItemUpdateData source;
        
                source.item = item;