Fix CID 1491157: use after free.
[claws.git] / src / filtering.c
index b3eb8b54f30b63f50593c48b4c08771fc03e5ba3..9e1d98158dafb70c1cf38ad4ead978a5ca8beb60 100644 (file)
@@ -1,6 +1,6 @@
 /*
- * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2007 Hiroyuki Yamamoto & The Claws Mail Team
+ * Claws Mail -- a GTK+ based, lightweight, and fast e-mail client
+ * Copyright (C) 1999-2020 the Claws Mail Team and Hiroyuki Yamamoto
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -14,7 +14,6 @@
  *
  * You should have received a copy of the GNU General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
- * 
  */
 
 #include "defs.h"
 #include "prefs_gtk.h"
 #include "compose.h"
 #include "prefs_common.h"
-#include "addrbook.h"
+#include "addritem.h"
+#ifndef USE_ALT_ADDRBOOK
+       #include "addrbook.h"
+       #include "addressbook.h"
+#else
+       #include "addressbook-dbus.h"
+       #include "addressadd.h"
+#endif
 #include "addr_compl.h"
 #include "tags.h"
 #include "log.h"
-
-#define PREFSBUFSIZE           1024
+#include "account.h"
+#include "addrindex.h"
+#include "folder_item_prefs.h"
 
 GSList * pre_global_processing = NULL;
 GSList * post_global_processing = NULL;
@@ -49,19 +56,6 @@ gboolean debug_filtering_session = FALSE;
 
 static gboolean filtering_is_final_action(FilteringAction *filtering_action);
 
-#define STRLEN_WITH_CHECK(expr) \
-        strlen_with_check(#expr, __LINE__, expr)
-               
-static inline gint strlen_with_check(const gchar *expr, gint fline, const gchar *str)
-{
-        if (str) 
-               return strlen(str);
-       else {
-               debug_print("%s(%d) - invalid string %s\n", __FILE__, fline, expr?expr:"(null)");
-               return 0;
-       }
-}
-
 FilteringAction * filteringaction_new(int type, int account_id,
                                      gchar * destination,
                                      gint labelcolor, gint score, gchar * header)
@@ -89,12 +83,25 @@ FilteringAction * filteringaction_new(int type, int account_id,
 
 void filteringaction_free(FilteringAction * action)
 {
-       g_return_if_fail(action);
+       cm_return_if_fail(action);
        g_free(action->header);
        g_free(action->destination);
        g_free(action);
 }
 
+static gint action_list_sort(gconstpointer a, gconstpointer b)
+{
+       int first  = filtering_is_final_action((FilteringAction *) a) ? 1 : 0;
+       int second = filtering_is_final_action((FilteringAction *) b) ? 1 : 0;
+       
+       return (first - second);
+}
+
+GSList *filtering_action_list_sort(GSList *action_list)
+{
+       return g_slist_sort(action_list, action_list_sort);
+}
+
 FilteringProp * filteringprop_new(gboolean enabled,
                                  const gchar *name,
                                  gint account_id,
@@ -108,7 +115,7 @@ FilteringProp * filteringprop_new(gboolean enabled,
        filtering->name = name ? g_strdup(name): NULL;
        filtering->account_id = account_id;
        filtering->matchers = matchers;
-       filtering->action_list = action_list;
+       filtering->action_list = filtering_action_list_sort(action_list);
 
        return filtering;
 }
@@ -170,12 +177,13 @@ void filteringprop_free(FilteringProp * prop)
 {
         GSList * tmp;
 
-       g_return_if_fail(prop);
+       cm_return_if_fail(prop);
        matcherlist_free(prop->matchers);
         
         for (tmp = prop->action_list ; tmp != NULL ; tmp = tmp->next) {
                 filteringaction_free(tmp->data);
         }
+       g_slist_free(prop->action_list);
        g_free(prop->name);
        g_free(prop);
 }
@@ -229,7 +237,7 @@ void filtering_move_and_copy_msgs(GSList *msgs)
                } else {
                        debug_print("%d messages to %s in %s\n", found,
                                cur_op==IS_COPY ? "copy":(cur_op==IS_DELE ?"delete":"move"), 
-                               last_item?(last_item->name ? last_item->name:"(noname)"):"nowhere");
+                               last_item->name ? last_item->name:"(noname)");
                }
                for (cur = batch; cur; cur = cur->next) {
                        MsgInfo *info = (MsgInfo *)cur->data;
@@ -288,6 +296,9 @@ static gboolean filteringaction_apply(FilteringAction * action, MsgInfo * info)
 
        switch(action->type) {
        case MATCHACTION_MOVE:
+               if (MSG_IS_LOCKED(info->flags))
+                       return FALSE;
+                       
                dest_folder =
                        folder_find_item_from_identifier(action->destination);
                if (!dest_folder) {
@@ -367,17 +378,13 @@ static gboolean filteringaction_apply(FilteringAction * action, MsgInfo * info)
 
        case MATCHACTION_MARK_AS_UNREAD:
                FLUSH_COPY_IF_NEEDED(info);
-               procmsg_msginfo_set_flags(info, MSG_UNREAD, 0);
+               procmsg_msginfo_change_flags(info, MSG_UNREAD, 0, MSG_NEW, 0);
                return TRUE;
        
        case MATCHACTION_MARK_AS_SPAM:
                FLUSH_COPY_IF_NEEDED(info);
                procmsg_spam_learner_learn(info, NULL, TRUE);
                procmsg_msginfo_change_flags(info, MSG_SPAM, 0, MSG_NEW|MSG_UNREAD, 0);
-               if (procmsg_spam_get_folder(info)) {
-                       info->filter_op = IS_MOVE;
-                       info->to_filter_folder = procmsg_spam_get_folder(info);
-               }
                return TRUE;
 
        case MATCHACTION_MARK_AS_HAM:
@@ -401,7 +408,7 @@ static gboolean filteringaction_apply(FilteringAction * action, MsgInfo * info)
                compose_entry_append(compose, action->destination,
                                     compose->account->protocol == A_NNTP
                                            ? COMPOSE_NEWSGROUPS
-                                           : COMPOSE_TO);
+                                           : COMPOSE_TO, PREF_NONE);
 
                val = compose_send(compose);
 
@@ -414,7 +421,7 @@ static gboolean filteringaction_apply(FilteringAction * action, MsgInfo * info)
                        break;
                else
                        compose_entry_append(compose, action->destination,
-                                            COMPOSE_TO);
+                                            COMPOSE_TO, PREF_NONE);
 
                val = compose_send(compose);
                
@@ -425,7 +432,8 @@ static gboolean filteringaction_apply(FilteringAction * action, MsgInfo * info)
                if (cmd == NULL)
                        return FALSE;
                else {
-                       system(cmd);
+                       if (system(cmd) == -1)
+                               g_warning("couldn't run %s", cmd);
                        g_free(cmd);
                }
                return TRUE;
@@ -460,27 +468,33 @@ static gboolean filteringaction_apply(FilteringAction * action, MsgInfo * info)
 
        case MATCHACTION_ADD_TO_ADDRESSBOOK:
                {
+#ifndef USE_ALT_ADDRBOOK
                        AddressDataSource *book = NULL;
                        AddressBookFile *abf = NULL;
                        ItemFolder *folder = NULL;
-                       gchar buf[BUFFSIZE];
-                       Header *header;
+#endif
+                       gchar *buf = NULL;
+                       Header *header = NULL;
                        gint errors = 0;
 
+#ifndef USE_ALT_ADDRBOOK
                        if (!addressbook_peek_folder_exists(action->destination, &book, &folder)) {
-                               g_warning("addressbook folder not found '%s'\n", action->destination);
+                               g_warning("addressbook folder not found '%s'", action->destination?action->destination:"(null)");
                                return FALSE;
                        }
                        if (!book) {
-                               g_warning("addressbook_peek_folder_exists returned NULL book\n");
+                               g_warning("addressbook_peek_folder_exists returned NULL book");
                                return FALSE;
                        }
 
                        abf = book->rawDataSource;
-
+#endif
                        /* get the header */
-                       procheader_get_header_from_msginfo(info, buf, sizeof(buf), action->header);
+                       if (procheader_get_header_from_msginfo(info, &buf, action->header) < 0)
+                               return FALSE;
+
                        header = procheader_parse_header(buf);
+                       g_free(buf);
 
                        /* add all addresses that are not already in */
                        if (header && *header->body && (*header->body != '\0')) {
@@ -496,18 +510,24 @@ static gboolean filteringaction_apply(FilteringAction * action, MsgInfo * info)
                                        path = action->destination;
                                start_address_completion(path);
 
-                               address_list = address_list_append(address_list, header->body);
+                               address_list = g_slist_append(address_list, header->body);
                                for (walk = address_list; walk != NULL; walk = walk->next) {
                                        gchar *stripped_addr = g_strdup(walk->data);
                                        extract_address(stripped_addr);
 
                                        if (complete_matches_found(walk->data) == 0) {
-                                               debug_print("adding address '%s' to addressbook '%s'\n",
-                                                               stripped_addr, action->destination);
-                                               if (!addrbook_add_contact(abf, folder, stripped_addr, stripped_addr, NULL)) {
-                                                       g_warning("contact could not been added\n");
+                                               gchar *name = procheader_get_fromname(walk->data);
+                                               debug_print("adding '%s <%s>' to addressbook '%s'\n",
+                                                               name, stripped_addr, action->destination);
+#ifndef USE_ALT_ADDRBOOK
+                                               if (!addrbook_add_contact(abf, folder, name, stripped_addr, NULL)) {
+#else
+                                               if (!addressadd_selection(name, stripped_addr, NULL, NULL)) {
+#endif
+                                                       g_warning("contact could not be added");
                                                        errors++;
                                                }
+                                               g_free(name);
                                        } else {
                                                debug_print("address '%s' already found in addressbook '%s', skipping\n",
                                                                stripped_addr, action->destination);
@@ -518,11 +538,10 @@ static gboolean filteringaction_apply(FilteringAction * action, MsgInfo * info)
                                g_slist_free(address_list);
                                end_address_completion();
                        } else {
-                               g_warning("header '%s' not set or empty\n", action->header);
+                               g_warning("header '%s' not set or empty", action->header?action->header:"(null)");
                        }
                        return (errors == 0);
                }
-
        default:
                break;
        }
@@ -532,8 +551,8 @@ static gboolean filteringaction_apply(FilteringAction * action, MsgInfo * info)
 gboolean filteringaction_apply_action_list(GSList *action_list, MsgInfo *info)
 {
        GSList *p;
-       g_return_val_if_fail(action_list, FALSE);
-       g_return_val_if_fail(info, FALSE);
+       cm_return_val_if_fail(action_list, FALSE);
+       cm_return_val_if_fail(info, FALSE);
        for (p = action_list; p && p->data; p = g_slist_next(p)) {
                FilteringAction *a = (FilteringAction *) p->data;
                if (filteringaction_apply(a, info)) {
@@ -587,7 +606,7 @@ static gboolean filtering_match_condition(FilteringProp *filtering, MsgInfo *inf
                                                log_status_ok(LOG_DEBUG_FILTERING,
                                                                _("rule is account-based [id=%d, name='%s'], "
                                                                "matching the account currently used to retrieve messages\n"),
-                                                               ac_prefs->account_id, ac_prefs->account_name);
+                                                               ac_prefs->account_id, ac_prefs?ac_prefs->account_name:_("NON_EXISTENT"));
                                        }
                                }
                        }
@@ -720,7 +739,7 @@ static gboolean filtering_apply_rule(FilteringProp *filtering, MsgInfo *info,
     gboolean * final)
 {
        gboolean result = TRUE;
-       gchar    buf[256];
+       gchar    *buf;
         GSList * tmp;
         
         * final = FALSE;
@@ -728,9 +747,9 @@ static gboolean filtering_apply_rule(FilteringProp *filtering, MsgInfo *info,
                 FilteringAction * action;
 
                 action = tmp->data;
-                               filteringaction_to_string(buf, sizeof buf, action);
-                               if (debug_filtering_session)
-                                       log_print(LOG_DEBUG_FILTERING, _("applying action [ %s ]\n"), buf);
+               buf = filteringaction_to_string(action);
+               if (debug_filtering_session)
+                       log_print(LOG_DEBUG_FILTERING, _("applying action [ %s ]\n"), buf);
 
                 if (FALSE == (result = filteringaction_apply(action, info))) {
                                        if (debug_filtering_session) {
@@ -738,14 +757,15 @@ static gboolean filtering_apply_rule(FilteringProp *filtering, MsgInfo *info,
                                                        log_warning(LOG_DEBUG_FILTERING, _("action could not apply\n"));
                                                log_print(LOG_DEBUG_FILTERING,
                                                                _("no further processing after action [ %s ]\n"), buf);
-                                       } else
-                                               g_warning("No further processing after rule %s\n", buf);
+                                       }
+                                       debug_print("No further processing after rule %s\n", buf);
                 }
-                
+                g_free(buf);
                 if (filtering_is_final_action(action)) {
                         * final = TRUE;
                         break;
                 }
+               
         }
        return result;
 }
@@ -764,20 +784,30 @@ static gboolean filtering_is_final_action(FilteringAction *filtering_action)
        case MATCHACTION_MOVE:
        case MATCHACTION_DELETE:
        case MATCHACTION_STOP:
-       case MATCHACTION_MARK_AS_SPAM:
                return TRUE; /* MsgInfo invalid for message */
        default:
                return FALSE;
        }
 }
 
+gboolean processing_enabled(GSList *filtering_list)
+{
+       GSList  *l;
+       for (l = filtering_list; l != NULL; l = g_slist_next(l)) {
+               FilteringProp * filtering = (FilteringProp *) l->data;
+               if (filtering->enabled)
+                       return TRUE;
+       }
+       return FALSE;
+}
+
 static gboolean filter_msginfo(GSList * filtering_list, MsgInfo * info, PrefsAccount* ac_prefs)
 {
        GSList  *l;
        gboolean final;
        gboolean apply_next;
        
-       g_return_val_if_fail(info != NULL, TRUE);
+       cm_return_val_if_fail(info != NULL, TRUE);
        
        for (l = filtering_list, final = FALSE, apply_next = FALSE; l != NULL; l = g_slist_next(l)) {
                FilteringProp * filtering = (FilteringProp *) l->data;
@@ -794,6 +824,7 @@ static gboolean filter_msginfo(GSList * filtering_list, MsgInfo * info, PrefsAcc
                                                _("processing rule <unnamed> [ %s ]\n"),
                                                buf);
                                }
+                               g_free(buf);
                        }
 
                        if (filtering_match_condition(filtering, info, ac_prefs)) {
@@ -821,9 +852,10 @@ static gboolean filter_msginfo(GSList * filtering_list, MsgInfo * info, PrefsAcc
                }
        }
 
-       /* put in inbox if a final rule could not be applied, or
-        * the last rule was not a final one. */
-       if ((final && !apply_next) || !final) {
+    /* put in inbox if the last rule was not a final one, or
+     * a final rule could not be applied.
+     * Either of these cases is likely. */
+    if (!final || !apply_next) {
                return FALSE;
        }
 
@@ -876,6 +908,7 @@ gboolean filter_message_by_msginfo(GSList *flist, MsgInfo *info, PrefsAccount* a
                        debug_filtering_session = FALSE;
                        break;
                }
+
                if (debug_filtering_session) {
                        gchar *file = procmsg_get_message_file_path(info);
                        gchar *spc = g_strnfill(LOG_TIME_LEN + 1, ' ');
@@ -908,12 +941,14 @@ gboolean filter_message_by_msginfo(GSList *flist, MsgInfo *info, PrefsAccount* a
        return ret;
 }
 
-gchar *filteringaction_to_string(gchar *dest, gint destlen, FilteringAction *action)
+gchar *filteringaction_to_string(FilteringAction *action)
 {
        const gchar *command_str;
        gchar * quoted_dest;
        gchar * quoted_header;
-       
+       GString *dest = g_string_new("");
+       gchar *deststr = NULL;
+
        command_str = get_matchparser_tab_str(action->type);
 
        if (command_str == NULL)
@@ -926,9 +961,9 @@ gchar *filteringaction_to_string(gchar *dest, gint destlen, FilteringAction *act
        case MATCHACTION_SET_TAG:
        case MATCHACTION_UNSET_TAG:
                quoted_dest = matcher_quote_str(action->destination);
-               g_snprintf(dest, destlen, "%s \"%s\"", command_str, quoted_dest);
+               g_string_append_printf(dest, "%s \"%s\"", command_str, quoted_dest);
                g_free(quoted_dest);
-               return dest;
+               break;
 
        case MATCHACTION_DELETE:
        case MATCHACTION_MARK:
@@ -944,43 +979,45 @@ gchar *filteringaction_to_string(gchar *dest, gint destlen, FilteringAction *act
        case MATCHACTION_IGNORE:
        case MATCHACTION_WATCH:
        case MATCHACTION_CLEAR_TAGS:
-               g_snprintf(dest, destlen, "%s", command_str);
-               return dest;
+               g_string_append_printf(dest, "%s", command_str);
+               break;
 
        case MATCHACTION_REDIRECT:
        case MATCHACTION_FORWARD:
        case MATCHACTION_FORWARD_AS_ATTACHMENT:
                quoted_dest = matcher_quote_str(action->destination);
-               g_snprintf(dest, destlen, "%s %d \"%s\"", command_str, action->account_id, quoted_dest);
+               g_string_append_printf(dest, "%s %d \"%s\"", command_str, action->account_id, quoted_dest);
                g_free(quoted_dest);
-               return dest; 
+               break;
 
        case MATCHACTION_COLOR:
-               g_snprintf(dest, destlen, "%s %d", command_str, action->labelcolor);
-               return dest;  
+               g_string_append_printf(dest, "%s %d", command_str, action->labelcolor);
+               break;
 
        case MATCHACTION_CHANGE_SCORE:
        case MATCHACTION_SET_SCORE:
-               g_snprintf(dest, destlen, "%s %d", command_str, action->score);
-               return dest;  
+               g_string_append_printf(dest, "%s %d", command_str, action->score);
+               break;
 
        case MATCHACTION_ADD_TO_ADDRESSBOOK:
                quoted_header = matcher_quote_str(action->header);
                quoted_dest = matcher_quote_str(action->destination);
-               g_snprintf(dest, destlen, "%s \"%s\" \"%s\"", command_str, quoted_header, quoted_dest);
+               g_string_append_printf(dest, "%s \"%s\" \"%s\"", command_str, quoted_header, quoted_dest);
                g_free(quoted_dest);
                g_free(quoted_header);
-               return dest;
+               break;
 
        default:
                return NULL;
        }
+       deststr = dest->str;
+       g_string_free(dest, FALSE);
+       return deststr;
 }
 
 gchar * filteringaction_list_to_string(GSList * action_list)
 {
        gchar *action_list_str;
-       gchar  buf[256];
         GSList * tmp;
        gchar *list_str;
 
@@ -991,8 +1028,7 @@ gchar * filteringaction_list_to_string(GSList * action_list)
                 
                 action = tmp->data;
                 
-                action_str = filteringaction_to_string(buf,
-                    sizeof buf, action);
+                action_str = filteringaction_to_string(action);
                 
                 if (action_list_str != NULL) {
                         list_str = g_strconcat(action_list_str, " ", action_str, NULL);
@@ -1001,6 +1037,7 @@ gchar * filteringaction_list_to_string(GSList * action_list)
                 else {
                         list_str = g_strdup(action_str);
                 }
+               g_free(action_str);
                 action_list_str = list_str;
         }
 
@@ -1013,6 +1050,9 @@ gchar * filteringprop_to_string(FilteringProp * prop)
        gchar *action_list_str;
        gchar *filtering_str;
 
+       if (prop == NULL)
+               return NULL;
+
         action_list_str = filteringaction_list_to_string(prop->action_list);
 
        if (action_list_str == NULL)
@@ -1037,8 +1077,8 @@ static void prefs_filtering_free(GSList * prefs_filtering)
        while (prefs_filtering != NULL) {
                FilteringProp * filtering = (FilteringProp *)
                        prefs_filtering->data;
-               filteringprop_free(filtering);
                prefs_filtering = g_slist_remove(prefs_filtering, filtering);
+               filteringprop_free(filtering);
        }
 }
 
@@ -1046,8 +1086,8 @@ static gboolean prefs_filtering_free_func(GNode *node, gpointer data)
 {
        FolderItem *item = node->data;
 
-       g_return_val_if_fail(item, FALSE);
-       g_return_val_if_fail(item->prefs, FALSE);
+       cm_return_val_if_fail(item, FALSE);
+       cm_return_val_if_fail(item->prefs, FALSE);
 
        prefs_filtering_free(item->prefs->processing);
        item->prefs->processing = NULL;
@@ -1077,8 +1117,8 @@ void prefs_filtering_clear(void)
 
 void prefs_filtering_clear_folder(Folder *folder)
 {
-       g_return_if_fail(folder);
-       g_return_if_fail(folder->node);
+       cm_return_if_fail(folder);
+       cm_return_if_fail(folder->node);
 
        g_node_traverse(folder->node, G_PRE_ORDER, G_TRAVERSE_ALL, -1,
                        prefs_filtering_free_func, NULL);
@@ -1100,3 +1140,94 @@ gboolean filtering_peek_per_account_rules(GSList *filtering_list)
 
        return FALSE;
 }
+
+gboolean filtering_action_list_rename_path(GSList *action_list, const gchar *old_path,
+                                          const gchar *new_path)
+{
+       gchar *base;
+       gchar *prefix;
+       gchar *suffix;
+       gchar *dest_path;
+       gchar *old_path_with_sep;
+       gint destlen;
+       gint prefixlen;
+       gint oldpathlen;
+        GSList * action_cur;
+       const gchar *separator=G_DIR_SEPARATOR_S;
+       gboolean matched = FALSE;
+#ifdef G_OS_WIN32
+again:
+#endif
+       oldpathlen = strlen(old_path);
+       old_path_with_sep = g_strconcat(old_path,separator,NULL);
+
+       for(action_cur = action_list ; action_cur != NULL ;
+               action_cur = action_cur->next) {
+
+               FilteringAction *action = action_cur->data;
+                        
+               if (action->type == MATCHACTION_SET_TAG ||
+                   action->type == MATCHACTION_UNSET_TAG)
+                       continue;
+               if (!action->destination) 
+                       continue;
+               
+               destlen = strlen(action->destination);
+                        
+               if (destlen > oldpathlen) {
+                       prefixlen = destlen - oldpathlen;
+                       suffix = action->destination + prefixlen;
+                                
+                       if (!strncmp(old_path, suffix, oldpathlen)) {
+                               prefix = g_malloc0(prefixlen + 1);
+                               strncpy2(prefix, action->destination, prefixlen);
+                                        
+                               base = suffix + oldpathlen;
+                               while (*base == G_DIR_SEPARATOR) base++;
+                                if (*base == '\0')
+                                       dest_path = g_strconcat(prefix, separator,
+                                                               new_path, NULL);
+                               else
+                                       dest_path = g_strconcat(prefix,
+                                                               separator,
+                                                               new_path,
+                                                               separator,
+                                                               base, NULL);
+                                        
+                                       g_free(prefix);
+                                       g_free(action->destination);
+                                       action->destination = dest_path;
+                                       matched = TRUE;
+                       } else { /* for non-leaf folders */
+                               /* compare with trailing slash */
+                               if (!strncmp(old_path_with_sep, action->destination, oldpathlen+1)) {
+                                                
+                                       suffix = action->destination + oldpathlen + 1;
+                                       dest_path = g_strconcat(new_path, separator,
+                                                               suffix, NULL);
+                                       g_free(action->destination);
+                                       action->destination = dest_path;
+                                       matched = TRUE;
+                               }
+                       }
+               } else {
+                       /* folder-moving a leaf */
+                       if (!strcmp(old_path, action->destination)) {
+                               dest_path = g_strdup(new_path);
+                               g_free(action->destination);
+                               action->destination = dest_path;
+                               matched = TRUE;
+                       }
+               }
+       }
+       
+       g_free(old_path_with_sep);
+#ifdef G_OS_WIN32
+       if (!strcmp(separator, G_DIR_SEPARATOR_S) && !matched) {
+               separator = "/";
+               goto again;
+       }
+#endif
+
+       return matched;
+}