fix crash when using Forward in Filtering when external editor option is set
[claws.git] / src / filtering.c
index 48d0188ef9af8afba0547f0a5d188590d3f51f92..853af400576e5003b58eb16f5118ae8dc127218e 100644 (file)
@@ -1,3 +1,23 @@
+/*
+ * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
+ * Copyright (C) 1999-2002 Hiroyuki Yamamoto & The Sylpheed Claws Team
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+ */
+
+#include "defs.h"
 #include <ctype.h>
 #include <string.h>
 #include <stdlib.h>
 #include <stdio.h>
 #include "intl.h"
 #include "utils.h"
-#include "defs.h"
 #include "procheader.h"
 #include "matcher.h"
 #include "filtering.h"
-#include "prefs.h"
+#include "prefs_gtk.h"
 #include "compose.h"
 
 #define PREFSBUFSIZE           1024
 
-GSList * prefs_filtering = NULL;
+GSList * global_processing = NULL;
+
+static gboolean filtering_is_final_action(FilteringAction *filtering_action);
+
+#define STRLEN_WITH_CHECK(expr) \
+        strlen_with_check(#expr, __LINE__, expr)
+               
+static inline gint strlen_with_check(const gchar *expr, gint fline, const gchar *str)
+{
+        if (str) 
+               return strlen(str);
+       else {
+               debug_print("%s(%d) - invalid string %s\n", __FILE__, fline, expr);
+               return 0;
+       }
+}
 
 FilteringAction * filteringaction_new(int type, int account_id,
-                                     gchar * destination)
+                                     gchar * destination,
+                                     gint labelcolor, gint score)
 {
        FilteringAction * action;
 
@@ -26,583 +61,499 @@ FilteringAction * filteringaction_new(int type, int account_id,
 
        action->type = type;
        action->account_id = account_id;
-       if (destination)
-               action->destination = g_strdup(destination);
-
+       if (destination) {
+               action->destination       = g_strdup(destination);
+               action->unesc_destination = matcher_unescape_str(g_strdup(destination));
+       } else {
+               action->destination       = NULL;
+               action->unesc_destination = NULL;
+       }
+       action->labelcolor = labelcolor;        
+        action->score = score;
        return action;
 }
 
 void filteringaction_free(FilteringAction * action)
 {
+       g_return_if_fail(action);
        if (action->destination)
                g_free(action->destination);
+       if (action->unesc_destination)
+               g_free(action->unesc_destination);
        g_free(action);
 }
 
-FilteringAction * filteringaction_parse(gchar ** str)
+FilteringProp * filteringprop_new(MatcherList * matchers,
+                                 GSList * action_list)
 {
-       FilteringAction * action;
-       gchar * tmp;
-       gchar * destination = NULL;
-       gint account_id = 0;
-       gint key;
-
-       tmp = * str;
-
-       key = matcher_parse_keyword(&tmp);
-
-       switch (key) {
-       case MATCHING_ACTION_MOVE:
-               destination = matcher_parse_str(&tmp);
-               if (tmp == NULL) {
-                       * str = NULL;
-                       return NULL;
-               }
-               break;
-       case MATCHING_ACTION_COPY:
-               destination = matcher_parse_str(&tmp);
-               if (tmp == NULL) {
-                       * str = NULL;
-                       return NULL;
-               }
-               break;
-       case MATCHING_ACTION_DELETE:
-               break;
-       case MATCHING_ACTION_MARK:
-               break;
-       case MATCHING_ACTION_MARK_AS_READ:
-               break;
-       case MATCHING_ACTION_UNMARK:
-               break;
-       case MATCHING_ACTION_MARK_AS_UNREAD:
-               break;
-       case MATCHING_ACTION_FORWARD:
-               account_id = matcher_parse_number(&tmp);
-               if (tmp == NULL) {
-                       * str = NULL;
-                       return NULL;
-               }
-
-               destination = matcher_parse_str(&tmp);
-               if (tmp == NULL) {
-                       * str = NULL;
-                       return NULL;
-               }
-
-               break;
-       case MATCHING_ACTION_FORWARD_AS_ATTACHMENT:
-               account_id = matcher_parse_number(&tmp);
-               if (tmp == NULL) {
-                       * str = NULL;
-                       return NULL;
-               }
+       FilteringProp * filtering;
 
-               destination = matcher_parse_str(&tmp);
-               if (tmp == NULL) {
-                       * str = NULL;
-                       return NULL;
-               }
+       filtering = g_new0(FilteringProp, 1);
+       filtering->matchers = matchers;
+       filtering->action_list = action_list;
 
-               break;
-       default:
-               * str = NULL;
-               return NULL;
-       }
+       return filtering;
+}
 
-       * str = tmp;
-       action = filteringaction_new(key, account_id, destination);
+static FilteringAction * filteringaction_copy(FilteringAction * src)
+{
+        FilteringAction * new;
+        
+        new = g_new0(FilteringAction, 1);
+        
+       new->type = src->type;
+       new->account_id = src->account_id;
+       if (src->destination)
+               new->destination = g_strdup(src->destination);
+       else 
+               new->destination = NULL;
+       if (src->unesc_destination)
+               new->unesc_destination = g_strdup(src->unesc_destination);
+       else
+               new->unesc_destination = NULL;
+       new->labelcolor = src->labelcolor;
 
-       return action;
+        return new;
 }
 
-FilteringProp * filteringprop_parse(gchar ** str)
+FilteringProp * filteringprop_copy(FilteringProp *src)
 {
-       gchar * tmp;
-       gint key;
-       FilteringProp * filtering;
-       MatcherList * matchers;
-       FilteringAction * action;
+       FilteringProp * new;
+       GSList *tmp;
        
-       tmp = * str;
+       new = g_new0(FilteringProp, 1);
+       new->matchers = g_new0(MatcherList, 1);
 
-       matchers = matcherlist_parse(&tmp);
-       if (tmp == NULL) {
-               * str = NULL;
-               return NULL;
-       }
+#if 0
+       new->action = g_new0(FilteringAction, 1);
+#endif
 
-       if (tmp == NULL) {
-               matcherlist_free(matchers);
-               * str = NULL;
-               return NULL;
-       }
-
-       action = filteringaction_parse(&tmp);
-       if (tmp == NULL) {
-               matcherlist_free(matchers);
-               * str = NULL;
-               return NULL;
+       for (tmp = src->matchers->matchers; tmp != NULL && tmp->data != NULL;) {
+               MatcherProp *matcher = (MatcherProp *)tmp->data;
+               
+               new->matchers->matchers = g_slist_append(new->matchers->matchers,
+                                                  matcherprop_copy(matcher));
+               tmp = tmp->next;
        }
 
-       filtering = filteringprop_new(matchers, action);
-
-       * str = tmp;
-       return filtering;
-}
-
-
-FilteringProp * filteringprop_new(MatcherList * matchers,
-                                 FilteringAction * action)
-{
-       FilteringProp * filtering;
-
-       filtering = g_new0(FilteringProp, 1);
-       filtering->matchers = matchers;
-       filtering->action = action;
-
-       return filtering;
+       new->matchers->bool_and = src->matchers->bool_and;
+
+#if 0
+       new->action->type = src->action->type;
+       new->action->account_id = src->action->account_id;
+       if (src->action->destination)
+               new->action->destination = g_strdup(src->action->destination);
+       else 
+               new->action->destination = NULL;
+       if (src->action->unesc_destination)
+               new->action->unesc_destination = g_strdup(src->action->unesc_destination);
+       else
+               new->action->unesc_destination = NULL;
+       new->action->labelcolor = src->action->labelcolor;
+#endif
+        new->action_list = NULL;
+
+        for (tmp = src->action_list ; tmp != NULL ; tmp = tmp->next) {
+                FilteringAction *filtering_action;
+                
+                filtering_action = tmp->data;
+                
+                new->action_list = g_slist_append(new->action_list,
+                    filteringaction_copy(filtering_action));
+        }
+
+       return new;
 }
 
 void filteringprop_free(FilteringProp * prop)
 {
+        GSList * tmp;
+
+       g_return_if_fail(prop);
        matcherlist_free(prop->matchers);
-       filteringaction_free(prop->action);
+        
+        for (tmp = prop->action_list ; tmp != NULL ; tmp = tmp->next) {
+                filteringaction_free(tmp->data);
+        }
        g_free(prop);
 }
 
-static gboolean filteringaction_update_mark(MsgInfo * info)
-{
-       gchar * dest_path;
-       FILE * fp;
-
-       if (info->folder->folder->type == F_MH) {
-               dest_path = folder_item_get_path(info->folder);
-               if (!is_dir_exist(dest_path))
-                       make_dir_hier(dest_path);
-               
-               if (dest_path == NULL) {
-                       g_warning(_("Can't open mark file.\n"));
-                       return FALSE;
-               }
-               
-               if ((fp = procmsg_open_mark_file(dest_path, TRUE))
-                   == NULL) {
-                       g_warning(_("Can't open mark file.\n"));
-                       return FALSE;
-               }
-               
-               procmsg_write_flags(info, fp);
-               fclose(fp);
-               return TRUE;
-       }
-       return FALSE;
-}
-
 /*
   fitleringaction_apply
   runs the action on one MsgInfo
   return value : return TRUE if the action could be applied
 */
 
-#define CHANGE_FLAGS(msginfo) \
-{ \
-if (msginfo->folder->folder->change_flags != NULL) \
-msginfo->folder->folder->change_flags(msginfo->folder->folder, \
-                                     msginfo->folder, \
-                                     msginfo); \
-}
-
-static gboolean filteringaction_apply(FilteringAction * action, MsgInfo * info,
-                                     GHashTable *folder_table)
+static gboolean filteringaction_apply(FilteringAction * action, MsgInfo * info)
 {
        FolderItem * dest_folder;
        gint val;
        Compose * compose;
        PrefsAccount * account;
+       gchar * cmd;
 
        switch(action->type) {
-       case MATCHING_ACTION_MOVE:
-               dest_folder = folder_find_item_from_path(action->destination);
+       case MATCHACTION_MOVE:
+               dest_folder =
+                       folder_find_item_from_identifier(action->destination);
                if (!dest_folder)
                        return FALSE;
-
-               if (folder_item_move_msg(dest_folder, info) == -1)
-                       return FALSE;
-
-               info->flags = 0;
-               filteringaction_update_mark(info);
                
-               val = GPOINTER_TO_INT(g_hash_table_lookup
-                                     (folder_table, dest_folder));
-               if (val == 0) {
-                       folder_item_scan(dest_folder);
-                       g_hash_table_insert(folder_table, dest_folder,
-                                           GINT_TO_POINTER(1));
-               }
-               val = GPOINTER_TO_INT(g_hash_table_lookup
-                                     (folder_table, info->folder));
-               if (val == 0) {
-                       folder_item_scan(info->folder);
-                       g_hash_table_insert(folder_table, info->folder,
-                                           GINT_TO_POINTER(1));
-               }
+               if (folder_item_move_msg(dest_folder, info) == -1) {
+                       debug_print("*** could not move message\n");
+                       return FALSE;
+               }       
 
                return TRUE;
 
-       case MATCHING_ACTION_COPY:
-               dest_folder = folder_find_item_from_path(action->destination);
+       case MATCHACTION_COPY:
+               dest_folder =
+                       folder_find_item_from_identifier(action->destination);
+
                if (!dest_folder)
                        return FALSE;
 
                if (folder_item_copy_msg(dest_folder, info) == -1)
                        return FALSE;
 
-               val = GPOINTER_TO_INT(g_hash_table_lookup
-                                     (folder_table, dest_folder));
-               if (val == 0) {
-                       folder_item_scan(dest_folder);
-                       g_hash_table_insert(folder_table, dest_folder,
-                                           GINT_TO_POINTER(1));
-               }
-
                return TRUE;
 
-       case MATCHING_ACTION_DELETE:
+       case MATCHACTION_DELETE:
                if (folder_item_remove_msg(info->folder, info->msgnum) == -1)
                        return FALSE;
-
-               info->flags = 0;
-               filteringaction_update_mark(info);
-
                return TRUE;
 
-       case MATCHING_ACTION_MARK:
-               MSG_SET_FLAGS(info->flags, MSG_MARKED);
-               filteringaction_update_mark(info);
-
-               CHANGE_FLAGS(info);
-
+       case MATCHACTION_MARK:
+               procmsg_msginfo_set_flags(info, MSG_MARKED, 0);
                return TRUE;
 
-       case MATCHING_ACTION_UNMARK:
-               MSG_UNSET_FLAGS(info->flags, MSG_MARKED);
-               filteringaction_update_mark(info);
-
-               CHANGE_FLAGS(info);
-
+       case MATCHACTION_UNMARK:
+               procmsg_msginfo_unset_flags(info, MSG_MARKED, 0);
                return TRUE;
-               
-       case MATCHING_ACTION_MARK_AS_READ:
-               MSG_UNSET_FLAGS(info->flags, MSG_UNREAD | MSG_NEW);
-               filteringaction_update_mark(info);
-
-               CHANGE_FLAGS(info);
 
+       case MATCHACTION_LOCK:
+               procmsg_msginfo_set_flags(info, MSG_LOCKED, 0);
                return TRUE;
 
-       case MATCHING_ACTION_MARK_AS_UNREAD:
-               MSG_SET_FLAGS(info->flags, MSG_UNREAD | MSG_NEW);
-               filteringaction_update_mark(info);
-
-               CHANGE_FLAGS(info);
+       case MATCHACTION_UNLOCK:
+               procmsg_msginfo_unset_flags(info, MSG_LOCKED, 0);       
+               return TRUE;
                
+       case MATCHACTION_MARK_AS_READ:
+               procmsg_msginfo_unset_flags(info, MSG_UNREAD | MSG_NEW, 0);
                return TRUE;
 
-       case MATCHING_ACTION_FORWARD:
+       case MATCHACTION_MARK_AS_UNREAD:
+               procmsg_msginfo_set_flags(info, MSG_UNREAD | MSG_NEW, 0);
+               return TRUE;
+       
+       case MATCHACTION_COLOR:
+               procmsg_msginfo_unset_flags(info, MSG_CLABEL_FLAG_MASK, 0); 
+               procmsg_msginfo_set_flags(info, MSG_COLORLABEL_TO_FLAGS(action->labelcolor), 0);
+               return TRUE;
 
+       case MATCHACTION_FORWARD:
+       case MATCHACTION_FORWARD_AS_ATTACHMENT:
                account = account_find_from_id(action->account_id);
-               compose = compose_forward(account, info, FALSE);
-               if (compose->account->protocol == A_NNTP)
-                       compose_entry_append(compose, action->destination,
-                                            COMPOSE_NEWSGROUPS);
-               else
-                       compose_entry_append(compose, action->destination,
-                                            COMPOSE_TO);
+               compose = compose_forward(account, info,
+                       action->type == MATCHACTION_FORWARD ? FALSE : TRUE,
+                       NULL, TRUE);
+               compose_entry_append(compose, action->destination,
+                                    compose->account->protocol == A_NNTP
+                                           ? COMPOSE_NEWSGROUPS
+                                           : COMPOSE_TO);
 
                val = compose_send(compose);
-               if (val == 0) {
-                       gtk_widget_destroy(compose->window);
-                       return TRUE;
-               }
-
                gtk_widget_destroy(compose->window);
-               return FALSE;
 
-       case MATCHING_ACTION_FORWARD_AS_ATTACHMENT:
+               return val == 0 ? TRUE : FALSE;
 
+       case MATCHACTION_REDIRECT:
                account = account_find_from_id(action->account_id);
-               compose = compose_forward(account, info, TRUE);
+               compose = compose_redirect(account, info);
                if (compose->account->protocol == A_NNTP)
-                       compose_entry_append(compose, action->destination,
-                                            COMPOSE_NEWSGROUPS);
+                       break;
                else
                        compose_entry_append(compose, action->destination,
                                             COMPOSE_TO);
 
                val = compose_send(compose);
-               if (val == 0) {
-                       gtk_widget_destroy(compose->window);
-                       return TRUE;
+               gtk_widget_destroy(compose->window);
+               
+               return val == 0 ? TRUE : FALSE;
+
+       case MATCHACTION_EXECUTE:
+               cmd = matching_build_command(action->unesc_destination, info);
+               if (cmd == NULL)
+                       return FALSE;
+               else {
+                       system(cmd);
+                       g_free(cmd);
                }
+               return TRUE;
 
-               gtk_widget_destroy(compose->window);
-               return FALSE;
+       case MATCHACTION_SET_SCORE:
+               info->score = action->score;
+               return TRUE;
+
+       case MATCHACTION_ADD_SCORE:
+               info->score += action->score;
+               return TRUE;
+
+       case MATCHACTION_STOP:
+                break;
 
        default:
-               return FALSE;
+               break;
        }
+       return FALSE;
 }
 
-/*
-  filteringprop_apply
-  runs the action on one MsgInfo if it matches the criterium
-  return value : return TRUE if the action doesn't allow more actions
-*/
-
-static gboolean filteringprop_apply(FilteringProp * filtering, MsgInfo * info,
-                                   GHashTable *folder_table)
+gboolean filteringaction_apply_action_list(GSList *action_list, MsgInfo *info)
 {
-       if (matcherlist_match(filtering->matchers, info)) {
-               gint result;
-               gchar * action_str;
-
-               result = TRUE;
-
-               result = filteringaction_apply(filtering->action, info,
-                                              folder_table);
-               action_str =
-                       filteringaction_to_string(filtering->action);
-               if (!result) {
-                       g_warning(_("action %s could not be applied"),
-                                 action_str);
-               }
-               else {
-                       debug_print(_("message %i %s..."),
-                                     info->msgnum, action_str);
-               }
-
-               g_free(action_str);
-
-               switch(filtering->action->type) {
-               case MATCHING_ACTION_MOVE:
-               case MATCHING_ACTION_DELETE:
-                       return TRUE;
-               case MATCHING_ACTION_COPY:
-               case MATCHING_ACTION_MARK:
-               case MATCHING_ACTION_MARK_AS_READ:
-               case MATCHING_ACTION_UNMARK:
-               case MATCHING_ACTION_MARK_AS_UNREAD:
-               case MATCHING_ACTION_FORWARD:
-               case MATCHING_ACTION_FORWARD_AS_ATTACHMENT:
-                       return FALSE;
-               default:
+       GSList *p;
+       g_return_val_if_fail(action_list, FALSE);
+       g_return_val_if_fail(info, FALSE);
+       for (p = action_list; p && p->data; p = g_slist_next(p)) {
+               FilteringAction *a = (FilteringAction *) p->data;
+               if (filteringaction_apply(a, info)) {
+                       if (filtering_is_final_action(a))
+                               break;
+               } else
                        return FALSE;
-               }
+               
        }
-       else
-               return FALSE;
+       return TRUE;
 }
 
-void filter_msginfo(GSList * filtering_list, MsgInfo * info,
-                   GHashTable *folder_table)
+static gboolean filtering_match_condition(FilteringProp *filtering, MsgInfo *info)
 {
-       GSList * l;
-
-       if (info == NULL) {
-               g_warning(_("msginfo is not set"));
-               return;
-       }
-       
-       for(l = filtering_list ; l != NULL ; l = g_slist_next(l)) {
-               FilteringProp * filtering = (FilteringProp *) l->data;
-               
-               if (filteringprop_apply(filtering, info, folder_table))
-                       break;
-       }
+       return matcherlist_match(filtering->matchers, info);
 }
 
-void filter_message(GSList * filtering_list, FolderItem * item,
-                   gint msgnum, GHashTable *folder_table)
+static gboolean filtering_apply_rule(FilteringProp *filtering, MsgInfo *info,
+    gboolean * final)
 {
-       MsgInfo * msginfo;
-       gchar * filename;
+       gboolean result;
+       gchar    buf[50];
+        GSList * tmp;
+        
+        * final = FALSE;
+        for (tmp = filtering->action_list ; tmp != NULL ; tmp = tmp->next) {
+                FilteringAction * action;
+                
+                action = tmp->data;
+                
+                if (FALSE == (result = filteringaction_apply(action, info))) {
+                        g_warning("action %s could not be applied", 
+                            filteringaction_to_string(buf, sizeof buf, action));
+                }
+                
+                if (filtering_is_final_action(action)) {
+                        * final = TRUE;
+                        break;
+                }
+        }
+       return result;
+}
 
-       if (item == NULL) {
-               g_warning(_("folderitem not set"));
-               return;
+static gboolean filtering_is_final_action(FilteringAction *filtering_action)
+{
+       switch(filtering_action->type) {
+       case MATCHACTION_MOVE:
+       case MATCHACTION_DELETE:
+       case MATCHACTION_STOP:
+               return TRUE; /* MsgInfo invalid for message */
+       default:
+               return FALSE;
        }
+}
 
-       filename = folder_item_fetch_msg(item, msgnum);
+static gboolean filter_msginfo(GSList * filtering_list, MsgInfo * info)
+{
+       GSList  *l;
+       gboolean final;
+       gboolean applied;
+       
+       g_return_val_if_fail(info != NULL, TRUE);
+       
+       for (l = filtering_list, final = FALSE, applied = FALSE; l != NULL; l = g_slist_next(l)) {
+               FilteringProp * filtering = (FilteringProp *) l->data;
 
-       if (filename == NULL) {
-               g_warning(_("filename is not set"));
-               return;
+               if (filtering_match_condition(filtering, info)) {
+                       applied = filtering_apply_rule(filtering, info, &final);
+#if 0
+                       if (TRUE == (final = filtering_is_final_action(filtering)))
+                               break;
+#endif
+                        if (final)
+                                break;
+               }               
        }
 
-       msginfo = procheader_parse(filename, 0, TRUE);
-
-       g_free(filename);
-
-       if (msginfo == NULL) {
-               g_warning(_("could not get info for %s"), filename);
-               return;
+       /* put in inbox if a final rule could not be applied, or
+        * the last rule was not a final one. */
+       if ((final && !applied) || !final) {
+               return FALSE;
        }
 
-       msginfo->folder = item;
-       msginfo->msgnum = msgnum;
-
-       filter_msginfo(filtering_list, msginfo, folder_table);
+       return TRUE;
 }
 
-void prefs_filtering_read_config(void)
+gboolean filter_message_by_msginfo(GSList *flist, MsgInfo *info)
 {
-       gchar *rcpath;
-       FILE *fp;
-       gchar buf[PREFSBUFSIZE];
-
-       debug_print(_("Reading filtering configuration...\n"));
-
-       rcpath = g_strconcat(get_rc_dir(), G_DIR_SEPARATOR_S,
-                            FILTERING_RC, NULL);
-       if ((fp = fopen(rcpath, "r")) == NULL) {
-               if (ENOENT != errno) FILE_OP_ERROR(rcpath, "fopen");
-               g_free(rcpath);
-               prefs_filtering = NULL;
-               return;
-       }
-       g_free(rcpath);
-
-       /* remove all filtering */
-       while (prefs_filtering != NULL) {
-               FilteringProp * filtering =
-                       (FilteringProp *) prefs_filtering->data;
-               filteringprop_free(filtering);
-               prefs_filtering = g_slist_remove(prefs_filtering, filtering);
-       }
-
-       while (fgets(buf, sizeof(buf), fp) != NULL) {
-               FilteringProp * filtering;
-               gchar * tmp;
-
-               g_strchomp(buf);
-
-               if ((*buf != '#') && (*buf != '\0')) {
-                       tmp = buf;
-                       filtering = filteringprop_parse(&tmp);
-                       if (tmp != NULL) {
-                               prefs_filtering =
-                                       g_slist_append(prefs_filtering,
-                                                      filtering);
-                       }
-                       else {
-                               /* debug */
-                               g_warning(_("syntax error : %s\n"), buf);
-                       }
-               }
-       }
-
-       fclose(fp);
+       return filter_msginfo(flist, info);
 }
 
-gchar * filteringaction_to_string(FilteringAction * action)
+gchar *filteringaction_to_string(gchar *dest, gint destlen, FilteringAction *action)
 {
-       gchar * command_str;
-       gint i;
-       gchar * account_id_str;
+       const gchar *command_str;
 
-       command_str = NULL;
        command_str = get_matchparser_tab_str(action->type);
 
        if (command_str == NULL)
                return NULL;
 
        switch(action->type) {
-       case MATCHING_ACTION_MOVE:
-       case MATCHING_ACTION_COPY:
-               return g_strconcat(command_str, " \"", action->destination,
-                                  "\"", NULL);
-
-       case MATCHING_ACTION_DELETE:
-       case MATCHING_ACTION_MARK:
-       case MATCHING_ACTION_UNMARK:
-       case MATCHING_ACTION_MARK_AS_READ:
-       case MATCHING_ACTION_MARK_AS_UNREAD:
-               return g_strdup(command_str);
-               break;
-
-       case MATCHING_ACTION_FORWARD:
-       case MATCHING_ACTION_FORWARD_AS_ATTACHMENT:
-               account_id_str = itos(action->account_id);
-               return g_strconcat(command_str, " ", account_id_str,
-                                  " \"", action->destination, "\"", NULL);
+       case MATCHACTION_MOVE:
+       case MATCHACTION_COPY:
+       case MATCHACTION_EXECUTE:
+               g_snprintf(dest, destlen, "%s \"%s\"", command_str, action->destination);
+               return dest;
+
+       case MATCHACTION_DELETE:
+       case MATCHACTION_MARK:
+       case MATCHACTION_UNMARK:
+       case MATCHACTION_LOCK:
+       case MATCHACTION_UNLOCK:
+       case MATCHACTION_MARK_AS_READ:
+       case MATCHACTION_MARK_AS_UNREAD:
+       case MATCHACTION_STOP:
+               g_snprintf(dest, destlen, "%s", command_str);
+               return dest;
+
+       case MATCHACTION_REDIRECT:
+       case MATCHACTION_FORWARD:
+       case MATCHACTION_FORWARD_AS_ATTACHMENT:
+               g_snprintf(dest, destlen, "%s %d \"%s\"", command_str, action->account_id, action->destination); 
+               return dest; 
+
+       case MATCHACTION_COLOR:
+               g_snprintf(dest, destlen, "%s %d", command_str, action->labelcolor);
+               return dest;  
+
+       case MATCHACTION_ADD_SCORE:
+       case MATCHACTION_SET_SCORE:
+               g_snprintf(dest, destlen, "%s %d", command_str, action->score);
+               return dest;  
 
        default:
                return NULL;
        }
 }
 
+gchar * filteringaction_list_to_string(GSList * action_list)
+{
+       gchar *action_list_str;
+       gchar  buf[256];
+        GSList * tmp;
+       gchar *list_str;
+
+        action_list_str = NULL;
+        for (tmp = action_list ; tmp != NULL ; tmp = tmp->next) {
+                gchar *action_str;
+                FilteringAction * action;
+                
+                action = tmp->data;
+                
+                action_str = filteringaction_to_string(buf,
+                    sizeof buf, action);
+                
+                if (action_list_str != NULL) {
+                        list_str = g_strconcat(action_list_str, " ", action_str, NULL);
+                        g_free(action_list_str);
+                }
+                else {
+                        list_str = g_strdup(action_str);
+                }
+                action_list_str = list_str;
+        }
+
+        return action_list_str;
+}
+
 gchar * filteringprop_to_string(FilteringProp * prop)
 {
-       gchar * list_str;
-       gchar * action_str;
-       gchar * filtering_str;
+       gchar *list_str;
+       gchar *action_list_str;
+       gchar *filtering_str;
+        GSList * tmp;
 
-       action_str = filteringaction_to_string(prop->action);
+        action_list_str = filteringaction_list_to_string(prop->action_list);
 
-       if (action_str == NULL)
+       if (action_list_str == NULL)
                return NULL;
 
        list_str = matcherlist_to_string(prop->matchers);
 
        if (list_str == NULL) {
-               g_free(action_str);
+                g_free(action_list_str);
                return NULL;
-       }
+        }
 
-       filtering_str = g_strconcat(list_str, " ", action_str, NULL);
+       filtering_str = g_strconcat(list_str, " ", action_list_str, NULL);
+       g_free(action_list_str);
        g_free(list_str);
-       g_free(action_str);
 
        return filtering_str;
 }
 
-void prefs_filtering_write_config(void)
+void prefs_filtering_free(GSList * prefs_filtering)
 {
-       gchar *rcpath;
-       PrefFile *pfile;
-       GSList *cur;
-       FilteringProp * prop;
+       while (prefs_filtering != NULL) {
+               FilteringProp * filtering = (FilteringProp *)
+                       prefs_filtering->data;
+               filteringprop_free(filtering);
+               prefs_filtering = g_slist_remove(prefs_filtering, filtering);
+       }
+}
 
-       debug_print(_("Writing filtering configuration...\n"));
+static gboolean prefs_filtering_free_func(GNode *node, gpointer data)
+{
+       FolderItem *item = node->data;
 
-       rcpath = g_strconcat(get_rc_dir(), G_DIR_SEPARATOR_S, FILTERING_RC, NULL);
+       g_return_val_if_fail(item, FALSE);
+       g_return_val_if_fail(item->prefs, FALSE);
 
-       if ((pfile = prefs_write_open(rcpath)) == NULL) {
-               g_warning(_("failed to write configuration to file\n"));
-               g_free(rcpath);
-               return;
-       }
+       prefs_filtering_free(item->prefs->processing);
+       item->prefs->processing = NULL;
 
-       for (cur = prefs_filtering; cur != NULL; cur = cur->next) {
-               gchar *filtering_str;
-
-               prop = (FilteringProp *) cur->data;
-               filtering_str = filteringprop_to_string(prop);
-               if (fputs(filtering_str, pfile->fp) == EOF ||
-                   fputc('\n', pfile->fp) == EOF) {
-                       FILE_OP_ERROR(rcpath, "fputs || fputc");
-                       prefs_write_close_revert(pfile);
-                       g_free(rcpath);
-                       g_free(filtering_str);
-                       return;
-               }
-               g_free(filtering_str);
-       }
+       return FALSE;
+}
+
+void prefs_filtering_clear(void)
+{
+       GList * cur;
 
-       g_free(rcpath);
+       for (cur = folder_get_list() ; cur != NULL ; cur = g_list_next(cur)) {
+               Folder *folder;
 
-       if (prefs_write_close(pfile) < 0) {
-               g_warning(_("failed to write configuration to file\n"));
-               return;
+               folder = (Folder *) cur->data;
+               g_node_traverse(folder->node, G_PRE_ORDER, G_TRAVERSE_ALL, -1,
+                               prefs_filtering_free_func, NULL);
        }
+
+       prefs_filtering_free(global_processing);
+       global_processing = NULL;
+}
+
+void prefs_filtering_clear_folder(Folder *folder)
+{
+       g_return_if_fail(folder);
+       g_return_if_fail(folder->node);
+
+       g_node_traverse(folder->node, G_PRE_ORDER, G_TRAVERSE_ALL, -1,
+                       prefs_filtering_free_func, NULL);
+       /* FIXME: Note folder settings were changed, where the updates? */
 }
+