more revision of filtering system
[claws.git] / src / filtering.c
index d7acb6063171c9a95e03ff7b7635b9443f574176..13c200a3062980a19bd5786220ab840a16b3a789 100644 (file)
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
  */
 
-/* 
- * initital    Hoa             initial
- * 07/16/01    Alfons          fix bugs
- * 07/18/01    Alfons          rewrite things
- */
-
-/* 07/18/01 (alfons) 
+/* (alfons) - Just a quick note of how this filtering module works on 
+ * new (arriving) messages.
+ * 
+ * 1) as an initialization step, code in inc.c and mbox.c set up the 
+ *    drop folder to the inbox (see inc.c and mbox.c).
+ *
+ * 2) the message is actually being copied to the drop folder using
+ *    folder_item_add_msg(dropfolder, file, TRUE). this function
+ *    eventually calls mh->add_msg(). however, the important thing
+ *    about this function is, is that the folder is not yet updated
+ *    to reflect the copy. i don't know about the validity of this
+ *    assumption, however, the filtering code assumes this and
+ *    updates the marks itself.
+ *
+ * 3) technically there's nothing wrong with the matcher (the 
+ *    piece of code which matches search strings). there's
+ *    one gotcha in procmsg.c:procmsg_get_message_file(): it
+ *    only reads a message file based on a MsgInfo. for design
+ *    reasons the filtering system should read directly from
+ *    a file (based on the file's name).
+ *
+ * 4) after the matcher sorts out any matches, it looks at the
+ *    action. this part again pushes the folder system design
+ *    to its limits. based on the assumption in 2), the matcher
+ *    knows the message has not been added to the folder system yet.
+ *    it can happily update mark files, and in fact it does.
  * 
- * filter_message() is no longer the entry point for filtering. it's
- * replaced with filter_incoming_message() which does not trust
- * on MsgInfo's from a folder. instead it directly works with
- * the temporary file.  
- * updating the mark file is a lot easier now, because we can do that
- * right after a call to folder_item_add_msg(). 
  */ 
 
 #include "defs.h"
 
 GSList * global_processing = NULL;
 
+#define STRLEN_WITH_CHECK(expr) \
+        strlen_with_check(#expr, __LINE__, expr)
+               
+static inline gint strlen_with_check(const gchar *expr, gint fline, const gchar *str)
+{
+        if (str) 
+               return strlen(str);
+       else {
+               debug_print("%s(%d) - invalid string %s\n", __FILE__, fline, expr);
+               return 0;
+       }
+}
+
 FilteringAction * filteringaction_new(int type, int account_id,
                                      gchar * destination,
                                      gint labelcolor)
@@ -75,111 +101,6 @@ void filteringaction_free(FilteringAction * action)
        g_free(action);
 }
 
-/*
-FilteringAction * filteringaction_parse(gchar ** str)
-{
-       FilteringAction * action;
-       gchar * tmp;
-       gchar * destination = NULL;
-       gint account_id = 0;
-       gint key;
-       gint labelcolor = 0;
-
-       tmp = * str;
-
-       key = matcher_parse_keyword(&tmp);
-
-       switch (key) {
-       case MATCHACTION_MOVE:
-       case MATCHACTION_COPY:
-       case MATCHACTION_EXECUTE:
-               destination = matcher_parse_str(&tmp);
-               if (tmp == NULL) {
-                       * str = NULL;
-                       return NULL;
-               }
-               break;
-       case MATCHACTION_DELETE:
-               break;
-       case MATCHACTION_MARK:
-               break;
-       case MATCHACTION_MARK_AS_READ:
-               break;
-       case MATCHACTION_UNMARK:
-               break;
-       case MATCHACTION_MARK_AS_UNREAD:
-               break;
-       case MATCHACTION_FORWARD:
-       case MATCHACTION_FORWARD_AS_ATTACHMENT:
-               account_id = matcher_parse_number(&tmp);
-               if (tmp == NULL) {
-                       * str = NULL;
-                       return NULL;
-               }
-
-               destination = matcher_parse_str(&tmp);
-               if (tmp == NULL) {
-                       * str = NULL;
-                       return NULL;
-               }
-
-               break;
-       case MATCHACTION_COLOR:
-               labelcolor = matcher_parse_number(&tmp);
-               if (tmp == NULL) {
-                       *str = NULL;
-                       return NULL;
-               }
-
-               break;
-       default:
-               * str = NULL;
-               return NULL;
-       }
-
-       * str = tmp;
-
-       action = filteringaction_new(key, account_id, destination, labelcolor);
-
-       return action;
-}
-
-FilteringProp * filteringprop_parse(gchar ** str)
-{
-       gchar * tmp;
-       gint key;
-       FilteringProp * filtering;
-       MatcherList * matchers;
-       FilteringAction * action;
-       
-       tmp = * str;
-
-       matchers = matcherlist_parse(&tmp);
-       if (tmp == NULL) {
-               * str = NULL;
-               return NULL;
-       }
-
-       if (tmp == NULL) {
-               matcherlist_free(matchers);
-               * str = NULL;
-               return NULL;
-       }
-
-       action = filteringaction_parse(&tmp);
-       if (tmp == NULL) {
-               matcherlist_free(matchers);
-               * str = NULL;
-               return NULL;
-       }
-
-       filtering = filteringprop_new(matchers, action);
-
-       * str = tmp;
-       return filtering;
-}
-*/
-
 FilteringProp * filteringprop_new(MatcherList * matchers,
                                  FilteringAction * action)
 {
@@ -231,19 +152,6 @@ static gboolean filteringaction_update_mark(MsgInfo * info)
        return FALSE;
 }
 
-static inline gint strlen_with_check(const gchar *expr, gint fline, const gchar *str)
-{
-       if (str) 
-               return strlen(str);
-       else {
-               debug_print("%s(%d) - invalid string %s\n", __FILE__, fline, expr);
-               return 0;
-       }
-}
-
-#define STRLEN_WITH_CHECK(expr) \
-       strlen_with_check(#expr, __LINE__, expr)
-       
 static gchar * filteringaction_execute_command(gchar * cmd, MsgInfo * info)
 {
        gchar * s = cmd;
@@ -287,11 +195,7 @@ static gchar * filteringaction_execute_command(gchar * cmd, MsgInfo * info)
                                size += STRLEN_WITH_CHECK(info->references) - 2;
                                break;
                        case 'F': /* file */
-                               if (MSG_IS_FILTERING(info->flags))
-                                       filename = g_strdup((gchar *)info->folder);
-                               else
-                                       filename = folder_item_fetch_msg(info->folder, info->msgnum);
-                               
+                               filename = folder_item_fetch_msg(info->folder, info->msgnum);
                                if (filename == NULL) {
                                        g_warning(_("filename is not set"));
                                        return NULL;
@@ -393,8 +297,6 @@ static gchar * filteringaction_execute_command(gchar * cmd, MsgInfo * info)
                        s++;
                }
        }
-
-       g_free(filename);
        return processed_cmd;
 }
 
@@ -432,13 +334,6 @@ static gboolean filteringaction_apply(FilteringAction * action, MsgInfo * info,
                        return FALSE;
                }       
 
-               /* WRONG: can not update the mark, because the message has 
-                * been moved. info pertains to original location. 
-                * folder_item_move_msg() already updated the mark for the
-                * destination folder.
-               info->flags = 0;
-               filteringaction_update_mark(info);
-                */
                if (folder_table) {
                        val = GPOINTER_TO_INT(g_hash_table_lookup
                                              (folder_table, dest_folder));
@@ -447,13 +342,6 @@ static gboolean filteringaction_apply(FilteringAction * action, MsgInfo * info,
                                g_hash_table_insert(folder_table, dest_folder,
                                                    GINT_TO_POINTER(1));
                        }
-                       val = GPOINTER_TO_INT(g_hash_table_lookup
-                                             (folder_table, info->folder));
-                       if (val == 0) {
-                               folder_item_scan(info->folder);
-                               g_hash_table_insert(folder_table, info->folder,
-                                                   GINT_TO_POINTER(1));
-                       }
                }
                return TRUE;
 
@@ -464,10 +352,6 @@ static gboolean filteringaction_apply(FilteringAction * action, MsgInfo * info,
                if (!dest_folder)
                        return FALSE;
 
-               /* NOTE: the following call *will* update the mark file for
-                * the destination folder. but the original message will
-                * still be there in the inbox. */
-
                if (folder_item_copy_msg(dest_folder, info) == -1)
                        return FALSE;
 
@@ -485,53 +369,29 @@ static gboolean filteringaction_apply(FilteringAction * action, MsgInfo * info,
        case MATCHACTION_DELETE:
                if (folder_item_remove_msg(info->folder, info->msgnum) == -1)
                        return FALSE;
-
-               /* WRONG: can not update the mark. this would actually add
-                * a bogus record to the mark file for the message's original 
-                * folder. 
-               info->flags = 0;
-               filteringaction_update_mark(info);
-                */
-
                return TRUE;
 
        case MATCHACTION_MARK:
                MSG_SET_PERM_FLAGS(info->flags, MSG_MARKED);
-               debug_print("*** MARKING message %d, in folder %s, \"%s\"\n",
-                           info->msgnum, info->folder->name,
-                           info->subject ? info->subject : "<none>");
-               filteringaction_update_mark(info);
-
-               CHANGE_FLAGS(info);
-
                return TRUE;
 
        case MATCHACTION_UNMARK:
                MSG_UNSET_PERM_FLAGS(info->flags, MSG_MARKED);
-               filteringaction_update_mark(info);
-
-               CHANGE_FLAGS(info);
-
                return TRUE;
                
        case MATCHACTION_MARK_AS_READ:
                MSG_UNSET_PERM_FLAGS(info->flags, MSG_UNREAD | MSG_NEW);
-               filteringaction_update_mark(info);
-
-               CHANGE_FLAGS(info);
-
                return TRUE;
 
        case MATCHACTION_MARK_AS_UNREAD:
                MSG_SET_PERM_FLAGS(info->flags, MSG_UNREAD | MSG_NEW);
-               filteringaction_update_mark(info);
-
-               CHANGE_FLAGS(info);
-               
+               return TRUE;
+       
+       case MATCHACTION_COLOR:
+               MSG_SET_COLORLABEL_VALUE(info->flags, action->labelcolor);
                return TRUE;
 
        case MATCHACTION_FORWARD:
-
                account = account_find_from_id(action->account_id);
                compose = compose_forward(account, info, FALSE);
                if (compose->account->protocol == A_NNTP)
@@ -561,6 +421,23 @@ static gboolean filteringaction_apply(FilteringAction * action, MsgInfo * info,
                        compose_entry_append(compose, action->destination,
                                             COMPOSE_TO);
 
+               val = compose_send(compose);
+               if (val == 0) {
+                       gtk_widget_destroy(compose->window);
+                       return TRUE;
+               }
+               gtk_widget_destroy(compose->window);
+               return FALSE;
+
+       case MATCHACTION_BOUNCE:
+               account = account_find_from_id(action->account_id);
+               compose = compose_bounce(account, info);
+               if (compose->account->protocol == A_NNTP)
+                       break;
+               else
+                       compose_entry_append(compose, action->destination,
+                                            COMPOSE_TO);
+
                val = compose_send(compose);
                if (val == 0) {
                        gtk_widget_destroy(compose->window);
@@ -571,7 +448,6 @@ static gboolean filteringaction_apply(FilteringAction * action, MsgInfo * info,
                return FALSE;
 
        case MATCHACTION_EXECUTE:
-
                cmd = matching_build_command(action->destination, info);
                if (cmd == NULL)
                        return TRUE;
@@ -579,8 +455,7 @@ static gboolean filteringaction_apply(FilteringAction * action, MsgInfo * info,
                        system(cmd);
                        g_free(cmd);
                }
-
-               return TRUE;
+               return FALSE;
 
        default:
                return FALSE;
@@ -612,8 +487,6 @@ static gboolean filteringprop_apply(FilteringProp * filtering, MsgInfo * info,
                        g_warning(_("action %s could not be applied"), action_str);
                }
 
-               g_free(action_str);
-
                switch(filtering->action->type) {
                case MATCHACTION_MOVE:
                case MATCHACTION_DELETE:
@@ -626,6 +499,7 @@ static gboolean filteringprop_apply(FilteringProp * filtering, MsgInfo * info,
                case MATCHACTION_MARK_AS_UNREAD:
                case MATCHACTION_FORWARD:
                case MATCHACTION_FORWARD_AS_ATTACHMENT:
+               case MATCHACTION_BOUNCE:
                        return FALSE; /* MsgInfo still valid for message */
                default:
                        return FALSE;
@@ -638,8 +512,10 @@ static gboolean filteringprop_apply(FilteringProp * filtering, MsgInfo * info,
 void filter_msginfo(GSList * filtering_list, MsgInfo * info,
                    GHashTable *folder_table)
 {
-       GSList * l;
-
+       GSList          *l;
+       gboolean         result;
+       FolderItem      *inbox;
+       
        if (info == NULL) {
                g_warning(_("msginfo is not set"));
                return;
@@ -647,10 +523,32 @@ void filter_msginfo(GSList * filtering_list, MsgInfo * info,
        
        for(l = filtering_list ; l != NULL ; l = g_slist_next(l)) {
                FilteringProp * filtering = (FilteringProp *) l->data;
-               
-               if (filteringprop_apply(filtering, info, folder_table))
+               if (TRUE == (result = filteringprop_apply(filtering, info, folder_table))) 
                        break;
        }
+
+       /* drop in inbox too */
+       if (!result) {
+               gint val;
+
+               inbox = folder_get_default_inbox();
+               g_assert(inbox);
+               
+               if (folder_item_move_msg(inbox, info) == -1) {
+                       debug_print(_("*** Could not drop message in inbox; still in .processing\n"));
+                       return;
+               }       
+
+               if (folder_table) {
+                       val = GPOINTER_TO_INT(g_hash_table_lookup
+                                             (folder_table, inbox));
+                       if (val == 0) {
+                               folder_item_scan(inbox);
+                               g_hash_table_insert(folder_table, inbox,
+                                                   GINT_TO_POINTER(1));
+                       }
+               }
+       }
 }
 
 void filter_msginfo_move_or_delete(GSList * filtering_list, MsgInfo * info,
@@ -709,440 +607,6 @@ void filter_message(GSList * filtering_list, FolderItem * item,
        filter_msginfo(filtering_list, msginfo, folder_table);
 }
 
-
-/******************************************************************************/
-
-/* revised filtering system.  
- * 
- * 07/18/01    alfons          initial revisement
- */
-
-/* (alfons)
- * 
- * the revised filtering system does not rely on a message being "registered"
- * in one of sylpheed's folders. it now uses the file sylpheed created on
- * incorporation of mail. 
- * i do use MsgInfo data; that's needed by the matcher, but for the rest
- * the MsgInfo is not really used. */
-
-/* add_mark() - adds a mark for a file */
-static void add_mark(FolderItem *folder, gint msgnum, MsgPermFlags flags)
-{
-       gchar * dest_path;
-       FILE * fp;
-
-       if (folder->folder->type == F_MH) {
-               dest_path = folder_item_get_path(folder);
-               if (!is_dir_exist(dest_path))
-                       make_dir_hier(dest_path);
-               
-               if (dest_path == NULL) {
-                       g_warning(_("Can't open mark file.\n"));
-                       return;
-               }
-               
-               if ((fp = procmsg_open_mark_file(dest_path, TRUE))
-                   == NULL) {
-                       g_warning(_("Can't open mark file.\n"));
-                       return;
-               }
-
-               /* TODO: straight from procmsg.c:procmsg_write_flags()
-                * should update this when mark file version changes */
-#if MARK_VERSION == 2           
-               WRITE_CACHE_DATA_INT(msgnum, fp);
-               WRITE_CACHE_DATA_INT(flags, fp);
-#else
-#error should rewrite the above for new  mark version  
-               /* paste the source code of procmsg.c:procmsg_write_flags() */
-#endif
-               fclose(fp);
-               return;
-       }
-       return;
-}
-
-/* prepare_destination() - prepares destination folder by registering it 
- * in the global folder table (if not already there). it returns TRUE if
- * successful. it also returns the FolderItem for the destination */
-static gboolean prepare_destination(const gchar *destination, FolderItem **item, 
-                                   GHashTable *folder_table)
-{
-       gint val;
-       FolderItem *result;
-
-       result = folder_find_item_from_identifier(destination);
-       if (!result)
-               return FALSE;
-       if (folder_table) {
-               *item = result;
-               val = GPOINTER_TO_INT(g_hash_table_lookup(folder_table, *item));
-               if (val == 0) {
-                       folder_item_scan(*item);
-                       g_hash_table_insert(folder_table, *item, GINT_TO_POINTER(1));
-               }
-       }
-       return TRUE;
-}
-
-/* filter_incoming_perform_actions() - performs actions on incoming
- * message. this function handles updating marks a little bit smarter;
- * remember that marks can only be appended. */
-static gboolean filter_incoming_perform_actions(FolderItem *default_folder, 
-                                               MsgInfo    *msginfo,
-                                               GHashTable *folder_table)
-{
-       /* matching actions for msginfo */
-       struct matching_action {
-               FilteringAction         *action;
-               struct matching_action  *next;
-       };
-
-       struct matching_action  ma_head = { NULL, NULL };
-       struct matching_action *ma_tail = &ma_head;
-
-       /* need this for the forwarding stuff */
-       PrefsAccount *account;
-       Compose      *compose;
-       MsgFlags      tmp;
-       gchar        *fwd_msg_name;
-       gint          val;
-       MsgInfo      *fwd_msg;
-
-       MsgFlags     markflags = { 0, 0 };
-
-       /* use the global prefs_filtering list */
-       GSList *     list = global_processing;
-
-       /* things we get after having added a message to a folder */
-       FolderItem  *dest_folder;
-       gint         msgnum;
-       
-       /* after performing certain action, we may have to copy 
-        * the message to inbox too */
-       gboolean     copy_to_inbox_too = TRUE;
-       
-       /* filename is only put in msginfo->folder if MSG_FILTERING is set. */
-       const gchar *filename = (gchar *) msginfo->folder;
-       
-       MsgPermFlags flags;
-       gboolean     stop;
-       gchar        *cmd;
-
-       /* build list of matching actions */
-       for (; list != NULL; list = g_slist_next(list)) {
-               FilteringProp *prop = (FilteringProp *) list->data;
-               
-               if (!matcherlist_match(prop->matchers, msginfo))
-                       continue;
-
-               if (NULL == (ma_tail->next = alloca(sizeof(struct matching_action)))) {
-                       debug_print(_("action allocation error\n"));
-                       break;
-               }
-
-               debug_print("*** action %d\n", prop->action->type);
-
-               ma_tail->action = prop->action;
-               ma_tail->next->action = NULL;
-               ma_tail->next->next = NULL;
-               ma_tail = ma_tail->next;
-       }
-
-       debug_print("*** collecting marks\n");          
-       
-       /* collect all marks */
-       for (ma_tail = &ma_head, stop = FALSE; ma_tail->action && !stop; ma_tail = ma_tail->next) {
-               switch (ma_tail->action->type) {
-               
-               case MATCHACTION_MARK:
-                       MSG_SET_PERM_FLAGS(markflags, MSG_MARKED);
-                       break;
-                       
-               case MATCHACTION_UNMARK:
-                       MSG_UNSET_PERM_FLAGS(markflags, MSG_MARKED);
-                       break;
-               
-               case MATCHACTION_MARK_AS_READ:
-                       MSG_UNSET_PERM_FLAGS(markflags, MSG_UNREAD);
-                       break;
-
-               case MATCHACTION_MARK_AS_UNREAD:                        
-                       MSG_SET_PERM_FLAGS(markflags, MSG_UNREAD);
-                       break;
-
-               case MATCHACTION_COLOR:
-                       MSG_SET_COLORLABEL_VALUE(markflags, ma_tail->action->labelcolor);
-                       break;
-
-               /* UNCONTINUABLE */
-               case MATCHACTION_FORWARD:
-               case MATCHACTION_FORWARD_AS_ATTACHMENT:
-               case MATCHACTION_MOVE:
-               case MATCHACTION_DELETE:
-                       stop = TRUE;
-                       break;
-               
-               default:
-                       break;
-               }
-       }
-
-
-       /* msgnum & dest_folder should have valid values after a succesful
-        * drop; in this case there is a MsgInfo available */
-       msgnum      = -1;
-       dest_folder = NULL;
-
-       debug_print("*** performing actions\n"); 
-       
-       for (ma_tail = &ma_head ; ma_tail->action; ma_tail = ma_tail->next) {
-
-               /* there are variables you have to use when defining new actions:
-                *
-                * copy_to_inbox_too - if the original message should be copied to the inbox 
-                *                     (default_folder) too.
-                * 
-                * also note that after dropping it to a folder (folder_item_add_msg()) you have
-                * to mark the message, just to make sure any defined mark actions are applied. */
-                
-#define ACTION (ma_tail->action->type) 
-
-               /* C O N T I N U A B L E */
-
-               if (MATCHACTION_COPY == ACTION) {
-                       debug_print("*** performing copy\n");
-                       copy_to_inbox_too = TRUE;
-                       if (!prepare_destination(ma_tail->action->destination, &dest_folder, folder_table)) {
-                               debug_print("Rule failed: unknown destination %s\n", ma_tail->action->destination);
-                               continue; /* try next action */
-                       }
-                       if (0 > (msgnum = folder_item_add_msg(dest_folder, filename, FALSE))) {
-                               debug_print(_("Rule failed: could not copy to folder %s\n"),
-                                           ma_tail->action->destination);
-                               continue; /* try next action */     
-                       }   
-                       flags = msginfo->flags.perm_flags | markflags.perm_flags;
-                       add_mark(dest_folder, msgnum, flags);
-               }               
-               else if (MATCHACTION_EXECUTE == ACTION) {
-                       debug_print("*** performing exec\n");
-                       copy_to_inbox_too = TRUE;
-                       
-                       /* matching_build_command() knows about filtering */
-                       cmd = matching_build_command(ma_tail->action->destination, msginfo);
-                       if (cmd) { 
-                               system(cmd);
-                               g_free(cmd);
-                       }
-                       else
-                               debug_print(_("Rule failed: no command line\n"));
-               } 
-
-               /* U N C O N T I N U A B L E */
-               
-               else if (MATCHACTION_FORWARD == ACTION
-               ||       MATCHACTION_FORWARD_AS_ATTACHMENT == ACTION) {
-                       debug_print("*** performing forward\n");
-
-                       /* forwarding messages is complicated because there's currently no 
-                        * way to forward a message using "filenames"; you can only forward
-                        * a message if you have its MsgInfo. this means we have to drop
-                        * the message first */ 
-                       if (0 > (msgnum = folder_item_add_msg(default_folder, filename, FALSE))) {
-                               debug_print(_("Rule failed: could not forward\n"));
-                               copy_to_inbox_too = TRUE;
-                               continue;
-                       }
-                               
-                       flags = msginfo->flags.perm_flags | markflags.perm_flags;
-                       flags |= MSG_FORWARDED;
-                       add_mark(default_folder, msgnum, flags);
-
-                       /* grab the dropped message */
-                       fwd_msg_name = folder_item_fetch_msg(default_folder, msgnum);
-
-                       tmp.perm_flags = tmp.tmp_flags = 0;
-                       fwd_msg = procheader_parse(fwd_msg_name, tmp, TRUE);
-
-                       fwd_msg->folder = default_folder;
-                       fwd_msg->msgnum = msgnum;
-
-                       /* do the compose_XXX stuff */
-                       account = account_find_from_id(ma_tail->action->account_id);
-                       compose = compose_forward(account, fwd_msg, ACTION == MATCHACTION_FORWARD ? FALSE : TRUE);
-                       if (compose->account->protocol == A_NNTP)
-                               compose_entry_append(compose, ma_tail->action->destination,
-                                                    COMPOSE_NEWSGROUPS);
-                       else
-                               compose_entry_append(compose, ma_tail->action->destination,
-                                                    COMPOSE_TO);
-
-                       compose_send(compose);
-
-                       procmsg_msginfo_free(fwd_msg);
-                       
-                       gtk_widget_destroy(compose->window);
-                       break;
-               }                       
-               else if (MATCHACTION_DELETE == ACTION) {
-                       debug_print("*** performing delete\n");
-                       copy_to_inbox_too = FALSE;
-
-                       /* drop to Trash */
-                       dest_folder = folder_get_default_trash();
-                       msgnum = folder_item_add_msg(dest_folder, filename, FALSE);
-                       if (msgnum < 0) {
-                               debug_print(_("Rule failed: could not move to trash"));
-                               copy_to_inbox_too = TRUE;           
-                       }
-                       else {
-                               flags = msginfo->flags.perm_flags | markflags.perm_flags;
-                               add_mark(dest_folder, msgnum, flags);
-                       }
-                       break;                          
-               }
-               else if (MATCHACTION_MOVE == ACTION) {
-                       debug_print("*** performing move\n");
-                       copy_to_inbox_too = FALSE;
-                       
-                       if (!prepare_destination(ma_tail->action->destination, &dest_folder, folder_table)) {
-                               copy_to_inbox_too = TRUE;
-                               break;
-                       }
-                               
-                       msgnum = folder_item_add_msg(dest_folder, filename, FALSE);
-                       if (msgnum < 0) {
-                               debug_print(_("Rule failed: could not move to folder %s\n"),
-                                           ma_tail->action->destination);
-                               copy_to_inbox_too = TRUE;                                          
-                               break;
-                       }   
-                       
-                       flags = msginfo->flags.perm_flags | markflags.perm_flags;
-                       add_mark(dest_folder, msgnum, flags);
-                       break;
-               }
-       }
-
-       /* may need to copy it to inbox too */
-       if (copy_to_inbox_too) {
-               debug_print("*** performing inbox copy\n");
-               msgnum = folder_item_add_msg(default_folder, filename, TRUE);
-               if (msgnum < 0) {
-                       debug_print(_("error copying incoming file %s to inbox\n"), 
-                                   filename);
-                       return FALSE;                               
-               }
-               flags = msginfo->flags.perm_flags | markflags.perm_flags;
-               add_mark(default_folder, msgnum, flags);
-       }
-       else {
-               debug_print("*** unlinking\n");
-               if (unlink(filename) < 0) 
-                       debug_print(_("error deleting incoming message file\n"));
-       }
-
-#undef ACTION
-
-       return TRUE;
-}
-
-static void filter_incoming_msginfo(FolderItem *default_folder, MsgInfo *msginfo, 
-                                   GHashTable *folder_table)
-{
-       filter_incoming_perform_actions(default_folder, msginfo, folder_table); 
-}
-
-/* filter_incoming_message() - tries to apply a filter on one incoming message.
- * it also handles the case when there's no filter match */
-void filter_incoming_message(FolderItem *default_folder, const gchar *file_name, 
-                            GHashTable *folder_table)
-{
-       MsgInfo *msginfo;
-       MsgFlags msgflags = { 0, 0 };
-       
-       /* make an "uncomplete" msginfo. it's incomplete because it doesn't
-        * have a message number / folder yet. */
-       if (NULL == (msginfo = procheader_parse(file_name, msgflags, TRUE))) {
-               g_warning(_("error filtering incoming message %s\n"), 
-                         file_name);
-               return;         
-       }
-
-       /* let matcher know that this is a message that has no
-        * valid body data yet. */
-       MSG_SET_TMP_FLAGS(msginfo->flags, MSG_FILTERING);
-       msginfo->folder = (FolderItem *) g_strdup(file_name); /* actually storing a pointer to a string */
-       msginfo->msgnum = 0;
-
-       filter_incoming_msginfo(default_folder, msginfo, folder_table);
-
-       g_free(msginfo->folder);
-       procmsg_msginfo_free(msginfo);
-}
-
-/****************************************************************************/
-
-
-
-/*
-void prefs_filtering_read_config(void)
-{
-
-       gchar *rcpath;
-       FILE *fp;
-       gchar buf[PREFSBUFSIZE];
-
-       debug_print(_("Reading filtering configuration...\n"));
-
-       rcpath = g_strconcat(get_rc_dir(), G_DIR_SEPARATOR_S,
-                            FILTERING_RC, NULL);
-       if ((fp = fopen(rcpath, "r")) == NULL) {
-               if (ENOENT != errno) FILE_OP_ERROR(rcpath, "fopen");
-               g_free(rcpath);
-               prefs_filtering = NULL;
-               return;
-       }
-       g_free(rcpath);
-       */
-       /* remove all filtering */
-       /*
-       while (prefs_filtering != NULL) {
-               FilteringProp * filtering =
-                       (FilteringProp *) prefs_filtering->data;
-               filteringprop_free(filtering);
-               prefs_filtering = g_slist_remove(prefs_filtering, filtering);
-       }
-
-       while (fgets(buf, sizeof(buf), fp) != NULL) {
-               FilteringProp * filtering;
-               gchar * tmp;
-
-               g_strchomp(buf);
-
-               if ((*buf != '#') && (*buf != '\0')) {
-                       tmp = buf;
-                       filtering = filteringprop_parse(&tmp);
-                       if (tmp != NULL) {
-                               prefs_filtering =
-                                       g_slist_append(prefs_filtering,
-                                                      filtering);
-                       }
-                       else {
-       */
-                               /* debug */
-       /*
-                               g_warning(_("syntax error : %s\n"), buf);
-                       }
-               }
-       }
-
-       fclose(fp);
-}
-*/
-
 gchar *filteringaction_to_string(gchar *dest, gint destlen, FilteringAction *action)
 {
        gchar *command_str;
@@ -1167,6 +631,7 @@ gchar *filteringaction_to_string(gchar *dest, gint destlen, FilteringAction *act
                g_snprintf(dest, destlen, "%s", command_str);
                return dest;
 
+       case MATCHACTION_BOUNCE:
        case MATCHACTION_FORWARD:
        case MATCHACTION_FORWARD_AS_ATTACHMENT:
                g_snprintf(dest, destlen, "%s %d \"%s\"", command_str, action->account_id, action->destination); 
@@ -1204,50 +669,6 @@ gchar * filteringprop_to_string(FilteringProp * prop)
        return filtering_str;
 }
 
-void prefs_filtering_write_config(void)
-{
-       /*
-       gchar *rcpath;
-       PrefFile *pfile;
-       GSList *cur;
-       FilteringProp * prop;
-
-       debug_print(_("Writing filtering configuration...\n"));
-
-       rcpath = g_strconcat(get_rc_dir(), G_DIR_SEPARATOR_S, FILTERING_RC, NULL);
-
-       if ((pfile = prefs_write_open(rcpath)) == NULL) {
-               g_warning(_("failed to write configuration to file\n"));
-               g_free(rcpath);
-               return;
-       }
-
-       for (cur = global_processing; cur != NULL; cur = cur->next) {
-               gchar *filtering_str;
-
-               prop = (FilteringProp *) cur->data;
-               filtering_str = filteringprop_to_string(prop);
-               
-               if (fputs(filtering_str, pfile->fp) == EOF ||
-                   fputc('\n', pfile->fp) == EOF) {
-                       FILE_OP_ERROR(rcpath, "fputs || fputc");
-                       prefs_write_close_revert(pfile);
-                       g_free(rcpath);
-                       g_free(filtering_str);
-                       return;
-               }
-               g_free(filtering_str);
-       }
-
-       g_free(rcpath);
-
-       if (prefs_write_close(pfile) < 0) {
-               g_warning(_("failed to write configuration to file\n"));
-               return;
-       }
-       */
-}
-
 void prefs_filtering_free(GSList * prefs_filtering)
 {
        while (prefs_filtering != NULL) {