More and better leak fixes after commit 9729bf0e0.
[claws.git] / src / etpan / nntp-thread.c
index 84a2f83d761b4527174805cec6047526bb06caf0..cebdf69dcce744d7cc9a541b4dbfb4fc1baab281 100644 (file)
@@ -1,6 +1,6 @@
 /*
  * Claws Mail -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 2005-2012 DINH Viet Hoa and the Claws Mail team
+ * Copyright (C) 2005-2016 DINH Viet Hoa and the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -14,7 +14,6 @@
  *
  * You should have received a copy of the GNU General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
- * 
  */
 
 #ifdef HAVE_CONFIG_H
 
 #define DISABLE_LOG_DURING_LOGIN
 
+#define NNTP_BATCH_SIZE 4999
+
 static struct etpan_thread_manager * thread_manager = NULL;
 static chash * nntp_hash = NULL;
 static chash * session_hash = NULL;
 static guint thread_manager_signal = 0;
 static GIOChannel * io_channel = NULL;
 
-static void (*previous_stream_logger)(int direction,
-    const char * str, size_t size);
-
 static void nntp_logger(int direction, const char * str, size_t size) 
 {
        gchar *buf;
@@ -213,7 +211,7 @@ void nntp_done(Folder * folder)
        
        chash_delete(nntp_hash, &key, NULL);
        
-       debug_print("remove thread");
+       debug_print("remove thread\n");
 }
 
 static struct etpan_thread * get_thread(Folder * folder)
@@ -221,13 +219,17 @@ static struct etpan_thread * get_thread(Folder * folder)
        struct etpan_thread * thread;
        chashdatum key;
        chashdatum value;
-       
+       int r;
+
        key.data = &folder;
        key.len = sizeof(folder);
-       
-       chash_get(nntp_hash, &key, &value);
+
+       r = chash_get(nntp_hash, &key, &value);
+       if (r < 0)
+               return NULL;
+
        thread = value.data;
-       
+
        return thread;
 }
 
@@ -266,7 +268,9 @@ static void threaded_run(Folder * folder, void * param, void * result,
 {
        struct etpan_thread_op * op;
        struct etpan_thread * thread;
-       
+       void (*previous_stream_logger)(int direction,
+               const char * str, size_t size);
+
        nntp_folder_ref(folder);
 
        op = etpan_thread_op_new();
@@ -274,14 +278,10 @@ static void threaded_run(Folder * folder, void * param, void * result,
        op->nntp = get_nntp(folder);
        op->param = param;
        op->result = result;
-       
-       op->cancellable = 0;
+
        op->run = func;
        op->callback = generic_cb;
        op->callback_data = op;
-       op->cleanup = NULL;
-       
-       op->finished = 0;
        
        previous_stream_logger = mailstream_logger;
        mailstream_logger = nntp_logger;
@@ -373,7 +373,7 @@ int nntp_threaded_connect(Folder * folder, const char * server, int port)
        
        return result.error;
 }
-
+#ifdef USE_GNUTLS
 static void connect_ssl_run(struct etpan_thread_op * op)
 {
        int r;
@@ -398,11 +398,12 @@ int nntp_threaded_connect_ssl(Folder * folder, const char * server, int port)
        chashdatum key;
        chashdatum value;
        newsnntp * nntp, * oldnntp;
-       
+       gboolean accept_if_valid = FALSE;
+
        oldnntp = get_nntp(folder);
 
        nntp = newsnntp_new(0, NULL);
-       
+
        if (oldnntp) {
                debug_print("deleting old nntp %p\n", oldnntp);
                delete_nntp(folder, oldnntp);
@@ -413,23 +414,28 @@ int nntp_threaded_connect_ssl(Folder * folder, const char * server, int port)
        value.data = nntp;
        value.len = 0;
        chash_set(session_hash, &key, &value, NULL);
-       
+
        param.nntp = nntp;
        param.server = server;
        param.port = port;
        param.account = folder->account;
 
+       if (folder->account)
+               accept_if_valid = folder->account->ssl_certs_auto_accept;
+
        refresh_resolvers();
        threaded_run(folder, &param, &result, connect_ssl_run);
 
        if (result.error == NEWSNNTP_NO_ERROR && !etpan_skip_ssl_cert_check) {
-               if (etpan_certificate_check(nntp->nntp_stream, server, port) < 0)
+               if (etpan_certificate_check(nntp->nntp_stream, server, port,
+                                           accept_if_valid) != TRUE)
                        return -1;
        }
        debug_print("connect %d with nntp %p\n", result.error, nntp);
        
        return result.error;
 }
+#endif
 
 void nntp_threaded_disconnect(Folder * folder)
 {
@@ -818,26 +824,64 @@ static void xover_run(struct etpan_thread_op * op)
        }
        
        result->error = r;
-       debug_print("nntp xover run - end %i\n", r);
+       debug_print("nntp xover run %d-%d - end %i\n",
+                       param->beg, param->end, r);
 }
 
 int nntp_threaded_xover(Folder * folder, guint32 beg, guint32 end, struct newsnntp_xover_resp_item **single_result, clist **multiple_result)
 {
        struct xover_param param;
        struct xover_result result;
-       
-       debug_print("nntp xover - begin\n");
-       
-       param.nntp = get_nntp(folder);
-       param.beg = beg;
-       param.end = end;
-       param.result = single_result;
-       param.msglist = multiple_result;
-
-       threaded_run(folder, &param, &result, xover_run);
+       clist *l = NULL, *h = NULL;
+       guint32 cbeg = 0, cend = 0;
+
+       debug_print("nntp xover - begin (%d-%d)\n", beg, end);
+
+       h = clist_new();
+
+       /* Request the overview in batches of NNTP_BATCH_SIZE, to prevent
+        * long stalls or libetpan choking on too large server response,
+        * and to allow updating any progress indicators while we work. */
+       cbeg = beg;
+       while (cbeg <= end && cend <= end) {
+               cend = cbeg + NNTP_BATCH_SIZE;
+               if (cend > end)
+                       cend = end;
+
+               param.nntp = get_nntp(folder);
+               param.beg = cbeg;
+               param.end = cend;
+               param.result = single_result;
+               param.msglist = &l;
+
+               threaded_run(folder, &param, &result, xover_run);
+
+               /* Handle errors */
+               if (result.error != NEWSNNTP_NO_ERROR) {
+                       log_warning(LOG_PROTOCOL, _("couldn't get xover range\n"));
+                       debug_print("couldn't get xover for %d-%d\n", cbeg, cend);
+                       if (l != NULL)
+                               newsnntp_xover_resp_list_free(l);
+                       newsnntp_xover_resp_list_free(h);
+                       return result.error;
+               }
+
+               /* Append the new data (l) to list of results (h). */
+               if (l != NULL) {
+                       debug_print("total items so far %d, items this batch %d\n",
+                                       clist_count(h), clist_count(l));
+                       clist_concat(h, l);
+                       clist_free(l);
+                       l = NULL;
+               }
+
+               cbeg += NNTP_BATCH_SIZE + 1;
+       }
        
        debug_print("nntp xover - end\n");
-       
+
+       *multiple_result = h;
+
        return result.error;
 }
 
@@ -871,26 +915,66 @@ static void xhdr_run(struct etpan_thread_op * op)
        }
        
        result->error = r;
-       debug_print("nntp xhdr run - end %i\n", r);
+       debug_print("nntp xhdr '%s %d-%d' run - end %i\n",
+                       param->header, param->beg, param->end, r);
 }
 
 int nntp_threaded_xhdr(Folder * folder, const char *header, guint32 beg, guint32 end, clist **hdrlist)
 {
        struct xhdr_param param;
        struct xhdr_result result;
+       clist *l = NULL;
+       clist *h = *hdrlist;
+       guint32 cbeg = 0, cend = 0;
+
+       debug_print("nntp xhdr %s - begin (%d-%d)\n", header, beg, end);
+
+       if (h == NULL)
+               h = clist_new();
+
+       /* Request the headers in batches of NNTP_BATCH_SIZE, to prevent
+        * long stalls or libetpan choking on too large server response,
+        * and to allow updating any progress indicators while we work. */
+       cbeg = beg;
+       while (cbeg <= end && cend <= end) {
+               cend = cbeg + NNTP_BATCH_SIZE;
+               if (cend > end)
+                       cend = end;
+
+               param.nntp = get_nntp(folder);
+               param.header = header;
+               param.beg = cbeg;
+               param.end = cend;
+               param.hdrlist = &l;
+
+               threaded_run(folder, &param, &result, xhdr_run);
+
+               /* Handle errors */
+               if (result.error != NEWSNNTP_NO_ERROR) {
+                       log_warning(LOG_PROTOCOL, _("couldn't get xhdr range\n"));
+                       debug_print("couldn't get xhdr %s %d-%d\n",     header, cbeg, cend);
+                       if (l != NULL)
+                               newsnntp_xhdr_free(l);
+                       newsnntp_xhdr_free(h);
+                       return result.error;
+               }
+
+               /* Append the new data (l) to list of results (h). */
+               if (l != NULL) {
+                       debug_print("total items so far %d, items this batch %d\n",
+                                       clist_count(h), clist_count(l));
+                       clist_concat(h, l);
+                       clist_free(l);
+                       l = NULL;
+               }
+
+               cbeg += NNTP_BATCH_SIZE + 1;
+       }
        
-       debug_print("nntp xhdr - begin\n");
-       
-       param.nntp = get_nntp(folder);
-       param.header = header;
-       param.beg = beg;
-       param.end = end;
-       param.hdrlist = hdrlist;
+       debug_print("nntp xhdr %s - end (%d-%d)\n", header, beg, end);
+
+       *hdrlist = h;
 
-       threaded_run(folder, &param, &result, xhdr_run);
-       
-       debug_print("nntp xhdr - end\n");
-       
        return result.error;
 }