2012-10-12 [mones] 3.8.1cvs98
[claws.git] / src / etpan / imap-thread.c
index 3a8bc0837a824b1eae97f8a5f0a19a1ff09d4df1..d4e3bf0b946b33c421f2220d2e7f9108c1f32e1c 100644 (file)
@@ -1,6 +1,6 @@
 /*
  * Claws Mail -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 2005-2007 DINH Viet Hoa and the Claws Mail team
+ * Copyright (C) 2005-2012 DINH Viet Hoa and the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
 
 #ifdef HAVE_CONFIG_H
 #  include "config.h"
+#include "claws-features.h"
 #endif
 
 #ifdef HAVE_LIBETPAN
 
+#include <glib.h>
+#include <glib/gi18n.h>
 #include "imap-thread.h"
 #include <imap.h>
 #include <sys/types.h>
 #include "etpan-thread-manager.h"
 #include "utils.h"
 #include "mainwindow.h"
+#include "ssl.h"
 #include "ssl_certificate.h"
 #include "socket.h"
 #include "remotefolder.h"
+#include "tags.h"
 
 #define DISABLE_LOG_DURING_LOGIN
 
@@ -56,12 +61,9 @@ static GIOChannel * io_channel = NULL;
 static void delete_imap(Folder *folder, mailimap *imap)
 {
        chashdatum key;
-       chashdatum value;
 
        key.data = &folder;
        key.len = sizeof(folder);
-       value.data = imap;
-       value.len = 0;
        chash_delete(session_hash, &key, NULL);
        
        key.data = &imap;
@@ -80,6 +82,13 @@ static gboolean thread_manager_event(GIOChannel * source,
     GIOCondition condition,
     gpointer data)
 {
+#ifdef G_OS_WIN32
+       gsize bytes_read;
+       gchar ch;
+       
+       if (condition & G_IO_IN)
+               g_io_channel_read_chars(source, &ch, 1, &bytes_read, NULL);
+#endif
        etpan_thread_manager_loop(thread_manager);
        
        return TRUE;
@@ -271,8 +280,11 @@ void imap_main_init(gboolean skip_ssl_cert_check)
        
        fd_thread_manager = etpan_thread_manager_get_fd(thread_manager);
        
+#ifndef G_OS_WIN32
        io_channel = g_io_channel_unix_new(fd_thread_manager);
-       
+#else
+       io_channel = g_io_channel_win32_new_fd(fd_thread_manager);
+#endif
        thread_manager_signal = g_io_add_watch_full(io_channel, 0, G_IO_IN,
                                                    thread_manager_event,
                                                    (gpointer) NULL,
@@ -285,8 +297,9 @@ void imap_main_set_timeout(int sec)
        mailstream_network_delay.tv_usec = 0;
 }
 
-void imap_main_done(void)
+void imap_main_done(gboolean have_connectivity)
 {
+       imap_disconnect_all(have_connectivity);
        etpan_thread_manager_stop(thread_manager);
 #if defined(__NetBSD__) || defined(__OpenBSD__) || defined(__FreeBSD__)
        return;
@@ -437,6 +450,7 @@ static void threaded_run(Folder * folder, void * param, void * result,
 
 struct connect_param {
        mailimap * imap;
+       PrefsAccount *account;
        const char * server;
        int port;
 };
@@ -507,27 +521,7 @@ int imap_threaded_connect(Folder * folder, const char * server, int port)
 
 static int etpan_certificate_check(const unsigned char *certificate, int len, void *data)
 {
-#ifdef USE_OPENSSL
-       struct connect_param *param = (struct connect_param *)data;
-       X509 *cert = NULL;
-       
-       if (certificate == NULL || len < 0) {
-               g_warning("no cert presented.\n");
-               return 0;
-       }
-       cert = d2i_X509(NULL, (const unsigned char **)&certificate, len);
-       if (cert == NULL) {
-               g_warning("IMAP: can't get cert\n");
-               return 0;
-       } else if (ssl_certificate_check(cert, NULL,
-               (gchar *)param->server, (gushort)param->port) == TRUE) {
-               X509_free(cert);
-               return 0;
-       } else {
-               X509_free(cert);
-               return -1;
-       }
-#elif USE_GNUTLS
+#ifdef USE_GNUTLS
        struct connect_param *param = (struct connect_param *)data;
        gnutls_x509_crt cert = NULL;
        gnutls_datum tmp;
@@ -544,8 +538,8 @@ static int etpan_certificate_check(const unsigned char *certificate, int len, vo
        if (gnutls_x509_crt_import(cert, &tmp, GNUTLS_X509_FMT_DER) < 0) {
                g_warning("IMAP: can't get cert\n");
                return 0;
-       } else if (ssl_certificate_check(cert, (guint)-1, NULL,
-               (gchar *)param->server, (gushort)param->port) == TRUE) {
+       } else if (ssl_certificate_check(cert, (guint)-1, (gchar *)param->server,
+                       (gushort)param->port) == TRUE) {
                gnutls_x509_crt_deinit(cert);
                return 0;
        } else {
@@ -556,6 +550,48 @@ static int etpan_certificate_check(const unsigned char *certificate, int len, vo
        return 0;
 }
 
+static void connect_ssl_context_cb(struct mailstream_ssl_context * ssl_context, void * data)
+{
+#ifdef USE_GNUTLS
+       PrefsAccount *account = (PrefsAccount *)data;
+       const gchar *cert_path = NULL;
+       const gchar *password = NULL;
+       gnutls_x509_crt x509 = NULL;
+       gnutls_x509_privkey pkey = NULL;
+
+       if (account->in_ssl_client_cert_file && *account->in_ssl_client_cert_file)
+               cert_path = account->in_ssl_client_cert_file;
+       if (account->in_ssl_client_cert_pass && *account->in_ssl_client_cert_pass)
+               password = account->in_ssl_client_cert_pass;
+       
+       if (mailstream_ssl_set_client_certificate_data(ssl_context, NULL, 0) < 0 ||
+           mailstream_ssl_set_client_private_key_data(ssl_context, NULL, 0) < 0)
+               debug_print("Impossible to set the client certificate.\n");
+       x509 = ssl_certificate_get_x509_from_pem_file(cert_path);
+       pkey = ssl_certificate_get_pkey_from_pem_file(cert_path);
+       if (!(x509 && pkey)) {
+               /* try pkcs12 format */
+               ssl_certificate_get_x509_and_pkey_from_p12_file(cert_path, password, &x509, &pkey);
+       }
+       if (x509 && pkey) {
+               unsigned char *x509_der = NULL, *pkey_der = NULL;
+               size_t x509_len, pkey_len;
+               
+               x509_len = (size_t)gnutls_i2d_X509(x509, &x509_der);
+               pkey_len = (size_t)gnutls_i2d_PrivateKey(pkey, &pkey_der);
+               if (x509_len > 0 && pkey_len > 0) {
+                       if (mailstream_ssl_set_client_certificate_data(ssl_context, x509_der, x509_len) < 0 ||
+                           mailstream_ssl_set_client_private_key_data(ssl_context, pkey_der, pkey_len) < 0) 
+                               log_error(LOG_PROTOCOL, _("Impossible to set the client certificate.\n"));
+                       g_free(x509_der);
+                       g_free(pkey_der);
+               }
+               gnutls_x509_crt_deinit(x509);
+               gnutls_x509_privkey_deinit(pkey);
+       }
+#endif
+}
+
 static void connect_ssl_run(struct etpan_thread_op * op)
 {
        int r;
@@ -567,8 +603,9 @@ static void connect_ssl_run(struct etpan_thread_op * op)
        
        CHECK_IMAP();
 
-       r = mailimap_ssl_connect(param->imap,
-                                param->server, param->port);
+       r = mailimap_ssl_connect_with_callback(param->imap,
+                                               param->server, param->port,
+                                               connect_ssl_context_cb, param->account);
        result->error = r;
 }
 
@@ -600,7 +637,8 @@ int imap_threaded_connect_ssl(Folder * folder, const char * server, int port)
        param.imap = imap;
        param.server = server;
        param.port = port;
-       
+       param.account = folder->account;
+
        refresh_resolvers();
        threaded_run(folder, &param, &result, connect_ssl_run);
 
@@ -1118,7 +1156,7 @@ static void starttls_run(struct etpan_thread_op * op)
                        return;
                }
 
-               tls_low = mailstream_low_tls_open(fd);
+               tls_low = mailstream_low_tls_open_with_callback(fd, connect_ssl_context_cb, param->account);
                if (tls_low == NULL) {
                        debug_print("imap starttls run - can't tls_open\n");
                        result->error = MAILIMAP_ERROR_STREAM;
@@ -1134,14 +1172,15 @@ int imap_threaded_starttls(Folder * folder, const gchar *host, int port)
        struct connect_param param;
        struct starttls_result result;
        int cert_len;
-       unsigned char *certificate;
+       unsigned char *certificate = NULL;
        
        debug_print("imap starttls - begin\n");
        
        param.imap = get_imap(folder);
        param.server = host;
        param.port = port;
-       
+       param.account = folder->account;
+
        threaded_run(folder, &param, &result, starttls_run);
        
        debug_print("imap starttls - end\n");
@@ -1355,8 +1394,10 @@ int imap_threaded_select(Folder * folder, const char * mb,
 
        if (imap->imap_selection_info->sel_perm_flags) {
                GSList *t_flags = NULL;
-               clistiter *cur =
-                       clist_begin(imap->imap_selection_info->sel_perm_flags);
+               clistiter *cur = NULL;
+               if (imap->imap_selection_info->sel_perm_flags)
+                       cur = clist_begin(imap->imap_selection_info->sel_perm_flags);
+
                for (; cur; cur = clist_next(cur)) {
                        struct mailimap_flag_perm *flag = (struct mailimap_flag_perm *)clist_content(cur);
                        if (flag->fl_type == MAILIMAP_FLAG_PERM_ALL)
@@ -1365,7 +1406,7 @@ int imap_threaded_select(Folder * folder, const char * mb,
                                        flag->fl_flag->fl_type == 6 &&
                                        !strcmp(flag->fl_flag->fl_data.fl_extension, "*"))
                                *can_create_flags = TRUE; 
-                       if (ok_flags) {
+                       if (flag->fl_flag && ok_flags) {
                                MsgPermFlags c_flag = 0;
                                switch (flag->fl_flag->fl_type) {
                                case MAILIMAP_FLAG_ANSWERED:
@@ -1384,8 +1425,14 @@ int imap_threaded_select(Folder * folder, const char * mb,
                                        c_flag = IMAP_FLAG_SEEN;
                                        break;
                                case MAILIMAP_FLAG_KEYWORD:
-                                       if (!strcasecmp(flag->fl_flag->fl_data.fl_keyword, "$Forwarded"))
+                                       if (!strcasecmp(flag->fl_flag->fl_data.fl_keyword, RTAG_FORWARDED))
                                                c_flag = IMAP_FLAG_FORWARDED;
+                                       if (!strcasecmp(flag->fl_flag->fl_data.fl_keyword, RTAG_JUNK))
+                                               c_flag = IMAP_FLAG_SPAM;
+                                       if (!strcasecmp(flag->fl_flag->fl_data.fl_keyword, RTAG_NON_JUNK) ||
+                                           !strcasecmp(flag->fl_flag->fl_data.fl_keyword, RTAG_NO_JUNK) ||
+                                           !strcasecmp(flag->fl_flag->fl_data.fl_keyword, RTAG_NOT_JUNK))
+                                               c_flag = IMAP_FLAG_HAM;
                                        break;
                                default:
                                        break;
@@ -1507,6 +1554,7 @@ struct search_param {
        mailimap * imap;
        int type;
        struct mailimap_set * set;
+       IMAPSearchKey* key;
 };
 
 struct search_result {
@@ -1541,7 +1589,7 @@ static void search_run(struct etpan_thread_op * op)
        int r;
        struct mailimap_search_key * key = NULL;
        struct mailimap_search_key * uid_key = NULL;
-       struct mailimap_search_key * search_type_key;
+       struct mailimap_search_key * search_type_key = NULL;
        clist * search_result;
        
        param = op->param;
@@ -1555,62 +1603,33 @@ static void search_run(struct etpan_thread_op * op)
        } else if (param->type == IMAP_SEARCH_TYPE_SIMPLE) {
                uid_key = mailimap_search_key_new_all();
        }
-       search_type_key = NULL;
        switch (param->type) {
        case IMAP_SEARCH_TYPE_SIMPLE:
                search_type_key = NULL;
                break;
-               
        case IMAP_SEARCH_TYPE_SEEN:
-               search_type_key = mailimap_search_key_new(MAILIMAP_SEARCH_KEY_SEEN,
-                                                         NULL, NULL, NULL, NULL, NULL,
-                                                         NULL, NULL, NULL, NULL, NULL,
-                                                         NULL, NULL, NULL, NULL, 0,
-                                                         NULL, NULL, NULL, NULL, NULL,
-                                                         NULL, 0, NULL, NULL, NULL);
+               search_type_key = imap_search_new(IMAP_SEARCH_CRITERIA_READ, NULL, NULL, 0);
                break;
-               
        case IMAP_SEARCH_TYPE_UNSEEN:
-               search_type_key = mailimap_search_key_new(MAILIMAP_SEARCH_KEY_UNSEEN,
-                                                         NULL, NULL, NULL, NULL, NULL,
-                                                         NULL, NULL, NULL, NULL, NULL,
-                                                         NULL, NULL, NULL, NULL, 0,
-                                                         NULL, NULL, NULL, NULL, NULL,
-                                                         NULL, 0, NULL, NULL, NULL);
+               search_type_key = imap_search_new(IMAP_SEARCH_CRITERIA_UNREAD, NULL, NULL, 0);
                break;
-               
        case IMAP_SEARCH_TYPE_ANSWERED:
-               search_type_key = mailimap_search_key_new(MAILIMAP_SEARCH_KEY_ANSWERED,
-                                                         NULL, NULL, NULL, NULL, NULL,
-                                                         NULL, NULL, NULL, NULL, NULL,
-                                                         NULL, NULL, NULL, NULL, 0,
-                                                         NULL, NULL, NULL, NULL, NULL,
-                                                         NULL, 0, NULL, NULL, NULL);
+               search_type_key = imap_search_new(IMAP_SEARCH_CRITERIA_REPLIED, NULL, NULL, 0);
                break;
-               
        case IMAP_SEARCH_TYPE_FLAGGED:
-               search_type_key = mailimap_search_key_new(MAILIMAP_SEARCH_KEY_FLAGGED,
-                                                         NULL, NULL, NULL, NULL, NULL,
-                                                         NULL, NULL, NULL, NULL, NULL,
-                                                         NULL, NULL, NULL, NULL, 0,
-                                                         NULL, NULL, NULL, NULL, NULL,
-                                                         NULL, 0, NULL, NULL, NULL);
+               search_type_key = imap_search_new(IMAP_SEARCH_CRITERIA_MARKED, NULL, NULL, 0);
                break;
        case IMAP_SEARCH_TYPE_DELETED:
-               search_type_key = mailimap_search_key_new(MAILIMAP_SEARCH_KEY_DELETED,
-                                                         NULL, NULL, NULL, NULL, NULL,
-                                                         NULL, NULL, NULL, NULL, NULL,
-                                                         NULL, NULL, NULL, NULL, 0,
-                                                         NULL, NULL, NULL, NULL, NULL,
-                                                         NULL, 0, NULL, NULL, NULL);
+               search_type_key = imap_search_new(IMAP_SEARCH_CRITERIA_DELETED, NULL, NULL, 0);
                break;
        case IMAP_SEARCH_TYPE_FORWARDED:
-               search_type_key = mailimap_search_key_new(MAILIMAP_SEARCH_KEY_KEYWORD,
-                                                         NULL, NULL, NULL, NULL, NULL,
-                                                         strdup("$Forwarded"), NULL, NULL, NULL, NULL,
-                                                         NULL, NULL, NULL, NULL, 0,
-                                                         NULL, NULL, NULL, NULL, NULL,
-                                                         NULL, 0, NULL, NULL, NULL);
+               search_type_key = imap_search_new(IMAP_SEARCH_CRITERIA_TAG, NULL, RTAG_FORWARDED, 0);
+               break;
+       case IMAP_SEARCH_TYPE_SPAM:
+               search_type_key = imap_search_new(IMAP_SEARCH_CRITERIA_TAG, NULL, RTAG_JUNK, 0);
+               break;
+       case IMAP_SEARCH_TYPE_KEYED:
+               search_type_key = param->key;
                break;
        }
        
@@ -1647,7 +1666,7 @@ static void search_run(struct etpan_thread_op * op)
        debug_print("imap search run - end %i\n", result->error);
 }
 
-int imap_threaded_search(Folder * folder, int search_type,
+int imap_threaded_search(Folder * folder, int search_type, IMAPSearchKey* key,
                         struct mailimap_set * set, clist ** search_result)
 {
        struct search_param param;
@@ -1660,7 +1679,8 @@ int imap_threaded_search(Folder * folder, int search_type,
        param.imap = imap;
        param.set = set;
        param.type = search_type;
-       
+       param.key = key;
+
        threaded_run(folder, &param, &result, search_run);
        
        if (result.error != MAILIMAP_NO_ERROR)
@@ -1674,6 +1694,160 @@ int imap_threaded_search(Folder * folder, int search_type,
 }
 
 
+struct _IMAPSearchKey {
+       struct mailimap_search_key* key;
+};
+
+IMAPSearchKey* imap_search_new(gint             criteria, 
+                               const gchar     *header,
+                               const gchar     *expr,
+                               int              value)
+{
+       char* sk_bcc = NULL;
+       struct mailimap_date* sk_before = NULL;
+       char* sk_body = NULL;
+       char* sk_cc = NULL;
+       char* sk_from = NULL;
+       char* sk_keyword = NULL;
+       struct mailimap_date* sk_on = NULL;
+       struct mailimap_date* sk_since = NULL;
+       char* sk_subject = NULL;
+       char* sk_text = NULL;
+       char* sk_to = NULL;
+       char* sk_unkeyword = NULL;
+       char* sk_header_name = NULL;
+       char* sk_header_value = NULL;
+       uint32_t sk_larger = 0;
+       struct mailimap_search_key* sk_not = NULL;
+       struct mailimap_search_key* sk_or1 = NULL;
+       struct mailimap_search_key* sk_or2 = NULL;
+       struct mailimap_date* sk_sentbefore = NULL;
+       struct mailimap_date* sk_senton = NULL;
+       struct mailimap_date* sk_sentsince = NULL;
+       uint32_t sk_smaller = 0;
+       struct mailimap_set* sk_uid = NULL;
+       struct mailimap_set* sk_set = NULL;
+       clist* sk_multiple = NULL;
+       int etpan_matcher_type;
+
+       switch (criteria) {
+       case IMAP_SEARCH_CRITERIA_ALL: etpan_matcher_type = MAILIMAP_SEARCH_KEY_ALL; break;
+       case IMAP_SEARCH_CRITERIA_READ: etpan_matcher_type = MAILIMAP_SEARCH_KEY_SEEN; break;
+       case IMAP_SEARCH_CRITERIA_UNREAD: etpan_matcher_type = MAILIMAP_SEARCH_KEY_UNSEEN; break;
+       case IMAP_SEARCH_CRITERIA_NEW: etpan_matcher_type = MAILIMAP_SEARCH_KEY_NEW; break;
+       case IMAP_SEARCH_CRITERIA_MARKED: etpan_matcher_type = MAILIMAP_SEARCH_KEY_FLAGGED; break;
+       case IMAP_SEARCH_CRITERIA_REPLIED: etpan_matcher_type = MAILIMAP_SEARCH_KEY_ANSWERED; break;
+       case IMAP_SEARCH_CRITERIA_DELETED: etpan_matcher_type = MAILIMAP_SEARCH_KEY_DELETED; break;
+
+       case IMAP_SEARCH_CRITERIA_TAG:
+               sk_keyword = strdup(expr);
+               etpan_matcher_type = MAILIMAP_SEARCH_KEY_KEYWORD;
+               break;
+
+       case IMAP_SEARCH_CRITERIA_SUBJECT:
+               etpan_matcher_type = MAILIMAP_SEARCH_KEY_SUBJECT;
+               sk_subject = strdup(expr);
+               break;
+
+       case IMAP_SEARCH_CRITERIA_TO:
+               etpan_matcher_type = MAILIMAP_SEARCH_KEY_TO;
+               sk_to = strdup(expr);
+               break;
+
+       case IMAP_SEARCH_CRITERIA_CC:
+               etpan_matcher_type = MAILIMAP_SEARCH_KEY_CC;
+               sk_cc = strdup(expr);
+               break;
+
+       case IMAP_SEARCH_CRITERIA_AGE_GREATER:
+       case IMAP_SEARCH_CRITERIA_AGE_LOWER:
+               {
+                       struct tm tm;
+                       time_t limit = time(NULL) - 60 * 60 * 24 * value;
+
+                       tzset();
+                       localtime_r(&limit, &tm);
+                       if (criteria == IMAP_SEARCH_CRITERIA_AGE_GREATER) {
+                               etpan_matcher_type = MAILIMAP_SEARCH_KEY_SENTBEFORE;
+                               sk_sentbefore = mailimap_date_new(tm.tm_mday, tm.tm_mon, tm.tm_year + 1900);
+                       } else {
+                               etpan_matcher_type = MAILIMAP_SEARCH_KEY_SENTSINCE;
+                               sk_sentsince = mailimap_date_new(tm.tm_mday, tm.tm_mon, tm.tm_year + 1900);
+                       }
+                       break;
+               }
+
+       case IMAP_SEARCH_CRITERIA_BODY:
+               etpan_matcher_type = MAILIMAP_SEARCH_KEY_BODY;
+               sk_body = strdup(expr);
+               break;
+
+       case IMAP_SEARCH_CRITERIA_MESSAGE:
+               etpan_matcher_type = MAILIMAP_SEARCH_KEY_TEXT;
+               sk_text = strdup(expr);
+               break;
+
+       case IMAP_SEARCH_CRITERIA_HEADER:
+               etpan_matcher_type = MAILIMAP_SEARCH_KEY_HEADER;
+               sk_header_name = strdup(header);
+               sk_header_value = strdup(expr);
+               break;
+
+       case IMAP_SEARCH_CRITERIA_FROM:
+               etpan_matcher_type = MAILIMAP_SEARCH_KEY_FROM;
+               sk_from = strdup(expr);
+               break;
+
+       case IMAP_SEARCH_CRITERIA_SIZE_GREATER:
+               etpan_matcher_type = MAILIMAP_SEARCH_KEY_LARGER;
+               sk_larger = value;
+               break;
+
+       case IMAP_SEARCH_CRITERIA_SIZE_SMALLER:
+               etpan_matcher_type = MAILIMAP_SEARCH_KEY_SMALLER;
+               sk_smaller = value;
+               break;
+
+       default:
+               return NULL;
+       }
+
+       return mailimap_search_key_new(etpan_matcher_type,
+               sk_bcc, sk_before, sk_body, sk_cc, sk_from, sk_keyword,
+               sk_on, sk_since, sk_subject, sk_text, sk_to,
+               sk_unkeyword, sk_header_name,sk_header_value, sk_larger,
+               sk_not, sk_or1, sk_or2, sk_sentbefore, sk_senton,
+               sk_sentsince, sk_smaller, sk_uid, sk_set, sk_multiple);
+}
+
+IMAPSearchKey* imap_search_not(IMAPSearchKey* key)
+{
+       return mailimap_search_key_new_not(key);
+}
+
+IMAPSearchKey* imap_search_or(IMAPSearchKey* l, IMAPSearchKey* r)
+{
+       return mailimap_search_key_new_or(l, r);
+}
+
+IMAPSearchKey* imap_search_and(IMAPSearchKey* l, IMAPSearchKey* r)
+{
+       IMAPSearchKey* result = mailimap_search_key_new_multiple_empty();
+       mailimap_search_key_multiple_add(result, l);
+       mailimap_search_key_multiple_add(result, r);
+
+       return result;
+}
+
+void imap_search_free(IMAPSearchKey* key)
+{
+       if (!key)
+           return;
+
+       mailimap_search_key_free(key);
+}
+
+
 
 static int imap_get_msg_att_info(struct mailimap_msg_att * msg_att,
                                 uint32_t * puid,
@@ -1684,7 +1858,7 @@ static int imap_get_msg_att_info(struct mailimap_msg_att * msg_att,
 static int
 result_to_uid_list(clist * fetch_result, carray ** result)
 {
-       clistiter * cur;
+       clistiter * cur = NULL;
        int r;
        int res;
        carray * tab;
@@ -1695,8 +1869,10 @@ result_to_uid_list(clist * fetch_result, carray ** result)
                goto err;
        }
        
-       for(cur = clist_begin(fetch_result) ; cur != NULL ;
-           cur = clist_next(cur)) {
+       if (fetch_result)
+               cur = clist_begin(fetch_result);
+
+       for(; cur != NULL ; cur = clist_next(cur)) {
                struct mailimap_msg_att * msg_att;
                uint32_t uid;
                uint32_t * puid;
@@ -1884,7 +2060,7 @@ static int imap_flags_to_flags(struct mailimap_msg_att_dynamic * att_dyn, GSList
 static int
 result_to_uid_flags_list(clist * fetch_result, carray ** result)
 {
-       clistiter * cur;
+       clistiter * cur = NULL;
        int r;
        int res;
        carray * tab;
@@ -1895,9 +2071,11 @@ result_to_uid_flags_list(clist * fetch_result, carray ** result)
                res = MAILIMAP_ERROR_MEMORY;
                goto err;
        }
-       
-       for(cur = clist_begin(fetch_result) ; cur != NULL ;
-           cur = clist_next(cur)) {
+
+       if (fetch_result)
+               cur = clist_begin(fetch_result);
+
+       for(; cur != NULL ; cur = clist_next(cur)) {
                struct mailimap_msg_att * msg_att;
                uint32_t uid;
                uint32_t * puid;
@@ -1958,8 +2136,7 @@ result_to_uid_flags_list(clist * fetch_result, carray ** result)
   
  free_list:
        imap_fetch_uid_flags_list_free(tab);
-       slist_free_strings(tags);
-       g_slist_free(tags);
+       slist_free_strings_full(tags);
  err:
        return res;
 }
@@ -2176,7 +2353,7 @@ static int imap_fetch(mailimap * imap,
                return r;
        }
   
-       if (clist_begin(fetch_result) == NULL) {
+       if (fetch_result == NULL || clist_begin(fetch_result) == NULL) {
                mailimap_fetch_list_free(fetch_result);
                return MAILIMAP_ERROR_FETCH;
        }
@@ -2186,8 +2363,12 @@ static int imap_fetch(mailimap * imap,
        text = NULL;
        text_length = 0;
 
-       for(cur = clist_begin(msg_att->att_list) ; cur != NULL ;
-           cur = clist_next(cur)) {
+       if (msg_att->att_list)
+               cur = clist_begin(msg_att->att_list);
+       else
+               cur = NULL;
+
+       for(; cur != NULL ; cur = clist_next(cur)) {
                msg_att_item = clist_content(cur);
 
                if (msg_att_item->att_type == MAILIMAP_MSG_ATT_ITEM_STATIC) {
@@ -2278,7 +2459,7 @@ static int imap_fetch_header(mailimap * imap,
     return r;
   }
 
-  if (clist_begin(fetch_result) == NULL) {
+  if (fetch_result == NULL || clist_begin(fetch_result) == NULL) {
     mailimap_fetch_list_free(fetch_result);
     return MAILIMAP_ERROR_FETCH;
   }
@@ -2288,8 +2469,12 @@ static int imap_fetch_header(mailimap * imap,
   text = NULL;
   text_length = 0;
 
-  for(cur = clist_begin(msg_att->att_list) ; cur != NULL ;
-      cur = clist_next(cur)) {
+  if (msg_att->att_list)
+     cur = clist_begin(msg_att->att_list);
+  else
+     cur = NULL;
+
+  for(; cur != NULL ; cur = clist_next(cur)) {
     msg_att_item = clist_content(cur);
 
     if (msg_att_item->att_type == MAILIMAP_MSG_ATT_ITEM_STATIC) {
@@ -2361,7 +2546,7 @@ static void fetch_content_run(struct etpan_thread_op * op)
        result->error = r;
        
        if (r == MAILIMAP_NO_ERROR) {
-               fd = open(param->filename, O_RDWR | O_CREAT, 0600);
+               fd = g_open(param->filename, O_RDWR | O_CREAT, 0600);
                if (fd < 0) {
                        result->error = MAILIMAP_ERROR_FETCH;
                        goto free;
@@ -2468,8 +2653,14 @@ static int imap_flags_to_flags(struct mailimap_msg_att_dynamic * att_dyn, GSList
                                flags &= ~MSG_NEW;
                                break;
                        case MAILIMAP_FLAG_KEYWORD:
-                               if (!strcasecmp(flag_fetch->fl_flag->fl_data.fl_keyword, "$Forwarded"))
+                               if (!strcasecmp(flag_fetch->fl_flag->fl_data.fl_keyword, RTAG_FORWARDED))
                                        flags |= MSG_FORWARDED;
+                               else if (!strcasecmp(flag_fetch->fl_flag->fl_data.fl_keyword, RTAG_JUNK)) 
+                                       flags |= MSG_SPAM;
+                               else if (!strcasecmp(flag_fetch->fl_flag->fl_data.fl_keyword, RTAG_NON_JUNK) ||
+                                        !strcasecmp(flag_fetch->fl_flag->fl_data.fl_keyword, RTAG_NO_JUNK) ||
+                                        !strcasecmp(flag_fetch->fl_flag->fl_data.fl_keyword, RTAG_NOT_JUNK)) 
+                                       flags &= ~MSG_SPAM;
                                else if (s_tags)
                                        tags = g_slist_prepend(tags, g_strdup(flag_fetch->fl_flag->fl_data.fl_keyword));
                                break;
@@ -2498,8 +2689,11 @@ static int imap_get_msg_att_info(struct mailimap_msg_att * msg_att,
   ref_size = 0;
   att_dyn = NULL;
 
-  for(item_cur = clist_begin(msg_att->att_list) ; item_cur != NULL ;
-      item_cur = clist_next(item_cur)) {
+  if (msg_att->att_list)
+     item_cur = clist_begin(msg_att->att_list);
+  else
+     item_cur = NULL;
+  for(; item_cur != NULL ; item_cur = clist_next(item_cur)) {
     struct mailimap_msg_att_item * item;
 
     item = clist_content(item_cur);
@@ -2570,59 +2764,54 @@ imap_fetch_result_to_envelop_list(clist * fetch_result,
                                  carray ** p_env_list)
 {
        clistiter * cur;
-       unsigned int i;
        carray * env_list;
 
-       i = 0;
        env_list = carray_new(16);
   
-       for(cur = clist_begin(fetch_result) ; cur != NULL ;
-           cur = clist_next(cur)) {
-               struct mailimap_msg_att * msg_att;
-               struct imap_fetch_env_info * env_info;
-               GSList *tags = NULL;
-
-               msg_att = clist_content(cur);
-
-               env_info = fetch_to_env_info(msg_att, &tags);
-               if (!env_info)
-                       return MAILIMAP_ERROR_MEMORY;
-               carray_add(env_list, env_info, NULL);
-               carray_add(env_list, tags, NULL);
+       if (fetch_result) {
+               for(cur = clist_begin(fetch_result) ; cur != NULL ;
+                   cur = clist_next(cur)) {
+                       struct mailimap_msg_att * msg_att;
+                       struct imap_fetch_env_info * env_info;
+                       GSList *tags = NULL;
+
+                       msg_att = clist_content(cur);
+
+                       env_info = fetch_to_env_info(msg_att, &tags);
+                       if (!env_info)
+                               return MAILIMAP_ERROR_MEMORY;
+                       carray_add(env_list, env_info, NULL);
+                       carray_add(env_list, tags, NULL);
+               }
+               * p_env_list = env_list;
+       } else {
+               * p_env_list = NULL;
        }
-  
-       * p_env_list = env_list;
-  
+
        return MAIL_NO_ERROR;
 }
 
 static int imap_add_envelope_fetch_att(struct mailimap_fetch_type * fetch_type)
 {
        struct mailimap_fetch_att * fetch_att;
-       int r;
+       int i;
        char * header;
        clist * hdrlist;
        struct mailimap_header_list * imap_hdrlist;
        struct mailimap_section * section;
+       char *headers[] = {
+                       "Date", "From", "To", "Cc", "Subject", "Message-ID",
+                       "References", "In-Reply-To", NULL
+               };
 
        hdrlist = clist_new();
-  
-       header = strdup("Date");
-       r = clist_append(hdrlist, header);
-       header = strdup("From");
-       r = clist_append(hdrlist, header);
-       header = strdup("To");
-       r = clist_append(hdrlist, header);
-       header = strdup("Cc");
-       r = clist_append(hdrlist, header);
-       header = strdup("Subject");
-       r = clist_append(hdrlist, header);
-       header = strdup("Message-ID");
-       r = clist_append(hdrlist, header);
-       header = strdup("References");
-       r = clist_append(hdrlist, header);
-       header = strdup("In-Reply-To");
-       r = clist_append(hdrlist, header);
+       i = 0;
+       while (headers[i] != NULL) {
+               header = strdup(headers[i]);
+               if (header == NULL || clist_append(hdrlist, header) != 0)
+                       return MAIL_ERROR_MEMORY;
+               ++i;
+       }
   
        imap_hdrlist = mailimap_header_list_new(hdrlist);
        section = mailimap_section_new_header_fields(imap_hdrlist);
@@ -2694,7 +2883,7 @@ imap_get_envelopes_list(mailimap * imap, struct mailimap_set * set,
                return r;
        }
        
-       if (clist_begin(fetch_result) == NULL) {
+       if (fetch_result == NULL || clist_begin(fetch_result) == NULL) {
                res = MAILIMAP_ERROR_FETCH;
                debug_print("clist_begin = NULL\n");
                goto err;
@@ -2850,7 +3039,7 @@ static void append_run(struct etpan_thread_op * op)
        }
        size = stat_buf.st_size;
        
-       fd = open(param->filename, O_RDONLY);
+       fd = g_open(param->filename, O_RDONLY, 0);
        if (fd < 0) {
                result->error = MAILIMAP_ERROR_APPEND;
                return;
@@ -3136,7 +3325,7 @@ static void do_exec_command(int fd, const char * command,
        /* Detach from the controlling tty if we have one. Otherwise,
           SSH might do something stupid like trying to use it instead
           of running $SSH_ASKPASS. Doh. */
-       fd = open("/dev/tty", O_RDONLY);
+       fd = g_open("/dev/tty", O_RDONLY, 0);
        if (fd != -1) {
                ioctl(fd, TIOCNOTTY, NULL);
                close(fd);
@@ -3288,7 +3477,7 @@ void imap_threaded_cancel(Folder * folder)
 void imap_main_init(void)
 {
 }
-void imap_main_done(void)
+void imap_main_done(gboolean have_connectivity)
 {
 }
 void imap_main_set_timeout(int sec)