2008-01-24 [colin] 3.2.0cvs67
[claws.git] / src / etpan / imap-thread.c
index 531df68f8d8cc9e874c561e4af97a45d0ac6d1fb..5c74747419d663ab4f53a425b273751d35f84ae6 100644 (file)
@@ -1,3 +1,22 @@
+/*
+ * Claws Mail -- a GTK+ based, lightweight, and fast e-mail client
+ * Copyright (C) 2005-2007 DINH Viet Hoa and the Claws Mail team
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ * 
+ */
+
 #ifdef HAVE_CONFIG_H
 #  include "config.h"
 #endif
 #include <sys/socket.h>
 #endif
 #include <fcntl.h>
+#ifndef G_OS_WIN32
 #include <sys/mman.h>
 #include <sys/wait.h>
-
+#endif
 #include <gtk/gtk.h>
 #include <log.h>
 #include "etpan-thread-manager.h"
 #include "utils.h"
+#include "mainwindow.h"
 #include "ssl_certificate.h"
 #include "socket.h"
+#include "remotefolder.h"
 
 #define DISABLE_LOG_DURING_LOGIN
 
@@ -31,6 +53,28 @@ static chash * session_hash = NULL;
 static guint thread_manager_signal = 0;
 static GIOChannel * io_channel = NULL;
 
+static void delete_imap(Folder *folder, mailimap *imap)
+{
+       chashdatum key;
+       chashdatum value;
+
+       key.data = &folder;
+       key.len = sizeof(folder);
+       value.data = imap;
+       value.len = 0;
+       chash_delete(session_hash, &key, NULL);
+       
+       key.data = &imap;
+       key.len = sizeof(imap);
+       chash_delete(courier_workaround_hash, &key, NULL);
+       if (imap && imap->imap_stream) {
+               /* we don't want libetpan to logout */
+               mailstream_close(imap->imap_stream);
+               imap->imap_stream = NULL;
+       }
+       debug_print("removing mailimap %p\n", imap);
+       mailimap_free(imap);    
+}
 
 static gboolean thread_manager_event(GIOChannel * source,
     GIOCondition condition,
@@ -41,12 +85,21 @@ static gboolean thread_manager_event(GIOChannel * source,
        return TRUE;
 }
 
+static void imap_logger_noop(int direction, const char * str, size_t size) 
+{
+       /* inhibit logging */
+}
+
 static void imap_logger_cmd(int direction, const char * str, size_t size) 
 {
        gchar *buf;
        gchar **lines;
        int i = 0;
 
+       if (size > 8192) {
+               log_print(LOG_PROTOCOL, "IMAP4%c [CMD data - %zd bytes]\n", direction?'>':'<', size);
+               return;
+       }
        buf = malloc(size+1);
        memset(buf, 0, size+1);
        strncpy(buf, str, size);
@@ -65,7 +118,7 @@ static void imap_logger_cmd(int direction, const char * str, size_t size)
        lines = g_strsplit(buf, "\n", -1);
 
        while (lines[i] && *lines[i]) {
-               log_print("IMAP4%c %s\n", direction?'>':'<', lines[i]);
+               log_print(LOG_PROTOCOL, "IMAP4%c %s\n", direction?'>':'<', lines[i]);
                i++;
        }
        g_strfreev(lines);
@@ -78,6 +131,11 @@ static void imap_logger_fetch(int direction, const char * str, size_t size)
        gchar **lines;
        int i = 0;
 
+       if (size > 128 && !direction) {
+               log_print(LOG_PROTOCOL, "IMAP4%c [FETCH data - %zd bytes]\n", direction?'>':'<', size);
+               return;
+       }
+       
        buf = malloc(size+1);
        memset(buf, 0, size+1);
        strncpy(buf, str, size);
@@ -96,11 +154,11 @@ static void imap_logger_fetch(int direction, const char * str, size_t size)
 
        if (direction != 0 || (buf[0] == '*' && buf[1] == ' ') || size < 32) {
                while (lines[i] && *lines[i]) {
-                       log_print("IMAP4%c %s\n", direction?'>':'<', lines[i]);
+                       log_print(LOG_PROTOCOL, "IMAP4%c %s\n", direction?'>':'<', lines[i]);
                        i++;
                }
        } else {
-               log_print("IMAP4%c [data - %zd bytes]\n", direction?'>':'<', size);
+               log_print(LOG_PROTOCOL, "IMAP4%c [data - %zd bytes]\n", direction?'>':'<', size);
        }
        g_strfreev(lines);
        free(buf);
@@ -112,6 +170,10 @@ static void imap_logger_uid(int direction, const char * str, size_t size)
        gchar **lines;
        int i = 0;
 
+       if (size > 8192) {
+               log_print(LOG_PROTOCOL, "IMAP4%c [UID data - %zd bytes]\n", direction?'>':'<', size);
+               return;
+       }
        buf = malloc(size+1);
        memset(buf, 0, size+1);
        strncpy(buf, str, size);
@@ -131,11 +193,11 @@ static void imap_logger_uid(int direction, const char * str, size_t size)
        while (lines[i] && *lines[i]) {
                int llen = strlen(lines[i]);
                if (llen < 64)
-                       log_print("IMAP4%c %s\n", direction?'>':'<', lines[i]);
+                       log_print(LOG_PROTOCOL, "IMAP4%c %s\n", direction?'>':'<', lines[i]);
                else {
                        gchar tmp[64];
                        strncpy2(tmp, lines[i], 63);
-                       log_print("IMAP4%c %s[... - %zd bytes more]\n", direction?'>':'<', tmp,
+                       log_print(LOG_PROTOCOL, "IMAP4%c %s[... - %d bytes more]\n", direction?'>':'<', tmp,
                                  llen-64);
                }
                i++;
@@ -144,12 +206,19 @@ static void imap_logger_uid(int direction, const char * str, size_t size)
        free(buf);
 }
 
-void imap_logger_append(int direction, const char * str, size_t size) 
+static void imap_logger_append(int direction, const char * str, size_t size) 
 {
        gchar *buf;
        gchar **lines;
        int i = 0;
 
+       if (size > 8192) {
+               log_print(LOG_PROTOCOL, "IMAP4%c [APPEND data - %zd bytes]\n", direction?'>':'<', size);
+               return;
+       } else if (direction == 0 && size > 64) {
+               log_print(LOG_PROTOCOL, "IMAP4%c [APPEND data - %zd bytes]\n", direction?'>':'<', size);
+               return;
+       } 
        buf = malloc(size+1);
        memset(buf, 0, size+1);
        strncpy(buf, str, size);
@@ -168,18 +237,19 @@ void imap_logger_append(int direction, const char * str, size_t size)
 
        if (direction == 0 || (buf[0] == '*' && buf[1] == ' ') || size < 64) {
                while (lines[i] && *lines[i]) {
-                       log_print("IMAP4%c %s\n", direction?'>':'<', lines[i]);
+                       log_print(LOG_PROTOCOL, "IMAP4%c %s\n", direction?'>':'<', lines[i]);
                        i++;
                }
        } else {
-               log_print("IMAP4%c [data - %zd bytes]\n", direction?'>':'<', size);
+               log_print(LOG_PROTOCOL, "IMAP4%c [data - %zd bytes]\n", direction?'>':'<', size);
        }
        g_strfreev(lines);
        free(buf);
 }
 
 #define ETPAN_DEFAULT_NETWORK_TIMEOUT 60
-static gboolean etpan_skip_ssl_cert_check = FALSE;
+gboolean etpan_skip_ssl_cert_check = FALSE;
+extern void mailsasl_ref(void);
 
 void imap_main_init(gboolean skip_ssl_cert_check)
 {
@@ -191,7 +261,8 @@ void imap_main_init(gboolean skip_ssl_cert_check)
        
        mailstream_debug = 1;
        mailstream_logger = imap_logger_cmd;
-
+       mailsasl_ref();
+       
        imap_hash = chash_new(CHASH_COPYKEY, CHASH_DEFAULTSIZE);
        session_hash = chash_new(CHASH_COPYKEY, CHASH_DEFAULTSIZE);
        courier_workaround_hash = chash_new(CHASH_COPYKEY, CHASH_DEFAULTSIZE);
@@ -217,6 +288,9 @@ void imap_main_set_timeout(int sec)
 void imap_main_done(void)
 {
        etpan_thread_manager_stop(thread_manager);
+#if defined(__NetBSD__) || defined(__OpenBSD__) || defined(__FreeBSD__)
+       return;
+#endif
        etpan_thread_manager_join(thread_manager);
        
        g_source_remove(thread_manager_signal);
@@ -298,20 +372,30 @@ static mailimap * get_imap(Folder * folder)
                return NULL;
        
        imap = value.data;
-       
+       debug_print("found imap %p\n", imap);
        return imap;
 }
 
+static gboolean cb_show_error(gpointer data)
+{
+       mainwindow_show_error();
+       return FALSE;
+}
 
 static void generic_cb(int cancelled, void * result, void * callback_data)
 {
-       int * p_finished;
+       struct etpan_thread_op * op;
        
-       p_finished = callback_data;
+       op = (struct etpan_thread_op *) callback_data;
 
        debug_print("generic_cb\n");
-       
-       * p_finished = 1;
+       if (op->imap && op->imap->imap_response_info &&
+           op->imap->imap_response_info->rsp_alert) {
+               log_error(LOG_PROTOCOL, "IMAP4< Alert: %s\n", 
+                       op->imap->imap_response_info->rsp_alert);
+               g_timeout_add(10, cb_show_error, NULL);
+       } 
+       op->finished = 1;
 }
 
 static void threaded_run(Folder * folder, void * param, void * result,
@@ -319,26 +403,27 @@ static void threaded_run(Folder * folder, void * param, void * result,
 {
        struct etpan_thread_op * op;
        struct etpan_thread * thread;
-       int finished;
        
        imap_folder_ref(folder);
 
        op = etpan_thread_op_new();
+       
+       op->imap = get_imap(folder);
        op->param = param;
        op->result = result;
        
        op->cancellable = 0;
        op->run = func;
        op->callback = generic_cb;
-       op->callback_data = &finished;
+       op->callback_data = op;
        op->cleanup = NULL;
        
-       finished = 0;
+       op->finished = 0;
        
        thread = get_thread(folder);
        etpan_thread_op_schedule(thread, op);
        
-       while (!finished) {
+       while (!op->finished) {
                gtk_main_iteration();
        }
        
@@ -360,6 +445,13 @@ struct connect_result {
        int error;
 };
 
+#define CHECK_IMAP() {                                         \
+       if (!param->imap) {                                     \
+               result->error = MAILIMAP_ERROR_BAD_STATE;       \
+               return;                                         \
+       }                                                       \
+}
+
 static void connect_run(struct etpan_thread_op * op)
 {
        int r;
@@ -369,6 +461,8 @@ static void connect_run(struct etpan_thread_op * op)
        param = op->param;
        result = op->result;
        
+       CHECK_IMAP();
+
        r = mailimap_socket_connect(param->imap,
                                    param->server, param->port);
        
@@ -382,10 +476,17 @@ int imap_threaded_connect(Folder * folder, const char * server, int port)
        struct connect_result result;
        chashdatum key;
        chashdatum value;
-       mailimap * imap;
+       mailimap * imap, * oldimap;
        
+       oldimap = get_imap(folder);
+
        imap = mailimap_new(0, NULL);
        
+       if (oldimap) {
+               debug_print("deleting old imap %p\n", oldimap);
+               delete_imap(folder, oldimap);
+       }
+       
        key.data = &folder;
        key.len = sizeof(folder);
        value.data = imap;
@@ -399,7 +500,7 @@ int imap_threaded_connect(Folder * folder, const char * server, int port)
        refresh_resolvers();
        threaded_run(folder, &param, &result, connect_run);
        
-       debug_print("connect ok %i\n", result.error);
+       debug_print("connect ok %i with imap %p\n", result.error, imap);
        
        return result.error;
 }
@@ -409,14 +510,14 @@ static int etpan_certificate_check(const unsigned char *certificate, int len, vo
 #ifdef USE_OPENSSL
        struct connect_param *param = (struct connect_param *)data;
        X509 *cert = NULL;
-
+       
        if (certificate == NULL || len < 0) {
                g_warning("no cert presented.\n");
                return 0;
        }
-       cert = d2i_X509(NULL, (unsigned char **) &certificate, len);
+       cert = d2i_X509(NULL, (const unsigned char **)&certificate, len);
        if (cert == NULL) {
-               g_warning("can't get cert\n");
+               g_warning("IMAP: can't get cert\n");
                return 0;
        } else if (ssl_certificate_check(cert, NULL,
                (gchar *)param->server, (gushort)param->port) == TRUE) {
@@ -426,9 +527,33 @@ static int etpan_certificate_check(const unsigned char *certificate, int len, vo
                X509_free(cert);
                return -1;
        }
-#else
-       return 0;
+#elif USE_GNUTLS
+       struct connect_param *param = (struct connect_param *)data;
+       gnutls_x509_crt cert = NULL;
+       gnutls_datum tmp;
+       
+       if (certificate == NULL || len < 0) {
+               g_warning("no cert presented.\n");
+               return 0;
+       }
+       
+       tmp.data = malloc(len);
+       memcpy(tmp.data, certificate, len);
+       tmp.size = len;
+       gnutls_x509_crt_init(&cert);
+       if (gnutls_x509_crt_import(cert, &tmp, GNUTLS_X509_FMT_DER) < 0) {
+               g_warning("IMAP: can't get cert\n");
+               return 0;
+       } else if (ssl_certificate_check(cert, (guint)-1, NULL,
+               (gchar *)param->server, (gushort)param->port) == TRUE) {
+               gnutls_x509_crt_deinit(cert);
+               return 0;
+       } else {
+               gnutls_x509_crt_deinit(cert);
+               return -1;
+       }
 #endif
+       return 0;
 }
 
 static void connect_ssl_run(struct etpan_thread_op * op)
@@ -440,6 +565,8 @@ static void connect_ssl_run(struct etpan_thread_op * op)
        param = op->param;
        result = op->result;
        
+       CHECK_IMAP();
+
        r = mailimap_ssl_connect(param->imap,
                                 param->server, param->port);
        result->error = r;
@@ -451,12 +578,19 @@ int imap_threaded_connect_ssl(Folder * folder, const char * server, int port)
        struct connect_result result;
        chashdatum key;
        chashdatum value;
-       mailimap * imap;
+       mailimap * imap, * oldimap;
        unsigned char *certificate = NULL;
        int cert_len;
+       
+       oldimap = get_imap(folder);
 
        imap = mailimap_new(0, NULL);
        
+       if (oldimap) {
+               debug_print("deleting old imap %p\n", oldimap);
+               delete_imap(folder, oldimap);
+       }
+
        key.data = &folder;
        key.len = sizeof(folder);
        value.data = imap;
@@ -469,15 +603,16 @@ int imap_threaded_connect_ssl(Folder * folder, const char * server, int port)
        
        refresh_resolvers();
        threaded_run(folder, &param, &result, connect_ssl_run);
-       
-       if (result.error >= 0 && !etpan_skip_ssl_cert_check) {
-               cert_len = mailstream_ssl_get_certificate(imap->imap_stream, &certificate);
+
+       if ((result.error == MAILIMAP_NO_ERROR_AUTHENTICATED ||
+            result.error == MAILIMAP_NO_ERROR_NON_AUTHENTICATED) && !etpan_skip_ssl_cert_check) {
+               cert_len = (int)mailstream_ssl_get_certificate(imap->imap_stream, &certificate);
                if (etpan_certificate_check(certificate, cert_len, &param) < 0)
                        return -1;
                if (certificate) 
                        free(certificate); 
        }
-       debug_print("connect %d\n", result.error);
+       debug_print("connect %d with imap %p\n", result.error, imap);
        
        return result.error;
 }
@@ -501,6 +636,8 @@ static void capability_run(struct etpan_thread_op * op)
        param = op->param;
        result = op->result;
        
+       CHECK_IMAP();
+
        r = mailimap_capability(param->imap, &caps);
        
        result->error = r;
@@ -546,6 +683,8 @@ static void disconnect_run(struct etpan_thread_op * op)
        param = op->param;
        result = op->result;
        
+       CHECK_IMAP();
+
        r = mailimap_logout(param->imap);
        
        result->error = r;
@@ -555,8 +694,6 @@ void imap_threaded_disconnect(Folder * folder)
 {
        struct connect_param param;
        struct connect_result result;
-       chashdatum key;
-       chashdatum value;
        mailimap * imap;
        
        imap = get_imap(folder);
@@ -569,17 +706,12 @@ void imap_threaded_disconnect(Folder * folder)
        
        threaded_run(folder, &param, &result, disconnect_run);
        
-       key.data = &folder;
-       key.len = sizeof(folder);
-       value.data = imap;
-       value.len = 0;
-       chash_delete(session_hash, &key, NULL);
-       
-       key.data = &imap;
-       key.len = sizeof(imap);
-       chash_delete(courier_workaround_hash, &key, NULL);
-       
-       mailimap_free(imap);
+       if (imap == get_imap(folder)) {
+               debug_print("deleting old imap %p\n", imap);
+               delete_imap(folder, imap);
+       } else {
+               debug_print("imap already deleted %p\n", imap);
+       }
        
        debug_print("disconnect ok\n");
 }
@@ -589,6 +721,7 @@ struct list_param {
        mailimap * imap;
        const char * base;
        const char * wildcard;
+       gboolean sub_only;
 };
 
 struct list_result {
@@ -604,11 +737,24 @@ static void list_run(struct etpan_thread_op * op)
        clist * list;
        
        param = op->param;
+       result = op->result;
+
+       CHECK_IMAP();
+
        list = NULL;
-       r = mailimap_list(param->imap, param->base,
-                         param->wildcard, &list);
        
-       result = op->result;
+       if (param->base == NULL || param->wildcard == NULL) {
+               result->list = list;
+               result->error = -1;
+               debug_print("no base or wildcard (%p %p)\n", param->base, param->wildcard);
+               return;
+       }
+       if (param->sub_only)
+               r = mailimap_lsub(param->imap, param->base,
+                         param->wildcard, &list);
+       else
+               r = mailimap_list(param->imap, param->base,
+                         param->wildcard, &list);
        result->error = r;
        result->list = list;
        debug_print("imap list run - end\n");
@@ -626,7 +772,8 @@ int imap_threaded_list(Folder * folder, const char * base,
        param.imap = get_imap(folder);
        param.base = base;
        param.wildcard = wildcard;
-       
+       param.sub_only = FALSE;
+
        threaded_run(folder, &param, &result, list_run);
        
        * p_result = result.list;
@@ -636,13 +783,86 @@ int imap_threaded_list(Folder * folder, const char * base,
        return result.error;
 }
 
+int imap_threaded_lsub(Folder * folder, const char * base,
+                      const char * wildcard,
+                      clist ** p_result)
+{
+       struct list_param param;
+       struct list_result result;
+       
+       debug_print("imap lsub - begin\n");
+       
+       param.imap = get_imap(folder);
+       param.base = base;
+       param.wildcard = wildcard;
+       param.sub_only = TRUE;
+       
+       threaded_run(folder, &param, &result, list_run);
+       
+       * p_result = result.list;
+       
+       debug_print("imap lsub - end %p\n", result.list);
+       
+       return result.error;
+}
+
+struct subscribe_param {
+       mailimap * imap;
+       const char * mb;
+       gboolean subscribe;
+};
+
+struct subscribe_result {
+       int error;
+};
+
+static void subscribe_run(struct etpan_thread_op * op)
+{
+       struct subscribe_param * param;
+       struct subscribe_result * result;
+       int r;
+       
+       param = op->param;
+       result = op->result;
+
+       CHECK_IMAP();
+
+       if (param->mb == NULL) {
+               result->error = -1;
+               debug_print("no mb\n");
+               return;
+       }
+       if (param->subscribe)
+               r = mailimap_subscribe(param->imap, param->mb);
+       else
+               r = mailimap_unsubscribe(param->imap, param->mb);
+       result->error = r;
+       debug_print("imap %ssubscribe run - end %d\n", param->subscribe?"":"un", r);
+}
+
+int imap_threaded_subscribe(Folder * folder, const char * mb,
+                      gboolean subscribe)
+{
+       struct subscribe_param param;
+       struct subscribe_result result;
+       
+       debug_print("imap list - begin\n");
+       
+       param.imap = get_imap(folder);
+       param.mb = mb;
+       param.subscribe = subscribe;
 
+       threaded_run(folder, &param, &result, subscribe_run);
+       
+       return result.error;
+}
 
 struct login_param {
        mailimap * imap;
        const char * login;
        const char * password;
        const char * type;
+       const char * server;
 };
 
 struct login_result {
@@ -659,7 +879,10 @@ static void login_run(struct etpan_thread_op * op)
 #endif
        
        param = op->param;
-       
+       result = op->result;
+
+       CHECK_IMAP();
+
 #ifdef DISABLE_LOG_DURING_LOGIN
        old_debug = mailstream_debug;
        mailstream_debug = 0;
@@ -667,6 +890,11 @@ static void login_run(struct etpan_thread_op * op)
        if (!strcmp(param->type, "LOGIN"))
                r = mailimap_login(param->imap,
                           param->login, param->password);
+       else if (!strcmp(param->type, "GSSAPI"))
+               r = mailimap_authenticate(param->imap,
+                       param->type, param->server, NULL, NULL,
+                       param->login, param->login,
+                       param->password, NULL);
        else 
                r = mailimap_authenticate(param->imap,
                        param->type, NULL, NULL, NULL,
@@ -676,8 +904,9 @@ static void login_run(struct etpan_thread_op * op)
        mailstream_debug = old_debug;
 #endif
        
-       result = op->result;
        result->error = r;
+       if (param->imap->imap_response)
+               imap_logger_cmd(0, param->imap->imap_response, strlen(param->imap->imap_response));
        debug_print("imap login run - end %i\n", r);
 }
 
@@ -694,6 +923,10 @@ int imap_threaded_login(Folder * folder,
        param.login = login;
        param.password = password;
        param.type = type;
+       if (folder && folder->account)
+               param.server = folder->account->recv_server;
+       else
+               param.server = NULL;
 
        threaded_run(folder, &param, &result, login_run);
        
@@ -723,6 +956,8 @@ static void status_run(struct etpan_thread_op * op)
        param = op->param;
        result = op->result;
        
+       CHECK_IMAP();
+
        r = mailimap_status(param->imap, param->mb,
                            param->status_att_list,
                            &result->data_status);
@@ -794,14 +1029,22 @@ static void noop_run(struct etpan_thread_op * op)
        int r;
        
        param = op->param;
+       result = op->result;
+
+       CHECK_IMAP();
+
        r = mailimap_noop(param->imap);
        
-       result = op->result;
        result->error = r;
        debug_print("imap noop run - end %i\n", r);
 }
 
-int imap_threaded_noop(Folder * folder, unsigned int * p_exists)
+int imap_threaded_noop(Folder * folder, unsigned int * p_exists, 
+                      unsigned int *p_recent, 
+                      unsigned int *p_expunge,
+                      unsigned int *p_unseen,
+                      unsigned int *p_uidnext,
+                      unsigned int *p_uidval)
 {
        struct noop_param param;
        struct noop_result result;
@@ -811,17 +1054,31 @@ int imap_threaded_noop(Folder * folder, unsigned int * p_exists)
        
        imap = get_imap(folder);
        param.imap = imap;
-       
+
        threaded_run(folder, &param, &result, noop_run);
        
-       if (imap->imap_selection_info != NULL) {
+       if (result.error == 0 && imap && imap->imap_selection_info != NULL) {
                * p_exists = imap->imap_selection_info->sel_exists;
-       }
-       else {
+               * p_recent = imap->imap_selection_info->sel_recent;
+               * p_unseen = imap->imap_selection_info->sel_unseen;
+               * p_uidnext = imap->imap_selection_info->sel_uidnext;
+               * p_uidval = imap->imap_selection_info->sel_uidvalidity;
+       } else {
                * p_exists = 0;
+               * p_recent = 0;
+               * p_unseen = 0;
+               * p_uidnext = 0;
+               * p_uidval = 0;
        }
-       
-       debug_print("imap noop - end\n");
+       if (result.error == 0 && imap && imap->imap_response_info != NULL &&
+           imap->imap_response_info->rsp_expunged != NULL) {
+               * p_expunge = clist_count(imap->imap_response_info->rsp_expunged);
+       } else {
+               * p_expunge = 0;
+       }       
+       debug_print("imap noop - end [EXISTS %d RECENT %d EXPUNGE %d UNSEEN %d UIDNEXT %d UIDVAL %d]\n",
+               *p_exists, *p_recent, *p_expunge, *p_unseen,
+               *p_uidnext, *p_uidval);
        
        return result.error;
 }
@@ -838,9 +1095,12 @@ static void starttls_run(struct etpan_thread_op * op)
        int r;
 
        param = op->param;
+       result = op->result;
+
+       CHECK_IMAP();
+
        r = mailimap_starttls(param->imap);
        
-       result = op->result;
        result->error = r;
        debug_print("imap starttls run - end %i\n", r);
        
@@ -885,9 +1145,9 @@ int imap_threaded_starttls(Folder * folder, const gchar *host, int port)
        threaded_run(folder, &param, &result, starttls_run);
        
        debug_print("imap starttls - end\n");
-       
-       if (result.error == 0 && !etpan_skip_ssl_cert_check) {
-               cert_len = mailstream_ssl_get_certificate(param.imap->imap_stream, &certificate);
+
+       if (result.error == 0 && param.imap && !etpan_skip_ssl_cert_check) {
+               cert_len = (int)mailstream_ssl_get_certificate(param.imap->imap_stream, &certificate);
                if (etpan_certificate_check(certificate, cert_len, &param) < 0)
                        result.error = MAILIMAP_ERROR_STREAM;
                if (certificate) 
@@ -914,9 +1174,12 @@ static void create_run(struct etpan_thread_op * op)
        int r;
        
        param = op->param;
+       result = op->result;
+
+       CHECK_IMAP();
+
        r = mailimap_create(param->imap, param->mb);
        
-       result = op->result;
        result->error = r;
        debug_print("imap create run - end %i\n", r);
 }
@@ -958,9 +1221,12 @@ static void rename_run(struct etpan_thread_op * op)
        int r;
        
        param = op->param;
+       result = op->result;
+
+       CHECK_IMAP();
+
        r = mailimap_rename(param->imap, param->mb, param->new_name);
        
-       result = op->result;
        result->error = r;
        debug_print("imap rename run - end %i\n", r);
 }
@@ -1003,9 +1269,12 @@ static void delete_run(struct etpan_thread_op * op)
        int r;
        
        param = op->param;
+       result = op->result;
+
+       CHECK_IMAP();
+
        r = mailimap_delete(param->imap, param->mb);
        
-       result = op->result;
        result->error = r;
        debug_print("imap delete run - end %i\n", r);
 }
@@ -1045,21 +1314,24 @@ static void select_run(struct etpan_thread_op * op)
        int r;
        
        param = op->param;
+       result = op->result;
+
+       CHECK_IMAP();
+
        r = mailimap_select(param->imap, param->mb);
        
-       result = op->result;
        result->error = r;
        debug_print("imap select run - end %i\n", r);
 }
 
 int imap_threaded_select(Folder * folder, const char * mb,
                         gint * exists, gint * recent, gint * unseen,
-                        guint32 * uid_validity)
+                        guint32 * uid_validity,gint *can_create_flags)
 {
        struct select_param param;
        struct select_result result;
        mailimap * imap;
-       
+
        debug_print("imap select - begin\n");
        
        imap = get_imap(folder);
@@ -1071,20 +1343,71 @@ int imap_threaded_select(Folder * folder, const char * mb,
        if (result.error != MAILIMAP_NO_ERROR)
                return result.error;
        
-       if (imap->imap_selection_info == NULL)
+       if (!imap || imap->imap_selection_info == NULL)
                return MAILIMAP_ERROR_PARSE;
        
        * exists = imap->imap_selection_info->sel_exists;
        * recent = imap->imap_selection_info->sel_recent;
        * unseen = imap->imap_selection_info->sel_unseen;
        * uid_validity = imap->imap_selection_info->sel_uidvalidity;
-       
+       * can_create_flags = FALSE;
+
+       if (imap->imap_selection_info->sel_perm_flags) {
+               clistiter *cur =
+                       clist_begin(imap->imap_selection_info->sel_perm_flags);
+               for (; cur && !(*can_create_flags); cur = clist_next(cur)) {
+                       struct mailimap_flag_perm *flag = (struct mailimap_flag_perm *)clist_content(cur);
+                       if (flag->fl_type == MAILIMAP_FLAG_PERM_ALL)
+                               *can_create_flags = TRUE;
+                       else if (flag->fl_flag && 
+                                       flag->fl_flag->fl_type == 6 &&
+                                       !strcmp(flag->fl_flag->fl_data.fl_extension, "*"))
+                               *can_create_flags = TRUE; 
+                       
+               }
+       }
        debug_print("imap select - end\n");
        
        return result.error;
 }
 
+static void close_run(struct etpan_thread_op * op)
+{
+       struct select_param * param;
+       struct select_result * result;
+       int r;
+       
+       param = op->param;
+       result = op->result;
+
+       CHECK_IMAP();
 
+       r = mailimap_close(param->imap);
+       
+       result->error = r;
+       debug_print("imap close run - end %i\n", r);
+}
+
+int imap_threaded_close(Folder * folder)
+{
+       struct select_param param;
+       struct select_result result;
+       mailimap * imap;
+       
+       debug_print("imap close - begin\n");
+       
+       imap = get_imap(folder);
+       param.imap = imap;
+       
+       threaded_run(folder, &param, &result, close_run);
+       
+       if (result.error != MAILIMAP_NO_ERROR)
+               return result.error;
+       
+       debug_print("imap close - end\n");
+       
+       return result.error;
+}
 
 struct examine_param {
        mailimap * imap;
@@ -1102,9 +1425,12 @@ static void examine_run(struct etpan_thread_op * op)
        int r;
        
        param = op->param;
+       result = op->result;
+
+       CHECK_IMAP();
+
        r = mailimap_examine(param->imap, param->mb);
        
-       result = op->result;
        result->error = r;
        debug_print("imap examine run - end %i\n", r);
 }
@@ -1128,7 +1454,7 @@ int imap_threaded_examine(Folder * folder, const char * mb,
        if (result.error != MAILIMAP_NO_ERROR)
                return result.error;
        
-       if (imap->imap_selection_info == NULL)
+       if (!imap || imap->imap_selection_info == NULL)
                return MAILIMAP_ERROR_PARSE;
        
        * exists = imap->imap_selection_info->sel_exists;
@@ -1186,15 +1512,16 @@ static void search_run(struct etpan_thread_op * op)
        clist * search_result;
        
        param = op->param;
-       
-       if (param->set == NULL && param->type == IMAP_SEARCH_TYPE_SIMPLE) {
-               g_warning("broken search");
-       }
-       
+       result = op->result;
+
+       CHECK_IMAP();
+
        /* we copy the mailimap_set because freeing the key is recursive */
-       if (param->set != NULL)
+       if (param->set != NULL) {
                uid_key = mailimap_search_key_new_uid(sc_mailimap_set_copy(param->set));
-       
+       } else if (param->type == IMAP_SEARCH_TYPE_SIMPLE) {
+               uid_key = mailimap_search_key_new_all();
+       }
        search_type_key = NULL;
        switch (param->type) {
        case IMAP_SEARCH_TYPE_SIMPLE:
@@ -1244,6 +1571,14 @@ static void search_run(struct etpan_thread_op * op)
                                                          NULL, NULL, NULL, NULL, NULL,
                                                          NULL, 0, NULL, NULL, NULL);
                break;
+       case IMAP_SEARCH_TYPE_FORWARDED:
+               search_type_key = mailimap_search_key_new(MAILIMAP_SEARCH_KEY_KEYWORD,
+                                                         NULL, NULL, NULL, NULL, NULL,
+                                                         strdup("$Forwarded"), NULL, NULL, NULL, NULL,
+                                                         NULL, NULL, NULL, NULL, 0,
+                                                         NULL, NULL, NULL, NULL, NULL,
+                                                         NULL, 0, NULL, NULL, NULL);
+               break;
        }
        
        if (search_type_key != NULL) {
@@ -1273,7 +1608,6 @@ static void search_run(struct etpan_thread_op * op)
                /* free the key (with the imapset) */
                mailimap_search_key_free(key);
 
-               result = op->result;
                result->error = r;
                result->search_result = search_result;
        }
@@ -1308,15 +1642,19 @@ int imap_threaded_search(Folder * folder, int search_type,
 
 
 
+static int imap_get_msg_att_info(struct mailimap_msg_att * msg_att,
+                                uint32_t * puid,
+                                char ** pheaders,
+                                size_t * pref_size,
+                                struct mailimap_msg_att_dynamic ** patt_dyn);
 
 static int
-uid_list_to_env_list(clist * fetch_result, carray ** result)
+result_to_uid_list(clist * fetch_result, carray ** result)
 {
        clistiter * cur;
        int r;
        int res;
        carray * tab;
-       unsigned int i;
        
        tab = carray_new(128);
        if (tab == NULL) {
@@ -1327,31 +1665,13 @@ uid_list_to_env_list(clist * fetch_result, carray ** result)
        for(cur = clist_begin(fetch_result) ; cur != NULL ;
            cur = clist_next(cur)) {
                struct mailimap_msg_att * msg_att;
-               clistiter * item_cur;
                uint32_t uid;
-               size_t size;
                uint32_t * puid;
                
                msg_att = clist_content(cur);
                
                uid = 0;
-               size = 0;
-               for(item_cur = clist_begin(msg_att->att_list) ;
-                   item_cur != NULL ;
-                   item_cur = clist_next(item_cur)) {
-                       struct mailimap_msg_att_item * item;
-                       
-                       item = clist_content(item_cur);
-                       
-                       switch (item->att_type) {
-                       case MAILIMAP_MSG_ATT_ITEM_STATIC:
-                               switch (item->att_data.att_static->att_type) {
-                               case MAILIMAP_MSG_ATT_UID:
-                                       uid = item->att_data.att_static->att_data.att_uid;
-                                       break;
-                               }
-                       }
-               }
+               imap_get_msg_att_info(msg_att, &uid, NULL, NULL, NULL);
                
                puid = malloc(sizeof(* puid));
                if (puid == NULL) {
@@ -1373,8 +1693,7 @@ uid_list_to_env_list(clist * fetch_result, carray ** result)
        return MAILIMAP_NO_ERROR;
   
  free_list:
-       for(i = 0 ; i < carray_count(tab) ; i++)
-               mailmessage_free(carray_get(tab, i));
+       imap_fetch_uid_list_free(tab);
  err:
        return res;
 }
@@ -1416,9 +1735,12 @@ static int imap_get_messages_list(mailimap * imap,
                goto free_fetch_type;
        }
 
-       r = mailimap_uid_fetch(imap, set,
+       mailstream_logger = imap_logger_fetch;
+       
+       r = mailimap_uid_fetch(imap, set,
                               fetch_type, &fetch_result);
 
+       mailstream_logger = imap_logger_cmd;
        mailimap_fetch_type_free(fetch_type);
        mailimap_set_free(set);
 
@@ -1428,7 +1750,7 @@ static int imap_get_messages_list(mailimap * imap,
        }
 
        env_list = NULL;
-       r = uid_list_to_env_list(fetch_result, &env_list);
+       r = result_to_uid_list(fetch_result, &env_list);
        mailimap_fetch_list_free(fetch_result);
        
        * result = env_list;
@@ -1464,12 +1786,19 @@ static void fetch_uid_run(struct etpan_thread_op * op)
        int r;
        
        param = op->param;
-       
+       result = op->result;
+
+       CHECK_IMAP();
+
        fetch_result = NULL;
+       mailstream_logger = imap_logger_noop;
+       log_print(LOG_PROTOCOL, "IMAP4- [fetching UIDs...]\n");
+
        r = imap_get_messages_list(param->imap, param->first_index,
                                   &fetch_result);
        
-       result = op->result;
+       mailstream_logger = imap_logger_cmd;
+
        result->error = r;
        result->fetch_result = fetch_result;
        debug_print("imap fetch_uid run - end %i\n", r);
@@ -1516,6 +1845,244 @@ void imap_fetch_uid_list_free(carray * uid_list)
 
 
 
+
+static int imap_flags_to_flags(struct mailimap_msg_att_dynamic * att_dyn, GSList **tags);
+
+static int
+result_to_uid_flags_list(clist * fetch_result, carray ** result)
+{
+       clistiter * cur;
+       int r;
+       int res;
+       carray * tab;
+       GSList *tags = NULL;
+
+       tab = carray_new(128);
+       if (tab == NULL) {
+               res = MAILIMAP_ERROR_MEMORY;
+               goto err;
+       }
+       
+       for(cur = clist_begin(fetch_result) ; cur != NULL ;
+           cur = clist_next(cur)) {
+               struct mailimap_msg_att * msg_att;
+               uint32_t uid;
+               uint32_t * puid;
+               struct mailimap_msg_att_dynamic * att_dyn;
+               int flags;
+               int * pflags;
+               
+               tags = NULL;
+
+               msg_att = clist_content(cur);
+               
+               uid = 0;
+               att_dyn = NULL;
+               imap_get_msg_att_info(msg_att, &uid, NULL, NULL, &att_dyn);
+               if (uid == 0)
+                       continue;
+               if (att_dyn == NULL)
+                       continue;
+               
+               flags = imap_flags_to_flags(att_dyn, &tags);
+               
+               puid = malloc(sizeof(* puid));
+               if (puid == NULL) {
+                       res = MAILIMAP_ERROR_MEMORY;
+                       goto free_list;
+               }
+               * puid = uid;
+               
+               r = carray_add(tab, puid, NULL);
+               if (r < 0) {
+                       free(puid);
+                       res = MAILIMAP_ERROR_MEMORY;
+                       goto free_list;
+               }
+               pflags = malloc(sizeof(* pflags));
+               if (pflags == NULL) {
+                       res = MAILIMAP_ERROR_MEMORY;
+                       goto free_list;
+               }
+               * pflags = flags;
+               r = carray_add(tab, pflags, NULL);
+               if (r < 0) {
+                       free(pflags);
+                       res = MAILIMAP_ERROR_MEMORY;
+                       goto free_list;
+               }
+               r = carray_add(tab, tags, NULL);
+               if (r < 0) {
+                       free(pflags);
+                       res = MAILIMAP_ERROR_MEMORY;
+                       goto free_list;
+               }
+       }
+               
+       * result = tab;
+
+       return MAILIMAP_NO_ERROR;
+  
+ free_list:
+       imap_fetch_uid_flags_list_free(tab);
+       slist_free_strings(tags);
+       g_slist_free(tags);
+ err:
+       return res;
+}
+
+static int imap_get_messages_flags_list(mailimap * imap,
+                                       uint32_t first_index,
+                                       carray ** result)
+{
+       carray * env_list;
+       int r;
+       struct mailimap_fetch_att * fetch_att;
+       struct mailimap_fetch_type * fetch_type;
+       struct mailimap_set * set;
+       clist * fetch_result;
+       int res;
+       
+       set = mailimap_set_new_interval(first_index, 0);
+       if (set == NULL) {
+               res = MAILIMAP_ERROR_MEMORY;
+               goto err;
+       }
+
+       fetch_type = mailimap_fetch_type_new_fetch_att_list_empty();
+       if (fetch_type == NULL) {
+               res = MAILIMAP_ERROR_MEMORY;
+               goto free_set;
+       }
+
+       fetch_att = mailimap_fetch_att_new_flags();
+       if (fetch_att == NULL) {
+               res = MAILIMAP_ERROR_MEMORY;
+               goto free_fetch_type;
+       }
+       
+       r = mailimap_fetch_type_new_fetch_att_list_add(fetch_type, fetch_att);
+       if (r != MAILIMAP_NO_ERROR) {
+               mailimap_fetch_att_free(fetch_att);
+               res = MAILIMAP_ERROR_MEMORY;
+               goto free_fetch_type;
+       }
+       
+       fetch_att = mailimap_fetch_att_new_uid();
+       if (fetch_att == NULL) {
+               res = MAILIMAP_ERROR_MEMORY;
+               goto free_fetch_type;
+       }
+
+       r = mailimap_fetch_type_new_fetch_att_list_add(fetch_type, fetch_att);
+       if (r != MAILIMAP_NO_ERROR) {
+               mailimap_fetch_att_free(fetch_att);
+               res = MAILIMAP_ERROR_MEMORY;
+               goto free_fetch_type;
+       }
+
+       mailstream_logger = imap_logger_fetch;
+       
+       r = mailimap_uid_fetch(imap, set,
+                              fetch_type, &fetch_result);
+
+       mailstream_logger = imap_logger_cmd;
+       mailimap_fetch_type_free(fetch_type);
+       mailimap_set_free(set);
+
+       if (r != MAILIMAP_NO_ERROR) {
+               res = r;
+               goto err;
+       }
+
+       env_list = NULL;
+       r = result_to_uid_flags_list(fetch_result, &env_list);
+       mailimap_fetch_list_free(fetch_result);
+       
+       * result = env_list;
+
+       return MAILIMAP_NO_ERROR;
+
+ free_fetch_type:
+       mailimap_fetch_type_free(fetch_type);
+ free_set:
+       mailimap_set_free(set);
+ err:
+       return res;
+}
+
+
+
+static void fetch_uid_flags_run(struct etpan_thread_op * op)
+{
+       struct fetch_uid_param * param;
+       struct fetch_uid_result * result;
+       carray * fetch_result;
+       int r;
+       
+       param = op->param;
+       result = op->result;
+
+       CHECK_IMAP();
+
+       fetch_result = NULL;
+       r = imap_get_messages_flags_list(param->imap, param->first_index,
+                                        &fetch_result);
+       
+       result->error = r;
+       result->fetch_result = fetch_result;
+       debug_print("imap fetch_uid run - end %i\n", r);
+}
+
+int imap_threaded_fetch_uid_flags(Folder * folder, uint32_t first_index,
+                                 carray ** fetch_result)
+{
+       struct fetch_uid_param param;
+       struct fetch_uid_result result;
+       mailimap * imap;
+       
+       debug_print("imap fetch_uid - begin\n");
+       
+       imap = get_imap(folder);
+       param.imap = imap;
+       param.first_index = first_index;
+       
+       mailstream_logger = imap_logger_noop;
+       log_print(LOG_PROTOCOL, "IMAP4- [fetching flags...]\n");
+
+       threaded_run(folder, &param, &result, fetch_uid_flags_run);
+
+       mailstream_logger = imap_logger_cmd;
+
+       
+       if (result.error != MAILIMAP_NO_ERROR)
+               return result.error;
+       
+       debug_print("imap fetch_uid - end\n");
+       
+       * fetch_result = result.fetch_result;
+       
+       return result.error;
+}
+
+
+void imap_fetch_uid_flags_list_free(carray * uid_flags_list)
+{
+       unsigned int i;
+       
+       for(i = 0 ; i < carray_count(uid_flags_list) ; i += 3) {
+               void * data;
+               
+               data = carray_get(uid_flags_list, i);
+               free(data);
+               data = carray_get(uid_flags_list, i + 1);
+               free(data);
+       }
+       carray_free(uid_flags_list);
+}
+
+
+
 static int imap_fetch(mailimap * imap,
                      uint32_t msg_index,
                      char ** result,
@@ -1663,8 +2230,11 @@ static int imap_fetch_header(mailimap * imap,
     goto free_fetch_att;
   }
 
+  mailstream_logger = imap_logger_fetch;
+  
   r = mailimap_uid_fetch(imap, set, fetch_type, &fetch_result);
   
+  mailstream_logger = imap_logger_cmd;
   mailimap_fetch_type_free(fetch_type);
   mailimap_set_free(set);
 
@@ -1742,7 +2312,10 @@ static void fetch_content_run(struct etpan_thread_op * op)
        FILE * f;
        
        param = op->param;
-       
+       result = op->result;
+
+       CHECK_IMAP();
+
        content = NULL;
        content_size = 0;
        if (param->with_body)
@@ -1752,7 +2325,6 @@ static void fetch_content_run(struct etpan_thread_op * op)
                r = imap_fetch_header(param->imap, param->msg_index,
                                      &content, &content_size);
        
-       result = op->result;
        result->error = r;
        
        if (r == MAILIMAP_NO_ERROR) {
@@ -1769,14 +2341,13 @@ static void fetch_content_run(struct etpan_thread_op * op)
                }
                
                r = fwrite(content, 1, content_size, f);
-               if (r == 0) {
+               if (r < content_size) {
                        goto fclose;
                }
                
                r = fclose(f);
                if (r == EOF) {
-                       g_unlink(param->filename);
-                       goto close;
+                       goto unlink;
                }
                goto free;
                
@@ -1789,6 +2360,8 @@ static void fetch_content_run(struct etpan_thread_op * op)
                g_unlink(param->filename);
        
        free:
+               /* mmap_string_unref is a simple free in libetpan
+                * when it has MMAP_UNAVAILABLE defined */
                if (mmap_string_unref(content) != 0)
                        free(content);
        }
@@ -1824,12 +2397,13 @@ int imap_threaded_fetch_content(Folder * folder, uint32_t msg_index,
 
 
 
-static int imap_flags_to_flags(struct mailimap_msg_att_dynamic * att_dyn)
+static int imap_flags_to_flags(struct mailimap_msg_att_dynamic * att_dyn, GSList **s_tags)
 {
        int flags;
        clist * flag_list;
        clistiter * cur;
-       
+       GSList *tags = NULL;
+
        flags = MSG_UNREAD;
        
        flag_list = att_dyn->att_list;
@@ -1858,10 +2432,17 @@ static int imap_flags_to_flags(struct mailimap_msg_att_dynamic * att_dyn)
                                flags &= ~MSG_UNREAD;
                                flags &= ~MSG_NEW;
                                break;
+                       case MAILIMAP_FLAG_KEYWORD:
+                               if (!strcasecmp(flag_fetch->fl_flag->fl_data.fl_keyword, "$Forwarded"))
+                                       flags |= MSG_FORWARDED;
+                               else if (s_tags)
+                                       tags = g_slist_prepend(tags, g_strdup(flag_fetch->fl_flag->fl_data.fl_keyword));
+                               break;
                        }
                }
        }
-       
+       if (s_tags)
+               *s_tags = tags;
        return flags;
 }
 
@@ -1927,14 +2508,14 @@ static int imap_get_msg_att_info(struct mailimap_msg_att * msg_att,
 }
 
 static struct imap_fetch_env_info *
-fetch_to_env_info(struct mailimap_msg_att * msg_att)
+fetch_to_env_info(struct mailimap_msg_att * msg_att, GSList **tags)
 {
        struct imap_fetch_env_info * info;
        uint32_t uid;
        char * headers;
        size_t size;
        struct mailimap_msg_att_dynamic * att_dyn;
-       
+
        imap_get_msg_att_info(msg_att, &uid, &headers, &size,
                              &att_dyn);
        
@@ -1944,7 +2525,7 @@ fetch_to_env_info(struct mailimap_msg_att * msg_att)
        info->uid = uid;
        info->headers = strdup(headers);
        info->size = size;
-       info->flags = imap_flags_to_flags(att_dyn);
+       info->flags = imap_flags_to_flags(att_dyn, tags);
        
        return info;
 }
@@ -1956,21 +2537,23 @@ imap_fetch_result_to_envelop_list(clist * fetch_result,
        clistiter * cur;
        unsigned int i;
        carray * env_list;
+
        i = 0;
-  
        env_list = carray_new(16);
   
        for(cur = clist_begin(fetch_result) ; cur != NULL ;
            cur = clist_next(cur)) {
                struct mailimap_msg_att * msg_att;
                struct imap_fetch_env_info * env_info;
-    
+               GSList *tags = NULL;
+
                msg_att = clist_content(cur);
 
-               env_info = fetch_to_env_info(msg_att);
+               env_info = fetch_to_env_info(msg_att, &tags);
                if (!env_info)
                        return MAILIMAP_ERROR_MEMORY;
                carray_add(env_list, env_info, NULL);
+               carray_add(env_list, tags, NULL);
        }
   
        * p_env_list = env_list;
@@ -1978,7 +2561,7 @@ imap_fetch_result_to_envelop_list(clist * fetch_result,
        return MAIL_NO_ERROR;
 }
 
-int imap_add_envelope_fetch_att(struct mailimap_fetch_type * fetch_type)
+static int imap_add_envelope_fetch_att(struct mailimap_fetch_type * fetch_type)
 {
        struct mailimap_fetch_att * fetch_att;
        int r;
@@ -2014,7 +2597,7 @@ int imap_add_envelope_fetch_att(struct mailimap_fetch_type * fetch_type)
        return MAIL_NO_ERROR;
 }
 
-int imap_add_header_fetch_att(struct mailimap_fetch_type * fetch_type)
+static int imap_add_header_fetch_att(struct mailimap_fetch_type * fetch_type)
 {
        struct mailimap_fetch_att * fetch_att;
        struct mailimap_section * section;
@@ -2062,8 +2645,11 @@ imap_get_envelopes_list(mailimap * imap, struct mailimap_set * set,
        else
                r = imap_add_header_fetch_att(fetch_type);
        
+       mailstream_logger = imap_logger_fetch;
+       
        r = mailimap_uid_fetch(imap, set, fetch_type, &fetch_result);
        
+       mailstream_logger = imap_logger_cmd;
        switch (r) {
        case MAILIMAP_NO_ERROR:
                break;
@@ -2117,12 +2703,14 @@ static void fetch_env_run(struct etpan_thread_op * op)
        int r;
        
        param = op->param;
-       
+       result = op->result;
+
+       CHECK_IMAP();
+
        env_list = NULL;
        r = imap_get_envelopes_list(param->imap, param->set,
                                    &env_list);
        
-       result = op->result;
        result->error = r;
        result->fetch_env_result = env_list;
        
@@ -2175,7 +2763,7 @@ void imap_fetch_env_free(carray * env_list)
 {
        unsigned int i;
        
-       for(i = 0 ; i < carray_count(env_list) ; i ++) {
+       for(i = 0 ; i < carray_count(env_list) ; i += 2) {
                struct imap_fetch_env_info * env_info;
                
                env_info = carray_get(env_list, i);
@@ -2208,12 +2796,18 @@ static void append_run(struct etpan_thread_op * op)
        int r;
        char * data;
        size_t size;
+#ifndef G_OS_WIN32
        struct stat stat_buf;
-       int fd, uid = 0;
+       int fd;
+#endif
+       guint32 uid = 0, val = 0;
        
        param = op->param;
        result = op->result;
        
+       CHECK_IMAP();
+
+#ifndef G_OS_WIN32
        r = stat(param->filename, &stat_buf);
        if (r < 0) {
                result->error = MAILIMAP_ERROR_APPEND;
@@ -2233,17 +2827,28 @@ static void append_run(struct etpan_thread_op * op)
                result->error = MAILIMAP_ERROR_APPEND;
                return;
        }
-       
+#else
+       data = file_read_to_str_no_recode(param->filename);
+       if (data == NULL) {
+               result->error = MAILIMAP_ERROR_APPEND;
+               return;
+       }
+       size = strlen(data);
+#endif
        mailstream_logger = imap_logger_append;
        
-       r = mailimap_append(param->imap, param->mailbox,
+       r = mailimap_uidplus_append(param->imap, param->mailbox,
                            param->flag_list, NULL,
-                           data, size/*, &uid */);
+                           data, size, &val, &uid);
 
        mailstream_logger = imap_logger_cmd;
        
+#ifndef G_OS_WIN32
        munmap(data, size);
        close(fd);
+#else
+       g_free(data);
+#endif
        
        result->error = r;
        result->uid = uid;
@@ -2297,9 +2902,12 @@ static void expunge_run(struct etpan_thread_op * op)
        int r;
        
        param = op->param;
+       result = op->result;
+
+       CHECK_IMAP();
+
        r = mailimap_expunge(param->imap);
        
-       result = op->result;
        result->error = r;
        debug_print("imap expunge run - end %i\n", r);
 }
@@ -2329,6 +2937,8 @@ struct copy_param {
 
 struct copy_result {
        int error;
+       struct mailimap_set *source;
+       struct mailimap_set *dest;
 };
 
 static void copy_run(struct etpan_thread_op * op)
@@ -2336,19 +2946,31 @@ static void copy_run(struct etpan_thread_op * op)
        struct copy_param * param;
        struct copy_result * result;
        int r;
-       
+       guint32 val;
+       struct mailimap_set *source = NULL, *dest = NULL;
+
        param = op->param;
-       
-       r = mailimap_uid_copy(param->imap, param->set, param->mb);
-       
        result = op->result;
-       result->error = r;
+
+       CHECK_IMAP();
+
+       r = mailimap_uidplus_uid_copy(param->imap, param->set, param->mb,
+               &val, &source, &dest);
        
+       result->error = r;
+       if (r == 0) {
+               result->source = source;
+               result->dest = dest;
+       } else {
+               result->source = NULL;
+               result->dest = NULL;
+       }
        debug_print("imap copy run - end %i\n", r);
 }
 
 int imap_threaded_copy(Folder * folder, struct mailimap_set * set,
-                      const char * mb)
+                      const char * mb, struct mailimap_set **source,
+                      struct mailimap_set **dest)
 {
        struct copy_param param;
        struct copy_result result;
@@ -2362,10 +2984,15 @@ int imap_threaded_copy(Folder * folder, struct mailimap_set * set,
        param.mb = mb;
        
        threaded_run(folder, &param, &result, copy_run);
+       *source = NULL;
+       *dest = NULL;
        
        if (result.error != MAILIMAP_NO_ERROR)
                return result.error;
        
+       *source = result.source;
+       *dest = result.dest;
+
        debug_print("imap copy - end\n");
        
        return result.error;
@@ -2390,11 +3017,13 @@ static void store_run(struct etpan_thread_op * op)
        int r;
        
        param = op->param;
-       
+       result = op->result;
+
+       CHECK_IMAP();
+
        r = mailimap_uid_store(param->imap, param->set,
                               param->store_att_flags);
        
-       result = op->result;
        result->error = r;
        
        debug_print("imap store run - end %i\n", r);
@@ -2426,7 +3055,7 @@ int imap_threaded_store(Folder * folder, struct mailimap_set * set,
 
 
 #define ENV_BUFFER_SIZE 512
-
+#ifndef G_OS_WIN32
 static void do_exec_command(int fd, const char * command,
                            const char * servername, uint16_t port)
 {
@@ -2530,7 +3159,7 @@ static int subcommand_connect(const char *command,
        return sockfds[0];
 }
 
-int socket_connect_cmd(mailimap * imap, const char * command,
+static int socket_connect_cmd(mailimap * imap, const char * command,
                       const char * server, int port)
 {
        int fd;
@@ -2551,6 +3180,8 @@ int socket_connect_cmd(mailimap * imap, const char * command,
        if (r != MAILIMAP_NO_ERROR_AUTHENTICATED
        &&  r != MAILIMAP_NO_ERROR_NON_AUTHENTICATED) {
                mailstream_close(s);
+               if (imap)
+                       imap->imap_stream = NULL;
                return r;
        }
        
@@ -2579,6 +3210,8 @@ static void connect_cmd_run(struct etpan_thread_op * op)
        param = op->param;
        result = op->result;
        
+       CHECK_IMAP();
+
        r = socket_connect_cmd(param->imap, param->command,
                               param->server, param->port);
        
@@ -2593,10 +3226,17 @@ int imap_threaded_connect_cmd(Folder * folder, const char * command,
        struct connect_cmd_result result;
        chashdatum key;
        chashdatum value;
-       mailimap * imap;
+       mailimap * imap, * oldimap;
        
+       oldimap = get_imap(folder);
+
        imap = mailimap_new(0, NULL);
        
+       if (oldimap) {
+               debug_print("deleting old imap %p\n", oldimap);
+               delete_imap(folder, oldimap);
+       }
+
        key.data = &folder;
        key.len = sizeof(folder);
        value.data = imap;
@@ -2610,10 +3250,21 @@ int imap_threaded_connect_cmd(Folder * folder, const char * command,
        
        threaded_run(folder, &param, &result, connect_cmd_run);
        
-       debug_print("connect_cmd ok %i\n", result.error);
+       debug_print("connect_cmd ok %i with imap %p\n", result.error, imap);
        
        return result.error;
 }
+#endif /* G_OS_WIN32 */
+
+void imap_threaded_cancel(Folder * folder)
+{
+       mailimap * imap;
+       
+       imap = get_imap(folder);
+       if (imap->imap_stream != NULL)
+               mailstream_cancel(imap->imap_stream);
+}
+
 #else
 
 void imap_main_init(void)
@@ -2626,4 +3277,8 @@ void imap_main_set_timeout(int sec)
 {
 }
 
+void imap_threaded_cancel(Folder * folder);
+{
+}
+
 #endif