fix bug 4239, 'Preferences: Text Options Header Display modal is not modal' (sic)
[claws.git] / src / edittags.c
index 99fa8bc26b8418fdb0ac7446261422c6686bae76..c53653e66918df7e23e3f42ed0a8938f36d12bc5 100644 (file)
@@ -1,6 +1,6 @@
 /*
  * Claws Mail -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2007 Hiroyuki Yamamoto & The Claws Mail Team
+ * Copyright (C) 2007-2013 The Claws Mail Team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -19,6 +19,7 @@
 
 #ifdef HAVE_CONFIG_H
 #  include "config.h"
+#include "claws-features.h"
 #endif
 
 #include "defs.h"
@@ -58,6 +59,7 @@ enum {
 static gint tag_cmp_func (GtkTreeModel *model, GtkTreeIter *a, GtkTreeIter *b, gpointer userdata)
  {
        gchar *name1, *name2;
+       gint res;
 
        gtk_tree_model_get(model, a, TAG_NAME, &name1, -1);
        gtk_tree_model_get(model, b, TAG_NAME, &name2, -1);
@@ -66,9 +68,13 @@ static gint tag_cmp_func (GtkTreeModel *model, GtkTreeIter *a, GtkTreeIter *b, g
                return name2 == NULL ? 0:1;
        
        if (name2 == NULL)
-               return name1 == NULL ? 0:1;
+               return 1;
        
-       return g_utf8_collate(name1,name2);
+       res = g_utf8_collate(name1,name2);
+       g_free(name1);
+       g_free(name2);
+
+       return res;
 }
 
 static void apply_window_create(void);
@@ -76,7 +82,6 @@ static void apply_window_create(void);
 static struct TagApplyWindow
 {
        GtkWidget *window;
-       GtkWidget *list_view;
        GtkWidget *hbox1;
        GtkWidget *vbox1;
        GtkWidget *label;
@@ -86,8 +91,20 @@ static struct TagApplyWindow
        GtkWidget *add_btn;
        GSList *msglist;
        gboolean has_tag_col;
+       GdkCursor *watch_cursor;
+       gboolean busy;
 } applywindow;
 
+#define APPLYWINDOW_LOCK() {                                                           \
+       gdk_window_set_cursor(gtk_widget_get_window(applywindow.window), applywindow.watch_cursor);     \
+       applywindow.busy = TRUE;                                                        \
+}
+
+#define APPLYWINDOW_UNLOCK() {                                                         \
+       gdk_window_set_cursor(gtk_widget_get_window(applywindow.window), NULL);                 \
+       applywindow.busy = FALSE;                                                       \
+}
+
 static void apply_window_load_tags (void);
 static void apply_window_insert_check_column(GtkWidget *list_view);
 
@@ -103,12 +120,12 @@ void tag_apply_open(GSList *msglist)
        apply_window_load_tags();
 
        if (msglist && !applywindow.has_tag_col) {
-               apply_window_insert_check_column(applywindow.list_view);
+               apply_window_insert_check_column(applywindow.taglist);
                applywindow.has_tag_col = TRUE;
        }
        if (!msglist && applywindow.has_tag_col) {
-               gtk_tree_view_remove_column(GTK_TREE_VIEW(applywindow.list_view),
-                       gtk_tree_view_get_column(GTK_TREE_VIEW(applywindow.list_view), 0));
+               gtk_tree_view_remove_column(GTK_TREE_VIEW(applywindow.taglist),
+                       gtk_tree_view_get_column(GTK_TREE_VIEW(applywindow.taglist), 0));
                applywindow.has_tag_col = FALSE;
        } 
 
@@ -186,31 +203,41 @@ static void apply_window_create_list_view_columns(GtkWidget *list_view)
 
 }
 
-static GtkItemFactory *apply_popup_factory = NULL;
 static GtkWidget *apply_popup_menu = NULL;
 
-static void apply_popup_delete (void *obj, guint action, void *data)
+static void apply_popup_delete (GtkAction *action, gpointer data)
 {
        GtkTreeIter sel;
        GtkTreeModel *model;
        gint id;
        SummaryView *summaryview = NULL;
-       
-       if (!gtk_tree_selection_get_selected(gtk_tree_view_get_selection
-                               (GTK_TREE_VIEW(applywindow.taglist)),
-                               &model, &sel))
-               return;                         
+       GtkTreeSelection *selection = gtk_tree_view_get_selection
+                               (GTK_TREE_VIEW(applywindow.taglist));
+       model = gtk_tree_view_get_model(GTK_TREE_VIEW(applywindow.taglist));
+
+       if (!gtk_tree_selection_get_selected(selection, NULL, &sel))
+               return;
 
        if (alertpanel(_("Delete tag"),
                       _("Do you really want to delete this tag?"),
-                      GTK_STOCK_CANCEL, GTK_STOCK_DELETE, NULL) != G_ALERTALTERNATE)
+                      GTK_STOCK_CANCEL, GTK_STOCK_DELETE, NULL,
+                                        ALERTFOCUS_FIRST) != G_ALERTALTERNATE)
                return;
 
+       APPLYWINDOW_LOCK();
+
        /* XXX: Here's the reason why we need to store the original 
         * pointer: we search the slist for it. */
        gtk_tree_model_get(model, &sel,
                           TAG_DATA, &id,
                           -1);
+
+       /* Even though this is not documented, gtk_tree_model_get()
+        * seems to invalidate the GtkTreeIter that is passed to it,
+        * so we need to reacquire it. */
+       if (!gtk_tree_selection_get_selected(selection, NULL, &sel))
+               return;
+
        gtk_list_store_remove(GTK_LIST_STORE(model), &sel);
        if (mainwindow_get_mainwindow() != NULL)
                summaryview = mainwindow_get_mainwindow()->summaryview;
@@ -218,24 +245,80 @@ static void apply_popup_delete (void *obj, guint action, void *data)
                summary_set_tag(summaryview, -id, NULL);
        tags_remove_tag(id);
        tags_write_tags();
+       APPLYWINDOW_UNLOCK();
+}
+
+static void apply_popup_delete_all (GtkAction *action, gpointer data)
+{
+       GSList *cur, *tags;
+       GtkTreeModel *model;
+       SummaryView *summaryview = NULL;
+       
+       if (alertpanel(_("Delete all tags"),
+                      _("Do you really want to delete all tags?"),
+                      GTK_STOCK_CANCEL, GTK_STOCK_DELETE, NULL,
+                                        ALERTFOCUS_FIRST) != G_ALERTALTERNATE)
+               return;
+
+       APPLYWINDOW_LOCK();
+
+       model = gtk_tree_view_get_model(GTK_TREE_VIEW(applywindow.taglist));
+       gtk_list_store_clear(GTK_LIST_STORE(model));
+
+       if (mainwindow_get_mainwindow() != NULL)
+               summaryview = mainwindow_get_mainwindow()->summaryview;
+       cur = tags = tags_get_list();
+       for (; cur; cur = cur->next) {
+               gint id = GPOINTER_TO_INT(cur->data);
+               if (summaryview)
+                       summary_set_tag(summaryview, -id, NULL);
+               tags_remove_tag(id);
+       }
+       g_slist_free(tags);
+       tags_write_tags();
+
+       APPLYWINDOW_UNLOCK();
 }
 
-static GtkItemFactoryEntry apply_popup_entries[] =
+static GtkActionEntry apply_popup_actions[] =
 {
-       {N_("/_Delete"),                NULL, apply_popup_delete, 0, NULL, NULL},
+       { "EditTags", NULL, "EditTags", NULL, NULL, NULL },
+       { "EditTags/Delete", NULL, N_("_Delete"), NULL, "Delete tag", G_CALLBACK(apply_popup_delete) },
+       { "EditTags/DeleteAll", NULL, N_("Delete _all"), NULL, "Delete all tags", G_CALLBACK(apply_popup_delete_all) }
 };
 
 static gint apply_list_btn_pressed(GtkWidget *widget, GdkEventButton *event,
                                    GtkTreeView *list_view)
 {
+       GtkUIManager *gui_manager = gtkut_ui_manager();
+
+       if (applywindow.busy)
+               return FALSE;
+
        if (event && event->button == 3) {
+               GtkTreeModel *model = gtk_tree_view_get_model(list_view);
+               GtkTreeIter iter;
+               gboolean non_empty;
+
                if (!apply_popup_menu) {
-                       gint n_entries = sizeof(apply_popup_entries) /
-                               sizeof(apply_popup_entries[0]);
-                       apply_popup_menu = menu_create_items(apply_popup_entries, n_entries,
-                                                     "<TagPopupMenu>", &apply_popup_factory,
-                                                     list_view);
+                       (void) cm_menu_create_action_group("EditTags", apply_popup_actions,
+                                       G_N_ELEMENTS(apply_popup_actions), (gpointer)list_view);
+
+                       MENUITEM_ADDUI("/Menus", "EditTags", "EditTags", GTK_UI_MANAGER_MENU)
+                       MENUITEM_ADDUI("/Menus/EditTags", "Delete", "EditTags/Delete",
+                                       GTK_UI_MANAGER_MENUITEM)
+                       MENUITEM_ADDUI("/Menus/EditTags", "DeleteAll", "EditTags/DeleteAll",
+                                       GTK_UI_MANAGER_MENUITEM)
+
+                       apply_popup_menu = gtk_menu_item_get_submenu(GTK_MENU_ITEM(
+                                               gtk_ui_manager_get_widget(gui_manager, "/Menus/EditTags")) );
                }
+
+               /* grey out popup menu items if list is empty */
+               non_empty = gtk_tree_model_get_iter_first(model, &iter);
+               cm_menu_set_sensitive("EditTags/Delete", non_empty);
+               cm_menu_set_sensitive("EditTags/DeleteAll", non_empty);
+
                gtk_menu_popup(GTK_MENU(apply_popup_menu), 
                               NULL, NULL, NULL, NULL, 
                               event->button, event->time);
@@ -277,28 +360,30 @@ static GtkWidget *apply_window_list_view_create   (void)
        /* create the columns */
        apply_window_create_list_view_columns(GTK_WIDGET(list_view));
 
-#ifndef MAEMO
        g_signal_connect(G_OBJECT(list_view), "popup-menu",
                         G_CALLBACK(apply_list_popup_menu), list_view);
-#else
-       gtk_widget_tap_and_hold_setup(GTK_WIDGET(list_view), NULL, NULL,
-                       GTK_TAP_AND_HOLD_NONE | GTK_TAP_AND_HOLD_NO_INTERNALS);
-       g_signal_connect(G_OBJECT(list_view), "tap-and-hold",
-                        G_CALLBACK(apply_list_popup_menu), list_view);
-#endif
        g_signal_connect(G_OBJECT(list_view), "button-press-event",
                        G_CALLBACK(apply_list_btn_pressed), list_view);
        return GTK_WIDGET(list_view);
 
 }
 
+static void apply_window_list_view_clear_tags(GtkWidget *list_view);
+
 static void apply_window_close(void) 
 {
+       if (applywindow.busy)
+               return;
+
        if (applywindow.msglist)
                g_slist_free(applywindow.msglist);
        applywindow.msglist = NULL;
-       gtk_widget_hide(applywindow.window);
+       APPLYWINDOW_LOCK();
        main_window_reflect_tags_changes(mainwindow_get_mainwindow());
+       APPLYWINDOW_UNLOCK();
+       apply_window_list_view_clear_tags(applywindow.taglist);
+       gtk_widget_hide(applywindow.window);
+       gtk_window_set_modal(GTK_WINDOW(applywindow.window), FALSE);
 }
 
 static void apply_window_close_cb(GtkWidget *widget,
@@ -339,8 +424,15 @@ static void apply_window_add_tag(void)
        gchar *new_tag = gtk_editable_get_chars(GTK_EDITABLE(applywindow.add_entry), 0, -1);
        g_strstrip(new_tag);
        if (new_tag && *new_tag) {
-               gint id = tags_get_id_for_str(new_tag);
+               gint id;
                FindTagInStore fis;
+               if (!(IS_NOT_RESERVED_TAG(new_tag))) {
+                       alertpanel_error(_("You entered a reserved tag name, please choose another instead."));
+                       g_free(new_tag);
+                       return;
+               }
+               id = tags_get_id_for_str(new_tag);
+               APPLYWINDOW_LOCK();
                if (id == -1) {
                        id = tags_add_tag(new_tag);
                        tags_write_tags();
@@ -375,15 +467,18 @@ static void apply_window_add_tag(void)
                        apply_window_list_view_insert_tag(applywindow.taglist, &fis.iter, id);
                        gtk_tree_path_free(path);
                }
-               g_free(new_tag);
+               APPLYWINDOW_UNLOCK();
        } else {
                alertpanel_error(_("Tag is not set."));
        }
+       g_free(new_tag);
 }
 
 static void apply_window_add_tag_cb(GtkWidget *widget,
                                 gpointer data) 
 {
+       if (applywindow.busy)
+               return;
        apply_window_add_tag();
        gtk_entry_set_text(GTK_ENTRY(applywindow.add_entry), "");
        gtk_widget_grab_focus(applywindow.taglist);
@@ -392,22 +487,29 @@ static void apply_window_add_tag_cb(GtkWidget *widget,
 static void apply_window_del_tag_cb(GtkWidget *widget,
                                 gpointer data) 
 {
-       apply_popup_delete(NULL, 0, NULL);
+       if (applywindow.busy)
+               return;
+       apply_popup_delete(NULL, NULL);
        gtk_widget_grab_focus(applywindow.taglist);
 }
 
 static gboolean apply_window_key_pressed(GtkWidget *widget, GdkEventKey *event, gpointer data)
 {
-       if (event && event->keyval == GDK_Escape)
+       if (applywindow.busy)
+               return FALSE;
+       if (event && event->keyval == GDK_KEY_Escape)
                apply_window_close();
-       else if (event && event->keyval == GDK_Delete)
-               apply_popup_delete(NULL, 0, NULL);
+       else if (event && event->keyval == GDK_KEY_Delete)
+               apply_popup_delete(NULL, NULL);
        return FALSE;
 }
 
 static gboolean apply_window_add_key_pressed(GtkWidget *widget, GdkEventKey *event, gpointer data)
 {
-       if (event && (event->keyval == GDK_KP_Enter || event->keyval == GDK_Return)) {
+       if (applywindow.busy)
+               return FALSE;
+
+       if (event && (event->keyval == GDK_KEY_KP_Enter || event->keyval == GDK_KEY_Return)) {
                apply_window_add_tag();
                gtk_entry_set_text(GTK_ENTRY(applywindow.add_entry), "");
                gtk_widget_grab_focus(applywindow.taglist);
@@ -416,6 +518,18 @@ static gboolean apply_window_add_key_pressed(GtkWidget *widget, GdkEventKey *eve
        return FALSE;
 }
 
+/*!
+ *\brief       Save Gtk object size to prefs dataset
+ */
+static void apply_window_size_allocate_cb(GtkWidget *widget,
+                                        GtkAllocation *allocation)
+{
+       cm_return_if_fail(allocation != NULL);
+
+       prefs_common.tagswin_width = allocation->width;
+       prefs_common.tagswin_height = allocation->height;
+}
+
 static void apply_window_create(void) 
 {
        GtkWidget *window;
@@ -429,16 +543,20 @@ static void apply_window_create(void)
        GtkWidget *new_tag_entry;
        GtkWidget *add_btn;
        GtkWidget *del_btn;
+       static GdkGeometry geometry;
 
        window = gtkut_window_new(GTK_WINDOW_TOPLEVEL, "tag_apply_window");
        gtk_window_set_title (GTK_WINDOW(window),
-                             Q_("Dialog title|Apply tags"));
+                             C_("Dialog title", "Apply tags"));
 
        gtk_container_set_border_width (GTK_CONTAINER (window), 8);
        gtk_window_set_position (GTK_WINDOW (window), GTK_WIN_POS_CENTER);
        gtk_window_set_resizable(GTK_WINDOW (window), TRUE);
+       gtk_window_set_type_hint(GTK_WINDOW(window), GDK_WINDOW_TYPE_HINT_DIALOG);
        g_signal_connect(G_OBJECT(window), "delete_event",
                         G_CALLBACK(apply_window_close_cb), NULL);
+       g_signal_connect(G_OBJECT(window), "size_allocate",
+                        G_CALLBACK(apply_window_size_allocate_cb), NULL);
        g_signal_connect(G_OBJECT(window), "key_press_event",
                         G_CALLBACK(apply_window_key_pressed), NULL);
        MANAGE_WINDOW_SIGNALS_CONNECT (window);
@@ -487,8 +605,6 @@ static void apply_window_create(void)
        gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(scrolledwin),
                                       GTK_POLICY_AUTOMATIC, GTK_POLICY_ALWAYS);
                                       
-       gtk_widget_set_size_request(scrolledwin, 500, 250);
-
        gtk_container_add(GTK_CONTAINER(scrolledwin), taglist);
        gtk_box_pack_start(GTK_BOX(vbox1), scrolledwin, TRUE, TRUE, 0);
        gtk_box_pack_start(GTK_BOX(vbox1), hbox1, FALSE, FALSE, 0);
@@ -501,8 +617,17 @@ static void apply_window_create(void)
        gtk_widget_show(close_btn);
        gtk_container_add(GTK_CONTAINER (window), vbox1);
 
+       if (!geometry.min_height) {
+               geometry.min_width = 500;
+               geometry.min_height = 250;
+       }
+
+       gtk_window_set_geometry_hints(GTK_WINDOW(window), NULL, &geometry,
+                                     GDK_HINT_MIN_SIZE);
+       gtk_widget_set_size_request(window, prefs_common.tagswin_width,
+                                   prefs_common.tagswin_height);
+
        applywindow.window = window;
-       applywindow.list_view = taglist;
        applywindow.hbox1 = hbox1;
        applywindow.vbox1 = vbox1;
        applywindow.label = label;
@@ -511,6 +636,7 @@ static void apply_window_create(void)
        applywindow.add_btn = add_btn;
        applywindow.add_entry = new_tag_entry;
        applywindow.has_tag_col = FALSE;
+       applywindow.watch_cursor = gdk_cursor_new(GDK_WATCH);
 }
 
 static void apply_window_list_view_clear_tags(GtkWidget *list_view)
@@ -531,7 +657,10 @@ static void tag_apply_selected_toggled(GtkCellRendererToggle *widget,
        gpointer tmp;
        gint tag_id;
        SummaryView *summaryview = NULL;
-       
+
+       if (applywindow.busy)
+               return;
+
        if (mainwindow_get_mainwindow() != NULL)
                summaryview = mainwindow_get_mainwindow()->summaryview;
 
@@ -551,8 +680,10 @@ static void tag_apply_selected_toggled(GtkCellRendererToggle *widget,
                           TAG_SELECTED_INCONSISTENT, FALSE,
                           -1);
        
+       APPLYWINDOW_LOCK();
        if (summaryview)
                summary_set_tag(summaryview, set ? tag_id : -tag_id, NULL);
+       APPLYWINDOW_UNLOCK();
 }
 
 static void tag_apply_selected_edited(GtkCellRendererText *widget,
@@ -564,6 +695,10 @@ static void tag_apply_selected_edited(GtkCellRendererText *widget,
        gpointer tmp;
        gint tag_id;
        SummaryView *summaryview = NULL;
+       gboolean selected;
+
+       if (applywindow.busy)
+               return;
 
        if (mainwindow_get_mainwindow() != NULL)
                summaryview = mainwindow_get_mainwindow()->summaryview;
@@ -571,18 +706,35 @@ static void tag_apply_selected_edited(GtkCellRendererText *widget,
        if (!gtk_tree_model_get_iter_from_string(model, &iter, path))
                return;
 
+       if (!new_text || !*new_text)
+               return;
+
        gtk_tree_model_get(model, &iter,
+                          TAG_SELECTED, &selected,
                           TAG_DATA, &tmp,
                           -1);
 
        tag_id = GPOINTER_TO_INT(tmp);
+       
+       APPLYWINDOW_LOCK();
+       if (selected) {
+               if (summaryview)
+                       summary_set_tag(summaryview, -tag_id, NULL);
+       }
+       
        tags_update_tag(tag_id, new_text);
        
        gtk_list_store_set(GTK_LIST_STORE(model), &iter,
                           TAG_NAME, new_text,
                           -1);
-       if (summaryview)
-               summary_set_tag(summaryview, 0, NULL);
+       if (selected) {
+               if (summaryview)
+                       summary_set_tag(summaryview, tag_id, NULL);
+       } else  {
+               if (summaryview)
+                       summary_set_tag(summaryview, 0, NULL);
+       }       
+       APPLYWINDOW_UNLOCK();
 }
 
 static void apply_window_get_selected_state(gint tag, gboolean *selected, gboolean *selected_inconsistent)
@@ -636,14 +788,14 @@ static void apply_window_list_view_insert_tag(GtkWidget *list_view,
 
 static void apply_window_load_tags (void) 
 {
-       GSList *cur;
-       GSList *tags = tags_get_list();
+       GSList *cur, *tags;
+       gint id;
        apply_window_list_view_clear_tags(applywindow.taglist);
        
-       cur = tags;
+       cur = tags = tags_get_list();
        for (; cur; cur = cur->next) {
-               gint id = GPOINTER_TO_INT(cur->data);
+               id = GPOINTER_TO_INT(cur->data);
                apply_window_list_view_insert_tag(applywindow.taglist, NULL, id);
        }
+       g_slist_free(tags);
 }
-