2008-06-13 [wwp] 3.4.0cvs92
[claws.git] / src / editgroup.c
index e6cf99f90af7d1082e0a17523bd6185e3712504d..aa4464e65b537e58a6624b67900294e6a3c2ef97 100644 (file)
@@ -1,10 +1,10 @@
 /*
  * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999,2000 Hiroyuki Yamamoto
+ * Copyright (C) 1999-2007 Hiroyuki Yamamoto and the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
+ * the Free Software Foundation; either version 3 of the License, or
  * (at your option) any later version.
  *
  * This program is distributed in the hope that it will be useful,
@@ -13,8 +13,8 @@
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ * 
  */
 
 #ifdef HAVE_CONFIG_H
 #include "defs.h"
 
 #include <glib.h>
+#include <glib/gi18n.h>
 #include <gdk/gdkkeysyms.h>
 
-#include "intl.h"
 #include "addressbook.h"
 #include "addressitem.h"
 #include "addrbook.h"
 #include "addritem.h"
 
+#include "mgutils.h"
+
 #include "prefs_common.h"
 
 #include "alertpanel.h"
 #include "inputdialog.h"
+#include "manage_window.h"
+#include "gtkutils.h"
 
 #define ADDRESSBOOK_GUESS_FOLDER_NAME  "NewFolder"
 #define ADDRESSBOOK_GUESS_GROUP_NAME   "NewGroup"
 
-#define EDITGROUP_WIDTH      580
-#define EDITGROUP_HEIGHT     340
-
 typedef enum {
        GROUP_COL_NAME    = 0,
        GROUP_COL_EMAIL   = 1,
@@ -60,14 +61,12 @@ static struct _GroupEdit_dlg {
        GtkWidget *statusbar;
        gint status_cid;
 
-       // Basic data tab
+       /* Basic data tab */
        GtkWidget *entry_name;
        GtkCList *clist_group;
        GtkCList *clist_avail;
 
        GHashTable *hashEMail;
-       gint rowIndGroup;
-       gint rowIndAvail;
 
 } groupeditdlg;
 
@@ -84,8 +83,10 @@ static void edit_group_status_show( gchar *msg ) {
 }
 
 static void edit_group_ok(GtkWidget *widget, gboolean *cancelled) {
-       gchar *sName = g_strdup( gtk_editable_get_chars( GTK_EDITABLE(groupeditdlg.entry_name), 0, -1 ) );
+       gchar *sName;
        gboolean errFlag = TRUE;
+
+       sName = gtk_editable_get_chars( GTK_EDITABLE(groupeditdlg.entry_name), 0, -1 );
        if( sName ) {
                g_strstrip( sName );
                if( *sName != '\0' ) {
@@ -100,7 +101,7 @@ static void edit_group_ok(GtkWidget *widget, gboolean *cancelled) {
        }
        g_free( sName );
 }
-       
+
 static void edit_group_cancel(GtkWidget *widget, gboolean *cancelled) {
        *cancelled = TRUE;
        gtk_main_quit();
@@ -112,11 +113,12 @@ static gint edit_group_delete_event(GtkWidget *widget, GdkEventAny *event, gbool
        return TRUE;
 }
 
-static void edit_group_key_pressed(GtkWidget *widget, GdkEventKey *event, gboolean *cancelled) {
+static gboolean edit_group_key_pressed(GtkWidget *widget, GdkEventKey *event, gboolean *cancelled) {
        if (event && event->keyval == GDK_Escape) {
                *cancelled = TRUE;
                gtk_main_quit();
        }
+       return FALSE;
 }
 
 static gchar *edit_group_format_item_clist( ItemPerson *person, ItemEMail *email ) {
@@ -138,13 +140,14 @@ static gint edit_group_clist_add_email( GtkCList *clist, ItemEMail *email ) {
        gchar *text[ GROUP_N_COLS ];
        gint row;
        if( str ) {
-               text[ GROUP_COL_NAME ] = str;
+               text[ GROUP_COL_NAME ] = addressbook_set_col_name_guard(str);
        }
        else {
-               text[ GROUP_COL_NAME ] = ADDRITEM_NAME(person);
+               text[ GROUP_COL_NAME ] = addressbook_set_col_name_guard(ADDRITEM_NAME(person));
        }
        text[ GROUP_COL_EMAIL   ] = email->address;
        text[ GROUP_COL_REMARKS ] = email->remarks;
+
        row = gtk_clist_append( clist, text );
        gtk_clist_set_row_data( clist, row, email );
        return row;
@@ -152,58 +155,83 @@ static gint edit_group_clist_add_email( GtkCList *clist, ItemEMail *email ) {
 
 static void edit_group_load_clist( GtkCList *clist, GList *listEMail ) {
        GList *node = listEMail;
+       gtk_clist_freeze(clist);
        while( node ) {
                ItemEMail *email = node->data;
                edit_group_clist_add_email( clist, email );
                node = g_list_next( node );
        }
+       gtk_clist_thaw(clist);
 }
 
-static void edit_group_group_selected( GtkCList *clist, gint row, gint column, GdkEvent *event, gpointer data ) {
-       groupeditdlg.rowIndGroup = row;
-}
 
-static void edit_group_avail_selected( GtkCList *clist, gint row, gint column, GdkEvent *event, gpointer data ) {
-       groupeditdlg.rowIndAvail = row;
-}
-
-static gint edit_group_move_email( GtkCList *clist_from, GtkCList *clist_to, gint row ) {
-       ItemEMail *email = gtk_clist_get_row_data( clist_from, row );
-       gint rrow = -1;
+static void edit_group_move_email( GtkCList *clist_from, GtkCList *clist_to, GtkCTreeNode *node ) {
+       ItemEMail *email = gtk_ctree_node_get_row_data( GTK_CTREE(clist_from), node );
+       GtkCTreeNode *next = gtkut_ctree_node_next(GTK_CTREE(clist_from), node);
+       GtkCTreeNode *prev = gtkut_ctree_node_prev(GTK_CTREE(clist_from), node);
+       int rrow = 0;
        if( email ) {
-               gtk_clist_remove( clist_from, row );
+               gtk_ctree_remove_node(GTK_CTREE(clist_from), node);
                rrow = edit_group_clist_add_email( clist_to, email );
                gtk_clist_select_row( clist_to, rrow, 0 );
+               if (next)
+                       gtk_ctree_select(GTK_CTREE(clist_from), next);
+               else if (prev)
+                       gtk_ctree_select(GTK_CTREE(clist_from), prev);
        }
-       return rrow;
 }
 
 static void edit_group_to_group( GtkWidget *widget, gpointer data ) {
-       groupeditdlg.rowIndGroup = edit_group_move_email( groupeditdlg.clist_avail,
-                                       groupeditdlg.clist_group, groupeditdlg.rowIndAvail );
+       GList *selected = g_list_copy(GTK_CLIST(groupeditdlg.clist_avail)->selection);
+       /* Clear the selected rows on destination clist */
+       gtk_clist_freeze(groupeditdlg.clist_avail);
+       gtk_clist_freeze(groupeditdlg.clist_group);
+       gtk_clist_unselect_all(groupeditdlg.clist_group);
+       while (selected) {
+               edit_group_move_email( groupeditdlg.clist_avail,
+                                       groupeditdlg.clist_group, GTK_CTREE_NODE(selected->data) );
+               selected = selected->next;
+       }
+       g_list_free(selected);
+       gtk_clist_thaw(groupeditdlg.clist_avail);
+       gtk_clist_thaw(groupeditdlg.clist_group);
 }
 
 static void edit_group_to_avail( GtkWidget *widget, gpointer data ) {
-       groupeditdlg.rowIndAvail = edit_group_move_email( groupeditdlg.clist_group,
-                                       groupeditdlg.clist_avail, groupeditdlg.rowIndGroup );
+       GList *selected = g_list_copy(GTK_CLIST(groupeditdlg.clist_group)->selection);
+       gtk_clist_freeze(groupeditdlg.clist_avail);
+       gtk_clist_freeze(groupeditdlg.clist_group);
+       gtk_clist_unselect_all(groupeditdlg.clist_avail);
+       while (selected) {
+               edit_group_move_email( groupeditdlg.clist_group,
+                                       groupeditdlg.clist_avail, GTK_CTREE_NODE(selected->data) );
+               selected = selected->next;
+       }
+       g_list_free(selected);
+       gtk_clist_thaw(groupeditdlg.clist_avail);
+       gtk_clist_thaw(groupeditdlg.clist_group);
 }
 
-static void edit_group_list_group_button( GtkCList *clist, GdkEventButton *event, gpointer data ) {
-       if( ! event ) return;
+static gboolean edit_group_list_group_button( GtkCList *clist, GdkEventButton *event, gpointer data ) {
+       if( ! event ) return FALSE;
+
        if( event->button == 1 ) {
                if( event->type == GDK_2BUTTON_PRESS ) {
                        edit_group_to_avail( NULL, NULL );
                }
        }
+       return FALSE;
 }
 
-static void edit_group_list_avail_button( GtkCList *clist, GdkEventButton *event, gpointer data ) {
-       if( ! event ) return;
+static gboolean edit_group_list_avail_button( GtkCList *clist, GdkEventButton *event, gpointer data ) {
+       if( ! event ) return FALSE;
+
        if( event->button == 1 ) {
                if( event->type == GDK_2BUTTON_PRESS ) {
                        edit_group_to_group( NULL, NULL );
                }
        }
+       return FALSE;
 }
 
 static gint edit_group_list_compare_func( GtkCList *clist, gconstpointer ptr1, gconstpointer ptr2 ) {
@@ -214,7 +242,16 @@ static gint edit_group_list_compare_func( GtkCList *clist, gconstpointer ptr1, g
        if( cell2 ) name2 = cell2->u.text;
        if( ! name1 ) return ( name2 != NULL );
        if( ! name2 ) return -1;
-       return strcasecmp( name1, name2 );
+       return g_utf8_collate( name1, name2 );
+}
+
+static void addressbook_edit_group_size_allocate_cb(GtkWidget *widget,
+                                        GtkAllocation *allocation)
+{
+       g_return_if_fail(allocation != NULL);
+
+       prefs_common.addressbookeditgroupwin_width = allocation->width;
+       prefs_common.addressbookeditgroupwin_height = allocation->height;
 }
 
 static void addressbook_edit_group_create( gboolean *cancelled ) {
@@ -238,46 +275,50 @@ static void addressbook_edit_group_create( gboolean *cancelled ) {
        GtkWidget *clist_group;
        GtkWidget *clist_avail;
 
-       GtkWidget *vboxb;
-       GtkWidget *vbuttonbox;
        GtkWidget *buttonGroup;
        GtkWidget *buttonAvail;
        gint top;
 
-       gchar *titles[ GROUP_N_COLS ] = { _( "Name" ), _("E-Mail Address"), _("Remarks") };
-       gchar *text;
+       gchar *titles[ GROUP_N_COLS ];
        gint i;
 
-       window = gtk_window_new(GTK_WINDOW_DIALOG);
-       gtk_widget_set_usize(window, EDITGROUP_WIDTH, EDITGROUP_HEIGHT );
+       static GdkGeometry geometry;
+
+       titles[ GROUP_COL_NAME    ] = _( "Name" );
+       titles[ GROUP_COL_EMAIL   ] = _("Email Address");
+       titles[ GROUP_COL_REMARKS ] = _("Remarks");
+
+       window = gtkut_window_new(GTK_WINDOW_TOPLEVEL, "editgroup");
        gtk_container_set_border_width(GTK_CONTAINER(window), 0);
        gtk_window_set_title(GTK_WINDOW(window), _("Edit Group Data"));
        gtk_window_set_position(GTK_WINDOW(window), GTK_WIN_POS_CENTER);
-       gtk_window_set_modal(GTK_WINDOW(window), TRUE); 
-       gtk_signal_connect(GTK_OBJECT(window), "delete_event",
-                          GTK_SIGNAL_FUNC(edit_group_delete_event),
-                          cancelled);
-       gtk_signal_connect(GTK_OBJECT(window), "key_press_event",
-                          GTK_SIGNAL_FUNC(edit_group_key_pressed),
-                          cancelled);
+       gtk_window_set_modal(GTK_WINDOW(window), TRUE);
+       g_signal_connect(G_OBJECT(window), "delete_event",
+                        G_CALLBACK(edit_group_delete_event),
+                        cancelled);
+       g_signal_connect(G_OBJECT(window), "key_press_event",
+                        G_CALLBACK(edit_group_key_pressed),
+                        cancelled);
+       g_signal_connect(G_OBJECT(window), "size_allocate",
+                        G_CALLBACK(addressbook_edit_group_size_allocate_cb), NULL);
 
        vbox = gtk_vbox_new( FALSE, 6 );
        gtk_container_set_border_width(GTK_CONTAINER(vbox), BORDER_WIDTH);
        gtk_widget_show( vbox );
        gtk_container_add( GTK_CONTAINER( window ), vbox );
 
-       // Group area
+       /* Group area */
        hboxg = gtk_hbox_new( FALSE, 0 );
        gtk_box_pack_start(GTK_BOX(vbox), hboxg, FALSE, FALSE, 0);
 
-       // Data entry area
+       /* Data entry area */
        table = gtk_table_new( 1, 3, FALSE);
        gtk_box_pack_start(GTK_BOX(hboxg), table, TRUE, TRUE, 0);
        gtk_container_set_border_width( GTK_CONTAINER(table), 4 );
        gtk_table_set_row_spacings(GTK_TABLE(table), 0);
        gtk_table_set_col_spacings(GTK_TABLE(table), 4);
 
-       // First row
+       /* First row */
        top = 0;
        label = gtk_label_new(_("Group Name"));
        gtk_table_attach(GTK_TABLE(table), label, 0, 1, top, (top + 1), GTK_FILL, 0, 0, 0);
@@ -286,12 +327,12 @@ static void addressbook_edit_group_create( gboolean *cancelled ) {
        entry_name = gtk_entry_new();
        gtk_table_attach(GTK_TABLE(table), entry_name, 1, 2, top, (top + 1), GTK_EXPAND|GTK_SHRINK|GTK_FILL, 0, 0, 0);
 
-       // List area
+       /* List area */
        hboxl = gtk_hbox_new( FALSE, 6 );
        gtk_container_set_border_width( GTK_CONTAINER(hboxl), 8 );
        gtk_box_pack_start(GTK_BOX(vbox), hboxl, TRUE, TRUE, 0);
 
-       // Group list
+       /* Group list */
        vboxl = gtk_vbox_new( FALSE, 0 );
        gtk_box_pack_start(GTK_BOX(hboxl), vboxl, TRUE, TRUE, 0);
 
@@ -300,18 +341,28 @@ static void addressbook_edit_group_create( gboolean *cancelled ) {
        gtk_box_pack_start(GTK_BOX(vboxl), hboxh, FALSE, FALSE, 0);
        label = gtk_label_new(_("Addresses in Group"));
        gtk_box_pack_start(GTK_BOX(hboxh), label, TRUE, TRUE, 0);
-       buttonAvail = gtk_button_new_with_label( _( " -> " ) );
+       buttonAvail = gtk_button_new_from_stock(GTK_STOCK_REMOVE);
        gtk_box_pack_end(GTK_BOX(hboxh), buttonAvail, FALSE, FALSE, 0);
 
        clist_swin = gtk_scrolled_window_new( NULL, NULL );
        gtk_box_pack_start(GTK_BOX(vboxl), clist_swin, TRUE, TRUE, 0);
        gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(clist_swin),
                                       GTK_POLICY_AUTOMATIC,
-                                      GTK_POLICY_ALWAYS);
+                                      GTK_POLICY_AUTOMATIC);
 
-       clist_group = gtk_clist_new_with_titles( GROUP_N_COLS, titles );
+       clist_group = gtk_sctree_new_with_titles( GROUP_N_COLS, GROUP_N_COLS, titles );
        gtk_container_add( GTK_CONTAINER(clist_swin), clist_group );
-       gtk_clist_set_selection_mode( GTK_CLIST(clist_group), GTK_SELECTION_BROWSE );
+       if (prefs_common.enable_dotted_lines) {
+               gtk_ctree_set_line_style(GTK_CTREE(clist_group), GTK_CTREE_LINES_DOTTED);
+               gtk_ctree_set_expander_style(GTK_CTREE(clist_group),
+                                    GTK_CTREE_EXPANDER_SQUARE);
+       } else {
+               gtk_ctree_set_line_style(GTK_CTREE(clist_group), GTK_CTREE_LINES_NONE);
+               gtk_ctree_set_expander_style(GTK_CTREE(clist_group),
+                                    GTK_CTREE_EXPANDER_TRIANGLE);
+       }
+       gtk_sctree_set_stripes(GTK_SCTREE(clist_group), prefs_common.use_stripes_in_summaries);
+       gtk_clist_set_selection_mode( GTK_CLIST(clist_group), GTK_SELECTION_EXTENDED );
        gtk_clist_set_column_width( GTK_CLIST(clist_group), GROUP_COL_NAME, GROUP_COL_WIDTH_NAME );
        gtk_clist_set_column_width( GTK_CLIST(clist_group), GROUP_COL_EMAIL, GROUP_COL_WIDTH_EMAIL );
        gtk_clist_set_compare_func( GTK_CLIST(clist_group), edit_group_list_compare_func );
@@ -320,14 +371,14 @@ static void addressbook_edit_group_create( gboolean *cancelled ) {
        for( i = 0; i < GROUP_N_COLS; i++ )
                GTK_WIDGET_UNSET_FLAGS(GTK_CLIST(clist_group)->column[i].button, GTK_CAN_FOCUS);
 
-       // Available list
+       /* Available list */
        vboxl = gtk_vbox_new( FALSE, 0 );
        gtk_box_pack_start(GTK_BOX(hboxl), vboxl, TRUE, TRUE, 0);
 
        hboxh = gtk_hbox_new( FALSE, 0 );
        gtk_container_set_border_width( GTK_CONTAINER(hboxh), 4 );
        gtk_box_pack_start(GTK_BOX(vboxl), hboxh, FALSE, FALSE, 0);
-       buttonGroup = gtk_button_new_with_label( _( " <- " ) );
+       buttonGroup = gtk_button_new_from_stock(GTK_STOCK_ADD);
        gtk_box_pack_start(GTK_BOX(hboxh), buttonGroup, FALSE, FALSE, 0);
        label = gtk_label_new(_("Available Addresses"));
        gtk_box_pack_end(GTK_BOX(hboxh), label, TRUE, TRUE, 0);
@@ -336,11 +387,11 @@ static void addressbook_edit_group_create( gboolean *cancelled ) {
        gtk_box_pack_start(GTK_BOX(vboxl), clist_swin, TRUE, TRUE, 0);
        gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(clist_swin),
                                       GTK_POLICY_AUTOMATIC,
-                                      GTK_POLICY_ALWAYS);
+                                      GTK_POLICY_AUTOMATIC);
 
-       clist_avail = gtk_clist_new_with_titles( GROUP_N_COLS, titles );
+       clist_avail = gtk_sctree_new_with_titles( GROUP_N_COLS, GROUP_N_COLS, titles );
        gtk_container_add( GTK_CONTAINER(clist_swin), clist_avail );
-       gtk_clist_set_selection_mode( GTK_CLIST(clist_avail), GTK_SELECTION_BROWSE );
+       gtk_clist_set_selection_mode( GTK_CLIST(clist_avail), GTK_SELECTION_EXTENDED );
        gtk_clist_set_column_width( GTK_CLIST(clist_avail), GROUP_COL_NAME, GROUP_COL_WIDTH_NAME );
        gtk_clist_set_column_width( GTK_CLIST(clist_avail), GROUP_COL_EMAIL, GROUP_COL_WIDTH_EMAIL );
        gtk_clist_set_compare_func( GTK_CLIST(clist_avail), edit_group_list_compare_func );
@@ -349,38 +400,46 @@ static void addressbook_edit_group_create( gboolean *cancelled ) {
        for( i = 0; i < GROUP_N_COLS; i++ )
                GTK_WIDGET_UNSET_FLAGS(GTK_CLIST(clist_avail)->column[i].button, GTK_CAN_FOCUS);
 
-       // Status line
+       /* Status line */
        hsbox = gtk_hbox_new(FALSE, 0);
        gtk_box_pack_end(GTK_BOX(vbox), hsbox, FALSE, FALSE, BORDER_WIDTH);
        statusbar = gtk_statusbar_new();
        gtk_box_pack_start(GTK_BOX(hsbox), statusbar, TRUE, TRUE, BORDER_WIDTH);
 
-       // Button panel
-       gtkut_button_set_create(&hbbox, &ok_btn, _("OK"),
-                               &cancel_btn, _("Cancel"), NULL, NULL);
+       /* Button panel */
+       gtkut_stock_button_set_create(&hbbox, &cancel_btn, GTK_STOCK_CANCEL,
+                                     &ok_btn, GTK_STOCK_OK,
+                                     NULL, NULL);
        gtk_box_pack_end(GTK_BOX(vbox), hbbox, FALSE, FALSE, 0);
        gtk_widget_grab_default(ok_btn);
 
-       gtk_signal_connect(GTK_OBJECT(ok_btn), "clicked",
-                          GTK_SIGNAL_FUNC(edit_group_ok), cancelled);
-       gtk_signal_connect(GTK_OBJECT(cancel_btn), "clicked",
-                          GTK_SIGNAL_FUNC(edit_group_cancel), cancelled);
+       g_signal_connect(G_OBJECT(ok_btn), "clicked",
+                        G_CALLBACK(edit_group_ok), cancelled);
+       g_signal_connect(G_OBJECT(cancel_btn), "clicked",
+                        G_CALLBACK(edit_group_cancel), cancelled);
 
        gtk_widget_show_all(vbox);
 
-       // Event handlers
-       gtk_signal_connect( GTK_OBJECT(clist_group), "select_row",
-                       GTK_SIGNAL_FUNC( edit_group_group_selected), NULL );
-       gtk_signal_connect( GTK_OBJECT(clist_avail), "select_row",
-                       GTK_SIGNAL_FUNC( edit_group_avail_selected), NULL );
-       gtk_signal_connect( GTK_OBJECT(buttonGroup), "clicked",
-                       GTK_SIGNAL_FUNC( edit_group_to_group ), NULL );
-       gtk_signal_connect( GTK_OBJECT(buttonAvail), "clicked",
-                       GTK_SIGNAL_FUNC( edit_group_to_avail ), NULL );
-       gtk_signal_connect(GTK_OBJECT(clist_avail), "button_press_event",
-                          GTK_SIGNAL_FUNC(edit_group_list_avail_button), NULL);
-       gtk_signal_connect(GTK_OBJECT(clist_group), "button_press_event",
-                          GTK_SIGNAL_FUNC(edit_group_list_group_button), NULL);
+       /* Event handlers */
+       g_signal_connect( G_OBJECT(buttonGroup), "clicked",
+                         G_CALLBACK( edit_group_to_group ), NULL );
+       g_signal_connect( G_OBJECT(buttonAvail), "clicked",
+                         G_CALLBACK( edit_group_to_avail ), NULL );
+       g_signal_connect(G_OBJECT(clist_avail), "button_press_event",
+                        G_CALLBACK(edit_group_list_avail_button), NULL);
+       g_signal_connect(G_OBJECT(clist_group), "button_press_event",
+                        G_CALLBACK(edit_group_list_group_button), NULL);
+
+       if (!geometry.min_height) {
+               geometry.min_width = 580;
+               geometry.min_height = 340;
+       }
+
+       gtk_window_set_geometry_hints(GTK_WINDOW(window), NULL, &geometry,
+                                     GDK_HINT_MIN_SIZE);
+       gtk_widget_set_size_request(window,
+                                       prefs_common.addressbookeditgroupwin_width,
+                                   prefs_common.addressbookeditgroupwin_height);
 
        groupeditdlg.window     = window;
        groupeditdlg.ok_btn     = ok_btn;
@@ -393,7 +452,7 @@ static void addressbook_edit_group_create( gboolean *cancelled ) {
        groupeditdlg.clist_avail = GTK_CLIST( clist_avail );
 
        if( ! _edit_group_dfl_message_ ) {
-               _edit_group_dfl_message_ = _( "Move E-Mail Addresses to or from Group with arrow buttons" );
+               _edit_group_dfl_message_ = _( "Move Email Addresses to or from Group with arrow buttons" );
        }
 }
 
@@ -405,7 +464,7 @@ static GList *edit_group_build_email_list() {
        GList *listEMail = NULL;
        ItemEMail *email;
        gint row = 0;
-       while( email = gtk_clist_get_row_data( clist, row ) ) {
+       while( (email = gtk_clist_get_row_data( clist, row )) ) {
                listEMail = g_list_append( listEMail, email );
                row++;
        }
@@ -423,6 +482,7 @@ static GList *edit_group_build_email_list() {
 ItemGroup *addressbook_edit_group( AddressBookFile *abf, ItemFolder *parent, ItemGroup *group ) {
        static gboolean cancelled;
        GList *listEMail = NULL;
+       gchar *name;
 
        if (!groupeditdlg.window)
                addressbook_edit_group_create(&cancelled);
@@ -431,9 +491,7 @@ ItemGroup *addressbook_edit_group( AddressBookFile *abf, ItemFolder *parent, Ite
        gtk_widget_show(groupeditdlg.window);
        manage_window_set_transient(GTK_WINDOW(groupeditdlg.window));
 
-       // Clear all fields
-       groupeditdlg.rowIndGroup = -1;
-       groupeditdlg.rowIndAvail = -1;
+       /* Clear all fields */
        edit_group_status_show( "" );
        gtk_clist_clear( GTK_CLIST(groupeditdlg.clist_group) );
        gtk_clist_clear( GTK_CLIST(groupeditdlg.clist_avail) );
@@ -467,14 +525,16 @@ ItemGroup *addressbook_edit_group( AddressBookFile *abf, ItemFolder *parent, Ite
 
        listEMail = edit_group_build_email_list();
        if( group ) {
-               // Update email list
+               /* Update email list */
                addrbook_update_group_list( abf, group, listEMail );
        }
        else {
-               // Create new person and email list
+               /* Create new person and email list */
                group = addrbook_add_group_list( abf, parent, listEMail );
        }
-       addritem_group_set_name( group, gtk_editable_get_chars( GTK_EDITABLE(groupeditdlg.entry_name), 0, -1 ) );
+       name = gtk_editable_get_chars( GTK_EDITABLE(groupeditdlg.entry_name), 0, -1 );
+       addritem_group_set_name( group, name );
+       g_free( name );
 
        listEMail = NULL;
        return group;
@@ -507,7 +567,7 @@ ItemFolder *addressbook_edit_folder( AddressBookFile *abf, ItemFolder *parent, I
                return NULL;
        }
        if( folder ) {
-               if( strcasecmp( name, ADDRITEM_NAME(folder) ) == 0 ) {
+               if( strcmp( name, ADDRITEM_NAME(folder) ) == 0 ) {
                        g_free( name );
                        return NULL;
                }