fix bug 4239, 'Preferences: Text Options Header Display modal is not modal' (sic)
[claws.git] / src / editaddress.c
index 976cb4b6136b252c9689c1e33881585d391cde66..0dc34d5ccd6b055e6b1f397ccd17f63c54e51eb3 100644 (file)
@@ -1,6 +1,6 @@
 /*
- * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2007 Hiroyuki Yamamoto and the Claws Mail team
+ * Claws Mail -- a GTK+ based, lightweight, and fast e-mail client
+ * Copyright (C) 1999-2016 Hiroyuki Yamamoto and the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  *
  * You should have received a copy of the GNU General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
- * 
  */
 
 #ifdef HAVE_CONFIG_H
 #  include "config.h"
+#include "claws-features.h"
 #endif
 
 #include "defs.h"
 #include <glib.h>
 #include <glib/gi18n.h>
 #include <gdk/gdkkeysyms.h>
-#include <gtk/gtkwindow.h>
-#include <gtk/gtksignal.h>
-#include <gtk/gtklabel.h>
-#include <gtk/gtkvbox.h>
-#include <gtk/gtkentry.h>
-#include <gtk/gtktable.h>
+#include <gtk/gtk.h>
 
 #include "alertpanel.h"
+#include "stock_pixmap.h"
 #include "mgutils.h"
 #include "addressbook.h"
 #include "addressitem.h"
@@ -47,6 +43,8 @@
 #include "editaddress_other_attributes_ldap.h"
 #include "prefs_common.h"
 #include "menu.h"
+#include "combobox.h"
+#include "file-utils.h"
 
 /* transient data */
 static struct _PersonEdit_dlg personeditdlg;
@@ -56,35 +54,29 @@ static ItemFolder *current_parent_folder = NULL;
 static EditAddressPostUpdateCallback edit_person_close_post_update_cb = NULL;
 
 typedef enum {
-       EMAIL_COL_EMAIL   = 0,
-       EMAIL_COL_ALIAS   = 1,
-       EMAIL_COL_REMARKS = 2
+       EMAIL_COL_EMAIL,
+       EMAIL_COL_ALIAS,
+       EMAIL_COL_REMARKS,
+       EMAIL_COL_PTR
 } PersonEditEMailColumnPos;
 
-typedef enum {
-       ATTRIB_COL_NAME    = 0,
-       ATTRIB_COL_VALUE   = 1
-} PersonEditAttribColumnPos;
-
 #define EDITPERSON_WIDTH      520
 #define EDITPERSON_HEIGHT     320
 
-#ifndef MAEMO
-# define EMAIL_N_COLS          3
+#ifndef GENERIC_UMPC
+# define EMAIL_N_COLS          4
 # define EMAIL_COL_WIDTH_EMAIL 180
 # define EMAIL_COL_WIDTH_ALIAS 80
 #else
-# define EMAIL_N_COLS          1
+# define EMAIL_N_COLS          2
 # define EMAIL_COL_WIDTH_EMAIL 130
 # define EMAIL_COL_WIDTH_ALIAS 130
 #endif
 
-#ifndef MAEMO
-# define ATTRIB_N_COLS          2
+#ifndef GENERIC_UMPC
 # define ATTRIB_COL_WIDTH_NAME  240
 # define ATTRIB_COL_WIDTH_VALUE 0
 #else
-# define ATTRIB_N_COLS          2
 # define ATTRIB_COL_WIDTH_NAME  120
 # define ATTRIB_COL_WIDTH_VALUE 120
 #endif
@@ -94,6 +86,41 @@ typedef enum {
 #define PAGE_ATTRIBUTES        2
 
 static gboolean addressbook_edit_person_close( gboolean cancelled );
+static GList *edit_person_build_email_list();
+static GList *edit_person_build_attrib_list();
+
+static gchar* edit_person_get_common_name_from_widgets(void)
+{
+       gchar *cn = NULL; /* cn must be freed by caller */
+
+#ifndef GENERIC_UMPC
+       {
+               cn = gtk_editable_get_chars( GTK_EDITABLE(personeditdlg.entry_name), 0, -1 );
+               if ( cn == NULL || *cn == '\0' ) {
+                       gchar *first = gtk_editable_get_chars( GTK_EDITABLE(personeditdlg.entry_first), 0, -1 );
+                       gchar *last = gtk_editable_get_chars( GTK_EDITABLE(personeditdlg.entry_last), 0, -1 );
+                       cn = g_strdup_printf("%s%s%s", first?first:"", (first && last && *first && *last)?" ":"", last?last:"");
+                       g_free(first);
+                       g_free(last);
+               }
+               if ( cn == NULL || *cn == '\0' ) {
+                       g_free(cn);
+                       cn = gtk_editable_get_chars( GTK_EDITABLE(personeditdlg.entry_nick), 0, -1 );;
+               }
+       }
+#else
+       {
+               gchar *first = gtk_editable_get_chars( GTK_EDITABLE(personeditdlg.entry_first), 0, -1 );
+               gchar *last = gtk_editable_get_chars( GTK_EDITABLE(personeditdlg.entry_last), 0, -1 );
+               cn = g_strdup_printf("%s%s%s", first?first:"", (first && last && *first && *last)?" ":"", last?last:"");
+               g_free(first);
+               g_free(last);
+       }
+#endif
+       if ( cn != NULL )
+               g_strstrip(cn);
+       return cn;
+}
 
 static void edit_person_status_show( gchar *msg ) {
        if( personeditdlg.statusbar != NULL ) {
@@ -104,22 +131,122 @@ static void edit_person_status_show( gchar *msg ) {
        }
 }
 
-static void edit_person_ok(GtkWidget *widget, gboolean *cancelled) {
-       *cancelled = FALSE;
+static void edit_person_cancel(GtkWidget *widget, gboolean *cancelled) {
+       *cancelled = TRUE;
        if (prefs_common.addressbook_use_editaddress_dialog)
                gtk_main_quit();
        else
                addressbook_edit_person_close( *cancelled );
 }
 
-static void edit_person_cancel(GtkWidget *widget, gboolean *cancelled) {
-       *cancelled = TRUE;
+static void edit_person_ok(GtkWidget *widget, gboolean *cancelled) {
+       GList *listEMail = edit_person_build_email_list();
+       GList *listAttrib = edit_person_build_attrib_list();
+       gchar *cn = edit_person_get_common_name_from_widgets();
+
+       if( (cn == NULL || *cn == '\0') && listEMail == NULL && listAttrib == NULL ) {
+               gint val;
+
+               val = alertpanel( _("Add New Person"),
+#ifndef GENERIC_UMPC
+                               _("Adding a new person requires at least one of the\n"
+                                 "following values to be set:\n"
+                                 " - Display Name\n"
+                                 " - First Name\n"
+                                 " - Last Name\n"
+                                 " - Nickname\n"
+                                 " - any email address\n"
+                                 " - any additional attribute\n\n"
+                                 "Click OK to keep editing this contact.\n"
+                                 "Click Cancel to close without saving."),
+#else
+                               _("Adding a new person requires at least one of the\n"
+                                 "following values to be set:\n"
+                                 " - First Name\n"
+                                 " - Last Name\n"
+                                 " - any email address\n"
+                                 " - any additional attribute\n\n"
+                                 "Click OK to keep editing this contact.\n"
+                                 "Click Cancel to close without saving."),
+#endif
+                               GTK_STOCK_CANCEL, GTK_STOCK_OK, NULL, ALERTFOCUS_SECOND );
+               if( val == G_ALERTDEFAULT ) {
+                       edit_person_cancel(widget, cancelled);
+               }
+               g_free( cn );
+               return;
+       }
+       g_free( cn );
+
+       *cancelled = FALSE;
        if (prefs_common.addressbook_use_editaddress_dialog)
                gtk_main_quit();
        else
                addressbook_edit_person_close( *cancelled );
 }
 
+/* Updated up/down buttons sensitivity, depending on list
+ * cursor position */
+static void edit_person_email_update_buttons()
+{
+       GtkTreeModel *model;
+       GtkTreeIter iter, otheriter;
+       GtkTreePath *path;
+       gboolean has_prev;
+       ItemEMail *email;
+
+       email = gtkut_tree_view_get_selected_pointer(
+                       GTK_TREE_VIEW(personeditdlg.view_email), EMAIL_COL_PTR,
+                       &model, NULL, &iter);
+
+       if (email) {
+               if (!personeditdlg.read_only) {
+                       otheriter = iter;
+                       path = gtk_tree_model_get_path(model, &otheriter);
+                       has_prev = gtk_tree_path_prev(path);
+                       if (has_prev) {
+                               gtk_tree_model_get_iter(model, &otheriter, path);
+                       }
+                       gtk_widget_set_sensitive(personeditdlg.email_up, has_prev);
+
+                       otheriter = iter;
+                       gtk_widget_set_sensitive(personeditdlg.email_down,
+                                       gtk_tree_model_iter_next(model, &otheriter));
+               }
+       } else {
+               gtk_widget_set_sensitive(personeditdlg.email_del, FALSE);
+               gtk_widget_set_sensitive(personeditdlg.email_up, FALSE);
+               gtk_widget_set_sensitive(personeditdlg.email_down, FALSE);
+       }
+}
+
+static void edit_person_email_cursor_changed(GtkTreeView *view,
+               gpointer user_data)
+{
+       GtkTreeModel *model;
+       GtkTreeIter iter;
+       ItemEMail *email;
+
+       email = gtkut_tree_view_get_selected_pointer(
+                       GTK_TREE_VIEW(personeditdlg.view_email), EMAIL_COL_PTR,
+                       &model, NULL, &iter);
+
+       if (email != NULL) {
+               if (email->address != NULL)
+                       gtk_entry_set_text(GTK_ENTRY(personeditdlg.entry_email),
+                                       email->address);
+               if (ADDRITEM_NAME(email) != NULL)
+                       gtk_entry_set_text(GTK_ENTRY(personeditdlg.entry_alias),
+                                       ADDRITEM_NAME(email));
+               if (email->remarks != NULL)
+                       gtk_entry_set_text(GTK_ENTRY(personeditdlg.entry_remarks),
+                                       email->remarks);
+       }
+
+       edit_person_email_update_buttons();
+}
+
+
 static gint edit_person_delete_event(GtkWidget *widget, GdkEventAny *event, gboolean *cancelled) {
        *cancelled = TRUE;
        if (prefs_common.addressbook_use_editaddress_dialog)
@@ -131,7 +258,7 @@ static gint edit_person_delete_event(GtkWidget *widget, GdkEventAny *event, gboo
 
 static gboolean edit_person_key_pressed(GtkWidget *widget, GdkEventKey *event, gboolean *cancelled) {
        if (prefs_common.addressbook_use_editaddress_dialog) {
-       if (event && event->keyval == GDK_Escape) {
+       if (event && event->keyval == GDK_KEY_Escape) {
                *cancelled = TRUE;
                gtk_main_quit();
        }
@@ -146,7 +273,7 @@ static void edit_person_set_widgets_title( gchar *text )
 {
        gchar *label = NULL;
 
-       g_return_if_fail( text != NULL );
+       cm_return_if_fail( text != NULL );
 
        gtk_label_set_text(GTK_LABEL(personeditdlg.title), "");
        label = g_markup_printf_escaped("<b>%s</b>", text);
@@ -183,7 +310,11 @@ static void edit_person_set_window_title( gint pageNum ) {
                else {
                        gchar *name;
                        name = gtk_editable_get_chars( GTK_EDITABLE(personeditdlg.entry_name), 0, -1 );
-                       sTitle = g_strdup_printf( "%s - %s", _title_edit_, name );
+                       g_strstrip(name);
+                       if ( *name != '\0' )
+                               sTitle = g_strdup_printf( "%s - %s", _title_edit_, name );
+                       else
+                               sTitle = g_strdup( _title_edit_ );
                        g_free( name );
                }
                if (prefs_common.addressbook_use_editaddress_dialog)
@@ -202,12 +333,12 @@ static void edit_person_email_clear( gpointer data ) {
 
 static void edit_person_attrib_clear( gpointer data ) {
        if (!personeditdlg.ldap) {
-               gtk_entry_set_text( GTK_ENTRY(personeditdlg.entry_atname), "" );
+               gtk_entry_set_text( GTK_ENTRY(gtk_bin_get_child(GTK_BIN((personeditdlg.entry_atname)))), "" );
                gtk_entry_set_text( GTK_ENTRY(personeditdlg.entry_atvalue), "" );
        }
 }
 
-static void edit_person_switch_page( GtkNotebook *notebook, GtkNotebookPage *page,
+static void edit_person_switch_page( GtkNotebook *notebook, gpointer page,
                                        gint pageNum, gpointer user_data)
 {
        edit_person_set_window_title( pageNum );
@@ -219,96 +350,136 @@ static void edit_person_switch_page( GtkNotebook *notebook, GtkNotebookPage *pag
 */
 static void edit_person_load_email( ItemPerson *person ) {
        GList *node = person->listEMail;
-       GtkCList *clist = GTK_CLIST(personeditdlg.clist_email);
-       gchar *text[ EMAIL_N_COLS ];
+       GtkTreeModel *model = gtk_tree_view_get_model(
+                       GTK_TREE_VIEW(personeditdlg.view_email));
+       GtkTreeIter iter;
+
        while( node ) {
                ItemEMail *emorig = ( ItemEMail * ) node->data;
                ItemEMail *email = addritem_copyfull_item_email( emorig );
-               gint row;
-               text[ EMAIL_COL_EMAIL   ] = email->address;
-#ifndef MAEMO
-               text[ EMAIL_COL_ALIAS   ] = email->obj.name;
-               text[ EMAIL_COL_REMARKS ] = email->remarks;
+
+               gtk_list_store_append(GTK_LIST_STORE(model), &iter);
+               gtk_list_store_set(GTK_LIST_STORE(model), &iter,
+                               EMAIL_COL_EMAIL, email->address,
+#ifndef GENERIC_UMPC
+                               EMAIL_COL_ALIAS, email->obj.name,
+                               EMAIL_COL_REMARKS, email->remarks,
 #endif
-               row = gtk_clist_append( clist, text );
-               gtk_clist_set_row_data( clist, row, email );
+                               EMAIL_COL_PTR, email,
+                               -1);
+
                node = g_list_next( node );
        }
 }
 
-static void edit_person_email_list_selected( GtkCList *clist, gint row, gint column, GdkEvent *event, gpointer data ) {
-       ItemEMail *email = gtk_clist_get_row_data( clist, row );
+static void edit_person_email_move_up( gpointer data ) {
+       GtkTreeModel *model;
+       GtkTreeIter iter, otheriter;
+       GtkTreePath *path;
+       ItemEMail *email;
+       gboolean has_prev;
+
+       edit_person_email_clear( NULL );
+       edit_person_status_show( NULL );
+
+       email = gtkut_tree_view_get_selected_pointer(
+                       GTK_TREE_VIEW(personeditdlg.view_email), EMAIL_COL_PTR,
+                       &model, NULL, &iter);
+
        if( email ) {
-               if( email->address )
-                       gtk_entry_set_text( GTK_ENTRY(personeditdlg.entry_email), email->address );
-               if( ADDRITEM_NAME(email) )
-                       gtk_entry_set_text( GTK_ENTRY(personeditdlg.entry_alias), ADDRITEM_NAME(email) );
-               if( email->remarks )
-                       gtk_entry_set_text( GTK_ENTRY(personeditdlg.entry_remarks), email->remarks );
-               if (!personeditdlg.read_only) {
-                       gtk_widget_set_sensitive(personeditdlg.email_del, TRUE);
-                       gtk_widget_set_sensitive(personeditdlg.email_up, row > 0);
-                       gtk_widget_set_sensitive(personeditdlg.email_down, gtk_clist_get_row_data(clist, row + 1) != NULL);
+               otheriter = iter;
+               /* GTK+2 does not have gtk_tree_model_iter_previous(), so
+                * we have to go through GtkTreePath */
+               path = gtk_tree_model_get_path(model, &otheriter);
+               has_prev = gtk_tree_path_prev(path);
+               if (has_prev) {
+                       gtk_tree_model_get_iter(model, &otheriter, path);
+                       gtk_list_store_move_before(GTK_LIST_STORE(model), &iter, &otheriter);
                }
-       } else {
-               gtk_widget_set_sensitive(personeditdlg.email_del, FALSE);
-               gtk_widget_set_sensitive(personeditdlg.email_up, FALSE);
-               gtk_widget_set_sensitive(personeditdlg.email_down, FALSE);
+               gtk_tree_path_free(path);
        }
-       personeditdlg.rowIndEMail = row;
-       edit_person_status_show( NULL );
+
+       edit_person_email_update_buttons();
 }
 
-static void edit_person_email_move( gint dir ) {
-       GtkCList *clist = GTK_CLIST(personeditdlg.clist_email);
-       gint row = personeditdlg.rowIndEMail + dir;
-       ItemEMail *email = gtk_clist_get_row_data( clist, row );
+static void edit_person_email_move_down( gpointer data ) {
+       GtkTreeModel *model;
+       GtkTreeIter iter, otheriter;
+       ItemEMail *email;
+
+       edit_person_email_clear( NULL );
+       edit_person_status_show( NULL );
+
+       email = gtkut_tree_view_get_selected_pointer(
+                       GTK_TREE_VIEW(personeditdlg.view_email), EMAIL_COL_PTR,
+                       &model, NULL, &iter);
+
        if( email ) {
-               gtk_clist_row_move( clist, personeditdlg.rowIndEMail, row );
-               personeditdlg.rowIndEMail = row;
-               if (!personeditdlg.read_only) {
-                       gtk_widget_set_sensitive(personeditdlg.email_up, row > 0);
-                       gtk_widget_set_sensitive(personeditdlg.email_down, gtk_clist_get_row_data(clist, row + 1) != NULL);
+               otheriter = iter;
+               if (gtk_tree_model_iter_next(model, &otheriter)) {
+                       gtk_list_store_move_after(GTK_LIST_STORE(model), &iter, &otheriter);
                }
-       } else {
-               gtk_widget_set_sensitive(personeditdlg.email_up, FALSE);
-               gtk_widget_set_sensitive(personeditdlg.email_down, FALSE);
        }
-       edit_person_email_clear( NULL );
-       edit_person_status_show( NULL );
-}
 
-static void edit_person_email_move_up( gpointer data ) {
-       edit_person_email_move( -1 );
+       edit_person_email_update_buttons();
 }
 
-static void edit_person_email_move_down( gpointer data ) {
-       edit_person_email_move( +1 );
+static void edit_person_attrib_cursor_changed(GtkTreeView *view,
+               gpointer user_data)
+{
+       UserAttribute *attrib = gtkut_tree_view_get_selected_pointer(
+                       view, ATTRIB_COL_PTR, NULL, NULL, NULL);
+
+       if( attrib && !personeditdlg.read_only && !personeditdlg.ldap ) {
+               gtk_entry_set_text( GTK_ENTRY(gtk_bin_get_child(GTK_BIN((personeditdlg.entry_atname))) ), attrib->name );
+               gtk_entry_set_text( GTK_ENTRY(personeditdlg.entry_atvalue), attrib->value );
+               gtk_widget_set_sensitive(personeditdlg.attrib_del, TRUE);
+       } else {
+               gtk_widget_set_sensitive(personeditdlg.attrib_del, FALSE);
+       }
+       edit_person_status_show( NULL );
 }
 
+
 static void edit_person_email_delete( gpointer data ) {
-       GtkCList *clist = GTK_CLIST(personeditdlg.clist_email);
-       gint row = personeditdlg.rowIndEMail;
-       ItemEMail *email = gtk_clist_get_row_data( clist, row );
+       GtkTreeModel *model;
+       GtkTreeIter iter;
+       GtkTreeSelection *sel;
+       ItemEMail *email;
+       gboolean has_row = FALSE;
+       gint n;
+
        edit_person_email_clear( NULL );
+       edit_person_status_show( NULL );
+
+       email = gtkut_tree_view_get_selected_pointer(
+                       GTK_TREE_VIEW(personeditdlg.view_email), EMAIL_COL_PTR,
+                       &model, &sel, &iter);
+
        if( email ) {
-               /* Remove list entry */
-               gtk_clist_remove( clist, row );
+               /* Remove list entry and set iter to next row, if any */
+               has_row = gtk_list_store_remove(GTK_LIST_STORE(model), &iter);
                addritem_free_item_email( email );
                email = NULL;
        }
 
        /* Position hilite bar */
-       email = gtk_clist_get_row_data( clist, row );
-       if( ! email ) {
-               personeditdlg.rowIndEMail = -1 + row;
-       }
-       if (!personeditdlg.read_only) {
-               gtk_widget_set_sensitive(personeditdlg.email_del, gtk_clist_get_row_data(clist, 0) != NULL);
-               gtk_widget_set_sensitive(personeditdlg.email_up, gtk_clist_get_row_data(clist, personeditdlg.rowIndEMail + 1) != NULL);
-               gtk_widget_set_sensitive(personeditdlg.email_down, gtk_clist_get_row_data(clist, personeditdlg.rowIndEMail - 1) != NULL);
+       if (!has_row) {
+               /* The removed row was the last in the list, so iter is not
+                * valid. Find out if there is at least one row remaining
+                * in the list, and select the last one if so. */
+               n = gtk_tree_model_iter_n_children(model, NULL);
+               if (n > 0 && gtk_tree_model_iter_nth_child(model, &iter, NULL, n-1)) {
+                       /* It exists */
+                       has_row = TRUE;
+               }
        }
-       edit_person_status_show( NULL );
+
+       if (has_row)
+               gtk_tree_selection_select_iter(sel, &iter);
+
+       edit_person_email_cursor_changed(
+                       GTK_TREE_VIEW(personeditdlg.view_email), NULL);
 }
 
 static ItemEMail *edit_person_email_edit( gboolean *error, ItemEMail *email ) {
@@ -344,147 +515,174 @@ static ItemEMail *edit_person_email_edit( gboolean *error, ItemEMail *email ) {
 }
 
 static void edit_person_email_modify( gpointer data ) {
+       GtkTreeModel *model;
+       GtkTreeIter iter;
        gboolean errFlg = FALSE;
-       GtkCList *clist = GTK_CLIST(personeditdlg.clist_email);
-       gint row = personeditdlg.rowIndEMail;
-       ItemEMail *email = gtk_clist_get_row_data( clist, row );
+       ItemEMail *email;
+
+       email = gtkut_tree_view_get_selected_pointer(
+                       GTK_TREE_VIEW(personeditdlg.view_email), EMAIL_COL_PTR,
+                       &model, NULL, &iter);
+
        if( email ) {
                edit_person_email_edit( &errFlg, email );
                if( ! errFlg ) {
-                       gtk_clist_set_text( clist, row, EMAIL_COL_EMAIL, email->address );
-                       gtk_clist_set_text( clist, row, EMAIL_COL_ALIAS, email->obj.name );
-                       gtk_clist_set_text( clist, row, EMAIL_COL_REMARKS, email->remarks );
+                       gtk_list_store_set(GTK_LIST_STORE(model), &iter,
+                                       EMAIL_COL_EMAIL, email->address,
+#ifndef GENERIC_UMPC
+                                       EMAIL_COL_ALIAS, email->obj.name,
+                                       EMAIL_COL_REMARKS, email->remarks,
+#endif
+                                       -1);
                        edit_person_email_clear( NULL );
                }
        }
 }
 
 static void edit_person_email_add( gpointer data ) {
-       GtkCList *clist = GTK_CLIST(personeditdlg.clist_email);
-       gboolean errFlg = FALSE;
+       GtkTreeModel *model;
+       GtkTreeIter iter, otheriter;
+       GtkTreeSelection *sel;
+       gboolean errFlg = FALSE, prev_exists = FALSE;
        ItemEMail *email = NULL;
-       gint row = personeditdlg.rowIndEMail;
-       if( gtk_clist_get_row_data( clist, row ) == NULL ) row = 0;
+
+       email = gtkut_tree_view_get_selected_pointer(
+                       GTK_TREE_VIEW(personeditdlg.view_email), EMAIL_COL_PTR,
+                       &model, &sel, &otheriter);
+       if (email != NULL)
+               prev_exists = TRUE;
 
        email = edit_person_email_edit( &errFlg, NULL );
        if( ! errFlg ) {
-               gchar *text[ EMAIL_N_COLS ];
-               text[ EMAIL_COL_EMAIL   ] = email->address;
-#ifndef MAEMO
-               text[ EMAIL_COL_ALIAS   ] = email->obj.name;
-               text[ EMAIL_COL_REMARKS ] = email->remarks;
+               if (prev_exists)
+                       gtk_list_store_insert_after(GTK_LIST_STORE(model), &iter, &otheriter);
+               else /* list is empty */
+                       gtk_list_store_append(GTK_LIST_STORE(model), &iter);
+
+               gtk_list_store_set(GTK_LIST_STORE(model), &iter,
+                                       EMAIL_COL_EMAIL, email->address,
+#ifndef GENERIC_UMPC
+                                       EMAIL_COL_ALIAS, email->obj.name,
+                                       EMAIL_COL_REMARKS, email->remarks,
 #endif
-               row = gtk_clist_insert( clist, 1 + row, text );
-               gtk_clist_set_row_data( clist, row, email );
-               gtk_clist_select_row( clist, row, 0 );
+                                       EMAIL_COL_PTR, email,
+                                       -1);
+               gtk_tree_selection_select_iter(sel, &iter);
+               edit_person_email_update_buttons();
+
                edit_person_email_clear( NULL );
        }
 }
 
-/*
-* Comparison using cell contents (text in first column). Used for sort
-* address index widget.
-*/
-static gint edit_person_attrib_compare_func(
-       GtkCList *clist, gconstpointer ptr1, gconstpointer ptr2 )
+static gboolean list_find_email(const gchar *addr)
 {
-       GtkCell *cell1 = ((GtkCListRow *)ptr1)->cell;
-       GtkCell *cell2 = ((GtkCListRow *)ptr2)->cell;
-       gchar *name1 = NULL, *name2 = NULL;
-
-       if( cell1 ) name1 = cell1->u.text;
-       if( cell2 ) name2 = cell2->u.text;
-       if( ! name1 ) return ( name2 != NULL );
-       if( ! name2 ) return -1;
-       return g_utf8_collate( name1, name2 );
-}
+       GtkWidget *view = personeditdlg.view_email;
+       GtkTreeModel *model = gtk_tree_view_get_model(GTK_TREE_VIEW(view));
+       GtkTreeSelection *sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(view));
+       GtkTreeIter iter;
+       ItemEMail *email;
 
-static gboolean list_find_attribute(const gchar *attr)
-{
-       GtkCList *clist = GTK_CLIST(personeditdlg.clist_attrib);
-       UserAttribute *attrib;
-       gint row = 0;
-       while( (attrib = gtk_clist_get_row_data( clist, row )) ) {
-               if (!g_ascii_strcasecmp(attrib->name, attr)) {
-                       gtk_clist_select_row(clist, row, 0);
+       if (!gtk_tree_model_get_iter_first(model, &iter))
+               return FALSE;
+
+       do {
+               gtk_tree_model_get(model, &iter, EMAIL_COL_PTR, &email, -1);
+               if (!g_ascii_strcasecmp(email->address, addr)) {
+                       gtk_tree_selection_select_iter(sel, &iter);
                        return TRUE;
                }
-               row++;
-       }
+       } while (gtk_tree_model_iter_next(model, &iter));
+
        return FALSE;
 }
 
-static gboolean list_find_email(const gchar *addr)
+static gboolean list_find_attribute(const gchar *attr)
 {
-       GtkCList *clist = GTK_CLIST(personeditdlg.clist_email);
-       ItemEMail *email;
-       gint row = 0;
-       while( (email = gtk_clist_get_row_data( clist, row )) ) {
-               if (!g_ascii_strcasecmp(email->address, addr)) {
-                       gtk_clist_select_row(clist, row, 0);
+       GtkWidget *view = personeditdlg.view_attrib;
+       GtkTreeModel *model = gtk_tree_view_get_model(GTK_TREE_VIEW(view));
+       GtkTreeSelection *sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(view));
+       GtkTreeIter iter;
+       UserAttribute *attrib;
+
+       if (!gtk_tree_model_get_iter_first(model, &iter))
+               return FALSE;
+
+       do {
+               gtk_tree_model_get(model, &iter, ATTRIB_COL_PTR, &attrib, -1);
+               if (!g_ascii_strcasecmp(attrib->name, attr)) {
+                       gtk_tree_selection_select_iter(sel, &iter);
                        return TRUE;
                }
-               row++;
-       }
+       } while (gtk_tree_model_iter_next(model, &iter));
+
        return FALSE;
 }
 
 /*
-* Load clist with a copy of person's email addresses.
+* Load list with a copy of person's email addresses.
 */
 static void edit_person_load_attrib( ItemPerson *person ) {
        GList *node = person->listAttrib;
-       GtkCList *clist = GTK_CLIST(personeditdlg.clist_attrib);
-       gchar *text[ ATTRIB_N_COLS ];
+       GtkWidget *view = personeditdlg.view_attrib;
+       GtkTreeModel *model = gtk_tree_view_get_model(GTK_TREE_VIEW(view));
+       GtkTreeIter iter;
+
        while( node ) {
                UserAttribute *atorig = ( UserAttribute * ) node->data;
                UserAttribute *attrib = addritem_copy_attribute( atorig );
-               gint row;
+
                debug_print("name: %s value: %s\n", attrib->name, attrib->value);
-               text[ ATTRIB_COL_NAME  ] = attrib->name;
-               text[ ATTRIB_COL_VALUE ] = attrib->value;
 
-               row = gtk_clist_append( clist, text );
-               gtk_clist_set_row_data( clist, row, attrib );
-               node = g_list_next( node );
-       }
-}
+               gtk_list_store_append(GTK_LIST_STORE(model), &iter);
+               gtk_list_store_set(GTK_LIST_STORE(model), &iter,
+                               ATTRIB_COL_NAME, attrib->name,
+                               ATTRIB_COL_VALUE, attrib->value,
+                               ATTRIB_COL_PTR, attrib,
+                               -1);
 
-static void edit_person_attrib_list_selected( GtkCList *clist, gint row, gint column, GdkEvent *event, gpointer data ) {
-       UserAttribute *attrib = gtk_clist_get_row_data( clist, row );
-       if( attrib && !personeditdlg.read_only && !personeditdlg.ldap ) {
-               gtk_entry_set_text( GTK_ENTRY(personeditdlg.entry_atname), attrib->name );
-               gtk_entry_set_text( GTK_ENTRY(personeditdlg.entry_atvalue), attrib->value );
-               gtk_widget_set_sensitive(personeditdlg.attrib_del, TRUE);
-       } else {
-               gtk_widget_set_sensitive(personeditdlg.attrib_del, FALSE);
+               node = g_list_next( node );
        }
-       personeditdlg.rowIndAttrib = row;
-       edit_person_status_show( NULL );
 }
 
-static void edit_person_attrib_delete( gpointer data ) {
-       GtkCList *clist = GTK_CLIST(personeditdlg.clist_attrib);
-       gint row = personeditdlg.rowIndAttrib;
-       UserAttribute *attrib = gtk_clist_get_row_data( clist, row );
-       edit_person_attrib_clear( NULL );
-       if( attrib ) {
-               /* Remove list entry */
-               gtk_clist_remove( clist, row );
-               addritem_free_attribute( attrib );
+static void edit_person_attrib_delete(gpointer data) {
+       UserAttribute *attrib;
+       GtkTreeModel *model;
+       GtkTreeSelection *sel;
+       GtkTreeIter iter;
+       gboolean has_row = FALSE;
+       gint n;
+
+       edit_person_attrib_clear(NULL);
+       edit_person_status_show(NULL);
+
+       attrib = gtkut_tree_view_get_selected_pointer(
+                       GTK_TREE_VIEW(personeditdlg.view_attrib), ATTRIB_COL_PTR,
+                       &model, &sel, &iter);
+
+       if (attrib) {
+               /* Remove list entry, and set iter to next row, if any */
+               has_row = gtk_list_store_remove(GTK_LIST_STORE(model), &iter);
+               addritem_free_attribute(attrib);
                attrib = NULL;
        }
 
        /* Position hilite bar */
-       attrib = gtk_clist_get_row_data( clist, row );
-       if( ! attrib ) {
-               personeditdlg.rowIndAttrib = -1 + row;
-       } 
-       
-       if (!personeditdlg.read_only && !personeditdlg.ldap)
-               gtk_widget_set_sensitive(personeditdlg.attrib_del, gtk_clist_get_row_data(clist, 0) != NULL);
-       
-       edit_person_status_show( NULL );
+       if (!has_row) {
+               /* The removed row was the last in the list, so iter is not
+                * valid. Find out if there is at least one row remaining
+                * in the list, and select the last one if so. */
+               n = gtk_tree_model_iter_n_children(model, NULL);
+               if (n > 0 && gtk_tree_model_iter_nth_child(model, &iter, NULL, n-1)) {
+                       /* It exists. */
+                       has_row = TRUE;
+               }
+       }
+
+       if (has_row)
+               gtk_tree_selection_select_iter(sel, &iter);
+
+       edit_person_attrib_cursor_changed(
+                       GTK_TREE_VIEW(personeditdlg.view_attrib), NULL);
 }
 
 static UserAttribute *edit_person_attrib_edit( gboolean *error, UserAttribute *attrib ) {
@@ -492,7 +690,7 @@ static UserAttribute *edit_person_attrib_edit( gboolean *error, UserAttribute *a
        gchar *sName, *sValue, *sName_, *sValue_;
 
        *error = TRUE;
-       sName_ = gtk_editable_get_chars( GTK_EDITABLE(personeditdlg.entry_atname), 0, -1 );
+       sName_ = gtk_editable_get_chars( GTK_EDITABLE(gtk_bin_get_child(GTK_BIN((personeditdlg.entry_atname)))), 0, -1 );
        sValue_ = gtk_editable_get_chars( GTK_EDITABLE(personeditdlg.entry_atvalue), 0, -1 );
        sName = mgu_email_check_empty( sName_ );
        sValue = mgu_email_check_empty( sValue_ );
@@ -518,39 +716,60 @@ static UserAttribute *edit_person_attrib_edit( gboolean *error, UserAttribute *a
        return retVal;
 }
 
-static void edit_person_attrib_modify( gpointer data ) {
+static void edit_person_attrib_modify(gpointer data) {
        gboolean errFlg = FALSE;
-       GtkCList *clist = GTK_CLIST(personeditdlg.clist_attrib);
-       gint row = personeditdlg.rowIndAttrib;
-       UserAttribute *attrib = gtk_clist_get_row_data( clist, row );
-       if( attrib ) {
-               edit_person_attrib_edit( &errFlg, attrib );
-               if( ! errFlg ) {
-                       gtk_clist_set_text( clist, row, ATTRIB_COL_NAME, attrib->name );
-                       gtk_clist_set_text( clist, row, ATTRIB_COL_VALUE, attrib->value );
-                       edit_person_attrib_clear( NULL );
+       GtkTreeModel *model;
+       GtkTreeIter iter;
+       UserAttribute *attrib;
+
+       attrib = gtkut_tree_view_get_selected_pointer(
+                       GTK_TREE_VIEW(personeditdlg.view_attrib), ATTRIB_COL_PTR,
+                       &model, NULL, &iter);
+       if (attrib) {
+               edit_person_attrib_edit(&errFlg, attrib);
+               if (!errFlg) {
+                       gtk_list_store_set(GTK_LIST_STORE(model), &iter,
+                                       ATTRIB_COL_NAME, attrib->name,
+                                       ATTRIB_COL_VALUE, attrib->value,
+                                       -1);
+                       edit_person_attrib_clear(NULL);
                }
        }
 }
 
-static void edit_person_attrib_add( gpointer data ) {
-       GtkCList *clist = GTK_CLIST(personeditdlg.clist_attrib);
+static void edit_person_attrib_add(gpointer data) {
        gboolean errFlg = FALSE;
-       UserAttribute *attrib = NULL;
-       gint row = personeditdlg.rowIndAttrib;
-       if( gtk_clist_get_row_data( clist, row ) == NULL ) row = 0;
+       GtkTreeModel *model;
+       GtkTreeSelection *sel;
+       GtkTreeIter iter, iter2;
+       UserAttribute *prev_attrib, *attrib;
 
-       attrib = edit_person_attrib_edit( &errFlg, NULL );
-       if( ! errFlg ) {
-               gchar *text[ ATTRIB_N_COLS ];
-               text[ ATTRIB_COL_NAME  ] = attrib->name;
-               text[ ATTRIB_COL_VALUE ] = attrib->value;
-
-               row = gtk_clist_insert( clist, 1 + row, text );
-               gtk_clist_set_row_data( clist, row, attrib );
-               gtk_clist_select_row( clist, row, 0 );
-               edit_person_attrib_clear( NULL );
+       attrib = edit_person_attrib_edit(&errFlg, NULL);
+       if (attrib == NULL) /* input for new attribute is not valid */
+               return;
+
+       prev_attrib = gtkut_tree_view_get_selected_pointer(
+                       GTK_TREE_VIEW(personeditdlg.view_attrib), ATTRIB_COL_PTR,
+                       &model, &sel, &iter);
+
+       if (prev_attrib == NULL) {
+               /* No row selected, or list empty, add new attribute as first row. */
+               gtk_list_store_insert(GTK_LIST_STORE(model), &iter, 0);
+       } else {
+               /* Add it after the currently selected row. */
+               gtk_list_store_insert_after(GTK_LIST_STORE(model), &iter2,
+                               &iter);
+               iter = iter2;
        }
+
+       /* Fill out the new row. */
+       gtk_list_store_set(GTK_LIST_STORE(model), &iter,
+                       ATTRIB_COL_NAME, attrib->name,
+                       ATTRIB_COL_VALUE, attrib->value,
+                       ATTRIB_COL_PTR, attrib,
+                       -1);
+       gtk_tree_selection_select_iter(sel, &iter);
+       edit_person_attrib_clear(NULL);
 }
 
 /*!
@@ -559,7 +778,7 @@ static void edit_person_attrib_add( gpointer data ) {
 static void edit_person_size_allocate_cb(GtkWidget *widget,
                                         GtkAllocation *allocation)
 {
-       g_return_if_fail(allocation != NULL);
+       cm_return_if_fail(allocation != NULL);
 
        prefs_common.addressbookeditpersonwin_width = allocation->width;
        prefs_common.addressbookeditpersonwin_height = allocation->height;
@@ -631,7 +850,8 @@ static void addressbook_edit_person_dialog_create( gboolean *cancelled ) {
        /* gtk_container_set_border_width(GTK_CONTAINER(window), 0); */
        gtk_window_set_title(GTK_WINDOW(window), _("Edit Person Data"));
        gtk_window_set_position(GTK_WINDOW(window), GTK_WIN_POS_CENTER);
-       gtk_window_set_modal(GTK_WINDOW(window), TRUE); 
+       gtk_window_set_modal(GTK_WINDOW(window), FALSE);
+       gtk_window_set_type_hint(GTK_WINDOW(window), GDK_WINDOW_TYPE_HINT_DIALOG);
        g_signal_connect(G_OBJECT(window), "delete_event",
                         G_CALLBACK(edit_person_delete_event),
                         cancelled);
@@ -698,59 +918,104 @@ void addressbook_edit_person_widgetset_hide( void )
                gtk_widget_hide( personeditdlg.container );
 }
 
-static void addressbook_edit_person_unset_picture (void *obj, guint action, void *data)
+static void addressbook_edit_person_set_picture(void)
 {
-       personeditdlg.pixbuf = gdk_pixbuf_new(GDK_COLORSPACE_RGB, TRUE, 8, 48, 48);
-       gdk_pixbuf_fill(personeditdlg.pixbuf, 0xffffff00);
+       GError *error = NULL;
+       gchar *filename;
+       int width, height, scalewidth, scaleheight;
+
+       if (personeditdlg.ldap)
+               return;
+
+       if ( (filename = filesel_select_file_open(_("Choose a picture"), NULL)) ) {
+               GdkPixbuf *pixbuf = NULL;
+               gdk_pixbuf_get_file_info(filename, &width, &height);
+
+               if ( width > 128 || height > 128 ) {
+                       if (width > height) {
+                               scaleheight = (height * 128) / width;
+                               scalewidth = 128;
+                       }
+                       else {
+                               scalewidth = (width * 128) / height;
+                               scaleheight = 128;
+                       }
+                       pixbuf = gdk_pixbuf_new_from_file_at_scale(filename, 
+                                       scalewidth, scaleheight, TRUE, &error);
+               } else {
+                       pixbuf = gdk_pixbuf_new_from_file(filename, &error);
+               }
+               if (error) {
+                       alertpanel_error(_("Failed to import image: \n%s"),
+                                       error->message);
+                       g_error_free(error);
+                       error = NULL;
+                       /* keep the previous picture if any */
+                       g_free(filename);
+                       if (pixbuf)
+                               g_object_unref(pixbuf);
+                       return;
+               }
+               personeditdlg.picture_set = TRUE;
+               cm_menu_set_sensitive("EditAddressPopup/UnsetPicture", personeditdlg.picture_set);
+               g_free(filename);
+               gtk_image_set_from_pixbuf(GTK_IMAGE(personeditdlg.image), pixbuf);
+               g_object_unref(pixbuf);
+       }
+}      
+
+static void addressbook_edit_person_clear_picture(void)
+{
+       GdkPixbuf *pixbuf;
+
+       stock_pixbuf_gdk(STOCK_PIXMAP_ANONYMOUS, &pixbuf);
        personeditdlg.picture_set = FALSE;
-       gtk_image_set_from_pixbuf(GTK_IMAGE(personeditdlg.image), personeditdlg.pixbuf);
+       cm_menu_set_sensitive("EditAddressPopup/UnsetPicture", personeditdlg.picture_set);
+       gtk_image_set_from_pixbuf(GTK_IMAGE(personeditdlg.image), pixbuf);
 }
 
-static GtkItemFactoryEntry editaddr_popup_entries[] =
+static void addressbook_edit_person_set_picture_menu_cb (GtkAction *action, gpointer data)
 {
-       {N_("/_Unset picture"),         NULL, addressbook_edit_person_unset_picture, 0, NULL},
+       addressbook_edit_person_set_picture();
+}
+
+static void addressbook_edit_person_unset_picture_menu_cb (GtkAction *action, gpointer data)
+{
+       addressbook_edit_person_clear_picture();
+}
+
+static GtkWidget *editaddr_popup_menu = NULL;
+static GtkActionEntry editaddr_popup_entries[] =
+{
+       {"EditAddressPopup",                    NULL, "EditAddressPopup", NULL, NULL, NULL },
+       {"EditAddressPopup/SetPicture",         NULL, N_("_Set picture"), NULL, NULL, G_CALLBACK(addressbook_edit_person_set_picture_menu_cb) },
+       {"EditAddressPopup/UnsetPicture",       NULL, N_("_Unset picture"), NULL, NULL, G_CALLBACK(addressbook_edit_person_unset_picture_menu_cb) },
 };
 
-static void addressbook_edit_person_set_picture(GtkWidget *widget, 
+static void addressbook_edit_person_set_picture_cb(GtkWidget *widget, 
                GdkEventButton *event, gpointer data)
-{
-       GError *error = NULL;
-       gchar *filename;
-       int width, height, scalewidth, scaleheight;
-       
+{      
        if (event->button == 1) {
-               if ( (filename = filesel_select_file_open(_("Choose a picture"), NULL)) ) {
-                       personeditdlg.pixbuf = gdk_pixbuf_new_from_file(filename, &error);
-                       if (error) {
-                               alertpanel_error(_("Failed to import image: \n%s"),
-                                               error->message);
-                               g_error_free(error);
-                       }
-                       personeditdlg.picture_set = TRUE;
-                       g_free(filename);
-                       width = gdk_pixbuf_get_width(personeditdlg.pixbuf);
-                       height = gdk_pixbuf_get_height(personeditdlg.pixbuf);
-
-                       if ( width > 128 || height > 128 ) {
-                               if (width > height) {
-                                       scaleheight = (height * 128) / width;
-                                       scalewidth = 128;
-                               }
-                               else {
-                                       scalewidth = (width * 128) / height;
-                                       scaleheight = 128;
-                               }
-                               personeditdlg.pixbuf = gdk_pixbuf_scale_simple(personeditdlg.pixbuf, scalewidth, scaleheight, GDK_INTERP_BILINEAR);
-                       }
-               gtk_image_set_from_pixbuf(GTK_IMAGE(personeditdlg.image), personeditdlg.pixbuf);
-               }
+               addressbook_edit_person_set_picture();
        } else {
-               gtk_menu_popup(GTK_MENU(personeditdlg.editaddr_popupmenu), 
+               gtk_menu_popup(GTK_MENU(editaddr_popup_menu), 
                               NULL, NULL, NULL, NULL, 
                               event->button, event->time);
        }
 }
 
+static gboolean addressbook_edit_person_picture_popup_menu(GtkWidget *widget, gpointer data)
+{
+       GdkEventButton event;
+       
+       event.button = 3;
+       event.time = gtk_get_current_event_time();
+       
+       addressbook_edit_person_set_picture_cb(NULL, &event, data);
+
+       return TRUE;
+}
+
 static void addressbook_edit_person_page_basic( gint pageNum, gchar *pageLbl ) {
        GtkWidget *vbox;
        GtkWidget *hbox;
@@ -764,23 +1029,30 @@ static void addressbook_edit_person_page_basic( gint pageNum, gchar *pageLbl ) {
        GtkWidget *entry_nn;
        const gchar *locale;
        gint top = 0;
-       gint n_entries;
 
        vbox = gtk_vbox_new( FALSE, 20 );
        hbox = gtk_hbox_new( FALSE, 8 );
 
        gtk_widget_show( vbox );        
-       
+
+       if (!editaddr_popup_menu) {
+               cm_menu_create_action_group("EditAddressPopup", editaddr_popup_entries,
+                       G_N_ELEMENTS(editaddr_popup_entries), (gpointer)NULL);
+               MENUITEM_ADDUI("/Menus", "EditAddressPopup", "EditAddressPopup", GTK_UI_MANAGER_MENU)
+               MENUITEM_ADDUI("/Menus/EditAddressPopup", "SetPicture", "EditAddressPopup/SetPicture", GTK_UI_MANAGER_MENUITEM)
+               MENUITEM_ADDUI("/Menus/EditAddressPopup", "UnsetPicture", "EditAddressPopup/UnsetPicture", GTK_UI_MANAGER_MENUITEM)
+
+               editaddr_popup_menu = gtk_menu_item_get_submenu(GTK_MENU_ITEM(
+                       gtk_ui_manager_get_widget(gtkut_ui_manager(), "/Menus/EditAddressPopup")) );
+       }
        /* User's picture */
        ebox_picture = gtk_event_box_new();
-       frame_picture = gtk_frame_new("Photo");
+       frame_picture = gtk_frame_new(_("Photo"));
        
        /* Room for a photo */
-       personeditdlg.pixbuf = gdk_pixbuf_new(GDK_COLORSPACE_RGB, TRUE, 8, 48, 48);
-       gdk_pixbuf_fill(personeditdlg.pixbuf, 0xffffff00);
-       personeditdlg.picture_set = FALSE;
-       personeditdlg.image = gtk_image_new_from_pixbuf(personeditdlg.pixbuf);
-       
+       personeditdlg.image = gtk_image_new();
+       addressbook_edit_person_clear_picture();
+
        gtk_container_add(GTK_CONTAINER(ebox_picture), personeditdlg.image);
        gtk_container_add(GTK_CONTAINER(frame_picture), ebox_picture);  
        gtk_container_add(GTK_CONTAINER( personeditdlg.notebook ), hbox );
@@ -796,14 +1068,10 @@ static void addressbook_edit_person_page_basic( gint pageNum, gchar *pageLbl ) {
                GTK_NOTEBOOK( personeditdlg.notebook ),
                gtk_notebook_get_nth_page( GTK_NOTEBOOK( personeditdlg.notebook ), pageNum ), label );
        
+       g_signal_connect(G_OBJECT(ebox_picture), "popup-menu",
+                        G_CALLBACK(addressbook_edit_person_picture_popup_menu), NULL);
        g_signal_connect(G_OBJECT(ebox_picture), "button_press_event", 
-                       G_CALLBACK(addressbook_edit_person_set_picture), NULL);
-
-       n_entries = sizeof(editaddr_popup_entries) /
-               sizeof(editaddr_popup_entries[0]);
-       personeditdlg.editaddr_popupmenu = menu_create_items(editaddr_popup_entries, n_entries,
-                                     "<EditAddrPopupMenu>", &personeditdlg.editaddr_popupfactory,
-                                     NULL);
+                       G_CALLBACK(addressbook_edit_person_set_picture_cb), NULL);
 
        table = gtk_table_new( 3, 3, FALSE);
 
@@ -825,15 +1093,17 @@ static void addressbook_edit_person_page_basic( gint pageNum, gchar *pageLbl ) {
        entry = gtk_entry_new(); \
 }
 
-#ifndef MAEMO
+#ifndef GENERIC_UMPC
        ATTACH_ROW(_("Display Name"), entry_name);
 #else
        ATTACH_HIDDEN_ROW(_("Display Name"), entry_name);
 #endif
        locale = conv_get_current_locale();
        if (locale &&
-           (!g_ascii_strncasecmp(locale, "ja", 2) ||
+           (!g_ascii_strncasecmp(locale, "hu", 2) ||
+            !g_ascii_strncasecmp(locale, "ja", 2) ||
             !g_ascii_strncasecmp(locale, "ko", 2) ||
+            !g_ascii_strncasecmp(locale, "vi", 2) ||
             !g_ascii_strncasecmp(locale, "zh", 2))) {
                ATTACH_ROW(_("Last Name"), entry_ln);
                ATTACH_ROW(_("First Name"), entry_fn);
@@ -841,7 +1111,7 @@ static void addressbook_edit_person_page_basic( gint pageNum, gchar *pageLbl ) {
                ATTACH_ROW(_("First Name"), entry_fn);
                ATTACH_ROW(_("Last Name"), entry_ln);
        }
-#ifndef MAEMO
+#ifndef GENERIC_UMPC
        ATTACH_ROW(_("Nickname"), entry_nn);
 #else
        ATTACH_HIDDEN_ROW(_("Nickname"), entry_nn);
@@ -866,7 +1136,9 @@ static gboolean email_adding = FALSE, email_saving = FALSE;
 
 static void edit_person_entry_email_changed (GtkWidget *entry, gpointer data)
 {
-       gboolean non_empty = gtk_clist_get_row_data(GTK_CLIST(personeditdlg.clist_email), 0) != NULL;
+       GtkTreeModel *model = gtk_tree_view_get_model(
+                       GTK_TREE_VIEW(personeditdlg.view_email));
+       gboolean non_empty = (gtk_tree_model_iter_n_children(model, NULL) > 0);
 
        if (personeditdlg.read_only)
                return;
@@ -892,7 +1164,7 @@ static void edit_person_entry_email_changed (GtkWidget *entry, gpointer data)
 
 static gboolean edit_person_entry_email_pressed(GtkWidget *widget, GdkEventKey *event, gpointer data)
 {
-       if (event && event->keyval == GDK_Return) {
+       if (event && event->keyval == GDK_KEY_Return) {
                if (email_saving)
                        edit_person_email_modify(NULL);         
                else if (email_adding)
@@ -916,21 +1188,17 @@ static void addressbook_edit_person_page_email( gint pageNum, gchar *pageLbl ) {
 
        GtkWidget *table;
        GtkWidget *label;
-       GtkWidget *clist_swin;
-       GtkWidget *clist;
+       GtkWidget *scrollwin;
+       GtkWidget *view;
        GtkWidget *entry_email;
        GtkWidget *entry_alias;
        GtkWidget *entry_remarks;
        gint top;
+       GtkListStore *store;
+       GtkTreeViewColumn *col;
+       GtkCellRenderer *rdr;
+       GtkTreeSelection *sel;
 
-       gchar *titles[ EMAIL_N_COLS ];
-       gint i;
-
-       titles[ EMAIL_COL_EMAIL   ] = _("Email Address");
-#ifndef MAEMO
-       titles[ EMAIL_COL_ALIAS   ] = _("Alias");
-       titles[ EMAIL_COL_REMARKS ] = _("Remarks");
-#endif
        vbox = gtk_vbox_new( FALSE, 8 );
        gtk_widget_show( vbox );
        gtk_container_add( GTK_CONTAINER( personeditdlg.notebook ), vbox );
@@ -951,31 +1219,58 @@ static void addressbook_edit_person_page_email( gint pageNum, gchar *pageLbl ) {
        gtk_container_add( GTK_CONTAINER( hbox ), vboxl );
        gtk_container_set_border_width( GTK_CONTAINER(vboxl), 4 );
 
-       clist_swin = gtk_scrolled_window_new( NULL, NULL );
-       gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(clist_swin),
+       scrollwin = gtk_scrolled_window_new( NULL, NULL );
+       gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(scrollwin),
                                       GTK_POLICY_AUTOMATIC,
                                       GTK_POLICY_AUTOMATIC);
 
-       clist = gtk_clist_new_with_titles( EMAIL_N_COLS, titles );
+       store = gtk_list_store_new(EMAIL_N_COLS,
+                       G_TYPE_STRING,
+#ifndef GENERIC_UMPC
+                       G_TYPE_STRING,
+                       G_TYPE_STRING,
+#endif
+                       G_TYPE_POINTER,
+                       -1);
 
-       gtk_container_add( GTK_CONTAINER(clist_swin), clist );
-       gtk_clist_set_selection_mode( GTK_CLIST(clist), GTK_SELECTION_BROWSE );
-       gtk_clist_set_column_width( GTK_CLIST(clist), EMAIL_COL_EMAIL, EMAIL_COL_WIDTH_EMAIL );
-       gtk_clist_set_column_width( GTK_CLIST(clist), EMAIL_COL_ALIAS, EMAIL_COL_WIDTH_ALIAS );
+       view = gtk_tree_view_new_with_model(GTK_TREE_MODEL(store));
+       g_object_unref(store);
+#ifndef GENERIC_UMPC
+       gtk_tree_view_set_headers_visible(GTK_TREE_VIEW(view), TRUE);
+#else
+       gtk_tree_view_set_headers_visible(GTK_TREE_VIEW(view), FALSE);
+#endif
+       sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(view));
+       gtk_tree_selection_set_mode(sel, GTK_SELECTION_BROWSE);
+
+       rdr = gtk_cell_renderer_text_new();
+       col = gtk_tree_view_column_new_with_attributes(_("Email Address"), rdr,
+                       "markup", EMAIL_COL_EMAIL, NULL);
+       gtk_tree_view_column_set_min_width(col, EMAIL_COL_WIDTH_EMAIL);
+       gtk_tree_view_append_column(GTK_TREE_VIEW(view), col);
+
+#ifndef GENERIC_UMPC
+       col = gtk_tree_view_column_new_with_attributes(_("Alias"), rdr,
+                       "markup", EMAIL_COL_ALIAS, NULL);
+       gtk_tree_view_column_set_min_width(col, EMAIL_COL_WIDTH_ALIAS);
+       gtk_tree_view_append_column(GTK_TREE_VIEW(view), col);
+
+       col = gtk_tree_view_column_new_with_attributes(_("Remarks"), rdr,
+                       "markup", EMAIL_COL_REMARKS, NULL);
+       gtk_tree_view_append_column(GTK_TREE_VIEW(view), col);
+#endif
 
-       for( i = 0; i < EMAIL_N_COLS; i++ )
-               GTK_WIDGET_UNSET_FLAGS(GTK_CLIST(clist)->column[i].button, GTK_CAN_FOCUS);
+       gtk_container_add( GTK_CONTAINER(scrollwin), view );
 
        /* Data entry area */
        table = gtk_table_new( 4, 2, FALSE);
 
-#ifndef MAEMO
-       gtk_container_add( GTK_CONTAINER(vboxl), clist_swin );
+#ifndef GENERIC_UMPC
+       gtk_container_add( GTK_CONTAINER(vboxl), scrollwin );
        gtk_box_pack_start(GTK_BOX(vboxl), table, FALSE, FALSE, 0);
 #else
        gtk_box_pack_start(GTK_BOX(vboxl), table, FALSE, FALSE, 0);
-       gtk_container_add( GTK_CONTAINER(vboxl), clist_swin );
-       gtk_clist_column_titles_hide(GTK_CLIST(clist));
+       gtk_container_add( GTK_CONTAINER(vboxl), scrollwin );
 #endif
        gtk_container_set_border_width( GTK_CONTAINER(table), 4 );
        gtk_table_set_row_spacings(GTK_TABLE(table), 4);
@@ -993,7 +1288,7 @@ static void addressbook_edit_person_page_email( gint pageNum, gchar *pageLbl ) {
 
        gtk_table_attach(GTK_TABLE(table), entry_email, 1, 2, top, (top + 1), GTK_EXPAND|GTK_SHRINK|GTK_FILL, 0, 0, 0);
 
-#ifndef MAEMO
+#ifndef GENERIC_UMPC
        /* Next row */
        ++top;
        label = gtk_label_new(_("Alias"));
@@ -1029,7 +1324,7 @@ static void addressbook_edit_person_page_email( gint pageNum, gchar *pageLbl ) {
        buttonAdd = gtk_button_new_from_stock(GTK_STOCK_ADD);
        
 
-#ifndef MAEMO
+#ifndef GENERIC_UMPC
        gtk_container_add( GTK_CONTAINER(vbuttonbox), buttonUp );
 
        gtk_container_add( GTK_CONTAINER(vbuttonbox), buttonDown );
@@ -1043,8 +1338,8 @@ static void addressbook_edit_person_page_email( gint pageNum, gchar *pageLbl ) {
        gtk_widget_show_all(vbox);
 
        /* Event handlers */
-       g_signal_connect( G_OBJECT(clist), "select_row",
-                         G_CALLBACK( edit_person_email_list_selected), NULL );
+       g_signal_connect( G_OBJECT(view), "cursor-changed",
+                         G_CALLBACK( edit_person_email_cursor_changed ), NULL );
        g_signal_connect( G_OBJECT(buttonUp), "clicked",
                          G_CALLBACK( edit_person_email_move_up ), NULL );
        g_signal_connect( G_OBJECT(buttonDown), "clicked",
@@ -1064,7 +1359,7 @@ static void addressbook_edit_person_page_email( gint pageNum, gchar *pageLbl ) {
        g_signal_connect(G_OBJECT(entry_remarks), "key_press_event",
                         G_CALLBACK(edit_person_entry_email_pressed), NULL);
 
-       personeditdlg.clist_email   = clist;
+       personeditdlg.view_email   = view;
        personeditdlg.entry_email   = entry_email;
        personeditdlg.entry_alias   = entry_alias;
        personeditdlg.entry_remarks = entry_remarks;
@@ -1079,18 +1374,22 @@ static gboolean attrib_adding = FALSE, attrib_saving = FALSE;
 
 static void edit_person_entry_att_changed (GtkWidget *entry, gpointer data)
 {
-       gboolean non_empty = gtk_clist_get_row_data(GTK_CLIST(personeditdlg.clist_attrib), 0) != NULL;
+       GtkTreeModel *model = gtk_tree_view_get_model(
+                       GTK_TREE_VIEW(personeditdlg.view_attrib));
+       gboolean non_empty = (gtk_tree_model_iter_n_children(model, NULL) > 0);
+       const gchar *atname;
 
        if (personeditdlg.read_only || personeditdlg.ldap)
                return;
 
-       if (gtk_entry_get_text(GTK_ENTRY(personeditdlg.entry_atname)) == NULL
-       ||  strlen(gtk_entry_get_text(GTK_ENTRY(personeditdlg.entry_atname))) == 0) {
+       atname = gtk_entry_get_text(GTK_ENTRY(gtk_bin_get_child(GTK_BIN((personeditdlg.entry_atname)))));
+       if ( atname == NULL
+       ||  strlen(atname) == 0) {
                gtk_widget_set_sensitive(personeditdlg.attrib_add,FALSE);
                gtk_widget_set_sensitive(personeditdlg.attrib_mod,FALSE);
                attrib_adding = FALSE;
                attrib_saving = FALSE;
-       } else if (list_find_attribute(gtk_entry_get_text(GTK_ENTRY(personeditdlg.entry_atname)))) {
+       } else if (list_find_attribute(atname)) {
                gtk_widget_set_sensitive(personeditdlg.attrib_add,FALSE);
                gtk_widget_set_sensitive(personeditdlg.attrib_mod,non_empty);
                attrib_adding = FALSE;
@@ -1105,7 +1404,7 @@ static void edit_person_entry_att_changed (GtkWidget *entry, gpointer data)
 
 static gboolean edit_person_entry_att_pressed(GtkWidget *widget, GdkEventKey *event, gpointer data)
 {
-       if (event && event->keyval == GDK_Return) {
+       if (event && event->keyval == GDK_KEY_Return) {
                if (attrib_saving)
                        edit_person_attrib_modify(NULL);
                else if (attrib_adding)
@@ -1126,17 +1425,15 @@ static void addressbook_edit_person_page_attrib( gint pageNum, gchar *pageLbl )
 
        GtkWidget *table;
        GtkWidget *label;
-       GtkWidget *clist_swin;
-       GtkWidget *clist;
+       GtkWidget *scrollwin;
+       GtkWidget *view;
        GtkWidget *entry_name;
        GtkWidget *entry_value;
        gint top;
-
-       gchar *titles[ ATTRIB_N_COLS ];
-       gint i;
-
-       titles[ ATTRIB_COL_NAME  ] = _("Name");
-       titles[ ATTRIB_COL_VALUE ] = _("Value");
+       GtkListStore *store;
+       GtkTreeViewColumn *col;
+       GtkCellRenderer *rdr;
+       GtkTreeSelection *sel;
 
        vbox = gtk_vbox_new( FALSE, 8 );
        gtk_widget_show( vbox );
@@ -1158,32 +1455,43 @@ static void addressbook_edit_person_page_attrib( gint pageNum, gchar *pageLbl )
        gtk_container_add( GTK_CONTAINER( hbox ), vboxl );
        gtk_container_set_border_width( GTK_CONTAINER(vboxl), 4 );
 
-       clist_swin = gtk_scrolled_window_new( NULL, NULL );
-       gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(clist_swin),
+       scrollwin = gtk_scrolled_window_new( NULL, NULL );
+       gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(scrollwin),
                                       GTK_POLICY_AUTOMATIC,
                                       GTK_POLICY_AUTOMATIC);
 
-       clist = gtk_clist_new_with_titles( ATTRIB_N_COLS, titles );
-       gtk_container_add( GTK_CONTAINER(clist_swin), clist );
-       gtk_clist_set_selection_mode( GTK_CLIST(clist), GTK_SELECTION_BROWSE );
-       gtk_clist_set_compare_func( GTK_CLIST(clist), edit_person_attrib_compare_func );
-       gtk_clist_set_auto_sort( GTK_CLIST(clist), TRUE );
-       gtk_clist_set_column_width( GTK_CLIST(clist), ATTRIB_COL_NAME, ATTRIB_COL_WIDTH_NAME );
-       gtk_clist_set_column_width( GTK_CLIST(clist), ATTRIB_COL_VALUE, ATTRIB_COL_WIDTH_VALUE );
+       store = gtk_list_store_new(ATTRIB_N_COLS,
+                       G_TYPE_STRING, G_TYPE_STRING,
+                       G_TYPE_POINTER, -1);
+
+       view = gtk_tree_view_new_with_model(GTK_TREE_MODEL(store));
+       g_object_unref(store);
+       gtk_tree_view_set_headers_visible(GTK_TREE_VIEW(view), TRUE);
+       sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(view));
+       gtk_tree_selection_set_mode(sel, GTK_SELECTION_BROWSE);
 
-       for( i = 0; i < ATTRIB_N_COLS; i++ )
-               GTK_WIDGET_UNSET_FLAGS(GTK_CLIST(clist)->column[i].button, GTK_CAN_FOCUS);
+       rdr = gtk_cell_renderer_text_new();
+       col = gtk_tree_view_column_new_with_attributes(_("Name"), rdr,
+                       "markup", ATTRIB_COL_NAME, NULL);
+       gtk_tree_view_column_set_min_width(col, ATTRIB_COL_WIDTH_NAME);
+       gtk_tree_view_append_column(GTK_TREE_VIEW(view), col);
+
+       col = gtk_tree_view_column_new_with_attributes(_("Value"), rdr,
+                       "markup", ATTRIB_COL_VALUE, NULL);
+       gtk_tree_view_column_set_min_width(col, ATTRIB_COL_WIDTH_VALUE);
+       gtk_tree_view_append_column(GTK_TREE_VIEW(view), col);
+
+       gtk_container_add( GTK_CONTAINER(scrollwin), view );
 
        /* Data entry area */
-#ifndef MAEMO
+#ifndef GENERIC_UMPC
        table = gtk_table_new( 4, 2, FALSE);
-       gtk_container_add( GTK_CONTAINER(vboxl), clist_swin );
+       gtk_container_add( GTK_CONTAINER(vboxl), scrollwin );
        gtk_box_pack_start(GTK_BOX(vboxl), table, FALSE, FALSE, 0);
 #else
        table = gtk_table_new( 2, 4, FALSE);
        gtk_box_pack_start(GTK_BOX(vboxl), table, FALSE, FALSE, 0);
-       gtk_container_add( GTK_CONTAINER(vboxl), clist_swin );
-       gtk_clist_column_titles_hide(GTK_CLIST(clist));
+       gtk_container_add( GTK_CONTAINER(vboxl), scrollwin );
 #endif
        gtk_container_set_border_width( GTK_CONTAINER(table), 4 );
        gtk_table_set_row_spacings(GTK_TABLE(table), 4);
@@ -1191,12 +1499,12 @@ static void addressbook_edit_person_page_attrib( gint pageNum, gchar *pageLbl )
 
        /* First row */
        top = 0;
-#ifndef MAEMO
+#ifndef GENERIC_UMPC
        label = gtk_label_new(_("Name"));
        gtk_table_attach(GTK_TABLE(table), label, 0, 1, top, (top + 1), GTK_FILL, 0, 0, 0);
        gtk_misc_set_alignment(GTK_MISC(label), 0, 0.5);
 
-       entry_name = gtk_entry_new();
+       entry_name = gtk_combo_box_text_new_with_entry ();
        gtk_table_attach(GTK_TABLE(table), entry_name, 1, 2, top, (top + 1), GTK_EXPAND|GTK_SHRINK|GTK_FILL, 0, 0, 0);
 
        /* Next row */
@@ -1212,7 +1520,7 @@ static void addressbook_edit_person_page_attrib( gint pageNum, gchar *pageLbl )
        gtk_table_attach(GTK_TABLE(table), label, 0, 1, 0, 1, GTK_FILL, 0, 0, 0);
        gtk_misc_set_alignment(GTK_MISC(label), 0, 0.5);
 
-       entry_name = gtk_entry_new();
+       entry_name = gtk_combo_box_text_new_with_entry ();
        gtk_table_attach(GTK_TABLE(table), entry_name, 1, 2, 0, 1, GTK_EXPAND|GTK_SHRINK|GTK_FILL, 0, 0, 0);
 
        /* Next row */
@@ -1224,6 +1532,10 @@ static void addressbook_edit_person_page_attrib( gint pageNum, gchar *pageLbl )
        entry_value = gtk_entry_new();
        gtk_table_attach(GTK_TABLE(table), entry_value, 3, 4, 0, 1, GTK_EXPAND|GTK_SHRINK|GTK_FILL, 0, 0, 0);
 #endif
+       gtk_combo_box_set_active(GTK_COMBO_BOX(entry_name), -1);
+       if (prefs_common.addressbook_custom_attributes)
+               combobox_set_popdown_strings(GTK_COMBO_BOX_TEXT(entry_name),
+                               prefs_common.addressbook_custom_attributes);            
        /* Button box */
        vboxb = gtk_vbox_new( FALSE, 4 );
        gtk_box_pack_start(GTK_BOX(hbox), vboxb, FALSE, FALSE, 2);
@@ -1251,8 +1563,8 @@ static void addressbook_edit_person_page_attrib( gint pageNum, gchar *pageLbl )
        gtk_widget_show_all(vbox);
 
        /* Event handlers */
-       g_signal_connect( G_OBJECT(clist), "select_row",
-                         G_CALLBACK( edit_person_attrib_list_selected), NULL );
+       g_signal_connect( G_OBJECT(view), "cursor-changed",
+                         G_CALLBACK( edit_person_attrib_cursor_changed ), NULL );
        g_signal_connect( G_OBJECT(buttonDel), "clicked",
                          G_CALLBACK( edit_person_attrib_delete ), NULL );
        g_signal_connect( G_OBJECT(buttonMod), "clicked",
@@ -1266,7 +1578,7 @@ static void addressbook_edit_person_page_attrib( gint pageNum, gchar *pageLbl )
        g_signal_connect(G_OBJECT(entry_value), "key_press_event",
                         G_CALLBACK(edit_person_entry_att_pressed), NULL);
 
-       personeditdlg.clist_attrib  = clist;
+       personeditdlg.view_attrib  = view;
        personeditdlg.entry_atname  = entry_name;
        personeditdlg.entry_atvalue = entry_value;
        personeditdlg.attrib_add = buttonAdd;
@@ -1294,14 +1606,20 @@ static void addressbook_edit_person_create( GtkWidget *parent, gboolean *cancell
 * Return list of email items.
 */
 static GList *edit_person_build_email_list() {
-       GtkCList *clist = GTK_CLIST(personeditdlg.clist_email);
+       GtkWidget *view = personeditdlg.view_email;
+       GtkTreeModel *model = gtk_tree_view_get_model(GTK_TREE_VIEW(view));
+       GtkTreeIter iter;
        GList *listEMail = NULL;
        ItemEMail *email;
-       gint row = 0;
-       while( (email = gtk_clist_get_row_data( clist, row )) ) {
+
+       if (!gtk_tree_model_get_iter_first(model, &iter))
+               return NULL;
+
+       do {
+               gtk_tree_model_get(model, &iter, EMAIL_COL_PTR, &email, -1);
                listEMail = g_list_append( listEMail, email );
-               row++;
-       }
+       } while (gtk_tree_model_iter_next(model, &iter));
+
        return listEMail;
 }
 
@@ -1309,14 +1627,22 @@ static GList *edit_person_build_email_list() {
 * Return list of attributes.
 */
 static GList *edit_person_build_attrib_list() {
-       GtkCList *clist = GTK_CLIST(personeditdlg.clist_attrib);
+       GtkTreeModel *model = gtk_tree_view_get_model(
+                       GTK_TREE_VIEW(personeditdlg.view_attrib));
+       GtkTreeIter iter;
        GList *listAttrib = NULL;
        UserAttribute *attrib;
-       gint row = 0;
-       while( (attrib = gtk_clist_get_row_data( clist, row )) ) {
+
+       /* Iterate through all the rows, selecting the one that
+        * matches. */
+       if (!gtk_tree_model_get_iter_first(model, &iter))
+               return FALSE;
+
+       do {
+               gtk_tree_model_get(model, &iter, ATTRIB_COL_PTR, &attrib, -1);
                listAttrib = g_list_append( listAttrib, attrib );
-               row++;
-       }
+       } while (gtk_tree_model_iter_next(model, &iter));
+
        return listAttrib;
 }
 
@@ -1378,16 +1704,18 @@ static gboolean addressbook_edit_person_close( gboolean cancelled )
 {
        GList *listEMail = NULL;
        GList *listAttrib = NULL;
-       GError *error;
-       gchar *cn = NULL;
+       GError *error = NULL;
+       GtkTreeModel *model;
 
        listEMail = edit_person_build_email_list();
        listAttrib = edit_person_build_attrib_list();
        if( cancelled ) {
                addritem_free_list_email( listEMail );
                addritem_free_list_attribute( listAttrib );
-               gtk_clist_clear( GTK_CLIST(personeditdlg.clist_email) );
-               gtk_clist_clear( GTK_CLIST(personeditdlg.clist_attrib) );
+               model = gtk_tree_view_get_model(GTK_TREE_VIEW(personeditdlg.view_email));
+               gtk_list_store_clear(GTK_LIST_STORE(model));
+               model = gtk_tree_view_get_model(GTK_TREE_VIEW(personeditdlg.view_attrib));
+               gtk_list_store_clear(GTK_LIST_STORE(model));
 
                if (!prefs_common.addressbook_use_editaddress_dialog)
                        gtk_widget_hide( personeditdlg.container );
@@ -1395,23 +1723,13 @@ static gboolean addressbook_edit_person_close( gboolean cancelled )
                /* no callback, as we're discarding the form */
                edit_person_close_post_update_cb = NULL;
                addressbook_edit_person_flush_transient();
+               current_person = NULL;
 
                /* set focus to the address list (this is done by the post_update_cb usually) */
                addressbook_address_list_set_focus();
                return FALSE;
        }
 
-#ifndef MAEMO
-       cn = gtk_editable_get_chars( GTK_EDITABLE(personeditdlg.entry_name), 0, -1 );
-#else
-       {
-               gchar *first = gtk_editable_get_chars( GTK_EDITABLE(personeditdlg.entry_first), 0, -1 );
-               gchar *last = gtk_editable_get_chars( GTK_EDITABLE(personeditdlg.entry_last), 0, -1 );
-               cn = g_strdup_printf("%s%s%s", first, (first && last && *first && *last)?" ":"", last);
-               g_free(first);
-               g_free(last);
-       }
-#endif
        if( current_person && current_abf ) {
                /* Update email/attribute list for existing current_person */
                addrbook_update_address_list( current_abf, current_person, listEMail );
@@ -1419,10 +1737,6 @@ static gboolean addressbook_edit_person_close( gboolean cancelled )
        }
        else {
                /* Create new current_person and email/attribute list */
-               if( cn == NULL || *cn == '\0' ) {
-                       /* Wasting our time */
-                       if( listEMail == NULL && listAttrib == NULL ) cancelled = TRUE;
-               }
                if( ! cancelled && current_abf ) {
                        current_person = addrbook_add_address_list( current_abf, current_parent_folder, listEMail );
                        addrbook_add_attrib_list( current_abf, current_person, listAttrib );
@@ -1431,21 +1745,44 @@ static gboolean addressbook_edit_person_close( gboolean cancelled )
        listEMail = NULL;
        listAttrib = NULL;
 
-       if( ! cancelled ) {
+       if(!cancelled && current_person != NULL) {
                /* Set current_person stuff */          
 
                gchar *name;
+               gchar *cn = edit_person_get_common_name_from_widgets();
+
                addritem_person_set_common_name( current_person, cn );
-               if (personeditdlg.picture_set) {
-                       name = g_strconcat( get_rc_dir(), G_DIR_SEPARATOR_S, ADDRBOOK_DIR, G_DIR_SEPARATOR_S, 
-                                                       ADDRITEM_ID(current_person), NULL );
-                       gdk_pixbuf_save(personeditdlg.pixbuf, name, "png", &error, NULL);
-                       addritem_person_set_picture( current_person, ADDRITEM_ID(current_person) ) ;
+               g_free( cn );
+
+               if (personeditdlg.picture_set) { 
+                       GdkPixbuf * pixbuf = gtk_image_get_pixbuf(GTK_IMAGE(personeditdlg.image));
+
+                       if (!current_person->picture)
+                               name = g_strconcat( get_rc_dir(), G_DIR_SEPARATOR_S, ADDRBOOK_DIR, G_DIR_SEPARATOR_S, 
+                                               ADDRITEM_ID(current_person), ".png", NULL );
+                       else 
+                               name = g_strconcat( get_rc_dir(), G_DIR_SEPARATOR_S, ADDRBOOK_DIR, G_DIR_SEPARATOR_S, 
+                                               current_person->picture, ".png", NULL );
+
+                       gdk_pixbuf_save(pixbuf, name, "png", &error, NULL);
+                       if (error) {
+                               alertpanel_error(_("Failed to save image: \n%s"),
+                                               error->message);
+                               g_error_free(error);
+                       } else {
+                               debug_print("saved picture to %s\n", name);
+                       }
+                       if (!current_person->picture)
+                               addritem_person_set_picture( current_person, ADDRITEM_ID(current_person) ) ;
                        g_free( name );
                } else {
-                       name = g_strconcat( get_rc_dir(), G_DIR_SEPARATOR_S, ADDRBOOK_DIR, G_DIR_SEPARATOR_S, 
-                                                       ADDRITEM_ID(current_person), NULL );
-                       g_unlink(name);
+                       if (!current_person->picture)
+                               name = g_strconcat( get_rc_dir(), G_DIR_SEPARATOR_S, ADDRBOOK_DIR, G_DIR_SEPARATOR_S, 
+                                               ADDRITEM_ID(current_person), ".png", NULL );
+                       else 
+                               name = g_strconcat( get_rc_dir(), G_DIR_SEPARATOR_S, ADDRBOOK_DIR, G_DIR_SEPARATOR_S, 
+                                               current_person->picture, ".png", NULL );
+                       claws_unlink(name);
                        g_free(name);
                }
                name = gtk_editable_get_chars( GTK_EDITABLE(personeditdlg.entry_first), 0, -1 );
@@ -1458,10 +1795,11 @@ static gboolean addressbook_edit_person_close( gboolean cancelled )
                addritem_person_set_nick_name( current_person, name );
                g_free( name );
        }
-       g_free( cn );
 
-       gtk_clist_clear( GTK_CLIST(personeditdlg.clist_email) );
-       gtk_clist_clear( GTK_CLIST(personeditdlg.clist_attrib) );
+       model = gtk_tree_view_get_model(GTK_TREE_VIEW(personeditdlg.view_email));
+       gtk_list_store_clear(GTK_LIST_STORE(model));
+       model = gtk_tree_view_get_model(GTK_TREE_VIEW(personeditdlg.view_attrib));
+       gtk_list_store_clear(GTK_LIST_STORE(model));
 
        if (!prefs_common.addressbook_use_editaddress_dialog)
                gtk_widget_hide( personeditdlg.container );
@@ -1485,6 +1823,10 @@ ItemPerson *addressbook_edit_person( AddressBookFile *abf, ItemFolder *parent_fo
                                                                         gboolean get_focus) {
        static gboolean cancelled;
        GError *error = NULL;
+       GdkPixbuf *pixbuf = NULL;
+       GtkTreeModel *model;
+       GtkTreeSelection *sel;
+       GtkTreeIter iter;
 
        /* set transient data */
        current_abf = abf;
@@ -1492,8 +1834,12 @@ ItemPerson *addressbook_edit_person( AddressBookFile *abf, ItemFolder *parent_fo
        current_parent_folder = parent_folder;
        edit_person_close_post_update_cb = post_update_cb;
        personeditdlg.ldap = (abf && abf->type == ADBOOKTYPE_LDAP)? TRUE : FALSE;
-       if( !personeditdlg.container )
-               addressbook_edit_person_create(parent_container, &cancelled);
+
+       if( personeditdlg.container ) {
+               gtk_widget_destroy(personeditdlg.container);
+               personeditdlg.container = NULL;
+       }
+       addressbook_edit_person_create(parent_container, &cancelled);
 
        /* typically, get focus when dialog mode is enabled, or when editing a new address */
        if( get_focus ) {
@@ -1512,11 +1858,13 @@ ItemPerson *addressbook_edit_person( AddressBookFile *abf, ItemFolder *parent_fo
                        addressbook_address_list_disable_some_actions();
 
        /* Clear all fields */
-       personeditdlg.rowIndEMail = -1;
-       personeditdlg.rowIndAttrib = -1;
        edit_person_status_show( "" );
-       gtk_clist_clear( GTK_CLIST(personeditdlg.clist_email) );
-       gtk_clist_clear( GTK_CLIST(personeditdlg.clist_attrib) );
+
+       model = gtk_tree_view_get_model(GTK_TREE_VIEW(personeditdlg.view_email));
+       gtk_list_store_clear(GTK_LIST_STORE(model));
+       model = gtk_tree_view_get_model(GTK_TREE_VIEW(personeditdlg.view_attrib));
+       gtk_list_store_clear(GTK_LIST_STORE(model));
+
        gtk_entry_set_text(GTK_ENTRY(personeditdlg.entry_name), "" );
        gtk_entry_set_text(GTK_ENTRY(personeditdlg.entry_first), "" );
        gtk_entry_set_text(GTK_ENTRY(personeditdlg.entry_last), "" );
@@ -1524,32 +1872,40 @@ ItemPerson *addressbook_edit_person( AddressBookFile *abf, ItemFolder *parent_fo
 
        personeditdlg.editNew = FALSE;
        if( current_person ) {
+               gchar *filename = NULL;
+
                if( ADDRITEM_NAME(current_person) )
                        gtk_entry_set_text(GTK_ENTRY(personeditdlg.entry_name), ADDRITEM_NAME(person) );
 
+               cm_menu_set_sensitive("EditAddressPopup/SetPicture", !personeditdlg.ldap);
+               cm_menu_set_sensitive("EditAddressPopup/UnsetPicture", !personeditdlg.ldap);
                if( current_person->picture ) { 
-                       gchar *filename = g_strconcat( get_rc_dir(), G_DIR_SEPARATOR_S, ADDRBOOK_DIR, G_DIR_SEPARATOR_S, 
-                                                       current_person->picture, NULL );
+                       filename = g_strconcat( get_rc_dir(), G_DIR_SEPARATOR_S, ADDRBOOK_DIR, G_DIR_SEPARATOR_S, 
+                                                       current_person->picture, ".png", NULL );
                        if (is_file_exist(filename)) {
-                               personeditdlg.pixbuf = gdk_pixbuf_new_from_file(filename, &error);
+                               pixbuf = gdk_pixbuf_new_from_file(filename, &error);
                                if (error) {
-                                       debug_print("Failed to import image: \n%s",
+                                       debug_print("Failed to import image: %s\n",
                                                        error->message);
                                        g_error_free(error);
                                        goto no_img;
                                }
                                personeditdlg.picture_set = TRUE;
+                               cm_menu_set_sensitive("EditAddressPopup/UnsetPicture", !personeditdlg.ldap && personeditdlg.picture_set);
                        } else {
                                goto no_img;
                        }
-                       g_free(filename);
+                       gtk_image_set_from_pixbuf(GTK_IMAGE(personeditdlg.image), pixbuf);
                } else {
 no_img:
-                       personeditdlg.picture_set = FALSE;
-                       personeditdlg.pixbuf = gdk_pixbuf_new(GDK_COLORSPACE_RGB, TRUE, 8, 48, 48);
-                       gdk_pixbuf_fill(personeditdlg.pixbuf, 0xffffff00);
+                       addressbook_edit_person_clear_picture();
+               }
+               
+               g_free(filename);
+               if (pixbuf) {
+                       g_object_unref(pixbuf);
+                       pixbuf = NULL;
                }
-               gtk_image_set_from_pixbuf(GTK_IMAGE(personeditdlg.image), personeditdlg.pixbuf);
 
                if( current_person->firstName )
                        gtk_entry_set_text(GTK_ENTRY(personeditdlg.entry_first), current_person->firstName );
@@ -1573,24 +1929,44 @@ no_img:
                gtk_notebook_set_current_page( GTK_NOTEBOOK(personeditdlg.notebook), PAGE_BASIC );
        }
 
-       gtk_clist_select_row( GTK_CLIST(personeditdlg.clist_email), 0, 0 );
-       gtk_clist_select_row( GTK_CLIST(personeditdlg.clist_attrib), 0, 0 );
-       edit_person_email_clear( NULL );
-       if (current_person)
-               edit_person_email_list_selected(GTK_CLIST(personeditdlg.clist_email), 0, 0, NULL, NULL);
+       sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(personeditdlg.view_email));
+       model = gtk_tree_view_get_model(GTK_TREE_VIEW(personeditdlg.view_email));
+       if (gtk_tree_model_get_iter_first(model, &iter)) {
+               gtk_tree_selection_select_iter(sel, &iter);
+               edit_person_email_cursor_changed(
+                               GTK_TREE_VIEW(personeditdlg.view_email), NULL);
+       }
 
+       sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(personeditdlg.view_attrib));
+       model = gtk_tree_view_get_model(GTK_TREE_VIEW(personeditdlg.view_attrib));
+       if (gtk_tree_model_get_iter_first(model, &iter))
+               gtk_tree_selection_select_iter(sel, &iter);
+       edit_person_attrib_cursor_changed(
+                       GTK_TREE_VIEW(personeditdlg.view_attrib), NULL);
+
+       edit_person_email_clear( NULL );
        edit_person_attrib_clear( NULL );
 
        if (prefs_common.addressbook_use_editaddress_dialog) {
-
-       gtk_main();
+               gtk_main();
                gtk_widget_hide( personeditdlg.container );
 
-               if (!addressbook_edit_person_close( cancelled ))
+               if (!addressbook_edit_person_close( cancelled )) {
                        return NULL;
+               }
        }
+       
+       return person;
+}
 
-       return current_person;
+void addressbook_edit_reload_attr_list( void )
+{
+       if (personeditdlg.entry_atname) {
+               combobox_unset_popdown_strings(GTK_COMBO_BOX_TEXT(personeditdlg.entry_atname));
+               if (prefs_common.addressbook_custom_attributes)
+                       combobox_set_popdown_strings(GTK_COMBO_BOX_TEXT(personeditdlg.entry_atname),
+                                       prefs_common.addressbook_custom_attributes);
+       }
 }
 
 /*