2006-08-16 [colin] 2.4.0cvs54
[claws.git] / src / compose.c
index 2d79c6174e05cea7173952d2ac9cb7ce7a36abf1..b584fc2ae7cec3c3ebb27a77384b86b6ca577108 100644 (file)
 #include "toolbar.h"
 #include "inc.h"
 #include "message_search.h"
+#include "combobox.h"
 
 enum
 {
@@ -324,7 +325,9 @@ static void compose_undo_state_changed              (UndoMain       *undostruct,
 static void compose_create_header_entry        (Compose *compose);
 static void compose_add_header_entry   (Compose *compose, gchar *header, gchar *text);
 static void compose_update_priority_menu_item(Compose * compose);
-
+#if USE_ASPELL
+static void compose_spell_menu_changed (void *data);
+#endif
 static void compose_add_field_list     ( Compose *compose,
                                          GList *listAddress );
 
@@ -333,7 +336,7 @@ static void compose_add_field_list  ( Compose *compose,
 static gboolean compose_edit_size_alloc (GtkEditable   *widget,
                                         GtkAllocation  *allocation,
                                         GtkSHRuler     *shruler);
-static void account_activated          (GtkMenuItem    *menuitem,
+static void account_activated          (GtkComboBox *optmenu,
                                         gpointer        data);
 static void attach_selected            (GtkTreeView    *tree_view, 
                                         GtkTreePath    *tree_path,
@@ -762,8 +765,8 @@ static GtkItemFactoryEntry compose_entries[] =
 static GtkTargetEntry compose_mime_types[] =
 {
        {"text/uri-list", 0, 0},
-       {"text/plain", 0, 0},
-       {"STRING", 0, 0}
+       {"UTF8_STRING", 0, 0},
+       {"text/plain", 0, 0}
 };
 
 static gboolean compose_put_existing_to_front(MsgInfo *info)
@@ -957,6 +960,7 @@ Compose *compose_generic_new(PrefsAccount *account, const gchar *mailto, FolderI
            compose->gtkaspell) 
                gtkaspell_change_dict(compose->gtkaspell, 
                    item->prefs->default_dictionary);
+       compose_spell_menu_changed(compose);
 #endif
 
        if (account->auto_sig)
@@ -1312,6 +1316,7 @@ static Compose *compose_generic_reply(MsgInfo *msginfo, gboolean quote,
                compose_quote_fmt(compose, compose->replyinfo,
                                  prefs_common.quotefmt,
                                  qmark, body, FALSE);
+               quote_fmt_reset_vartable();
        }
        if (procmime_msginfo_is_encrypted(compose->replyinfo)) {
                compose_force_encryption(compose, account, FALSE);
@@ -1427,6 +1432,7 @@ Compose *compose_forward(PrefsAccount *account, MsgInfo *msginfo,
                compose_quote_fmt(compose, full_msginfo,
                                  prefs_common.fw_quotefmt,
                                  qmark, body, FALSE);
+               quote_fmt_reset_vartable();
                compose_attach_parts(compose, msginfo);
 
                procmsg_msginfo_free(full_msginfo);
@@ -1635,6 +1641,7 @@ Compose *compose_reedit(MsgInfo *msginfo, gboolean batch)
        gboolean use_signing = FALSE;
        gboolean use_encryption = FALSE;
        gchar *privacy_system = NULL;
+       int priority = PRIORITY_NORMAL;
 
        g_return_val_if_fail(msginfo != NULL, NULL);
        g_return_val_if_fail(msginfo->folder != NULL, NULL);
@@ -1686,7 +1693,7 @@ Compose *compose_reedit(MsgInfo *msginfo, gboolean batch)
                if (!procheader_get_header_from_msginfo(msginfo, queueheader_buf, 
                                             sizeof(queueheader_buf), "X-Priority: ")) {
                        param = atoi(&queueheader_buf[strlen("X-Priority: ")]); /* mind the space */
-                       compose->priority = param;
+                       priority = param;
                }
        } else {
                account = msginfo->folder->folder->account;
@@ -1707,7 +1714,8 @@ Compose *compose_reedit(MsgInfo *msginfo, gboolean batch)
        compose = compose_create(account, COMPOSE_REEDIT, batch);
        
        compose->updating = TRUE;
-       
+       compose->priority = priority;
+
        if (privacy_system != NULL) {
                compose->privacy_system = privacy_system;
                compose_use_signing(compose, use_signing);
@@ -1808,6 +1816,9 @@ Compose *compose_reedit(MsgInfo *msginfo, gboolean batch)
                compose_destroy(compose);
                return NULL;
        }
+       
+       compose->sig_str = compose_get_signature_str(compose);
+       
        return compose;
 }
 
@@ -1869,6 +1880,7 @@ Compose *compose_redirect(PrefsAccount *account, MsgInfo *msginfo,
        gtk_editable_set_editable(GTK_EDITABLE(compose->subject_entry), FALSE);
 
        compose_quote_fmt(compose, msginfo, "%M", NULL, NULL, FALSE);
+       quote_fmt_reset_vartable();
        gtk_text_view_set_editable(GTK_TEXT_VIEW(compose->text), FALSE);
 
        compose_colorize_signature(compose);
@@ -2073,7 +2085,7 @@ static void compose_entries_set(Compose *compose, const gchar *mailto)
        gchar *subject = NULL;
        gchar *body = NULL;
        gchar *temp = NULL;
-       gint  len = 0;
+       guint  len = 0;
 
        scan_mailto_url(mailto, &to, &cc, NULL, &subject, &body);
 
@@ -2569,7 +2581,7 @@ static void compose_reply_set_entry(Compose *compose, MsgInfo *msginfo,
 
        if (msginfo->subject && *msginfo->subject) {
                gchar *buf, *buf2;
-               guchar *p;
+               gchar *p;
 
                buf = p = g_strdup(msginfo->subject);
                p += subject_get_prefix_length(p);
@@ -2679,7 +2691,9 @@ static void compose_insert_sig(Compose *compose, gboolean replace)
        GtkTextMark *mark;
        GtkTextIter iter, iter_end;
        gint cur_pos;
+       gchar *search = NULL;
        gboolean prev_autowrap;
+       gboolean found = FALSE, shift = FALSE;
 
        
        g_return_if_fail(compose->account != NULL);
@@ -2697,8 +2711,9 @@ static void compose_insert_sig(Compose *compose, gboolean replace)
 
        gtk_text_buffer_get_end_iter(buffer, &iter);
 
-       if (replace && compose->sig_str) {
-               gboolean found;
+       search = compose->sig_str;
+again:
+       if (replace && search) {
                GtkTextIter first_iter, start_iter, end_iter;
 
                gtk_text_buffer_get_start_iter(buffer, &first_iter);
@@ -2707,7 +2722,7 @@ static void compose_insert_sig(Compose *compose, gboolean replace)
                        found = FALSE;
                else
                        found = gtk_text_iter_forward_search(&first_iter,
-                                                            compose->sig_str,
+                                                            search,
                                                             GTK_TEXT_SEARCH_TEXT_ONLY,
                                                             &start_iter, &end_iter,
                                                             NULL);
@@ -2716,6 +2731,12 @@ static void compose_insert_sig(Compose *compose, gboolean replace)
                        gtk_text_buffer_delete(buffer, &start_iter, &end_iter);
                        iter = start_iter;
                }
+       } 
+       if (replace && !found && search && strlen(search) > 2
+       &&  search[0] == '\n' && search[1] == '\n') {
+               search ++;
+               shift = TRUE;
+               goto again;
        }
 
        g_free(compose->sig_str);
@@ -2724,7 +2745,10 @@ static void compose_insert_sig(Compose *compose, gboolean replace)
                compose->sig_str = g_strdup("");
 
        cur_pos = gtk_text_iter_get_offset(&iter);
-       gtk_text_buffer_insert(buffer, &iter, compose->sig_str, -1);
+       if (shift && found)
+               gtk_text_buffer_insert(buffer, &iter, compose->sig_str + 1, -1);
+       else
+               gtk_text_buffer_insert(buffer, &iter, compose->sig_str, -1);
        /* skip \n\n */
        gtk_text_buffer_get_iter_at_offset(buffer, &iter, cur_pos);
        gtk_text_iter_forward_char(&iter);
@@ -3501,6 +3525,7 @@ static void compose_beautify_paragraph(Compose *compose, GtkTextIter *par_iter,
                        {"http://",  strcasestr, get_uri_part,   make_uri_string},
                        {"https://", strcasestr, get_uri_part,   make_uri_string},
                        {"ftp://",   strcasestr, get_uri_part,   make_uri_string},
+                       {"sftp://",  strcasestr, get_uri_part,   make_uri_string},
                        {"www.",     strcasestr, get_uri_part,   make_http_string},
                        {"mailto:",  strcasestr, get_uri_part,   make_uri_string},
                        {"@",        strcasestr, get_email_part, make_email_string}
@@ -3877,8 +3902,11 @@ static void compose_select_account(Compose *compose, PrefsAccount *account,
                                       
        activate_privacy_system(compose, account, FALSE);
 
-       if (!init && compose->mode != COMPOSE_REDIRECT)
+       if (!init && compose->mode != COMPOSE_REDIRECT) {
+               undo_block(compose->undostruct);
                compose_insert_sig(compose, TRUE);
+               undo_unblock(compose->undostruct);
+       }
 }
 
 gboolean compose_check_for_valid_recipient(Compose *compose) {
@@ -4031,6 +4059,8 @@ gint compose_send(Compose *compose)
        gchar *msgpath = NULL;
        gboolean discard_window = FALSE;
        gchar *errstr = NULL;
+       MainWindow *mainwin = mainwindow_get_mainwindow();
+
        if (prefs_common.send_dialog_mode != SEND_DIALOG_ALWAYS
                        || compose->batch == TRUE)
                discard_window = TRUE;
@@ -4055,6 +4085,7 @@ gint compose_send(Compose *compose)
                        alertpanel_error(_("Could not queue message for sending:\n\n"
                                           "Charset conversion failed."));
                } else if (val == -3) {
+                       if (privacy_peek_error())
                        alertpanel_error(_("Could not queue message for sending:\n\n"
                                           "Signature failed: %s"), privacy_get_error());
                } else if (val == -2 && errno != 0) {
@@ -4124,12 +4155,16 @@ gint compose_send(Compose *compose)
                return -1;
        }
 
+       toolbar_main_set_sensitive(mainwin);
+       main_window_set_menu_sensitive(mainwin);
        return 0;
 
 bail:
        compose_allow_user_actions (compose, TRUE);
        compose->sending = FALSE;
        compose->modified = TRUE; 
+       toolbar_main_set_sensitive(mainwin);
+       main_window_set_menu_sensitive(mainwin);
 
        return -1;
 }
@@ -4470,12 +4505,16 @@ static gint compose_write_to_file(Compose *compose, FILE *fp, gint action, gbool
        mimetext->subtype = g_strdup("plain");
        g_hash_table_insert(mimetext->typeparameters, g_strdup("charset"),
                            g_strdup(out_codeset));
+                           
        /* protect trailing spaces when signing message */
        if (action == COMPOSE_WRITE_FOR_SEND && compose->use_signing && 
            privacy_system_can_sign(compose->privacy_system)) {
                encoding = ENC_QUOTED_PRINTABLE;
        }
        
+       debug_print("main text: %d bytes encoded as %s in %d\n",
+               strlen(buf), out_codeset, encoding);
+
        /* check for line length limit */
        if (action == COMPOSE_WRITE_FOR_SEND &&
            encoding != ENC_QUOTED_PRINTABLE && encoding != ENC_BASE64 &&
@@ -5014,10 +5053,8 @@ static gchar *compose_get_header(Compose *compose)
        header = g_string_sized_new(64);
 
        /* Date */
-       if (compose->account->add_date) {
-               get_rfc822_date(buf, sizeof(buf));
-               g_string_append_printf(header, "Date: %s\n", buf);
-       }
+       get_rfc822_date(buf, sizeof(buf));
+       g_string_append_printf(header, "Date: %s\n", buf);
 
        /* From */
        
@@ -6148,7 +6185,9 @@ static GtkWidget *compose_account_option_menu_create(Compose *compose)
        GList *accounts;
        GtkWidget *hbox;
        GtkWidget *optmenu;
-       GtkWidget *menu;
+       GtkWidget *optmenubox;
+       GtkListStore *menu;
+       GtkTreeIter iter;
        GtkWidget *from_name = NULL;
 
        gint num = 0, def_menu = 0;
@@ -6156,8 +6195,9 @@ static GtkWidget *compose_account_option_menu_create(Compose *compose)
        accounts = account_get_list();
        g_return_val_if_fail(accounts != NULL, NULL);
 
-       optmenu = gtk_option_menu_new();
-       menu = gtk_menu_new();
+       optmenubox = gtk_event_box_new();
+       optmenu = gtkut_sc_combobox_create(optmenubox, FALSE);
+       menu = GTK_LIST_STORE(gtk_combo_box_get_model(GTK_COMBO_BOX(optmenu)));
 
        hbox = gtk_hbox_new(FALSE, 6);
        from_name = gtk_entry_new();
@@ -6167,12 +6207,11 @@ static GtkWidget *compose_account_option_menu_create(Compose *compose)
 
        for (; accounts != NULL; accounts = accounts->next, num++) {
                PrefsAccount *ac = (PrefsAccount *)accounts->data;
-               GtkWidget *menuitem;
                gchar *name, *from = NULL;
 
                if (ac == compose->account) def_menu = num;
 
-               name = g_markup_printf_escaped("From: <i>%s</i>",
+               name = g_markup_printf_escaped(_("From: <i>%s</i>"),
                                       ac->account_name);
                
                if (ac == compose->account) {
@@ -6188,24 +6227,21 @@ static GtkWidget *compose_account_option_menu_create(Compose *compose)
                                gtk_entry_set_text(GTK_ENTRY(from_name), from);
                        }
                }
-               MENUITEM_ADD(menu, menuitem, name, ac->account_id);
-               gtk_label_set_use_markup (
-                               GTK_LABEL (gtk_bin_get_child (GTK_BIN (menuitem))),
-                               TRUE);
+               COMBOBOX_ADD(menu, name, ac->account_id);
                g_free(name);
                g_free(from);
-               g_signal_connect(G_OBJECT(menuitem), "activate",
-                                G_CALLBACK(account_activated),
-                                compose);
        }
 
-       gtk_option_menu_set_menu(GTK_OPTION_MENU(optmenu), menu);
-       gtk_option_menu_set_history(GTK_OPTION_MENU(optmenu), def_menu);
+       gtk_combo_box_set_active(GTK_COMBO_BOX(optmenu), def_menu);
 
-       gtk_box_pack_start(GTK_BOX(hbox), optmenu, FALSE, FALSE, 0);
+       g_signal_connect(G_OBJECT(optmenu), "changed",
+                       G_CALLBACK(account_activated),
+                       compose);
+
+       gtk_box_pack_start(GTK_BOX(hbox), optmenubox, FALSE, FALSE, 0);
        gtk_box_pack_start(GTK_BOX(hbox), from_name, TRUE, TRUE, 0);
        
-       gtk_tooltips_set_tip(compose->tooltips, optmenu,
+       gtk_tooltips_set_tip(compose->tooltips, optmenubox,
                _("Account to use for this email"), NULL);
        gtk_tooltips_set_tip(compose->tooltips, from_name,
                _("Sender address to be used"), NULL);
@@ -6547,7 +6583,7 @@ static void compose_template_apply(Compose *compose, Template *tmpl,
 
        /* process the other fields */
        compose_template_apply_fields(compose, tmpl);
-       
+       quote_fmt_reset_vartable();
        compose_changed_cb(NULL, compose);
 }
 
@@ -6755,7 +6791,7 @@ static void compose_attach_property(Compose *compose)
 {
        GtkTreeView *tree_view = GTK_TREE_VIEW(compose->attach_clist);
        AttachInfo *ainfo;
-       GtkOptionMenu *optmenu;
+       GtkComboBox *optmenu;
        GtkTreeSelection *selection;
        GList *sel;
        GtkTreeModel *model;
@@ -6789,13 +6825,11 @@ static void compose_attach_property(Compose *compose)
        gtk_widget_show(attach_prop.window);
        manage_window_set_transient(GTK_WINDOW(attach_prop.window));
 
-       optmenu = GTK_OPTION_MENU(attach_prop.encoding_optmenu);
+       optmenu = GTK_COMBO_BOX(attach_prop.encoding_optmenu);
        if (ainfo->encoding == ENC_UNKNOWN)
-               menu_select_by_data(GTK_MENU(gtk_option_menu_get_menu(optmenu)),
-                                   GINT_TO_POINTER(ENC_BASE64));
+               combobox_select_by_data(optmenu, ENC_BASE64);
        else
-               menu_select_by_data(GTK_MENU(gtk_option_menu_get_menu(optmenu)),
-                                   GINT_TO_POINTER(ainfo->encoding));
+               combobox_select_by_data(optmenu, ainfo->encoding);
 
        gtk_entry_set_text(GTK_ENTRY(attach_prop.mimetype_entry),
                           ainfo->content_type ? ainfo->content_type : "");
@@ -6810,8 +6844,6 @@ static void compose_attach_property(Compose *compose)
                gchar *cnttype = NULL;
                gchar *file = NULL;
                off_t size = 0;
-               GtkWidget *menu;
-               GtkWidget *menuitem;
 
                cancelled = FALSE;
                gtk_main();
@@ -6836,10 +6868,7 @@ static void compose_attach_property(Compose *compose)
                        }
                }
 
-               menu = gtk_option_menu_get_menu(optmenu);
-               menuitem = gtk_menu_get_active(GTK_MENU(menu));
-               ainfo->encoding = GPOINTER_TO_INT
-                       (g_object_get_data(G_OBJECT(menuitem), MENU_VAL_ID));
+               ainfo->encoding = combobox_get_active_data(optmenu);
 
                entry_text = gtk_entry_get_text(GTK_ENTRY(attach_prop.path_entry));
                if (*entry_text != '\0') {
@@ -6907,14 +6936,14 @@ static void compose_attach_property_create(gboolean *cancelled)
        GtkWidget *mimetype_entry;
        GtkWidget *hbox;
        GtkWidget *optmenu;
-       GtkWidget *optmenu_menu;
-       GtkWidget *menuitem;
+       GtkListStore *optmenu_menu;
        GtkWidget *path_entry;
        GtkWidget *filename_entry;
        GtkWidget *hbbox;
        GtkWidget *ok_btn;
        GtkWidget *cancel_btn;
        GList     *mime_type_list, *strlist;
+       GtkTreeIter iter;
 
        debug_print("Creating attach_property window...\n");
 
@@ -6981,21 +7010,16 @@ static void compose_attach_property_create(gboolean *cancelled)
        gtk_table_attach(GTK_TABLE(table), hbox, 1, 2, 1, 2,
                         GTK_EXPAND|GTK_SHRINK|GTK_FILL, 0, 0, 0);
 
-       optmenu = gtk_option_menu_new();
-       gtk_box_pack_start(GTK_BOX(hbox), optmenu, TRUE, TRUE, 0);
-
-       optmenu_menu = gtk_menu_new();
-       MENUITEM_ADD(optmenu_menu, menuitem, "7bit", ENC_7BIT);
-       gtk_option_menu_set_menu(GTK_OPTION_MENU(optmenu), optmenu_menu);
-       MENUITEM_ADD(optmenu_menu, menuitem, "8bit", ENC_8BIT);
-       gtk_option_menu_set_menu(GTK_OPTION_MENU(optmenu), optmenu_menu);
-       MENUITEM_ADD(optmenu_menu, menuitem, "quoted-printable",
-                    ENC_QUOTED_PRINTABLE);
-       gtk_option_menu_set_menu(GTK_OPTION_MENU(optmenu), optmenu_menu);
+       optmenu = gtkut_sc_combobox_create(NULL, TRUE);
+       optmenu_menu = GTK_LIST_STORE(gtk_combo_box_get_model(GTK_COMBO_BOX(optmenu)));
 
-       MENUITEM_ADD(optmenu_menu, menuitem, "base64", ENC_BASE64);
+       COMBOBOX_ADD(optmenu_menu, "7bit", ENC_7BIT);
+       COMBOBOX_ADD(optmenu_menu, "8bit", ENC_8BIT);
+       COMBOBOX_ADD(optmenu_menu, "quoted-printable",  ENC_QUOTED_PRINTABLE);
+       COMBOBOX_ADD(optmenu_menu, "base64", ENC_BASE64);
+       gtk_combo_box_set_active(GTK_COMBO_BOX(optmenu), 0);
 
-       gtk_option_menu_set_menu(GTK_OPTION_MENU(optmenu), optmenu_menu);
+       gtk_box_pack_start(GTK_BOX(hbox), optmenu, TRUE, TRUE, 0);
 
        SET_LABEL_AND_ENTRY(_("Path"),      path_entry,     2);
        SET_LABEL_AND_ENTRY(_("File name"), filename_entry, 3);
@@ -7391,15 +7415,22 @@ static gboolean compose_edit_size_alloc(GtkEditable *widget,
        return TRUE;
 }
 
-static void account_activated(GtkMenuItem *menuitem, gpointer data)
+static void account_activated(GtkComboBox *optmenu, gpointer data)
 {
        Compose *compose = (Compose *)data;
 
        PrefsAccount *ac;
        gchar *folderidentifier;
+       gint account_id = 0;
+       GtkTreeModel *menu;
+       GtkTreeIter iter;
 
-       ac = account_find_from_id(
-               GPOINTER_TO_INT(g_object_get_data(G_OBJECT(menuitem), MENU_VAL_ID)));
+       /* Get ID of active account in the combo box */
+       menu = gtk_combo_box_get_model(optmenu);
+       gtk_combo_box_get_active_iter(optmenu, &iter);
+       gtk_tree_model_get(menu, &iter, 1, &account_id, -1);
+
+       ac = account_find_from_id(account_id);
        g_return_if_fail(ac != NULL);
 
        if (ac != compose->account)
@@ -7516,19 +7547,21 @@ static void compose_send_later_cb(gpointer data, guint action,
        gint val;
 
        val = compose_queue_sub(compose, NULL, NULL, NULL, TRUE, TRUE);
-       if (!val) 
+       if (!val) {
                compose_close(compose);
-       else if (val == -1) {
+       else if (val == -1) {
                alertpanel_error(_("Could not queue message."));
        } else if (val == -2) {
                alertpanel_error(_("Could not queue message:\n\n%s."), strerror(errno));
        } else if (val == -3) {
+               if (privacy_peek_error())
                alertpanel_error(_("Could not queue message for sending:\n\n"
                                   "Signature failed: %s"), privacy_get_error());
        } else if (val == -4) {
                alertpanel_error(_("Could not queue message for sending:\n\n"
                                   "Charset conversion failed."));
        }
+       toolbar_main_set_sensitive(mainwindow_get_mainwindow());
 }
 
 void compose_draft (gpointer data) 
@@ -7597,6 +7630,23 @@ static void compose_draft_cb(gpointer data, guint action, GtkWidget *widget)
                fprintf(fp, "X-Sylpheed-Privacy-System:%s\n", compose->privacy_system);
        }
 
+       /* Message-ID of message replying to */
+       if ((compose->replyinfo != NULL) && (compose->replyinfo->msgid != NULL)) {
+               gchar *folderid;
+               
+               folderid = folder_item_get_identifier(compose->replyinfo->folder);
+               fprintf(fp, "RMID:%s\t%d\t%s\n", folderid, compose->replyinfo->msgnum, compose->replyinfo->msgid);
+               g_free(folderid);
+       }
+       /* Message-ID of message forwarding to */
+       if ((compose->fwdinfo != NULL) && (compose->fwdinfo->msgid != NULL)) {
+               gchar *folderid;
+               
+               folderid = folder_item_get_identifier(compose->fwdinfo->folder);
+               fprintf(fp, "FMID:%s\t%d\t%s\n", folderid, compose->fwdinfo->msgnum, compose->fwdinfo->msgid);
+               g_free(folderid);
+       }
+
        /* end of headers */
        fprintf(fp, "X-Sylpheed-End-Special-Headers: 1\n");
 
@@ -7623,7 +7673,6 @@ static void compose_draft_cb(gpointer data, guint action, GtkWidget *widget)
                goto unlock;
        }
        g_free(tmp);
-       draft->mtime = 0;       /* force updating */
 
        if (compose->mode == COMPOSE_REEDIT) {
                compose_remove_reedit_target(compose, TRUE);
@@ -7894,16 +7943,18 @@ static void entry_paste_clipboard(Compose *compose, GtkWidget *entry,
                GtkTextMark *mark_start = gtk_text_buffer_get_insert(buffer);
                GtkTextIter start_iter, end_iter;
                gint start, end;
-               
                gchar *contents = gtk_clipboard_wait_for_text(gtk_clipboard_get(clip));
 
                if (contents == NULL)
                        return;
 
+               undo_paste_clipboard(GTK_TEXT_VIEW(compose->text), compose->undostruct);
+
                /* we shouldn't delete the selection when middle-click-pasting, or we
                 * can't mid-click-paste our own selection */
-               if (clip != GDK_SELECTION_PRIMARY)
+               if (clip != GDK_SELECTION_PRIMARY) {
                        gtk_text_buffer_delete_selection(buffer, FALSE, TRUE);
+               }
                
                if (insert_place == NULL) {
                        /* if insert_place isn't specified, insert at the cursor.
@@ -7931,7 +7982,6 @@ static void entry_paste_clipboard(Compose *compose, GtkWidget *entry,
                        gtk_text_iter_backward_char(&start_iter);
                        compose_beautify_paragraph(compose, &start_iter, TRUE);
                }
-               
        } else if (GTK_IS_EDITABLE(entry))
                gtk_editable_paste_clipboard (GTK_EDITABLE(entry));
        
@@ -8513,6 +8563,43 @@ static void compose_insert_drag_received_cb (GtkWidget           *widget,
        /* strangely, testing data->type == gdk_atom_intern("text/uri-list", TRUE)
         * does not work */
        if (gdk_atom_name(data->type) && !strcmp(gdk_atom_name(data->type), "text/uri-list")) {
+               AlertValue val = G_ALERTDEFAULT;
+
+               switch (prefs_common.compose_dnd_mode) {
+                       case COMPOSE_DND_ASK:
+                               val = alertpanel_full(_("Insert or attach?"),
+                                        _("Do you want to insert the contents of the file(s) "
+                                          "into the message body, or attach it to the email?"),
+                                         GTK_STOCK_CANCEL, _("+_Insert"), _("_Attach"),
+                                         TRUE, NULL, ALERT_QUESTION, G_ALERTALTERNATE);
+                               break;
+                       case COMPOSE_DND_INSERT:
+                               val = G_ALERTALTERNATE;
+                               break;
+                       case COMPOSE_DND_ATTACH:
+                               val = G_ALERTOTHER;
+                               break;
+                       default:
+                               /* unexpected case */
+                               g_warning("error: unexpected compose_dnd_mode option value in compose_insert_drag_received_cb()");
+               }
+
+               if (val & G_ALERTDISABLE) {
+                       val &= ~G_ALERTDISABLE;
+                       /* remember what action to perform by default, only if we don't click Cancel */
+                       if (val == G_ALERTALTERNATE)
+                               prefs_common.compose_dnd_mode = COMPOSE_DND_INSERT;
+                       else if (val == G_ALERTOTHER)
+                                       prefs_common.compose_dnd_mode = COMPOSE_DND_ATTACH;
+               }
+
+               if (val == G_ALERTDEFAULT || val == G_ALERTCANCEL) {
+                       gtk_drag_finish(drag_context, FALSE, FALSE, time);
+                       return;
+               } else if (val == G_ALERTOTHER) {
+                       compose_attach_drag_received_cb(widget, drag_context, x, y, data, info, time, user_data);
+                       return;
+               } 
                list = uri_list_extract_filenames((const gchar *)data->data);
                for (tmp = list; tmp != NULL; tmp = tmp->next) {
                        compose_insert_file(compose, (const gchar *)tmp->data);
@@ -8682,6 +8769,7 @@ static void text_inserted(GtkTextBuffer *buffer, GtkTextIter *iter,
                gtk_text_buffer_place_cursor(buffer, iter);
 
                compose_quote_fmt(compose, NULL, "%Q", qmark, new_text, TRUE);
+               quote_fmt_reset_vartable();
                g_free(new_text);
                g_object_set_data(G_OBJECT(compose->text), "paste_as_quotation",
                                  GINT_TO_POINTER(paste_as_quotation - 1));