Make double-click open edit dialog also for addressbook datasources.
[claws.git] / src / addressbook.c
index e424e694a44b0e5243eabc64f918a4bd26c15826..80599f8dce13563f4950430f812ca0812bb857af 100644 (file)
@@ -1,6 +1,6 @@
 /*
  * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2011 Hiroyuki Yamamoto and the Claws Mail team
+ * Copyright (C) 1999-2013 Hiroyuki Yamamoto and the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -19,6 +19,7 @@
 
 #ifdef HAVE_CONFIG_H
 #  include "config.h"
+#include "claws-features.h"
 #endif
 
 #include "defs.h"
@@ -209,6 +210,9 @@ static void addressbook_person_collapse_node        (GtkCMCTree     *ctree,
                                                 GList          *node,
                                                 gpointer       *data );
 
+static void addressbook_entry_activated                (GtkWidget      *widget,
+                                                gpointer        data);
+
 static gboolean addressbook_list_button_pressed        (GtkWidget      *widget,
                                                 GdkEventButton *event,
                                                 gpointer        data);
@@ -630,10 +634,7 @@ void addressbook_open(Compose *target)
        }
 
        gtk_widget_show_all(addrbook.window);
-#ifdef MAEMO
-               maemo_window_full_screen_if_needed(GTK_WINDOW(addrbook.window));
-               maemo_connect_key_press_to_mainwindow(GTK_WINDOW(addrbook.window));
-#endif
+
        if (!prefs_common.addressbook_use_editaddress_dialog)
                addressbook_edit_person_widgetset_hide();
 
@@ -694,9 +695,9 @@ void addressbook_refresh( void )
 
 static gboolean key_pressed(GtkWidget *widget, GdkEventKey *event, gpointer data)
 {
-       if (event && event->keyval == GDK_Escape)
+       if (event && event->keyval == GDK_KEY_Escape)
                addressbook_close();
-       else if (event && event->keyval == GDK_Delete) {
+       else if (event && event->keyval == GDK_KEY_Delete) {
                /* TODO: enable deletion when focus is in ctree (needs implementation in _del_clicked() */
                if ( /* address_index_has_focus || */ address_list_has_focus )
                        addressbook_del_clicked(NULL, NULL);
@@ -937,11 +938,7 @@ static void addressbook_create(void)
        gtk_action_group_add_actions(action_group, addressbook_list_popup_entries,
                        G_N_ELEMENTS(addressbook_list_popup_entries), NULL);
 
-#ifndef MAEMO
        MENUITEM_ADDUI_MANAGER(ui_manager, "/", "Menu", NULL, GTK_UI_MANAGER_MENUBAR)
-#else
-       MENUITEM_ADDUI_MANAGER(ui_manager, "/", "Menu", NULL, GTK_UI_MANAGER_POPUP)
-#endif
 
        MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu", "Book", "Book", GTK_UI_MANAGER_MENU)
        MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu", "Address", "Address", GTK_UI_MANAGER_MENU)
@@ -996,11 +993,7 @@ static void addressbook_create(void)
 
        menubar = gtk_ui_manager_get_widget(ui_manager, "/Menu");
 
-#ifndef MAEMO
        gtk_box_pack_start(GTK_BOX(vbox), menubar, FALSE, TRUE, 0);
-#else
-       hildon_window_set_menu(HILDON_WINDOW(window), GTK_MENU(menubar));
-#endif
 
        vbox2 = gtk_vbox_new(FALSE, BORDER_WIDTH);
        gtk_container_set_border_width(GTK_CONTAINER(vbox2), BORDER_WIDTH);
@@ -1019,15 +1012,9 @@ static void addressbook_create(void)
        gtk_container_add(GTK_CONTAINER(ctree_swin), ctree);
        gtk_cmclist_set_selection_mode(GTK_CMCLIST(ctree), GTK_SELECTION_BROWSE);
        gtk_cmclist_set_column_width(GTK_CMCLIST(ctree), 0, COL_FOLDER_WIDTH);
-       if (prefs_common.enable_dotted_lines) {
-               gtk_cmctree_set_line_style(GTK_CMCTREE(ctree), GTK_CMCTREE_LINES_DOTTED);
-               gtk_cmctree_set_expander_style(GTK_CMCTREE(ctree),
-                                    GTK_CMCTREE_EXPANDER_SQUARE);
-       } else {
-               gtk_cmctree_set_line_style(GTK_CMCTREE(ctree), GTK_CMCTREE_LINES_NONE);
-               gtk_cmctree_set_expander_style(GTK_CMCTREE(ctree),
-                                    GTK_CMCTREE_EXPANDER_TRIANGLE);
-       }
+       gtk_cmctree_set_line_style(GTK_CMCTREE(ctree), GTK_CMCTREE_LINES_NONE);
+       gtk_cmctree_set_expander_style(GTK_CMCTREE(ctree),
+                            GTK_CMCTREE_EXPANDER_TRIANGLE);
        gtk_sctree_set_stripes(GTK_SCTREE(ctree), prefs_common.use_stripes_in_summaries);
        gtk_cmctree_set_indent(GTK_CMCTREE(ctree), CTREE_INDENT);
        gtk_cmclist_set_compare_func(GTK_CMCLIST(ctree),
@@ -1073,16 +1060,10 @@ static void addressbook_create(void)
        /* Address list */
        clist = gtk_sctree_new_with_titles(N_LIST_COLS, 0, list_titles);
        gtk_container_add(GTK_CONTAINER(clist_swin), clist);
-       gtk_cmclist_set_selection_mode(GTK_CMCLIST(clist), GTK_SELECTION_EXTENDED);
-       if (prefs_common.enable_dotted_lines) {
-               gtk_cmctree_set_line_style(GTK_CMCTREE(clist), GTK_CMCTREE_LINES_DOTTED);
-               gtk_cmctree_set_expander_style(GTK_CMCTREE(clist),
-                                    GTK_CMCTREE_EXPANDER_SQUARE);
-       } else {
-               gtk_cmctree_set_line_style(GTK_CMCTREE(clist), GTK_CMCTREE_LINES_NONE);
-               gtk_cmctree_set_expander_style(GTK_CMCTREE(clist),
-                                    GTK_CMCTREE_EXPANDER_TRIANGLE);
-       }
+       gtk_cmclist_set_selection_mode(GTK_CMCLIST(clist), GTK_SELECTION_MULTIPLE);
+       gtk_cmctree_set_line_style(GTK_CMCTREE(clist), GTK_CMCTREE_LINES_NONE);
+       gtk_cmctree_set_expander_style(GTK_CMCTREE(clist),
+                            GTK_CMCTREE_EXPANDER_TRIANGLE);
        gtk_sctree_set_stripes(GTK_SCTREE(ctree), prefs_common.use_stripes_in_summaries);
        gtk_cmctree_set_indent(GTK_CMCTREE(clist), CTREE_INDENT);
        gtk_cmclist_set_column_width(GTK_CMCLIST(clist), COL_NAME,
@@ -1128,7 +1109,7 @@ static void addressbook_create(void)
        hbox = gtk_hbox_new(FALSE, 4);
        gtk_box_pack_start(GTK_BOX(clist_vbox), hbox, FALSE, FALSE, 0);
 
-       label = gtk_label_new(_("Lookup name:"));
+       label = gtk_label_new(_("Search"));
        gtk_box_pack_start(GTK_BOX(hbox), label, FALSE, FALSE, 0);
 
        entry = gtk_entry_new();
@@ -1139,6 +1120,8 @@ static void addressbook_create(void)
        g_signal_connect(G_OBJECT(entry), "key_press_event",
                         G_CALLBACK(addressbook_entry_key_pressed),
                         NULL);
+       g_signal_connect(G_OBJECT(entry), "activate",
+                        G_CALLBACK(addressbook_entry_activated), NULL);
 
        if (!prefs_common.addressbook_use_editaddress_dialog) {
                editaddress_vbox = gtk_vbox_new(FALSE, 4);
@@ -1491,7 +1474,7 @@ static void addressbook_del_clicked(GtkButton *button, gpointer data)
                        item = node->data;
                        node = g_list_next( node );
                        aio = ( AddrItemObject * ) item->addressItem;
-                       if( aio->type == ADDR_ITEM_PERSON || aio->type == ADDR_ITEM_EMAIL ) {
+                       if( aio->type == ITEMTYPE_PERSON || aio->type == ITEMTYPE_EMAIL ) {
                                group_delete = FALSE;
                                break;
                        }
@@ -1521,10 +1504,10 @@ static void addressbook_del_clicked(GtkButton *button, gpointer data)
                        aio = ( AddrItemObject * ) item->addressItem;
                        if (!aio)
                                continue;
-                       if( aio->type == ADDR_ITEM_GROUP ) {
+                       if( aio->type == ITEMTYPE_GROUP ) {
                                groups = g_list_prepend(groups, item);
                        }
-                       else if( aio->type == ADDR_ITEM_PERSON ) {
+                       else if( aio->type == ITEMTYPE_PERSON ) {
                                persons = g_list_prepend(persons, item);
                        }
                }
@@ -1537,7 +1520,7 @@ static void addressbook_del_clicked(GtkButton *button, gpointer data)
                        aio = ( AddrItemObject * ) item->addressItem;
                        if (!aio)
                                continue;
-                       if( aio->type == ADDR_ITEM_EMAIL ) {
+                       if( aio->type == ITEMTYPE_EMAIL ) {
                                ItemEMail *sitem = ( ItemEMail * ) aio;
                                ItemPerson *person = ( ItemPerson * ) ADDRITEM_PARENT(sitem);
                                if (!g_list_find_custom(persons, person, (GCompareFunc)(find_person))) {
@@ -1554,7 +1537,7 @@ static void addressbook_del_clicked(GtkButton *button, gpointer data)
                        aio = ( AddrItemObject * ) item->addressItem;
                        if (!aio)
                                continue;
-                       if( aio->type == ADDR_ITEM_GROUP ) {
+                       if( aio->type == ITEMTYPE_GROUP ) {
                                ItemGroup *item = ( ItemGroup * ) aio;
                                GtkCMCTreeNode *nd = NULL;
                                nd = addressbook_find_group_node( addrbook.opened, item );
@@ -1575,7 +1558,7 @@ static void addressbook_del_clicked(GtkButton *button, gpointer data)
                        aio = ( AddrItemObject * ) item->addressItem;
                        if (!aio)
                                continue;
-                       if( aio->type == ADDR_ITEM_PERSON ) {
+                       if( aio->type == ITEMTYPE_PERSON ) {
                                ItemPerson *item = ( ItemPerson * ) aio;
                                item->status = DELETE_ENTRY; 
                                addressbook_folder_remove_one_person( clist, item );
@@ -1607,7 +1590,7 @@ static void addressbook_del_clicked(GtkButton *button, gpointer data)
                        if (!aio)
                                continue;
 
-                       if( aio->type == ADDR_ITEM_EMAIL ) {
+                       if( aio->type == ITEMTYPE_EMAIL ) {
                                ItemEMail *sitem = ( ItemEMail * ) aio;
                                ItemPerson *person = ( ItemPerson * ) ADDRITEM_PARENT(sitem);
                                sitem = addrbook_person_remove_email( abf, person, sitem );
@@ -1643,7 +1626,7 @@ static void addressbook_del_clicked(GtkButton *button, gpointer data)
                        item = node->data;
                        node = g_list_next( node );
                        aio = ( AddrItemObject * ) item->addressItem;
-                       if( aio->type == ADDR_ITEM_EMAIL ) {
+                       if( aio->type == ITEMTYPE_EMAIL ) {
                                ItemEMail *item = ( ItemEMail * ) aio;
                                ItemPerson *person = ( ItemPerson * ) ADDRITEM_PARENT(item);
                                item = addrbook_person_remove_email( abf, person, item );
@@ -1685,7 +1668,7 @@ static gchar *addressbook_format_address( AddrItemObject * aio ) {
        gchar *name = NULL;
        gchar *address = NULL;
 
-       if( aio->type == ADDR_ITEM_EMAIL ) {
+       if( aio->type == ITEMTYPE_EMAIL ) {
                ItemPerson *person = NULL;
                ItemEMail *email = ( ItemEMail * ) aio;
 
@@ -1706,7 +1689,7 @@ static gchar *addressbook_format_address( AddrItemObject * aio ) {
                        address = email->address;
                }
        }
-       else if( aio->type == ADDR_ITEM_PERSON ) {
+       else if( aio->type == ITEMTYPE_PERSON ) {
                ItemPerson *person = ( ItemPerson * ) aio;
                GList *node = person->listEMail;
 
@@ -1757,14 +1740,14 @@ static void addressbook_to_clicked(GtkButton *button, gpointer data)
                        item = node->data;
                        node = g_list_next( node );
                        aio = item->addressItem;
-                       if( aio->type == ADDR_ITEM_PERSON ||
-                           aio->type == ADDR_ITEM_EMAIL ) {
+                       if( aio->type == ITEMTYPE_PERSON ||
+                           aio->type == ITEMTYPE_EMAIL ) {
                                addr = addressbook_format_address( aio );
                                compose_entry_append(
                                        compose, addr, (ComposeEntryType) data, PREF_NONE );
                                g_free( addr );
                        }
-                       else if( aio->type == ADDR_ITEM_GROUP ) {
+                       else if( aio->type == ITEMTYPE_GROUP ) {
                                ItemGroup *group = ( ItemGroup * ) aio;
                                GList *nodeMail = group->listEMail;
                                while( nodeMail ) {
@@ -1935,7 +1918,7 @@ static void addressbook_tree_selected(GtkCMCTree *ctree, GtkCMCTreeNode *node,
                static gboolean tVal = TRUE;
 
                ads = ADAPTER_DSOURCE(obj);
-               if( ads == NULL ) return;
+
                ds = ads->dataSource;
                if( ds == NULL ) return;                
 
@@ -2148,18 +2131,24 @@ static void addressbook_treenode_add_list(
                GtkCMCTreeNode *nn;
 
                aio = node->data;
-               if( ADDRESS_OBJECT_TYPE(aio) == ITEMTYPE_GROUP ) {
+               if( ADDRESS_OBJECT_TYPE(aio) == ADDR_ITEM_GROUP ) {
                        ItemGroup *group;
 
                        group = ( ItemGroup * ) aio;
                        nn = addressbook_node_add_group( treeNode, ds, group );
+                       if (nn == NULL) {
+                               g_message("error adding addressbook group\n");
+                       }
                }
-               else if( ADDRESS_OBJECT_TYPE(aio) == ITEMTYPE_FOLDER ) {
+               else if( ADDRESS_OBJECT_TYPE(aio) == ADDR_ITEM_FOLDER ) {
                        ItemFolder *folder;
 
                        folder = ( ItemFolder * ) aio;
                        nn = addressbook_node_add_folder(
                                treeNode, ds, folder, ADDR_ITEM_FOLDER );
+                       if (nn == NULL) {
+                               g_message("error adding addressbook folder\n");
+                       }
                }
                node = g_list_next( node );
        }
@@ -2388,13 +2377,11 @@ static void addressbook_list_row_selected( GtkCMCTree *clist,
                                           gint column,
                                           gpointer data )
 {
-       GtkEntry *entry = GTK_ENTRY(addrbook.entry);
        AddrItemObject *aio = NULL;
        AddressObject *pobj = NULL;
        AdapterDSource *ads = NULL;
        AddressDataSource *ds = NULL;
 
-       gtk_entry_set_text( entry, "" );
        addrbook.listSelected = node;
 
        pobj = gtk_cmctree_node_get_row_data( GTK_CMCTREE(addrbook.ctree), addrbook.treeSelected );
@@ -2441,6 +2428,11 @@ static void addressbook_list_row_unselected( GtkCMCTree *ctree,
                addressbook_edit_person_invalidate(NULL, NULL, NULL);
 }
 
+static void addressbook_entry_activated(GtkWidget *widget, gpointer data)
+{
+       addressbook_lup_clicked(NULL, NULL);
+}
+
 static gboolean addressbook_list_button_pressed(GtkWidget *widget,
                                                GdkEventButton *event,
                                                gpointer data)
@@ -2512,7 +2504,8 @@ static gboolean addressbook_tree_button_pressed(GtkWidget *ctree,
                        if( obj == NULL )
                                return FALSE;
 
-                       if (obj->type == ADDR_ITEM_GROUP) {
+                       if (obj->type == ADDR_ITEM_GROUP ||
+                                       obj->type == ADDR_DATASOURCE) {
                                /* edit group */
                                addressbook_treenode_edit_cb(NULL, NULL);
                        } else {
@@ -2553,6 +2546,7 @@ static gboolean addressbook_tree_button_pressed(GtkWidget *ctree,
                        canLookup = TRUE;
        }
        if (obj->type == ADDR_DATASOURCE) {
+               canLookup = TRUE;
                ads = ADAPTER_DSOURCE(obj);
                ds = ads->dataSource;
                if( !ds )
@@ -2568,10 +2562,9 @@ static gboolean addressbook_tree_button_pressed(GtkWidget *ctree,
                }
                canEdit = TRUE;
                canTreeCopy = TRUE;
-               if( iface->externalQuery )
-                       canLookup = TRUE;
        }
        else if (obj->type == ADDR_ITEM_FOLDER) {
+               canLookup = TRUE;
                ds = addressbook_find_datasource( node );
                if( !ds )
                        goto just_set_sens;
@@ -2590,11 +2583,11 @@ static gboolean addressbook_tree_button_pressed(GtkWidget *ctree,
 
                if( iface->externalQuery ) {
                        /* Enable deletion of LDAP folder */
-                       canLookup = TRUE;
                        canDelete = TRUE;
                }
        }
        else if (obj->type == ADDR_ITEM_GROUP) {
+               canLookup = TRUE;
                ds = addressbook_find_datasource( node );
                if( !ds )
                        goto just_set_sens;
@@ -2689,6 +2682,9 @@ static void addressbook_new_folder_cb(GtkAction *action, gpointer data)
                GtkCMCTreeNode *nn;
                nn = addressbook_node_add_folder(
                        addrbook.treeSelected, ds, folder, ADDR_ITEM_FOLDER );
+               if (nn == NULL) {
+                       g_message("error adding addressbook folder\n");
+               }
                gtk_cmctree_expand( ctree, addrbook.treeSelected );
                if( addrbook.treeSelected == addrbook.opened )
                        addressbook_set_clist(obj, TRUE);
@@ -2726,6 +2722,9 @@ static void addressbook_new_group_cb(GtkAction *action, gpointer data)
        if( group ) {
                GtkCMCTreeNode *nn;
                nn = addressbook_node_add_group( addrbook.treeSelected, ds, group );
+               if (nn == NULL) {
+                       g_message("error adding addressbook group\n");
+               }
                gtk_cmctree_expand( ctree, addrbook.treeSelected );
                if( addrbook.treeSelected == addrbook.opened )
                        addressbook_set_clist(obj, TRUE);
@@ -2743,7 +2742,7 @@ static void addressbook_change_node_name(GtkCMCTreeNode *node, const gchar *name
        gtk_cmctree_get_node_info(ctree, node, text, &spacing,
                                &pix_cl, &pix_op,
                                &is_leaf, &expanded);
-       gtk_sctree_set_node_info(ctree, node, name, spacing,
+       gtk_cmctree_set_node_info(ctree, node, name, spacing,
                                pix_cl, pix_op,
                                is_leaf, expanded);
 }
@@ -2891,7 +2890,7 @@ static void addressbook_treenode_delete_cb(GtkAction *action, gpointer data)
 
        if( obj->type == ADDR_DATASOURCE ) {
                ads = ADAPTER_DSOURCE(obj);
-               if( ads == NULL ) return;
+
                ds = ads->dataSource;
                if( ds == NULL ) return;
        }
@@ -2911,10 +2910,10 @@ static void addressbook_treenode_delete_cb(GtkAction *action, gpointer data)
        /* Confirm deletion */
        delType = ADDRTREE_DEL_NONE;
        if( obj->type == ADDR_ITEM_FOLDER ) {
-               if( iface->externalQuery ) {
+               if( iface && iface->externalQuery ) {
                        message = g_strdup_printf( _(
                                "Do you want to delete the query " \
-                               "results and addresses in '%s' ?" ),
+                               "results and addresses in '%s'?" ),
                                obj->name );
                        aval = alertpanel( _("Delete"), message,
                                GTK_STOCK_CANCEL, "+"GTK_STOCK_DELETE, NULL );
@@ -2925,11 +2924,11 @@ static void addressbook_treenode_delete_cb(GtkAction *action, gpointer data)
                }
                else {
                        message = g_strdup_printf
-                               ( _( "Do you want to delete '%s' ? "
+                               ( _( "Do you want to delete '%s'? "
                                     "If you delete the folder only, the addresses it contains will be moved into the parent folder." ),
                                 obj->name );
                        aval = alertpanel( _("Delete folder"), message,
-                               GTK_STOCK_CANCEL, _("+Delete _folder only"), _("Delete folder and _addresses"));
+                               GTK_STOCK_CANCEL, g_strconcat("+",_("Delete _folder only"), NULL), _("Delete folder and _addresses"));
                        g_free(message);
                        if( aval == G_ALERTALTERNATE ) {
                                delType = ADDRTREE_DEL_FOLDER_ONLY;
@@ -2960,7 +2959,11 @@ static void addressbook_treenode_delete_cb(GtkAction *action, gpointer data)
        if( obj->type == ADDR_DATASOURCE ) {
                /* Remove node from tree */
                gtk_cmctree_remove_node( ctree, node );
-       
+               
+               if (delType == ADDRTREE_DEL_DATA &&
+                   ds->interface && ds->interface->type == ADDR_IF_BOOK)
+                       addrbook_delete_book_file((AddressBookFile *) ds->rawDataSource);
+                       
                /* Remove data source. */
                if( addrindex_index_remove_datasource( _addressIndex_, ds ) ) {
                        addrindex_free_datasource( ds );
@@ -2974,7 +2977,7 @@ static void addressbook_treenode_delete_cb(GtkAction *action, gpointer data)
        cache = adbase->addressCache;
 
        /* Remove query results folder */
-       if( iface->externalQuery ) {
+       if( iface && iface->externalQuery ) {
                AdapterFolder *adapter = ADAPTER_FOLDER(obj);
                ItemFolder *folder = adapter->itemFolder;
 
@@ -3180,7 +3183,7 @@ static void addressbook_new_address_cb( GtkAction *action, gpointer data ) {
                        ItemPerson *person;
                        ItemFolder *folder = NULL;
 #ifdef USE_LDAP
-                       if (abf && abf->type == ADDR_IF_LDAP) {
+                       if (abf && abf->type == ADBOOKTYPE_LDAP) {
                                GtkCMCTreeNode *parentNode;
                                ds = addressbook_find_datasource( GTK_CMCTREE_NODE( addrbook.treeSelected ) );
                                if( ds == NULL ) return;
@@ -3197,7 +3200,6 @@ static void addressbook_new_address_cb( GtkAction *action, gpointer data ) {
                                }
                                folder = addressbook_setup_subf( ds, _("New Contacts"), parentNode );
 
-                               pobj = gtk_cmctree_node_get_row_data(GTK_CMCTREE(addrbook.ctree), addrbook.treeSelected);
                                ds = addressbook_find_datasource( GTK_CMCTREE_NODE(addrbook.treeSelected) );
                                if (ds)
                                        abf = ds->rawDataSource;
@@ -3208,7 +3210,7 @@ static void addressbook_new_address_cb( GtkAction *action, gpointer data ) {
                                                                  addressbook_new_address_from_book_post_cb,
                                                                  TRUE );
 #ifdef USE_LDAP
-                       if (ds && abf && abf->type == ADDR_IF_LDAP) {
+                       if (ds && abf && abf->type == ADBOOKTYPE_LDAP) {
                                LdapServer *server = ds->rawDataSource;
                                ldapsvr_set_modified(server, TRUE);
                                ldapsvr_update_book(server, NULL);
@@ -3230,7 +3232,7 @@ static void addressbook_new_address_cb( GtkAction *action, gpointer data ) {
                ItemFolder *folder = ADAPTER_FOLDER(pobj)->itemFolder;
                ItemPerson *person;
 #ifdef USE_LDAP
-               if (abf && abf->type == ADDR_IF_LDAP) {
+               if (abf && abf->type == ADBOOKTYPE_LDAP) {
                        GtkCMCTreeNode *parentNode;
                        ds = addressbook_find_datasource( GTK_CMCTREE_NODE( addrbook.treeSelected ) );
                        if( ds == NULL ) return;
@@ -3248,7 +3250,7 @@ static void addressbook_new_address_cb( GtkAction *action, gpointer data ) {
                        folder = addressbook_setup_subf( ds, _("New Contacts"), parentNode );
                        if (!folder)
                                return;
-                       pobj = gtk_cmctree_node_get_row_data(GTK_CMCTREE(addrbook.ctree), addrbook.treeSelected);
+
                        ds = addressbook_find_datasource( GTK_CMCTREE_NODE(addrbook.treeSelected) );
                        if (ds)
                                abf = ds->rawDataSource;
@@ -3259,7 +3261,7 @@ static void addressbook_new_address_cb( GtkAction *action, gpointer data ) {
                                                          addressbook_new_address_from_folder_post_cb,
                                                          TRUE );
 #ifdef USE_LDAP
-               if (ds && abf && abf->type == ADDR_IF_LDAP) {
+               if (ds && abf && abf->type == ADBOOKTYPE_LDAP) {
                        LdapServer *server = ds->rawDataSource;
                        ldapsvr_set_modified(server, TRUE);
                        ldapsvr_update_book(server, NULL);
@@ -3306,7 +3308,7 @@ static GtkCMCTreeNode *addressbook_find_group_node( GtkCMCTreeNode *parent, Item
                        AddressObject *obj;
 
                        obj = gtk_cmctree_node_get_row_data( GTK_CMCTREE(addrbook.ctree), node );
-                       if( obj->type == ADDR_ITEM_GROUP ) {
+                       if(obj && obj->type == ADDR_ITEM_GROUP ) {
                                ItemGroup *g = ADAPTER_GROUP(obj)->itemGroup;
                                if( g == group ) return node;
                        }
@@ -3359,7 +3361,7 @@ static void addressbook_edit_address_post_cb( ItemPerson *person )
 #ifdef USE_LDAP
                AddressBookFile *abf = addressbook_get_book_file();
 
-               if (abf && abf->type == ADDR_IF_LDAP) {
+               if (abf && abf->type == ADBOOKTYPE_LDAP) {
                        if (strcmp2(person->nickName, ADDRITEM_NAME(person)))
                                addritem_person_set_nick_name( person, ADDRITEM_NAME(person));
                }
@@ -3406,7 +3408,6 @@ static void addressbook_edit_address( gpointer data, guint action, GtkWidget *wi
 
                ctree = GTK_CMCTREE( addrbook.ctree );
        pobj = gtk_cmctree_node_get_row_data( ctree, addrbook.treeSelected );
-       node = gtk_cmctree_find_by_row_data( ctree, addrbook.treeSelected, obj );
 
        ds = addressbook_find_datasource( GTK_CMCTREE_NODE(addrbook.treeSelected) );
        if( ds == NULL ) return;
@@ -3415,7 +3416,7 @@ static void addressbook_edit_address( gpointer data, guint action, GtkWidget *wi
        
        if( obj->type == ADDR_ITEM_EMAIL ) {
                ItemEMail *email = ( ItemEMail * ) obj;
-               if( email == NULL ) return;
+
                if( pobj && pobj->type == ADDR_ITEM_GROUP ) {
                        /* Edit parent group */
                        AdapterGroup *adapter = ADAPTER_GROUP(pobj);
@@ -3435,7 +3436,7 @@ static void addressbook_edit_address( gpointer data, guint action, GtkWidget *wi
                                                                                   (prefs_common.addressbook_use_editaddress_dialog||force_focus) )
                                  != NULL ) { 
 #ifdef USE_LDAP
-                               if (abf && abf->type == ADDR_IF_LDAP) {
+                               if (abf && abf->type == ADBOOKTYPE_LDAP) {
                                        ldapsvr_set_modified( (LdapServer *) abf, TRUE );
                                        person->status = UPDATE_ENTRY;
                                }
@@ -3454,7 +3455,7 @@ static void addressbook_edit_address( gpointer data, guint action, GtkWidget *wi
                                                                          (prefs_common.addressbook_use_editaddress_dialog||force_focus) )
                        != NULL ) {
 #ifdef USE_LDAP
-                               if (abf && abf->type == ADDR_IF_LDAP) {
+                               if (abf && abf->type == ADBOOKTYPE_LDAP) {
                                        ldapsvr_set_modified( (LdapServer *) abf, TRUE );
                                        person->status = UPDATE_ENTRY;
                                }
@@ -3529,9 +3530,32 @@ static gchar *addressbook_format_item_clist( ItemPerson *person, ItemEMail *emai
        return str;
 }
 
+static gboolean addressbook_match_item(const gchar *name,
+                                      const gchar *email_alias,
+                                      const gchar *addr,
+                                      const gchar *remarks,
+                                      const gchar *str)
+{
+       if (!name)
+               return FALSE;
+       if (!str || str[0] == '\0')
+               return TRUE;
+       if (strcasestr(name, str))
+               return TRUE;
+       else if (email_alias && strcasestr(email_alias, str))
+               return TRUE;
+       else if (addr && strcasestr(addr, str))
+               return TRUE;
+       else if (remarks && strcasestr(remarks, str))
+               return TRUE;
+
+       return FALSE;
+}
+
 static void addressbook_load_group( GtkCMCTree *clist, ItemGroup *itemGroup ) {
        GList *items = itemGroup->listEMail;
        AddressTypeControlItem *atci = addrbookctl_lookup( ADDR_ITEM_EMAIL );
+       const gchar *search_str = gtk_entry_get_text(GTK_ENTRY(addrbook.entry));
        for( ; items != NULL; items = g_list_next( items ) ) {
                GtkCMCTreeNode *nodeEMail = NULL;
                gchar *text[N_LIST_COLS];
@@ -3542,6 +3566,13 @@ static void addressbook_load_group( GtkCMCTree *clist, ItemGroup *itemGroup ) {
                if( ! email ) continue;
 
                person = ( ItemPerson * ) ADDRITEM_PARENT(email);
+
+               if( !addressbook_match_item(ADDRITEM_NAME(person),
+                                           ADDRITEM_NAME(email),
+                                           email->address, email->remarks,
+                                           search_str))
+                       continue;
+
                str = addressbook_format_item_clist( person, email );
                if( str ) {
                        text[COL_NAME] = addressbook_set_col_name_guard(str);
@@ -3608,7 +3639,7 @@ static void addressbook_folder_load_one_person(
                                text[COL_NAME] = addressbook_set_col_name_guard(str);
                        }
 #ifdef USE_LDAP
-                       else if( abf && abf->type == ADDR_IF_LDAP && 
+                       else if( abf && abf->type == ADBOOKTYPE_LDAP && 
                                 person && person->nickName ) {
                                if (person->nickName) {
                                        if (strcmp(person->nickName, "") != 0) {
@@ -3667,13 +3698,33 @@ static void addressbook_folder_load_person( GtkCMCTree *clist, ItemFolder *itemF
        GList *items;
        AddressTypeControlItem *atci = addrbookctl_lookup( ADDR_ITEM_PERSON );
        AddressTypeControlItem *atciMail = addrbookctl_lookup( ADDR_ITEM_EMAIL );
+       const gchar *search_str;
 
        if( atci == NULL ) return;
        if( atciMail == NULL ) return;
 
+       search_str = gtk_entry_get_text(GTK_ENTRY(addrbook.entry));
+
        /* Load email addresses */
        items = addritem_folder_get_person_list( itemFolder );
        for( ; items != NULL; items = g_list_next( items ) ) {
+               ItemPerson *person;
+               GList *node;
+               ItemEMail *email;
+
+               person = (ItemPerson *)items->data;
+               if (!person)
+                       continue;
+               node = person->listEMail;
+               if (node && node->data) {
+                       email = node->data;
+                       if (!addressbook_match_item(ADDRITEM_NAME(person), ADDRITEM_NAME(email), email->address, email->remarks, search_str))
+                               continue;
+               } else {
+                       if (!addressbook_match_item(ADDRITEM_NAME(person), NULL, NULL, NULL, search_str))
+                               continue;
+               }
+
                addressbook_folder_load_one_person( clist, items->data, atci, atciMail );
        }
        /* Free up the list */
@@ -3715,11 +3766,9 @@ static void addressbook_folder_refresh_one_person( GtkCMCTree *clist, ItemPerson
 
 static void addressbook_folder_remove_one_person( GtkCMCTree *clist, ItemPerson *person ) {
        GtkCMCTreeNode *node;
-       gint row;
        
        if( person == NULL ) return;
        node = gtk_cmctree_find_by_row_data( clist, NULL, person );
-       row  = gtk_cmclist_find_row_from_data( GTK_CMCLIST(clist), person );
        if( node ) {
                addressbook_folder_remove_node( clist, node );
        }
@@ -3728,15 +3777,23 @@ static void addressbook_folder_remove_one_person( GtkCMCTree *clist, ItemPerson
 static void addressbook_folder_load_group( GtkCMCTree *clist, ItemFolder *itemFolder ) {
        GList *items;
        AddressTypeControlItem *atci =  addrbookctl_lookup( ADDR_ITEM_GROUP );
+       const gchar *search_str;
 
        /* Load any groups */
        if( ! atci ) return;
+
+       search_str = gtk_entry_get_text(GTK_ENTRY(addrbook.entry));
+
        items = addritem_folder_get_group_list( itemFolder );
        for( ; items != NULL; items = g_list_next( items ) ) {
                GtkCMCTreeNode *nodeGroup = NULL;
                gchar *text[N_LIST_COLS];
                ItemGroup *group = items->data;
                if( group == NULL ) continue;
+               if( !addressbook_match_item(ADDRITEM_NAME(group),
+                                           NULL, NULL, NULL, search_str) )
+                       continue;
+
                text[COL_NAME] = ADDRITEM_NAME(group);
                text[COL_ADDRESS] = "";
                text[COL_REMARKS] = "";
@@ -3882,15 +3939,15 @@ static void addressbook_set_clist( AddressObject *obj, gboolean refresh ) {
 
        if( obj->type == ADDR_DATASOURCE ) {
                ads = ADAPTER_DSOURCE(obj);
-               ds = ADAPTER_DSOURCE(obj)->dataSource;
+               ds = ads->dataSource;
                if( ds ) {
                        /* Load root folder */
                        ItemFolder *rootFolder = NULL;
                        rootFolder = addrindex_ds_get_root_folder( ds );
                        addressbook_folder_load_person(
-                               ctreelist, addrindex_ds_get_root_folder( ds ) );
+                               ctreelist, rootFolder );
                        addressbook_folder_load_group(
-                               ctreelist, addrindex_ds_get_root_folder( ds ) );
+                               ctreelist, rootFolder );
                }
        }
        else {
@@ -3987,12 +4044,14 @@ static void addressbook_load_tree( void ) {
                                nodeDS = iface->listSource;
                                while( nodeDS ) {
                                        ds = nodeDS->data;
-                                       newNode = NULL;
                                        name = addrindex_ds_get_name( ds );
                                        ads = addressbook_create_ds_adapter(
                                                        ds, atci->objectType, name );
                                        newNode = addressbook_add_object(
                                                        node, ADDRESS_OBJECT(ads) );
+                                       if (newNode == NULL) {
+                                               g_message("error adding addressbook object\n");
+                                       }
                                        nodeDS = g_list_next( nodeDS );
                                }
                                gtk_cmctree_expand( ctree, node );
@@ -4093,22 +4152,26 @@ static gboolean addressbook_convert( AddressIndex *addrIndex ) {
 
 static gboolean migrate_addrbook(const gchar *origdir, const gchar *destdir)
 {
-       DIR *dp;
-       struct dirent *d;
+       GDir *dp;
+       const gchar *d;
        gboolean failed = FALSE;
+       GError *error = NULL;
 
-       if( ( dp = opendir( origdir ) ) == NULL ) {
+       if( ( dp = g_dir_open( origdir, 0, &error ) ) == NULL ) {
+               debug_print("opening '%s' failed: %d (%s)\n", origdir,
+                               error->code, error->message);
+               g_error_free(error);
                return FALSE;
        }
        
-       while( ( d = readdir( dp ) ) != NULL ) {
-               if (strncmp(d->d_name, "addrbook-", strlen("addrbook-")))
+       while( ( d = g_dir_read_name( dp ) ) != NULL ) {
+               if (strncmp(d, "addrbook-", strlen("addrbook-")))
                        continue;
                else {
                        gchar *orig_file = g_strconcat(origdir, G_DIR_SEPARATOR_S, 
-                                       d->d_name, NULL);
+                                       d, NULL);
                        gchar *dest_file = g_strconcat(destdir, G_DIR_SEPARATOR_S, 
-                                       d->d_name, NULL);
+                                       d, NULL);
                        if (copy_file(orig_file, dest_file, FALSE) < 0) {
                                failed = TRUE;
                        }
@@ -4119,24 +4182,27 @@ static gboolean migrate_addrbook(const gchar *origdir, const gchar *destdir)
                        }
                }
        }
+       g_dir_close( dp );
 
-       closedir( dp );
        if (!failed) {
                /* all copies succeeded, we can remove source files */
-               if( ( dp = opendir( origdir ) ) == NULL ) {
+               if( ( dp = g_dir_open( origdir, 0, &error ) ) == NULL ) {
+                       debug_print("opening '%s' failed: %d (%s)\n", origdir,
+                                       error->code, error->message);
+                       g_error_free(error);
                        return FALSE;
                }
-               while( ( d = readdir( dp ) ) != NULL ) {
-                       if (strncmp(d->d_name, "addrbook-", strlen("addrbook-")))
+               while( ( d = g_dir_read_name( dp ) ) != NULL ) {
+                       if (strncmp(d, "addrbook-", strlen("addrbook-")))
                                continue;
                        else {
                                gchar *orig_file = g_strconcat(origdir, G_DIR_SEPARATOR_S, 
-                                               d->d_name, NULL);
+                                               d, NULL);
                                claws_unlink(orig_file);
                                g_free(orig_file);
                        }
                }
-               closedir( dp );
+               g_dir_close( dp );
        }
        
        return !failed;
@@ -4160,7 +4226,7 @@ void addressbook_read_file( void ) {
        if ( !is_dir_exist(indexdir) ) {
                if ( make_dir(indexdir) < 0 ) {
                        addrindex_set_file_path( addrIndex, get_rc_dir() );
-                       g_warning( "couldn't create dir %s\n", indexdir);
+                       g_warning( "couldn't create dir '%s'", indexdir);
                } else {
                        if (!migrate_addrbook(get_rc_dir(), indexdir)) {
                                remove_dir_recursive(indexdir);
@@ -4378,7 +4444,7 @@ void addressbook_export_to_file( void ) {
 
 static gboolean addressbook_entry_key_pressed(GtkWidget *widget, GdkEventKey *event, gpointer data)
 {
-       if (event && (event->keyval == GDK_Return || event->keyval == GDK_KP_Enter))
+       if (event && (event->keyval == GDK_KEY_Return || event->keyval == GDK_KEY_KP_Enter))
                addressbook_lup_clicked(NULL, NULL);
        return FALSE;
 }
@@ -4584,30 +4650,15 @@ static void addressbook_perform_search(
                AddressDataSource *ds, gchar *searchTerm,
                GtkCMCTreeNode *pNode )
 {
-       AddrBookBase *adbase;
-       AddressCache *cache;
        ItemFolder *folder;
        gchar *name;
        gint queryID;
        guint idleID;
-#ifdef USE_LDAP
-       AddressObjectType aoType = ADDR_NONE;
-#endif
 
        /* Setup a query */
        if( *searchTerm == '\0' || strlen( searchTerm ) < 1 ) return;
 
-       if( ds && ds->type == ADDR_IF_LDAP ) {
-#if USE_LDAP
-               aoType = ADDR_LDAP_QUERY;
-#endif
-       }
-       else {
-               return;
-       }
-       /* Get reference to address cache */    
-       adbase = ( AddrBookBase * ) ds->rawDataSource;
-       cache = adbase->addressCache;
+       if( !ds || ds->type != ADDR_IF_LDAP ) return;
 
        /* Create a folder for the search results */
        name = g_strdup_printf( _queryFolderLabel_, searchTerm );
@@ -4623,6 +4674,9 @@ static void addressbook_perform_search(
        idleID = g_idle_add(
                        (GSourceFunc) addressbook_search_idle,
                        GINT_TO_POINTER( queryID ) );
+       if (idleID == 0) {
+               g_message("error adding addressbook_search_idle\n");
+       }
 
        /* Start search, sit back and wait for something to happen */
        addrindex_start_search( queryID );
@@ -4653,6 +4707,14 @@ static void addressbook_lup_clicked( GtkButton *button, gpointer data ) {
        obj = gtk_cmctree_node_get_row_data( ctree, node );
        if( obj == NULL ) return;
 
+       if (obj->type != ADDR_DATASOURCE ||
+                       ADAPTER_DSOURCE(obj)->subType != ADDR_LDAP) {
+               addressbook_set_clist(
+                               gtk_cmctree_node_get_row_data(GTK_CMCTREE(addrbook.ctree),
+                                       addrbook.treeSelected),
+                               TRUE);
+       }
+
        ds = addressbook_find_datasource( node );
        if( ds == NULL ) return;
 
@@ -4713,8 +4775,6 @@ static void addressbook_browse_entry_cb( GtkAction *action, gpointer data)
        person = NULL;
        if (obj->type == ADDR_ITEM_EMAIL) {
                email = ( ItemEMail * ) obj;
-               if (email == NULL)
-                       return;
                
                person = (ItemPerson *) ADDRITEM_PARENT(email);
        }
@@ -4762,7 +4822,7 @@ ItemObjectType addressbook_type2item( AddressObjectType abType ) {
                atci->iconXpm = icon;                           \
                atci->iconXpmOpen = iconopen;                   \
        } else {                                                \
-               g_warning("can't get atci %d\n", id);           \
+               g_warning("can't get atci %d", id);             \
        }                                                       \
 }
 
@@ -5090,7 +5150,7 @@ static void addrbookctl_build_ifselect( void ) {
        gint ifType;
        gint i;
        gchar *endptr = NULL;
-       gboolean enabled;
+       /* gboolean enabled; */
        AdapterInterface *adapter;
 
        selectStr = g_strdup( ADDRESSBOOK_IFACE_SELECTION );
@@ -5101,12 +5161,13 @@ static void addrbookctl_build_ifselect( void ) {
                if( splitStr[i] ) {
                        /* g_print( "%d : %s\n", i, splitStr[i] ); */
                        ifType = strtol( splitStr[i], &endptr, 10 );
-                       enabled = TRUE;
+                       /* enabled = TRUE;
                        if( *endptr ) {
                                if( strcmp( endptr, "/n" ) == 0 ) {
                                        enabled = FALSE;
                                }
                        }
+                       */
                        /* g_print( "\t%d : %s\n", ifType, enabled ? "yes" : "no" ); */
                        adapter = addrbookctl_find_interface( ifType );
                        if( adapter ) {
@@ -5496,6 +5557,9 @@ void addressbook_harvest(
                                newNode = addressbook_add_object(
                                                adapter->treeNode,
                                                ADDRESS_OBJECT(ads) );
+                               if (newNode == NULL) {
+                                       g_message("error adding addressbook object\n");
+                               }
                        }
                }
 
@@ -5610,12 +5674,12 @@ static void addressbook_drag_data_get(GtkWidget        *widget,
        for(cur = GTK_CMCLIST(addrbook.clist)->selection; cur; cur = cur->next) {
                aio = (AddrItemObject *)gtk_cmctree_node_get_row_data(GTK_CMCTREE(addrbook.clist),
                        GTK_CMCTREE_NODE(cur->data));
-               while (aio && aio->type != ADDR_ITEM_PERSON) {
+               while (aio && aio->type != ITEMTYPE_PERSON) {
                        aio = aio->parent;
                }
        }
 
-       if (aio && aio->type == ADDR_ITEM_PERSON) {
+       if (aio && aio->type == ITEMTYPE_PERSON) {
                if( ds && ds->interface && ds->interface->readOnly)
                        gtk_selection_data_set(selection_data,
                                       gtk_selection_data_get_target(selection_data), 8,