update copyright year
[claws.git] / src / addressbook.c
index 77ddee8d408e098535228680d40b06e704e9708d..413668ec450a11b1a5157e749dbb46c3da228919 100644 (file)
@@ -1,6 +1,6 @@
 /*
- * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2013 Hiroyuki Yamamoto and the Claws Mail team
+ * Claws Mail -- a GTK based, lightweight, and fast e-mail client
+ * Copyright (C) 1999-2024 the Claws Mail team and Hiroyuki Yamamoto
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -14,7 +14,6 @@
  *
  * You should have received a copy of the GNU General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
- * 
  */
 
 #ifdef HAVE_CONFIG_H
@@ -31,7 +30,6 @@
 #include <string.h>
 #include <setjmp.h>
 #include <sys/types.h>
-#include <dirent.h>
 
 #include "main.h"
 #include "addressbook.h"
 #include "xml.h"
 #include "prefs_gtk.h"
 #include "procmime.h"
+#include "file-utils.h"
 #include "utils.h"
 #include "gtkutils.h"
 #include "codeconv.h"
 #include "about.h"
 #include "addr_compl.h"
+#include "password.h"
 
 #include "mgutils.h"
 #include "addressitem.h"
@@ -56,6 +56,7 @@
 #include "addrcache.h"
 #include "addrbook.h"
 #include "addrindex.h"
+#include "addrmerge.h"
 #include "addressadd.h"
 #include "addrduplicates.h"
 #include "addressbook_foldersel.h"
@@ -305,10 +306,6 @@ static void addressbook_folder_load_one_person     (GtkCMCTree *clist,
                                                 ItemPerson *person,  
                                                 AddressTypeControlItem *atci, 
                                                 AddressTypeControlItem *atciMail);
-static void addressbook_folder_refresh_one_person(GtkCMCTree *clist, 
-                                                 ItemPerson *person);
-static void addressbook_folder_remove_one_person(GtkCMCTree *clist, 
-                                                ItemPerson *person);
 static void addressbook_folder_remove_node     (GtkCMCTree *clist, 
                                                 GtkCMCTreeNode *node);
 
@@ -351,6 +348,7 @@ static void addressbook_treenode_copy_cb    ( GtkAction *action, gpointer data );
 static void addressbook_treenode_paste_cb      ( GtkAction *action, gpointer data );
 
 static void addressbook_mail_to_cb             ( GtkAction *action, gpointer data );
+static void addressbook_merge_cb               ( GtkAction *action, gpointer data );
 
 #ifdef USE_LDAP
 static void addressbook_browse_entry_cb                ( GtkAction *action, gpointer data );
@@ -393,19 +391,13 @@ static GtkTargetEntry addressbook_drag_types[] =
 
 static GtkTargetList *addressbook_target_list = NULL;
 
-static void about_show_cb(GtkAction *action, gpointer data)
-{
-       about_show();
-}
-
 static GtkActionEntry addressbook_entries[] =
 {
-       {"Menu",                                NULL, "Menu" },
+       {"Menu",                                NULL, "Menu", NULL, NULL, NULL },
 /* menus */
-       {"Book",                        NULL, N_("_Book") },
-       {"Address",                     NULL, N_("_Edit") },
-       {"Tools",                       NULL, N_("_Tools") },
-       {"Help",                        NULL, N_("_Help") },
+       {"Book",                        NULL, N_("_Book"), NULL, NULL, NULL },
+       {"Edit",                        NULL, N_("_Edit"), NULL, NULL, NULL },
+       {"Tools",                       NULL, N_("_Tools"), NULL, NULL, NULL },
        
 /* Book menu */
        {"Book/NewBook",                NULL, N_("New _Book"), "<control>B", NULL, G_CALLBACK(addressbook_new_book_cb) },
@@ -441,6 +433,7 @@ static GtkActionEntry addressbook_entries[] =
        {"Address/NewGroup",            NULL, N_("New _Group"), "<control>G", NULL, G_CALLBACK(addressbook_new_group_cb) },
        /* {"Address/---",                      NULL, "---", NULL, NULL, NULL }, */
        {"Address/Mailto",              NULL, N_("_Mail To"), "<control>M", NULL, G_CALLBACK(addressbook_mail_to_cb) },
+       {"Address/Merge",               NULL, N_("_Merge"), "<control>E", NULL, G_CALLBACK(addressbook_merge_cb) },
 
 
 /* Tools menu */
@@ -453,15 +446,11 @@ static GtkActionEntry addressbook_entries[] =
        /* {"Tools/---",                        NULL, "---", NULL, NULL, NULL },*/
        {"Tools/FindDuplicates",        NULL, N_("Find duplicates..."), NULL, NULL, G_CALLBACK(addressbook_find_duplicates_cb) },
        {"Tools/EditAttrs",             NULL, N_("Edit custom attributes..."), NULL, NULL, G_CALLBACK(addressbook_edit_custom_attr_cb) },
-
-/* Help menu */
-       {"Help/About",                  NULL, N_("_About"), NULL, NULL, G_CALLBACK(about_show_cb) }, 
-
 };
 
 static GtkActionEntry addressbook_tree_popup_entries[] =
 {
-       {"ABTreePopup",                 NULL, "ABTreePopup" },
+       {"ABTreePopup",                 NULL, "ABTreePopup", NULL, NULL, NULL },
        {"ABTreePopup/EditBook",        NULL, N_("_Edit"), NULL, NULL, G_CALLBACK(addressbook_treenode_edit_cb) },
        {"ABTreePopup/DeleteBook",      NULL, N_("_Delete"), NULL, NULL, G_CALLBACK(addressbook_treenode_delete_cb) },
        {"ABTreePopup/---",             NULL, "---", NULL, NULL, NULL },
@@ -476,7 +465,7 @@ static GtkActionEntry addressbook_tree_popup_entries[] =
 
 static GtkActionEntry addressbook_list_popup_entries[] =
 {
-       {"ABListPopup",                 NULL, "ABListPopup" },
+       {"ABListPopup",                 NULL, "ABListPopup", NULL, NULL, NULL },
        {"ABListPopup/SelectAll",       NULL, N_("_Select all"), NULL, NULL, G_CALLBACK(addressbook_select_all_cb) },
        {"ABListPopup/---",             NULL, "---", NULL, NULL, NULL },
        {"ABListPopup/Edit",            NULL, N_("_Edit"), NULL, NULL, G_CALLBACK(addressbook_edit_address_cb) },
@@ -493,6 +482,7 @@ static GtkActionEntry addressbook_list_popup_entries[] =
 #ifdef USE_LDAP
        {"ABListPopup/BrowseEntry",     NULL, N_("_Browse Entry"), NULL, NULL, G_CALLBACK(addressbook_browse_entry_cb) },
 #endif
+       {"ABListPopup/Merge",           NULL, N_("_Merge"), NULL, NULL, G_CALLBACK(addressbook_merge_cb) },
 };
 
 /**
@@ -654,6 +644,7 @@ void addressbook_destroy( void ) {
        }
        if( _clipBoard_ != NULL ) {
                addrclip_free( _clipBoard_ );
+               _clipBoard_ = NULL;
        }
        if( _addressIndex_ != NULL ) {
                addrindex_free_index( _addressIndex_ );
@@ -713,8 +704,8 @@ static void addressbook_size_allocate_cb(GtkWidget *widget,
 {
        cm_return_if_fail(allocation != NULL);
 
-       prefs_common.addressbookwin_width = allocation->width;
-       prefs_common.addressbookwin_height = allocation->height;
+       gtk_window_get_size(GTK_WINDOW(widget),
+               &prefs_common.addressbookwin_width, &prefs_common.addressbookwin_height);
 }
 
 static gint sort_column_number = 0;
@@ -764,13 +755,13 @@ static void addressbook_sort_list(GtkCMCList *clist, const gint col,
        gtk_cmclist_sort(clist);
        
        for(pos = 0 ; pos < N_LIST_COLS ; pos++) {
-               hbox = gtk_hbox_new(FALSE, 4);
+               hbox = gtk_box_new(GTK_ORIENTATION_HORIZONTAL, 4);
                label = gtk_label_new(gettext(list_titles[pos]));
                gtk_box_pack_start(GTK_BOX(hbox), label, FALSE, FALSE, 0);
                
                if(pos == col) {
-                       arrow = gtk_arrow_new(sort_type == GTK_SORT_ASCENDING ?
-                               GTK_ARROW_DOWN : GTK_ARROW_UP, GTK_SHADOW_IN);
+                       arrow = gtk_image_new_from_icon_name(sort_type == GTK_SORT_ASCENDING ?
+                               "pan-down-symbolic" : "pan-up-symbolic", GTK_ICON_SIZE_MENU);
                        gtk_box_pack_end(GTK_BOX(hbox), arrow, FALSE, FALSE, 0);
                }
                
@@ -916,6 +907,7 @@ static void addressbook_create(void)
        window = gtkut_window_new(GTK_WINDOW_TOPLEVEL, "addressbook");
        gtk_window_set_title(GTK_WINDOW(window), _("Address book"));
        gtk_window_set_resizable(GTK_WINDOW(window), TRUE);
+       gtk_window_set_type_hint(GTK_WINDOW(window), GDK_WINDOW_TYPE_HINT_DIALOG);
        gtk_widget_realize(window);
 
        g_signal_connect(G_OBJECT(window), "delete_event",
@@ -926,7 +918,7 @@ static void addressbook_create(void)
                         G_CALLBACK(key_pressed), NULL);
        MANAGE_WINDOW_SIGNALS_CONNECT(window);
 
-       vbox = gtk_vbox_new(FALSE, 0);
+       vbox = gtk_box_new(GTK_ORIENTATION_VERTICAL, 0);
        gtk_container_add(GTK_CONTAINER(window), vbox);
 
        /* Menu bar */
@@ -941,9 +933,8 @@ static void addressbook_create(void)
        MENUITEM_ADDUI_MANAGER(ui_manager, "/", "Menu", NULL, GTK_UI_MANAGER_MENUBAR)
 
        MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu", "Book", "Book", GTK_UI_MANAGER_MENU)
-       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu", "Address", "Address", GTK_UI_MANAGER_MENU)
+       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu", "Edit", "Edit", GTK_UI_MANAGER_MENU)
        MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu", "Tools", "Tools", GTK_UI_MANAGER_MENU)
-       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu", "Help", "Help", GTK_UI_MANAGER_MENU)
 
 /* Book menu */
        MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Book", "NewBook", "Book/NewBook", GTK_UI_MANAGER_MENUITEM)
@@ -963,19 +954,20 @@ static void addressbook_create(void)
        MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Book", "Close", "Book/Close", GTK_UI_MANAGER_MENUITEM)
 
 /* Address menu */
-       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Address", "SelectAll", "Address/SelectAll", GTK_UI_MANAGER_MENUITEM)
-       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Address", "Separator1", "Address/---", GTK_UI_MANAGER_SEPARATOR)
-       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Address", "Cut", "Address/Cut", GTK_UI_MANAGER_MENUITEM)
-       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Address", "Copy", "Address/Copy", GTK_UI_MANAGER_MENUITEM)
-       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Address", "Paste", "Address/Paste", GTK_UI_MANAGER_MENUITEM)
-       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Address", "Separator2", "Address/---", GTK_UI_MANAGER_SEPARATOR)
-       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Address", "Edit", "Address/Edit", GTK_UI_MANAGER_MENUITEM)
-       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Address", "Delete", "Address/Delete", GTK_UI_MANAGER_MENUITEM)
-       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Address", "Separator3", "Address/---", GTK_UI_MANAGER_SEPARATOR)
-       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Address", "NewAddress", "Address/NewAddress", GTK_UI_MANAGER_MENUITEM)
-       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Address", "NewGroup", "Address/NewGroup", GTK_UI_MANAGER_MENUITEM)
-       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Address", "Separator4", "Address/---", GTK_UI_MANAGER_SEPARATOR)
-       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Address", "Mailto", "Address/Mailto", GTK_UI_MANAGER_MENUITEM)
+       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Edit", "SelectAll", "Address/SelectAll", GTK_UI_MANAGER_MENUITEM)
+       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Edit", "Separator1", "Address/---", GTK_UI_MANAGER_SEPARATOR)
+       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Edit", "Cut", "Address/Cut", GTK_UI_MANAGER_MENUITEM)
+       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Edit", "Copy", "Address/Copy", GTK_UI_MANAGER_MENUITEM)
+       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Edit", "Paste", "Address/Paste", GTK_UI_MANAGER_MENUITEM)
+       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Edit", "Separator2", "Address/---", GTK_UI_MANAGER_SEPARATOR)
+       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Edit", "Edit", "Address/Edit", GTK_UI_MANAGER_MENUITEM)
+       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Edit", "Delete", "Address/Delete", GTK_UI_MANAGER_MENUITEM)
+       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Edit", "Separator3", "Address/---", GTK_UI_MANAGER_SEPARATOR)
+       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Edit", "NewAddress", "Address/NewAddress", GTK_UI_MANAGER_MENUITEM)
+       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Edit", "NewGroup", "Address/NewGroup", GTK_UI_MANAGER_MENUITEM)
+       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Edit", "Separator4", "Address/---", GTK_UI_MANAGER_SEPARATOR)
+       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Edit", "Mailto", "Address/Mailto", GTK_UI_MANAGER_MENUITEM)
+       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Edit", "Merge", "Address/Merge", GTK_UI_MANAGER_MENUITEM)
 
 /* Tools menu */
        MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Tools", "ImportLDIF", "Tools/ImportLDIF", GTK_UI_MANAGER_MENUITEM)
@@ -988,14 +980,14 @@ static void addressbook_create(void)
        MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Tools", "FindDuplicates", "Tools/FindDuplicates", GTK_UI_MANAGER_MENUITEM)
        MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Tools", "EditAttrs", "Tools/EditAttrs", GTK_UI_MANAGER_MENUITEM)
 
-/* Help menu */
-       MENUITEM_ADDUI_MANAGER(ui_manager, "/Menu/Help", "About", "Help/About", GTK_UI_MANAGER_MENUITEM)
+       gtk_window_add_accel_group(GTK_WINDOW(window),
+                       gtk_ui_manager_get_accel_group(ui_manager));
 
        menubar = gtk_ui_manager_get_widget(ui_manager, "/Menu");
 
        gtk_box_pack_start(GTK_BOX(vbox), menubar, FALSE, TRUE, 0);
 
-       vbox2 = gtk_vbox_new(FALSE, BORDER_WIDTH);
+       vbox2 = gtk_box_new(GTK_ORIENTATION_VERTICAL, BORDER_WIDTH);
        gtk_container_set_border_width(GTK_CONTAINER(vbox2), BORDER_WIDTH);
        gtk_box_pack_start(GTK_BOX(vbox), vbox2, TRUE, TRUE, 0);
 
@@ -1003,16 +995,14 @@ static void addressbook_create(void)
        gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(ctree_swin),
                                       GTK_POLICY_AUTOMATIC,
                                       GTK_POLICY_AUTOMATIC);
-       gtk_widget_set_size_request(ctree_swin, COL_FOLDER_WIDTH + 20, -1);
 
        /* Address index */
        ctree = gtk_sctree_new_with_titles(N_INDEX_COLS, 0, index_titles);
-       gtkut_widget_set_can_focus(GTK_CMCLIST(ctree)->column[0].button, FALSE);
+       gtk_widget_set_can_focus(GTK_CMCLIST(ctree)->column[0].button, FALSE);
 
        gtk_container_add(GTK_CONTAINER(ctree_swin), ctree);
        gtk_cmclist_set_selection_mode(GTK_CMCLIST(ctree), GTK_SELECTION_BROWSE);
        gtk_cmclist_set_column_width(GTK_CMCLIST(ctree), 0, COL_FOLDER_WIDTH);
-       gtk_cmctree_set_line_style(GTK_CMCTREE(ctree), GTK_CMCTREE_LINES_NONE);
        gtk_cmctree_set_expander_style(GTK_CMCTREE(ctree),
                             GTK_CMCTREE_EXPANDER_TRIANGLE);
        gtk_sctree_set_stripes(GTK_SCTREE(ctree), prefs_common.use_stripes_in_summaries);
@@ -1049,7 +1039,7 @@ static void addressbook_create(void)
        g_signal_connect(G_OBJECT(ctree), "focus_out_event",
                G_CALLBACK(addressbook_address_index_focus_evt_out), NULL);
 
-       clist_vbox = gtk_vbox_new(FALSE, 4);
+       clist_vbox = gtk_box_new(GTK_ORIENTATION_VERTICAL, 4);
 
        clist_swin = gtk_scrolled_window_new(NULL, NULL);
        gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(clist_swin),
@@ -1061,7 +1051,6 @@ static void addressbook_create(void)
        clist = gtk_sctree_new_with_titles(N_LIST_COLS, 0, list_titles);
        gtk_container_add(GTK_CONTAINER(clist_swin), clist);
        gtk_cmclist_set_selection_mode(GTK_CMCLIST(clist), GTK_SELECTION_MULTIPLE);
-       gtk_cmctree_set_line_style(GTK_CMCTREE(clist), GTK_CMCTREE_LINES_NONE);
        gtk_cmctree_set_expander_style(GTK_CMCTREE(clist),
                             GTK_CMCTREE_EXPANDER_TRIANGLE);
        gtk_sctree_set_stripes(GTK_SCTREE(ctree), prefs_common.use_stripes_in_summaries);
@@ -1085,7 +1074,7 @@ static void addressbook_create(void)
                G_CALLBACK(addressbook_address_list_focus_evt_out), NULL);
 
        for (i = 0; i < N_LIST_COLS; i++)
-               gtkut_widget_set_can_focus(GTK_CMCLIST(clist)->column[i].button,
+               gtk_widget_set_can_focus(GTK_CMCLIST(clist)->column[i].button,
                                         FALSE);
 
        g_signal_connect(G_OBJECT(clist), "tree_select_row",
@@ -1106,7 +1095,7 @@ static void addressbook_create(void)
                         G_CALLBACK(addressbook_start_drag), NULL);
        g_signal_connect(G_OBJECT(clist), "drag_data_get",
                         G_CALLBACK(addressbook_drag_data_get), NULL);  
-       hbox = gtk_hbox_new(FALSE, 4);
+       hbox = gtk_box_new(GTK_ORIENTATION_HORIZONTAL, 4);
        gtk_box_pack_start(GTK_BOX(clist_vbox), hbox, FALSE, FALSE, 0);
 
        label = gtk_label_new(_("Search"));
@@ -1124,15 +1113,15 @@ static void addressbook_create(void)
                         G_CALLBACK(addressbook_entry_activated), NULL);
 
        if (!prefs_common.addressbook_use_editaddress_dialog) {
-               editaddress_vbox = gtk_vbox_new(FALSE, 4);
-               vpaned = gtk_vpaned_new();
+               editaddress_vbox = gtk_box_new(GTK_ORIENTATION_VERTICAL, 4);
+               vpaned = gtk_paned_new(GTK_ORIENTATION_VERTICAL);
                gtk_paned_pack1(GTK_PANED(vpaned), clist_vbox, FALSE, FALSE);
                gtk_paned_pack2(GTK_PANED(vpaned), editaddress_vbox, TRUE, FALSE);
        } else {
                vpaned = NULL;
                editaddress_vbox = NULL;
        }
-       hpaned = gtk_hpaned_new();
+       hpaned = gtk_paned_new(GTK_ORIENTATION_HORIZONTAL);
        gtk_box_pack_start(GTK_BOX(vbox2), hpaned, TRUE, TRUE, 0);
        gtk_paned_pack1(GTK_PANED(hpaned), ctree_swin, FALSE, FALSE);
        if (prefs_common.addressbook_use_editaddress_dialog)
@@ -1141,13 +1130,13 @@ static void addressbook_create(void)
                gtk_paned_pack2(GTK_PANED(hpaned), vpaned, TRUE, FALSE);
 
        /* Status bar */
-       hsbox = gtk_hbox_new(FALSE, 0);
+       hsbox = gtk_box_new(GTK_ORIENTATION_HORIZONTAL, 0);
        gtk_box_pack_end(GTK_BOX(vbox), hsbox, FALSE, FALSE, BORDER_WIDTH);
        statusbar = gtk_statusbar_new();
        gtk_box_pack_start(GTK_BOX(hsbox), statusbar, TRUE, TRUE, BORDER_WIDTH);
 
        /* Button panel */
-       hbbox = gtk_hbutton_box_new();
+       hbbox = gtk_button_box_new(GTK_ORIENTATION_HORIZONTAL);
        gtk_button_box_set_layout(GTK_BUTTON_BOX(hbbox), GTK_BUTTONBOX_END);
        gtk_box_set_spacing(GTK_BOX(hbbox), 2);
        gtk_container_set_border_width(GTK_CONTAINER(hbbox), 4);
@@ -1155,19 +1144,19 @@ static void addressbook_create(void)
 
        gtkut_stock_button_add_help(hbbox, &help_btn);
 
-       edit_btn = gtk_button_new_from_stock(GTK_STOCK_EDIT);
-       gtkut_widget_set_can_default(edit_btn, TRUE);
+       edit_btn = gtk_button_new_with_mnemonic("_Edit");
+       gtk_widget_set_can_default(edit_btn, TRUE);
        gtk_box_pack_start(GTK_BOX(hbbox), edit_btn, TRUE, TRUE, 0);
-       del_btn = gtk_button_new_from_stock(GTK_STOCK_DELETE);
-       gtkut_widget_set_can_default(del_btn, TRUE);
+       del_btn = gtk_button_new_with_mnemonic("_Delete");
+       gtk_widget_set_can_default(del_btn, TRUE);
        gtk_box_pack_start(GTK_BOX(hbbox), del_btn, TRUE, TRUE, 0);
-       reg_btn = gtk_button_new_from_stock(GTK_STOCK_NEW);
-       gtkut_widget_set_can_default(reg_btn, TRUE);
+       reg_btn = gtk_button_new_with_mnemonic("_New");
+       gtk_widget_set_can_default(reg_btn, TRUE);
        gtk_box_pack_start(GTK_BOX(hbbox), reg_btn, TRUE, TRUE, 0);
 
 
-       lup_btn = gtk_button_new_from_stock(GTK_STOCK_FIND);
-       gtkut_widget_set_can_default(lup_btn, TRUE);
+       lup_btn = gtkut_stock_button("edit-find", _("_Find"));
+       gtk_widget_set_can_default(lup_btn, TRUE);
        gtk_box_pack_start(GTK_BOX(hbox), lup_btn, TRUE, TRUE, 0);
 
        g_signal_connect(G_OBJECT(help_btn), "clicked",
@@ -1185,19 +1174,19 @@ static void addressbook_create(void)
 
        to_btn = gtk_button_new_with_label
                (prefs_common_translated_header_name("To:"));
-       gtkut_widget_set_can_default(to_btn, TRUE);
+       gtk_widget_set_can_default(to_btn, TRUE);
        gtk_box_pack_start(GTK_BOX(hbbox), to_btn, TRUE, TRUE, 0);
        cc_btn = gtk_button_new_with_label
                (prefs_common_translated_header_name("Cc:"));
-       gtkut_widget_set_can_default(cc_btn, TRUE);
+       gtk_widget_set_can_default(cc_btn, TRUE);
        gtk_box_pack_start(GTK_BOX(hbbox), cc_btn, TRUE, TRUE, 0);
        bcc_btn = gtk_button_new_with_label
                (prefs_common_translated_header_name("Bcc:"));
-       gtkut_widget_set_can_default(bcc_btn, TRUE);
+       gtk_widget_set_can_default(bcc_btn, TRUE);
        gtk_box_pack_start(GTK_BOX(hbbox), bcc_btn, TRUE, TRUE, 0);
 
-       close_btn = gtk_button_new_from_stock(GTK_STOCK_CLOSE);
-       gtkut_widget_set_can_default(close_btn, TRUE);
+       close_btn = gtkut_stock_button("window-close", "_Close");
+       gtk_widget_set_can_default(close_btn, TRUE);
        gtk_box_pack_start(GTK_BOX(hbbox), close_btn, TRUE, TRUE, 0);
 
        g_signal_connect(G_OBJECT(to_btn), "clicked",
@@ -1279,6 +1268,7 @@ static void addressbook_create(void)
 #ifdef USE_LDAP
        MENUITEM_ADDUI_MANAGER(ui_manager, "/Popups/ABListPopup", "BrowseEntry", "ABListPopup/BrowseEntry", GTK_UI_MANAGER_MENUITEM)
 #endif
+       MENUITEM_ADDUI_MANAGER(ui_manager, "/Popups/ABListPopup", "Merge", "ABListPopup/Merge", GTK_UI_MANAGER_MENUITEM)
        list_popup = gtk_menu_item_get_submenu(GTK_MENU_ITEM(
                                gtk_ui_manager_get_widget(ui_manager, "/Popups/ABListPopup")));
 
@@ -1319,7 +1309,7 @@ static void addressbook_create(void)
 
        gtk_window_set_geometry_hints(GTK_WINDOW(window), NULL, &geometry,
                                      GDK_HINT_MIN_SIZE);
-       gtk_widget_set_size_request(window, prefs_common.addressbookwin_width,
+       gtk_window_set_default_size(GTK_WINDOW(window), prefs_common.addressbookwin_width,
                                    prefs_common.addressbookwin_height);
 #ifdef G_OS_WIN32
        gtk_window_move(GTK_WINDOW(window), 48, 48);
@@ -1436,8 +1426,8 @@ static void addressbook_del_clicked(GtkButton *button, gpointer data)
        iface = ds->interface;
        if( iface->readOnly ) {
                alertpanel( _("Delete address(es)"),
-                       _("This address data is readonly and cannot be deleted."),
-                       GTK_STOCK_CLOSE, NULL, NULL );
+                       _("This address data is read-only and cannot be deleted."),
+                       "window-close", _("_Close"), NULL, NULL, NULL, NULL, ALERTFOCUS_FIRST);
                return;
        }
 
@@ -1483,14 +1473,16 @@ static void addressbook_del_clicked(GtkButton *button, gpointer data)
                        aval = alertpanel( _("Delete group"),
                                        _("Really delete the group(s)?\n"
                                          "The addresses it contains will not be lost."),
-                                       GTK_STOCK_CANCEL, "+"GTK_STOCK_DELETE, NULL );
+                                       NULL, _("_Cancel"), "edit-delete", _("D_elete"), NULL, NULL,
+                                       ALERTFOCUS_SECOND );
                        if( aval != G_ALERTALTERNATE ) {
                                goto thaw_ret;
                        }
                } else {
                        aval = alertpanel( _("Delete address(es)"),
                                        _("Really delete the address(es)?"),
-                                       GTK_STOCK_CANCEL, "+"GTK_STOCK_DELETE, NULL );
+                                       NULL, _("_Cancel"), "edit-delete", _("D_elete"), NULL, NULL,
+                                       ALERTFOCUS_SECOND );
                        if( aval != G_ALERTALTERNATE ) {
                                goto thaw_ret;
                        }
@@ -1787,14 +1779,15 @@ static void addressbook_menubar_set_sensitive( gboolean sensitive ) {
        cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Book/DeleteBook", sensitive );
        cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Book/NewFolder",  sensitive );
 
-       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Address/SelectAll",    TRUE );
-       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Address/Cut",    sensitive );
-       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Address/Copy",   sensitive );
-       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Address/Paste",  sensitive );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Edit/SelectAll",    TRUE );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Edit/Cut",    sensitive );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Edit/Copy",   sensitive );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Edit/Paste",  sensitive );
 
-       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Address/NewAddress", sensitive );
-       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Address/NewGroup",   sensitive );
-       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Address/Mailto",     sensitive );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Edit/NewAddress", sensitive );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Edit/NewGroup",   sensitive );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Edit/Mailto",     sensitive );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Edit/Merge",      sensitive );
        gtk_widget_set_sensitive( addrbook.edit_btn, sensitive );
        gtk_widget_set_sensitive( addrbook.del_btn, sensitive );
 }
@@ -1861,14 +1854,14 @@ static void addressbook_menuitem_set_sensitive( AddressObject *obj, GtkCMCTreeNo
                canEdit = FALSE;
 
        /* Enable add */
-       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Address/NewAddress", editAddress );
-       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Address/NewGroup",   canAdd );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Edit/NewAddress", editAddress );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Edit/NewGroup",   canAdd );
        cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Book/NewFolder",  canAdd );
        gtk_widget_set_sensitive( addrbook.reg_btn, editAddress );
 
        /* Enable edit */
-       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Address/Edit",   canEdit );
-       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Address/Delete", canDelete );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Edit/Edit",   canEdit );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Edit/Delete", canDelete );
        gtk_widget_set_sensitive( addrbook.edit_btn, canEdit );
        gtk_widget_set_sensitive( addrbook.del_btn, canDelete );
 
@@ -1983,12 +1976,16 @@ static void addressbook_list_menu_setup( void ) {
        AdapterDSource *ads = NULL;
        AddressInterface *iface = NULL;
        AddressDataSource *ds = NULL;
+       GList *list;
+       AddrItemObject *aio;
+       AddrSelectItem *item;
        gboolean canEdit = FALSE;
        gboolean canDelete = FALSE;
        gboolean canCut = FALSE;
        gboolean canCopy = FALSE;
        gboolean canPaste = FALSE;
        gboolean canBrowse = FALSE;
+       gboolean canMerge = FALSE;
 
        pobj = gtk_cmctree_node_get_row_data( GTK_CMCTREE(addrbook.ctree), addrbook.treeSelected );
        if( pobj == NULL ) return;
@@ -2066,11 +2063,23 @@ static void addressbook_list_menu_setup( void ) {
                canBrowse = FALSE;
        }
 
+       /* Allow merging persons or emails are selected */
+       list = _addressSelect_->listSelect;
+       if (list && list->next ) {
+               item = list->data;
+               aio = ( AddrItemObject * ) item->addressItem;
+               if( aio->type == ITEMTYPE_EMAIL ||
+                               aio->type == ITEMTYPE_PERSON ) {
+                       canMerge = TRUE;
+               }
+       }
+
        /* Forbid write changes when read-only */
        if( iface && iface->readOnly ) {
                canCut = FALSE;
                canDelete = FALSE;
                canPaste = FALSE;
+               canMerge = FALSE;
        }
 
        /* Now go finalize menu items */
@@ -2082,14 +2091,16 @@ static void addressbook_list_menu_setup( void ) {
        cm_menu_set_sensitive_full( addrbook.ui_manager, "Popups/ABListPopup/Paste",         canPaste );
 
        cm_menu_set_sensitive_full( addrbook.ui_manager, "Popups/ABListPopup/Mailto",       canCopy );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Popups/ABListPopup/Merge",        canMerge );
 
-       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Address/Cut",           canCut );
-       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Address/Copy",          canCopy );
-       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Address/Paste",         canPaste );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Edit/Cut",           canCut );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Edit/Copy",          canCopy );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Edit/Paste",         canPaste );
 
-       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Address/Edit",    canEdit );
-       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Address/Delete",  canDelete );
-       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Address/Mailto", canCopy );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Edit/Edit",    canEdit );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Edit/Delete",  canDelete );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Edit/Mailto", canCopy );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Edit/Merge",  canMerge );
 
        gtk_widget_set_sensitive( addrbook.edit_btn, canEdit );
        gtk_widget_set_sensitive( addrbook.del_btn, canDelete );
@@ -2162,7 +2173,9 @@ static void addressbook_clip_cut_cb( GtkAction *action, gpointer data ) {
        _clipBoard_->cutFlag = TRUE;
        addrclip_clear( _clipBoard_ );
        addrclip_add( _clipBoard_, _addressSelect_ );
-       /* addrclip_list_show( _clipBoard_, stdout ); */
+#ifdef DEBUG_ADDRBOOK
+       addrclip_list_show( _clipBoard_, stdout );
+#endif
 }
 
 /**
@@ -2172,7 +2185,9 @@ static void addressbook_clip_copy_cb(GtkAction *action, gpointer data) {
        _clipBoard_->cutFlag = FALSE;
        addrclip_clear( _clipBoard_ );
        addrclip_add( _clipBoard_, _addressSelect_ );
-       /* addrclip_list_show( _clipBoard_, stdout ); */
+#ifdef DEBUG_ADDRBOOK
+       addrclip_list_show( _clipBoard_, stdout );
+#endif
 }
 
 /**
@@ -2189,7 +2204,7 @@ static void addressbook_clip_paste_cb( GtkAction *action, gpointer data ) {
        ds = addressbook_find_datasource( GTK_CMCTREE_NODE(addrbook.treeSelected) );
        if( ds == NULL ) return;
        if( addrindex_ds_get_readonly( ds ) ) {
-               alertpanel_error( _("Cannot paste. Target address book is readonly.") );
+               alertpanel_error( _("Cannot paste. Target address book is read-only.") );
                return;
        }
 
@@ -2226,7 +2241,9 @@ static void addressbook_clip_paste_cb( GtkAction *action, gpointer data ) {
                folderGroup = addrclip_paste_copy( _clipBoard_, abf, folder );
        }
 
-       /* addrclip_list_show( _clipBoard_, stdout ); */
+#ifdef DEBUG_ADDRBOOK
+       addrclip_list_show( _clipBoard_, stdout );
+#endif
        if( folderGroup ) {
                /* Update tree by inserting node for each folder or group */
                addressbook_treenode_add_list(
@@ -2305,7 +2322,9 @@ static void addressbook_treenode_cut_cb( GtkAction *action, gpointer data ) {
        addressbook_treenode_to_clipboard();
        addrclip_clear( _clipBoard_ );
        addrclip_add( _clipBoard_, _addressSelect_ );
-       /* addrclip_list_show( _clipBoard_, stdout ); */
+#ifdef DEBUG_ADDRBOOK
+       addrclip_list_show( _clipBoard_, stdout );
+#endif
 }
 
 /**
@@ -2316,7 +2335,9 @@ static void addressbook_treenode_copy_cb( GtkAction *action, gpointer data ) {
        addressbook_treenode_to_clipboard();
        addrclip_clear( _clipBoard_ );
        addrclip_add( _clipBoard_, _addressSelect_ );
-       /* addrclip_list_show( _clipBoard_, stdout ); */
+#ifdef DEBUG_ADDRBOOK
+       addrclip_list_show( _clipBoard_, stdout );
+#endif
 }
 
 /**
@@ -2364,11 +2385,36 @@ static void addressbook_mail_to_cb( GtkAction *action, gpointer data ) {
        if( ! addrselect_test_empty( _addressSelect_ ) ) {
                listAddress = addrselect_build_list( _addressSelect_ );
                compose_new_with_list( NULL, listAddress );
-               mgu_free_dlist( listAddress );
+               g_list_free_full( listAddress, g_free );
                listAddress = NULL;
        }
 }
 
+static void addressbook_merge_list( AddrSelectList *list ) {
+       GtkCMCTree *ctree = GTK_CMCTREE(addrbook.ctree);
+       GtkCMCTree *clist = GTK_CMCTREE(addrbook.clist);
+       AddressObject *pobj;
+       AddressDataSource *ds = NULL;
+
+       pobj = gtk_cmctree_node_get_row_data(ctree, addrbook.opened );
+       cm_return_if_fail(pobj != NULL);
+
+       ds = addressbook_find_datasource( addrbook.treeSelected );
+       if( ds == NULL ) return;
+
+       addrmerge_merge(clist, pobj, ds, list);
+}
+
+/**
+ * Merge selected entries in the address list
+ */
+static void addressbook_merge_cb( GtkAction *action, gpointer data ) {
+       if( addrselect_test_empty( _addressSelect_ ) )
+               return;
+
+       addressbook_merge_list( _addressSelect_ );
+}
+
 static void addressbook_list_row_selected( GtkCMCTree *clist,
                                           GtkCMCTreeNode *node,
                                           gint column,
@@ -2435,12 +2481,12 @@ static gboolean addressbook_list_button_pressed(GtkWidget *widget,
                                                gpointer data)
 {
        if( ! event ) return FALSE;
+       if( event->window != GTK_CMCLIST(widget)->clist_window ) return FALSE;
 
        addressbook_list_menu_setup();
 
        if( event->button == 3 ) {
-               gtk_menu_popup( GTK_MENU(addrbook.list_popup), NULL, NULL, NULL, NULL,
-                      event->button, event->time );
+               gtk_menu_popup_at_pointer(GTK_MENU(addrbook.list_popup), NULL);
        } else if (event->button == 1) {
                if (event->type == GDK_2BUTTON_PRESS) {
                        if (prefs_common.add_address_by_click &&
@@ -2492,6 +2538,9 @@ static gboolean addressbook_tree_button_pressed(GtkWidget *ctree,
        if( ! event ) return FALSE;
 /*     if( ! event || event->type != GDK_BUTTON_PRESS) return FALSE;*/
 
+       if( event->window != clist->clist_window )
+               return FALSE;
+
        if (event->button == 1) {
                if (event->type == GDK_2BUTTON_PRESS) {
                        if( gtk_cmclist_get_selection_info( clist, event->x, event->y, &row, &column ) ) {
@@ -2623,16 +2672,15 @@ just_set_sens:
 
        cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Book/EditBook",          canEdit );
        cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Book/DeleteBook",        canDelete );
-       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Address/Cut",           canCut );
-       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Address/Copy",          canCopy );
-       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Address/Paste",         canPaste );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Edit/Cut",           canCut );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Edit/Copy",          canCopy );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Edit/Paste",         canPaste );
 
        addressbook_show_buttons(addrbook.target_compose == NULL, canLookup,
                        addrbook.target_compose != NULL);
 
        if( event->button == 3 )
-               gtk_menu_popup(GTK_MENU(addrbook.tree_popup), NULL, NULL, NULL, NULL,
-                              event->button, event->time);
+               gtk_menu_popup_at_pointer(GTK_MENU(addrbook.tree_popup), NULL);
 
        return FALSE;
 }
@@ -2911,7 +2959,8 @@ static void addressbook_treenode_delete_cb(GtkAction *action, gpointer data)
                                "results and addresses in '%s'?" ),
                                obj->name );
                        aval = alertpanel( _("Delete"), message,
-                               GTK_STOCK_CANCEL, "+"GTK_STOCK_DELETE, NULL );
+                               NULL, _("_Cancel"), "edit-delete", _("D_elete"), NULL, NULL,
+                               ALERTFOCUS_SECOND );
                        g_free(message);
                        if( aval == G_ALERTALTERNATE ) {
                                delType = ADDRTREE_DEL_FOLDER_ADDR;
@@ -2923,7 +2972,8 @@ static void addressbook_treenode_delete_cb(GtkAction *action, gpointer data)
                                     "If you delete the folder only, the addresses it contains will be moved into the parent folder." ),
                                 obj->name );
                        aval = alertpanel( _("Delete folder"), message,
-                               GTK_STOCK_CANCEL, g_strconcat("+",_("Delete _folder only"), NULL), _("Delete folder and _addresses"));
+                               NULL, _("_Cancel"), "edit-delete", _("Delete _folder only"),
+                               "edit-delete", _("Delete folder and _addresses"), ALERTFOCUS_SECOND);
                        g_free(message);
                        if( aval == G_ALERTALTERNATE ) {
                                delType = ADDRTREE_DEL_FOLDER_ONLY;
@@ -2936,15 +2986,15 @@ static void addressbook_treenode_delete_cb(GtkAction *action, gpointer data)
        else if( obj->type == ADDR_ITEM_GROUP ) {
                message = g_strdup_printf(_("Do you want to delete '%s'?\n"
                                            "The addresses it contains will not be lost."), obj->name);
-               aval = alertpanel(_("Delete"), message, GTK_STOCK_CANCEL, 
-                               "+" GTK_STOCK_DELETE, NULL);
+               aval = alertpanel(_("Delete"), message, NULL, _("_Cancel"),
+                               "edit-delete", _("D_elete"), NULL, NULL, ALERTFOCUS_SECOND);
                g_free(message);
                if( aval == G_ALERTALTERNATE ) delType = ADDRTREE_DEL_FOLDER_ONLY;
        } else {
                message = g_strdup_printf(_("Do you want to delete '%s'?\n"
                                            "The addresses it contains will be lost."), obj->name);
-               aval = alertpanel(_("Delete"), message, GTK_STOCK_CANCEL, 
-                               "+" GTK_STOCK_DELETE, NULL);
+               aval = alertpanel(_("Delete"), message, NULL, _("_Cancel"),
+                               "edit-delete", _("D_elete"), NULL, NULL, ALERTFOCUS_SECOND);
                g_free(message);
                if( aval == G_ALERTALTERNATE ) delType = ADDRTREE_DEL_DATA;
        }
@@ -3110,7 +3160,7 @@ static ItemFolder * addressbook_setup_subf(
                GList *cur = children;
                for (; cur; cur = cur->next) {
                        ItemFolder *child = (ItemFolder *) cur->data;
-                       if (!strcmp2(ADDRITEM_NAME(child), title)) {
+                       if (!g_strcmp0(ADDRITEM_NAME(child), title)) {
                                nNode = gtk_cmctree_find_by_row_data_custom(
                                        ctree, NULL, child,
                                        addressbook_treenode_find_folder_cb );
@@ -3212,7 +3262,8 @@ static void addressbook_new_address_cb( GtkAction *action, gpointer data ) {
                                if (server->retVal != LDAPRC_SUCCESS) {
                                        alertpanel( _("Add address(es)"),
                                                addressbook_err2string(_lutErrorsLDAP_, server->retVal),
-                                               GTK_STOCK_CLOSE, NULL, NULL );
+                                               "window-close", _("_Close"), NULL, NULL, NULL, NULL,
+                                               ALERTFOCUS_FIRST );
                                        server->retVal = LDAPRC_SUCCESS;
                                        return;
                                }
@@ -3263,7 +3314,7 @@ static void addressbook_new_address_cb( GtkAction *action, gpointer data ) {
                        if (server->retVal != LDAPRC_SUCCESS) {
                                alertpanel( _("Add address(es)"),
                                                addressbook_err2string(_lutErrorsLDAP_, server->retVal),
-                                       GTK_STOCK_CLOSE, NULL, NULL );
+                                       "window-close", _("_Close"), NULL, NULL, NULL, NULL, ALERTFOCUS_FIRST );
                                return;
                        }
                }
@@ -3357,7 +3408,7 @@ static void addressbook_edit_address_post_cb( ItemPerson *person )
                AddressBookFile *abf = addressbook_get_book_file();
 
                if (abf && abf->type == ADBOOKTYPE_LDAP) {
-                       if (strcmp2(person->nickName, ADDRITEM_NAME(person)))
+                       if (g_strcmp0(person->nickName, ADDRITEM_NAME(person)))
                                addritem_person_set_nick_name( person, ADDRITEM_NAME(person));
                }
 #endif
@@ -3378,9 +3429,9 @@ void addressbook_address_list_set_focus( void )
 void addressbook_address_list_disable_some_actions(void)
 {
        /* disable address copy/pasting when editing contact's detail (embedded form) */
-       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Address/Cut",   FALSE );
-       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Address/Copy",  FALSE );
-       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Address/Paste", FALSE );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Edit/Cut",   FALSE );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Edit/Copy",  FALSE );
+       cm_menu_set_sensitive_full( addrbook.ui_manager, "Menu/Edit/Paste", FALSE );
 }
 
 static void addressbook_edit_address_cb( GtkAction *action, gpointer data ) {
@@ -3593,10 +3644,12 @@ gchar *addressbook_set_col_name_guard(gchar *value)
 {
        gchar *ret = "<not set>";
        gchar *tmp = g_strdup(value);
-       g_strstrip(tmp);
-       if (tmp !=NULL && *tmp != '\0')
-               ret = value;
-       g_free(tmp);
+       if (tmp) {
+               g_strstrip(tmp);
+               if (*tmp != '\0')
+                       ret = value;
+               g_free(tmp);
+       }
        return ret;
 }
 
@@ -3690,7 +3743,7 @@ static void addressbook_folder_load_one_person(
 }
 
 static void addressbook_folder_load_person( GtkCMCTree *clist, ItemFolder *itemFolder ) {
-       GList *items;
+       GList *items, *cur;
        AddressTypeControlItem *atci = addrbookctl_lookup( ADDR_ITEM_PERSON );
        AddressTypeControlItem *atciMail = addrbookctl_lookup( ADDR_ITEM_EMAIL );
        const gchar *search_str;
@@ -3702,12 +3755,12 @@ static void addressbook_folder_load_person( GtkCMCTree *clist, ItemFolder *itemF
 
        /* Load email addresses */
        items = addritem_folder_get_person_list( itemFolder );
-       for( ; items != NULL; items = g_list_next( items ) ) {
+       for(cur = items ; cur != NULL; cur = g_list_next( cur ) ) {
                ItemPerson *person;
                GList *node;
                ItemEMail *email;
 
-               person = (ItemPerson *)items->data;
+               person = (ItemPerson *)cur->data;
                if (!person)
                        continue;
                node = person->listEMail;
@@ -3720,10 +3773,9 @@ static void addressbook_folder_load_person( GtkCMCTree *clist, ItemFolder *itemF
                                continue;
                }
 
-               addressbook_folder_load_one_person( clist, items->data, atci, atciMail );
+               addressbook_folder_load_one_person( clist, cur->data, atci, atciMail );
        }
        /* Free up the list */
-       mgu_clear_list( items );
        g_list_free( items );
 }
 
@@ -3737,7 +3789,7 @@ static void addressbook_folder_remove_node( GtkCMCTree *clist, GtkCMCTreeNode *n
                addrbook.treeSelected );
 }
 
-static void addressbook_folder_refresh_one_person( GtkCMCTree *clist, ItemPerson *person ) {
+void addressbook_folder_refresh_one_person( GtkCMCTree *clist, ItemPerson *person ) {
        AddressTypeControlItem *atci = addrbookctl_lookup( ADDR_ITEM_PERSON );
        AddressTypeControlItem *atciMail = addrbookctl_lookup( ADDR_ITEM_EMAIL );
        GtkCMCTreeNode *node;
@@ -3759,7 +3811,7 @@ static void addressbook_folder_refresh_one_person( GtkCMCTree *clist, ItemPerson
        }
 }
 
-static void addressbook_folder_remove_one_person( GtkCMCTree *clist, ItemPerson *person ) {
+void addressbook_folder_remove_one_person( GtkCMCTree *clist, ItemPerson *person ) {
        GtkCMCTreeNode *node;
        
        if( person == NULL ) return;
@@ -3801,7 +3853,6 @@ static void addressbook_folder_load_group( GtkCMCTree *clist, ItemFolder *itemFo
                gtk_sctree_sort_node(clist, NULL);
        }
        /* Free up the list */
-       mgu_clear_list( items );
        g_list_free( items );
 }
 
@@ -4129,17 +4180,16 @@ static gboolean addressbook_convert( AddressIndex *addrIndex ) {
                        }
                }
        }
-       if( errFlag ) {
+       if (errFlag) {
                debug_print( "Error\n%s\n", msg );
                alertpanel_full(_("Addressbook conversion error"), msg,
-                               GTK_STOCK_CLOSE, NULL, NULL, FALSE,
-                               NULL, ALERT_ERROR, G_ALERTDEFAULT);
-       }
-       else if( msg ) {
+                               "window-close", _("_Close"), NULL, NULL, NULL, NULL,
+                               ALERTFOCUS_FIRST, FALSE, NULL, ALERT_ERROR);
+       } else if (msg) {
                debug_print( "Warning\n%s\n", msg );
                alertpanel_full(_("Addressbook conversion error"), msg,
-                               GTK_STOCK_CLOSE, NULL, NULL, FALSE,
-                               NULL, ALERT_WARNING, G_ALERTDEFAULT);
+                               "window-close", _("_Close"), NULL, NULL, NULL, NULL,
+                               ALERTFOCUS_FIRST, FALSE, NULL, ALERT_WARNING);
        }
 
        return retVal;
@@ -4206,10 +4256,11 @@ static gboolean migrate_addrbook(const gchar *origdir, const gchar *destdir)
 void addressbook_read_file( void ) {
        AddressIndex *addrIndex = NULL;
        gchar *indexdir = g_strconcat(get_rc_dir(), G_DIR_SEPARATOR_S, ADDRBOOK_DIR, NULL);
-       
+
        debug_print( "Reading address index...\n" );
        if( _addressIndex_ ) {
                debug_print( "address book already read!!!\n" );
+               g_free(indexdir);
                return;
        }
 
@@ -4221,7 +4272,7 @@ void addressbook_read_file( void ) {
        if ( !is_dir_exist(indexdir) ) {
                if ( make_dir(indexdir) < 0 ) {
                        addrindex_set_file_path( addrIndex, get_rc_dir() );
-                       g_warning( "couldn't create dir '%s'", indexdir);
+                       g_warning("couldn't create dir '%s'", indexdir);
                } else {
                        if (!migrate_addrbook(get_rc_dir(), indexdir)) {
                                remove_dir_recursive(indexdir);
@@ -4253,8 +4304,8 @@ void addressbook_read_file( void ) {
                addrindex_print_index( addrIndex, stdout );
                alertpanel_full(_("Addressbook Error"),
                                _("Could not read address index"),
-                               GTK_STOCK_CLOSE, NULL, NULL, FALSE,
-                               NULL, ALERT_ERROR, G_ALERTDEFAULT);
+                               "window-close", _("_Close"), NULL, NULL, NULL, NULL,
+                               ALERTFOCUS_FIRST, FALSE, NULL, ALERT_ERROR);
        }
        debug_print( "done.\n" );
 }
@@ -4364,7 +4415,6 @@ static GtkCMCTreeNode *addressbook_node_add_folder(
 {
        GtkCMCTree *ctree = GTK_CMCTREE(addrbook.ctree);
        GtkCMCTreeNode *newNode = NULL;
-       AdapterFolder *adapter;
        AddressTypeControlItem *atci = NULL;
        GList *listItems = NULL;
        gchar *name;
@@ -4389,7 +4439,7 @@ static GtkCMCTreeNode *addressbook_node_add_folder(
                newNode = node;
        }
        else {
-               adapter = g_new0( AdapterFolder, 1 );
+               AdapterFolder *adapter = g_new0( AdapterFolder, 1 );
                ADDRESS_OBJECT_TYPE(adapter) = ADDR_ITEM_FOLDER;
                ADDRESS_OBJECT_NAME(adapter) = g_strdup( ADDRITEM_NAME(itemFolder) );
                adapter->itemFolder = itemFolder;
@@ -4401,6 +4451,8 @@ static GtkCMCTreeNode *addressbook_node_add_folder(
                if( newNode ) {
                        gtk_cmctree_node_set_row_data_full( ctree, newNode, adapter,
                                addressbook_free_treenode );
+               } else {
+                       addrbookctl_free_folder(adapter);
                }
        }
 
@@ -4693,6 +4745,10 @@ static void addressbook_lup_clicked( GtkButton *button, gpointer data ) {
        AddressInterface *iface;
        gchar *searchTerm;
        GtkCMCTreeNode *node, *parentNode;
+#ifdef USE_LDAP
+       LdapServer *ldap_server;
+       LdapControl *ldap_ctl;
+#endif
 
        node = addrbook.treeSelected;
        if( ! node ) return;
@@ -4718,6 +4774,23 @@ static void addressbook_lup_clicked( GtkButton *button, gpointer data ) {
        if( ! iface->haveLibrary ) return;
        if( ! iface->externalQuery ) return;
 
+#ifdef USE_LDAP
+       if (iface->type == ADDR_IF_LDAP) {
+               ldap_server = ds->rawDataSource;
+               ldap_ctl = ldap_server->control;
+               if (ldap_ctl != NULL &&
+                               ldap_ctl->bindDN != NULL && strlen(ldap_ctl->bindDN) > 0) {
+#ifndef PASSWORD_CRYPTO_OLD
+                       /* LDAP server is password-protected. */
+                       if (primary_passphrase() == NULL) {
+                               /* User did not enter primary passphrase, do not start a search. */
+                               return;
+                       }
+#endif /* PASSWORD_CRYPTO_OLD */
+               }
+       }
+#endif /* USE_LDAP */
+
        searchTerm =
                gtk_editable_get_chars( GTK_EDITABLE(addrbook.entry), 0, -1 );
        g_strchomp( searchTerm );
@@ -5178,7 +5251,6 @@ static void addrbookctl_build_ifselect( void ) {
        g_free( selectStr );
 
        /* Replace existing list */
-       mgu_clear_list( _addressIFaceSelection_ );
        g_list_free( _addressIFaceSelection_ );
        _addressIFaceSelection_ = newList;
        newList = NULL;
@@ -5629,8 +5701,9 @@ static void addressbook_start_drag(GtkWidget *widget, gint button,
        if (addressbook_target_list == NULL)
                addressbook_target_list = gtk_target_list_new(
                                addressbook_drag_types, 1);
-       context = gtk_drag_begin(widget, addressbook_target_list,
-                                GDK_ACTION_MOVE|GDK_ACTION_COPY|GDK_ACTION_DEFAULT, button, event);
+       context = gtk_drag_begin_with_coordinates(widget, addressbook_target_list,
+                                GDK_ACTION_MOVE|GDK_ACTION_COPY|GDK_ACTION_DEFAULT, button, event,
+                                -1, -1);
        gtk_drag_set_icon_default(context);
 }
 
@@ -5711,16 +5784,16 @@ static gboolean addressbook_drag_motion_cb(GtkWidget      *widget,
 
                if (y > height - 24 && height + vpos < total_height) {
                        gtk_adjustment_set_value(pos, (vpos+5 > height ? height : vpos+5));
-                       gtk_adjustment_changed(pos);
                }
                if (y < 24 && y > 0) {
                        gtk_adjustment_set_value(pos, (vpos-5 < 0 ? 0 : vpos-5));
-                       gtk_adjustment_changed(pos);
                }
                node = gtk_cmctree_node_nth(GTK_CMCTREE(widget), row);
 
                if (node != NULL) {
                        AddressObject *obj = gtk_cmctree_node_get_row_data(GTK_CMCTREE(widget), node );
+                       if (obj == NULL)
+                               return FALSE;
                        if( obj->type == ADDR_ITEM_FOLDER 
                        || obj->type == ADDR_ITEM_GROUP)
                                acceptable = TRUE;
@@ -5728,7 +5801,6 @@ static gboolean addressbook_drag_motion_cb(GtkWidget      *widget,
                                AdapterDSource *ads = NULL;
                                AddressDataSource *ds = NULL;
                                ads = ADAPTER_DSOURCE(obj);
-                               if (ads == NULL ){ return FALSE;}
                                ds = ads->dataSource;
                                if (ds == NULL ) { return FALSE;}