fix bug 4239, 'Preferences: Text Options Header Display modal is not modal' (sic)
[claws.git] / src / addressadd.c
index 368ceea21dfc7897b8456f3bd443b95db07953bd..f2b985c232c768b2d708ff74a5dab128f37706ed 100644 (file)
@@ -1,6 +1,6 @@
 /*
  * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 2001-2007 Match Grun and the Claws Mail team
+ * Copyright (C) 2001-2012 Match Grun and the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -23,6 +23,7 @@
 
 #ifdef HAVE_CONFIG_H
 #  include "config.h"
+#include "claws-features.h"
 #endif
 
 #include "defs.h"
 #include <glib.h>
 #include <glib/gi18n.h>
 #include <gdk/gdkkeysyms.h>
-#include <gtk/gtkwindow.h>
-#include <gtk/gtksignal.h>
-#include <gtk/gtkhbox.h>
-#include <gtk/gtklabel.h>
-#include <gtk/gtkentry.h>
-#include <gtk/gtkhbbox.h>
-#include <gtk/gtkbutton.h>
+#include <gtk/gtk.h>
 
 #include "gtkutils.h"
 #include "stock_pixmap.h"
 #include "prefs_common.h"
 #include "prefs_gtk.h"
 #include "addressadd.h"
-#include "addritem.h"
-#include "addrbook.h"
-#include "addrindex.h"
+#ifndef USE_ALT_ADDRBOOK
+       #include "addritem.h"
+       #include "addrbook.h"
+       #include "addrindex.h"
+       #include "ldapserver.h"
+       #include "ldapupdate.h"
+#else
+       #include "addressbook-dbus.h"
+#endif
 #include "manage_window.h"
-#include "ldapserver.h"
-#include "ldapupdate.h"
 #include "alertpanel.h"
 
+#ifndef USE_ALT_ADDRBOOK
 typedef struct {
        AddressBookFile *book;
        ItemFolder      *folder;
 } FolderInfo;
+#else
+typedef struct {
+    gchar* book;
+} FolderInfo;
+#endif
 
 static struct _AddressAdd_dlg {
        GtkWidget *window;
@@ -68,13 +73,19 @@ static struct _AddressAdd_dlg {
        FolderInfo *fiSelected;
 } addressadd_dlg;
 
-static GdkPixmap *folderXpm;
-static GdkBitmap *folderXpmMask;
-static GdkPixmap *bookXpm;
-static GdkBitmap *bookXpmMask;
+static GdkPixbuf *folderXpm;
+static GdkPixbuf *bookXpm;
 
 static gboolean addressadd_cancelled;
 
+enum {
+       ADDRADD_COL_ICON,
+       ADDRADD_COL_NAME,
+       ADDRADD_COL_PTR,
+       N_ADDRADD_COLS
+};
+
+#ifndef USE_ALT_ADDRBOOK
 static FolderInfo *addressadd_create_folderinfo( AddressBookFile *abf, ItemFolder *folder )
 {
        FolderInfo *fi = g_new0( FolderInfo, 1 );
@@ -82,12 +93,26 @@ static FolderInfo *addressadd_create_folderinfo( AddressBookFile *abf, ItemFolde
        fi->folder = folder;
        return fi;
 }
+#else
+static FolderInfo *addressadd_create_folderinfo(gchar* book) {
+       FolderInfo *fi = g_new0( FolderInfo, 1 );
+       fi->book = book;
+       return fi;
+}
+#endif
 
+#ifndef USE_ALT_ADDRBOOK
 static void addressadd_free_folderinfo( FolderInfo *fi ) {
        fi->book   = NULL;
        fi->folder = NULL;
        g_free( fi );
 }
+#else
+static void addressadd_free_folderinfo( FolderInfo *fi ) {
+       fi->book   = NULL;
+       g_free( fi );
+}
+#endif
 
 static gint addressadd_delete_event( GtkWidget *widget, GdkEventAny *event, gboolean *cancelled ) {
        addressadd_cancelled = TRUE;
@@ -96,47 +121,44 @@ static gint addressadd_delete_event( GtkWidget *widget, GdkEventAny *event, gboo
 }
 
 static gboolean addressadd_key_pressed( GtkWidget *widget, GdkEventKey *event, gboolean *cancelled ) {
-       if (event && event->keyval == GDK_Escape) {
+       if (event && event->keyval == GDK_KEY_Escape) {
                addressadd_cancelled = TRUE;
                gtk_main_quit();
        }
        return FALSE;
 }
 
+/* Points addressadd_dlg.fiSelected to the selected item */
+static void set_selected_ptr()
+{
+       addressadd_dlg.fiSelected = gtkut_tree_view_get_selected_pointer(
+                       GTK_TREE_VIEW(addressadd_dlg.tree_folder), ADDRADD_COL_PTR,
+                       NULL, NULL, NULL);
+}
+
 static void addressadd_ok( GtkWidget *widget, gboolean *cancelled ) {
+       set_selected_ptr();
        addressadd_cancelled = FALSE;
        gtk_main_quit();
 }
 
 static void addressadd_cancel( GtkWidget *widget, gboolean *cancelled ) {
+       set_selected_ptr();
        addressadd_cancelled = TRUE;
        gtk_main_quit();
 }
 
-static void addressadd_folder_select( GtkCMCTree *ctree, GtkCMCTreeNode *node,
-                                     gint column, gpointer data )
+static void addressadd_tree_row_activated(GtkTreeView *view,
+               GtkTreePath *path, GtkTreeViewColumn *col,
+               gpointer user_data)
 {
-       addressadd_dlg.fiSelected = gtk_cmctree_node_get_row_data( ctree, node );
-}
-
-static gboolean addressadd_tree_button( GtkCMCTree *ctree, GdkEventButton *event, gpointer data ) {
-       if( ! event )
-               return FALSE;
-       if( event->button == 1 ) {
-               /* Handle double click */
-               if( event->type == GDK_2BUTTON_PRESS ) {
-                       addressadd_cancelled = FALSE;
-                       gtk_main_quit();
-               }
-       }
-
-       return FALSE;
+       addressadd_ok(NULL, NULL);
 }
 
 static void addressadd_size_allocate_cb(GtkWidget *widget,
                                         GtkAllocation *allocation)
 {
-       g_return_if_fail(allocation != NULL);
+       cm_return_if_fail(allocation != NULL);
 
        prefs_common.addressaddwin_width = allocation->width;
        prefs_common.addressaddwin_height = allocation->height;
@@ -160,13 +182,16 @@ static void addressadd_create( void ) {
        GtkWidget *cancel_btn;
        gint top;
        static GdkGeometry geometry;
-       gchar *titles[1];
+       GtkTreeStore *store;
+       GtkTreeViewColumn *col;
+       GtkCellRenderer *rdr;
+       GtkTreeSelection *sel;
 
        window = gtkut_window_new(GTK_WINDOW_TOPLEVEL, "addressadd");
        gtk_container_set_border_width( GTK_CONTAINER(window), VBOX_BORDER );
        gtk_window_set_title( GTK_WINDOW(window), _("Add to address book") );
        gtk_window_set_position( GTK_WINDOW(window), GTK_WIN_POS_MOUSE );
-       gtk_window_set_modal( GTK_WINDOW(window), TRUE );
+       gtk_window_set_type_hint(GTK_WINDOW(window), GDK_WINDOW_TYPE_HINT_DIALOG);
        g_signal_connect( G_OBJECT(window), "delete_event",
                          G_CALLBACK(addressadd_delete_event), NULL );
        g_signal_connect( G_OBJECT(window), "key_press_event",
@@ -237,24 +262,38 @@ static void addressadd_create( void ) {
                                        GTK_POLICY_AUTOMATIC );
        gtk_box_pack_start( GTK_BOX(vlbox), tree_win, TRUE, TRUE, 0 );
 
-       titles[0] = _( "Select Address Book Folder") ;
+       store = gtk_tree_store_new(N_ADDRADD_COLS,
+                       GDK_TYPE_PIXBUF, G_TYPE_STRING, G_TYPE_POINTER);
+
+       tree_folder = gtk_tree_view_new_with_model(GTK_TREE_MODEL(store));
+       g_object_unref(store);
+       gtk_tree_view_set_headers_visible(GTK_TREE_VIEW(tree_folder), TRUE);
+       gtk_tree_view_set_enable_tree_lines(GTK_TREE_VIEW(tree_folder), FALSE);
+       gtk_tree_view_set_search_column(GTK_TREE_VIEW(tree_folder),
+                       ADDRADD_COL_NAME);
+
+       /* Column with addressbook/folder icon and name. It has two
+        * renderers, so we create it a bit differently. */
+       col = gtk_tree_view_column_new();
+       rdr = gtk_cell_renderer_pixbuf_new();
+       gtk_cell_renderer_set_padding(rdr, 0, 0);
+       gtk_tree_view_column_pack_start(col, rdr, FALSE);
+       gtk_tree_view_column_set_attributes(col, rdr,
+                       "pixbuf", ADDRADD_COL_ICON, NULL);
+       rdr = gtk_cell_renderer_text_new();
+       gtk_tree_view_column_pack_start(col, rdr, TRUE);
+       gtk_tree_view_column_set_attributes(col, rdr,
+                       "markup", ADDRADD_COL_NAME, NULL);
+       gtk_tree_view_column_set_title(col, _("Select Address Book Folder"));
+       gtk_tree_view_append_column(GTK_TREE_VIEW(tree_folder), col);
+
+       sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(tree_folder));
+       gtk_tree_selection_set_mode(sel, GTK_SELECTION_BROWSE);
 
-       tree_folder = gtk_sctree_new_with_titles( 1, 0, titles );
        gtk_container_add( GTK_CONTAINER(tree_win), tree_folder );
-       gtk_cmclist_column_titles_show( GTK_CMCLIST(tree_folder) );
-       if (prefs_common.enable_dotted_lines) {
-               gtk_cmctree_set_line_style(GTK_CMCTREE(tree_folder), GTK_CMCTREE_LINES_DOTTED);
-               gtk_cmctree_set_expander_style(GTK_CMCTREE(tree_folder),
-                                    GTK_CMCTREE_EXPANDER_SQUARE);
-       } else {
-               gtk_cmctree_set_line_style(GTK_CMCTREE(tree_folder), GTK_CMCTREE_LINES_NONE);
-               gtk_cmctree_set_expander_style(GTK_CMCTREE(tree_folder),
-                                    GTK_CMCTREE_EXPANDER_TRIANGLE);
-       }
-       gtk_sctree_set_stripes(GTK_SCTREE(tree_folder), prefs_common.use_stripes_everywhere);
-       gtk_cmclist_set_selection_mode( GTK_CMCLIST(tree_folder), GTK_SELECTION_BROWSE );
-       gtk_cmctree_set_indent( GTK_CMCTREE(tree_folder), CTREE_INDENT );
-       gtk_cmclist_set_auto_sort( GTK_CMCLIST(tree_folder), TRUE );
+
+       g_signal_connect(G_OBJECT(tree_folder), "row-activated",
+                       G_CALLBACK(addressadd_tree_row_activated), NULL);
 
        /* Button panel */
        gtkut_stock_button_set_create(&hbbox, &cancel_btn, GTK_STOCK_CANCEL,
@@ -268,10 +307,6 @@ static void addressadd_create( void ) {
                         G_CALLBACK(addressadd_ok), NULL);
        g_signal_connect(G_OBJECT(cancel_btn), "clicked",
                         G_CALLBACK(addressadd_cancel), NULL);
-       g_signal_connect(G_OBJECT(tree_folder), "tree_select_row",
-                        G_CALLBACK(addressadd_folder_select), NULL);
-       g_signal_connect(G_OBJECT(tree_folder), "button_press_event",
-                        G_CALLBACK(addressadd_tree_button), NULL);
 
        if (!geometry.min_height) {
                geometry.min_width = 300;
@@ -294,35 +329,65 @@ static void addressadd_create( void ) {
 
        gtk_widget_show_all( window );
 
-       stock_pixmap_gdk( window, STOCK_PIXMAP_BOOK, &bookXpm, &bookXpmMask );
-       stock_pixmap_gdk( window, STOCK_PIXMAP_DIR_OPEN,
-                         &folderXpm, &folderXpmMask );
+       stock_pixbuf_gdk(STOCK_PIXMAP_BOOK, &bookXpm );
+       stock_pixbuf_gdk(STOCK_PIXMAP_DIR_OPEN, &folderXpm );
+}
+
+/* Helper function used by addressadd_tree_clear(). */
+static gboolean close_dialog_foreach_func(GtkTreeModel *model,
+               GtkTreePath *path,
+               GtkTreeIter *iter,
+               gpointer user_data)
+{
+       FolderInfo *fi;
+
+       gtk_tree_model_get(model, iter, ADDRADD_COL_PTR, &fi, -1);
+       if (fi != NULL) {
+               addressadd_free_folderinfo(fi);
+       }
+       gtk_tree_store_set(GTK_TREE_STORE(model), iter, ADDRADD_COL_PTR, NULL, -1);
+       return FALSE;
 }
 
-static void addressadd_load_folder( GtkCMCTreeNode *parentNode, ItemFolder *parentFolder,
-                                       FolderInfo *fiParent )
+/* Function to remove all rows from the tree view, and free the
+ * FolderInfo pointers in them in pointer column. */
+static void addressadd_tree_clear()
 {
-       GtkCMCTree *tree = GTK_CMCTREE( addressadd_dlg.tree_folder );
+       GtkWidget *view = addressadd_dlg.tree_folder;
+       GtkTreeModel *model = gtk_tree_view_get_model(GTK_TREE_VIEW(view));
+
+       gtk_tree_model_foreach(model, close_dialog_foreach_func, NULL);
+       gtk_tree_store_clear(GTK_TREE_STORE(model));
+}
+
+#ifndef USE_ALT_ADDRBOOK
+static void addressadd_load_folder( GtkTreeIter *parent_iter,
+               ItemFolder *parentFolder, FolderInfo *fiParent )
+{
+       GtkWidget *view = addressadd_dlg.tree_folder;
+       GtkTreeIter iter;
+       GtkTreeModel *model = gtk_tree_view_get_model(GTK_TREE_VIEW(view));
        GList *list;
        ItemFolder *folder;
-       gchar *fName;
-       gchar **name;
-       GtkCMCTreeNode *node;
+       gchar *name;
        FolderInfo *fi;
 
        list = parentFolder->listFolder;
        while( list ) {
                folder = list->data;
-               fName = g_strdup( ADDRITEM_NAME(folder) );
-               name = &fName;
-               node = gtk_sctree_insert_node( tree, parentNode, NULL, name, FOLDER_SPACING,
-                               folderXpm, folderXpmMask, folderXpm, folderXpmMask,
-                               FALSE, TRUE );
-               g_free( fName );
+               name = g_strdup( ADDRITEM_NAME(folder) );
                fi = addressadd_create_folderinfo( fiParent->book, folder );
-               gtk_cmctree_node_set_row_data_full( tree, node, fi,
-                               ( GtkDestroyNotify ) addressadd_free_folderinfo );
-               addressadd_load_folder( node, folder, fi );
+
+               gtk_tree_store_append(GTK_TREE_STORE(model), &iter, parent_iter);
+               gtk_tree_store_set(GTK_TREE_STORE(model), &iter,
+                               ADDRADD_COL_ICON, folderXpm,
+                               ADDRADD_COL_NAME, name,
+                               ADDRADD_COL_PTR, fi,
+                               -1);
+               g_free( name );
+
+               addressadd_load_folder( parent_iter, folder, fi );
+
                list = g_list_next( list );
        }
 }
@@ -330,24 +395,26 @@ static void addressadd_load_folder( GtkCMCTreeNode *parentNode, ItemFolder *pare
 static void addressadd_load_data( AddressIndex *addrIndex ) {
        AddressDataSource *ds;
        GList *list, *nodeDS;
-       gchar **name;
-       gchar *dsName;
+       gchar *name;
        ItemFolder *rootFolder;
        AddressBookFile *abf;
        FolderInfo *fi;
-       GtkCMCTree *tree = GTK_CMCTREE( addressadd_dlg.tree_folder );
-       GtkCMCTreeNode *node;
+       GtkWidget *view = addressadd_dlg.tree_folder;
+       GtkTreeIter iter;
+       GtkTreeModel *model = gtk_tree_view_get_model(GTK_TREE_VIEW(view));
+       GtkTreeSelection *sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(view));
+
+       addressadd_tree_clear();
 
-       gtk_cmclist_clear( GTK_CMCLIST( tree ) );
        list = addrindex_get_interface_list( addrIndex );
        while( list ) {
-               AddressInterface *interface = list->data;
-               if( interface->type == ADDR_IF_BOOK || 
-                               interface->type == ADDR_IF_LDAP ) {
-                       nodeDS = interface->listSource;
+               AddressInterface *ainterface = list->data;
+               if( ainterface->type == ADDR_IF_BOOK || 
+                               ainterface->type == ADDR_IF_LDAP ) {
+                       nodeDS = ainterface->listSource;
                        while( nodeDS ) {
                                ds = nodeDS->data;
-                               dsName = g_strdup( addrindex_ds_get_name( ds ) );
+                               name = g_strdup( addrindex_ds_get_name( ds ) );
 
                                /* Read address book */
                                if( ! addrindex_ds_get_read_flag( ds ) ) {
@@ -356,43 +423,84 @@ static void addressadd_load_data( AddressIndex *addrIndex ) {
 
                                /* Add node for address book */
                                abf = ds->rawDataSource;
-                               name = &dsName;
-                               node = gtk_cmctree_insert_node( tree, NULL, NULL,
-                                               name, FOLDER_SPACING, bookXpm,
-                                               bookXpmMask, bookXpm, bookXpmMask,
-                                               FALSE, TRUE );
-                               g_free( dsName );
-
                                fi = addressadd_create_folderinfo( abf, NULL );
-                               gtk_cmctree_node_set_row_data_full( tree, node, fi,
-                                               ( GtkDestroyNotify ) addressadd_free_folderinfo );
+
+                               gtk_tree_store_append(GTK_TREE_STORE(model), &iter, NULL);
+                               gtk_tree_store_set(GTK_TREE_STORE(model), &iter,
+                                               ADDRADD_COL_ICON, bookXpm,
+                                               ADDRADD_COL_NAME, name,
+                                               ADDRADD_COL_PTR, fi,
+                                               -1);
+                               g_free( name );
 
                                rootFolder = addrindex_ds_get_root_folder( ds );
-                               addressadd_load_folder( node, rootFolder, fi );
+                               addressadd_load_folder( &iter, rootFolder, fi );
 
                                nodeDS = g_list_next( nodeDS );
                        }
                }
                list = g_list_next( list );
        }
+
+       if (gtk_tree_model_get_iter_first(model, &iter))
+               gtk_tree_selection_select_iter(sel, &iter);
+}
+#else
+static void addressadd_load_data() {
+       GSList *list;
+       FolderInfo *fi = NULL;
+       GError* error = NULL;
+       GtkWidget *view = addressadd_dlg.tree_folder;
+       GtkTreeIter iter;
+       GtkTreeModel *model = gtk_tree_view_get_model(GTK_TREE_VIEW(view));
+       GtkTreeSelection *sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(view));
+       gchar *name;
+
+       addressadd_tree_clear();
+
+       list = addressbook_dbus_get_books(&error);
+       for (; list; list = g_slist_next(list)) {
+               name = (gchar *) list->data;
+               fi = addressadd_create_folderinfo(name);
+               gtk_tree_store_append(GTK_TREE_STORE(model), &iter, NULL);
+               gtk_tree_store_set(GTK_TREE_STORE(model), &iter,
+                               ADDRADD_COL_ICON, bookXpm,ADDRADD_COL_NAME, (gchar *)list->data,
+                               ADDRADD_COL_PTR, fi,
+                               -1);
+       }
+
+       if (gtk_tree_model_get_iter_first(model, &iter))
+                gtk_tree_selection_select_iter(sel, &iter);
 }
+#endif
 
+#ifndef USE_ALT_ADDRBOOK 
 gboolean addressadd_selection( AddressIndex *addrIndex, const gchar *name, 
                const gchar *address, const gchar *remarks, GdkPixbuf *picture ) {
+#else
+gboolean addressadd_selection(const gchar *name, const gchar *address,
+                                                         const gchar *remarks, GdkPixbuf *picture ) {
+#endif
        gboolean retVal = FALSE;
+#ifndef USE_ALT_ADDRBOOK 
        ItemPerson *person = NULL;
+#endif
        FolderInfo *fi = NULL;
        addressadd_cancelled = FALSE;
 
        if( ! addressadd_dlg.window ) addressadd_create();
-       gtk_widget_grab_focus(addressadd_dlg.ok_btn);
-       gtk_widget_show(addressadd_dlg.window);
-       manage_window_set_transient(GTK_WINDOW(addressadd_dlg.window));
 
        addressadd_dlg.fiSelected = NULL;
+#ifndef USE_ALT_ADDRBOOK
        addressadd_load_data( addrIndex );
-       gtk_cmclist_select_row( GTK_CMCLIST( addressadd_dlg.tree_folder ), 0, 0 );
+#else
+       addressadd_load_data();
+#endif
        gtk_widget_show(addressadd_dlg.window);
+       gtk_window_set_modal(GTK_WINDOW(addressadd_dlg.window), TRUE);
+       gtk_widget_grab_focus(addressadd_dlg.ok_btn);
+
+       manage_window_set_transient(GTK_WINDOW(addressadd_dlg.window));
 
        gtk_entry_set_text( GTK_ENTRY(addressadd_dlg.entry_name ), "" );
        gtk_label_set_text( GTK_LABEL(addressadd_dlg.label_address ), "" );
@@ -411,7 +519,7 @@ gboolean addressadd_selection( AddressIndex *addrIndex, const gchar *name,
        }
        gtk_main();
        gtk_widget_hide( addressadd_dlg.window );
-
+       gtk_window_set_modal(GTK_WINDOW(addressadd_dlg.window), FALSE);
        if( ! addressadd_cancelled ) {
                if( addressadd_dlg.fiSelected ) {
                        gchar *returned_name;
@@ -421,45 +529,87 @@ gboolean addressadd_selection( AddressIndex *addrIndex, const gchar *name,
 
                        fi = addressadd_dlg.fiSelected;
                        
+#ifndef USE_ALT_ADDRBOOK
                        person = addrbook_add_contact( fi->book, fi->folder, 
                                                        returned_name, 
                                                        address, 
                                                        returned_remarks);
-                       person->status = ADD_ENTRY;
-
-                       if (picture) {
-                               GError *error = NULL;
-                               gchar *name = g_strconcat( get_rc_dir(), G_DIR_SEPARATOR_S, ADDRBOOK_DIR, G_DIR_SEPARATOR_S, 
-                                                       ADDRITEM_ID(person), ".png", NULL );
-                               gdk_pixbuf_save(picture, name, "png", &error, NULL);
+                       
+                       if (person != NULL) {
+                               person->status = ADD_ENTRY;
+
+                               if (picture) {
+                                       GError *error = NULL;
+                                       gchar *name = g_strconcat( get_rc_dir(), G_DIR_SEPARATOR_S, ADDRBOOK_DIR, G_DIR_SEPARATOR_S, 
+                                                               ADDRITEM_ID(person), ".png", NULL );
+                                       gdk_pixbuf_save(picture, name, "png", &error, NULL);
+                                       if (error) {
+                                               g_warning("Failed to save image: %s",
+                                                               error->message);
+                                               g_error_free(error);
+                                       }
+                                       addritem_person_set_picture( person, ADDRITEM_ID(person) ) ;
+                                       g_free( name );
+                               }
+                       }
+#else
+                       ContactData* contact = g_new0(ContactData, 1);
+                       GError* error = NULL;
+                       
+                       if (returned_name)
+                               contact->cn = g_strdup(returned_name);
+                       else
+                               contact->cn = g_strdup(address);
+                       
+                       contact->name = g_strdup(returned_name);
+                       contact->email = g_strdup(address);
+                       contact->remarks = g_strdup(returned_remarks);
+                       contact->book = g_strdup(fi->book);
+                       contact->picture = picture;
+                       
+            if (addressbook_dbus_add_contact(contact, &error) == 0) {
+                               debug_print("Added to addressbook:\n%s\n%s\n%s\n%s\n",
+                                                        returned_name, address, returned_remarks, fi->book);
+                               retVal = TRUE;
+                       }
+                       else {
+                               retVal = FALSE;
                                if (error) {
-                                       g_warning(_("Failed to save image: \n%s"),
-                                                       error->message);
+                                       GtkWidget* dialog = gtk_message_dialog_new (
+                                                               GTK_WINDOW(addressadd_dlg.window),
+                                GTK_DIALOG_DESTROY_WITH_PARENT,
+                                GTK_MESSAGE_ERROR,
+                                GTK_BUTTONS_CLOSE,
+                                "%s", error->message);
+                                       gtk_dialog_run (GTK_DIALOG (dialog));
+                                       gtk_widget_destroy (dialog);
                                        g_error_free(error);
                                }
-                               addritem_person_set_picture( person, ADDRITEM_ID(person) ) ;
-                               g_free( name );
                        }
+                       contact_data_free(&contact);
+#endif
 #ifdef USE_LDAP
-                       if (fi->book->type == ADBOOKTYPE_LDAP) {
+                       if (person != NULL && fi->book->type == ADBOOKTYPE_LDAP) {
                                LdapServer *server = (LdapServer *) fi->book;
                                ldapsvr_set_modified(server, TRUE);
                                ldapsvr_update_book(server, person);
                                if (server->retVal != LDAPRC_SUCCESS) {
                                        alertpanel( _("Add address(es)"),
                                                _("Can't add the specified address"),
-                                               GTK_STOCK_CLOSE, NULL, NULL );
+                                               GTK_STOCK_CLOSE, NULL, NULL, ALERTFOCUS_FIRST );
                                        return server->retVal;
                                }
                        }
 #endif
                        g_free(returned_name);
                        g_free(returned_remarks);
+#ifndef USE_ALT_ADDRBOOK
                        if( person ) retVal = TRUE;
+#endif
                }
        }
 
-       gtk_cmclist_clear( GTK_CMCLIST( addressadd_dlg.tree_folder ) );
+       addressadd_tree_clear();
 
        return retVal;
 }