Fix bug #3352, "found_in_addressbook matches entries from GPG keyring"

[claws.git] / src / addr_compl.c

diff --git a/src/addr_compl.c b/src/addr_compl.c
index 21348ab4fa72881047fc5b077bf88343eb11f452..44303a6a2b2fa0f70240a664b3a327b8d6daa31e 100644 (file)
--- a/src/addr_compl.c
+++ b/src/addr_compl.c
@@ -183,7 +183,7 @@ static gint addr_completion_func(const gchar *needle, const gchar *haystack,
  */
 static gint weight_addr_match(const address_entry* addr)
 {
-       gint    n_weight = strlen(addr->name);
+       gint    n_weight = addr->name ? strlen(addr->name): 0;
        gint    a_weight = addr->address ? strlen(addr->address) : n_weight;
        gchar*  match = NULL;
 
@@ -205,7 +205,7 @@ static gint weight_addr_match(const address_entry* addr)
                        else
                                a_weight = match - addr->address;
 
-                       if (strlen(match) < strlen(g_completion_prefix)
+                       if (strlen(match) > strlen(g_completion_prefix)
                         && *(match + strlen(g_completion_prefix)) == '@')
                                a_weight--;
                }
@@ -230,8 +230,8 @@ static gint addr_comparison_func(gconstpointer a, gconstpointer b)
        else if (a_weight > b_weight)
                return 1;
        else {
-           cmp = strcmp(a_ref->name, b_ref->name);
-           return cmp ? cmp :  strcmp(a_ref->address, b_ref->address);
+               cmp = strcmp(a_ref->name, b_ref->name);
+               return cmp ? cmp : g_strcmp0(a_ref->address, b_ref->address);
        }
 }
 
@@ -386,7 +386,9 @@ static void read_address_book(gchar *folderpath) {
        }
 #endif
        /* plugins may hook in here to modify/extend the completion list */
-       hooks_invoke(ADDDRESS_COMPLETION_BUILD_ADDRESS_LIST_HOOKLIST, &g_address_list);
+       if(!folderpath) {
+               hooks_invoke(ADDDRESS_COMPLETION_BUILD_ADDRESS_LIST_HOOKLIST, &g_address_list);
+       }
 
        g_address_list = g_list_reverse(g_address_list);
        g_completion_list = g_list_reverse(g_completion_list);
@@ -950,14 +952,7 @@ static void addrcompl_resize_window( CompletionWindow *cw ) {
        gdk_window_get_geometry( gtk_widget_get_window( cw->window ), &x, &y, &width, &height );
 #endif
 
-       /* simple _hide breaks size requisition !? */
-#if !GTK_CHECK_VERSION(3, 0, 0)
-       gtk_widget_hide_all( cw->window );
-       gtk_widget_show_all( cw->window );
-#else
-       gtk_widget_hide( cw->window );
-       gtk_widget_show( cw->window );
-#endif
+       gtk_widget_queue_resize_no_redraw(cw->list_view);
        gtk_widget_size_request( cw->list_view, &r );
 
        /* Adjust window height to available screen space */
@@ -1595,7 +1590,7 @@ static gboolean completion_window_key_press(GtkWidget *widget,
                        (GTK_TREE_VIEW(list_view),
                         event->keyval == GDK_KEY_Down ||
                         event->keyval == GDK_KEY_Page_Down ? TRUE : FALSE);
-               return FALSE;
+               return TRUE;
        }               
 
        /* make tab move to next field */