2009-09-24 [iwkse] 3.7.2cvs36
[claws.git] / src / action.c
index aaac94031ced0677dc565a7cf1e44fc0666ca39f..42b5c5da88936ca116ee316443f130da278b76a5 100644 (file)
@@ -1,10 +1,10 @@
 /*
  * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2006 Hiroyuki Yamamoto & The Claws Mail Team
+ * Copyright (C) 1999-2009 Hiroyuki Yamamoto & The Claws Mail Team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
+ * the Free Software Foundation; either version 3 of the License, or
  * (at your option) any later version.
  *
  * This program is distributed in the hope that it will be useful,
@@ -13,8 +13,8 @@
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ * 
  */
 
 #ifdef HAVE_CONFIG_H
@@ -106,19 +106,29 @@ struct _ChildInfo
        GSList          *msginfo_list;
 };
 
-static void action_update_menu         (GtkItemFactory *ifactory,
+static void action_update_menu         (GtkUIManager   *ui_manager,
+                                        const gchar    *accel_group,
                                         gchar          *branch_path,
                                         gpointer        callback,
                                         gpointer        data);
-static void compose_actions_execute_cb (Compose        *compose,
+static void compose_actions_execute_cb (GtkWidget      *widget, 
+                                        gpointer        data);
+static void compose_actions_execute    (Compose        *compose,
                                         guint           action_nb,
-                                        GtkWidget      *widget);
-static void mainwin_actions_execute_cb         (MainWindow     *mainwin,
+                                        GtkWidget      *widget);
+
+static void mainwin_actions_execute_cb (GtkWidget      *widget, 
+                                        gpointer        data);
+static void mainwin_actions_execute    (MainWindow     *mainwin,
                                         guint           action_nb,
                                         GtkWidget      *widget);
-static void msgview_actions_execute_cb (MessageView    *msgview,
+
+static void msgview_actions_execute_cb (GtkWidget      *widget, 
+                                        gpointer        data);
+static void msgview_actions_execute    (MessageView    *msgview,
                                         guint           action_nb,
-                                        GtkWidget      *widget);
+                                        GtkWidget      *widget);
+
 static void message_actions_execute    (MessageView    *msgview,
                                         guint           action_nb,
                                         GSList         *msg_list);
@@ -184,10 +194,11 @@ static gchar *get_user_string             (const gchar    *action,
 ActionType action_get_type(const gchar *action_str)
 {
        const gchar *p;
+       gboolean in_filtering_action = FALSE;
        ActionType action_type = ACTION_NONE;
 
-       g_return_val_if_fail(action_str,  ACTION_ERROR);
-       g_return_val_if_fail(*action_str, ACTION_ERROR);
+       cm_return_val_if_fail(action_str,  ACTION_ERROR);
+       cm_return_val_if_fail(*action_str, ACTION_ERROR);
 
        p = action_str;
 
@@ -206,51 +217,60 @@ ActionType action_get_type(const gchar *action_str)
                return ACTION_ERROR;
 
        while (*p && action_type != ACTION_ERROR) {
-               if (p[0] == '%' && p[1]) {
-                       switch (p[1]) {
-                       case 'a':
-                               /* CLAWS: filtering action is a mutually exclusive
-                                * action. we can enable others if needed later. we
-                                * add ACTION_SINGLE | ACTION_MULTIPLE so it will
-                                * only be executed from the main window toolbar */
-                               if (p[2] == 's')  /* source messages */
-                                       action_type = ACTION_FILTERING_ACTION 
-                                                   | ACTION_SINGLE 
-                                                   | ACTION_MULTIPLE;
-                               break;
-                       case 'f':
-                               action_type |= ACTION_SINGLE;
-                               break;
-                       case 'F':
-                               action_type |= ACTION_MULTIPLE;
-                               break;
-                       case 'p':
-                               action_type |= ACTION_SINGLE;
-                               break;
-                       case 's':
-                               action_type |= ACTION_SELECTION_STR;
-                               break;
-                       case 'u':
-                               action_type |= ACTION_USER_STR;
-                               break;
-                       case 'h':
-                               action_type |= ACTION_USER_HIDDEN_STR;
-                               break;
-                       default:
-                               action_type = ACTION_ERROR;
-                               break;
+               if (!in_filtering_action) {
+                       if (p[0] == '%' && p[1]) {
+                               switch (p[1]) {
+                               case 'a':
+                                       /* CLAWS: filtering action is a mutually exclusive
+                                       * action. we can enable others if needed later. we
+                                       * add ACTION_SINGLE | ACTION_MULTIPLE so it will
+                                       * only be executed from the main window toolbar */
+                                       if (p[2] == 's')  /* source messages */
+                                               action_type = ACTION_FILTERING_ACTION 
+                                                               | ACTION_SINGLE 
+                                                               | ACTION_MULTIPLE;
+                                       in_filtering_action = TRUE;
+                                       break;
+                               case 'f':
+                                       action_type |= ACTION_SINGLE;
+                                       break;
+                               case 'F':
+                                       action_type |= ACTION_MULTIPLE;
+                                       break;
+                               case 'p':
+                                       action_type |= ACTION_SINGLE;
+                                       break;
+                               case 's':
+                                       action_type |= ACTION_SELECTION_STR;
+                                       break;
+                               case 'u':
+                                       action_type |= ACTION_USER_STR;
+                                       break;
+                               case 'h':
+                                       action_type |= ACTION_USER_HIDDEN_STR;
+                                       break;
+                               case '%':
+                                       /* literal '%' */
+                                       break;
+                               default:
+                                       action_type = ACTION_ERROR;
+                                       break;
+                               }
+                               p++;
+                       } else if (p[0] == '|') {
+                               if (p[1] == '\0')
+                                       action_type |= ACTION_PIPE_OUT;
+                       } else if (p[0] == '>') {
+                               if (p[1] == '\0')
+                                       action_type |= ACTION_INSERT;
+                       } else if (p[0] == '&') {
+                               if (p[1] == '\0')
+                                       action_type |= ACTION_ASYNC;
+                       } else if (p[0] == '}') {
+                               in_filtering_action = FALSE;
                        }
-               } else if (p[0] == '|') {
-                       if (p[1] == '\0')
-                               action_type |= ACTION_PIPE_OUT;
-               } else if (p[0] == '>') {
-                       if (p[1] == '\0')
-                               action_type |= ACTION_INSERT;
-               } else if (p[0] == '&') {
-                       if (p[1] == '\0')
-                               action_type |= ACTION_ASYNC;
                }
-               p++;
+                       p++;
        }
 
        return action_type;
@@ -321,6 +341,10 @@ static gchar *parse_action_cmd(gchar *action, MsgInfo *msginfo,
                                        g_string_append(cmd, user_hidden_str);
                                p++;
                                break;
+                       case '%':
+                               g_string_append_c(cmd, p[1]);
+                               p++;
+                               break;
                        default:
                                g_string_append_c(cmd, p[0]);
                                g_string_append_c(cmd, p[1]);
@@ -347,7 +371,7 @@ static gboolean parse_append_filename(GString *cmd, MsgInfo *msginfo)
        gchar *p, *q;
        gchar escape_ch[] = "\\ ";
 
-       g_return_val_if_fail(msginfo, FALSE);
+       cm_return_val_if_fail(msginfo, FALSE);
 
        filename = procmsg_get_message_file(msginfo);
 
@@ -400,7 +424,7 @@ static gboolean parse_append_msgpart(GString *cmd, MsgInfo *msginfo,
        g_free(filename);
 
        if (ret < 0) {
-               alertpanel_error(_("Can't get part of multipart message"));
+               alertpanel_error(_("Can't get part of multipart message: %s"), strerror(-ret));
                g_free(part_filename);
                return FALSE;
        }
@@ -418,95 +442,146 @@ void actions_execute(gpointer data,
                     gint source)
 {
        if (source == TOOLBAR_MAIN) 
-               mainwin_actions_execute_cb((MainWindow*)data, action_nb, widget);
+               mainwin_actions_execute((MainWindow*)data, action_nb, widget);
        else if (source == TOOLBAR_COMPOSE)
-               compose_actions_execute_cb((Compose*)data, action_nb, widget);
+               compose_actions_execute((Compose*)data, action_nb, widget);
        else if (source == TOOLBAR_MSGVIEW)
-               msgview_actions_execute_cb((MessageView*)data, action_nb, widget);      
+               msgview_actions_execute((MessageView*)data, action_nb, widget); 
 }
 
-void action_update_mainwin_menu(GtkItemFactory *ifactory,
+void action_update_mainwin_menu(GtkUIManager *ui_manager,
                                gchar *branch_path,
                                MainWindow *mainwin)
 {
-       action_update_menu(ifactory, branch_path,
+       action_update_menu(ui_manager, "<MainwinActions>", branch_path,
                           mainwin_actions_execute_cb, mainwin);
 }
 
-void action_update_msgview_menu(GtkItemFactory *ifactory,
+void action_update_msgview_menu(GtkUIManager   *ui_manager,
                                gchar *branch_path,
                                MessageView *msgview)
 {
-       action_update_menu(ifactory, branch_path,
+       action_update_menu(ui_manager, "<MsgviewActions>", branch_path,
                           msgview_actions_execute_cb, msgview);
 }
 
-void action_update_compose_menu(GtkItemFactory *ifactory
+void action_update_compose_menu(GtkUIManager *ui_manager
                                gchar *branch_path,
                                Compose *compose)
 {
-       action_update_menu(ifactory, branch_path,
+       action_update_menu(ui_manager, "<ComposeActions>", branch_path,
                           compose_actions_execute_cb, compose);
 }
 
-static void action_update_menu(GtkItemFactory *ifactory, 
+static GtkWidget *find_item_in_menu(GtkWidget *menu, gchar *name)
+{
+       GList *amenu = GTK_MENU_SHELL(menu)->children;
+       const gchar *existing_name;
+       while (amenu) {
+               GtkWidget *item = GTK_WIDGET(amenu->data);
+               if ((existing_name = g_object_get_data(G_OBJECT(item), "s_name")) != NULL &&
+                   !strcmp2(name, existing_name))
+                        return item;
+               amenu = amenu->next;
+       }
+       return NULL;
+}
+
+static GtkWidget *create_submenus(GtkWidget *menu, const gchar *action)
+{
+       gchar *submenu = g_strdup(action);
+       GtkWidget *new_menu = NULL;
+       
+       if (strchr(submenu, '/')) {
+               const gchar *end = (strchr(submenu, '/')+1);
+               GtkWidget *menu_item = NULL;
+               if (end && *end) {
+                       *strchr(submenu, '/') = '\0';
+                       if ((menu_item = find_item_in_menu(menu, submenu)) == NULL) {
+                               menu_item = gtk_menu_item_new_with_mnemonic(submenu);
+                               g_object_set_data_full(G_OBJECT(menu_item), "s_name", g_strdup(submenu), g_free);
+                               gtk_widget_show(menu_item);
+                               gtk_menu_shell_append(GTK_MENU_SHELL(menu), menu_item);         
+                               new_menu = gtk_menu_new();
+                               gtk_widget_show(new_menu);
+                               gtk_menu_item_set_submenu(GTK_MENU_ITEM(menu_item), new_menu);
+                       } else {
+                               new_menu = gtk_menu_item_get_submenu(GTK_MENU_ITEM(menu_item));
+                       }
+                       new_menu = create_submenus(new_menu, end);
+               }
+       }
+       g_free(submenu);
+       return new_menu ? new_menu : menu;
+}
+
+static void action_update_menu(GtkUIManager *ui_manager,
+                              const gchar *accel_group,
                               gchar *branch_path,
                               gpointer callback, gpointer data)
 {
-       GtkWidget *menuitem;
-       gchar *menu_path;
        GSList *cur;
        gchar *action, *action_p;
-       GList *amenu;
-       GtkItemFactoryEntry ifentry = {NULL, NULL, NULL, 0, "<Branch>"};
-
-       ifentry.path = branch_path;
-       menuitem = gtk_item_factory_get_widget(ifactory, branch_path);
-       g_return_if_fail(menuitem != NULL);
-
-       amenu = GTK_MENU_SHELL(menuitem)->children;
-       while (amenu != NULL) {
-               GList *alist = amenu->next;
-               gtk_widget_destroy(GTK_WIDGET(amenu->data));
-               amenu = alist;
-       }
-
-       ifentry.accelerator     = NULL;
-       ifentry.callback_action = 0;
-       ifentry.callback        = callback;
-       ifentry.item_type       = NULL;
+       int callback_action = 0;
+       GtkWidget *menu = gtk_menu_new();
+       GtkWidget *item;
 
-       for (cur = prefs_common.actions_list; cur; cur = cur->next) {
+       for (cur = prefs_common.actions_list; cur != NULL; cur = cur->next) {
+               GtkWidget *cur_menu = menu;
+               const gchar *action_name = NULL;
                action   = g_strdup((gchar *)cur->data);
                action_p = strstr(action, ": ");
                if (action_p && action_p[2] &&
                    (action_get_type(&action_p[2]) != ACTION_ERROR) &&
                    (action[0] != '/')) {
+                       gchar *accel_path = NULL;
+
                        action_p[0] = '\0';
-                       menu_path = g_strdup_printf("%s/%s", branch_path,
-                                                   action);
-                       ifentry.path = menu_path;
-                       gtk_item_factory_create_item(ifactory, &ifentry, data,
-                                                    1);
-                       g_free(menu_path);
+                       if (strchr(action, '/')) {
+                               cur_menu = create_submenus(cur_menu, action);
+                               action_name = strrchr(action, '/')+1;
+                       } else {
+                               action_name = action;
+                       }
+                       gtk_menu_set_accel_group (GTK_MENU (cur_menu), 
+                               gtk_ui_manager_get_accel_group(ui_manager));
+                       item = gtk_menu_item_new_with_label(action_name);
+                       gtk_menu_shell_append(GTK_MENU_SHELL(cur_menu), item);
+                       g_signal_connect(G_OBJECT(item), "activate",
+                                        G_CALLBACK(callback), data);
+                       g_object_set_data(G_OBJECT(item), "action_num", GINT_TO_POINTER(callback_action));
+                       gtk_widget_show(item);
+                       accel_path = g_strconcat(accel_group,branch_path, "/", action, NULL);
+                       gtk_menu_item_set_accel_path(GTK_MENU_ITEM(item), accel_path);
+                       g_free(accel_path);
+
                }
                g_free(action);
-               ifentry.callback_action++;
+               callback_action++;
        }
+
+       gtk_widget_show(menu);
+       gtk_menu_item_set_submenu(GTK_MENU_ITEM(gtk_ui_manager_get_widget(ui_manager, branch_path)), menu);
 }
 
-static void compose_actions_execute_cb(Compose *compose, guint action_nb,
-                                      GtkWidget *widget)
+static void compose_actions_execute_cb(GtkWidget *widget, gpointer data)
+{
+       Compose *compose = (Compose *)data;
+       gint action_nb = GPOINTER_TO_INT(g_object_get_data(G_OBJECT(widget), "action_num"));
+       compose_actions_execute(compose, action_nb, NULL);
+}
+
+static void compose_actions_execute(Compose *compose, guint action_nb, GtkWidget *widget)
 {
        gchar *buf, *action;
        ActionType action_type;
 
-       g_return_if_fail(action_nb < g_slist_length(prefs_common.actions_list));
+       cm_return_if_fail(action_nb < g_slist_length(prefs_common.actions_list));
 
        buf = (gchar *)g_slist_nth_data(prefs_common.actions_list, action_nb);
-       g_return_if_fail(buf != NULL);
+       cm_return_if_fail(buf != NULL);
        action = strstr(buf, ": ");
-       g_return_if_fail(action != NULL);
+       cm_return_if_fail(action != NULL);
 
        /* Point to the beginning of the command-line */
        action += 2;
@@ -523,7 +598,14 @@ static void compose_actions_execute_cb(Compose *compose, guint action_nb,
                compose_action_cb, compose);
 }
 
-static void mainwin_actions_execute_cb(MainWindow *mainwin, guint action_nb,
+static void mainwin_actions_execute_cb(GtkWidget *widget, gpointer data)
+{
+       MainWindow *mainwin = (MainWindow *)data;
+       gint action_nb = GPOINTER_TO_INT(g_object_get_data(G_OBJECT(widget), "action_num"));
+       mainwin_actions_execute(mainwin, action_nb, NULL);
+}
+
+static void mainwin_actions_execute(MainWindow *mainwin, guint action_nb,
                                       GtkWidget *widget)
 {
        GSList *msg_list;
@@ -533,7 +615,14 @@ static void mainwin_actions_execute_cb(MainWindow *mainwin, guint action_nb,
        g_slist_free(msg_list);
 }
 
-static void msgview_actions_execute_cb(MessageView *msgview, guint action_nb,
+static void msgview_actions_execute_cb(GtkWidget *widget, gpointer data)
+{
+       MessageView *msgview = (MessageView *)data;
+       gint action_nb = GPOINTER_TO_INT(g_object_get_data(G_OBJECT(widget), "action_num"));
+       msgview_actions_execute(msgview, action_nb, NULL);
+}
+
+static void msgview_actions_execute(MessageView *msgview, guint action_nb,
                                       GtkWidget *widget)
 {
        GSList *msg_list = NULL;
@@ -555,12 +644,12 @@ static void message_actions_execute(MessageView *msgview, guint action_nb,
        guint body_pos = 0;
        ActionType action_type;
        
-       g_return_if_fail(action_nb < g_slist_length(prefs_common.actions_list));
+       cm_return_if_fail(action_nb < g_slist_length(prefs_common.actions_list));
 
        buf = (gchar *)g_slist_nth_data(prefs_common.actions_list, action_nb);
 
-       g_return_if_fail(buf);
-       g_return_if_fail((action = strstr(buf, ": ")));
+       cm_return_if_fail(buf);
+       cm_return_if_fail((action = strstr(buf, ": ")));
 
        /* Point to the beginning of the command-line */
        action += 2;
@@ -607,13 +696,23 @@ static gboolean execute_filtering_actions(gchar *action, GSList *msglist)
        action_string = g_strndup(sbegin, send - sbegin);
        
        action_list = matcher_parser_get_action_list(action_string);
+       if (action_list == NULL) {
+               gchar *tmp = g_strdup(action_string);
+
+               g_strstrip(tmp);
+               if (*tmp == '\0')
+                       alertpanel_error(_("There is no filtering action set"));
+               else
+                       alertpanel_error(_("Invalid filtering action(s):\n%s"), tmp);
+               g_free(action_string);
+               g_free(tmp);
+               return FALSE;
+       }
        g_free(action_string);
-       if (action_list == NULL) return FALSE;
        
        /* apply actions on each message info */
        for (p = msglist; p && p->data; p = g_slist_next(p)) {
                filteringaction_apply_action_list(action_list, (MsgInfo *) p->data);
-               
        }
 
        if (summaryview) {
@@ -658,7 +757,7 @@ static gboolean execute_actions(gchar *action, GSList *msg_list,
        GtkTextIter start_iter, end_iter;
        gboolean is_selection = FALSE;
 
-       g_return_val_if_fail(action && *action, FALSE);
+       cm_return_val_if_fail(action && *action, FALSE);
 
        action_type = action_get_type(action);
 
@@ -797,9 +896,10 @@ static gboolean execute_actions(gchar *action, GSList *msg_list,
                        child_info->callback = callback;
                        child_info->data = data;
                        child_info->tag_status = 
-                               gdk_input_add(child_info->chld_status,
+                               claws_input_add(child_info->chld_status,
                                              GDK_INPUT_READ,
-                                             catch_status, child_info);
+                                             catch_status, child_info,
+                                             FALSE);
                }
 
                create_io_dialog(children);
@@ -830,14 +930,14 @@ static ChildInfo *fork_child(gchar *cmd, const gchar *msg_str,
                                           "Pipe creation failed.\n%s"),
                                        g_strerror(errno));
                        /* Closing fd = -1 fails silently */
-                       close(chld_in[0]);
-                       close(chld_in[1]);
-                       close(chld_out[0]);
-                       close(chld_out[1]);
-                       close(chld_err[0]);
-                       close(chld_err[1]);
-                       close(chld_status[0]);
-                       close(chld_status[1]);
+                       (void)close(chld_in[0]);
+                       (void)close(chld_in[1]);
+                       (void)close(chld_out[0]);
+                       (void)close(chld_out[1]);
+                       (void)close(chld_err[0]);
+                       (void)close(chld_err[1]);
+                       (void)close(chld_status[0]);
+                       (void)close(chld_status[1]);
                        return NULL; /* Pipe error */
                }
        }
@@ -851,7 +951,7 @@ static ChildInfo *fork_child(gchar *cmd, const gchar *msg_str,
                        perror("setpgid");
 
 #ifdef GDK_WINDOWING_X11
-               close(ConnectionNumber(gdk_display));
+               (void)close(ConnectionNumber(gdk_display));
 #endif /* GDK_WINDOWING_X11 */
 
                gch_pid = fork();
@@ -865,21 +965,21 @@ static ChildInfo *fork_child(gchar *cmd, const gchar *msg_str,
                                    (ACTION_PIPE_IN |
                                     ACTION_USER_IN |
                                     ACTION_USER_HIDDEN_IN)) {
-                                       close(fileno(stdin));
-                                       dup  (chld_in[0]);
+                                       (void)close(fileno(stdin));
+                                       (void)dup  (chld_in[0]);
                                }
-                               close(chld_in[0]);
-                               close(chld_in[1]);
-
-                               close(fileno(stdout));
-                               dup  (chld_out[1]);
-                               close(chld_out[0]);
-                               close(chld_out[1]);
-
-                               close(fileno(stderr));
-                               dup  (chld_err[1]);
-                               close(chld_err[0]);
-                               close(chld_err[1]);
+                               (void)close(chld_in[0]);
+                               (void)close(chld_in[1]);
+
+                               (void)close(fileno(stdout));
+                               (void)dup  (chld_out[1]);
+                               (void)close(chld_out[0]);
+                               (void)close(chld_out[1]);
+
+                               (void)close(fileno(stderr));
+                               (void)dup  (chld_err[1]);
+                               (void)close(chld_err[0]);
+                               (void)close(chld_err[1]);
                        }
 
                        cmdline[0] = "sh";
@@ -899,24 +999,24 @@ static ChildInfo *fork_child(gchar *cmd, const gchar *msg_str,
                        _exit(1);
                } else if (gch_pid < (pid_t) 0) { /* Fork error */
                        if (sync)
-                               write(chld_status[1], "1\n", 2);
+                               (void)write(chld_status[1], "1\n", 2);
                        perror("fork");
                        _exit(1);
                } else { /* Child */
                        if (sync) {
-                               close(chld_in[0]);
-                               close(chld_in[1]);
-                               close(chld_out[0]);
-                               close(chld_out[1]);
-                               close(chld_err[0]);
-                               close(chld_err[1]);
-                               close(chld_status[0]);
-
-                               debug_print("Child: Waiting for grandchild\n");
+                               (void)close(chld_in[0]);
+                               (void)close(chld_in[1]);
+                               (void)close(chld_out[0]);
+                               (void)close(chld_out[1]);
+                               (void)close(chld_err[0]);
+                               (void)close(chld_err[1]);
+                               (void)close(chld_status[0]);
+
+                               debug_print("Child: waiting for grandchild\n");
                                waitpid(gch_pid, NULL, 0);
                                debug_print("Child: grandchild ended\n");
-                               write(chld_status[1], "0\n", 2);
-                               close(chld_status[1]);
+                               (void)write(chld_status[1], "0\n", 2);
+                               (void)close(chld_status[1]);
                        }
                        _exit(0);
                }
@@ -934,13 +1034,13 @@ static ChildInfo *fork_child(gchar *cmd, const gchar *msg_str,
                return NULL;
        }
 
-       close(chld_in[0]);
+       (void)close(chld_in[0]);
        if (!(children->action_type &
              (ACTION_PIPE_IN | ACTION_USER_IN | ACTION_USER_HIDDEN_IN)))
-               close(chld_in[1]);
-       close(chld_out[1]);
-       close(chld_err[1]);
-       close(chld_status[1]);
+               (void)close(chld_in[1]);
+       (void)close(chld_out[1]);
+       (void)close(chld_err[1]);
+       (void)close(chld_status[1]);
 
        child_info = g_new0(ChildInfo, 1);
 
@@ -958,10 +1058,10 @@ static ChildInfo *fork_child(gchar *cmd, const gchar *msg_str,
        child_info->chld_err    = chld_err[0];
        child_info->chld_status = chld_status[0];
        child_info->tag_in      = -1;
-       child_info->tag_out     = gdk_input_add(chld_out[0], GDK_INPUT_READ,
-                                               catch_output, child_info);
-       child_info->tag_err     = gdk_input_add(chld_err[0], GDK_INPUT_READ,
-                                               catch_output, child_info);
+       child_info->tag_out     = claws_input_add(chld_out[0], GDK_INPUT_READ,
+                                               catch_output, child_info, FALSE);
+       child_info->tag_err     = claws_input_add(chld_err[0], GDK_INPUT_READ,
+                                               catch_output, child_info, FALSE);
 
        if (!(children->action_type &
              (ACTION_PIPE_IN | ACTION_PIPE_OUT | ACTION_INSERT)))
@@ -971,13 +1071,13 @@ static ChildInfo *fork_child(gchar *cmd, const gchar *msg_str,
                ret_str = g_locale_from_utf8(msg_str, strlen(msg_str),
                                             &by_read, &by_written, NULL);
                if (ret_str && by_written) {
-                       write(chld_in[1], ret_str, strlen(ret_str));
+                       (void)write(chld_in[1], ret_str, strlen(ret_str));
                        g_free(ret_str);
                } else
-                       write(chld_in[1], msg_str, strlen(msg_str));
+                       (void)write(chld_in[1], msg_str, strlen(msg_str));
                if (!(children->action_type &
                      (ACTION_USER_IN | ACTION_USER_HIDDEN_IN)))
-                       close(chld_in[1]);
+                       (void)close(chld_in[1]);
                child_info->chld_in = -1; /* No more input */
        }
 
@@ -1044,10 +1144,9 @@ static void send_input(GtkWidget *w, gpointer data)
        Children *children = (Children *) data;
        ChildInfo *child_info = (ChildInfo *) children->list->data;
 
-       child_info->tag_in = gdk_input_add(child_info->chld_in,
+       child_info->tag_in = claws_input_add(child_info->chld_in,
                                           GDK_INPUT_WRITE,
-                                          catch_input, children);
-       gtk_widget_set_sensitive(children->input_hbox, FALSE);
+                                          catch_input, children, FALSE);
 }
 
 static gint delete_io_dialog_cb(GtkWidget *w, GdkEvent *e, gpointer data)
@@ -1074,7 +1173,8 @@ static gint io_dialog_key_pressed_cb(GtkWidget *widget, GdkEventKey *event,
                                     gpointer data)
 {
        if (event && (event->keyval == GDK_Escape ||
-                     event->keyval == GDK_Return))
+                     event->keyval == GDK_Return ||
+                         event->keyval == GDK_KP_Enter))
                hide_io_dialog_cb(widget, data);
        return TRUE;
 }
@@ -1087,20 +1187,20 @@ static void childinfo_close_pipes(ChildInfo *child_info)
         * them if necessary
         */
        if (child_info->tag_in > 0)
-               gdk_input_remove(child_info->tag_in);
+               g_source_remove(child_info->tag_in);
        if (child_info->tag_out > 0)
-               gdk_input_remove(child_info->tag_out);
+               g_source_remove(child_info->tag_out);
        if (child_info->tag_err > 0)
-               gdk_input_remove(child_info->tag_err);
+               g_source_remove(child_info->tag_err);
 
        if (child_info->chld_in >= 0)
-               close(child_info->chld_in);
+               (void)close(child_info->chld_in);
        if (child_info->chld_out >= 0)
-               close(child_info->chld_out);
+               (void)close(child_info->chld_out);
        if (child_info->chld_err >= 0)
-               close(child_info->chld_err);
+               (void)close(child_info->chld_err);
 
-       close(child_info->chld_status);
+       (void)close(child_info->chld_status);
 }
 
 static void free_children(Children *children)
@@ -1270,8 +1370,14 @@ static void create_io_dialog(Children *children)
                g_signal_connect(G_OBJECT(entry), "activate",
                                 G_CALLBACK(send_input), children);
                gtk_box_pack_start(GTK_BOX(input_hbox), entry, TRUE, TRUE, 0);
-               if (children->action_type & ACTION_USER_HIDDEN_IN)
+               if (children->action_type & ACTION_USER_HIDDEN_IN) {
                        gtk_entry_set_visibility(GTK_ENTRY(entry), FALSE);
+#ifdef MAEMO
+                       hildon_gtk_entry_set_input_mode(GTK_ENTRY(entry), 
+                               HILDON_GTK_INPUT_MODE_FULL | 
+                               HILDON_GTK_INPUT_MODE_INVISIBLE);
+#endif
+               }
                gtk_widget_show(entry);
 
                send_button = gtk_button_new_from_stock(GTK_STOCK_EXECUTE);
@@ -1331,7 +1437,7 @@ static void catch_status(gpointer data, gint source, GdkInputCondition cond)
        gchar buf;
        gint c;
 
-       gdk_input_remove(child_info->tag_status);
+       g_source_remove(child_info->tag_status);
 
        c = read(source, &buf, 1);
        debug_print("Child returned %c\n", buf);
@@ -1402,7 +1508,10 @@ static void catch_input(gpointer data, gint source, GdkInputCondition cond)
        if (!(cond && GDK_INPUT_WRITE))
                return;
 
-       gdk_input_remove(child_info->tag_in);
+       gtk_widget_set_sensitive(children->input_hbox, FALSE);
+       gtk_widget_grab_focus(children->abort_btn);
+
+       g_source_remove(child_info->tag_in);
        child_info->tag_in = -1;
 
        input = gtk_editable_get_chars(GTK_EDITABLE(children->input_entry),
@@ -1424,13 +1533,11 @@ static void catch_input(gpointer data, gint source, GdkInputCondition cond)
        } while (c >= 0 && count < len);
 
        if (c >= 0)
-               write(child_info->chld_in, "\n", 2);
+               (void)write(child_info->chld_in, "\n", 2);
 
        g_free(input);
 
-       gtk_entry_set_text(GTK_ENTRY(children->input_entry), "");
-       gtk_widget_set_sensitive(children->input_hbox, TRUE);
-       close(child_info->chld_in);
+       (void)close(child_info->chld_in);
        child_info->chld_in = -1;
        debug_print("Input to grand child sent.\n");
 }
@@ -1503,14 +1610,14 @@ static void catch_output(gpointer data, gint source, GdkInputCondition cond)
        }
        if (c == 0) {
                if (source == child_info->chld_out) {
-                       gdk_input_remove(child_info->tag_out);
+                       g_source_remove(child_info->tag_out);
                        child_info->tag_out = -1;
-                       close(child_info->chld_out);
+                       (void)close(child_info->chld_out);
                        child_info->chld_out = -1;
                } else {
-                       gdk_input_remove(child_info->tag_err);
+                       g_source_remove(child_info->tag_err);
                        child_info->tag_err = -1;
-                       close(child_info->chld_err);
+                       (void)close(child_info->chld_err);
                        child_info->chld_err = -1;
                }
        }